- Ros-dev - ReactOS.org

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().
by Dmitry Gorbachev 17 Feb '09

17 Feb '09

Actually, no reasons were given to use extra parentheses *in this case*. Past mistakes do not justify future mistakes.

2 1

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().
by Dmitry Gorbachev 16 Feb '09

16 Feb '09

> This is just a one-off case of a silly programming error. Many such one-off cases were discovered, though not in your code. :)

1 0

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().
by Dmitry Gorbachev 16 Feb '09

16 Feb '09

Why this 'fix' is needed? For MSVC?

2 1

Re: [ros-dev] [ros-diffs] [arty] 39613: Fix loopback adapter locking and make traffic work consistently. Fix zero-address binding. Local tcp services should work now.
by Steven Edwards 16 Feb '09

16 Feb '09

Hi Arty! On Sun, Feb 15, 2009 at 4:52 PM, <arty(a)svn.reactos.org> wrote: > URL: http://svn.reactos.org/svn/reactos?rev=39613&view=rev > Log: > Fix loopback adapter locking and make traffic work consistently. > Fix zero-address binding. > Local tcp services should work now. I take this to mean telnetd should be talking on the network now? Hello remote process control and the 1980's! Thanks a lot of looking in to this. When I have time I am going to do further cleanup of telnetd and move it in to the ReactOS tree proper. Next on my list is a tftp server I found which I will attempt to get license clarification on, cleanup and add to ReactOS so that we can look in to using ReactOS tftpd to support kickstart like deployment with netboot. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 39622: - Reimplement RtlLargeIntegerToChar (based on Wine code with my changes). It fixes all large_int Wine tests
by Timo Kreuzer 16 Feb '09

16 Feb '09

This is yet another time where SEH is misused in user mode. Yes, you can see from OpenRCE call chains that ms is using SEH in that function, too. But the way it's used is not a good idea. EXCEPTION_EXECUTE_HANDLER eats all exceptions, including guard pages, invalid opcodes, etc. That's probably not what you want. For everyone wanting to use SEH in user mode I suggest reading this article: http://blogs.msdn.com/oldnewthing/archive/2006/09/27/773741.aspx Thanks, Timo dchapyshev(a)svn.reactos.org schrieb: > Author: dchapyshev > Date: Mon Feb 16 06:07:27 2009 > New Revision: 39622 > > URL: http://svn.reactos.org/svn/reactos?rev=39622&view=rev > Log: > - Reimplement RtlLargeIntegerToChar (based on Wine code with my changes). It fixes all large_int Wine tests > > Modified: > trunk/reactos/lib/rtl/unicode.c > > Modified: trunk/reactos/lib/rtl/unicode.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/unicode.c?rev=3962… > ============================================================================== > --- trunk/reactos/lib/rtl/unicode.c [iso-8859-1] (original) > +++ trunk/reactos/lib/rtl/unicode.c [iso-8859-1] Mon Feb 16 06:07:27 2009 > @@ -1559,56 +1559,56 @@ > IN ULONG Length, > IN OUT PCHAR String) > { > - NTSTATUS Status = STATUS_SUCCESS; > - ULONG Radix; > - CHAR temp[65]; > - ULONGLONG v = Value->QuadPart; > - ULONG i; > - PCHAR tp; > - PCHAR sp; > - > - Radix = Base; > - if (Radix == 0) > - Radix = 10; > - > - if ((Radix != 2) && (Radix != 8) && > - (Radix != 10) && (Radix != 16)) > - return STATUS_INVALID_PARAMETER; > - > - tp = temp; > - while (v || tp == temp) > - { > - i = v % Radix; > - v = v / Radix; > - if (i < 10) > - *tp = i + '0'; > - else > - *tp = i + 'A' - 10; > - tp++; > - } > - > - if ((ULONG)((ULONG_PTR)tp - (ULONG_PTR)temp) > Length) > - return STATUS_BUFFER_OVERFLOW; > - > - //_SEH2_TRY > - { > - sp = String; > - while (tp > temp) > - *sp++ = *--tp; > - > - if((ULONG)((ULONG_PTR)sp - (ULONG_PTR)String) < Length) > - *sp = 0; > - } > -#if 0 > - _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > - { > - /* Get the error code */ > - Status = _SEH2_GetExceptionCode(); > - } > - _SEH2_END; > -#endif > - > - return Status; > + ULONGLONG Val = Value->QuadPart; > + NTSTATUS Status = STATUS_SUCCESS; > + CHAR Buffer[65]; > + CHAR Digit; > + ULONG Len; > + PCHAR Pos; > + > + if (Base == 0) Base = 10; > + > + if ((Base != 2) && (Base != 8) && > + (Base != 10) && (Base != 16)) > + { > + return STATUS_INVALID_PARAMETER; > + } > + > + Pos = &Buffer[64]; > + *Pos = '\0'; > + > + do > + { > + Pos--; > + Digit = Val % Base; > + Val = Val / Base; > + if (Digit < 10) > + *Pos = '0' + Digit; > + else > + *Pos = 'A' + Digit - 10; > + } > + while (Val != 0L); > + > + Len = &Buffer[64] - Pos; > + > + if (Len > Length) > + return STATUS_BUFFER_OVERFLOW; > + > + _SEH2_TRY > + { > + if (Len == Length) > + RtlCopyMemory(String, Pos, Len); > + else > + RtlCopyMemory(String, Pos, Len + 1); > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + /* Get the error code */ > + Status = _SEH2_GetExceptionCode(); > + } > + _SEH2_END; > + > + return Status; > } > > /* > > >

1 0

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().
by Dmitry Gorbachev 16 Feb '09

16 Feb '09

> By reformatting my code and breaking ReactOS > 1) Coding Style and 2) Commit Rules? I'm not sure, what, exactly, it breaks?

2 1

[ros-diffs] [khornicek] 39617: - add more pixel formats
by James Tabor 16 Feb '09

16 Feb '09

Hi, I know this is in a branch, but~ WINAPI DdUnlock(LPDDHAL_UNLOCKDATA Unlock) { + /* Fixme for opengl hel emulations */ + HEL_OGL_STUB; +#if 0 /* Call win32k */ return NtGdiDdUnlock((HANDLE)Unlock->lpDDSurface->hDDSurface, (PDD_UNLOCKDATA)Unlock); +#endif } It is a direct call and this is correct. Why if it out? Don't add non standard functionality to the gdi interface unless this is a upgrade from XP. Thanks, James

2 1

RosBE-Unix 1.4 is out!
by Colin Finck 14 Feb '09

14 Feb '09

Hello everyone, A new release of RosBE-Unix is finally available. It mostly features updated build tools compatible to the versions used in RosBE-Windows 1.4 and initial multi-architecture support through additional RosBE-Unix packages (which still don't exist though :P) I highly recommend the update, because our previous binutils contains a critical bug in dlltool. (see http://sourceware.org/bugzilla/show_bug.cgi?id=9766 for details) Some components affected by that bug were our msvcrt*.dll and mapi32.dll. The new release is now available from SourceForge, just like RosBE-Windows (https://sourceforge.net/project/showfiles.php?group_id=6553&package_id=3084 58) Best regards, Colin

1 0

Forwarding functions to a file with a non-dll extension
by Colin Finck 14 Feb '09

14 Feb '09

Hello everyone, Recently, the problem came up that Wine's spoolss.dll tries to forward its "EnumPortsW" function to the similar function in winspool.drv. Wine added a forward entry "winspool.drv.EnumPortsW" for this reason. Unfortunately, such forwarders weren't supported by binutils, thus Christoph opened this bug for them: http://sourceware.org/bugzilla/show_bug.cgi?id=9811 The provided patch now makes such entries possible in the .def file, but that still doesn't help as Windows' and ReactOS' ntdll both forward to .dll files only. So after all, this non-dll forwarding thing seems to be a Wine invention we cannot support and have to avoid when importing Wine stuff. Additionally, the proposed patch on the binutils Bugzilla won't find its way into RosBE now. Best regards, Colin

1 0

fosdem
by Ged 14 Feb '09

14 Feb '09

Considering about 6 of you went to FOSDEM, is anyone actually gonna release any info about what happened? If I am completely unaware, I can imagine how expectant users feel Communication is really terrible. Ged.

3 4

Re: [ros-dev] [ros-diffs] [dchapyshev] 39580: - Add LCIDToLocaleName from Wine. Used by Wine Gecko
by Aleksey Bragin 14 Feb '09

14 Feb '09

Wine's Gecko shouldn't rely on non-exported functions... On Feb 13, 2009, at 3:04 PM, dchapyshev(a)svn.reactos.org wrote: > Author: dchapyshev > Date: Fri Feb 13 06:04:20 2009 > New Revision: 39580 > > URL: http://svn.reactos.org/svn/reactos?rev=39580&view=rev > Log: > - Add LCIDToLocaleName from Wine. Used by Wine Gecko > > Modified: > trunk/reactos/dll/win32/kernel32/kernel32.spec > trunk/reactos/dll/win32/kernel32/misc/lang.c

5 8

Re: [ros-dev] [ros-diffs] [tkreuzer] 39558: Implement hpp - the header preprocessor It can parse headers and create new headers from them based on a simple prepreprocessing language that's compatible with the C preprocessor, so the source file stays a valid header. It works, but doesn't yet support different folders.
by Aleksey Bragin 13 Feb '09

13 Feb '09

Please add a standard header, with license information. On Feb 11, 2009, at 11:37 PM, tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Wed Feb 11 14:37:25 2009 > New Revision: 39558 > > URL: http://svn.reactos.org/svn/reactos?rev=39558&view=rev > Log: > Implement hpp - the header preprocessor > It can parse headers and create new headers from them based on a > simple prepreprocessing language that's compatible with the C > preprocessor, so the source file stays a valid header. It works, > but doesn't yet support different folders. > > Added: > trunk/reactos/tools/hpp/ (with props) > trunk/reactos/tools/hpp/hpp.c (with props) > trunk/reactos/tools/hpp/hpp.rbuild (with props) > > Propchange: trunk/reactos/tools/hpp/ > ---------------------------------------------------------------------- > -------- > svn:mergeinfo = > > Added: trunk/reactos/tools/hpp/hpp.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/hpp/ > hpp.c?rev=39558&view=auto > ====================================================================== > ======== > --- trunk/reactos/tools/hpp/hpp.c (added) > +++ trunk/reactos/tools/hpp/hpp.c [iso-8859-1] Wed Feb 11 14:37:25 > 2009 > @@ -1,0 +1,509 @@ > +#include <stdio.h>

1 0

Re: [ros-dev] [ros-diffs] [fireball] 39578: Igor Koshpaev <tower@reactos.org> - Include missing modules into bootcd
by Timo Kreuzer 13 Feb '09

13 Feb '09

fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Fri Feb 13 05:20:59 2009 > New Revision: 39578 > > URL: http://svn.reactos.org/svn/reactos?rev=39578&view=rev > Log: > Igor Koshpaev <tower(a)reactos.org> > - Include missing modules into bootcd > ... > +modules\rostests\apitests\w32kdll\w32kdll_2k3sp2\w32kdll_2k3sp2.dll 1 optional > +modules\rostests\apitests\w32kdll\w32kdll_2ksp4\w32kdll_2ksp4.dll 1 optional > ... > +modules\rostests\apitests\w32kdll\w32kdll_xpsp2\w32kdll_xpsp2.dll 1 optional > These make no sense on reactos. They only work on the respective OS.

2 1

Re: [ros-dev] [ros-diffs] [tkreuzer] 39533: x64 version of ntoskrnl doesn't export ExInterlockedAddLargeStatistic
by Steven Edwards 11 Feb '09

11 Feb '09

Does the pspec here use Winebuild? Sorry I can't check at the moment. If it does, the current winebuild allows you to specify exports for a given arch by passing -arch=cpu in the spec file. On Tue, Feb 10, 2009 at 10:15 AM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Tue Feb 10 09:15:07 2009 > New Revision: 39533 > > URL: http://svn.reactos.org/svn/reactos?rev=39533&view=rev > Log: > x64 version of ntoskrnl doesn't export ExInterlockedAddLargeStatistic > > Modified: > branches/ros-amd64-bringup/reactos/ntoskrnl/ntoskrnl.pspec > > Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/ntoskrnl.pspec > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk… > ============================================================================== > --- branches/ros-amd64-bringup/reactos/ntoskrnl/ntoskrnl.pspec [iso-8859-1] (original) > +++ branches/ros-amd64-bringup/reactos/ntoskrnl/ntoskrnl.pspec [iso-8859-1] Tue Feb 10 09:15:07 2009 > @@ -104,7 +104,9 @@ > @ stdcall ExInitializeRundownProtectionCacheAware(ptr long) > @ stdcall ExInitializeZone(ptr long ptr long) > @ stdcall ExInterlockedAddLargeInteger(ptr long long ptr) > +#ifndef __x86_64__ > @ fastcall ExInterlockedAddLargeStatistic(ptr long) > +#endif > @ stdcall ExInterlockedAddUlong(ptr long ptr) > #ifndef __x86_64__ > @ fastcall ExInterlockedCompareExchange64(ptr ptr ptr ptr) > > -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 3

Development Tools for ReactOS
by Deepak Gupta 10 Feb '09

10 Feb '09

Folks, I don't know where to ask this question, So decided to ask it on Dev mailing list. I am new to ReactOS and installed it on VMWare workstation and really loved it. It's behavior look and feel is like Windows and I really appreciate it (although there is long way to for it) Few of my questions are below:-- 1) Is there any development kit for developing applications for ReactOS? 2) If not, Will Applications developed using Windows SDK (not .net framework and all, just plain SDK) will work on ReactOS? 3) If Apps developed on Windows works on ReactOS, Are libraries developed for Windows (which just depend on kernel32, user32 and other system dlls) will work on ReactOS? I am planning to use ReactOS for one of my custom device (using x86 based processor) and want to develop some applications on top of it. Regards Deepak

2 2

Public ddk headers vs ntoskrnl
by Timo Kreuzer 10 Feb '09

10 Feb '09

Hi, I am currently having a small problem on the x64 branch, maybe someone can help me. In wdm.h there's the following declarations: #if defined (_WIN64) #if defined(_NTDRIVER_) || defined(_NTDDK) || defined(_NTIFS_) || \ defined(_NTHAL_) || defined(_NTOSP_) NTKRNLAPI USHORT ExQueryDepthSList(IN PSLIST_HEADER Listhead); #else FORCEINLINE USHORT ExQueryDepthSList(IN PSLIST_HEADER Listhead) { return (USHORT)(ListHead->Alignment & 0xffff); } #endif #else #define ExQueryDepthSList(listhead) (listhead)->Depth #endif So when compiling ntoskrnl, ExQueryDepthSList is not inlined. Later in wdm.h (currently in our winddk.h, but to be moved to wdm.h) ExQueryDepthSList is used in ExFreeToNPagedLookasideList inline function. But I want ExQueryDepthSList to be inlined from within ntoskrnl. The question is how can I achieve this? If I #define it to be inline in ntoskrnl's private headers, it will not affect ExFreeToNPagedLookasideList. When I declare it as an inline function after the header is included, I get a warning that it was declared inline after being used and that a static declaration follows a non-static. (Does anyone know hoe to disable these stupid warnings?) Declaring it inline before including wdm.h doesn't work, as the needed declaration for SLIST_HEADER is missing. Anyone got any other idea? I'd like to avoid hacking our public headers, to keep them as compatible to ms headers as possible. Regards, Timo

2 1

Re: [ros-dev] [ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().
by Alex Ionescu 08 Feb '09

08 Feb '09

By reformatting my code and breaking ReactOS 1) Coding Style and 2) Commit Rules? On 5-Feb-09, at 4:30 PM, dgorbachev(a)svn.reactos.org wrote: > Author: dgorbachev > Date: Thu Feb 5 15:30:21 2009 > New Revision: 39422 > > URL: http://svn.reactos.org/svn/reactos?rev=39422&view=rev > Log: > Fix bug #4129 in CmpGetNameControlBlock(). > > Modified: > trunk/reactos/ntoskrnl/config/cmkcbncb.c > > Modified: trunk/reactos/ntoskrnl/config/cmkcbncb.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmkcbncb.c… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/config/cmkcbncb.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/config/cmkcbncb.c [iso-8859-1] Thu Feb 5 > 15:30:21 2009 > @@ -175,15 +175,16 @@ > Length = NodeName->Length / sizeof(WCHAR); > for (i = 0; i < (NodeName->Length / sizeof(WCHAR)); i++) > { > - /* Check if this is a valid character */ > - if (*NodeName->Buffer > (UCHAR)-1) > + /* Check if this is a 16-bit character */ > + if (NodeName->Buffer[i] > (UCHAR)-1) > { > /* This is the actual size, and we know we're not > compressed */ > Length = NodeName->Length; > IsCompressed = FALSE; > - } > - } > - > + break; > + } > + } > + > /* Lock the NCB entry */ > CmpAcquireNcbLockExclusiveByKey(ConvKey); > > @@ -195,7 +196,7 @@ > Ncb = CONTAINING_RECORD(HashEntry, CM_NAME_CONTROL_BLOCK, > NameHash); > > /* Check if the hash matches */ > - if ((ConvKey = HashEntry->ConvKey) && (Length = Ncb- > >NameLength)) > + if (ConvKey == HashEntry->ConvKey && Length == Ncb- > >NameLength) > { > /* Assume success */ > Found = TRUE; > @@ -242,7 +243,7 @@ > /* Go to the next hash */ > HashEntry = HashEntry->NextHash; > } > - > + > /* Check if we didn't find it */ > if (!Found) > { > @@ -255,16 +256,15 @@ > CmpReleaseNcbLockByKey(ConvKey); > return NULL; > } > - > + > /* Clear it out */ > RtlZeroMemory(Ncb, NcbSize); > - > + > /* Check if the name was compressed */ > if (IsCompressed) > { > /* Copy the compressed name */ > - Ncb->Compressed = TRUE; > - for (i = 0; i < Length; i++) > + for (i = 0; i < NodeName->Length / sizeof(WCHAR); i++) > { > /* Copy Unicode to ANSI */ > ((PCHAR)Ncb->Name)[i] = > (CHAR)RtlUpcaseUnicodeChar(NodeName->Buffer[i]); > @@ -273,25 +273,25 @@ > else > { > /* Copy the name directly */ > - Ncb->Compressed = FALSE; > - for (i = 0; i < Length; i++) > + for (i = 0; i < NodeName->Length / sizeof(WCHAR); i++) > { > /* Copy each unicode character */ > Ncb->Name[i] = RtlUpcaseUnicodeChar(NodeName- > >Buffer[i]); > } > } > - > + > /* Setup the rest of the NCB */ > + Ncb->Compressed = IsCompressed; > Ncb->ConvKey = ConvKey; > Ncb->RefCount++; > Ncb->NameLength = Length; > - > + > /* Insert the name in the hash table */ > HashEntry = &Ncb->NameHash; > HashEntry->NextHash = GET_HASH_ENTRY(CmpNameCacheTable, > ConvKey).Entry; > GET_HASH_ENTRY(CmpNameCacheTable, ConvKey).Entry = HashEntry; > } > - > + > /* Release NCB lock */ > CmpReleaseNcbLockByKey(ConvKey); > > @@ -537,18 +537,18 @@ > } > > /* Check if there's no linked cell */ > - if (Kcb->KeyCell == HCELL_NIL) > + if (Kcb->KeyCell == HCELL_NIL) > { > /* Make sure it's a delete */ > - ASSERT(Kcb->Delete); > - KeyNode = NULL; > - } > + ASSERT(Kcb->Delete); > + KeyNode = NULL; > + } > else > { > /* Get the key node */ > - KeyNode = (PCM_KEY_NODE)HvGetCell(Kcb->KeyHive, Kcb->KeyCell); > - } > - > + KeyNode = (PCM_KEY_NODE)HvGetCell(Kcb->KeyHive, Kcb- > >KeyCell); > + } > + > /* Check if we got the node */ > if (!KeyNode) > { > @@ -561,7 +561,7 @@ > Kcb->ExtFlags &= ~CM_KCB_INVALID_CACHED_INFO; > Kcb->SubKeyCount = KeyNode->SubKeyCounts[Stable] + > KeyNode->SubKeyCounts[Volatile]; > - > + > /* Release the cell */ > HvReleaseCell(Kcb->KeyHive, Kcb->KeyCell); > } > @@ -865,12 +865,12 @@ > } > > /* Check if this is a KCB inside a frozen hive */ > - if ((Kcb) && (((PCMHIVE)Hive)->Frozen) && (!(Kcb->Flags & > KEY_SYM_LINK))) > + if ((Kcb) && (((PCMHIVE)Hive)->Frozen) && (!(Kcb->Flags & > KEY_SYM_LINK))) > { > /* Don't add these to the delay close */ > - Kcb->ExtFlags |= CM_KCB_NO_DELAY_CLOSE; > - } > - > + Kcb->ExtFlags |= CM_KCB_NO_DELAY_CLOSE; > + } > + > /* Sanity check */ > ASSERT((!Kcb) || (Kcb->Delete == FALSE)); > > Best regards, Alex Ionescu

1 0

Re: [ros-dev] [ros-diffs] [janderwald] 39459: - Add a hack
by Timo Kreuzer 07 Feb '09

07 Feb '09

Very descriptive commit message ;-) janderwald(a)svn.reactos.org schrieb: > Author: janderwald > Date: Sat Feb 7 09:43:14 2009 > New Revision: 39459 > > URL: http://svn.reactos.org/svn/reactos?rev=39459&view=rev > Log: > - Add a hack > > Modified: > trunk/reactos/base/system/services/config.c > trunk/reactos/base/system/services/rpcserver.c > > Modified: trunk/reactos/base/system/services/config.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/services/confi… > ============================================================================== > --- trunk/reactos/base/system/services/config.c [iso-8859-1] (original) > +++ trunk/reactos/base/system/services/config.c [iso-8859-1] Sat Feb 7 09:43:14 2009 > @@ -289,7 +289,7 @@ > *lpValue = ptr; > } > > -done:; > +done: > if (dwError != ERROR_SUCCESS) > { > HeapFree(GetProcessHeap(), 0, ptr); > > Modified: trunk/reactos/base/system/services/rpcserver.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/services/rpcse… > ============================================================================== > --- trunk/reactos/base/system/services/rpcserver.c [iso-8859-1] (original) > +++ trunk/reactos/base/system/services/rpcserver.c [iso-8859-1] Sat Feb 7 09:43:14 2009 > @@ -4012,33 +4012,36 @@ > > if (InfoW.dwInfoLevel == SERVICE_CONFIG_DESCRIPTION) > { > - LPSERVICE_DESCRIPTIONW lpServiceDesriptonW; > - LPSERVICE_DESCRIPTIONA lpServiceDesriptonA; > - > - lpServiceDesriptonA = Info.psd; > - > - if (lpServiceDesriptonA && > - lpServiceDesriptonA->lpDescription) > - { > - dwLength = (strlen(lpServiceDesriptonA->lpDescription) + 1) * sizeof(WCHAR); > - > - lpServiceDesriptonW = HeapAlloc(GetProcessHeap(), > + LPSERVICE_DESCRIPTIONW lpServiceDescriptonW; > + LPSERVICE_DESCRIPTIONA lpServiceDescriptonA; > + > + lpServiceDescriptonA = Info.psd; > + > + ///if (lpServiceDescriptonA && > + ///lpServiceDescriptonA->lpDescription) > + ///{ > + dwLength = (strlen(Info.lpDescription) + 1) * sizeof(WCHAR); > + > + lpServiceDescriptonW = HeapAlloc(GetProcessHeap(), > 0, > dwLength + sizeof(SERVICE_DESCRIPTIONW)); > - if (!lpServiceDesriptonW) > + if (!lpServiceDescriptonW) > { > return ERROR_NOT_ENOUGH_MEMORY; > } > > + lpServiceDescriptonW->lpDescription = (LPWSTR)(lpServiceDescriptonW + 1); > + > MultiByteToWideChar(CP_ACP, > 0, > - lpServiceDesriptonA->lpDescription, > + Info.lpDescription, > -1, > - lpServiceDesriptonW->lpDescription, > + lpServiceDescriptonW->lpDescription, > dwLength); > > - ptr = lpServiceDesriptonW; > - } > + ptr = lpServiceDescriptonW; > + InfoW.psd = lpServiceDescriptonW; > + ///} > } > else if (Info.dwInfoLevel == SERVICE_CONFIG_FAILURE_ACTIONS) > { > @@ -4162,12 +4165,13 @@ > { > LPSERVICE_DESCRIPTIONW lpServiceDescription; > > - lpServiceDescription = (LPSERVICE_DESCRIPTIONW)&Info; > - lpServiceDescription->lpDescription = (LPWSTR)(&Info + sizeof(LPSERVICE_DESCRIPTIONW)); > + lpServiceDescription = (LPSERVICE_DESCRIPTIONW)Info.psd; > + lpServiceDescription->lpDescription = (LPWSTR)((ULONG_PTR)lpServiceDescription + sizeof(LPSERVICE_DESCRIPTIONW)); > > if (lpServiceDescription != NULL && > lpServiceDescription->lpDescription != NULL) > { > + DPRINT1("Setting value %S\n", lpServiceDescription->lpDescription); > RegSetValueExW(hServiceKey, > L"Description", > 0, > @@ -4212,7 +4216,7 @@ > LPWSTR lpDescriptionW = NULL; > LPSTR lpDescription = NULL; > > - DPRINT("RQueryServiceConfig2W() called\n"); > + DPRINT1("RQueryServiceConfig2A() called hService %p dwInfoLevel %u, lpBuffer %p cbBufSize %u pcbBytesNeeded %p\n",hService, dwInfoLevel, lpBuffer, cbBufSize, pcbBytesNeeded); > > if (!lpBuffer) > return ERROR_INVALID_ADDRESS; > @@ -4261,7 +4265,7 @@ > &lpDescriptionW); > if (dwError == ERROR_SUCCESS) > { > - *pcbBytesNeeded += ((wcslen(lpDescriptionW) + 1)); > + *pcbBytesNeeded += ((wcslen(lpDescriptionW) + 1) * sizeof(WCHAR)); > } > > if (cbBufSize >= *pcbBytesNeeded) > > >

1 0

Re: [ros-dev] [ros-diffs] [cfinck] 39353: Gabriel Ilardi (gabrielilardi@hotmail.it) - Allow only one instance of Task-Manager to be run at the same time See issue #3976 for more details.
by Alex Ionescu 04 Feb '09

04 Feb '09

This won't be compatible with Windows applications. On 3-Feb-09, at 5:25 PM, cfinck(a)svn.reactos.org wrote: > Author: cfinck > Date: Tue Feb 3 16:25:39 2009 > New Revision: 39353 > > URL: http://svn.reactos.org/svn/reactos?rev=39353&view=rev > Log: > Gabriel Ilardi (gabrielilardi(a)hotmail.it) > - Allow only one instance of Task-Manager to be run at the same time > > See issue #3976 for more details. > > Modified: > trunk/reactos/base/applications/taskmgr/taskmgr.c > > Modified: trunk/reactos/base/applications/taskmgr/taskmgr.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/taskmgr/… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/base/applications/taskmgr/taskmgr.c [iso-8859-1] > (original) > +++ trunk/reactos/base/applications/taskmgr/taskmgr.c [iso-8859-1] > Tue Feb 3 16:25:39 2009 > @@ -51,6 +51,12 @@ > HANDLE hProcess; > HANDLE hToken; > TOKEN_PRIVILEGES tkp; > + HANDLE hMutex; > + > + /* check wether we're already running or not */ > + hMutex = CreateMutexW(NULL, TRUE, L"taskmgrros"); > + if ((!hMutex) || (GetLastError() == ERROR_ALREADY_EXISTS)) > + return 1; > > /* Initialize global variables */ > hInst = hInstance; > Best regards, Alex Ionescu

4 3

Re : [Qemu-devel] Virtio ballon device always loaded ?
by Sylvain Petreolle 31 Jan '09

31 Jan '09

Forwarded to ReactOS mailing list. (using correct address this time :) ----- Message d'origine ---- > De : Anthony Liguori <anthony(a)codemonkey.ws> > À : qemu-devel(a)nongnu.org > Envoyé le : Jeudi, 29 Janvier 2009, 22h55mn 12s > Objet : Re: [Qemu-devel] Virtio ballon device always loaded ? > > Sylvain Petreolle wrote: > > Testing ReactOS in qemu made it always asking drivers for a RAM Controller. > > > > Looking at "info pci" output and hw/pc.c, I see that the Virtio balloon device > is always loaded in an x86/64 target. > > Is that a wanted feature ? > > > > Sure, as I see no harm in not enabling it by default. ReactOS doesn't > just ignore unknown PCI devices? That's strange because Windows seems to. > > Regards, > > Anthony Liguori > > > I also notice that hw/virtio-balloon.c header refers to the Virtio Block > Device. > > > > Kind regards, > > Sylvain Petreolle > > > > > > > >

1 0

[ros-diffs] [gschneider] 39217: Unify identical StretchBlt implementations in preparation of partial ROP suppport.
by James Tabor 31 Jan '09

31 Jan '09

Hi! Don't forget the Bug report number this is related to... Bolt aka BSTSoft is working hard on fixing this. Thanks, James Ref: http://www.reactos.org/bugzilla/show_bug.cgi?id=4075

1 0

Re: [ros-dev] [ros-diffs] [cfinck] 39186: - Set "lake.bmp" as the default wallpaper - Add a shortcut to "Download !" to the Desktop
by Ged 29 Jan '09

29 Jan '09

Btw, there are some really nice wallpapers in the forums, much nicer than the lake.bmp we keep using. Just a thought. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of cfinck(a)svn.reactos.org Sent: 28 January 2009 20:18 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [cfinck] 39186: - Set "lake.bmp" as the default wallpaper - Add a shortcut to "Download !" to the Desktop Author: cfinck Date: Wed Jan 28 14:17:33 2009 New Revision: 39186 URL: http://svn.reactos.org/svn/reactos?rev=39186&view=rev Log: - Set "lake.bmp" as the default wallpaper - Add a shortcut to "Download !" to the Desktop Modified: branches/ros-branch-0_3_8/reactos/boot/bootdata/hivedef_i386.inf branches/ros-branch-0_3_8/reactos/dll/win32/syssetup/install.c Modified: branches/ros-branch-0_3_8/reactos/boot/bootdata/hivedef_i386.inf URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_8/reactos/boot/b… ============================================================================== --- branches/ros-branch-0_3_8/reactos/boot/bootdata/hivedef_i386.inf [iso-8859-1] (original) +++ branches/ros-branch-0_3_8/reactos/boot/bootdata/hivedef_i386.inf [iso-8859-1] Wed Jan 28 14:17:33 2009 @@ -20,7 +20,7 @@ HKCU,"Control Panel\Desktop","HungAppTimeout",0x00000002,"5000" HKCU,"Control Panel\Desktop","SCRNSAVE.EXE",0x00000000,"" HKCU,"Control Panel\Desktop","WaitToKillAppTimeout",0x00000002,"20000" -HKCU,"Control Panel\Desktop","Wallpaper",0x00000000,"" +HKCU,"Control Panel\Desktop","Wallpaper",0x00000000,"%SystemRoot%\lake.bmp" HKCU,"Control Panel\International",,0x00000012 HKCU,"Control Panel\International","Locale",0x00000000,"0409" HKCU,"Control Panel\International\Geo","Nation",0x00000000,"1" Modified: branches/ros-branch-0_3_8/reactos/dll/win32/syssetup/install.c URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_8/reactos/dll/wi… ============================================================================== --- branches/ros-branch-0_3_8/reactos/dll/win32/syssetup/install.c [iso-8859-1] (original) +++ branches/ros-branch-0_3_8/reactos/dll/win32/syssetup/install.c [iso-8859-1] Wed Jan 28 14:17:33 2009 @@ -756,6 +756,7 @@ /* Create desktop shortcuts */ CreateShortcut(CSIDL_DESKTOP, NULL, IDS_SHORT_CMD, _T("%SystemRoot%\\system32\\cmd.exe"), IDS_CMT_CMD, TRUE); + CreateShortcut(CSIDL_DESKTOP, NULL, IDS_SHORT_DOWNLOADER, _T("%SystemRoot%\\system32\\downloader.exe"), IDS_CMT_DOWNLOADER, TRUE); /* Create program startmenu shortcuts */ CreateShortcut(CSIDL_PROGRAMS, NULL, IDS_SHORT_EXPLORER, _T("%SystemRoot%\\explorer.exe"), IDS_CMT_EXPLORER, TRUE);

8 19

Re: [ros-dev] [ros-diffs] [cfinck] 39186: - Set "lake.bmp" as the default wallpaper - Add a shortcut to "Download !" to the Desktop
by Marc Piulachs 29 Jan '09

29 Jan '09

Why bother when there are tons of free high quality wallpapers to choose from? We could use a simple but elegant abstract wallpaper rather than trying to imitate Vista or the iPhone like for example: http://www.gnome-look.org/content/show.php/Focus+GNU+Linux?content=94090 http://www.gnome-look.org/content/show.php/Flow?content=71058 http://www.gnome-look.org/content/show.php/Why+not?content=93589 My personal favourite: http://www.gnome-look.org/content/show.php/Colored+Particles+Wallpaper?cont… Regards, Marc -------------------------------------------------- From: "KJK::Hyperion" <hackbunny(a)reactos.com> Sent: Thursday, January 29, 2009 12:52 PM To: "ReactOS Development List" <ros-dev(a)reactos.org> Subject: Re: [ros-dev] [ros-diffs] [cfinck] 39186: - Set "lake.bmp" as the default wallpaper - Add a shortcut to "Download !" to the Desktop > Ged wrote: >> We'd need an alpha fish instead of a betta (Siamese fighter) >> ;) > > What about a betta youngling? This is actually pretty clever. I know a > semi-pro photographer. I could ask him > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

2 1

Re: [ros-dev] Ros-dev Digest, Vol 53, Issue 30
by Olaf Siejka 29 Jan '09

29 Jan '09

"Please test them, especially with the applications in Downloader, and write your results to http://www.reactos.org/wiki/index.php/Tests_for_0.3.8" I have a suggestion - we should limit the amount of people that are allowed to actually write the results to some designated people and let everyone pass the results to them.

1 0

0.3.8 Test Season has started :-)
by Colin Finck 28 Jan '09

28 Jan '09

Hello everybody (and especially the testers), After nobody complained about branching 0.3.8 from trunk now, I took the initiative today and prepared the branch with our usual customizations and hacks. It's now again the time for application testing. Therefore I uploaded Boot CD and Live CD of the current branch to http://reactos.colinfinck.de/ Please test them, especially with the applications in Downloader, and write your results to http://www.reactos.org/wiki/index.php/Tests_for_0.3.8 I especially write this now, because we want the release to be ready some days before FOSDEM. Andrew wants to start burning the CDs for FOSDEM soon, so it would be great if we could get the entire release done till *next Monday*. Best regards, Colin

1 0

[ros-diffs] [cfinck] 39188: Hack: Copy the toolbar image on our own instead of using CopyImage to hackfix the messed up toolbar graphics as it was done for previous releases.
by James Tabor 28 Jan '09

28 Jan '09

Hi! This is what I've been fighting (BITMAP) with! I should have read this in previous releases. Take note! Thanks, James --- branches/ros-branch-0_3_8/reactos/dll/win32/comctl32/toolbar.c [iso-8859-1] (original) +++ branches/ros-branch-0_3_8/reactos/dll/win32/comctl32/toolbar.c [iso-8859-1] Wed Jan 28 15:11:36 2009 @@ -2659,7 +2659,33 @@ TRACE("adding hInst=%p nID=%d nButtons=%d\n", bitmap->hInst, bitmap->nID, bitmap->nButtons); /* Add bitmaps to the default image list */ if (bitmap->hInst == NULL) /* a handle was passed */ - hbmLoad = CopyImage(ULongToHandle(bitmap->nID), IMAGE_BITMAP, 0, 0, 0); + { + BITMAP bmp; + HBITMAP hOldBitmapBitmap, hOldBitmapLoad; + HDC hdcImage, hdcBitmap; + + /* copy the bitmap before adding it so that the user's bitmap + * doesn't get modified. + */ + GetObjectW ((HBITMAP)bitmap->nID, sizeof(BITMAP), (LPVOID)&bmp); + + hdcImage = CreateCompatibleDC(0); + hdcBitmap = CreateCompatibleDC(0); + + /* create new bitmap */ + hbmLoad = CreateBitmap (bmp.bmWidth, bmp.bmHeight, bmp.bmPlanes, bmp.bmBitsPixel, NULL); + hOldBitmapBitmap = SelectObject(hdcBitmap, (HBITMAP)bitmap->nID); + hOldBitmapLoad = SelectObject(hdcImage, hbmLoad); + + /* Copy the user's image */ + BitBlt (hdcImage, 0, 0, bmp.bmWidth, bmp.bmHeight, + hdcBitmap, 0, 0, SRCCOPY); + + SelectObject (hdcImage, hOldBitmapLoad); + SelectObject (hdcBitmap, hOldBitmapBitmap); + DeleteDC (hdcImage); + DeleteDC (hdcBitmap); + } else hbmLoad = CreateMappedBitmap(bitmap->hInst, bitmap->nID, 0, NULL, 0);

1 0

winetest note
by Ged 28 Jan '09

28 Jan '09

I've been using the Winetests in Windows quite a lot recently, both XP and Vista, and I've noticed that a lot of the tests fail in Windows. For anyone using the Winetests in reactos to fix our code, it's worth testing if these functions pass or fail in Windows first as we might be breaking reactos to pass the winetests. Also, one of the problems I've noticed is that some tests fail on XP but pass in Vista, and vice versa. Does anyone know Wine's target OS? It seems that more tests are passing in Vista than XP these days, so maybe they've moved to a more recent target? I think the best way to move forward with this is to find out what version Wine target, fix any broken tests we come across and submit them to Wine. I don't envisage any problem with Wine accepting fixed test cases, even from the most hated of reactos devs. Anyway, I just wanted to make people aware, _don't blindly trust Winetests when fixing reactos_ Ged.

2 1

Re: [ros-dev] [ros-diffs] [hyperion] 39111: Begin moving rules out of modulehandler.cpp and into makefile include rules.mak, where they will be more readable and manageable.
by Timo Kreuzer 26 Jan '09

26 Jan '09

If you are going to do more work on rbuild, I'd suggest doing it in a branch to avoid clean rebuilds every few revisions. Timo hyperion(a)svn.reactos.org schrieb: > Author: hyperion > Date: Mon Jan 26 08:26:15 2009 > New Revision: 39111 > > URL: http://svn.reactos.org/svn/reactos?rev=39111&view=rev > Log: > Begin moving rules out of modulehandler.cpp and into makefile include rules.mak, where they will be more readable and manageable. Currently implemented: target C compiler and target C++ compiler rules. Please do a clean build if possible. Testing with unusual output paths appreciated > >

3 2

TEB
by James Tabor 24 Jan '09

24 Jan '09

Hi, The TEB in psdk/winternl.h does not match with the correct one in ndk/pstypes.h. Does anyone else see that as a problem or is it just me? If it is for wine, then it is wrong, need to implement it as it is in the SDK. Use it for the Tls fields only...... Thanks, James

2 1

Re: [ros-dev] [ros-diffs] [pschweitzer] 39040: Added notifications stuff to VCB
by Pierre SCHWEITZER 23 Jan '09

23 Jan '09

A general remark for this revision and r39033. FsRtlNotifyInitializeSync and CcInitializeCacheMap both raise exception in case of failure, instead of returning a status. Should we consider adding PSEH support and usage to the new driver? P. Schweitzer > Date: Fri, 23 Jan 2009 12:18:39 +0000 > To: ros-diffs(a)reactos.org > From: pschweitzer(a)svn.reactos.org > Subject: [ros-diffs] [pschweitzer] 39040: Added notifications stuff to VCB > > Author: pschweitzer > Date: Fri Jan 23 06:18:38 2009 > New Revision: 39040 > > URL: http://svn.reactos.org/svn/reactos?rev=39040&view=rev > Log: > Added notifications stuff to VCB > > Modified: > trunk/reactos/drivers/filesystems/fastfat_new/fat.c > trunk/reactos/drivers/filesystems/fastfat_new/fatstruc.h > _________________________________________________________________ Téléphonez gratuitement à tous vos proches avec Windows Live Messenger ! Téléchargez-le maintenant ! http://www.windowslive.fr/messenger/1.asp

1 0

Use kernel types in include files?
by Jun Koi 22 Jan '09

22 Jan '09

Hi, I am working on a project to parse the Windows image file. To do that, I must understand the structure of some Windows components, like _EPROCESS. So I took some headers from ReactOS, and write *userland* code like below: ---- #include <pstypes.h> #include <stdio.h> int main() { printf("size of EPROCESS: %d\n", sizeof(struct _EPROCESS)); return 0; } ---- The I got the problem: g++ reported that _EPROCESS is incomplete. Clearly this means it doesnt see the structure _EPROCESS, so I took a closer look, and found that _EPROCESS is not defined in user-mode (NTOS_MODE_USER). I tried to fix it by putting #undef NTOS_MODE_USER in front of #include <pstypes>, but that doesnt help. Anybody please tell me if there is any way to fix this? I think I can fix that by modifying the original headers. but that is way too ugly. Many thanks, Jun

3 4

Re: [ros-dev] [ros-diffs] [hyperion] 39010: modified tools/rbuild/module.cpp modified tools/rbuild/project.cpp modified tools/rbuild/project.dtd modified tools/rbuild/rbuild.h New per-project property allowwarnings overrides allowwarnings property of all modules in the project
by Timo Kreuzer 22 Jan '09

22 Jan '09

I thought it was made clear already... ReactOS code : no warnings, 3rd party code: allow warnings! This switch is of no use. Timo hyperion(a)svn.reactos.org schrieb: > Author: hyperion > Date: Thu Jan 22 05:55:12 2009 > New Revision: 39010 > > URL: http://svn.reactos.org/svn/reactos?rev=39010&view=rev > Log: > modified tools/rbuild/module.cpp > modified tools/rbuild/project.cpp > modified tools/rbuild/project.dtd > modified tools/rbuild/rbuild.h > New per-project property allowwarnings overrides allowwarnings property of all modules in the project > > Modified: > trunk/reactos/tools/rbuild/module.cpp > trunk/reactos/tools/rbuild/project.cpp > trunk/reactos/tools/rbuild/project.dtd > trunk/reactos/tools/rbuild/rbuild.h > > Modified: trunk/reactos/tools/rbuild/module.cpp > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/module.cpp?re… > ============================================================================== > --- trunk/reactos/tools/rbuild/module.cpp [iso-8859-1] (original) > +++ trunk/reactos/tools/rbuild/module.cpp [iso-8859-1] Thu Jan 22 05:55:12 2009 > @@ -452,6 +452,8 @@ > } > if ( att != NULL ) > allowWarnings = att->value == "true"; > + else if ( project.allowWarningsSet ) > + allowWarnings = project.allowWarnings; > else > allowWarnings = false; > > > Modified: trunk/reactos/tools/rbuild/project.cpp > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/project.cpp?r… > ============================================================================== > --- trunk/reactos/tools/rbuild/project.cpp [iso-8859-1] (original) > +++ trunk/reactos/tools/rbuild/project.cpp [iso-8859-1] Thu Jan 22 05:55:12 2009 > @@ -298,6 +298,11 @@ > assert(att); > makefile = Environment::GetAutomakeFile ( att->value ); > > + att = node->GetAttribute ( "allowwarnings", false ); > + allowWarningsSet = att != NULL; > + if ( att != NULL ) > + allowWarnings = att->value == "true"; > + > size_t i; > for ( i = 0; i < node->subElements.size (); i++ ) > { > > Modified: trunk/reactos/tools/rbuild/project.dtd > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/project.dtd?r… > ============================================================================== > --- trunk/reactos/tools/rbuild/project.dtd [iso-8859-1] (original) > +++ trunk/reactos/tools/rbuild/project.dtd [iso-8859-1] Thu Jan 22 05:55:12 2009 > @@ -137,6 +137,7 @@ > <!ATTLIST project > name (ReactOS|Project) #REQUIRED > makefile %Text; #REQUIRED > + allowwarnings (true|false) "false" > xmlns:xi %Text; #FIXED "http://www.w3.org/2001/XInclude" > > > > > Modified: trunk/reactos/tools/rbuild/rbuild.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/rbuild.h?rev=… > ============================================================================== > --- trunk/reactos/tools/rbuild/rbuild.h [iso-8859-1] (original) > +++ trunk/reactos/tools/rbuild/rbuild.h [iso-8859-1] Thu Jan 22 05:55:12 2009 > @@ -237,6 +237,8 @@ > std::map<std::string, Module*> modules; > IfableData non_if_data; > IfableData host_non_if_data; > + bool allowWarnings; > + bool allowWarningsSet; > > Project ( const Configuration& configuration, > const std::string& filename, > > >

2 1

Re: [ros-dev] [ros-diffs] [sginsberg] 38998: - Revert most of 38953. This was a bad idea, sorry.
by Pierre SCHWEITZER 21 Jan '09

21 Jan '09

Will the changes with Wine code remain? Or will they be reverted and the diffs reduced/deleted? P. Schweitzer > Date: Wed, 21 Jan 2009 14:41:24 +0000 > To: ros-diffs(a)reactos.org > From: sginsberg(a)svn.reactos.org > Subject: [ros-diffs] [sginsberg] 38998: - Revert most of 38953. This was a bad idea, sorry. > > Author: sginsberg > Date: Wed Jan 21 08:41:23 2009 > New Revision: 38998 > > URL: http://svn.reactos.org/svn/reactos?rev=38998&view=rev > Log: > - Revert most of 38953. This was a bad idea, sorry. > > Modified: > trunk/reactos/dll/win32/advpack/advpack.rbuild > trunk/reactos/dll/win32/atl/atl.rbuild > trunk/reactos/dll/win32/avifil32/avifil32.rbuild > trunk/reactos/dll/win32/browseui/browseui.rbuild > trunk/reactos/dll/win32/cabinet/cabinet.rbuild > trunk/reactos/dll/win32/clusapi/clusapi.rbuild > trunk/reactos/dll/win32/comcat/comcat.rbuild > trunk/reactos/dll/win32/comctl32/comctl32.rbuild > trunk/reactos/dll/win32/comdlg32/comdlg32.rbuild > trunk/reactos/dll/win32/compstui/compstui.rbuild > trunk/reactos/dll/win32/credui/credui.rbuild > trunk/reactos/dll/win32/crypt32/crypt32.rbuild > trunk/reactos/dll/win32/cryptdll/cryptdll.rbuild > trunk/reactos/dll/win32/cryptnet/cryptnet.rbuild > trunk/reactos/dll/win32/cryptui/cryptui.rbuild > trunk/reactos/dll/win32/dbghelp/dbghelp.rbuild > trunk/reactos/dll/win32/dciman32/dciman32.rbuild > trunk/reactos/dll/win32/dwmapi/dwmapi.rbuild > trunk/reactos/dll/win32/fusion/fusion.rbuild > trunk/reactos/dll/win32/gdiplus/gdiplus.rbuild > trunk/reactos/dll/win32/glu32/glu32.rbuild > trunk/reactos/dll/win32/hhctrl.ocx/hhctrl.ocx.rbuild > trunk/reactos/dll/win32/hlink/hlink.rbuild > trunk/reactos/dll/win32/imm32/imm32.rbuild > trunk/reactos/dll/win32/inetmib1/inetmib1.rbuild > trunk/reactos/dll/win32/iphlpapi/iphlpapi.rbuild > trunk/reactos/dll/win32/jscript/jscript.rbuild > trunk/reactos/dll/win32/localui/localui.rbuild > trunk/reactos/dll/win32/lz32/lz32.rbuild > trunk/reactos/dll/win32/mapi32/mapi32.rbuild > trunk/reactos/dll/win32/mlang/mlang.rbuild > trunk/reactos/dll/win32/mpr/mpr.rbuild > trunk/reactos/dll/win32/mshtml/mshtml.rbuild > trunk/reactos/dll/win32/msi/msi.rbuild > trunk/reactos/dll/win32/msimg32/msimg32.rbuild > trunk/reactos/dll/win32/mstask/mstask.rbuild > trunk/reactos/dll/win32/msvcrt20/msvcrt20.rbuild > trunk/reactos/dll/win32/msvfw32/msvfw32.rbuild > trunk/reactos/dll/win32/nddeapi/nddeapi.rbuild > trunk/reactos/dll/win32/netapi32/netapi32.rbuild > trunk/reactos/dll/win32/ntdsapi/ntdsapi.rbuild > trunk/reactos/dll/win32/objsel/objsel.rbuild > trunk/reactos/dll/win32/odbccp32/odbccp32.rbuild > trunk/reactos/dll/win32/ole32/ole32.rbuild > trunk/reactos/dll/win32/oleacc/oleacc.rbuild > trunk/reactos/dll/win32/oleaut32/oleaut32.rbuild > trunk/reactos/dll/win32/oleaut32/oleaut32_ros.diff > trunk/reactos/dll/win32/oledlg/oledlg.rbuild > trunk/reactos/dll/win32/olepro32/olepro32.rbuild > trunk/reactos/dll/win32/pdh/pdh.rbuild > trunk/reactos/dll/win32/printui/printui.rbuild > trunk/reactos/dll/win32/rasapi32/rasapi32.rbuild > trunk/reactos/dll/win32/riched20/riched20.rbuild > trunk/reactos/dll/win32/riched32/riched32.rbuild > trunk/reactos/dll/win32/rpcrt4/rpcrt4.rbuild > trunk/reactos/dll/win32/rsabase/rsabase.rbuild > trunk/reactos/dll/win32/rsaenh/rsaenh.rbuild > trunk/reactos/dll/win32/schannel/schannel.rbuild > trunk/reactos/dll/win32/sensapi/sensapi.rbuild > trunk/reactos/dll/win32/setupapi/setupapi.rbuild > trunk/reactos/dll/win32/sfc/sfc.rbuild > trunk/reactos/dll/win32/sfc_os/sfc_os.rbuild > trunk/reactos/dll/win32/shfolder/shfolder.rbuild > trunk/reactos/dll/win32/shlwapi/shlwapi.rbuild > trunk/reactos/dll/win32/spoolss/spoolss.rbuild > trunk/reactos/dll/win32/sxs/sxs.rbuild > trunk/reactos/dll/win32/syssetup/syssetup.rbuild > trunk/reactos/dll/win32/tapi32/tapi32.rbuild > trunk/reactos/dll/win32/twain_32/twain_32.rbuild > trunk/reactos/dll/win32/urlmon/urlmon.rbuild > trunk/reactos/dll/win32/usp10/usp10.rbuild > trunk/reactos/dll/win32/uxtheme/uxtheme.rbuild > trunk/reactos/dll/win32/version/version.rbuild > trunk/reactos/dll/win32/winfax/winfax.rbuild > trunk/reactos/dll/win32/winspool/winspool.rbuild > trunk/reactos/dll/win32/wintrust/wintrust.rbuild > trunk/reactos/dll/win32/wldap32/wldap32.rbuild > trunk/reactos/dll/win32/wtsapi32/wtsapi32.rbuild > _________________________________________________________________ Téléphonez gratuitement à tous vos proches avec Windows Live Messenger ! Téléchargez-le maintenant ! http://www.windowslive.fr/messenger/1.asp

1 0

Re: [ros-dev] [ros-diffs] [sginsberg] 38979: - Fix my .diff mess from yesterday, sorry
by Ged 20 Jan '09

20 Jan '09

No no no, why is this still happening??? We _DO NOT_ fix warnings in wine code! This is the 3rd email I've sent on this and it's still happening. All warnings in 3rd party code should be left and allowwarnings="true" should be set in the rbuild file. Continuing down this path is just going to make syncing code more and more difficult with absolutely no advantage. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of sginsberg(a)svn.reactos.org Sent: 20 January 2009 15:49 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [sginsberg] 38979: - Fix my .diff mess from yesterday, sorry Author: sginsberg Date: Tue Jan 20 09:48:54 2009 New Revision: 38979 URL: http://svn.reactos.org/svn/reactos?rev=38979&view=rev Log: - Fix my .diff mess from yesterday, sorry Added: trunk/reactos/dll/win32/crypt32/crypt32_ros.diff - copied unchanged from r38978, trunk/reactos/dll/win32/crypt32/warningfixes.diff trunk/reactos/dll/win32/ole32/ole32_ros.diff - copied unchanged from r38978, trunk/reactos/dll/win32/ole32/warningfix.diff Removed: trunk/reactos/dll/win32/crypt32/warningfixes.diff trunk/reactos/dll/win32/ole32/warningfix.diff Modified: trunk/reactos/dll/win32/oleaut32/oleaut32_ros.diff Removed: trunk/reactos/dll/win32/crypt32/warningfixes.diff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/crypt32/warningf… ============================================================================== --- trunk/reactos/dll/win32/crypt32/warningfixes.diff [iso-8859-1] (original) +++ trunk/reactos/dll/win32/crypt32/warningfixes.diff (removed) @@ -1,39 +1,0 @@ -Index: chain.c -=================================================================== ---- chain.c (revision 38919) -+++ chain.c (working copy) -@@ -205,7 +205,7 @@ - - config.cbSize = sizeof(config); - CertCreateCertificateChainEngine(&config, &engine); -- InterlockedCompareExchangePointer(&CRYPT_defaultChainEngine, engine, -+ (void)InterlockedCompareExchangePointer(&CRYPT_defaultChainEngine, engine, - NULL); - if (CRYPT_defaultChainEngine != engine) - CertFreeCertificateChainEngine(engine); -Index: main.c -=================================================================== ---- main.c (revision 38919) -+++ main.c (working copy) -@@ -66,7 +66,7 @@ - - CryptAcquireContextW(&prov, NULL, MS_ENHANCED_PROV_W, PROV_RSA_FULL, - CRYPT_VERIFYCONTEXT); -- InterlockedCompareExchangePointer((PVOID *)&hDefProv, (PVOID)prov, -+ (void)InterlockedCompareExchangePointer((PVOID *)&hDefProv, (PVOID)prov, - NULL); - if (hDefProv != prov) - CryptReleaseContext(prov, 0); -Index: rootstore.c -=================================================================== ---- rootstore.c (revision 38919) -+++ rootstore.c (working copy) -@@ -759,7 +759,7 @@ - { - HCERTSTORE root = create_root_store(); - -- InterlockedCompareExchangePointer((PVOID *)&CRYPT_rootStore, root, -+ (void)InterlockedCompareExchangePointer((PVOID *)&CRYPT_rootStore, root, - NULL); - if (CRYPT_rootStore != root) - CertCloseStore(root, 0); Removed: trunk/reactos/dll/win32/ole32/warningfix.diff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ole32/warningfix… ============================================================================== --- trunk/reactos/dll/win32/ole32/warningfix.diff [iso-8859-1] (original) +++ trunk/reactos/dll/win32/ole32/warningfix.diff (removed) @@ -1,13 +1,0 @@ -Index: marshal.c -=================================================================== ---- marshal.c (revision 38899) -+++ marshal.c (working copy) -@@ -824,7 +824,7 @@ - } while (new_dest_context != old_dest_context); - - if (dest_context_data) -- InterlockedExchangePointer(&This->dest_context_data, dest_context_data); -+ (void)InterlockedExchangePointer(&This->dest_context_data, dest_context_data); - } - - static HRESULT proxy_manager_query_local_interface(struct proxy_manager * This, REFIID riid, void ** ppv) Modified: trunk/reactos/dll/win32/oleaut32/oleaut32_ros.diff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/oleaut32/oleaut3… ============================================================================== --- trunk/reactos/dll/win32/oleaut32/oleaut32_ros.diff [iso-8859-1] (original) +++ trunk/reactos/dll/win32/oleaut32/oleaut32_ros.diff [iso-8859-1] Tue Jan 20 09:48:54 2009 @@ -72,3 +72,15 @@ /* * FIXME: +Index: oleaut32.rbuild +=================================================================== +--- oleaut32.rbuild (revision 23782) ++++ oleaut32.rbuild (working copy) +@@ -43,6 +43,7 @@ + <library>comctl32</library> + <library>urlmon</library> + <library>uuid</library> ++ <library>pseh</library> + </module> + <module name="oleaut32_oleaut32_oaidl_proxy" type="rpcproxy" allowwarnings="true"> + <file>oleaut32_oaidl.idl</file>

1 0

[ros-diffs] [silverblade] 38962: setupldr previously worked by faking the FreeLdr OS menu function.
by James Tabor 20 Jan '09

20 Jan '09

Hi, Does it boot for you? I make bootcd and it does not boot, I revert the change, now it boots..... Did you forget something? Thanks, James

1 0

Re: [ros-dev] [ros-diffs] [sginsberg] 38953: - Kill off more unnecessary allowwarnings="true" - Remove a .rbuild diff from oleaut32_ros.diff -- Wine doesn't use .rbuild, so why put this in .diff?
by Ged 19 Jan '09

19 Jan '09

This is another bad move, it makes synching much harder in the case where Wine code introduces warnings. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of sginsberg(a)svn.reactos.org Sent: 19 January 2009 19:45 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [sginsberg] 38953: - Kill off more unnecessary allowwarnings="true" - Remove a .rbuild diff from oleaut32_ros.diff -- Wine doesn't use .rbuild, so why put this in .diff? Author: sginsberg Date: Mon Jan 19 13:44:55 2009 New Revision: 38953 URL: http://svn.reactos.org/svn/reactos?rev=38953&view=rev Log: - Kill off more unnecessary allowwarnings="true" - Remove a .rbuild diff from oleaut32_ros.diff -- Wine doesn't use .rbuild, so why put this in .diff? Modified: trunk/reactos/dll/win32/advpack/advpack.rbuild trunk/reactos/dll/win32/atl/atl.rbuild trunk/reactos/dll/win32/avifil32/avifil32.rbuild trunk/reactos/dll/win32/browseui/browseui.rbuild trunk/reactos/dll/win32/cabinet/cabinet.rbuild trunk/reactos/dll/win32/clusapi/clusapi.rbuild trunk/reactos/dll/win32/comcat/comcat.rbuild trunk/reactos/dll/win32/comctl32/comctl32.rbuild trunk/reactos/dll/win32/comdlg32/comdlg32.rbuild trunk/reactos/dll/win32/compstui/compstui.rbuild trunk/reactos/dll/win32/credui/credui.rbuild trunk/reactos/dll/win32/crypt32/crypt32.rbuild trunk/reactos/dll/win32/cryptdll/cryptdll.rbuild trunk/reactos/dll/win32/cryptnet/cryptnet.rbuild trunk/reactos/dll/win32/cryptui/cryptui.rbuild trunk/reactos/dll/win32/dbghelp/dbghelp.rbuild trunk/reactos/dll/win32/dciman32/dciman32.rbuild trunk/reactos/dll/win32/dwmapi/dwmapi.rbuild trunk/reactos/dll/win32/fusion/fusion.rbuild trunk/reactos/dll/win32/gdiplus/gdiplus.rbuild trunk/reactos/dll/win32/glu32/glu32.rbuild trunk/reactos/dll/win32/hhctrl.ocx/hhctrl.ocx.rbuild trunk/reactos/dll/win32/hlink/hlink.rbuild trunk/reactos/dll/win32/imm32/imm32.rbuild trunk/reactos/dll/win32/inetmib1/inetmib1.rbuild trunk/reactos/dll/win32/iphlpapi/iphlpapi.rbuild trunk/reactos/dll/win32/jscript/jscript.rbuild trunk/reactos/dll/win32/localui/localui.rbuild trunk/reactos/dll/win32/lz32/lz32.rbuild trunk/reactos/dll/win32/mapi32/mapi32.rbuild trunk/reactos/dll/win32/mlang/mlang.rbuild trunk/reactos/dll/win32/mpr/mpr.rbuild trunk/reactos/dll/win32/mshtml/mshtml.rbuild trunk/reactos/dll/win32/msi/msi.rbuild trunk/reactos/dll/win32/msimg32/msimg32.rbuild trunk/reactos/dll/win32/mstask/mstask.rbuild trunk/reactos/dll/win32/msvcrt20/msvcrt20.rbuild trunk/reactos/dll/win32/msvfw32/msvfw32.rbuild trunk/reactos/dll/win32/msxml3/msxml3.rbuild trunk/reactos/dll/win32/nddeapi/nddeapi.rbuild trunk/reactos/dll/win32/netapi32/netapi32.rbuild trunk/reactos/dll/win32/ntdsapi/ntdsapi.rbuild trunk/reactos/dll/win32/objsel/objsel.rbuild trunk/reactos/dll/win32/odbccp32/odbccp32.rbuild trunk/reactos/dll/win32/ole32/ole32.rbuild trunk/reactos/dll/win32/oleacc/oleacc.rbuild trunk/reactos/dll/win32/oleaut32/oleaut32.rbuild trunk/reactos/dll/win32/oleaut32/oleaut32_ros.diff trunk/reactos/dll/win32/oledlg/oledlg.rbuild trunk/reactos/dll/win32/olepro32/olepro32.rbuild trunk/reactos/dll/win32/pdh/pdh.rbuild trunk/reactos/dll/win32/printui/printui.rbuild trunk/reactos/dll/win32/rasapi32/rasapi32.rbuild trunk/reactos/dll/win32/riched20/riched20.rbuild trunk/reactos/dll/win32/riched32/riched32.rbuild trunk/reactos/dll/win32/rpcrt4/rpcrt4.rbuild trunk/reactos/dll/win32/rsabase/rsabase.rbuild trunk/reactos/dll/win32/rsaenh/rsaenh.rbuild trunk/reactos/dll/win32/schannel/schannel.rbuild trunk/reactos/dll/win32/sensapi/sensapi.rbuild trunk/reactos/dll/win32/setupapi/setupapi.rbuild trunk/reactos/dll/win32/sfc/sfc.rbuild trunk/reactos/dll/win32/sfc_os/sfc_os.rbuild trunk/reactos/dll/win32/shfolder/shfolder.rbuild trunk/reactos/dll/win32/shlwapi/shlwapi.rbuild trunk/reactos/dll/win32/spoolss/spoolss.rbuild trunk/reactos/dll/win32/sxs/sxs.rbuild trunk/reactos/dll/win32/syssetup/syssetup.rbuild trunk/reactos/dll/win32/tapi32/tapi32.rbuild trunk/reactos/dll/win32/twain_32/twain_32.rbuild trunk/reactos/dll/win32/urlmon/urlmon.rbuild trunk/reactos/dll/win32/usp10/usp10.rbuild trunk/reactos/dll/win32/uxtheme/uxtheme.rbuild trunk/reactos/dll/win32/version/version.rbuild trunk/reactos/dll/win32/winfax/winfax.rbuild trunk/reactos/dll/win32/winspool/winspool.rbuild trunk/reactos/dll/win32/wintrust/wintrust.rbuild trunk/reactos/dll/win32/wldap32/wldap32.rbuild trunk/reactos/dll/win32/wtsapi32/wtsapi32.rbuild trunk/reactos/drivers/wdm/audio/drivers/sb16/sb16.rbuild trunk/reactos/include/reactos/idl/idl.rbuild trunk/reactos/lib/3rdparty/adns/adns.rbuild trunk/reactos/lib/3rdparty/expat/expat.rbuild trunk/reactos/lib/sdk/uuid/uuid.rbuild Modified: trunk/reactos/dll/win32/advpack/advpack.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advpack/advpack.… ============================================================================== --- trunk/reactos/dll/win32/advpack/advpack.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advpack/advpack.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="advpack" type="win32dll" baseaddress="${BASEADDRESS_ADVPACK}" installbase="system32" installname="advpack.dll" allowwarnings="true"> +<module name="advpack" type="win32dll" baseaddress="${BASEADDRESS_ADVPACK}" installbase="system32" installname="advpack.dll"> <importlibrary definition="advpack.spec" /> <include base="advpack">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/atl/atl.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/atl/atl.rbuild?r… ============================================================================== --- trunk/reactos/dll/win32/atl/atl.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/atl/atl.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="atl" type="win32dll" baseaddress="${BASEADDRESS_ATL}" installbase="system32" installname="atl.dll" allowwarnings="true"> +<module name="atl" type="win32dll" baseaddress="${BASEADDRESS_ATL}" installbase="system32" installname="atl.dll"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="atl.spec" /> <include base="atl">.</include> @@ -24,7 +24,7 @@ <library>ntdll</library> <dependency>atl_atliface_header</dependency> </module> -<module name="atl_atliface_header" type="idlheader" allowwarnings="true"> +<module name="atl_atliface_header" type="idlheader"> <file>atliface.idl</file> </module> </group> Modified: trunk/reactos/dll/win32/avifil32/avifil32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/avifil32/avifil3… ============================================================================== --- trunk/reactos/dll/win32/avifil32/avifil32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/avifil32/avifil32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="avifil32" type="win32dll" baseaddress="${BASEADDRESS_AVIFIL32}" installbase="system32" installname="avifil32.dll" allowwarnings="true"> +<module name="avifil32" type="win32dll" baseaddress="${BASEADDRESS_AVIFIL32}" installbase="system32" installname="avifil32.dll"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="avifil32.spec" /> <include base="avifil32">.</include> Modified: trunk/reactos/dll/win32/browseui/browseui.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/browseu… ============================================================================== --- trunk/reactos/dll/win32/browseui/browseui.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/browseui/browseui.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="browseui" type="win32dll" baseaddress="${BASEADDRESS_BROWSEUI}" installbase="system32" installname="browseui.dll" allowwarnings="true"> +<module name="browseui" type="win32dll" baseaddress="${BASEADDRESS_BROWSEUI}" installbase="system32" installname="browseui.dll"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="browseui.spec" /> <include base="browseui">.</include> Modified: trunk/reactos/dll/win32/cabinet/cabinet.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/cabinet/cabinet.… ============================================================================== --- trunk/reactos/dll/win32/cabinet/cabinet.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/cabinet/cabinet.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="cabinet" type="win32dll" baseaddress="${BASEADDRESS_CABINET}" installbase="system32" installname="cabinet.dll" allowwarnings="true" entrypoint="0"> +<module name="cabinet" type="win32dll" baseaddress="${BASEADDRESS_CABINET}" installbase="system32" installname="cabinet.dll" entrypoint="0"> <importlibrary definition="cabinet.spec" /> <include base="cabinet">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/clusapi/clusapi.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/clusapi/clusapi.… ============================================================================== --- trunk/reactos/dll/win32/clusapi/clusapi.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/clusapi/clusapi.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="clusapi" type="win32dll" baseaddress="${BASEADDRESS_CLUSAPI}" installbase="system32" installname="clusapi.dll" allowwarnings="true"> +<module name="clusapi" type="win32dll" baseaddress="${BASEADDRESS_CLUSAPI}" installbase="system32" installname="clusapi.dll"> <importlibrary definition="clusapi.spec" /> <include base="clusapi">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/comcat/comcat.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comcat/comcat.rb… ============================================================================== --- trunk/reactos/dll/win32/comcat/comcat.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/comcat/comcat.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="comcat" type="win32dll" baseaddress="${BASEADDRESS_COMCAT}" installbase="system32" entrypoint="0" installname="comcat.dll" allowwarnings="true"> +<module name="comcat" type="win32dll" baseaddress="${BASEADDRESS_COMCAT}" installbase="system32" entrypoint="0" installname="comcat.dll"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="comcat.spec" /> <include base="comcat">.</include> Modified: trunk/reactos/dll/win32/comctl32/comctl32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/comctl3… ============================================================================== --- trunk/reactos/dll/win32/comctl32/comctl32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/comctl32/comctl32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="comctl32" type="win32dll" baseaddress="${BASEADDRESS_COMCTL32}" installbase="system32" installname="comctl32.dll" allowwarnings="true"> +<module name="comctl32" type="win32dll" baseaddress="${BASEADDRESS_COMCTL32}" installbase="system32" installname="comctl32.dll"> <autoregister infsection="OleControlDlls" type="DllInstall" /> <importlibrary definition="comctl32.spec" /> <include base="comctl32">.</include> Modified: trunk/reactos/dll/win32/comdlg32/comdlg32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comdlg32/comdlg3… ============================================================================== --- trunk/reactos/dll/win32/comdlg32/comdlg32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/comdlg32/comdlg32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="comdlg32" type="win32dll" baseaddress="${BASEADDRESS_COMDLG32}" installbase="system32" installname="comdlg32.dll" allowwarnings="true"> +<module name="comdlg32" type="win32dll" baseaddress="${BASEADDRESS_COMDLG32}" installbase="system32" installname="comdlg32.dll"> <importlibrary definition="comdlg32.spec" /> <include base="comdlg32">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/compstui/compstui.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/compstui/compstu… ============================================================================== --- trunk/reactos/dll/win32/compstui/compstui.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/compstui/compstui.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="compstui" type="win32dll" baseaddress="${BASEADDRESS_COMPSTUI}" installbase="system32" installname="compstui.dll" allowwarnings="true"> +<module name="compstui" type="win32dll" baseaddress="${BASEADDRESS_COMPSTUI}" installbase="system32" installname="compstui.dll"> <importlibrary definition="compstui.spec" /> <include base="compstui">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/credui/credui.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/credui/credui.rb… ============================================================================== --- trunk/reactos/dll/win32/credui/credui.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/credui/credui.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="credui" type="win32dll" baseaddress="${BASEADDRESS_CREDUI}" installbase="system32" installname="credui.dll" allowwarnings="true"> +<module name="credui" type="win32dll" baseaddress="${BASEADDRESS_CREDUI}" installbase="system32" installname="credui.dll"> <importlibrary definition="credui.spec" /> <include base="credui">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/crypt32/crypt32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/crypt32/crypt32.… ============================================================================== --- trunk/reactos/dll/win32/crypt32/crypt32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/crypt32/crypt32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,4 +1,4 @@ -<module name="crypt32" type="win32dll" baseaddress="${BASEADDRESS_CRYPT32}" installbase="system32" installname="crypt32.dll" allowwarnings="true" crt="msvcrt"> +<module name="crypt32" type="win32dll" baseaddress="${BASEADDRESS_CRYPT32}" installbase="system32" installname="crypt32.dll" crt="msvcrt"> <importlibrary definition="crypt32.spec" /> <include base="crypt32">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/cryptdll/cryptdll.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/cryptdll/cryptdl… ============================================================================== --- trunk/reactos/dll/win32/cryptdll/cryptdll.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/cryptdll/cryptdll.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="cryptdll" type="win32dll" baseaddress="${BASEADDRESS_CRYPTDLL}" installbase="system32" installname="cryptdll.dll" allowwarnings="true"> +<module name="cryptdll" type="win32dll" baseaddress="${BASEADDRESS_CRYPTDLL}" installbase="system32" installname="cryptdll.dll"> <importlibrary definition="cryptdll.spec" /> <include base="cryptdll">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/cryptnet/cryptnet.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/cryptnet/cryptne… ============================================================================== --- trunk/reactos/dll/win32/cryptnet/cryptnet.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/cryptnet/cryptnet.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="cryptnet" type="win32dll" baseaddress="${BASEADDRESS_CRYPTNET}" installbase="system32" installname="cryptnet.dll" allowwarnings="true"> +<module name="cryptnet" type="win32dll" baseaddress="${BASEADDRESS_CRYPTNET}" installbase="system32" installname="cryptnet.dll"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="cryptnet.spec" /> <include base="cryptnet">.</include> Modified: trunk/reactos/dll/win32/cryptui/cryptui.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/cryptui/cryptui.… ============================================================================== --- trunk/reactos/dll/win32/cryptui/cryptui.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/cryptui/cryptui.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="cryptui" type="win32dll" baseaddress="${BASEADDRESS_CRYPTUI}" installbase="system32" installname="cryptui.dll" allowwarnings="true"> +<module name="cryptui" type="win32dll" baseaddress="${BASEADDRESS_CRYPTUI}" installbase="system32" installname="cryptui.dll">  <importlibrary definition="cryptui.spec" /> <include base="cryptui">.</include> Modified: trunk/reactos/dll/win32/dbghelp/dbghelp.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/dbghelp.… ============================================================================== --- trunk/reactos/dll/win32/dbghelp/dbghelp.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/dbghelp/dbghelp.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="dbghelp" type="win32dll" baseaddress="${BASEADDRESS_DBGHELP}" installbase="system32" installname="dbghelp.dll" allowwarnings="true" crt="msvcrt"> +<module name="dbghelp" type="win32dll" baseaddress="${BASEADDRESS_DBGHELP}" installbase="system32" installname="dbghelp.dll" crt="msvcrt"> <importlibrary definition="dbghelp.spec" /> <include base="dbghelp">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/dciman32/dciman32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dciman32/dciman3… ============================================================================== --- trunk/reactos/dll/win32/dciman32/dciman32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/dciman32/dciman32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="dciman32" type="win32dll" baseaddress="${BASEADDRESS_DCIMAN32}" installbase="system32" installname="dciman32.dll" allowwarnings="true"> +<module name="dciman32" type="win32dll" baseaddress="${BASEADDRESS_DCIMAN32}" installbase="system32" installname="dciman32.dll"> <importlibrary definition="dciman32.spec" /> <include base="dciman32">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/dwmapi/dwmapi.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dwmapi/dwmapi.rb… ============================================================================== --- trunk/reactos/dll/win32/dwmapi/dwmapi.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/dwmapi/dwmapi.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="dwmapi" type="win32dll" baseaddress="${BASEADDRESS_DWMAPI}" installbase="system32" installname="dwmapi.dll" allowwarnings="true"> +<module name="dwmapi" type="win32dll" baseaddress="${BASEADDRESS_DWMAPI}" installbase="system32" installname="dwmapi.dll"> <importlibrary definition="dwmapi.spec" /> <include base="dwmapi">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/fusion/fusion.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/fusion/fusion.rb… ============================================================================== --- trunk/reactos/dll/win32/fusion/fusion.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/fusion/fusion.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,4 +1,4 @@ -<module name="fusion" type="win32dll" baseaddress="${BASEADDRESS_FUSION}" installbase="system32" installname="fusion.dll" allowwarnings="true"> +<module name="fusion" type="win32dll" baseaddress="${BASEADDRESS_FUSION}" installbase="system32" installname="fusion.dll"> <importlibrary definition="fusion.spec" /> <include base="fusion">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/gdiplus/gdiplus.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/gdiplus/gdiplus.… ============================================================================== --- trunk/reactos/dll/win32/gdiplus/gdiplus.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/gdiplus/gdiplus.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="gdiplus" type="win32dll" baseaddress="${BASEADDRESS_GDIPLUS}" installbase="system32" installname="gdiplus.dll" allowwarnings="true" crt="msvcrt"> +<module name="gdiplus" type="win32dll" baseaddress="${BASEADDRESS_GDIPLUS}" installbase="system32" installname="gdiplus.dll" crt="msvcrt"> <importlibrary definition="gdiplus.spec" /> <include base="gdiplus">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/glu32/glu32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/glu32/glu32.rbui… ============================================================================== --- trunk/reactos/dll/win32/glu32/glu32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/glu32/glu32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,4 +1,4 @@ -<module name="glu32" type="win32dll" entrypoint="0" baseaddress="${BASEADDRESS_GLU32}" installbase="system32" installname="glu32.dll" allowwarnings="true" crt="msvcrt"> +<module name="glu32" type="win32dll" entrypoint="0" baseaddress="${BASEADDRESS_GLU32}" installbase="system32" installname="glu32.dll" crt="msvcrt"> <importlibrary definition="glu32.def" /> <include base="glu32">include</include> <include base="glu32">libnurbs/internals</include> Modified: trunk/reactos/dll/win32/hhctrl.ocx/hhctrl.ocx.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/hhctrl.ocx/hhctr… ============================================================================== --- trunk/reactos/dll/win32/hhctrl.ocx/hhctrl.ocx.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/hhctrl.ocx/hhctrl.ocx.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="hhctrl" type="win32ocx" baseaddress="${BASEADDRESS_HHCTRL}" installbase="system32" installname="hhctrl.ocx" allowwarnings="true"> +<module name="hhctrl" type="win32ocx" baseaddress="${BASEADDRESS_HHCTRL}" installbase="system32" installname="hhctrl.ocx"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="hhctrl.ocx.spec" /> <include base="hhctrl">.</include> Modified: trunk/reactos/dll/win32/hlink/hlink.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/hlink/hlink.rbui… ============================================================================== --- trunk/reactos/dll/win32/hlink/hlink.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/hlink/hlink.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="hlink" type="win32dll" baseaddress="${BASEADDRESS_HLINK}" installbase="system32" installname="hlink.dll" allowwarnings="true"> +<module name="hlink" type="win32dll" baseaddress="${BASEADDRESS_HLINK}" installbase="system32" installname="hlink.dll"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="hlink.spec" /> <include base="hlink">.</include> Modified: trunk/reactos/dll/win32/imm32/imm32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/imm32/imm32.rbui… ============================================================================== --- trunk/reactos/dll/win32/imm32/imm32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/imm32/imm32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="imm32" type="win32dll" baseaddress="${BASEADDRESS_IMM32}" installbase="system32" installname="imm32.dll" allowwarnings="true"> +<module name="imm32" type="win32dll" baseaddress="${BASEADDRESS_IMM32}" installbase="system32" installname="imm32.dll"> <importlibrary definition="imm32.spec" /> <include base="imm32">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/inetmib1/inetmib1.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/inetmib1/inetmib… ============================================================================== --- trunk/reactos/dll/win32/inetmib1/inetmib1.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/inetmib1/inetmib1.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="inetmib1" type="win32dll" baseaddress="${BASEADDRESS_INETMIB1}" installbase="system32" installname="inetmib1.dll" allowwarnings="true"> +<module name="inetmib1" type="win32dll" baseaddress="${BASEADDRESS_INETMIB1}" installbase="system32" installname="inetmib1.dll"> <importlibrary definition="inetmib1.spec" /> <include base="inetmib1">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/iphlpapi/iphlpapi.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/iphlpapi/iphlpap… ============================================================================== --- trunk/reactos/dll/win32/iphlpapi/iphlpapi.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/iphlpapi/iphlpapi.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,4 +1,4 @@ -<module name="iphlpapi" type="win32dll" baseaddress="${BASEADDRESS_IPHLPAPI}" installbase="system32" installname="iphlpapi.dll" allowwarnings="true" unicode="yes" crt="msvcrt"> +<module name="iphlpapi" type="win32dll" baseaddress="${BASEADDRESS_IPHLPAPI}" installbase="system32" installname="iphlpapi.dll" unicode="yes" crt="msvcrt"> <importlibrary definition="iphlpapi.spec" /> <include base="iphlpapi">include</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/jscript/jscript.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/jscript/jscript.… ============================================================================== --- trunk/reactos/dll/win32/jscript/jscript.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/jscript/jscript.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,5 +1,5 @@ <group> -<module name="jscript" type="win32dll" baseaddress="${BASEADDRESS_JSCRIPT}" installbase="system32" installname="jscript.dll" allowwarnings="true" crt="msvcrt"> +<module name="jscript" type="win32dll" baseaddress="${BASEADDRESS_JSCRIPT}" installbase="system32" installname="jscript.dll" crt="msvcrt"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="jscript.spec" /> <include base="jscript">.</include> Modified: trunk/reactos/dll/win32/localui/localui.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/localui/localui.… ============================================================================== --- trunk/reactos/dll/win32/localui/localui.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/localui/localui.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="localui" type="win32dll" baseaddress="${BASEADDRESS_LOCALUI}" installbase="system32" installname="localui.dll" allowwarnings="true"> +<module name="localui" type="win32dll" baseaddress="${BASEADDRESS_LOCALUI}" installbase="system32" installname="localui.dll"> <importlibrary definition="localui.spec" /> <include base="localui">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/lz32/lz32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lz32/lz32.rbuild… ============================================================================== --- trunk/reactos/dll/win32/lz32/lz32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/lz32/lz32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="lz32" type="win32dll" entrypoint="0" baseaddress="${BASEADDRESS_LZ32}" installbase="system32" installname="lz32.dll" allowwarnings="true"> +<module name="lz32" type="win32dll" entrypoint="0" baseaddress="${BASEADDRESS_LZ32}" installbase="system32" installname="lz32.dll"> <importlibrary definition="lz32.spec" /> <include base="lz32">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/mapi32/mapi32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/mapi32/mapi32.rb… ============================================================================== --- trunk/reactos/dll/win32/mapi32/mapi32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/mapi32/mapi32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="mapi32" type="win32dll" baseaddress="${BASEADDRESS_MAPI32}" installbase="system32" installname="mapi32.dll" allowwarnings="true"> +<module name="mapi32" type="win32dll" baseaddress="${BASEADDRESS_MAPI32}" installbase="system32" installname="mapi32.dll"> <importlibrary definition="mapi32.spec" /> <include base="mapi32">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/mlang/mlang.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/mlang/mlang.rbui… ============================================================================== --- trunk/reactos/dll/win32/mlang/mlang.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/mlang/mlang.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="mlang" type="win32dll" baseaddress="${BASEADDRESS_MLANG}" installbase="system32" installname="mlang.dll" allowwarnings="true"> +<module name="mlang" type="win32dll" baseaddress="${BASEADDRESS_MLANG}" installbase="system32" installname="mlang.dll"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="mlang.spec" /> <include base="mlang">.</include> Modified: trunk/reactos/dll/win32/mpr/mpr.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/mpr/mpr.rbuild?r… ============================================================================== --- trunk/reactos/dll/win32/mpr/mpr.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/mpr/mpr.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="mpr" type="win32dll" baseaddress="${BASEADDRESS_MPR}" installbase="system32" installname="mpr.dll" allowwarnings="true"> +<module name="mpr" type="win32dll" baseaddress="${BASEADDRESS_MPR}" installbase="system32" installname="mpr.dll"> <importlibrary definition="mpr.spec" /> <include base="mpr">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/mshtml/mshtml.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/mshtml/mshtml.rb… ============================================================================== --- trunk/reactos/dll/win32/mshtml/mshtml.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/mshtml/mshtml.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="mshtml" type="win32dll" baseaddress="${BASEADDRESS_MSHTML}" installbase="system32" installname="mshtml.dll" allowwarnings="true"> +<module name="mshtml" type="win32dll" baseaddress="${BASEADDRESS_MSHTML}" installbase="system32" installname="mshtml.dll"> <autoregister infsection="OleControlDlls" type="Both" /> <importlibrary definition="mshtml.spec" /> <include base="mshtml">.</include> @@ -71,7 +71,7 @@ <library>ntdll</library> <dependency>mshtml_nsiface_header</dependency> </module> -<module name="mshtml_nsiface_header" type="idlheader" allowwarnings="true"> +<module name="mshtml_nsiface_header" type="idlheader"> <file>nsiface.idl</file> </module> </group> Modified: trunk/reactos/dll/win32/msi/msi.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msi/msi.rbuild?r… ============================================================================== --- trunk/reactos/dll/win32/msi/msi.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msi/msi.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="msi" type="win32dll" baseaddress="${BASEADDRESS_MSI}" installbase="system32" installname="msi.dll" allowwarnings="true" crt="msvcrt"> +<module name="msi" type="win32dll" baseaddress="${BASEADDRESS_MSI}" installbase="system32" installname="msi.dll" crt="msvcrt"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="msi.spec" /> <include base="msi">.</include> @@ -75,7 +75,7 @@ <dependency>msiserver</dependency> <dependency>msiheader</dependency> </module> -<module name="msiserver" type="embeddedtypelib" allowwarnings="true"> +<module name="msiserver" type="embeddedtypelib"> <file>msiserver.idl</file> </module> <module name="msiheader" type="idlheader"> Modified: trunk/reactos/dll/win32/msimg32/msimg32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msimg32/msimg32.… ============================================================================== --- trunk/reactos/dll/win32/msimg32/msimg32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msimg32/msimg32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="msimg32" type="win32dll" baseaddress="${BASEADDRESS_MSIMG32}" installbase="system32" installname="msimg32.dll" allowwarnings="true"> +<module name="msimg32" type="win32dll" baseaddress="${BASEADDRESS_MSIMG32}" installbase="system32" installname="msimg32.dll"> <importlibrary definition="msimg32.spec" /> <include base="msimg32">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/mstask/mstask.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/mstask/mstask.rb… ============================================================================== --- trunk/reactos/dll/win32/mstask/mstask.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/mstask/mstask.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="mstask" type="win32dll" baseaddress="${BASEADDRESS_MSTASK}" installbase="system32" installname="mstask.dll" allowwarnings="true"> +<module name="mstask" type="win32dll" baseaddress="${BASEADDRESS_MSTASK}" installbase="system32" installname="mstask.dll"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="mstask.spec" /> <include base="mstask">.</include> Modified: trunk/reactos/dll/win32/msvcrt20/msvcrt20.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt20/msvcrt2… ============================================================================== --- trunk/reactos/dll/win32/msvcrt20/msvcrt20.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msvcrt20/msvcrt20.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="msvcrt20" type="win32dll" baseaddress="${BASEADDRESS_MSVCRT20}" installbase="system32" installname="msvcrt20.dll" allowwarnings="true" entrypoint="0" iscrt="yes"> +<module name="msvcrt20" type="win32dll" baseaddress="${BASEADDRESS_MSVCRT20}" installbase="system32" installname="msvcrt20.dll" entrypoint="0" iscrt="yes"> <importlibrary definition="msvcrt20.spec" /> <include base="msvcrt20">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/msvfw32/msvfw32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvfw32/msvfw32.… ============================================================================== --- trunk/reactos/dll/win32/msvfw32/msvfw32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msvfw32/msvfw32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="msvfw32" type="win32dll" baseaddress="${BASEADDRESS_MSVFW32}" installbase="system32" installname="msvfw32.dll" allowwarnings="true"> +<module name="msvfw32" type="win32dll" baseaddress="${BASEADDRESS_MSVFW32}" installbase="system32" installname="msvfw32.dll"> <importlibrary definition="msvfw32.spec" /> <include base="msvfw32">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/msxml3/msxml3.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msxml3/msxml3.rb… ============================================================================== --- trunk/reactos/dll/win32/msxml3/msxml3.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msxml3/msxml3.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,5 +1,5 @@ <group> -<module name="msxml3" type="win32dll" baseaddress="${BASEADDRESS_MSXML3}" installbase="system32" installname="msxml3.dll" allowwarnings="true" crt="msvcrt"> +<module name="msxml3" type="win32dll" baseaddress="${BASEADDRESS_MSXML3}" installbase="system32" installname="msxml3.dll" crt="msvcrt"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="msxml3.spec" /> <include base="msxml3">.</include> Modified: trunk/reactos/dll/win32/nddeapi/nddeapi.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/nddeapi/nddeapi.… ============================================================================== --- trunk/reactos/dll/win32/nddeapi/nddeapi.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/nddeapi/nddeapi.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,4 +1,4 @@ -<module name="nddeapi" type="win32dll" baseaddress="${BASEADDRESS_NDDEAPI}" installbase="system32" installname="nddeapi.dll" allowwarnings="true" entrypoint="0"> +<module name="nddeapi" type="win32dll" baseaddress="${BASEADDRESS_NDDEAPI}" installbase="system32" installname="nddeapi.dll" entrypoint="0"> <importlibrary definition="nddeapi.spec" /> <include base="nddeapi">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/netapi32/netapi32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netapi32/netapi3… ============================================================================== --- trunk/reactos/dll/win32/netapi32/netapi32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/netapi32/netapi32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="netapi32" type="win32dll" baseaddress="${BASEADDRESS_NETAPI32}" installbase="system32" installname="netapi32.dll" allowwarnings="true"> +<module name="netapi32" type="win32dll" baseaddress="${BASEADDRESS_NETAPI32}" installbase="system32" installname="netapi32.dll"> <importlibrary definition="netapi32.spec" /> <include base="netapi32">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/ntdsapi/ntdsapi.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ntdsapi/ntdsapi.… ============================================================================== --- trunk/reactos/dll/win32/ntdsapi/ntdsapi.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/ntdsapi/ntdsapi.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,4 +1,4 @@ -<module name="ntdsapi" type="win32dll" baseaddress="${BASEADDRESS_NTDSAPI}" installbase="system32" installname="ntdsapi.dll" allowwarnings="true" entrypoint="0"> +<module name="ntdsapi" type="win32dll" baseaddress="${BASEADDRESS_NTDSAPI}" installbase="system32" installname="ntdsapi.dll" entrypoint="0"> <importlibrary definition="ntdsapi.spec" /> <include base="ntdsapi">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/objsel/objsel.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/objsel/objsel.rb… ============================================================================== --- trunk/reactos/dll/win32/objsel/objsel.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/objsel/objsel.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="objsel" type="win32dll" baseaddress="${BASEADDRESS_OBJSEL}" installbase="system32" installname="objsel.dll" allowwarnings="true"> +<module name="objsel" type="win32dll" baseaddress="${BASEADDRESS_OBJSEL}" installbase="system32" installname="objsel.dll"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="objsel.spec" /> <include base="objsel">.</include> Modified: trunk/reactos/dll/win32/odbccp32/odbccp32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/odbccp32/odbccp3… ============================================================================== --- trunk/reactos/dll/win32/odbccp32/odbccp32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/odbccp32/odbccp32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="odbccp32" type="win32dll" baseaddress="${BASEADDRESS_ODBCCP32}" installbase="system32" installname="odbccp32.dll" allowwarnings="true" entrypoint="0"> +<module name="odbccp32" type="win32dll" baseaddress="${BASEADDRESS_ODBCCP32}" installbase="system32" installname="odbccp32.dll" entrypoint="0"> <importlibrary definition="odbccp32.spec" /> <include base="odbccp32">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/ole32/ole32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ole32/ole32.rbui… ============================================================================== --- trunk/reactos/dll/win32/ole32/ole32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/ole32/ole32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="ole32" type="win32dll" baseaddress="${BASEADDRESS_OLE32}" installbase="system32" installname="ole32.dll" allowwarnings="true"> +<module name="ole32" type="win32dll" baseaddress="${BASEADDRESS_OLE32}" installbase="system32" installname="ole32.dll"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="ole32.spec" /> <include base="ole32">.</include> @@ -73,7 +73,7 @@ <module name="ole32_irot_client" type="rpcclient"> <file>irot.idl</file> </module> -<module name="ole32_proxy" type="rpcproxy" allowwarnings="true"> +<module name="ole32_proxy" type="rpcproxy"> <define name="_OLE32_" /> <define name="COM_NO_WINDOWS_H" /> <define name="__WINESRC__" /> Modified: trunk/reactos/dll/win32/oleacc/oleacc.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/oleacc/oleacc.rb… ============================================================================== --- trunk/reactos/dll/win32/oleacc/oleacc.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/oleacc/oleacc.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="oleacc" type="win32dll" baseaddress="${BASEADDRESS_OLEACC}" installbase="system32" installname="oleacc.dll" allowwarnings="true" entrypoint="0"> +<module name="oleacc" type="win32dll" baseaddress="${BASEADDRESS_OLEACC}" installbase="system32" installname="oleacc.dll" entrypoint="0"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="oleacc.spec" /> <include base="oleacc">.</include> Modified: trunk/reactos/dll/win32/oleaut32/oleaut32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/oleaut32/oleaut3… ============================================================================== --- trunk/reactos/dll/win32/oleaut32/oleaut32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/oleaut32/oleaut32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="oleaut32" type="win32dll" baseaddress="${BASEADDRESS_OLEAUT32}" installbase="system32" installname="oleaut32.dll" allowwarnings="true" crt="msvcrt"> +<module name="oleaut32" type="win32dll" baseaddress="${BASEADDRESS_OLEAUT32}" installbase="system32" installname="oleaut32.dll" crt="msvcrt"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="oleaut32.spec" /> <include base="oleaut32">.</include> @@ -49,7 +49,7 @@ <library>uuid</library> <library>pseh</library> </module> -<module name="oleaut32_proxy" type="rpcproxy" allowwarnings="true"> +<module name="oleaut32_proxy" type="rpcproxy"> <define name="COM_NO_WINDOWS_H"/> <define name="PROXY_CLSID">CLSID_PSDispatch</define> <define name="_OLEAUT32_"/> Modified: trunk/reactos/dll/win32/oleaut32/oleaut32_ros.diff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/oleaut32/oleaut3… ============================================================================== --- trunk/reactos/dll/win32/oleaut32/oleaut32_ros.diff [iso-8859-1] (original) +++ trunk/reactos/dll/win32/oleaut32/oleaut32_ros.diff [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -72,15 +72,3 @@ /* * FIXME: -Index: oleaut32.rbuild -=================================================================== ---- oleaut32.rbuild (revision 23782) -+++ oleaut32.rbuild (working copy) -@@ -43,6 +43,7 @@ - <library>comctl32</library> - <library>urlmon</library> - <library>uuid</library> -+ <library>pseh</library> - </module> - <module name="oleaut32_oleaut32_oaidl_proxy" type="rpcproxy" allowwarnings="true"> - <file>oleaut32_oaidl.idl</file> Modified: trunk/reactos/dll/win32/oledlg/oledlg.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/oledlg/oledlg.rb… ============================================================================== --- trunk/reactos/dll/win32/oledlg/oledlg.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/oledlg/oledlg.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="oledlg" type="win32dll" baseaddress="${BASEADDRESS_OLEDLG}" installbase="system32" installname="oledlg.dll" allowwarnings="true"> +<module name="oledlg" type="win32dll" baseaddress="${BASEADDRESS_OLEDLG}" installbase="system32" installname="oledlg.dll"> <importlibrary definition="oledlg.spec" /> <include base="oledlg">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/olepro32/olepro32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/olepro32/olepro3… ============================================================================== --- trunk/reactos/dll/win32/olepro32/olepro32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/olepro32/olepro32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="olepro32" type="win32dll" entrypoint="0" baseaddress="${BASEADDRESS_OLEPRO32}" installbase="system32" installname="olepro32.dll" allowwarnings="true"> +<module name="olepro32" type="win32dll" entrypoint="0" baseaddress="${BASEADDRESS_OLEPRO32}" installbase="system32" installname="olepro32.dll"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="olepro32.spec" /> <include base="olepro32">.</include> Modified: trunk/reactos/dll/win32/pdh/pdh.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/pdh/pdh.rbuild?r… ============================================================================== --- trunk/reactos/dll/win32/pdh/pdh.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/pdh/pdh.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,4 +1,4 @@ -<module name="pdh" type="win32dll" baseaddress="${BASEADDRESS_PDH}" installbase="system32" installname="pdh.dll" allowwarnings="true" entrypoint="0"> +<module name="pdh" type="win32dll" baseaddress="${BASEADDRESS_PDH}" installbase="system32" installname="pdh.dll" entrypoint="0"> <importlibrary definition="pdh.spec" /> <include base="pdh">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/printui/printui.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/printui/printui.… ============================================================================== --- trunk/reactos/dll/win32/printui/printui.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/printui/printui.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,4 +1,4 @@ -<module name="printui" type="win32dll" baseaddress="${BASEADDRESS_PRINTUI}" installbase="system32" installname="printui.dll" allowwarnings="true" entrypoint="0"> +<module name="printui" type="win32dll" baseaddress="${BASEADDRESS_PRINTUI}" installbase="system32" installname="printui.dll" entrypoint="0"> <importlibrary definition="printui.spec" /> <include base="printui">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/rasapi32/rasapi32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rasapi32/rasapi3… ============================================================================== --- trunk/reactos/dll/win32/rasapi32/rasapi32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/rasapi32/rasapi32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="rasapi32" type="win32dll" entrypoint="0" baseaddress="${BASEADDRESS_RASAPI32}" installbase="system32" installname="rasapi32.dll" allowwarnings="true"> +<module name="rasapi32" type="win32dll" entrypoint="0" baseaddress="${BASEADDRESS_RASAPI32}" installbase="system32" installname="rasapi32.dll"> <importlibrary definition="rasapi32.spec" /> <include base="rasapi32">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/riched20/riched20.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/riched20/riched2… ============================================================================== --- trunk/reactos/dll/win32/riched20/riched20.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/riched20/riched20.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,12 +1,12 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="riched20" type="win32dll" baseaddress="${BASEADDRESS_RICHED20}" installbase="system32" installname="riched20.dll" allowwarnings="true"> +<module name="riched20" type="win32dll" baseaddress="${BASEADDRESS_RICHED20}" installbase="system32" installname="riched20.dll"> <importlibrary definition="riched20.spec" /> - <compilerflag compiler="cc">-Wno-format</compilerflag> <include base="riched20">.</include> <include base="ReactOS">include/reactos/wine</include> <define name="__WINESRC__" /> + <define name="__ROS_LONG64__" /> <linkerflag>-enable-stdcall-fixup</linkerflag> <file>caret.c</file> <file>clipboard.c</file> Modified: trunk/reactos/dll/win32/riched32/riched32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/riched32/riched3… ============================================================================== --- trunk/reactos/dll/win32/riched32/riched32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/riched32/riched32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="riched32" type="win32dll" baseaddress="${BASEADDRESS_RICHED32}" installbase="system32" installname="riched32.dll" allowwarnings="true"> +<module name="riched32" type="win32dll" baseaddress="${BASEADDRESS_RICHED32}" installbase="system32" installname="riched32.dll"> <importlibrary definition="riched32.spec" /> <include base="riched32">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/rpcrt4/rpcrt4.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/rpcrt4.rb… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/rpcrt4.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/rpcrt4/rpcrt4.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,4 +1,4 @@ -<module name="rpcrt4" type="win32dll" baseaddress="${BASEADDRESS_RPCRT4}" installbase="system32" installname="rpcrt4.dll" allowwarnings="true" crt="msvcrt"> +<module name="rpcrt4" type="win32dll" baseaddress="${BASEADDRESS_RPCRT4}" installbase="system32" installname="rpcrt4.dll" crt="msvcrt"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="rpcrt4.spec" /> <include base="rpcrt4">.</include> Modified: trunk/reactos/dll/win32/rsabase/rsabase.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rsabase/rsabase.… ============================================================================== --- trunk/reactos/dll/win32/rsabase/rsabase.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/rsabase/rsabase.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="rsabase" type="win32dll" baseaddress="${BASEADDRESS_RSABASE}" installbase="system32" installname="rsabase.dll" allowwarnings="true" entrypoint="0"> +<module name="rsabase" type="win32dll" baseaddress="${BASEADDRESS_RSABASE}" installbase="system32" installname="rsabase.dll" entrypoint="0"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="rsabase.spec" /> <include base="rsabase">.</include> Modified: trunk/reactos/dll/win32/rsaenh/rsaenh.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rsaenh/rsaenh.rb… ============================================================================== --- trunk/reactos/dll/win32/rsaenh/rsaenh.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/rsaenh/rsaenh.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="rsaenh" type="win32dll" baseaddress="${BASEADDRESS_RSAENH}" installbase="system32" installname="rsaenh.dll" allowwarnings="true" crt="msvcrt"> +<module name="rsaenh" type="win32dll" baseaddress="${BASEADDRESS_RSAENH}" installbase="system32" installname="rsaenh.dll" crt="msvcrt"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="rsaenh.spec" /> <include base="rsaenh">.</include> Modified: trunk/reactos/dll/win32/schannel/schannel.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/schannel/schanne… ============================================================================== --- trunk/reactos/dll/win32/schannel/schannel.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/schannel/schannel.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="schannel" type="win32dll" baseaddress="${BASEADDRESS_SCHANNEL}" installbase="system32" installname="schannel.dll" allowwarnings="true"> +<module name="schannel" type="win32dll" baseaddress="${BASEADDRESS_SCHANNEL}" installbase="system32" installname="schannel.dll"> <importlibrary definition="schannel.spec" /> <include base="schannel">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/sensapi/sensapi.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/sensapi/sensapi.… ============================================================================== --- trunk/reactos/dll/win32/sensapi/sensapi.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/sensapi/sensapi.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="sensapi" type="win32dll" baseaddress="${BASEADDRESS_SENSAPI}" installbase="system32" installname="sensapi.dll" allowwarnings="true"> +<module name="sensapi" type="win32dll" baseaddress="${BASEADDRESS_SENSAPI}" installbase="system32" installname="sensapi.dll"> <importlibrary definition="sensapi.spec" /> <include base="sensapi">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/setupapi/setupapi.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/setupap… ============================================================================== --- trunk/reactos/dll/win32/setupapi/setupapi.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/setupapi/setupapi.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="setupapi" type="win32dll" baseaddress="${BASEADDRESS_SETUPAPI}" installbase="system32" installname="setupapi.dll" allowwarnings="true" unicode="yes" crt="msvcrt"> +<module name="setupapi" type="win32dll" baseaddress="${BASEADDRESS_SETUPAPI}" installbase="system32" installname="setupapi.dll" unicode="yes" crt="msvcrt"> <importlibrary definition="setupapi.spec" /> <include base="setupapi">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/sfc/sfc.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/sfc/sfc.rbuild?r… ============================================================================== --- trunk/reactos/dll/win32/sfc/sfc.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/sfc/sfc.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,4 +1,4 @@ -<module name="sfc" type="win32dll" baseaddress="${BASEADDRESS_SFC}" installbase="system32" installname="sfc.dll" allowwarnings="yes"> +<module name="sfc" type="win32dll" baseaddress="${BASEADDRESS_SFC}" installbase="system32" installname="sfc.dll"> <importlibrary definition="sfc.spec" /> <include base="sfc">.</include> <library>kernel32</library> Modified: trunk/reactos/dll/win32/sfc_os/sfc_os.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/sfc_os/sfc_os.rb… ============================================================================== --- trunk/reactos/dll/win32/sfc_os/sfc_os.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/sfc_os/sfc_os.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,4 +1,4 @@ -<module name="sfc_os" type="win32dll" baseaddress="${BASEADDRESS_SFC_OS}" installbase="system32" installname="sfc_os.dll" allowwarnings="yes"> +<module name="sfc_os" type="win32dll" baseaddress="${BASEADDRESS_SFC_OS}" installbase="system32" installname="sfc_os.dll"> <importlibrary definition="sfc_os.spec" /> <include base="sfc_os">.</include> <library>kernel32</library> Modified: trunk/reactos/dll/win32/shfolder/shfolder.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shfolder/shfolde… ============================================================================== --- trunk/reactos/dll/win32/shfolder/shfolder.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shfolder/shfolder.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="shfolder" type="win32dll" baseaddress="${BASEADDRESS_SHFOLDER}" installbase="system32" installname="shfolder.dll" allowwarnings="true" entrypoint="0"> +<module name="shfolder" type="win32dll" baseaddress="${BASEADDRESS_SHFOLDER}" installbase="system32" installname="shfolder.dll" entrypoint="0"> <importlibrary definition="shfolder.spec" /> <include base="shfolder">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/shlwapi/shlwapi.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shlwapi/shlwapi.… ============================================================================== --- trunk/reactos/dll/win32/shlwapi/shlwapi.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shlwapi/shlwapi.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="shlwapi" type="win32dll" baseaddress="${BASEADDRESS_SHLWAPI}" installbase="system32" installname="shlwapi.dll" allowwarnings="true"> +<module name="shlwapi" type="win32dll" baseaddress="${BASEADDRESS_SHLWAPI}" installbase="system32" installname="shlwapi.dll"> <importlibrary definition="shlwapi.spec" /> <include base="shlwapi">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/spoolss/spoolss.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/spoolss/spoolss.… ============================================================================== --- trunk/reactos/dll/win32/spoolss/spoolss.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/spoolss/spoolss.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="spoolss" type="win32dll" baseaddress="${BASEADDRESS_SPOOLSS}" installbase="system32" installname="spoolss.dll" allowwarnings="true"> +<module name="spoolss" type="win32dll" baseaddress="${BASEADDRESS_SPOOLSS}" installbase="system32" installname="spoolss.dll"> <importlibrary definition="spoolss.spec" /> <include base="spoolss">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/sxs/sxs.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/sxs/sxs.rbuild?r… ============================================================================== --- trunk/reactos/dll/win32/sxs/sxs.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/sxs/sxs.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="sxs" type="win32dll" baseaddress="${BASEADDRESS_SXS}" installbase="system32" installname="sxs.dll" allowwarnings="true" entrypoint="0"> +<module name="sxs" type="win32dll" baseaddress="${BASEADDRESS_SXS}" installbase="system32" installname="sxs.dll" entrypoint="0"> <importlibrary definition="sxs.spec" /> <include base="sxs">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/syssetup/syssetup.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/syssetu… ============================================================================== --- trunk/reactos/dll/win32/syssetup/syssetup.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/syssetup/syssetup.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,4 +1,4 @@ -<module name="syssetup" type="win32dll" baseaddress="${BASEADDRESS_SYSSETUP}" installbase="system32" installname="syssetup.dll" unicode="yes" allowwarnings="true" crt="msvcrt"> +<module name="syssetup" type="win32dll" baseaddress="${BASEADDRESS_SYSSETUP}" installbase="system32" installname="syssetup.dll" unicode="yes" crt="msvcrt"> <importlibrary definition="syssetup.def" /> <include base="syssetup">.</include> <library>pseh</library> Modified: trunk/reactos/dll/win32/tapi32/tapi32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/tapi32/tapi32.rb… ============================================================================== --- trunk/reactos/dll/win32/tapi32/tapi32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/tapi32/tapi32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="tapi32" type="win32dll" baseaddress="${BASEADDRESS_TAPI32}" installbase="system32" installname="tapi32.dll" allowwarnings="true" entrypoint="0"> +<module name="tapi32" type="win32dll" baseaddress="${BASEADDRESS_TAPI32}" installbase="system32" installname="tapi32.dll" entrypoint="0"> <importlibrary definition="tapi32.spec" /> <include base="tapi32">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/twain_32/twain_32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/twain_32/twain_3… ============================================================================== --- trunk/reactos/dll/win32/twain_32/twain_32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/twain_32/twain_32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,4 +1,4 @@ -<module name="twain_32" type="win32dll" baseaddress="${BASEADDRESS_TWAIN_32}" installbase="system32" installname="twain_32.dll" allowwarnings="true" crt="msvcrt"> +<module name="twain_32" type="win32dll" baseaddress="${BASEADDRESS_TWAIN_32}" installbase="system32" installname="twain_32.dll" crt="msvcrt"> <importlibrary definition="twain_32.def" /> <include base="twain_32">.</include> <define name="_DISABLE_TIDENTS" /> Modified: trunk/reactos/dll/win32/urlmon/urlmon.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/urlmon/urlmon.rb… ============================================================================== --- trunk/reactos/dll/win32/urlmon/urlmon.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/urlmon/urlmon.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="urlmon" type="win32dll" baseaddress="${BASEADDRESS_URLMON}" installbase="system32" installname="urlmon.dll" allowwarnings="true"> +<module name="urlmon" type="win32dll" baseaddress="${BASEADDRESS_URLMON}" installbase="system32" installname="urlmon.dll"> <autoregister infsection="OleControlDlls" type="Both" /> <importlibrary definition="urlmon.spec" /> <include base="urlmon">.</include> Modified: trunk/reactos/dll/win32/usp10/usp10.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/usp10/usp10.rbui… ============================================================================== --- trunk/reactos/dll/win32/usp10/usp10.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/usp10/usp10.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="usp10" type="win32dll" baseaddress="${BASEADDRESS_USP10}" installbase="system32" installname="usp10.dll" allowwarnings="true"> +<module name="usp10" type="win32dll" baseaddress="${BASEADDRESS_USP10}" installbase="system32" installname="usp10.dll"> <importlibrary definition="usp10.spec" /> <include base="usp10">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/uxtheme/uxtheme.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/uxtheme/uxtheme.… ============================================================================== --- trunk/reactos/dll/win32/uxtheme/uxtheme.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/uxtheme/uxtheme.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="uxtheme" type="win32dll" baseaddress="${BASEADDRESS_UXTHEME}" installbase="system32" installname="uxtheme.dll" allowwarnings="true"> +<module name="uxtheme" type="win32dll" baseaddress="${BASEADDRESS_UXTHEME}" installbase="system32" installname="uxtheme.dll"> <importlibrary definition="uxtheme.spec" /> <include base="uxtheme">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/version/version.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/version/version.… ============================================================================== --- trunk/reactos/dll/win32/version/version.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/version/version.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="version" type="win32dll" baseaddress="${BASEADDRESS_VERSION}" installbase="system32" installname="version.dll" allowwarnings="true" entrypoint="0"> +<module name="version" type="win32dll" baseaddress="${BASEADDRESS_VERSION}" installbase="system32" installname="version.dll" entrypoint="0"> <importlibrary definition="version.spec" /> <include base="version">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/winfax/winfax.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/winfax/winfax.rb… ============================================================================== --- trunk/reactos/dll/win32/winfax/winfax.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/winfax/winfax.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,4 +1,4 @@ -<module name="winfax" type="win32dll" baseaddress="${BASEADDRESS_WINFAX}" installbase="system32" installname="winfax.dll" allowwarnings="true" entrypoint="0"> +<module name="winfax" type="win32dll" baseaddress="${BASEADDRESS_WINFAX}" installbase="system32" installname="winfax.dll" entrypoint="0"> <importlibrary definition="winfax.def" /> <include base="winfax">.</include> <library>kernel32</library> Modified: trunk/reactos/dll/win32/winspool/winspool.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/winspool/winspoo… ============================================================================== --- trunk/reactos/dll/win32/winspool/winspool.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/winspool/winspool.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,4 +1,4 @@ -<module name="winspool" type="win32dll" extension=".drv" baseaddress="${BASEADDRESS_WINSPOOL}" installbase="system32" installname="winspool.drv" allowwarnings="true" unicode="yes"> +<module name="winspool" type="win32dll" extension=".drv" baseaddress="${BASEADDRESS_WINSPOOL}" installbase="system32" installname="winspool.drv" unicode="yes"> <importlibrary definition="winspool.spec" /> <include base="winspool">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/wintrust/wintrust.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wintrust/wintrus… ============================================================================== --- trunk/reactos/dll/win32/wintrust/wintrust.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/wintrust/wintrust.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,4 +1,4 @@ -<module name="wintrust" type="win32dll" baseaddress="${BASEADDRESS_WINTRUST}" installbase="system32" installname="wintrust.dll" allowwarnings="true"> +<module name="wintrust" type="win32dll" baseaddress="${BASEADDRESS_WINTRUST}" installbase="system32" installname="wintrust.dll"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="wintrust.spec" /> <include base="wintrust">.</include> Modified: trunk/reactos/dll/win32/wldap32/wldap32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wldap32/wldap32.… ============================================================================== --- trunk/reactos/dll/win32/wldap32/wldap32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/wldap32/wldap32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="wldap32" type="win32dll" baseaddress="${BASEADDRESS_WLDAP32}" installbase="system32" installname="wldap32.dll" allowwarnings="true"> +<module name="wldap32" type="win32dll" baseaddress="${BASEADDRESS_WLDAP32}" installbase="system32" installname="wldap32.dll"> <importlibrary definition="wldap32.spec" /> <include base="wldap32">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/dll/win32/wtsapi32/wtsapi32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wtsapi32/wtsapi3… ============================================================================== --- trunk/reactos/dll/win32/wtsapi32/wtsapi32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/wtsapi32/wtsapi32.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="wtsapi32" type="win32dll" baseaddress="${BASEADDRESS_WTSAPI32}" installbase="system32" installname="wtsapi32.dll" allowwarnings="true"> +<module name="wtsapi32" type="win32dll" baseaddress="${BASEADDRESS_WTSAPI32}" installbase="system32" installname="wtsapi32.dll"> <importlibrary definition="wtsapi32.spec" /> <include base="wtsapi32">.</include> <include base="ReactOS">include/reactos/wine</include> Modified: trunk/reactos/drivers/wdm/audio/drivers/sb16/sb16.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/drivers/… ============================================================================== --- trunk/reactos/drivers/wdm/audio/drivers/sb16/sb16.rbuild [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/drivers/sb16/sb16.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../../../tools/rbuild/project.dtd"> -<module name="sb16_ks" type="kernelmodedriver" installbase="system32/drivers" installname="sb16_ks.sys" allowwarnings="true"> +<module name="sb16_ks" type="kernelmodedriver" installbase="system32/drivers" installname="sb16_ks.sys"> <include base="sb16_ks">.</include> <include base="sb16_ks">..</include> <library>ntoskrnl</library> Modified: trunk/reactos/include/reactos/idl/idl.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/idl/idl.rb… ============================================================================== --- trunk/reactos/include/reactos/idl/idl.rbuild [iso-8859-1] (original) +++ trunk/reactos/include/reactos/idl/idl.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE group SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="pnp_server" type="rpcserver" allowwarnings="true"> +<module name="pnp_server" type="rpcserver"> <define name="_WIN32_WINNT">0x600</define> <file>pnp.idl</file> </module> @@ -9,19 +9,19 @@ <define name="_WIN32_WINNT">0x600</define> <file>pnp.idl</file> </module> -<module name="scm_server" type="rpcserver" allowwarnings="true"> +<module name="scm_server" type="rpcserver"> <file>svcctl.idl</file> </module> <module name="scm_client" type="rpcclient"> <file>svcctl.idl</file> </module> -<module name="eventlog_server" type="rpcserver" allowwarnings="true"> +<module name="eventlog_server" type="rpcserver"> <file>eventlogrpc.idl</file> </module> <module name="eventlog_client" type="rpcclient" > <file>eventlogrpc.idl</file> </module> -<module name="lsa_server" type="rpcserver" allowwarnings="true"> +<module name="lsa_server" type="rpcserver"> <file>lsa.idl</file> </module> <module name="lsa_client" type="rpcclient"> Modified: trunk/reactos/lib/3rdparty/adns/adns.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/adns/adns.rbu… ============================================================================== --- trunk/reactos/lib/3rdparty/adns/adns.rbuild [iso-8859-1] (original) +++ trunk/reactos/lib/3rdparty/adns/adns.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="adns" type="staticlibrary" allowwarnings="true" crt="dll"> +<module name="adns" type="staticlibrary" crt="dll"> <include base="adns">src</include> <include base="adns">adns_win32</include> <define name="ADNS_JGAA_WIN32" /> Modified: trunk/reactos/lib/3rdparty/expat/expat.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/expat/expat.r… ============================================================================== --- trunk/reactos/lib/3rdparty/expat/expat.rbuild [iso-8859-1] (original) +++ trunk/reactos/lib/3rdparty/expat/expat.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="expat" type="staticlibrary" allowwarnings="true"> +<module name="expat" type="staticlibrary"> <include base="expat">.</include> <include base="expat">lib</include> <include base="ReactOS">include/reactos/libs/expat</include> Modified: trunk/reactos/lib/sdk/uuid/uuid.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/uuid/uuid.rbuild?r… ============================================================================== --- trunk/reactos/lib/sdk/uuid/uuid.rbuild [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/uuid/uuid.rbuild [iso-8859-1] Mon Jan 19 13:44:55 2009 @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="uuid" type="staticlibrary" allowwarnings="true"> +<module name="uuid" type="staticlibrary"> <include base="ReactOS">include/reactos/wine</include> <define name="_DISABLE_TIDENTS" /> <file>uuid.c</file>

1 0

Re: [ros-dev] [ros-diffs] [cwittich] 38928: fix some kernel32 virtual winetests
by Timo Kreuzer 19 Jan '09

19 Jan '09

cwittich(a)svn.reactos.org schrieb: > Author: cwittich > Date: Mon Jan 19 02:02:26 2009 > New Revision: 38928 > > URL: http://svn.reactos.org/svn/reactos?rev=38928&view=rev > Log: > fix some kernel32 virtual winetests > > Modified: > trunk/reactos/ntoskrnl/mm/anonmem.c > > Modified: trunk/reactos/ntoskrnl/mm/anonmem.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/anonmem.c?rev=… > ============================================================================== > --- trunk/reactos/ntoskrnl/mm/anonmem.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/anonmem.c [iso-8859-1] Mon Jan 19 02:02:26 2009 > @@ -569,7 +569,7 @@ > Protect); > > /* Check for valid protection flags */ > - if ((Protect & PAGE_FLAGS_VALID_FROM_USER_MODE) != Protect) > + if ((!Protect & PAGE_FLAGS_VALID_FROM_USER_MODE)) > Do you mean "if (Protect & ~PAGE_FLAGS_VALID_FROM_USER_MODE)" ?

1 0

Re: [ros-dev] [ros-diffs] [sginsberg] 38922: - Fix more InterlockedCompareExchangePointer warnings in crypt32 -- this to Wine, too - Hack-0-initialize a variable in cryptui to satisfy gcc -- this needed as Wine use a less retarded gcc than we do - Warning fix old a
by Ged 19 Jan '09

19 Jan '09

sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Sun Jan 18 17:31:26 2009 > New Revision: 38922 > > URL: http://svn.reactos.org/svn/reactos?rev=38922&view=rev > Log: > - Fix more InterlockedCompareExchangePointer warnings in crypt32 -- this to Wine, too > > Added: > trunk/reactos/dll/win32/crypt32/warningfixes.diff This is a bad idea. It's painful enough keeping wine libs in sync without adding to the complexity with non-needed warning fixes. Ged.

2 1

Re: [ros-dev] [ros-diffs] [hyperion] 38872: Warning killing commit modified include/psdk/basetsd.h modified include/psdk/windef.h modified include/psdk/winnt.h Introduce new define __ROS_LONG64__ ("assume 64-bit long"), to use int instead of long in typedefs of 32-bit integers __ROS_LONG64__ automatically defined if __WINESRC__ is defined. No, __WINESRC__ alone is not enough modified base/applications/winhlp32/winhlp32.rbuild modified base/applications/wordpad/wordpad.rbuild Compile with __ROS_LONG64__ defi
by Timo Kreuzer 18 Jan '09

18 Jan '09

hyperion(a)svn.reactos.org schrieb: > Author: hyperion > Date: Sun Jan 18 00:25:43 2009 > New Revision: 38872 > > ... > Introduce new define __ROS_LONG64__ ("assume 64-bit long"), to use int instead of long in typedefs of 32-bit integers > __ROS_LONG64__ automatically defined if __WINESRC__ is defined. No, __WINESRC__ alone is not enough > If it's defined automatically, why isn't __WINESRC__ alone enough? And when it's not enough anyway, why define __ROS_LONG64__ automatically at all? ... > #else /* !_WIN64 */ > +#if !defined(__ROS_LONG64__) > typedef int INT_PTR, *PINT_PTR; > typedef unsigned int UINT_PTR, *PUINT_PTR; > +#else > +typedef long INT_PTR, *PINT_PTR; > +typedef unsigned long UINT_PTR, *PUINT_PTR; > +#endif > If we assume a 64bit long, why define INT_PTR to long on 32 bit target?

2 1

ReactOS booth/speech at Linux days in Kiel?
by Aleksey Bragin 12 Jan '09

12 Jan '09

> From: Hauke Goos-Habermann <HHabermann(a)pc-kiel.de> > Date: January 12, 2009 4:53:40 PM GMT+03:00 > To: aleksey(a)reactos.org > Subject: ReactOS booth/speech at Linux days in Kiel? > > Hi Aleksey, > > for the Linux days in Kiel in Germany we are searching for > interesting OSS > projects. Can you tell me if there are members of ReactOS that may be > interested in a booth or/and giving a presentation? The "Kieler > Linux- und > -OpenSource Tage" will be at 2nd and 3rd of october. > > Additional information (in German only) can be found at: www.kieler- > linuxtage.de > > PS. Please forward the mail to interested members. > > Cu Hauke > > -- > > Stoppt Softwarepatente, sonst wird Softwareentwicklung in Europa > für die meisten > illegal! > Patentfrei sichert IT-Arbeitsplätze (www.patentfrei.de)

1 0

[ros-diffs] [tkreuzer] 38673: Inline wrappers user32 -> NtUser
by Dmitry Gorbachev 11 Jan '09

11 Jan '09

> Sorry I didn't quite get it. ;-) What is ok atm? How are we going to > handle it? Extern inline is ok atm. ;-) I mean that it works well now. And when its behavior will be changed, gnu_inline attribute can be used to get old (i.e., present) behavior.

1 0

[ros-diffs] [tkreuzer] 38673: Inline wrappers user32 -> NtUser
by Dmitry Gorbachev 10 Jan '09

10 Jan '09

> Well that was a workaround, because of "static declaration follows non > static declaration". > Then it needs to be done differently. But I don't see any good solution > that doesn't require lot's of hacks atm, except disabling that warning. It's ok atm. Attribute gnu_inline can be used to get old inline semantics.

2 1

[ros-bugs] [Bug 2451] Firefox 1.5 won't minimize to taskbar.
by James Tabor 10 Jan '09

10 Jan '09

Hi All! Just letting everyone know that a partial fix has been found by Dmitry aka Lentin, it is Dmitry? Well, I updated the bug report and the patch works to a point. FF does try to minimize and there is a hook bug exposed. Yes, not everything is fixed, since we use wine code, this was the reason for the patch. It corrects most of the message bugs related to wine tests. So this patch is going in soon and we need to cleanup the related code. I have a synced User32 Mdi.c that might require this patch to work. Just about the rest of the changes needed are wine sync/ports to user32/win32k. I would hope that everyone can help Dmitry/Lentin out and fix the rest of the SetWindowPos bugs. Some window position code in User32 still needing to be updated.. ;^) Thanks, James Ref: http://www.reactos.org/bugzilla/show_bug.cgi?id=2451

1 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 38678: - Fix 3 wine tests for OpenFile function
by Alex Ionescu 10 Jan '09

10 Jan '09

There's a constant for this INVALID_HANDLE_VALUE... On 10-Jan-09, at 7:33 AM, dchapyshev(a)svn.reactos.org wrote: > case 0xFFFFFFFF: /* File does not exist */ Best regards, Alex Ionescu

1 0

[ros-diffs] [tkreuzer] 38673: Inline wrappers user32 -> NtUser
by Dmitry Gorbachev 10 Jan '09

10 Jan '09

Hi! Why to use extern inline there, FORCEINLINE macro uses static. Extern inline — GCC extension — does not work as needed in c99/gnu99 mode (non-inline functions are emitted as well). GCC documentation says it will be the default in the future.

2 1

Re: [ros-dev] [ros-diffs] [dchapyshev] 38663: - Cleanup user32, direct call to kernel space
by Alex Ionescu 10 Jan '09

10 Jan '09

I totally disagree with this commit. Best regards, Alex Ionescu On Fri, Jan 9, 2009 at 6:33 AM, <dchapyshev(a)svn.reactos.org> wrote: > Author: dchapyshev > Date: Fri Jan 9 05:33:50 2009 > New Revision: 38663 > > URL: http://svn.reactos.org/svn/reactos?rev=38663&view=rev > Log: > - Cleanup user32, direct call to kernel space > > Modified: > trunk/reactos/dll/win32/user32/controls/button.c > trunk/reactos/dll/win32/user32/controls/combo.c > trunk/reactos/dll/win32/user32/controls/edit.c > trunk/reactos/dll/win32/user32/controls/icontitle.c > trunk/reactos/dll/win32/user32/controls/listbox.c > trunk/reactos/dll/win32/user32/controls/scrollbar.c > trunk/reactos/dll/win32/user32/controls/static.c > trunk/reactos/dll/win32/user32/misc/dde.c > trunk/reactos/dll/win32/user32/misc/ddeserver.c > trunk/reactos/dll/win32/user32/misc/desktop.c > trunk/reactos/dll/win32/user32/misc/misc.c > trunk/reactos/dll/win32/user32/misc/object.c > trunk/reactos/dll/win32/user32/misc/stubs.c > trunk/reactos/dll/win32/user32/misc/timer.c > trunk/reactos/dll/win32/user32/misc/winsta.c > trunk/reactos/dll/win32/user32/user32.def > trunk/reactos/dll/win32/user32/windows/accel.c > trunk/reactos/dll/win32/user32/windows/bitmap.c > trunk/reactos/dll/win32/user32/windows/caret.c > trunk/reactos/dll/win32/user32/windows/clipboard.c > trunk/reactos/dll/win32/user32/windows/cursor.c > trunk/reactos/dll/win32/user32/windows/dc.c > trunk/reactos/dll/win32/user32/windows/defwnd.c > trunk/reactos/dll/win32/user32/windows/dialog.c > trunk/reactos/dll/win32/user32/windows/draw.c > trunk/reactos/dll/win32/user32/windows/input.c > trunk/reactos/dll/win32/user32/windows/mdi.c > trunk/reactos/dll/win32/user32/windows/menu.c > trunk/reactos/dll/win32/user32/windows/message.c > trunk/reactos/dll/win32/user32/windows/messagebox.c > trunk/reactos/dll/win32/user32/windows/nonclient.c > trunk/reactos/dll/win32/user32/windows/paint.c > trunk/reactos/dll/win32/user32/windows/window.c > trunk/reactos/dll/win32/user32/windows/winpos.c > > [This mail would be too long, it was shortened to contain the URLs only.] > > Modified: trunk/reactos/dll/win32/user32/controls/button.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/… > > Modified: trunk/reactos/dll/win32/user32/controls/combo.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/… > > Modified: trunk/reactos/dll/win32/user32/controls/edit.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/… > > Modified: trunk/reactos/dll/win32/user32/controls/icontitle.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/… > > Modified: trunk/reactos/dll/win32/user32/controls/listbox.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/… > > Modified: trunk/reactos/dll/win32/user32/controls/scrollbar.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/… > > Modified: trunk/reactos/dll/win32/user32/controls/static.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/… > > Modified: trunk/reactos/dll/win32/user32/misc/dde.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/dde.… > > Modified: trunk/reactos/dll/win32/user32/misc/ddeserver.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/ddes… > > Modified: trunk/reactos/dll/win32/user32/misc/desktop.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/desk… > > Modified: trunk/reactos/dll/win32/user32/misc/misc.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/misc… > > Modified: trunk/reactos/dll/win32/user32/misc/object.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/obje… > > Modified: trunk/reactos/dll/win32/user32/misc/stubs.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/stub… > > Modified: trunk/reactos/dll/win32/user32/misc/timer.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/time… > > Modified: trunk/reactos/dll/win32/user32/misc/winsta.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/wins… > > Modified: trunk/reactos/dll/win32/user32/user32.def > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/user32.de… > > Modified: trunk/reactos/dll/win32/user32/windows/accel.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/a… > > Modified: trunk/reactos/dll/win32/user32/windows/bitmap.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/b… > > Modified: trunk/reactos/dll/win32/user32/windows/caret.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/c… > > Modified: trunk/reactos/dll/win32/user32/windows/clipboard.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/c… > > Modified: trunk/reactos/dll/win32/user32/windows/cursor.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/c… > > Modified: trunk/reactos/dll/win32/user32/windows/dc.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d… > > Modified: trunk/reactos/dll/win32/user32/windows/defwnd.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d… > > Modified: trunk/reactos/dll/win32/user32/windows/dialog.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d… > > Modified: trunk/reactos/dll/win32/user32/windows/draw.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d… > > Modified: trunk/reactos/dll/win32/user32/windows/input.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/i… > > Modified: trunk/reactos/dll/win32/user32/windows/mdi.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m… > > Modified: trunk/reactos/dll/win32/user32/windows/menu.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m… > > Modified: trunk/reactos/dll/win32/user32/windows/message.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m… > > Modified: trunk/reactos/dll/win32/user32/windows/messagebox.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m… > > Modified: trunk/reactos/dll/win32/user32/windows/nonclient.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/n… > > Modified: trunk/reactos/dll/win32/user32/windows/paint.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/p… > > Modified: trunk/reactos/dll/win32/user32/windows/window.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/w… > > Modified: trunk/reactos/dll/win32/user32/windows/winpos.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/w… > >

7 11

GIT mirror
by Aleksey Bragin 09 Jan '09

09 Jan '09

Since Arty just mentioned GIT, I think it's about time to uncover a ReactOS GIT mirror I've been setting up recent couple of weeks. It works pretty good so far, autoupdates every 10 minutes, so it stays quite up-to-date. URLs: git://git.reactos.org/ - for git cloning. http://git.reactos.org - for web viewing. As for branches, it was actually my main intention in using a DVCS, because SVN branches are greatly uncomfortable to develop anything because of the need to keep the branch up-to-date. But, to prevent any gossips, SVN stays as our main repository, and GIT mirror is just for exploration of new possibilities, and for comfortability of working with branches - if someone wants to try that out. Usual SVN branches are still permitted. WBR, Aleksey Bragin.

11 28

Re: [ros-dev] [ros-diffs] [mjmartin] 38659: - Run process notification routines after successfully creating process.
by Alex Ionescu 09 Jan '09

09 Jan '09

Umm... Best regards, Alex Ionescu On Fri, Jan 9, 2009 at 1:13 AM, <mjmartin(a)svn.reactos.org> wrote: > Author: mjmartin > Date: Fri Jan 9 00:13:14 2009 > New Revision: 38659 > > URL: http://svn.reactos.org/svn/reactos?rev=38659&view=rev > Log: > - Run process notification routines after successfully creating process. > > Modified: > trunk/reactos/ntoskrnl/ps/process.c > > Modified: trunk/reactos/ntoskrnl/ps/process.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/process.c?rev=… > > ============================================================================== > --- trunk/reactos/ntoskrnl/ps/process.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ps/process.c [iso-8859-1] Fri Jan 9 00:13:14 > 2009 > @@ -822,6 +822,9 @@ > } > _SEH2_END; > > + /* Run the Notification Routines */ > + PspRunCreateProcessNotifyRoutines(Process, TRUE); > + > CleanupWithRef: > /* > * Dereference the process. For failures, kills the process and does > >

1 0

Cache / Memory Manager / FileSystemDrivers
by Aleksey Bragin 08 Jan '09

08 Jan '09

Hello, I recently spent some time experimenting with various Cc rewrites we have in our tree, and before that I extensively tested our fastfat driver in a real NT environment (MS Windows 2003). The conclusion of the above work is that our fastfat driver either needs serious bugfixing, or a rewrite is needed. It corrupts directory tables in a real NT, leads to unusual behaviour of cc- rewrite branch, and may have side effects on arty's newcc. Before this is done (bugfixing or rewriting, developing and testing against a Windows 2003 at least, not ReactOS), it's meaningless to continue any other work on Cc and related Mm parts. WBR, Aleksey Bragin.

9 14

[ros-diffs] [hyperion] 38621: PSEH can't make code exception-safe (yet). Add explicit "volatile"s where it might be necessary
by Dmitry Gorbachev 07 Jan '09

07 Jan '09

Maybe better to use a macro, something like _SEH2_VOLATILE, instead of a plain "volatile"?

1 0

[ros-diffs] [jimtabor] 38590: - Patch by Michael Martin: Fix for Get/Set CallProc.
by James Tabor 06 Jan '09

06 Jan '09

Hi all! Here is the test program provided by BugBoy. It also shows another bug, see bug 3971. Please test before and after the patch. Thanks, James PS Good Job, Michael!

1 0

questions about mmc?
by Jack Yi 05 Jan '09

05 Jan '09

Hi,guys I'm just a fan of ReactOS,now I have two questions. 1, Is(or will be) there an disk management utility for ReactOS, or in another way, will we make an implementation of Microsoft diskmgmt.msc? 2, Will ReactOS group make an implementation of Microsoft Management Console for ReactOS? Thank you!

1 0

Re: [ros-dev] [ros-diffs] [fireball] 38552: - Revert changes to NtSetVolumeInformationFile made in 38550, it should indeed use IoGetRelatedDeviceObject, not target device.
by Alex Ionescu 04 Jan '09

04 Jan '09

Yeah, sorry, the target device should be used to send a TARGET_DEVICE_CUSTOM_NOTIFICAITON of type GUID_IO_VOLUME_CHANGE at the end of the function (IoReportTargetDeviceChange). FYI, Pierre, when you implement the notification system. On 4-Jan-09, at 5:12 AM, fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Sun Jan 4 04:12:38 2009 > New Revision: 38552 > > URL: http://svn.reactos.org/svn/reactos?rev=38552&view=rev > Log: > - Revert changes to NtSetVolumeInformationFile made in 38550, it > should indeed use IoGetRelatedDeviceObject, not target device. > > Modified: > trunk/reactos/ntoskrnl/io/iomgr/iofunc.c > > Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iofunc.c… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] Sun Jan 4 > 04:12:38 2009 > @@ -3307,8 +3307,7 @@ > } > > /* Get the device object */ > - Status = IoGetRelatedTargetDevice(FileObject, &DeviceObject); > - if (!NT_SUCCESS(Status)) return Status; > + DeviceObject = IoGetRelatedDeviceObject(FileObject); > > /* Clear File Object event */ > KeClearEvent(&FileObject->Event); > Best regards, Alex Ionescu

1 0

Re: [ros-dev] [ros-diffs] [jimtabor] 38518: - Removed SEH abuse and add notes for the hook code, in NtUserDefSetText. - Update NtUserCallHwndLock subfunctions.
by Timo Kreuzer 03 Jan '09

03 Jan '09

SEH is still needed. SafeText doesn't really deserve it's name, as it's only a safe copy of the UNICODE_STRING structure returned by ProbeForReadUnicodeString(), but with the still unsafe string buffer. Also the Buffer was never probed (ProbeForReadUnicodeString only checks the UNICODE_STRING and copies it) IMO the function is dangerous, as it implies that the Buffer was probed, too. Timo jimtabor(a)svn.reactos.org schrieb: > Author: jimtabor > Date: Fri Jan 2 22:02:54 2009 > New Revision: 38518 > > URL: http://svn.reactos.org/svn/reactos?rev=38518&view=rev > Log: > - Removed SEH abuse and add notes for the hook code, in NtUserDefSetText. > - Update NtUserCallHwndLock subfunctions. > > Modified: > trunk/reactos/subsystems/win32/win32k/ntuser/simplecall.c > trunk/reactos/subsystems/win32/win32k/ntuser/window.c > > ... > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/window.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/window.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/window.c [iso-8859-1] Fri Jan 2 22:02:54 2009 > @@ -4569,57 +4569,47 @@ > } > Wnd = Window->Wnd; > > - if(SafeText.Length != 0) > - { > - _SEH2_TRY > - { > - if (Wnd->WindowName.MaximumLength > 0 && > - SafeText.Length <= Wnd->WindowName.MaximumLength - sizeof(UNICODE_NULL)) > - { > - ASSERT(Wnd->WindowName.Buffer != NULL); > - > - Wnd->WindowName.Length = SafeText.Length; > - Wnd->WindowName.Buffer[SafeText.Length / sizeof(WCHAR)] = L'\0'; > - RtlCopyMemory(Wnd->WindowName.Buffer, > - SafeText.Buffer, > - SafeText.Length); > - } > - else > - { > - PWCHAR buf; > - Wnd->WindowName.MaximumLength = Wnd->WindowName.Length = 0; > - buf = Wnd->WindowName.Buffer; > - Wnd->WindowName.Buffer = NULL; > - if (buf != NULL) > - { > - DesktopHeapFree(Wnd->pdesktop, > - buf); > - } > - > - Wnd->WindowName.Buffer = DesktopHeapAlloc(Wnd->pdesktop, > - SafeText.Length + sizeof(UNICODE_NULL)); > - if (Wnd->WindowName.Buffer != NULL) > - { > - Wnd->WindowName.Buffer[SafeText.Length / sizeof(WCHAR)] = L'\0'; > - RtlCopyMemory(Wnd->WindowName.Buffer, > - SafeText.Buffer, > - SafeText.Length); > - Wnd->WindowName.MaximumLength = SafeText.Length + sizeof(UNICODE_NULL); > - Wnd->WindowName.Length = SafeText.Length; > - } > - else > - { > - SetLastWin32Error(ERROR_NOT_ENOUGH_MEMORY); > - Ret = FALSE; > - } > - } > - } > - _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > - { > - SetLastNtError(_SEH2_GetExceptionCode()); > - Ret = FALSE; > - } > - _SEH2_END; > + if (SafeText.Length != 0) > + { > + if (Wnd->WindowName.MaximumLength > 0 && > + SafeText.Length <= Wnd->WindowName.MaximumLength - sizeof(UNICODE_NULL)) > + { > + ASSERT(Wnd->WindowName.Buffer != NULL); > + > + Wnd->WindowName.Length = SafeText.Length; > + Wnd->WindowName.Buffer[SafeText.Length / sizeof(WCHAR)] = L'\0'; > + RtlCopyMemory(Wnd->WindowName.Buffer, > + SafeText.Buffer, > + SafeText.Length); > + } > + else > + { > + PWCHAR buf; > + Wnd->WindowName.MaximumLength = Wnd->WindowName.Length = 0; > + buf = Wnd->WindowName.Buffer; > + Wnd->WindowName.Buffer = NULL; > + if (buf != NULL) > + { > + DesktopHeapFree(Wnd->pdesktop, buf); > + } > + > + Wnd->WindowName.Buffer = DesktopHeapAlloc(Wnd->pdesktop, > + SafeText.Length + sizeof(UNICODE_NULL)); > + if (Wnd->WindowName.Buffer != NULL) > + { > + Wnd->WindowName.Buffer[SafeText.Length / sizeof(WCHAR)] = L'\0'; > + RtlCopyMemory(Wnd->WindowName.Buffer, > + SafeText.Buffer, > + SafeText.Length); > + Wnd->WindowName.MaximumLength = SafeText.Length + sizeof(UNICODE_NULL); > + Wnd->WindowName.Length = SafeText.Length; > + } > + else > + { > + SetLastWin32Error(ERROR_NOT_ENOUGH_MEMORY); > + Ret = FALSE; > + } > + } > } > else > { > @@ -4628,6 +4618,9 @@ > Wnd->WindowName.Buffer[0] = L'\0'; > } > > + // HAX! FIXME! Windows does not do this in here! > + // In User32, these are called after: NotifyWinEvent EVENT_OBJECT_NAMECHANGE than > + // RepaintButton, StaticRepaint, NtUserCallHwndLock HWNDLOCK_ROUTINE_REDRAWFRAMEANDHOOK, etc. > /* Send shell notifications */ > if (!IntGetOwner(Window) && !IntGetParent(Window)) > { > > >

3 3

Re: [ros-dev] [ros-diffs] [pschweitzer] 38523: - Implemeted Io(p)GetRelatedTargetDevice - Fixed FsRtlNotifyVolumeEvent
by Alex Ionescu 03 Jan '09

03 Jan '09

You can/should use IopGetDeviceNode instead of the ugly (but necessary) triple-casting you have. > + *DeviceNode = (PDEVICE_NODE) > ((PEXTENDED_DEVOBJ_EXTENSION)DeviceRelations->Objects[0]- > >DeviceObjectExtension)->DeviceNode; Also, I believe there is a bug in Nt/IoQuery/SetVolumeInformation -- we call IoGetRelatedDeviceObject instead of IoGetRelatedTargetDevice, because the function was missing. Good job! On 3-Jan-09, at 4:35 AM, pschweitzer(a)svn.reactos.org wrote: > Author: pschweitzer > Date: Sat Jan 3 03:35:10 2009 > New Revision: 38523 > > URL: http://svn.reactos.org/svn/reactos?rev=38523&view=rev > Log: > - Implemeted Io(p)GetRelatedTargetDevice > - Fixed FsRtlNotifyVolumeEvent > > Modified: > branches/pierre-fsd/ntoskrnl/fsrtl/pnp.c > branches/pierre-fsd/ntoskrnl/include/internal/io.h > branches/pierre-fsd/ntoskrnl/io/iomgr/device.c > > Modified: branches/pierre-fsd/ntoskrnl/fsrtl/pnp.c > URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/ntoskrnl/fsrtl/pnp.c… > = > = > = > = > = > = > = > = > ====================================================================== > --- branches/pierre-fsd/ntoskrnl/fsrtl/pnp.c [iso-8859-1] (original) > +++ branches/pierre-fsd/ntoskrnl/fsrtl/pnp.c [iso-8859-1] Sat Jan 3 > 03:35:10 2009 > @@ -43,8 +43,7 @@ > PDEVICE_OBJECT DeviceObject = NULL; > TARGET_DEVICE_CUSTOM_NOTIFICATION Notification; > > - /* FIXME: We should call IoGetRelatedTargetDevice here */ > - DeviceObject = IoGetRelatedDeviceObject(FileObject); > + IoGetRelatedTargetDevice(FileObject, &DeviceObject); > if (DeviceObject) > { > Notification.Version = 1; > > Modified: branches/pierre-fsd/ntoskrnl/include/internal/io.h > URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/ntoskrnl/include/int… > = > = > = > = > = > = > = > = > ====================================================================== > --- branches/pierre-fsd/ntoskrnl/include/internal/io.h [iso-8859-1] > (original) > +++ branches/pierre-fsd/ntoskrnl/include/internal/io.h [iso-8859-1] > Sat Jan 3 03:35:10 2009 > @@ -669,6 +669,12 @@ > IN BOOLEAN ForceUnload > ); > > +NTSTATUS > +NTAPI > +IoGetRelatedTargetDevice(IN PFILE_OBJECT FileObject, > + OUT PDEVICE_OBJECT *DeviceObject > +); > + > // > // IRP Routines > // > > Modified: branches/pierre-fsd/ntoskrnl/io/iomgr/device.c > URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/ntoskrnl/io/iomgr/de… > = > = > = > = > = > = > = > = > ====================================================================== > --- branches/pierre-fsd/ntoskrnl/io/iomgr/device.c [iso-8859-1] > (original) > +++ branches/pierre-fsd/ntoskrnl/io/iomgr/device.c [iso-8859-1] Sat > Jan 3 03:35:10 2009 > @@ -552,6 +552,49 @@ > } > } > > +NTSTATUS > +NTAPI > +IopGetRelatedTargetDevice(IN PFILE_OBJECT FileObject, > + OUT PDEVICE_NODE *DeviceNode) > +{ > + NTSTATUS Status; > + IO_STACK_LOCATION Stack; > + IO_STATUS_BLOCK IoStatusBlock; > + PDEVICE_RELATIONS DeviceRelations; > + PDEVICE_OBJECT DeviceObject = NULL; > + > + ASSERT(FileObject); > + > + /* Get DeviceObject related to given FileObject */ > + DeviceObject = IoGetRelatedDeviceObject(FileObject); > + if (!DeviceObject) > + { > + return STATUS_NO_SUCH_DEVICE; > + } > + > + /* Call the driver to query all the relations (IRP_MJ_PNP) */ > + Status = IopInitiatePnpIrp(DeviceObject, &IoStatusBlock, > + IRP_MN_QUERY_DEVICE_RELATIONS, > &Stack); > + if (NT_SUCCESS(Status)) > + { > + DeviceRelations = > (PDEVICE_RELATIONS)IoStatusBlock.Information; > + ASSERT(DeviceRelations); > + ASSERT(DeviceRelations->Count == 1); > + > + /* We finally get the device node */ > + *DeviceNode = (PDEVICE_NODE) > ((PEXTENDED_DEVOBJ_EXTENSION)DeviceRelations->Objects[0]- > >DeviceObjectExtension)->DeviceNode; > + if (!*DeviceNode) > + { > + Status = STATUS_NO_SUCH_DEVICE; > + } > + > + /* Free the DEVICE_RELATIONS structure, we don't need it > anymore */ > + ExFreePool(DeviceRelations); > + } > + > + return Status; > +} > + > /* PUBLIC FUNCTIONS > ***********************************************************/ > > /* > @@ -1205,6 +1248,26 @@ > > /* Return the DO we found */ > return DeviceObject; > +} > + > +/* > + * @implemented > + */ > +NTSTATUS > +NTAPI > +IoGetRelatedTargetDevice(IN PFILE_OBJECT FileObject, > + OUT PDEVICE_OBJECT *DeviceObject) > +{ > + NTSTATUS Status; > + PDEVICE_NODE DeviceNode = NULL; > + > + /* We call the internal function to do all the work */ > + Status = IopGetRelatedTargetDevice(FileObject, &DeviceNode); > + if (NT_SUCCESS(Status) && DeviceNode) > + { > + *DeviceObject = DeviceNode->PhysicalDeviceObject; > + } > + return Status; > } > > /* > Best regards, Alex Ionescu

2 1

Re: [ros-dev] [ros-diffs] [sginsberg] 38508: - Add Wine's GetPrivateObjectSecurity and use it instead of our that uses the unimplemented RtlQuerySecurityObject routine
by Alex Ionescu 03 Jan '09

03 Jan '09

Please don't do this -- now nobody will know that the Rtl function needs to be called! On 2-Jan-09, at 12:14 PM, sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Fri Jan 2 11:14:42 2009 > New Revision: 38508 > > URL: http://svn.reactos.org/svn/reactos?rev=38508&view=rev > Log: > - Add Wine's GetPrivateObjectSecurity and use it instead of our that > uses the unimplemented RtlQuerySecurityObject routine > > Modified: > trunk/reactos/dll/win32/advapi32/sec/misc.c > > Modified: trunk/reactos/dll/win32/advapi32/sec/misc.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/sec/mis… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/dll/win32/advapi32/sec/misc.c [iso-8859-1] > (original) > +++ trunk/reactos/dll/win32/advapi32/sec/misc.c [iso-8859-1] Fri > Jan 2 11:14:42 2009 > @@ -2250,19 +2250,25 @@ > } > > > +#if 0 > +// > +// Use when RtlQuerySecurityObject is implemented > +// > + > /* > * @implemented > */ > BOOL > WINAPI > -GetPrivateObjectSecurity(PSECURITY_DESCRIPTOR ObjectDescriptor, > - SECURITY_INFORMATION SecurityInformation, > - PSECURITY_DESCRIPTOR ResultantDescriptor, > - DWORD DescriptorLength, > - PDWORD ReturnLength) > +GetPrivateObjectSecurity(IN PSECURITY_DESCRIPTOR ObjectDescriptor, > + IN SECURITY_INFORMATION SecurityInformation, > + OUT PSECURITY_DESCRIPTOR > ResultantDescriptor OPTIONAL, > + IN DWORD DescriptorLength, > + OUT PDWORD ReturnLength) > { > NTSTATUS Status; > > + /* Call RTL */ > Status = RtlQuerySecurityObject(ObjectDescriptor, > SecurityInformation, > ResultantDescriptor, > @@ -2270,12 +2276,73 @@ > ReturnLength); > if (!NT_SUCCESS(Status)) > { > + /* Fail */ > SetLastError(RtlNtStatusToDosError(Status)); > return FALSE; > } > > + /* Success */ > return TRUE; > } > +#else > +// > +// Wine's implementation (as of December 30th 2008) > +// > + > +/* > + * @implemented > + */ > +BOOL > +WINAPI > +GetPrivateObjectSecurity(IN PSECURITY_DESCRIPTOR ObjectDescriptor, > + IN SECURITY_INFORMATION SecurityInformation, > + OUT PSECURITY_DESCRIPTOR > ResultantDescriptor OPTIONAL, > + IN DWORD DescriptorLength, > + OUT PDWORD ReturnLength) > +{ > + SECURITY_DESCRIPTOR desc; > + BOOL defaulted, present; > + PACL pacl; > + PSID psid; > + > + TRACE("(%p,0x%08x,%p,0x%08x,%p)\n", ObjectDescriptor, > SecurityInformation, > + ResultantDescriptor, DescriptorLength, ReturnLength); > + > + if (!InitializeSecurityDescriptor(&desc, > SECURITY_DESCRIPTOR_REVISION)) > + return FALSE; > + > + if (SecurityInformation & OWNER_SECURITY_INFORMATION) > + { > + if (!GetSecurityDescriptorOwner(ObjectDescriptor, &psid, > &defaulted)) > + return FALSE; > + SetSecurityDescriptorOwner(&desc, psid, defaulted); > + } > + > + if (SecurityInformation & GROUP_SECURITY_INFORMATION) > + { > + if (!GetSecurityDescriptorGroup(ObjectDescriptor, &psid, > &defaulted)) > + return FALSE; > + SetSecurityDescriptorGroup(&desc, psid, defaulted); > + } > + > + if (SecurityInformation & DACL_SECURITY_INFORMATION) > + { > + if (!GetSecurityDescriptorDacl(ObjectDescriptor, &present, > &pacl, &defaulted)) > + return FALSE; > + SetSecurityDescriptorDacl(&desc, present, pacl, defaulted); > + } > + > + if (SecurityInformation & SACL_SECURITY_INFORMATION) > + { > + if (!GetSecurityDescriptorSacl(ObjectDescriptor, &present, > &pacl, &defaulted)) > + return FALSE; > + SetSecurityDescriptorSacl(&desc, present, pacl, defaulted); > + } > + > + *ReturnLength = DescriptorLength; > + return MakeSelfRelativeSD(&desc, ResultantDescriptor, > ReturnLength); > +} > +#endif > > > /* > Best regards, Alex Ionescu

2 1

About r38504
by Pierre SCHWEITZER 02 Jan '09

02 Jan '09

Hi, the declaration of FsRtlNotifyReportChange was correct, even if this function is now deprecated (that's why it doesn't need to be in DDK). WBR, P. Schweitzer _________________________________________________________________ Inédit ! Des Emoticônes Déjantées! Installez les dans votre Messenger ! http://www.ilovemessenger.fr/Emoticones/EmoticonesDejantees.aspx

1 0

Re: [ros-dev] Problems installing REACTOS
by Ged 02 Jan '09

02 Jan '09

Why do you need to start on real hardware? This is fairly unsupported at the moment, so you’re really in no-mans-land here. I’d suggest a virtual machine until you become more familiar with it. Anyway, looking at your hardware spec I don’t see any untoward. Continuing down the real hardware path, your next step is to obtain debug output. The only current method to do this is via a null-modem cable, as specified in the link I gave you. Ged. From: James Muthee [mailto:jsoftpacks@yahoo.co.uk] Sent: 31 December 2008 09:12 To: Ged Subject: RE: [ros-dev] Problems installing REACTOS Hello Ged. Thanks for the prompt reply. First, I need to test the software on a real machine. No Virtualization, no support form any other OS. As for the exact configuration of the system, I am forwarding the entire report from the windows system info. I know its lengthy but, then again you would be looking for someting specific. My disks are FAT32 Please help. Thanks James I. M. --- On Tue, 30/12/08, Ged <gedmurphy(a)gmail.com> wrote: From: Ged <gedmurphy(a)gmail.com> Subject: RE: [ros-dev] Problems installing REACTOS To: jsoftpacks(a)yahoo.co.uk, "'ReactOS Development List'" <ros-dev(a)reactos.org> Date: Tuesday, 30 December, 2008, 1:59 PM It could be a whole range of things. Without having your hardware spec and debug output, it’s impossible to tell. If you just want to test it, it’s better to run it in a virtual machine. If you’re insistent on running it on hardware, then you’ll need to start by supplying your hardware details. If that doesn’t show any obvious problems (e.g. SATA, NTFS, etc) then you will need to grab debug output via a null cable modem <http://www.reactos.org/wiki/index.php/Debugging#Real_computer:_Physical_ser…> http://www.reactos.org/wiki/index.php/Debugging#Real_computer:_Physical_ser… Good luck. Ged. From: ros-dev-bounces(a)reactos.org [mailto:ros-dev-bounces@reactos.org] On Behalf Of James Muthee Sent: 30 December 2008 11:21 To: ros-dev(a)reactos.org Subject: [ros-dev] Problems installing REACTOS Hello. Having downloaded the software (I was amazed it was less than 40MB), I wrote the ISO on a CD and started the installation. 0.3.7 failed to install completely, stopping dead just after loading the initial files. I downloaded the 0.3.6 and tried again. This time, I was able to install the first portion (copying the textmode installation to the hard disk and modifying the MBR). On restart, A GUI window flashed then a blue screen with a single line about the Build, and that was the end. What am I doing wrong? I would appreciate any help. I really want to test drive this software. James I. M.

2 2

Re: [ros-dev] [ros-diffs] [hyperion] 38461: modified tests/pseh2/psehtest.c finally_13 test re-enabled, as it doesn't crash anymore finally_14 test fixed. Now we know how exceptions thrown in a __finally are supposed to be handled PSEH test suite now has 91 tests and passes all of them with both GCC and Visual C++
by Aleksey Bragin 31 Dec '08

31 Dec '08

Just wanted to tell this is a great work, and with such test suite we will always notice if something breaks. WBR, Aleksey Bragin. On Dec 30, 2008, at 7:04 AM, hyperion(a)svn.reactos.org wrote: > Author: hyperion > Date: Mon Dec 29 22:04:51 2008 > New Revision: 38461 > > URL: http://svn.reactos.org/svn/reactos?rev=38461&view=rev > Log: > modified tests/pseh2/psehtest.c > finally_13 test re-enabled, as it doesn't crash anymore > finally_14 test fixed. Now we know how exceptions thrown in a > __finally are supposed to be handled > PSEH test suite now has 91 tests and passes all of them with > both GCC and Visual C++

4 9

Problems installing REACTOS
by James Muthee 30 Dec '08

30 Dec '08

Hello. Having downloaded the software (I was amazed it was less than 40MB), I wrote the ISO on a CD and started the installation. 0.3.7 failed to install completely, stopping dead just after loading the initial files. I downloaded the 0.3.6 and tried again. This time, I was able to install the first portion (copying the textmode installation to the hard disk and modifying the MBR). On restart, A GUI window flashed then a blue screen with a single line about the Build, and that was the end. What am I doing wrong? I would appreciate any help. I really want to test drive this software. James I. M.

2 1

[ros-diffs] [dgorbachev] 38455: - Fix indentation. - Fix bug #3920 (at line 736).
by Dmitry Gorbachev 29 Dec '08

29 Dec '08

> But my point was, line 736 is almost impossible to find when looking > at a diff. Oh, I see. I wrote that thoughtlessly.

1 0

[ros-diffs] [dgorbachev] 38455: - Fix indentation. - Fix bug #3920 (at line 736).
by Dmitry Gorbachev 29 Dec '08

29 Dec '08

> I can't find the bug fix using the ros-diffs mail list It is at line 736. + hpsxa[1] = NULL;

2 1

Re: [ros-dev] [ros-diffs] [dgorbachev] 38455: - Fix indentation. - Fix bug #3920 (at line 736).
by Ged 29 Dec '08

29 Dec '08

It's best to keep formatting and code fixes separate. I can't find the bug fix using the ros-diffs mail list Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dgorbachev(a)svn.reactos.org Sent: 29 December 2008 11:50 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dgorbachev] 38455: - Fix indentation. - Fix bug #3920 (at line 736). Author: dgorbachev Date: Mon Dec 29 05:50:09 2008 New Revision: 38455 URL: http://svn.reactos.org/svn/reactos?rev=38455&view=rev Log: - Fix indentation. - Fix bug #3920 (at line 736). Modified: trunk/reactos/dll/win32/shell32/fprop.c Modified: trunk/reactos/dll/win32/shell32/fprop.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/fprop.c?… ============================================================================== --- trunk/reactos/dll/win32/shell32/fprop.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/fprop.c [iso-8859-1] Mon Dec 29 05:50:09 2008 @@ -25,12 +25,13 @@ #define MAX_PROPERTY_SHEET_PAGE 32 typedef struct _LANGANDCODEPAGE_ - { +{ WORD lang; WORD code; } LANGANDCODEPAGE, *LPLANGANDCODEPAGE; HPSXA WINAPI SHCreatePropSheetExtArrayEx(HKEY hKey, LPCWSTR pszSubKey, UINT max_iface, IDataObject *pDataObj); + /************************************************************************* * * SH_CreatePropertySheetPage [Internal] @@ -38,6 +39,7 @@ * creates a property sheet page from an resource name * */ + HPROPSHEETPAGE SH_CreatePropertySheetPage(LPSTR resname, DLGPROC dlgproc, LPARAM lParam, LPWSTR szTitle) { @@ -55,7 +57,9 @@ ERR("failed to find resource name\n"); return (HPROPSHEETPAGE)0; } + lpsztemplate = LoadResource(shell32_hInstance, hRes); + if (lpsztemplate == NULL) return (HPROPSHEETPAGE)0; @@ -66,18 +70,14 @@ ppage.pfnDlgProc = dlgproc; ppage.lParam = lParam; ppage.pszTitle = szTitle; + if (szTitle) { ppage.dwFlags |= PSP_USETITLE; } + return CreatePropertySheetPageW(&ppage); } - - - - - - /************************************************************************* * @@ -90,67 +90,72 @@ */ BOOL -SH_FileGeneralSetFileType(HWND hwndDlg, WCHAR * filext) -{ - WCHAR name[MAX_PATH]; - WCHAR value[MAX_PATH]; - DWORD lname = MAX_PATH; - DWORD lvalue = MAX_PATH; - - HKEY hKey; - LONG result; - HWND hDlgCtrl; - - TRACE("fileext %s\n", debugstr_w(filext)); - - if (filext == NULL) - return FALSE; - - hDlgCtrl = GetDlgItem(hwndDlg, 14005); - - if (hDlgCtrl == NULL) - return FALSE; - - if (RegOpenKeyW(HKEY_CLASSES_ROOT, filext, &hKey) != ERROR_SUCCESS) - { - /* the fileextension is unknown, so default to string "FileExtension File" */ - SendMessageW(hDlgCtrl, WM_GETTEXT, (WPARAM)MAX_PATH, (LPARAM)value); - swprintf(name, value, &filext[1]); - SendMessageW(hDlgCtrl, WM_SETTEXT, (WPARAM)NULL, (LPARAM)name); - return TRUE; - } - result = RegEnumValueW(hKey, 0, name, &lname, NULL, NULL, (LPBYTE)value, &lvalue); - RegCloseKey(hKey); +SH_FileGeneralSetFileType(HWND hwndDlg, WCHAR *filext) +{ + WCHAR name[MAX_PATH]; + WCHAR value[MAX_PATH]; + DWORD lname = MAX_PATH; + DWORD lvalue = MAX_PATH; + HKEY hKey; + LONG result; + HWND hDlgCtrl; + + TRACE("fileext %s\n", debugstr_w(filext)); + + if (filext == NULL) + return FALSE; + + hDlgCtrl = GetDlgItem(hwndDlg, 14005); + + if (hDlgCtrl == NULL) + return FALSE; + + if (RegOpenKeyW(HKEY_CLASSES_ROOT, filext, &hKey) != ERROR_SUCCESS) + { + /* the file extension is unknown, so default to string "FileExtension File" */ + SendMessageW(hDlgCtrl, WM_GETTEXT, (WPARAM)MAX_PATH, (LPARAM)value); + swprintf(name, value, &filext[1]); + SendMessageW(hDlgCtrl, WM_SETTEXT, (WPARAM)NULL, (LPARAM)name); + return TRUE; + } + + result = RegEnumValueW(hKey, 0, name, &lname, NULL, NULL, (LPBYTE)value, &lvalue); + RegCloseKey(hKey); if (result != ERROR_SUCCESS) return FALSE; + if (RegOpenKeyW(HKEY_CLASSES_ROOT, value, &hKey) == ERROR_SUCCESS) { if (RegLoadMUIStringW(hKey, L"FriendlyTypeName", value, MAX_PATH, NULL, 0, NULL) != ERROR_SUCCESS) { lvalue = lname = MAX_PATH; - result = RegEnumValueW(hKey,0, name, &lname, NULL, NULL, (LPBYTE)value, &lvalue); + result = RegEnumValueW(hKey, 0, name, &lname, NULL, NULL, (LPBYTE)value, &lvalue); } + lname = MAX_PATH; + if (RegGetValueW(hKey, L"DefaultIcon", NULL, RRF_RT_REG_SZ, NULL, name, &lname) == ERROR_SUCCESS) { UINT IconIndex; WCHAR szBuffer[MAX_PATH]; - WCHAR * Offset; + WCHAR *Offset; HICON hIcon = 0; HRSRC hResource; LPVOID pResource = NULL; HGLOBAL hGlobal; HANDLE hLibrary; Offset = wcsrchr(name, L','); + if (Offset) { IconIndex = _wtoi(Offset + 2); *Offset = L'\0'; - name[MAX_PATH-1] = L'\0'; + name[MAX_PATH - 1] = L'\0'; + if (ExpandEnvironmentStringsW(name, szBuffer, MAX_PATH)) { - szBuffer[MAX_PATH-1] = L'\0'; + szBuffer[MAX_PATH - 1] = L'\0'; hLibrary = LoadLibraryExW(szBuffer, NULL, LOAD_LIBRARY_AS_DATAFILE); if (hLibrary) { @@ -164,7 +169,13 @@ if (pResource != NULL) { hIcon = CreateIconFromResource(pResource, SizeofResource(shell32_hInstance, hResource), TRUE, 0x00030000); - TRACE("hIcon %p,- szBuffer %s IconIndex %u error %u icon %p hResource %p pResource %p\n", hIcon, debugstr_w(szBuffer), IconIndex, MAKEINTRESOURCEW(IconIndex), hResource, pResource); + TRACE("hIcon %p,- szBuffer %s IconIndex %u error %u icon %p hResource %p pResource %p\n", + hIcon, + debugstr_w(szBuffer), + IconIndex, + MAKEINTRESOURCEW(IconIndex), + hResource, + pResource); SendDlgItemMessageW(hwndDlg, 14000, STM_SETICON, (WPARAM)hIcon, 0); } } @@ -178,10 +189,12 @@ } /* file extension type */ - value[MAX_PATH-1] = L'\0'; + value[MAX_PATH - 1] = L'\0'; SendMessageW(hDlgCtrl, WM_SETTEXT, (WPARAM)NULL, (LPARAM)value); + return TRUE; } + /************************************************************************* * * SHFileGeneralGetFileTimeString [Internal] @@ -190,12 +203,14 @@ */ BOOL -SHFileGeneralGetFileTimeString(LPFILETIME lpFileTime, WCHAR * lpResult) +SHFileGeneralGetFileTimeString(LPFILETIME lpFileTime, WCHAR *lpResult) { FILETIME ft; SYSTEMTIME dt; WORD wYear; - static const WCHAR wFormat[] = {'%','0','2','d','/','%','0','2','d','/','%','0','4','d',' ',' ','%','0','2','d',':','%','0','2','u',0}; + static const WCHAR wFormat[] = { + '%', '0', '2', 'd', '/', '%', '0', '2', 'd', '/', '%', '0', '4', 'd', + ' ', ' ', '%', '0', '2', 'd', ':', '%', '0', '2', 'u', 0 }; if (lpFileTime == NULL || lpResult == NULL) return FALSE; @@ -206,10 +221,11 @@ FileTimeToSystemTime(&ft, &dt); wYear = dt.wYear; + /* ddmmyy */ - swprintf (lpResult, wFormat, dt.wDay, dt.wMonth, wYear, dt.wHour, dt.wMinute); - - TRACE("result %s\n",debugstr_w(lpResult)); + swprintf(lpResult, wFormat, dt.wDay, dt.wMonth, wYear, dt.wHour, dt.wMinute); + + TRACE("result %s\n", debugstr_w(lpResult)); return TRUE; } @@ -222,18 +238,18 @@ */ BOOL -SH_FileGeneralSetText(HWND hwndDlg, WCHAR * lpstr) +SH_FileGeneralSetText(HWND hwndDlg, WCHAR *lpstr) { int flength; int plength; - WCHAR * lpdir; + WCHAR *lpdir; WCHAR buff[MAX_PATH]; HWND hDlgCtrl; if (lpstr == NULL) return FALSE; - lpdir = wcschr(lpstr, '\\'); /* find the last occurence of '\\' */ + lpdir = wcschr(lpstr, '\\'); /* find the last occurence of '\\' */ plength = wcslen(lpstr); flength = wcslen(lpdir); @@ -247,12 +263,12 @@ SendMessageW(hDlgCtrl, WM_SETTEXT, (WPARAM)NULL, (LPARAM)buff); } - if(flength > 1) - { - /* text filename field */ - wcsncpy(buff, &lpdir[1], flength); - hDlgCtrl = GetDlgItem(hwndDlg, 14001); - SendMessageW(hDlgCtrl, WM_SETTEXT, (WPARAM)NULL, (LPARAM)buff); + if (flength > 1) + { + /* text filename field */ + wcsncpy(buff, &lpdir[1], flength); + hDlgCtrl = GetDlgItem(hwndDlg, 14001); + SendMessageW(hDlgCtrl, WM_SETTEXT, (WPARAM)NULL, (LPARAM)buff); } return TRUE; @@ -267,7 +283,7 @@ */ BOOL -SH_FileGeneralSetFileSizeTime(HWND hwndDlg, WCHAR * lpfilename, PULARGE_INTEGER lpfilesize) +SH_FileGeneralSetFileSizeTime(HWND hwndDlg, WCHAR *lpfilename, PULARGE_INTEGER lpfilesize) { BOOL result; HANDLE hFile; @@ -283,7 +299,8 @@ hFile = CreateFileW(lpfilename, GENERIC_READ, - FILE_SHARE_READ,NULL, + FILE_SHARE_READ, + NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL); @@ -301,7 +318,8 @@ WARN("GetFileTime failed\n"); return FALSE; } - if (SHFileGeneralGetFileTimeString(&create_time,resultstr)) + + if (SHFileGeneralGetFileTimeString(&create_time, resultstr)) { hDlgCtrl = GetDlgItem(hwndDlg, 14015); SendMessageW(hDlgCtrl, WM_SETTEXT, (WPARAM)NULL, (LPARAM)resultstr); @@ -325,15 +343,21 @@ CloseHandle(hFile); return FALSE; } + CloseHandle(hFile); - if (!StrFormatByteSizeW(file_size.QuadPart, resultstr, sizeof(resultstr) / sizeof(WCHAR))) - return FALSE; + + if (!StrFormatByteSizeW(file_size.QuadPart, + resultstr, + sizeof(resultstr) / sizeof(WCHAR))) + return FALSE; + hDlgCtrl = GetDlgItem(hwndDlg, 14011); + TRACE("result size %u resultstr %s\n", file_size.QuadPart, debugstr_w(resultstr)); SendMessageW(hDlgCtrl, WM_SETTEXT, (WPARAM)NULL, (LPARAM)resultstr); if (lpfilesize) - lpfilesize->QuadPart = (ULONGLONG)file_size.QuadPart; + lpfilesize->QuadPart = (ULONGLONG)file_size.QuadPart; return TRUE; } @@ -346,23 +370,24 @@ */ BOOL -SH_FileVersionQuerySetText(HWND hwndDlg, DWORD dlgId, LPVOID pInfo, WCHAR * text, WCHAR ** resptr) -{ - UINT reslen; - HWND hDlgCtrl; - - if(hwndDlg == NULL || resptr == NULL || text == NULL) - return FALSE; - - if(VerQueryValueW(pInfo, text, (LPVOID *)resptr, &reslen)) - { - /* file description property */ - hDlgCtrl = GetDlgItem(hwndDlg, dlgId); - TRACE("%s :: %s\n",debugstr_w(text), debugstr_w(*resptr)); - SendMessageW(hDlgCtrl, WM_SETTEXT, (WPARAM)0, (LPARAM)*resptr); - return TRUE; - } - return FALSE; +SH_FileVersionQuerySetText(HWND hwndDlg, DWORD dlgId, LPVOID pInfo, WCHAR *text, WCHAR **resptr) +{ + UINT reslen; + HWND hDlgCtrl; + + if (hwndDlg == NULL || resptr == NULL || text == NULL) + return FALSE; + + if (VerQueryValueW(pInfo, text, (LPVOID *)resptr, &reslen)) + { + /* file description property */ + hDlgCtrl = GetDlgItem(hwndDlg, dlgId); + TRACE("%s :: %s\n", debugstr_w(text), debugstr_w(*resptr)); + SendMessageW(hDlgCtrl, WM_SETTEXT, (WPARAM)0, (LPARAM)*resptr); + return TRUE; + } + + return FALSE; } /************************************************************************* @@ -373,33 +398,35 @@ * */ - BOOL -SH_FileVersionQuerySetListText(HWND hwndDlg, LPVOID pInfo, const WCHAR * text, WCHAR **resptr, WORD lang, WORD code) -{ - UINT reslen; - HWND hDlgCtrl; - UINT index; - static const WCHAR wFormat[] = { '\\','S','t','r','i','n','g','F','i','l','e','I','n', - 'f','o','\\','%','0','4','x','%','0','4','x','\\','%','s',0 }; - WCHAR buff[256]; - - TRACE("text %s, resptr %p hwndDlg %p\n",debugstr_w(text), resptr, hwndDlg); - - if(hwndDlg == NULL || resptr == NULL || text == NULL) - return FALSE; - - swprintf(buff, wFormat, lang, code, text); - if(VerQueryValueW(pInfo, buff, (LPVOID *)resptr, &reslen)) - { - /* listbox name property */ - hDlgCtrl = GetDlgItem(hwndDlg, 14009); - TRACE("%s :: %s\n",debugstr_w(text), debugstr_w(*resptr)); - index = SendMessageW(hDlgCtrl, LB_ADDSTRING, (WPARAM)-1, (LPARAM)text); - SendMessageW(hDlgCtrl, LB_SETITEMDATA, (WPARAM)index, (LPARAM)(WCHAR*)*resptr); - return TRUE; - } - return FALSE; +SH_FileVersionQuerySetListText(HWND hwndDlg, LPVOID pInfo, const WCHAR *text, WCHAR **resptr, WORD lang, WORD code) +{ + UINT reslen; + HWND hDlgCtrl; + UINT index; + static const WCHAR wFormat[] = { + '\\', 'S', 't', 'r', 'i', 'n', 'g', 'F', 'i', 'l', 'e', 'I', 'n', 'f', 'o', + '\\', '%', '0', '4', 'x', '%', '0', '4', 'x', '\\', '%', 's', 0 }; + WCHAR buff[256]; + + TRACE("text %s, resptr %p hwndDlg %p\n", debugstr_w(text), resptr, hwndDlg); + + if (hwndDlg == NULL || resptr == NULL || text == NULL) + return FALSE; + + swprintf(buff, wFormat, lang, code, text); + + if (VerQueryValueW(pInfo, buff, (LPVOID *)resptr, &reslen)) + { + /* listbox name property */ + hDlgCtrl = GetDlgItem(hwndDlg, 14009); + TRACE("%s :: %s\n", debugstr_w(text), debugstr_w(*resptr)); + index = SendMessageW(hDlgCtrl, LB_ADDSTRING, (WPARAM)-1, (LPARAM)text); + SendMessageW(hDlgCtrl, LB_SETITEMDATA, (WPARAM)index, (LPARAM)(WCHAR *)*resptr); + return TRUE; + } + + return FALSE; } /************************************************************************* @@ -408,102 +435,117 @@ * * sets all file version properties in dialog */ + BOOL -SH_FileVersionInitialize(HWND hwndDlg, WCHAR * lpfilename) -{ - LPVOID pBuf; - DWORD versize; - DWORD handle; - LPVOID info = NULL; - UINT infolen; - WCHAR buff[256]; - HWND hDlgCtrl; - WORD lang = 0; - WORD code = 0; - LPLANGANDCODEPAGE lplangcode; - WCHAR * str; - static const WCHAR wVersionFormat[] = { '%','d','.','%','d','.','%','d','.','%','d',0 }; - static const WCHAR wFileDescriptionFormat[] = { '\\','S','t','r','i','n','g','F','i','l','e','I','n','f','o', - '\\','%','0','4','x','%','0','4','x','\\','F','i','l','e','D','e','s','c','r','i','p','t','i','o','n',0 }; - static const WCHAR wLegalCopyrightFormat[] = { '\\','S','t','r','i','n','g','F','i','l','e','I','n','f','o', - '\\','%','0','4','x','%','0','4','x','\\','L','e','g','a','l','C','o','p','y','r','i','g','h','t',0 }; - static const WCHAR wTranslation[] = { 'V','a','r','F','i','l','e','I','n','f','o','\\','T','r','a','n','s','l','a','t','i','o','n',0 }; - static const WCHAR wCompanyName[] = { 'C','o','m','p','a','n','y','N','a','m','e',0 }; - static const WCHAR wFileVersion[] = { 'F','i','l','e','V','e','r','s','i','o','n',0 }; - static const WCHAR wInternalName[] = { 'I','n','t','e','r','n','a','l','N','a','m','e',0 }; - static const WCHAR wOriginalFilename[] = { 'O','r','i','g','i','n','a','l','F','i','l','e','n','a','m','e',0 }; - static const WCHAR wProductName[] = { 'P','r','o','d','u','c','t','N','a','m','e',0 }; - static const WCHAR wProductVersion[] = { 'P','r','o','d','u','c','t','V','e','r','s','i','o','n',0 }; - static const WCHAR wSlash[] = { '\\',0 }; - - - if(lpfilename == 0) - return FALSE; - - if(!(versize = GetFileVersionInfoSizeW(lpfilename, &handle))) - { - WARN("GetFileVersionInfoSize failed\n"); - return FALSE; - } - - if(!(pBuf = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, versize))) - { - WARN("HeapAlloc failed bytes %x\n",versize); - return FALSE; - } - - if(!GetFileVersionInfoW(lpfilename, handle, versize, pBuf)) - { - HeapFree(GetProcessHeap(), 0, pBuf); - return FALSE; - } - if(VerQueryValueW(pBuf, wSlash, &info, &infolen)) - { - VS_FIXEDFILEINFO * inf = (VS_FIXEDFILEINFO *)info; - swprintf(buff, wVersionFormat, HIWORD(inf->dwFileVersionMS), - LOWORD(inf->dwFileVersionMS), - HIWORD(inf->dwFileVersionLS), - LOWORD(inf->dwFileVersionLS)); - - hDlgCtrl = GetDlgItem(hwndDlg, 14001); - TRACE("MS %x LS %x res %s \n",inf->dwFileVersionMS, inf->dwFileVersionLS, debugstr_w(buff)); - SendMessageW(hDlgCtrl, WM_SETTEXT, (WPARAM)NULL, (LPARAM)buff); - } - if(VerQueryValueW(pBuf, wTranslation, (LPVOID *)&lplangcode, &infolen)) - { - /* FIXME find language from current locale / if not available, - * default to english - * for now default to first available language - */ - lang = lplangcode->lang; - code = lplangcode->code; - } - - swprintf(buff, wFileDescriptionFormat, lang, code); - SH_FileVersionQuerySetText(hwndDlg, 14003, pBuf, buff, &str); - - swprintf(buff, wLegalCopyrightFormat, lang, code); - SH_FileVersionQuerySetText(hwndDlg, 14005, pBuf, buff, &str); - - /* listbox properties */ - SH_FileVersionQuerySetListText(hwndDlg, pBuf, wCompanyName, &str, lang, code); - SH_FileVersionQuerySetListText(hwndDlg, pBuf, wFileVersion, &str, lang, code); - SH_FileVersionQuerySetListText(hwndDlg, pBuf, wInternalName, &str, lang, code); - - /* FIXME insert language identifier */ - - SH_FileVersionQuerySetListText(hwndDlg, pBuf, wOriginalFilename, &str, lang, code); - SH_FileVersionQuerySetListText(hwndDlg, pBuf, wProductName, &str, lang, code); - SH_FileVersionQuerySetListText(hwndDlg, pBuf, wProductVersion, &str, lang, code); - SetWindowLong(hwndDlg, DWL_USER, (LONG)pBuf); - - /* select first item */ - hDlgCtrl = GetDlgItem(hwndDlg, 14009); - SendMessageW(hDlgCtrl, LB_SETCURSEL, 0, 0); - str = (WCHAR *)SendMessageW(hDlgCtrl, LB_GETITEMDATA, (WPARAM)0, (LPARAM)NULL); - hDlgCtrl = GetDlgItem(hwndDlg, 14010); - SendMessageW(hDlgCtrl, WM_SETTEXT, (WPARAM)NULL, (LPARAM)str); - return TRUE; +SH_FileVersionInitialize(HWND hwndDlg, WCHAR *lpfilename) +{ + LPVOID pBuf; + DWORD versize; + DWORD handle; + LPVOID info = NULL; + UINT infolen; + WCHAR buff[256]; + HWND hDlgCtrl; + WORD lang = 0; + WORD code = 0; + LPLANGANDCODEPAGE lplangcode; + WCHAR *str; + static const WCHAR wVersionFormat[] = { + '%', 'd', '.', '%', 'd', '.', '%', 'd', '.', '%', 'd', 0 }; + static const WCHAR wFileDescriptionFormat[] = { + '\\', 'S', 't', 'r', 'i', 'n', 'g', 'F', 'i', 'l', 'e', 'I', 'n', 'f', 'o', + '\\', '%', '0', '4', 'x', '%', '0', '4', 'x', + '\\', 'F', 'i', 'l', 'e', 'D', 'e', 's', 'c', 'r', 'i', 'p', 't', 'i', 'o', 'n', 0 }; + static const WCHAR wLegalCopyrightFormat[] = { + '\\', 'S', 't', 'r', 'i', 'n', 'g', 'F', 'i', 'l', 'e', 'I', 'n', 'f', 'o', + '\\', '%', '0', '4', 'x', '%', '0', '4', 'x', + '\\', 'L', 'e', 'g', 'a', 'l', 'C', 'o', 'p', 'y', 'r', 'i', 'g', 'h', 't', 0 }; + static const WCHAR wTranslation[] = { + 'V', 'a', 'r', 'F', 'i', 'l', 'e', 'I', 'n', 'f', 'o', + '\\', 'T', 'r', 'a', 'n', 's', 'l', 'a', 't', 'i', 'o', 'n', 0 }; + static const WCHAR wCompanyName[] = { + 'C', 'o', 'm', 'p', 'a', 'n', 'y', 'N', 'a', 'm', 'e', 0 }; + static const WCHAR wFileVersion[] = { + 'F', 'i', 'l', 'e', 'V', 'e', 'r', 's', 'i', 'o', 'n', 0 }; + static const WCHAR wInternalName[] = { + 'I', 'n', 't', 'e', 'r', 'n', 'a', 'l', 'N', 'a', 'm', 'e', 0 }; + static const WCHAR wOriginalFilename[] = { + 'O', 'r', 'i', 'g', 'i', 'n', 'a', 'l', 'F', 'i', 'l', 'e', 'n', 'a', 'm', 'e', 0 }; + static const WCHAR wProductName[] = { + 'P', 'r', 'o', 'd', 'u', 'c', 't', 'N', 'a', 'm', 'e', 0 }; + static const WCHAR wProductVersion[] = { + 'P', 'r', 'o', 'd', 'u', 'c', 't', 'V', 'e', 'r', 's', 'i', 'o', 'n', 0 }; + static const WCHAR wSlash[] = { '\\', 0 }; + + if (lpfilename == 0) + return FALSE; + + if (!(versize = GetFileVersionInfoSizeW(lpfilename, &handle))) + { + WARN("GetFileVersionInfoSize failed\n"); + return FALSE; + } + + if (!(pBuf = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, versize))) + { + WARN("HeapAlloc failed bytes %x\n", versize); + return FALSE; + } + + if (!GetFileVersionInfoW(lpfilename, handle, versize, pBuf)) + { + HeapFree(GetProcessHeap(), 0, pBuf); + return FALSE; + } + + if (VerQueryValueW(pBuf, wSlash, &info, &infolen)) + { + VS_FIXEDFILEINFO *inf = (VS_FIXEDFILEINFO *)info; + swprintf(buff, wVersionFormat, HIWORD(inf->dwFileVersionMS), + LOWORD(inf->dwFileVersionMS), + HIWORD(inf->dwFileVersionLS), + LOWORD(inf->dwFileVersionLS)); + hDlgCtrl = GetDlgItem(hwndDlg, 14001); + TRACE("MS %x LS %x res %s \n", inf->dwFileVersionMS, inf->dwFileVersionLS, debugstr_w(buff)); + SendMessageW(hDlgCtrl, WM_SETTEXT, (WPARAM)NULL, (LPARAM)buff); + } + + if (VerQueryValueW(pBuf, wTranslation, (LPVOID *)&lplangcode, &infolen)) + { + /* FIXME find language from current locale / if not available, + * default to english + * for now default to first available language + */ + lang = lplangcode->lang; + code = lplangcode->code; + } + + swprintf(buff, wFileDescriptionFormat, lang, code); + SH_FileVersionQuerySetText(hwndDlg, 14003, pBuf, buff, &str); + + swprintf(buff, wLegalCopyrightFormat, lang, code); + SH_FileVersionQuerySetText(hwndDlg, 14005, pBuf, buff, &str); + + /* listbox properties */ + SH_FileVersionQuerySetListText(hwndDlg, pBuf, wCompanyName, &str, lang, code); + SH_FileVersionQuerySetListText(hwndDlg, pBuf, wFileVersion, &str, lang, code); + SH_FileVersionQuerySetListText(hwndDlg, pBuf, wInternalName, &str, lang, code); + + /* FIXME insert language identifier */ + + SH_FileVersionQuerySetListText(hwndDlg, pBuf, wOriginalFilename, &str, lang, code); + SH_FileVersionQuerySetListText(hwndDlg, pBuf, wProductName, &str, lang, code); + SH_FileVersionQuerySetListText(hwndDlg, pBuf, wProductVersion, &str, lang, code); + SetWindowLong(hwndDlg, DWL_USER, (LONG)pBuf); + + /* select first item */ + hDlgCtrl = GetDlgItem(hwndDlg, 14009); + SendMessageW(hDlgCtrl, LB_SETCURSEL, 0, 0); + str = (WCHAR *) SendMessageW(hDlgCtrl, LB_GETITEMDATA, (WPARAM)0, (LPARAM)NULL); + hDlgCtrl = GetDlgItem(hwndDlg, 14010); + SendMessageW(hDlgCtrl, WM_SETTEXT, (WPARAM)NULL, (LPARAM)str); + + return TRUE; } /************************************************************************* @@ -512,70 +554,71 @@ * * wnd proc of 'Version' property sheet page */ + INT_PTR CALLBACK -SH_FileVersionDlgProc( - HWND hwndDlg, - UINT uMsg, - WPARAM wParam, - LPARAM lParam -) -{ - LPPROPSHEETPAGE ppsp; - WCHAR * lpstr; - LPVOID * buf; - switch(uMsg) - { - case WM_INITDIALOG: - ppsp = (LPPROPSHEETPAGE)lParam; - if(ppsp == NULL) - break; - - TRACE("WM_INITDIALOG hwnd %p lParam %p ppsplParam %x\n",hwndDlg, lParam, ppsp->lParam); - - lpstr = (WCHAR *)ppsp->lParam; - - if(lpstr == NULL) - break; - - return SH_FileVersionInitialize(hwndDlg, lpstr); - - - case WM_COMMAND: - if(LOWORD(wParam) == 14009 && HIWORD(wParam) == LBN_DBLCLK) - { - HWND hDlgCtrl; - LRESULT lresult; - WCHAR * str; - - hDlgCtrl = GetDlgItem(hwndDlg, 14009); - lresult = SendMessageW(hDlgCtrl, LB_GETCURSEL, (WPARAM)NULL, (LPARAM)NULL); - if(lresult == LB_ERR) - { - break; - } - str = (WCHAR *)SendMessageW(hDlgCtrl, LB_GETITEMDATA, (WPARAM)lresult, (LPARAM)NULL); - - if(str == NULL) - { - break; - } - hDlgCtrl = GetDlgItem(hwndDlg, 14010); - TRACE("hDlgCtrl %x string %s \n",hDlgCtrl, debugstr_w(str)); - SendMessageW(hDlgCtrl, WM_SETTEXT, (WPARAM)NULL, (LPARAM)str); - return TRUE; - } - break; - - case WM_DESTROY: - buf = (LPVOID)GetWindowLong(hwndDlg, DWL_USER); - HeapFree(GetProcessHeap(), 0, buf); - break; - - default: - break; - } - return FALSE; +SH_FileVersionDlgProc(HWND hwndDlg, + UINT uMsg, + WPARAM wParam, + LPARAM lParam) +{ + LPPROPSHEETPAGE ppsp; + WCHAR *lpstr; + LPVOID *buf; + + switch (uMsg) + { + case WM_INITDIALOG: + ppsp = (LPPROPSHEETPAGE)lParam; + + if (ppsp == NULL) + break; + + TRACE("WM_INITDIALOG hwnd %p lParam %p ppsplParam %x\n", hwndDlg, lParam, ppsp->lParam); + + lpstr = (WCHAR *)ppsp->lParam; + + if (lpstr == NULL) + break; + + return SH_FileVersionInitialize(hwndDlg, lpstr); + + case WM_COMMAND: + if (LOWORD(wParam) == 14009 && HIWORD(wParam) == LBN_DBLCLK) + { + HWND hDlgCtrl; + LRESULT lresult; + WCHAR *str; + + hDlgCtrl = GetDlgItem(hwndDlg, 14009); + lresult = SendMessageW(hDlgCtrl, LB_GETCURSEL, (WPARAM)NULL, (LPARAM)NULL); + + if (lresult == LB_ERR) + break; + + str = (WCHAR *) SendMessageW(hDlgCtrl, LB_GETITEMDATA, (WPARAM)lresult, (LPARAM)NULL); + + if (str == NULL) + break; + + hDlgCtrl = GetDlgItem(hwndDlg, 14010); + TRACE("hDlgCtrl %x string %s \n", hDlgCtrl, debugstr_w(str)); + SendMessageW(hDlgCtrl, WM_SETTEXT, (WPARAM)NULL, (LPARAM)str); + + return TRUE; + } + break; + + case WM_DESTROY: + buf = (LPVOID) GetWindowLong(hwndDlg, DWL_USER); + HeapFree(GetProcessHeap(), 0, buf); + break; + + default: + break; + } + + return FALSE; } /************************************************************************* @@ -588,44 +631,54 @@ INT_PTR CALLBACK -SH_FileGeneralDlgProc( - HWND hwndDlg, - UINT uMsg, - WPARAM wParam, - LPARAM lParam -) +SH_FileGeneralDlgProc(HWND hwndDlg, + UINT uMsg, + WPARAM wParam, + LPARAM lParam) { LPPROPSHEETPAGEW ppsp; - WCHAR * lpstr; - switch(uMsg) - { - case WM_INITDIALOG: - ppsp = (LPPROPSHEETPAGEW)lParam; - if (ppsp == NULL) + WCHAR *lpstr; + + switch (uMsg) + { + case WM_INITDIALOG: + ppsp = (LPPROPSHEETPAGEW)lParam; + + if (ppsp == NULL) + break; + + TRACE("WM_INITDIALOG hwnd %p lParam %p ppsplParam %S\n", hwndDlg, lParam, ppsp->lParam); + + lpstr = (WCHAR *)ppsp->lParam; + + if (lpstr == NULL) + { + ERR("no filename\n"); + break; + } + + /* set general text properties filename filelocation and icon */ + SH_FileGeneralSetText(hwndDlg, lpstr); + + /* enumerate file extension from registry and application which opens it */ + SH_FileGeneralSetFileType(hwndDlg, wcsrchr(lpstr, '.')); + + /* set file time create/modfied/accessed */ + SH_FileGeneralSetFileSizeTime(hwndDlg, lpstr, NULL); + + return TRUE; + + default: break; - TRACE("WM_INITDIALOG hwnd %p lParam %p ppsplParam %S\n",hwndDlg, lParam, ppsp->lParam); - - lpstr = (WCHAR *)ppsp->lParam; - - if ( lpstr == NULL) - { - ERR("no filename\n"); - break; - } - /* set general text properties filename filelocation and icon */ - SH_FileGeneralSetText(hwndDlg, lpstr); - /* enumerate file extension from registry and application which opens it*/ - SH_FileGeneralSetFileType(hwndDlg, wcsrchr(lpstr, '.')); - /* set file time create/modfied/accessed */ - SH_FileGeneralSetFileSizeTime(hwndDlg, lpstr, NULL); - return TRUE; - default: - break; - } - return FALSE; -} - -BOOL CALLBACK AddShellPropSheetExCallback(HPROPSHEETPAGE hPage, LPARAM lParam) + } + + return FALSE; +} + +BOOL +CALLBACK +AddShellPropSheetExCallback(HPROPSHEETPAGE hPage, + LPARAM lParam) { PROPSHEETHEADERW *pinfo = (PROPSHEETHEADERW *)lParam; @@ -634,66 +687,73 @@ pinfo->u3.phpage[pinfo->nPages++] = hPage; return TRUE; } + return FALSE; } - int -EnumPropSheetExt(LPWSTR wFileName, PROPSHEETHEADERW *pinfo, int NumPages, HPSXA * hpsxa, IDataObject *pDataObj) -{ - WCHAR szName[MAX_PATH] = {0}; - WCHAR * pOffset; +EnumPropSheetExt(LPWSTR wFileName, PROPSHEETHEADERW *pinfo, int NumPages, HPSXA *hpsxa, IDataObject *pDataObj) +{ + WCHAR szName[MAX_PATH] = { 0 }; + WCHAR *pOffset; UINT Length; DWORD dwName; int Pages; CLSID clsid; pOffset = wcsrchr(wFileName, L'.'); + if (!pOffset) { Length = wcslen(szName); - if (Length + 6 > sizeof(szName)/sizeof(szName[0])) - return 0; + + if (Length + 6 > sizeof(szName) / sizeof(szName[0])) + return 0; if (CLSIDFromString(wFileName, &clsid) == NOERROR) { - wcscpy(szName, L"CLSID\\"); - wcscpy(&szName[6], wFileName); + wcscpy(szName, L"CLSID\\"); + wcscpy(&szName[6], wFileName); } else { - wcscpy(szName, wFileName); + wcscpy(szName, wFileName); } } else { Length = wcslen(pOffset); - if (Length >= sizeof(szName)/sizeof(szName[0])) + + if (Length >= sizeof(szName) / sizeof(szName[0])) return 0; + wcscpy(szName, pOffset); } + TRACE("EnumPropSheetExt szName %s\n", debugstr_w(szName)); + hpsxa[0] = SHCreatePropSheetExtArrayEx(HKEY_CLASSES_ROOT, szName, NumPages, pDataObj); + hpsxa[1] = NULL; + Pages = SHAddFromPropSheetExtArray(hpsxa[0], AddShellPropSheetExCallback, (LPARAM)pinfo); - if (pOffset) { /* try to load property sheet handlers from prog id key */ dwName = sizeof(szName); + if (RegGetValueW(HKEY_CLASSES_ROOT, pOffset, NULL, RRF_RT_REG_SZ, NULL, szName, &dwName) == ERROR_SUCCESS) { TRACE("EnumPropSheetExt szName %s, pOffset %s\n", debugstr_w(szName), debugstr_w(pOffset)); - szName[(sizeof(szName)/sizeof(WCHAR))-1] = L'\0'; + szName[(sizeof(szName) / sizeof(WCHAR)) - 1] = L'\0'; hpsxa[1] = SHCreatePropSheetExtArrayEx(HKEY_CLASSES_ROOT, szName, NumPages - Pages, pDataObj); - Pages +=SHAddFromPropSheetExtArray(hpsxa[1], AddShellPropSheetExCallback, (LPARAM)pinfo); + Pages += SHAddFromPropSheetExtArray(hpsxa[1], AddShellPropSheetExCallback, (LPARAM)pinfo); } } + return Pages; } - - /************************************************************************* * * SH_ShowPropertiesDialog @@ -703,38 +763,39 @@ * lpf contains (quoted) path of folder/file * * TODO: provide button change application type if file has registered type - * make filename field editable and apply changes to filename on close + * make filename field editable and apply changes to filename on close */ BOOL -SH_ShowPropertiesDialog(WCHAR * lpf, LPCITEMIDLIST pidlFolder, LPCITEMIDLIST * apidl) +SH_ShowPropertiesDialog(WCHAR *lpf, LPCITEMIDLIST pidlFolder, LPCITEMIDLIST *apidl) { PROPSHEETHEADERW pinfo; HPROPSHEETPAGE hppages[MAX_PROPERTY_SHEET_PAGE]; WCHAR wFileName[MAX_PATH]; DWORD dwHandle = 0; - WCHAR * pFileName; + WCHAR *pFileName; HPSXA hpsxa[2]; INT_PTR res; - IDataObject* pDataObj = NULL; + IDataObject *pDataObj = NULL; HRESULT hResult; TRACE("SH_ShowPropertiesDialog entered filename %s\n", debugstr_w(lpf)); - if (lpf== NULL) - return FALSE; - - if ( !wcslen(lpf) ) + if (lpf == NULL) + return FALSE; + + if (!wcslen(lpf)) return FALSE; memset(hppages, 0x0, sizeof(HPROPSHEETPAGE) * MAX_PROPERTY_SHEET_PAGE); + if (lpf[0] == '"') { /* remove quotes from lpf */ LPCWSTR src = lpf + 1; LPWSTR dst = wFileName; - while(*src && *src!='"') + while (*src && *src != '"') *dst++ = *src++; *dst = '\0'; @@ -754,13 +815,12 @@ return SH_ShowDriveProperties(wFileName, pidlFolder, apidl); } - pFileName = wcsrchr(wFileName, '\\'); + if (!pFileName) pFileName = wFileName; else pFileName++; - memset(&pinfo, 0x0, sizeof(PROPSHEETHEADERW)); pinfo.dwSize = sizeof(PROPSHEETHEADERW); @@ -768,24 +828,33 @@ pinfo.u3.phpage = hppages; pinfo.pszCaption = pFileName; - hppages[pinfo.nPages] = SH_CreatePropertySheetPage("SHELL_FILE_GENERAL_DLG", SH_FileGeneralDlgProc, (LPARAM)wFileName, NULL); + hppages[pinfo.nPages] = + SH_CreatePropertySheetPage("SHELL_FILE_GENERAL_DLG", + SH_FileGeneralDlgProc, + (LPARAM)wFileName, + NULL); + if (hppages[pinfo.nPages]) pinfo.nPages++; - - hResult = SHCreateDataObject(pidlFolder, 1, apidl, NULL, &IID_IDataObject, (LPVOID*)&pDataObj); + hResult = SHCreateDataObject(pidlFolder, 1, apidl, NULL, &IID_IDataObject, (LPVOID *)&pDataObj); + if (hResult == S_OK) { - if (!EnumPropSheetExt(wFileName, &pinfo, MAX_PROPERTY_SHEET_PAGE-1, hpsxa, pDataObj)) + if (!EnumPropSheetExt(wFileName, &pinfo, MAX_PROPERTY_SHEET_PAGE - 1, hpsxa, pDataObj)) { hpsxa[0] = NULL; hpsxa[1] = NULL; } } - if ( GetFileVersionInfoSizeW(lpf, &dwHandle)) - { - hppages[pinfo.nPages] = SH_CreatePropertySheetPage("SHELL_FILE_VERSION_DLG",SH_FileVersionDlgProc, (LPARAM)wFileName, NULL); + if (GetFileVersionInfoSizeW(lpf, &dwHandle)) + { + hppages[pinfo.nPages] = + SH_CreatePropertySheetPage("SHELL_FILE_VERSION_DLG", + SH_FileVersionDlgProc, + (LPARAM)wFileName, + NULL); if (hppages[pinfo.nPages]) pinfo.nPages++; } @@ -794,11 +863,12 @@ if (hResult == S_OK) { - SHDestroyPropSheetExtArray(hpsxa[0]); - SHDestroyPropSheetExtArray(hpsxa[1]); + SHDestroyPropSheetExtArray(hpsxa[0]); + SHDestroyPropSheetExtArray(hpsxa[1]); IDataObject_Release(pDataObj); } return (res != -1); } + /*EOF */

1 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 38432: FsRtlInitializeLargeMcb: Initialize fast mutex gate
by Alex Ionescu 28 Dec '08

28 Dec '08

Use a guarded mutex instead -- you're confused with what's actually going on. Fast mutexes use events, Guarded mutexes use gates. Both are initialized by their respective Ke/Ex/InitializeFast/Guarded mutex. On 28-Dec-08, at 3:06 PM, pschweitzer(a)svn.reactos.org wrote: > Author: pschweitzer > Date: Sun Dec 28 14:06:08 2008 > New Revision: 38432 > > URL: http://svn.reactos.org/svn/reactos?rev=38432&view=rev > Log: > FsRtlInitializeLargeMcb: Initialize fast mutex gate > > Modified: > branches/pierre-fsd/ntoskrnl/fsrtl/largemcb.c > > Modified: branches/pierre-fsd/ntoskrnl/fsrtl/largemcb.c > URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/ntoskrnl/fsrtl/large… > = > = > = > = > = > = > = > = > ====================================================================== > --- branches/pierre-fsd/ntoskrnl/fsrtl/largemcb.c [iso-8859-1] > (original) > +++ branches/pierre-fsd/ntoskrnl/fsrtl/largemcb.c [iso-8859-1] Sun > Dec 28 14:06:08 2008 > @@ -130,7 +130,9 @@ > IN POOL_TYPE PoolType) > { > Mcb->FastMutex = > ExAllocateFromNPagedLookasideList(&FsRtlFastMutexLookasideList); > + > ExInitializeFastMutex(Mcb->FastMutex); > + KeInitializeGate((PKGATE)&(Mcb->FastMutex->Gate)); > > FsRtlInitializeBaseMcb(&(Mcb->BaseMcb), PoolType); > } > Best regards, Alex Ionescu

1 0

Implementing ReplaceFileW
by Dmitry Chapyshev 28 Dec '08

28 Dec '08

Hi, I imported function ReplaceFileW from Wine, but it do not work in ReactOS. RepleceFileW there do not pass 11 tests (kernel32_winetest file). I think, that a problem in call MoveFileEx. Somebody can help with it? Function in Wine: http://www.reactos.org/paste/index.php/2745/ Patch for ReactOS: http://www.reactos.org/paste/index.php/2744/ -- WBR, Dmitry Chapyshev

2 1

[ros-diffs] [jimtabor] 38348: - Example of a thread overrun? HAX-Fixes wine cursoricon test.
by James Tabor 26 Dec '08

26 Dec '08

Hi ALL! Okay, not sure what is going on but here is the original output: Unhandled exception ExceptionCode: c0000005 Faulting Address: 682000 Address: 7c91e6ae C:\ReactOS\system32\ntdll.dll CS:EIP 1b:7c91e6ae DS 23 ES 23 FS 3b GS 0 EAX: 011f0020 EBX: 011f0020 ECX: 090b071d EDX: 242c2c64 EBP: 008afc54 ESI: 00681ffe ESP: 008afc4c EDI: 011f1010 EFLAGS: 00010212 Frames: 77e30000+211d2 C:\ReactOS\system32\user32.dll 77e30000+21365 C:\ReactOS\system32\user32.dll 77e30000+20c56 C:\ReactOS\system32\user32.dll 400000+892c C:\ReactOS\user32_crosstest.exe 400000+8e73 C:\ReactOS\user32_crosstest.exe 400000+a3ab C:\ReactOS\user32_crosstest.exe 400000+b4ac8 C:\ReactOS\user32_crosstest.exe 400000+b4c56 C:\ReactOS\user32_crosstest.exe 400000+1247 C:\ReactOS\user32_crosstest.exe 400000+1298 C:\ReactOS\user32_crosstest.exe 7c700000+218e4 C:\ReactOS\system32\kernel32.dll (subsystems/win32/csrss/api/wapi.c:115) CSR: received hard error c0000144 (subsystems/win32/csrss/win32csr/dllmain.c:528) The instruction at "0x7c91e6ae" referenced memory at "0x00682000". The memory could not be "read". After patch: We have a thread overrun, these are already freed! pi -> 18808864 bi -> 6819854 We have a thread overrun, these are already freed! pi -> 18808864 bi -> 6819854 Than, get two exit strings at the command console. bi -> 6819854 (0x68100E) is the one and it is from MapViewOfFile. The difference from 0x682000 is 4082.... Well with in the normal page but why is 0x68100E the start address and not 0x681000? It could be just simply bad math being used in LoadBitmapImage. Wine does use the same code in user32 from gdi32 to handle bitmap and friends. Thanks, James

1 0

Subpixel Rendering, ala sorta cleartype
by Steven Edwards 26 Dec '08

26 Dec '08

Hi rosdevs! This is an issue I've been working on for a while on the Wine side of things and now they have initial support for it. If any of you Win32k/GDI hackers are interested in making ReactOS look a bit better on LCDs please enable support in freetype and review the following Wine patch to get an idea of the requirements. Thanks http://source.winehq.org/git/wine.git/?a=commitdiff;h=028617b90ba586bdb3072… -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

3 5

Trunk regression
by Aleksey Bragin 23 Dec '08

23 Dec '08

Hi, Mozilla Firefox 2.0: install it, run it, then quit - total hang without KDBG or any exception, TAB+K doesn't work. Then, reboot - try to navigate via Start Menu to Applications -> Mozilla Firefox. Explorer will die with exception in dll/win32/user32/ misc/exticon.c:88 (find_entry_by_id). Maybe due to files corruption. WBR, Aleksey.

3 2

Re: [ros-dev] [ros-diffs] [cgutman] 38297: Huge memtrack commit (part 1 of 2) - Add checking for proper tags - Enable memtrack by default - Display the conflicting entries when an error occurs - Remove pool* routines and replace with ex* routines
by Aleksey Bragin 23 Dec '08

23 Dec '08

On Dec 23, 2008, at 3:39 PM, cgutman(a)svn.reactos.org wrote: > Author: cgutman > Date: Tue Dec 23 06:39:55 2008 > New Revision: 38297 > > ====================================================================== > ======== > --- branches/aicom-network-fixes/drivers/network/tcpip/datalink/ > lan.c [iso-8859-1] (original) > +++ branches/aicom-network-fixes/drivers/network/tcpip/datalink/ > lan.c [iso-8859-1] Tue Dec 23 06:39:55 2008 > @@ -703,7 +703,7 @@ > UnicodeString.MaximumLength = Information->DataLength; > > String->Buffer = > - (PWCHAR)exAllocatePool( NonPagedPool, > + (PWCHAR)ExAllocatePool( NonPagedPool, > UnicodeString.MaximumLength + sizeof(WCHAR) ); Isn't that a typo? you change it the other way around everywhere else in tcpip.

1 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 38294: For some unknown reason wmc likes to include string.h from the wine folder and we cannot link it on linux hosts. This hack should hopefully resolve the issue.
by Colin Finck 23 Dec '08

23 Dec '08

tkreuzer(a)svn.reactos.org wrote: > For some unknown reason wmc likes to include string.h from the wine folder and we cannot link it on linux hosts. This hack should hopefully resolve the issue. Not that mysterious actually. The "include/reactos/wine" directory is shared among Wine host and target tools while "include/crt" contains target-only headers and thus it's only available for target components. Therefore #include_next cannot find any other "string.h" file, when you use it inside host tools. Furthermore, #include_next is a GCC-only thing, so we should avoid it wherever possible. To circumvent these problems and remove the hacks from the actual CRT/PSDK headers, I propose we i.e. add '#include <reactos/wine/string.h>' to the CRT "string.h" and do the appropriate thing for other files. This is the prettiest solution I can think of without editing a bunch of Wine files. Best regards, Colin

1 0

[ros-diffs] [dgorbachev] 38170: Add a hack which allows to boot with Armenian language.
by Dmitry Gorbachev 23 Dec '08

23 Dec '08

Sooner or later, this problem should be solved somehow. And not only for Armenians, but also for other peoples of the world, who live without code pages.

1 0

Re: [ros-dev] [ros-diffs] [sserapion] 38260: Fix EDITSTREAM structure
by Ged 22 Dec '08

22 Dec '08

This will be lost in a Wine update -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of sserapion(a)svn.reactos.org Sent: 22 December 2008 03:22 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [sserapion] 38260: Fix EDITSTREAM structure Author: sserapion Date: Sun Dec 21 21:22:05 2008 New Revision: 38260 URL: http://svn.reactos.org/svn/reactos?rev=38260&view=rev Log: Fix EDITSTREAM structure Modified: branches/ros-amd64-bringup/reactos/dll/win32/riched20/editor.c branches/ros-amd64-bringup/reactos/include/psdk/richedit.h Modified: branches/ros-amd64-bringup/reactos/dll/win32/riched20/editor.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… ============================================================================== --- branches/ros-amd64-bringup/reactos/dll/win32/riched20/editor.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/dll/win32/riched20/editor.c [iso-8859-1] Sun Dec 21 21:22:05 2008 @@ -1616,7 +1616,7 @@ data.string = string; data.length = strlen(string); data.pos = 0; - es.dwCookie = (DWORD)&data; + es.dwCookie = (DWORD_PTR)&data; es.pfnCallback = ME_ReadFromRTFString; ME_StreamIn(editor, SF_RTF | (selection ? SFF_SELECTION : 0), &es, FALSE); } @@ -1998,7 +1998,7 @@ return FALSE; gds.hData = GetClipboardData(cf); gds.nLength = 0; - es.dwCookie = (DWORD)&gds; + es.dwCookie = (DWORD_PTR)&gds; es.pfnCallback = dwFormat == SF_RTF ? ME_ReadFromHGLOBALRTF : ME_ReadFromHGLOBALUnicode; ME_StreamIn(editor, dwFormat|SFF_SELECTION, &es, FALSE); Modified: branches/ros-amd64-bringup/reactos/include/psdk/richedit.h URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/inclu… ============================================================================== --- branches/ros-amd64-bringup/reactos/include/psdk/richedit.h [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/include/psdk/richedit.h [iso-8859-1] Sun Dec 21 21:22:05 2008 @@ -517,7 +517,7 @@ typedef struct _editstream { DWORD dwCookie; - DWORD dwError; + DWORD_PTR dwError; EDITSTREAMCALLBACK pfnCallback; } EDITSTREAM;

1 0

Re: [ros-dev] [ros-general] I am taking a break...
by Alex Ionescu 20 Dec '08

20 Dec '08

I concur with James. Eric, I think what you meant to say is you don't have time to work on ReactOS in its current state -- ie: the slow, time-consuming procedures and behaviors that take up more than 50% of your free time. What if ReactOS provides you with your own branch, and the ReactOS project assumes the responsibility of merging your changes to trunk, performing the testing and regression testing. You might be afraid that your code will "rot" and that it would never make it inline, but I'm sure the people respect your work as much as I do and would make sure that things stay up to date (much like we sync with Wine). This would allow you to keep committing code, have your own branch which at least works for you, and we'd take care of merging. Your only real responsibility would be to "sync up" with trunk every once in a while -- could even be only ever 3 months, or if you notice something obvious that might affect you (RPC changes, WIDL changes, SCM etc). I know this may sound unfair to other developers, but as James pointed out, you deserve everyone's time, considering how much you've put in all this time. On 19-Dec-08, at 9:22 PM, James Tabor wrote: > Hi Eric! > Eric Kohl wrote: >> Hi! >> >> Effective immediately I am taking a break from working on ReactOS >> for an >> undetermined period of time. It may even be the end of my involvement >> with ReactOS. >> >> There are several reasons for me to quit but the most important one >> is >> lack of time. I have a pretty exhausting job and spend more than 2 >> hours >> a day to commute so there is not much time left to spend on ReactOS. >> So working on ReactOS happened on weekends only. >> >> After my latest patch was partially reverted, I decided that I am not >> willing to create and maintain a development branch for >> improvements to >> LSA and SAM. I am not willing to spend an hour or two each weekend >> for >> branch maintenance and debugging and another two or three hours for >> developing new code. It just does not make sense to me. >> >> Maybe I will be back one day, maybe I will not. Time will tell. >> >> Over and out! >> Eric >> > Your resignation is disapproved! You are an integral part of this > project. > > You are the last of the root members of this project. We need your > help > and if that means breaking ReactOS truck that is your right to do > so. We will > learn to live with it. I have followed your work for years and I > would like > to see you more. Based on your tenure with this project, this gives > you > rights, influences and guidance to this project. > > Please recommence with your changes, > James > _______________________________________________ > Ros-general mailing list > Ros-general(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-general Best regards, Alex Ionescu

1 0

Job offer: Linux tool to create a valid Windows Registry hive file
by Martin v. Wittich 19 Dec '08

19 Dec '08

Hi, we are a software development company that develops and maintains a Linux-based server solution called IServ, designed for use in schools. We are in business since 2003, and there are currently about 370 schools in Germany using IServ as their portal server. One feature that we would like to integrate into our product is the possibility to customize the ntconfig.pol file. This file, located on the server's netlogon share, can deploy registry settings to Windows clients - it is especially important because it can deploy HKEY_LOCAL_MACHINE settings. This file is a binary registry hive. At the moment, we have to create this file manually with poledit.exe. We need a Linux program which can automatically generate this file. 1) It should read plain text files as input, for example an INF file. 2) The resulting policy file must work with Windows 2000 and XP x86 clients. It should be possible to easily test this by using the command "Load Hive" in Regedit. 3) The preferred programming language is Perl, C/C++ is also OK. Other languages should also be possible, but only after prior consultation (just to make sure nobody comes up with Java ;) ). 4) The resulting source code should be released as open source, e.g. under the GPL. We would like the program being finished in one month. We will pay you EUR 300 for it. If the program is very much work and you feel you need more money, submit us an offer. A Perl library to dump binary registry files to plain text: http://search.cpan.org/~jmacfarla/Parse-Win32Registry-0.30/ Attachments: ntconfig.pol - Our current policy. This must be generated automatically. ntconfig.pol.dump - Plain text dump of that file, generated with Parse::Win32Registry. winnt.adm - Template to edit our policy file with poledit.exe. Our homepage: http://iserv.eu (only in German, though) -- Yours sincerely, Martin v. Wittich IServ Falk & Ludwig GbR Rebenring 33 38106 Braunschweig Germany Telephone: +49 531 380 4450 E-Mail: martin.von.wittich(a)iserv.eu Internet: http://www.iserv.eu

8 12

Re: [ros-dev] [ros-diffs] [dgorbachev] 38170: Add a hack which allows to boot with Armenian language.
by Aleksey Bragin 18 Dec '08

18 Dec '08

Dmitry - I think we don't have THAT many Armenian users (if any?) so that we have to apply such ugly hacks. On Dec 18, 2008, at 3:26 PM, dgorbachev(a)svn.reactos.org wrote: > Author: dgorbachev > Date: Thu Dec 18 06:26:52 2008 > New Revision: 38170 > > URL: http://svn.reactos.org/svn/reactos?rev=38170&view=rev > Log: > Add a hack which allows to boot with Armenian language. > > Modified: > trunk/reactos/boot/freeldr/freeldr/reactos/reactos.c > > Modified: trunk/reactos/boot/freeldr/freeldr/reactos/reactos.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/ > freeldr/reactos/reactos.c?rev=38170&r1=38169&r2=38170&view=diff > ====================================================================== > ======== > --- trunk/reactos/boot/freeldr/freeldr/reactos/reactos.c > [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/reactos/reactos.c > [iso-8859-1] Thu Dec 18 06:26:52 2008 > @@ -262,8 +262,11 @@ > rc = RegQueryValue(hKey, szIdBuffer, NULL, (PUCHAR) > szNameBuffer, &BufferSize); > if (rc != ERROR_SUCCESS) { > > - strcpy(szErrorOut, "ACP NLS Setting exists, but isn't > readable"); > - return(FALSE); > + //strcpy(szErrorOut, "ACP NLS Setting exists, but isn't > readable"); > + //return(FALSE); > + > + /* HACK */ > + wcscpy(szNameBuffer, L"c_1252.nls"); > } > > /* load ANSI codepage table */ > @@ -288,8 +291,11 @@ > rc = RegQueryValue(hKey, szIdBuffer, NULL, (PUCHAR) > szNameBuffer, &BufferSize); > if (rc != ERROR_SUCCESS) { > > - strcpy(szErrorOut, "OEMCP NLS setting exists, but isn't > readable"); > - return(FALSE); > + //strcpy(szErrorOut, "OEMCP NLS setting exists, but isn't > readable"); > + //return(FALSE); > + > + /* HACK */ > + wcscpy(szNameBuffer, L"c_437.nls"); > } > > /* load OEM codepage table */ >

1 0

About @KfLowerIrql@4
by Fan Zhang 18 Dec '08

18 Dec '08

hi, i'm a newbie of ReacOS. I looked a piece of code in syscall.S which is come from 0.2.7 edtion. /* Raise IRQL to APC_LEVEL */ movl $1, %ecx call @KfRaiseIrql@4 could anybody help me explain why the function is decorated by @ in the head? and why transfer argument by ecx? Thank you ___________________________________________________________ 好玩贺卡等你发，邮箱贺卡全新上线！ http://card.mail.cn.yahoo.com/

2 1

Have anyone tried, stress prime on ReactOS?
by Ashuaria Lee 16 Dec '08

16 Dec '08

Hi, Guys(and Girls) did you heard about a program called "stress prime"? It was developed to calculate prime numbers. And it is very sensitive to small errors. Since it has some kinda detecting errors, many overclockers are using it to confirm overclocked H/W stability. Yes, I tried to run this program, just for fun, and surprise! The system is not overclocked, nor has problem when running stressprime on WindowsXP. The rounding error amount was huge. I saw the source code of the stress prime and I'm sorry it was assembly language, so I couldn't check what could make such prolem under ReactOS. It was all about the math, and I'm not good at both(asm,math) But, one thing sure, is something is not working properly(maybe kernel?) and it is affecting ReactOS stability. What is your opinion? any comments? -- Regards, Ashuaria Lee

2 3

[ros-diffs] [dgorbachev] 38083: - Use HEAP_ZERO_MEMORY instead of memset(). - Do not crash if no adapter found.
by Dmitry Gorbachev 15 Dec '08

15 Dec '08

Hi, Alex Ionescu wrote: > You should always use memset and void HEAP_ZERO_MEMORY. Could you please tell why HEAP_ZERO_MEMORY should not be used? It is used in many places, so if something wrong with RtlAllocateHeap, maybe better to fix it? Thanks, Dmitry

2 1

Re: [ros-dev] [ros-diffs] [dgorbachev] 38083: - Use HEAP_ZERO_MEMORY instead of memset(). - Do not crash if no adapter found.
by Alex Ionescu 14 Dec '08

14 Dec '08

You should always use memset and void HEAP_ZERO_MEMORY. On 14-Dec-08, at 3:45 PM, dgorbachev(a)svn.reactos.org wrote: > Author: dgorbachev > Date: Sun Dec 14 14:45:16 2008 > New Revision: 38083 > > URL: http://svn.reactos.org/svn/reactos?rev=38083&view=rev > Log: > - Use HEAP_ZERO_MEMORY instead of memset(). > - Do not crash if no adapter found. > > Modified: > trunk/reactos/dll/cpl/desk/desk.c > trunk/reactos/dll/cpl/desk/settings.c > > Modified: trunk/reactos/dll/cpl/desk/desk.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/desk.c?rev=38… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/dll/cpl/desk/desk.c [iso-8859-1] (original) > +++ trunk/reactos/dll/cpl/desk/desk.c [iso-8859-1] Sun Dec 14 > 14:45:16 2008 > @@ -162,7 +162,7 @@ > InitPropSheetPage(&psh, PropPages[i].idDlg, > PropPages[i].DlgProc, PropPages[i].Callback); > } > > - /* NOTE: Don;t call SHAddFromPropSheetExtArray here because > this applet only allows > + /* NOTE: Don't call SHAddFromPropSheetExtArray here because > this applet only allows > replacing the background page but not extending the > applet by more pages */ > > ret = (LONG)(PropertySheet(&psh) != -1); > > Modified: trunk/reactos/dll/cpl/desk/settings.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/settings.c?re… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/dll/cpl/desk/settings.c [iso-8859-1] (original) > +++ trunk/reactos/dll/cpl/desk/settings.c [iso-8859-1] Sun Dec 14 > 14:45:16 2008 > @@ -151,8 +151,7 @@ > DWORD ResolutionsCount = 1; > DWORD i; > > - newEntry = HeapAlloc(GetProcessHeap(), 0, > sizeof(DISPLAY_DEVICE_ENTRY)); > - memset(newEntry, 0, sizeof(DISPLAY_DEVICE_ENTRY)); > + newEntry = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > sizeof(DISPLAY_DEVICE_ENTRY)); > if (!newEntry) goto ByeBye; > > newEntry->Settings = GetPossibleSettings(DisplayDevice->DeviceName, > &newEntry->SettingsCount, &newEntry->CurrentSettings); > @@ -311,6 +310,7 @@ > EnableWindow(GetDlgItem(hwndDlg, IDC_SETTINGS_RESOLUTION), FALSE); > EnableWindow(GetDlgItem(hwndDlg, IDC_SETTINGS_RESOLUTION_TEXT), > FALSE); > EnableWindow(GetDlgItem(hwndDlg, IDC_SETTINGS_ADVANCED), FALSE); > + ShowWindow(GetDlgItem(hwndDlg, IDC_SETTINGS_SPECTRUM), SW_HIDE); > } > else if (Result == 1) > { > Best regards, Alex Ionescu

1 0

Type definition in NDK
by Dmitry Gorbachev 12 Dec '08

12 Dec '08

May I know from where comes NLS_FILE_HEADER structure definition in include/ndk/rtltypes.h ? I think it is not correct.

1 0

why IOCTL_DISK_GET_DRIVE_GEOMETRY_EX failed in windows 2000?
by Jack Yi 10 Dec '08

10 Dec '08

hi,guys: I don't know if it is proper to ask such a question here. I'm sorry if I break some rules. why IOCTL_DISK_GET_DRIVE_GEOMETRY_EX fail in windows 2000 and succeed in windows xp and greater version? or how can I get a disk(whatever,ATA,SCSI,USB )'s real size(including additional sectors) in a easy way in windows 2000, just like there is such a function, __int 64GetDiskRealSize(HANDLE hDisk); Could anybody help me? Waiting for reply. Thank you!

4 6

Re: [ros-dev] [ros-diffs] [cwittich] 37955: SeUnsolicitedInputPrivilege is obsolete - the LUID is used by SE_MACHINE_ACCOUNT_PRIVILEGE now
by Alex Ionescu 10 Dec '08

10 Dec '08

Hm? On 9-Dec-08, at 3:33 AM, cwittich(a)svn.reactos.org wrote: > - Luid->LowPart = Priv + 1; > + Luid->LowPart = Priv + 2; Best regards, Alex Ionescu

1 0

Re: [ros-dev] [ros-diffs] [jimtabor] 37952: - Add CP_UNIXCP for CP_ACP, this will help cross tests.
by Steven Edwards 09 Dec '08

09 Dec '08

On Tue, Dec 9, 2008 at 12:58 AM, <jimtabor(a)svn.reactos.org> wrote: > Author: jimtabor > Date: Mon Dec 8 23:58:23 2008 > New Revision: 37952 > > URL: http://svn.reactos.org/svn/reactos?rev=37952&view=rev > Log: > - Add CP_UNIXCP for CP_ACP, this will help cross tests. > > Added: > trunk/reactos/include/reactos/wine/winnls.h (with props) > +#ifndef __WINE_WINNLS_H > +#define __WINE_WINNLS_H > + > +#define CP_UNIXCP CP_ACP Rather than keep the include_next brokeness, perhaps we should add the define to wine/port.h and include that in any offending source file. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 1

compatibility vs. correctness
by Matthias Kupfer 09 Dec '08

09 Dec '08

Hi folks, yesterday a user shows me a program what is working properly under windows, but not working under reactos. It was an open source program and it was easy to figure out the problem. It was an invalid win-api-call (wrong parameter value). Due to this situation I would like to ask one question. How compatible reactos should be? Even fault compatible? Matthias -- Matthias Kupfer Telefon +49 (0) 371 236 46 52 Wilhelm-Firl-Straße 21 Mobil +49 (0) 160 859 43 54 09122 Chemnitz

11 12

compatibility vs. correctness
by Dmitry Gorbachev 08 Dec '08

08 Dec '08

I believe that people wish "perfect world" API as an optional feature, not that they really want to broke compatibility.

3 2

compatibility vs. correctness
by Dmitry Gorbachev 08 Dec '08

08 Dec '08

Steven Edwards wrote: > We discussed something like this years ago. It would be nice if every sort > of legacy API that has any sort of hacks for brokeness as part of its > implementation, could be isolated and a simple recompile with something > like a #define NO_LEGACY_WIN32 so you could recompile without the hacks. > Not really that useful for the real world as you need the backward > compatibility but it is a nice idea for embedded or non-normal windows > targets like ARM. I think this is like compiler warnings. Some checks are disabled by default as they would cause more harm than good. But there is an option to enable them. It will help to catch bugs in software.

1 0

Please dont break functionality due to a compiler problem, just fix it.
by Dmitry Gorbachev 08 Dec '08

08 Dec '08

>> It was already broken in r37496. > Gdi is right Win32k is wrong. I mean that GCC (by default) silently discards code like if (i < 0) { ... } where i is unsigned. So there was a bug in GDI...

1 0

Please dont break functionality due to a compiler problem, just fix it.
by Dmitry Gorbachev 08 Dec '08

08 Dec '08

It was already broken in r37496.

2 1

[ros-diffs] [ekohl] 37891: Replace call to ExtractIconExW (shell32.dll) by a call to PrivateExtractIconExw (user32.dll) and remove shell32.dll from the list of linked libraries because shell32.dll requires a valid user account upon initialization. Pl
by James Tabor 07 Dec '08

07 Dec '08

Eric Kohl is an Ace Programmer! Thanks Eric! James

1 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 37876: - Implement SetupInstallFileA/W - Stub implement SetupPromptForDiskA/W All from Wine.
by teknopup 07 Dec '08

07 Dec '08

1 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 37876: - Implement SetupInstallFileA/W - Stub implement SetupPromptForDiskA/W All from Wine.
by Ged 06 Dec '08

06 Dec '08

dchapyshev(a)svn.reactos.org wrote: > + if (!(inf_source = HeapAlloc( GetProcessHeap(), 0, len * sizeof(WCHAR) ))) > + { > + SetLastError( ERROR_NOT_ENOUGH_MEMORY ); > + return FALSE; > + } > + if (!SetupGetStringFieldW( inf_context, 1, inf_source, len, NULL )) return FALSE; > + source = inf_source; There's a memory leak here. It's best to read Wine code when throughly, they have bugs too ;) Ged.

1 0

ddk header cleanup
by Timo Kreuzer 05 Dec '08

05 Dec '08

Now that Stefan has cleaned up some stuff in the ddk headers, maybe we should think of some additional design fixes here. We currently have ntddk.h include "per version" headers: winxp.h, win2k.h, winnt4.h. These contain very few stuff. My suggestion is to merge them into winddk.h. We could also merge winddk.h and ntddk.h It might make sense to split wdm.h and ntddk.h into architecture specific files Layout suggestion: - ntddk.h: includes wdm.h and contains arch-independent definitions currently in winddk.h/win2k.h/winnt4.h - wdm.h: includes arch-dependent headers, contains arch-independend wdm definitions - ddk_x86.h / ddk_x64.h, ddk_arm.h, ddk_ppc.h / ddk_mips.h: arch-dependent definitions for both wdm.h and ntddk.h definitions (#ifdef _NTDDK_ ...) Comments appreciated. Timo

1 0

Re: [ros-dev] [ros-diffs] [jimtabor] 37783: - Fixed hooking bug for Firefox, a plus, new SEH found a bug!
by Timo Kreuzer 04 Dec '08

04 Dec '08

This looks like you're creating a mem leak. > Author: jimtabor > Date: Sun Nov 30 17:39:20 2008 > New Revision: 37783 > > URL: http://svn.reactos.org/svn/reactos?rev=37783&view=rev <http://svn.reactos.org/svn/reactos?rev=37783&view=rev> > Log: > - Fixed hooking bug for Firefox, a plus, new SEH found a bug! > > Modified: > trunk/reactos/subsystems/win32/win32k/ntuser/callback.c > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/callback.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… <http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt…> > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/callback.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/callback.c [iso-8859-1] Sun Nov 30 17:39:20 2008 > @@ -507,12 +507,12 @@ > } > _SEH2_END; > > - IntCbFreeMemory(Argument); > - > if (!NT_SUCCESS(Status)) > { > return 0; > } > + > + if (Argument) IntCbFreeMemory(Argument); > > return Result; > } >

2 1

Re: [ros-dev] [ros-diffs] [sginsberg] 37792: - Get rid of DDK's dependency on windef.h and winnt.h - Clean up, fix, and add missing types to ntdef.h/ntifs.h/winddk.h/wdm.h/ntpoapi.h - Add ntimage.h and use it in rossym and NDK - Fix a gcc compatibility issue -- some internal NT structures have their pointer types defined in the DDK headers, but we define them along with the "struct" type when defining the full structure. MSVC is okay with this double definition, but gcc treats it as an error (hidden by syst
by Timo Kreuzer 04 Dec '08

04 Dec '08

What's the reason to copy & paste comments from ms headers? Please remember: Interfaces are not copyrighted, header files (including the comments) are! > +// > +// Types to use to contain PFNs and their counts. > +// > +typedef ULONG PFN_COUNT; > typedef ULONG PFN_NUMBER, *PPFN_NUMBER; > +typedef LONG SPFN_NUMBER, *PSPFN_NUMBER; >

1 0

Boot broken, trunk locked
by Dmitry Gorbachev 04 Dec '08

04 Dec '08

Hi! I'm sorry I broke the trunk. About "extra" comma within braces, it is not a mistake. It is allowed. There is a fragment of C grammar: initializer : assignment_expression | '{' initializer_list '}' | '{' initializer_list ',' '}' ;

1 0

Boot broken, trunk locked
by Aleksey Bragin 03 Dec '08

03 Dec '08

Hello, booting bootcd leads to a stackfault of VMWare, build server experiences similar problems. Trunk is locked with write access available to Dmitry Gorbachev to fix the issue, and to anyone by request who has the fix. WBR, Aleksey Bragin.

2 1

Re: [ros-dev] [ros-diffs] [dgorbachev] 37830: Silence compiler warnings (8/11).
by Aleksey Bragin 03 Dec '08

03 Dec '08

On Dec 3, 2008, at 8:34 PM, dgorbachev(a)svn.reactos.org wrote: > Author: dgorbachev > Date: Wed Dec 3 11:34:49 2008 > New Revision: 37830 > -static FREELDR_SETTINGS Settings = { 0, {0}, 0 }; > +static FREELDR_SETTINGS Settings = { 0, { 0, }, 0, 0, FALSE }; I suspect there is a typo in the above line ("extra" comma within braces, should've been something like 0, {0, 0}, 0, FALSE instead probably). WBR, Aleksey.

1 0

Re: [ros-dev] [ros-diffs] [ekohl] 37801: Sync to wine-1.1.1 (Patch 4 of 10): ATTENTION: You MUST run "clean" before building ReactOS, otherwise WIDL will crash when it is run. - Dan Hipschman <dsh at linux.ucla.edu> Tue, 1 Jul 2008 widl: Implement type redefinition
by Colin Finck 01 Dec '08

01 Dec '08

Hi Eric, Just wanted to tell you that your patch is correct and the Release Buildslave is failing as you can see from its log. For some reason, it stopped cleaning properly today and also has weird file deletion issues sometimes. But as long as the patch builds on the Debug slave, it's correct in 99% of all cases. Wanted to finish this mail before you reverted in r37802, but I was too slow. :-( So, it's safe for you to reapply r37801 and it's here to stay! Best regards, Colin

1 0

Re: [ros-dev] [ros-diffs] [gschneider] 37774: Update C++ demangle code to recent wine, now all msvcrt cpp tests pass except one.
by Aleksey Bragin 01 Dec '08

01 Dec '08

On Nov 30, 2008, at 10:19 PM, gschneider(a)svn.reactos.org wrote: > Author: gschneider > Date: Sun Nov 30 13:19:45 2008 > New Revision: 37774 > - if (!(tmp = (char*)und_alloc(sym, len))) return NULL; > + if (!(tmp = und_alloc(sym, len))) return NULL; You might want to keep these when syncing, it reduces compiler warnings.

1 0

Question about east asian language support
by Ashuaria Lee 01 Dec '08

01 Dec '08

Hello, everyone. Since I'm new to this mailing list, I may ask stupid questions, so don't be mad at me. ;-) I was trying to get the status of east asian language support, but couldn't find it in the wiki. Could someone tell me some brief status about east asian support? -- Regards, Ashuaria Lee

2 2

Re: [ros-dev] [ros-diffs] [jimtabor] 37766: - Sync in rev 37720: Magnus Olsen, add GdiGetBitmapBitsSize is a new api from windows xp sp3, the code was tested in vs2003.
by Aleksey Bragin 01 Dec '08

01 Dec '08

Instead of copying the whole formula, it could be done as ULONG Height; if (lpbmi->bmiHeader.biHeight >=0 ) Height = lpbmi->bmiHeader.biHeight; else Height = -lpbmi->bmiHeader.biHeight; retSize = Height * ((lpbmi->bmiHeader.biWidth * lpbmi->bmiHeader.biPlanes * lpbmi- >bmiHeader.biBitCount + 31) & -32) / 8; Also comments contain typos /* Make height postiive if it negitve then calc the bits Size and align it*/ postiive, negitive WBR, Aleksey. On Nov 30, 2008, at 4:17 PM, jimtabor(a)svn.reactos.org wrote: > Author: jimtabor > Date: Sun Nov 30 07:17:19 2008 > New Revision: 37766 > + if (lpbmi->bmiHeader.biHeight >=0 ) > + { > + /* Calc the bits Size and align it*/ > + retSize = lpbmi->bmiHeader.biHeight * ((lpbmi- > >bmiHeader.biWidth * > + lpbmi->bmiHeader.biPlanes * lpbmi- > >bmiHeader.biBitCount + 31) & -32) / 8; > + } > + else > + { > + /* Make height postiive if it negitve then calc > the bits Size and align it*/ > + retSize = (-lpbmi->bmiHeader.biHeight) * ((lpbmi- > >bmiHeader.biWidth * > + lpbmi->bmiHeader.biPlanes * lpbmi- > >bmiHeader.biBitCount + 31) & -32) / 8; > + }

2 1

Silence a warning reported by gcc 4.3.2 (possibly incorrectly, but it's just a stub anyway)
by Dmitry Gorbachev 30 Nov '08

30 Nov '08

Yes, incorrectly. GetTraceLoggerHandle() should return 0xFFFFFFFFFFFFFFFF if it fails, but now it returns 0xFFFFFFFF.

1 0

Re: [ros-dev] [ros-diffs] [sginsberg] 37739: - Kill off ramdrv, it is deprecated since a long time ago. See issue #3422 for more details.
by Steven Edwards 30 Nov '08

30 Nov '08

On Sat, Nov 29, 2008 at 2:35 PM, <sginsberg(a)svn.reactos.org> wrote: > Author: sginsberg > Date: Sat Nov 29 13:35:04 2008 > New Revision: 37739 > > URL: http://svn.reactos.org/svn/reactos?rev=37739&view=rev > Log: > - Kill off ramdrv, it is deprecated since a long time ago. > See issue #3422 for more details. The problem was as far as I can tell not ramdrv but ramdrv/minix. I really think you should revert part of this. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [ros-dev] [ros-diffs] [cgutman] 37713: - Merge aicom-network-fixes up to r37712
by Aleksey Bragin 29 Nov '08

29 Nov '08

Another way of doing this (stylistically) would be: switch (Type) { case NdisWorkItemRequest: if (Adapter->NdisMiniportBlock.PendingRequest || MiniGetFirstWorkItem(Adapter, NdisWorkItemRequest)) Busy = TRUE; break case ...: } On Nov 29, 2008, at 4:51 AM, cgutman(a)svn.reactos.org wrote: > Author: cgutman > Date: Fri Nov 28 19:51:19 2008 > New Revision: 37713 > > +BOOLEAN > +MiniIsBusy( > + PLOGICAL_ADAPTER Adapter, > + NDIS_WORK_ITEM_TYPE Type) > +{ > + BOOLEAN Busy = FALSE; > + KIRQL OldIrql; > + > + KeAcquireSpinLock(&Adapter->NdisMiniportBlock.Lock, &OldIrql); > + > + if (Type == NdisWorkItemRequest && > + (Adapter->NdisMiniportBlock.PendingRequest || > MiniGetFirstWorkItem(Adapter, NdisWorkItemRequest))) > + { > + Busy = TRUE; > + } > + else if (Type == NdisWorkItemSend && > + (Adapter->NdisMiniportBlock.FirstPendingPacket || > MiniGetFirstWorkItem(Adapter, NdisWorkItemSend))) > + { > + Busy = TRUE; > + } > + else if (Type == NdisWorkItemResetRequested && > + (Adapter->NdisMiniportBlock.ResetStatus == > NDIS_STATUS_PENDING || MiniGetFirstWorkItem(Adapter, > NdisWorkItemResetRequested))) > + { > + Busy = TRUE; > + } > + > + KeReleaseSpinLock(&Adapter->NdisMiniportBlock.Lock, OldIrql); > + > + return Busy; > +}

1 0

Win32k Rewrite Status Report
by James Tabor 28 Nov '08

28 Nov '08

Hi Team! First, here is my personal list of last years goals for the rewrite. Most of you already know what I had plan for last year so please bare with me. ___ December 2007: End of previous year rewrite of definition files and structure integration with updates to ntgdibad.h. Housekeeping, test and verify. Add previous years loose ends and carryovers. Thomas help with user window handle support is a great bonus to the year end progress toward win32k rewrite. Timo win32k cross tests. Magnus integration of DDxD support is still in progress and ticking along nicely. January 2008: Miscellaneous Gdi adds, fix ups and cleanup. February 2008: Integration and implementation of Enhanced/Meta/Dc/File support. This is a wine sync/port that I have started during the beginning of the rewrite. Delayed and carryover. May 2008: Gdi/User Win32k DCE cleanup and fixes. 90% complete. One unique test case needing to be integrated in code base. June 2008: Gdi cleanup and verify testing. Integrate simple multi display support. DC and PDEV integration and cleanup. Partial DC and PDEV structures are supported and minor cleanup and testing was meant. No multi display add ons are included. Delayed and carryover. July 2008: Start prerewrite of User32/Win32k. Cleanup headers and add new types and structures. Started and carryover. September 2008: Housecleaning, Gdi testing and verifying. Still in progress. November 2008: Start User32/Win32 Menu rewrite. Still in progress, new structure support is in and working in test tree. December 2008: End of year housekeeping with cross test and verify. Add previous years loose ends and carryovers. Slow integration of known gdi structures have been completed. Attribute support is only for DC's, investigating a more conservative process of allocation and utilization of Brush/Pen /Regon and Font attribute support that is compatible with gdi. Carryover and finish up window handle and integration support. Timo started integration of user process/thread structures and support, leaving win32k initialization bug open for more investigation. Magnus DDxD is back on track. Stefan cleanup of win32 functions was completed. January 2009: Add new members to the rewrite team, start training and information exchange. Setup freelance hacker member list which would include just about everyone with commit access. -------- This is my personal list and included comments about team members progress. I'll add more after January for 2009. Side Note: Please do not post here if you are interested in joining the rewrite team. If you have commit access you are already in. We need to know your specialties, interests and goals which include what you want to learn so this can be carried into your next career. Resume stuffer for the next job and what knots. Thanks, James

1 0

Re: [ros-dev] [ros-diffs] [gschneider] 37695: Update gdi32 winetests, so we don't run out of things to fix.
by Steven Edwards 28 Nov '08

28 Nov '08

On Thu, Nov 27, 2008 at 3:52 PM, <gschneider(a)svn.reactos.org> wrote: > Author: gschneider > Date: Thu Nov 27 14:52:01 2008 > New Revision: 37695 > > URL: http://svn.reactos.org/svn/reactos?rev=37695&view=rev > Log: > Update gdi32 winetests, so we don't run out of things to fix. Best commit message ever. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

utf-16 data (e.g. inf files)
by Matthias Kupfer 26 Nov '08

26 Nov '08

Hi folks, due to the perpetual problems with utf-16 files I recommend to change the handling in the following way as long as we don't have another working translation system (mui) and we want to keep a win32 compatible inf file: We should store the files in subversion as utf-8 and convert during make and rbuild in utf-16 (e.g. via small c-programm or new rbuild-command), so we can edit and make diffs in an easy way. Comments are very welcome Matthias -- Matthias Kupfer Telefon +49 (0) 371 236 46 52 Wilhelm-Firl-Straße 21 Mobil +49 (0) 160 859 43 54 09122 Chemnitz

5 5

Migrate ntoskrnl to PSEH 2.0
by Dmitry Gorbachev 24 Nov '08

24 Nov '08

Hi! I have a linking error because GCC-4.4 inserts calls of ___enable_execute_stack() into functions which use PSEH. It seems that this behavior cannot be changed without changing the GCC itself. Or maybe I should provide an empty ___enable_execute_stack() function just to satisfy the linker.

1 0

(no subject)
by Dmitry Gorbachev 22 Nov '08

22 Nov '08

> This is already done, most files which have Wine code are labeled so atop > of the file ("Some parts are taken from Wine project..."). What I see is > that Dmitry Timoshkov says this is not enough. It should be enough if the original copyright notices are kept. No need to research origins of every piece of code. LGPL 2.1: > 1. You may copy and distribute verbatim copies of the Library's complete > source code as you receive it, in any medium, provided that you > conspicuously and appropriately publish on each copy an appropriate > copyright notice and disclaimer of warranty; keep intact all the notices > that refer to this License and to the absence of any warranty; [...] > 2. You may modify your copy or copies of the Library or any portion of > it, thus forming a work based on the Library, and copy and distribute such > modifications or work under the terms of Section 1 above, [...] GPL-HOWTO: > If you have copied code from other programs covered by the same license, > copy their copyright notices too. Put all the copyright notices together, > right near the top of each file.

2 1

Re: [ros-dev] [ros-diffs] [sginsberg] 37523: - winternl.h is deprecated since the NDK was invented, don't use
by Steven Edwards 21 Nov '08

21 Nov '08

On Fri, Nov 21, 2008 at 2:23 PM, <sginsberg(a)svn.reactos.org> wrote: > URL: http://svn.reactos.org/svn/reactos?rev=37523&view=rev > Log: > - winternl.h is deprecated since the NDK was invented, don't use I am sure there are some wine sources somewhere that we have the make use of it but perhaps we could add some sort of check like #ifndef __WINESRC__ #error Don't use winternl.h! #endif or something similar. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [ros-dev] FOSDEM booth/devroom sharing
by François Revol 21 Nov '08

21 Nov '08

Replying to myself... > (sent to AROS (please forward, I'm not on the dev list), ReactOS, > Syllable, CCed to Haiku) Moved from ros-general to ros-dev as the former seems very quiet... > > Hello, > I'm a Haiku developer, <http://haiku-os.org> > and I would like to propose sharing a devroom, eventually a booth at > FOSDEM with some other FOSS OS projects. As I've been told by the orga, other projects should also book the devroom officially: http://fosdem.org/2009/call_for_devrooms_and_stands Just add you are ok to share it. The official deadline is tomorrow... > > I sent to the mailing lists as I couldn't identify a specific > contact, > and I don't know how much centralized each project is. > > Last year we had our own booth at FOSDEM (we it shared with an ERP > software), > I really enjoyed the event, and would like to also get a devroom this > year. > But I'm not sure we will have enough people to animate it all the > time > (currently 3 or 4), plus we'd still have a stand to look after. > > http://www.haiku-os.org/blog/mmu_man/2008-02-25/hello_from_fosdem > > I know we shared a booth at last LinuxWorld with ReactOS and I heard > it > was interesting: > http://www.haiku-os.org/blog/umccullough/2008-08-06/day_1_at_linuxworld_200… > > http://www.haiku-os.org/blog/umccullough/2008-08-07/day_2_at_linuxworld_200… > > > As the deadline for booth and devroom application approaches (it's > before 22 nov.), I was thinking about sharing a devroom that could be > called "alternative OSes", "grep -v GNU/Linux" or alike, with other > projects. > This way we could all get a devroom with fewer people to man it. > > As for our project, we could have talks and hacking sessions on many > subjects, from architecture and design to installation, and specific > things like the using the FreePascal port, porting applications, > using > replicants (like NetSurf). > > We could also have common talks, about the platforms we support, our > design and goals. > > And if needed we could probably also share a booth with another > project > I suppose, last year we shared with a totally different software. > > I'll be mailing a booth and devroom request tomorrow precising it, > before it's too late. > > François. >

3 2

Event invitation [jornadas Imaginática 2009]
by victor martinez 20 Nov '08

20 Nov '08

Ok,marc ;) I have sent u a mail to: marc.piulach(at)live.com. Sure it will be clasified as Spam so give a look there.I have sent the email in perfect Spanish(i guess u are from Spain,or at least you understand Spanish). There are at least 2 Reacters in Seville with time to show Reactos in Imaginatica.Also some other spanish people have shown some interest to help with it. You can contact with me in vicmarcal(at)hotmail.com, so we can begin (if u want) to prepare this Event. Thanks Marc. _________________________________________________________________ Los más de lo más, Especial Rankings http://events.es.msn.com/dinero/listas/default.aspx

1 0

Re: [ros-dev] Job offer: Linux tool to create a valid Windows Registry hive file
by Chris Evans 20 Nov '08

20 Nov '08

1 0

Re: [ros-dev] Event invitation [jornadas Imaginática 2009]
by Marc Piulachs 20 Nov '08

20 Nov '08

Hi Victor, I haven't done any special "negotiations" mainly because anyone expressed interest on participating in the event. In case you or anyone else want to participate feel free to contact me and maybe we can workout something Regards, /Marc From: victor martinez Sent: Thursday, November 20, 2008 4:01 PM To: ros-dev(a)reactos.org Subject: [ros-dev] Re: Event invitation [jornadas Imaginática 2009] Hi All,I have been contacted/invited to participate and give a talk about ReactOS in an event organized by the university of Seville, spain (very beautiful city!) on 2-6 March 2009. It would be great if some of the other spanish based members are also interested on participate, I have been disconnected from the project lately due to offline life but would be willing to participate in this event and help to spread the word about reactos in academic circles.More information here (in spanish): http://imaginatica.org/2009/descargas/Dossier.pdfRegards,/MarcHi Marc, there are spanish people in Seville interested in Imaginatica Event. Does the invitation still available?How goes the "negotiations"?are they still counting on us being at Imaginatica?Thanks in advance. This event mix the most important IT companies,and also there are a lot of skilled developers.This is one of the most important Event in Spain (since SIMO has been cancelled).So being in Imaginatica must be a priority ;)VicmarcalSeville -------------------------------------------------------------------------------- No te aburras más, engánchate a los Juegos de Messenger -------------------------------------------------------------------------------- _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

1 0

Re: Event invitation [jornadas Imaginática 2009]
by victor martinez 20 Nov '08

20 Nov '08

Hi All, I have been contacted/invited to participate and give a talk about ReactOS in an event organized by the university of Seville, spain (very beautiful city!) on 2-6 March 2009. It would be great if some of the other spanish based members are also interested on participate, I have been disconnected from the project lately due to offline life but would be willing to participate in this event and help to spread the word about reactos in academic circles. More information here (in spanish): http://imaginatica.org/2009/descargas/Dossier.pdf Regards, /Marc Hi Marc, there are spanish people in Seville interested in Imaginatica Event. Does the invitation still available?How goes the "negotiations"?are they still counting on us being at Imaginatica? Thanks in advance. This event mix the most important IT companies,and also there are a lot of skilled developers.This is one of the most important Event in Spain (since SIMO has been cancelled). So being in Imaginatica must be a priority ;) Vicmarcal Seville _________________________________________________________________ Los más de lo más, Especial Rankings http://events.es.msn.com/dinero/listas/default.aspx

1 0

Re: [ros-dev] [ros-diffs] [cfinck] 37465: Dmitry Gorbachev - Fix compiler warnings, treated as errors due to our settings, which are emitted when using GCC 4.3.2 See issue #3849 for more details.
by Matthieu Suiche 19 Nov '08

19 Nov '08

char buf[MAX_PATH]; [...] strcat(buf, DIR_SEPARATOR_STRING); strcat(buf, source); strcat(buf, entry->d_name); I'm not sure this is really safe. -- Matthieu Suiche On Wed, Nov 19, 2008 at 8:59 PM, <cfinck(a)svn.reactos.org> wrote: > Author: cfinck > Date: Wed Nov 19 13:59:54 2008 > New Revision: 37465 > > URL: http://svn.reactos.org/svn/reactos?rev=37465&view=rev > Log: > Dmitry Gorbachev > - Fix compiler warnings, treated as errors due to our settings, which are emitted when using GCC 4.3.2 > > See issue #3849 for more details. > > Modified: > trunk/reactos/tools/cabman/cabinet.cxx > trunk/reactos/tools/cdmake/cdmake.c > trunk/reactos/tools/rgenstat/rgenstat.c > > Modified: trunk/reactos/tools/cabman/cabinet.cxx > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/cabman/cabinet.cxx?r… > ============================================================================== > --- trunk/reactos/tools/cabman/cabinet.cxx [iso-8859-1] (original) > +++ trunk/reactos/tools/cabman/cabinet.cxx [iso-8859-1] Wed Nov 19 13:59:54 2008 > @@ -2055,9 +2055,19 @@ > return CAB_STATUS_CANNOT_READ; > } > > - GetFileTimes(SrcFile, FileNode); > - > - GetAttributesOnFile(FileNode); > + if (GetFileTimes(SrcFile, FileNode) != CAB_STATUS_SUCCESS) > + { > + DPRINT(MIN_TRACE, ("Cannot read file times.\n")); > + FreeMemory(NewFileName); > + return CAB_STATUS_CANNOT_READ; > + } > + > + if (GetAttributesOnFile(FileNode) != CAB_STATUS_SUCCESS) > + { > + DPRINT(MIN_TRACE, ("Cannot read file attributes.\n")); > + FreeMemory(NewFileName); > + return CAB_STATUS_CANNOT_READ; > + } > > CloseFile(SrcFile); > > @@ -3646,7 +3656,8 @@ > strcpy(buf, File->FileName); > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + return CAB_STATUS_CANNOT_READ; > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, File->FileName); > } > @@ -3689,7 +3700,8 @@ > strcpy(buf, File->FileName); > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + return CAB_STATUS_CANNOT_READ; > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, File->FileName); > } > > Modified: trunk/reactos/tools/cdmake/cdmake.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/cdmake/cdmake.c?rev=… > ============================================================================== > --- trunk/reactos/tools/cdmake/cdmake.c [iso-8859-1] (original) > +++ trunk/reactos/tools/cdmake/cdmake.c [iso-8859-1] Wed Nov 19 13:59:54 2008 > @@ -882,7 +882,8 @@ > } > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + error_exit("Can't get CWD: %s\n", strerror(errno)); > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, source); > strcat(buf, entry->d_name); > @@ -943,7 +944,8 @@ > } > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + error_exit("Can't get CWD: %s\n", strerror(errno)); > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, source); > } > @@ -994,7 +996,8 @@ > } > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + error_exit("Can't get CWD: %s\n", strerror(errno)); > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, source); > strcat(buf, entry->d_name); > > Modified: trunk/reactos/tools/rgenstat/rgenstat.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rgenstat/rgenstat.c?… > ============================================================================== > --- trunk/reactos/tools/rgenstat/rgenstat.c [iso-8859-1] (original) > +++ trunk/reactos/tools/rgenstat/rgenstat.c [iso-8859-1] Wed Nov 19 13:59:54 2008 > @@ -553,7 +553,11 @@ > } > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + { > + printf("Can't get CWD: %s\n", strerror(errno)); > + return; > + } > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, path); > strcat(buf, entry->d_name); > @@ -611,7 +615,11 @@ > } > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + { > + printf("Can't get CWD: %s\n", strerror(errno)); > + return; > + } > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, path); > strcat(buf, entry->d_name); > >

1 0

OpenWatcom.
by Marcin Dalecki 19 Nov '08

19 Nov '08

Has anybody considered to use the openwatcom compiler for ReactOS? http://www.openwatcom.org/index.php/Main_Page At least it provides a proper native SEH implementation and is as free as the GCC is. ➧ Marcin Dalecki ❖

1 0

Re: [ros-dev] [ros-diffs] [jimtabor] 37436: - Fixes bug 3864. While I was at it I fixed most of the gdi max bit max info sizes too. - Added notes for the SEH abuse in win32k dibobj.c. - Tested WinMerge 2.10.2, AbiWord 2.4.1, Firefox 1.5.0.3 and wine
by James Tabor 19 Nov '08

19 Nov '08

These are correct changes. On Tue, Nov 18, 2008 at 10:34 AM, Aleksey Bragin <aleksey(a)reactos.org> wrote: > May I ask why those if (!Info) checks are required? To me it makes no > sense to call those APIs with the cruicial, mandatory working (and in > one case the only) parameter being NULL, and I would put an ASSERT > (Info) there to catch bad callers and fix them. > > WBR, > Aleksey. > > On Nov 18, 2008, at 8:36 AM, jimtabor(a)svn.reactos.org wrote: > >> Author: jimtabor >> Date: Mon Nov 17 23:36:19 2008 >> New Revision: 37436 >> >> UINT >> FASTCALL >> DIB_BitmapMaxBitsSize( PBITMAPINFO Info, UINT ScanLines ) >> { >> UINT MaxBits = 0; >> + >> + if (!Info) return 0; >> >> >> +UINT >> +FASTCALL >> +DIB_BitmapBitsSize( PBITMAPINFO Info ) >> +{ >> + UINT Ret; >> + >> + if (!Info) return 0; >

2 3

[ros-diffs] [jimtabor] 37345: - Add path support for ExtTextOut.
by Dmitry Gorbachev 19 Nov '08

19 Nov '08

gedmurphy wrote: > Let's say you implement a function in our win32k, based on Wine code. How > exactly would you realistically discover which Wine dev wrote that > function, and if the function was merely _based_ on wine code, which parts > of the function would you attribute credit to, and how would you do it? I think if the dev is not known, then all authors should be credited. I.e.: "Parts of this file are Copyright (C) ... ". Or: to gather the original Wine copiright notices into a separate file and put a pointer to it in any file which is based on Wine.

3 2

Re: [ros-dev] [ros-diffs] [jimtabor] 37345: - Add path support for ExtTextOut.
by Steven Edwards 19 Nov '08

19 Nov '08

Dmitry, On Tue, Nov 18, 2008 at 2:22 AM, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > http://www.reactos.org/archives/public/ros-diffs/2008-November/027021.html > > Please stop copying Wine code without any copyright and source > reference into reactos. This became very bad practice from your > side during last years. I have no power with the ReactOS project other than to ask and try to get policy changed in a democratic manner. I've made the case for the ReactOS to do a better job at proper attribution in code that is imported based on feedback from you in the past. In fact, just yesterday I replied to ros-dev proposing some guidelines for how to handle code imported from Wine. There is nothing more I can do. I have CC'd Alexandre and Jeremy for there thoughts on the subject. I welcome feedback from the Software Freedom Law Center or the FSF with reguards to this issue because on one hand I understand the attribution is important but on the other hand ReactOS is persona non-grata with Wine. Given Wine's reluctance to accept any contributions from ReactOS developers, totally based on guilt by assocation I think its in your best interested not to be credited. The Software is still being released under the terms you granted so I don't see a major violation. >From the LGPL preamble: "...Also, if the library is modified by someone else and passed on, the recipients should know that what they have is not the original version, so that the original author's reputation will not be affected by problems that might be introduced by others." Clearly the ReactOS developer is doing you a favor by not hurting your reputation if ReactOS is as Toxic as Wine makes it out to be. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

5 6

Southern California Linux Expo
by Zachary Gorden 19 Nov '08

19 Nov '08

So we've been invited to SCALE and I'm wondering whether any of the devs can actually make it. Arty is a logical choice because he's so close and we might be able to pull in some community members who are close by if we can only get one dev there. We'd get a booth on the show floor which includes table, chairs, power, ethernet drop, and 3-5 passes to the show. Are we going to be able to make it this year at all?

2 1

Re: [ros-dev] [ros-diffs] [dchapyshev] 37396: - Implement BindIoCompletionCallback, ReadFileScatter, WriteFileGather (based on Wine) - Move DnsHostnameToComputerNameA/W to computername.c
by gedmurphy 19 Nov '08

19 Nov '08

Steven has repeatedly asked for credit, and I quote: " Please add the appropriate copyright headers to the source file stating the original author when implementing code based on third party sources." Is there a reason for not doing it this time? Secondly, why are things being implemented in stubs? Thirdly, it's worth checking implementations before moving out of stubs. Just because Wine does something, doesn't mean it's correct for us. DnsHostnameToComputerName should call RtlDnsHostNameToComputerName. I stopped checking the rest of the code as soon as I read that, in case someone assumes I looked at everything. Fourthly, I'm willing to bet this email gets ignored too. Please take a little more time over commits. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dchapyshev(a)svn.reactos.org Sent: 17 November 2008 11:54 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dchapyshev] 37396: - Implement BindIoCompletionCallback, ReadFileScatter, WriteFileGather (based on Wine) - Move DnsHostnameToComputerNameA/W to computername.c Author: dchapyshev Date: Mon Nov 17 05:53:59 2008 New Revision: 37396 URL: http://svn.reactos.org/svn/reactos?rev=37396&view=rev Log: - Implement BindIoCompletionCallback, ReadFileScatter, WriteFileGather (based on Wine) - Move DnsHostnameToComputerNameA/W to computername.c Modified: trunk/reactos/dll/win32/kernel32/misc/computername.c trunk/reactos/dll/win32/kernel32/misc/stubs.c Modified: trunk/reactos/dll/win32/kernel32/misc/computername.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/misc/co… ============================================================================== --- trunk/reactos/dll/win32/kernel32/misc/computername.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/misc/computername.c [iso-8859-1] Mon Nov 17 05:53:59 2008 @@ -461,4 +461,73 @@ } } + +/* + * @implemented + */ +BOOL +STDCALL +DnsHostnameToComputerNameA(LPCSTR Hostname, + LPSTR ComputerName, + LPDWORD nSize) +{ + DWORD len; + + DPRINT("(%s, %p, %p)\n", Hostname, ComputerName, nSize); + + if (!Hostname || !nSize) + return FALSE; + + len = lstrlenA(Hostname); + + if (len > MAX_COMPUTERNAME_LENGTH) + len = MAX_COMPUTERNAME_LENGTH; + + if (*nSize < len) + { + *nSize = len; + return FALSE; + } + + if (!ComputerName) return FALSE; + + memcpy( ComputerName, Hostname, len ); + ComputerName[len + 1] = 0; + return TRUE; +} + + +/* + * @implemented + */ +BOOL +STDCALL +DnsHostnameToComputerNameW ( + LPCWSTR hostname, + LPWSTR computername, + LPDWORD size + ) +{ + DWORD len; + + DPRINT("(%s, %p, %p): stub\n", hostname, computername, size); + + if (!hostname || !size) return FALSE; + len = lstrlenW(hostname); + + if (len > MAX_COMPUTERNAME_LENGTH) + len = MAX_COMPUTERNAME_LENGTH; + + if (*size < len) + { + *size = len; + return FALSE; + } + if (!computername) return FALSE; + + memcpy( computername, hostname, len * sizeof(WCHAR) ); + computername[len + 1] = 0; + return TRUE; +} + /* EOF */ Modified: trunk/reactos/dll/win32/kernel32/misc/stubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/misc/st… ============================================================================== --- trunk/reactos/dll/win32/kernel32/misc/stubs.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/misc/stubs.c [iso-8859-1] Mon Nov 17 05:53:59 2008 @@ -342,18 +342,29 @@ } /* - * @unimplemented - */ -BOOL -STDCALL -BindIoCompletionCallback ( - HANDLE FileHandle, - LPOVERLAPPED_COMPLETION_ROUTINE Function, - ULONG Flags - ) -{ - STUB; - return 0; + * @implemented + */ +BOOL +STDCALL +BindIoCompletionCallback(HANDLE FileHandle, + LPOVERLAPPED_COMPLETION_ROUTINE Function, + ULONG Flags) +{ + NTSTATUS Status = 0; + + DPRINT("(%p, %p, %d)\n", FileHandle, Function, Flags); + + Status = RtlSetIoCompletionCallback(FileHandle, + (PRTL_OVERLAPPED_COMPLETION_ROUTINE) Function, + Flags); + + if (!NT_SUCCESS(Status)) + { + SetLastError(RtlNtStatusToDosError(Status)); + return FALSE; + } + + return TRUE; } /* @@ -562,20 +573,45 @@ } /* - * @unimplemented - */ -BOOL -STDCALL -ReadFileScatter( - HANDLE hFile, - FILE_SEGMENT_ELEMENT aSegmentArray[], - DWORD nNumberOfBytesToRead, - LPDWORD lpReserved, - LPOVERLAPPED lpOverlapped - ) -{ - STUB; - return 0; + * @implemented + */ +BOOL +STDCALL +ReadFileScatter(HANDLE hFile, + FILE_SEGMENT_ELEMENT aSegmentArray[], + DWORD nNumberOfBytesToRead, + LPDWORD lpReserved, + LPOVERLAPPED lpOverlapped) +{ + PIO_STATUS_BLOCK pIOStatus; + LARGE_INTEGER Offset; + NTSTATUS Status; + + DPRINT("(%p %p %u %p)\n", hFile, aSegmentArray, nNumberOfBytesToRead, lpOverlapped); + + Offset.LowPart = lpOverlapped->Offset; + Offset.HighPart = lpOverlapped->OffsetHigh; + pIOStatus = (PIO_STATUS_BLOCK) lpOverlapped; + pIOStatus->Status = STATUS_PENDING; + pIOStatus->Information = 0; + + Status = NtReadFileScatter(hFile, + NULL, + NULL, + NULL, + pIOStatus, + aSegmentArray, + nNumberOfBytesToRead, + &Offset, + NULL); + + if (!NT_SUCCESS(Status)) + { + SetLastError(RtlNtStatusToDosError(Status)); + return FALSE; + } + + return TRUE; } /* @@ -678,20 +714,45 @@ } /* - * @unimplemented - */ -BOOL -STDCALL -WriteFileGather( - HANDLE hFile, - FILE_SEGMENT_ELEMENT aSegmentArray[], - DWORD nNumberOfBytesToWrite, - LPDWORD lpReserved, - LPOVERLAPPED lpOverlapped - ) -{ - STUB; - return 0; + * @implemented + */ +BOOL +STDCALL +WriteFileGather(HANDLE hFile, + FILE_SEGMENT_ELEMENT aSegmentArray[], + DWORD nNumberOfBytesToWrite, + LPDWORD lpReserved, + LPOVERLAPPED lpOverlapped) +{ + PIO_STATUS_BLOCK IOStatus; + LARGE_INTEGER Offset; + NTSTATUS Status; + + DPRINT("%p %p %u %p\n", hFile, aSegmentArray, nNumberOfBytesToWrite, lpOverlapped); + + Offset.LowPart = lpOverlapped->Offset; + Offset.HighPart = lpOverlapped->OffsetHigh; + IOStatus = (PIO_STATUS_BLOCK) lpOverlapped; + IOStatus->Status = STATUS_PENDING; + IOStatus->Information = 0; + + Status = NtWriteFileGather(hFile, + NULL, + NULL, + NULL, + IOStatus, + aSegmentArray, + nNumberOfBytesToWrite, + &Offset, + NULL); + + if (!NT_SUCCESS(Status)) + { + SetLastError(RtlNtStatusToDosError(Status)); + return FALSE; + } + + return TRUE; } /* @@ -705,39 +766,6 @@ { STUB; return 0; -} - -/* - * @unimplemented - */ -BOOL -STDCALL -DnsHostnameToComputerNameW ( - LPCWSTR hostname, - LPWSTR computername, - LPDWORD size - ) -{ - DWORD len; - - DPRINT("(%s, %p, %p): stub\n", hostname, computername, size); - - if (!hostname || !size) return FALSE; - len = lstrlenW(hostname); - - if (len > MAX_COMPUTERNAME_LENGTH) - len = MAX_COMPUTERNAME_LENGTH; - - if (*size < len) - { - *size = len; - return FALSE; - } - if (!computername) return FALSE; - - memcpy( computername, hostname, len * sizeof(WCHAR) ); - computername[len + 1] = 0; - return TRUE; } /* @@ -919,21 +947,6 @@ /* * @unimplemented */ -BOOL -STDCALL -DnsHostnameToComputerNameA ( - LPCSTR Hostname, - LPSTR ComputerName, - LPDWORD nSize - ) -{ - STUB; - return 0; -} - -/* - * @unimplemented - */ HANDLE STDCALL FindFirstVolumeMountPointA( @@ -947,23 +960,22 @@ } /* - * @unimplemented - */ -BOOL -STDCALL -FindNextVolumeA( - HANDLE handle, - LPSTR volume, - DWORD len - ) -{ - WCHAR *buffer = HeapAlloc( GetProcessHeap(), 0, len * sizeof(WCHAR) ); + * @implemented + */ +BOOL +STDCALL +FindNextVolumeA(HANDLE handle, + LPSTR volume, + DWORD len) +{ + WCHAR *buffer = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); BOOL ret; if ((ret = FindNextVolumeW( handle, buffer, len ))) { if (!WideCharToMultiByte( CP_ACP, 0, buffer, -1, volume, len, NULL, NULL )) ret = FALSE; } + HeapFree( GetProcessHeap(), 0, buffer ); return ret; }

4 5

Re: [ros-dev] [ros-diffs] [jimtabor] 37436: - Fixes bug 3864. While I was at it I fixed most of the gdi max bit max info sizes too. - Added notes for the SEH abuse in win32k dibobj.c. - Tested WinMerge 2.10.2, AbiWord 2.4.1, Firefox 1.5.0.3 and wine gdi32 bitmap cross test. - When testing with gdi cross test in 24 and 32 bit display mode, we have a pixel conversion mismatch. Please fix it!
by Aleksey Bragin 18 Nov '08

18 Nov '08

May I ask why those if (!Info) checks are required? To me it makes no sense to call those APIs with the cruicial, mandatory working (and in one case the only) parameter being NULL, and I would put an ASSERT (Info) there to catch bad callers and fix them. WBR, Aleksey. On Nov 18, 2008, at 8:36 AM, jimtabor(a)svn.reactos.org wrote: > Author: jimtabor > Date: Mon Nov 17 23:36:19 2008 > New Revision: 37436 > > UINT > FASTCALL > DIB_BitmapMaxBitsSize( PBITMAPINFO Info, UINT ScanLines ) > { > UINT MaxBits = 0; > + > + if (!Info) return 0; > > > +UINT > +FASTCALL > +DIB_BitmapBitsSize( PBITMAPINFO Info ) > +{ > + UINT Ret; > + > + if (!Info) return 0;

1 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 37431: forgot this file
by Matthieu Suiche 18 Nov '08

18 Nov '08

+ return !!(Flags & EFLAGS_INTERRUPT_MASK); Why do you donnot use something like that instead ? return (Flags & EFLAGS_INTERRUPT_MASK) ? TRUE: FALSE; -- Matthieu Suiche On Tue, Nov 18, 2008 at 3:27 AM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Mon Nov 17 20:27:04 2008 > New Revision: 37431 > > URL: http://svn.reactos.org/svn/reactos?rev=37431&view=rev > Log: > forgot this file > > Added: > branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/interrupt.c (with props) > > Added: branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/interrupt.c > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk… > ============================================================================== > --- branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/interrupt.c (added) > +++ branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/interrupt.c [iso-8859-1] Mon Nov 17 20:27:04 2008 > @@ -1,0 +1,62 @@ > +/* > + * PROJECT: ReactOS Kernel > + * LICENSE: GPL - See COPYING in the top level directory > + * FILE: ntoskrnl/ke/i386/irq.c > + * PURPOSE: Manages the Kernel's IRQ support for external drivers, > + * for the purpopses of connecting, disconnecting and setting > + * up ISRs for drivers. The backend behind the Io* Interrupt > + * routines. > + * PROGRAMMERS: Timo Kreuzer (timo.kreuzer(a)web.de) > + */ > + > +/* INCLUDES *****************************************************************/ > + > +#include <ntoskrnl.h> > +#define NDEBUG > +#include <debug.h> > + > +/* FUNCTIONS ****************************************************************/ > + > + > + > +BOOLEAN > +NTAPI > +KeDisableInterrupts(VOID) > +{ > + ULONG64 Flags; > + > + /* Get the flags */ > + Flags = __readeflags(); > + > + /* Disable interrupts */ > + _disable(); > + > + return !!(Flags & EFLAGS_INTERRUPT_MASK); > +} > + > + > +BOOLEAN > +NTAPI > +KeDisconnectInterrupt(IN PKINTERRUPT Interrupt) > +{ > + UNIMPLEMENTED; > + return FALSE; > +} > + > +VOID > +NTAPI > +KeInitializeInterrupt(IN PKINTERRUPT Interrupt, > + IN PKSERVICE_ROUTINE ServiceRoutine, > + IN PVOID ServiceContext, > + IN PKSPIN_LOCK SpinLock, > + IN ULONG Vector, > + IN KIRQL Irql, > + IN KIRQL SynchronizeIrql, > + IN KINTERRUPT_MODE InterruptMode, > + IN BOOLEAN ShareVector, > + IN CHAR ProcessorNumber, > + IN BOOLEAN FloatingSave) > +{ > + UNIMPLEMENTED; > +} > + > > Propchange: branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/interrupt.c > ------------------------------------------------------------------------------ > svn:eol-style = native > >

1 0

Another WIDL sync, another build breakage
by Olaf Siejka 17 Nov '08

17 Nov '08

This is just getting repetitive: [WIDL] obj-i386\include\reactos\idl\lsa_c.c include\reactos\idl\lsa.idl:17: Error: NTSTATUS: redefinition error; original definition was at ( ť: 21 mingw32-make: *** [obj-i386\include\reactos\idl\lsa_c.c] Error 1 mingw32-make: *** Waiting for unfinished jobs.... [WIDL] obj-i386\include\reactos\idl\eventlogrpc_c.c include\reactos\idl\eventlogrpc.idl:7: Error: NTSTATUS: redefinition error; original definition was at Ş■.:21 mingw32-make: *** [obj-i386\include\reactos\idl\eventlogrpc_c.c] Error 1 With all due respect, Eric, would you be so kind and test your commits on more OS than your PC/buildbot???

1 0

Re: [ros-dev] [ros-diffs] [greatlrd] 37343: Bugfix : Do not link to LPDDRAWI_DIRECTDRAW_INT->lpLink when we do not have any LPDDRAWI_DIRECTDRAW_INT->lpLcl
by gedmurphy 16 Nov '08

16 Nov '08

Is it not time to start getting rid of IsBadWritePtr and friends? I don't see a good reason for these in our own code, especially when we can just use SEH directly. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of greatlrd(a)svn.reactos.org Sent: 13 November 2008 19:52 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [greatlrd] 37343: Bugfix : Do not link to LPDDRAWI_DIRECTDRAW_INT->lpLink when we do not have any LPDDRAWI_DIRECTDRAW_INT->lpLcl Author: greatlrd Date: Thu Nov 13 13:52:20 2008 New Revision: 37343 URL: http://svn.reactos.org/svn/reactos?rev=37343&view=rev Log: Bugfix : Do not link to LPDDRAWI_DIRECTDRAW_INT->lpLink when we do not have any LPDDRAWI_DIRECTDRAW_INT->lpLcl Modified: branches/reactx/reactos/dll/directx/ddraw/startup.c Modified: branches/reactx/reactos/dll/directx/ddraw/startup.c URL: http://svn.reactos.org/svn/reactos/branches/reactx/reactos/dll/directx/ddra… ============================================================================== --- branches/reactx/reactos/dll/directx/ddraw/startup.c [iso-8859-1] (original) +++ branches/reactx/reactos/dll/directx/ddraw/startup.c [iso-8859-1] Thu Nov 13 13:52:20 2008 @@ -33,8 +33,8 @@ This = (LPDDRAWI_DIRECTDRAW_INT)*pIface; - /* fixme linking too second link when we shall not doing it */ - if (IsBadReadPtr(This,sizeof(LPDIRECTDRAW))) + if ( (IsBadWritePtr(This,sizeof(LPDDRAWI_DIRECTDRAW_INT)) != 0) || + (IsBadWritePtr(This->lpLcl,sizeof(LPDDRAWI_DIRECTDRAW_LCL)) != 0) ) { /* We do not have a DirectDraw interface, we need alloc it*/ LPDDRAWI_DIRECTDRAW_INT memThis;

5 5

[WIDL] Problems with latest sync
by Olaf Siejka 16 Nov '08

16 Nov '08

Since revisions 37313-37314 i observe repetitive problems with WIDL. Every time WIDL is called by our BE, it throws an exception: Faulting application widl.exe, version 0.0.0.0, time stamp 0x491c610d, faulting module widl.exe, version 0.0.0.0, time stamp 0x491c610d, exception code 0xc0000005, fault offset 0x00005f0a, process id 0x17f8, application start time 0x01c945b3aefa8530. > [WIDL] obj-i386\include\reactos\idl\svcctl_s.c > [WIDL] obj-i386\include\reactos\idl\svcctl_s.h > mingw32-make: *** Waiting for unfinished jobs.... > mingw32-make: *** [obj-i386\include\reactos\idl\svcctl_s.h] Error -1073741819 (0xC0000005) > mingw32-make: *** [obj-i386\include\reactos\idl\svcctl_s.c] Error -1073741819 (0xC0000005) Reverting revisions 37313 and 37314 fixes this problem. Apart from me, this issue been noted by dreimer, encoded and Christoph_vW. Dunno about Christoph, but me, dreimer and encoded are using Vista/2008. I couldnt replicate this issue on XP/2003 though.

3 2

1st stage GUI setup and file system managment
by Matthias Kupfer 13 Nov '08

13 Nov '08

Hi folks, during the development of the 1st-stage-GUI-setup I experienced some problems with physical drive detection with reactos api (because it's fairly incomplete - it works under windows). To continue the development and to bring more benefits I want to make following suggestion. Sooner or later we need a drive/volume/partition management tool, so i will continue with this basing on the usetup code and replaced later by working reactos api calls. So we can use this tool to determine the current harddisk(s) layout(s), create/delete partitions, format with different file systems and show/install/configure the current boot loader. Later I can use this functions to handle the drives during installation process in a similiar way. What do you think about this plan? Matt -- Matthias Kupfer Telefon +49 (0) 371 236 46 52 Wilhelm-Firl-Straße 21 Mobil +49 (0) 160 859 43 54 09122 Chemnitz

2 1

Add a linkerflag to make sure we get an .eh_frame section
by Dmitry Gorbachev 12 Nov '08

12 Nov '08

Hi, > Todo: Get it at the end of the executable, so we can safely remove it. I think it can be safely removed from inside of the executable — just wasting some address space.

1 0

Re: [ros-dev] [ros-diffs] [gschneider] 37281: Implement ConvertSecurityDescriptorToStringSecurityDescriptorW based on Wine code.
by Steven Edwards 10 Nov '08

10 Nov '08

On Mon, Nov 10, 2008 at 9:25 AM, <gschneider(a)svn.reactos.org> wrote: > Author: gschneider > Date: Mon Nov 10 08:25:24 2008 > New Revision: 37281 > > URL: http://svn.reactos.org/svn/reactos?rev=37281&view=rev > Log: > Implement ConvertSecurityDescriptorToStringSecurityDescriptorW based on Wine code. Please add the appropriate copyright headers to the source file stating the original author when implementing code based on third party sources. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

seh 64
by Timo Kreuzer 10 Nov '08

10 Nov '08

Hi, I have recently been working on getting SEH into the x64 port. This covers several parts. One of them is compiler support. On x64 SEH is table based rather than code based, that means it needs tables of unwind data. These can be generated from DWARF unwind info - which gcc generates - and that's what I'm working on. The x64 version of rsym shall parse the DWARF unwind data and convert it into Windows compatible unwind data. Now there is a problem. While older versions of mingw64 used the ".debug_frame" section, the newer versions use the ".eh_frame" section. That is good and bad at the same time. What does that mean? What's the difference? The .eh_frame section isn't part of the DWARF 2 or 3 specification, it's a GNU extension / part of the LSB-Core specification. Documentation was hard to find, but google is your friend and it seems there's only one major difference to the debug_frame section and that is relative addressing rather than absolute. This is actually very good and saves the day for all modules that live in kernel space, because the addresses are only 32 bits. There is still a problem left. While the .debug_frame section is by default put into the output executable as a seperate section, the .eh_frame section isn't. The default linker script puts it into the ".rdata" section. But there it's kinda lost and I don't want to keep it anyway. With ntoskrnl there's no problem as it uses it's own linker script anyway. I can change it, so the .eh_frame section is put at the end of the executable. But how do I do this for the other modules? Do i need to provide a new default linkerscript for all other modules? Can I "fix" this behavior in RosBE64 (the files in lib/ldscripts seem to be unused)? Or does anyone know a command line option to change this default behavior? Regards, Timo

2 6

seh 64
by Dmitry Gorbachev 08 Nov '08

08 Nov '08

> Or does anyone know a command line option to change this default behavior? --unique=.eh_frame ?

2 1

Re: [ros-dev] [ros-diffs] [cgutman] 37248: - Check the status of IPSendDatagram - Validate the protocol - Use the hash value of the NCE address to get the lock - Simplify TCPAbortListenForSocket - Hardcode the length of the array
by Aleksey Bragin 08 Nov '08

08 Nov '08

On Nov 7, 2008, at 11:31 PM, cgutman(a)svn.reactos.org wrote: > Author: cgutman > Date: Fri Nov 7 14:31:34 2008 > New Revision: 37248 > > URL: http://svn.reactos.org/svn/reactos?rev=37248&view=rev > Log: > - Check the status of IPSendDatagram > - Validate the protocol > - Use the hash value of the NCE address to get the lock > - Simplify TCPAbortListenForSocket > - Hardcode the length of the array > > + HashValue = *(PULONG)(&NCE->Address.Address); > + HashValue ^= HashValue >> 16; > + HashValue ^= HashValue >> 8; > + HashValue ^= HashValue >> 4; > + HashValue &= NB_HASHMASK; It's used at least three times in the source code, I would do an inline hash-calculating function for that.

1 0

Re: [ros-dev] [ros-diffs] [cgutman] 37247: - Close the connection before freeing it
by Aleksey Bragin 08 Nov '08

08 Nov '08

Does TCPClose do what was written in comments (cancelling all pending requests)? I wonder if it was that simple, why it wasn't implemented this way before? ;) On Nov 7, 2008, at 10:12 PM, cgutman(a)svn.reactos.org wrote: > Author: cgutman > Date: Fri Nov 7 13:12:26 2008 > New Revision: 37247 > > URL: http://svn.reactos.org/svn/reactos?rev=37247&view=rev > Log: > - Close the connection before freeing it > > Modified: > branches/aicom-network-fixes/lib/drivers/ip/transport/tcp/tcp.c > > Modified: branches/aicom-network-fixes/lib/drivers/ip/transport/tcp/ > tcp.c > URL: http://svn.reactos.org/svn/reactos/branches/aicom-network- > fixes/lib/drivers/ip/transport/tcp/tcp.c? > rev=37247&r1=37246&r2=37247&view=diff > ====================================================================== > ======== > --- branches/aicom-network-fixes/lib/drivers/ip/transport/tcp/tcp.c > [iso-8859-1] (original) > +++ branches/aicom-network-fixes/lib/drivers/ip/transport/tcp/tcp.c > [iso-8859-1] Fri Nov 7 13:12:26 2008 > @@ -283,8 +283,7 @@ > } > > VOID TCPFreeConnectionEndpoint( PCONNECTION_ENDPOINT Connection ) { > - TI_DbgPrint(MAX_TRACE,("FIXME: Cancel all pending requests\n")); > - /* XXX Cancel all pending requests */ > + TCPClose( Connection ); > ExFreePool( Connection ); > } > >

1 0

Re: [ros-dev] [ros-diffs] [fireball] 37229: - Update the _ros.diff. Usual changes are there (unfortunately incompatibilites in Wine still exist, RpcMgmtWaitForServerListen is still not implemented there, and their dependency on unix sockets is totall
by Steven Edwards 07 Nov '08

07 Nov '08

On Fri, Nov 7, 2008 at 4:54 AM, Aleksey Bragin <aleksey(a)reactos.org> wrote: > I highly doubt they work, in fact I'm sure they won't work at all. > But their only duty is to allow building unmodified rpcrt4 from Wine. > I still have a hope, somewhere very very deep in my soul, that Wine > will stop using linux-specific APIs in DLLs. You can hope and dream. One of the problems we saw, such as in the case of wininet, using unix sockets instead of winsock gave something like a 20% speedup in performance. Another issue was that select on linux (thanks to glibc) fixes FD_SETSIZE at 1024 so the solution was to move to using poll(). The poll/select thing is not that big of a deal as it can be wrapped but fixing the winsock performance issues may require someone to dedicate a lot of time profiling. If you can fix all of the issues so that performance will be the same with pure win32, then I am sure Alexandre will accept it. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 1

Re: [ros-dev] [ros-diffs] [fireball] 37229: - Update the _ros.diff. Usual changes are there (unfortunately incompatibilites in Wine still exist, RpcMgmtWaitForServerListen is still not implemented there, and their dependency on unix sockets is totally out of place)
by gedmurphy 07 Nov '08

07 Nov '08

Do the apis in unix_func actually work? I wrote that file a long time ago, but I never actually tested it. I wasn't sure if that code was ever called. It was written mainly to allow me to build rpcrt4_new (which is what we now use) -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of fireball(a)svn.reactos.org Sent: 06 November 2008 19:10 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [fireball] 37229: - Update the _ros.diff. Usual changes are there (unfortunately incompatibilites in Wine still exist, RpcMgmtWaitForServerListen is still not implemented there, and their dependency on unix sockets is totally out of place). On Author: fireball Date: Thu Nov 6 13:10:03 2008 New Revision: 37229 URL: http://svn.reactos.org/svn/reactos?rev=37229&view=rev Log: - Update the _ros.diff. Usual changes are there (unfortunately incompatibilites in Wine still exist, RpcMgmtWaitForServerListen is still not implemented there, and their dependency on unix sockets is totally out of place). On the good side I could get rid of disabling unix-sockets stuff in source code by slightly improving unix_func. Modified: trunk/reactos/dll/win32/rpcrt4/rpcrt4_ros.diff Modified: trunk/reactos/dll/win32/rpcrt4/rpcrt4_ros.diff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/rpcrt4_ro… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/rpcrt4_ros.diff [iso-8859-1] (original) +++ trunk/reactos/dll/win32/rpcrt4/rpcrt4_ros.diff [iso-8859-1] Thu Nov 6 13:10:03 2008 @@ -1,8 +1,42 @@ +Index: epm_towers.h +=================================================================== +--- epm_towers.h (working copy) ++++ epm_towers.h (working copy) +@@ -17,11 +17,11 @@ + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + * + */ + +-#include "epm.h" ++#include "epm_c.h" + + #define EPM_PROTOCOL_DNET_NSP 0x04 + #define EPM_PROTOCOL_OSI_TP4 0x05 + #define EPM_PROTOCOL_OSI_CLNS 0x06 + #define EPM_PROTOCOL_TCP 0x07 +Index: rpc_epmap.c +=================================================================== +--- rpc_epmap.c (working copy) ++++ rpc_epmap.c (working copy) +@@ -30,11 +30,11 @@ + + #include "wine/debug.h" + #include "wine/exception.h" + + #include "rpc_binding.h" +-#include "epm.h" ++#include "epm_c.h" + #include "epm_towers.h" + + WINE_DEFAULT_DEBUG_CHANNEL(ole); + + /* The "real" RPC portmapper endpoints that I know of are: Index: rpc_server.c =================================================================== --- rpc_server.c (working copy) +++ rpc_server.c (working copy) -@@ -1017,22 +1017,30 @@ +@@ -1040,22 +1040,28 @@ /*********************************************************************** * RpcMgmtServerWaitListen (RPCRT4.@) */ @@ -18,14 +52,12 @@ return RPC_S_NOT_LISTENING; } -+ do -+ { ++ do { LeaveCriticalSection(&listen_cs); ++ LIST_FOR_EACH_ENTRY(cps, &protseqs, RpcServerProtseq, entry) ++ WaitForSingleObject(cps->server_ready_event, INFINITE); - FIXME("not waiting for server calls to finish\n"); -+ LIST_FOR_EACH_ENTRY(cps, &protseqs, RpcServerProtseq, entry) -+ WaitForSingleObject(cps->server_ready_event, INFINITE); -+ + EnterCriticalSection(&listen_cs); + } while (!std_listen); + @@ -39,11 +71,11 @@ =================================================================== --- rpc_transport.c (working copy) +++ rpc_transport.c (working copy) -@@ -54,10 +54,13 @@ - #endif - #ifdef HAVE_SYS_POLL_H - #include <sys/poll.h> - #endif +@@ -65,10 +65,13 @@ + # include <sys/poll.h> + # endif + # define closesocket close + #endif /* defined(__MINGW32__) || defined (_MSC_VER) */ +#include <winsock2.h> +#include <ws2tcpip.h> @@ -53,7 +85,7 @@ #include "winnls.h" #include "winerror.h" #include "winternl.h" -@@ -71,10 +74,12 @@ +@@ -82,10 +85,12 @@ #include "rpc_binding.h" #include "rpc_message.h" #include "rpc_server.h" @@ -66,7 +98,7 @@ #endif WINE_DEFAULT_DEBUG_CHANNEL(rpc); -@@ -83,11 +88,11 @@ +@@ -94,11 +99,11 @@ typedef struct _RpcConnection_np { @@ -79,25 +111,27 @@ static RpcConnection *rpcrt4_conn_np_alloc(void) { -@@ -105,15 +110,15 @@ - { - if (npc->listening) +@@ -118,17 +123,17 @@ return RPC_S_OK; npc->listening = TRUE; -- if (ConnectNamedPipe(npc->pipe, &npc->ovl)) -+ if (ConnectNamedPipe(npc->pipe, &npc->ovl[0])) - return RPC_S_OK; - - if (GetLastError() == ERROR_PIPE_CONNECTED) { -- SetEvent(npc->ovl.hEvent); -+ SetEvent(npc->ovl[0].hEvent); - return RPC_S_OK; - } - if (GetLastError() == ERROR_IO_PENDING) { - /* will be completed in rpcrt4_protseq_np_wait_for_new_connection */ - return RPC_S_OK; -@@ -126,11 +131,11 @@ + for (;;) + { +- if (ConnectNamedPipe(npc->pipe, &npc->ovl)) ++ if (ConnectNamedPipe(npc->pipe, &npc->ovl[0])) + return RPC_S_OK; + + switch(GetLastError()) + { + case ERROR_PIPE_CONNECTED: +- SetEvent(npc->ovl.hEvent); ++ SetEvent(npc->ovl[0].hEvent); + return RPC_S_OK; + case ERROR_IO_PENDING: + /* will be completed in rpcrt4_protseq_np_wait_for_new_connection */ + return RPC_S_OK; + case ERROR_NO_DATA_DETECTED: +@@ -146,11 +151,11 @@ static RPC_STATUS rpcrt4_conn_create_pipe(RpcConnection *Connection, LPCSTR pname) { RpcConnection_np *npc = (RpcConnection_np *) Connection; @@ -110,7 +144,7 @@ RPC_MAX_PACKET_SIZE, RPC_MAX_PACKET_SIZE, 5000, NULL); if (npc->pipe == INVALID_HANDLE_VALUE) { WARN("CreateNamedPipe failed with error %d\n", GetLastError()); -@@ -139,11 +144,12 @@ +@@ -159,11 +164,12 @@ else return RPC_S_CANT_CREATE_ENDPOINT; } @@ -124,7 +158,7 @@ * server thread as the thread must be alertable */ return RPC_S_OK; } -@@ -202,11 +208,13 @@ +@@ -220,11 +226,12 @@ /* success */ memset(&npc->ovl, 0, sizeof(npc->ovl)); /* pipe is connected; change to message-read mode. */ @@ -133,13 +167,12 @@ - npc->ovl.hEvent = CreateEventW(NULL, TRUE, FALSE, NULL); + npc->ovl[0].hEvent = CreateEventW(NULL, TRUE, FALSE, NULL); + npc->ovl[1].hEvent = CreateEventW(NULL, TRUE, FALSE, NULL); -+ npc->pipe = pipe; return RPC_S_OK; } -@@ -308,11 +316,12 @@ +@@ -326,11 +333,12 @@ { /* because of the way named pipes work, we'll transfer the connected pipe * to the child, then reopen the server binding to continue listening */ @@ -153,7 +186,7 @@ old_npc->listening = FALSE; } -@@ -359,13 +368,18 @@ +@@ -377,13 +385,18 @@ unsigned int bytes_left = count; while (bytes_left) @@ -163,39 +196,39 @@ - if (!ret || !bytes_read) + ret = ReadFile(npc->pipe, buf, bytes_left, &bytes_read, &npc->ovl[0]); + if ((!ret || !bytes_read) && (GetLastError() != ERROR_IO_PENDING)) ++ break; ++ ++ ret = GetOverlappedResult(npc->pipe, &npc->ovl[0], &bytes_read, TRUE); ++ if (!ret && (GetLastError() != ERROR_MORE_DATA)) break; -+ -+ ret = GetOverlappedResult(npc->pipe, &npc->ovl[0], &bytes_read, TRUE); -+ if (!ret && GetLastError() != ERROR_MORE_DATA) -+ break; + bytes_left -= bytes_read; buf += bytes_read; } return ret ? count : -1; } -@@ -379,13 +393,18 @@ +@@ -397,13 +410,18 @@ unsigned int bytes_left = count; while (bytes_left) { DWORD bytes_written; -- ret = WriteFile(npc->pipe, buf, count, &bytes_written, NULL); +- ret = WriteFile(npc->pipe, buf, bytes_left, &bytes_written, NULL); - if (!ret || !bytes_written) -+ ret = WriteFile(npc->pipe, buf, count, &bytes_written, &npc->ovl[1]); ++ ret = WriteFile(npc->pipe, buf, bytes_left, &bytes_written, &npc->ovl[1]); + if ((!ret || !bytes_written) && (GetLastError() != ERROR_IO_PENDING)) ++ break; ++ ++ ret = GetOverlappedResult(npc->pipe, &npc->ovl[1], &bytes_written, TRUE); ++ if (!ret && (GetLastError() != ERROR_MORE_DATA)) break; -+ -+ ret = GetOverlappedResult(npc->pipe, &npc->ovl[1], &bytes_written, TRUE); -+ if (!ret && GetLastError() != ERROR_MORE_DATA) -+ break; + bytes_left -= bytes_written; buf += bytes_written; } return ret ? count : -1; } -@@ -396,14 +415,19 @@ +@@ -414,13 +432,17 @@ if (npc->pipe) { FlushFileBuffers(npc->pipe); CloseHandle(npc->pipe); @@ -212,13 +245,11 @@ + CloseHandle(npc->ovl[1].hEvent); + npc->ovl[1].hEvent = 0; } -+ return 0; } static void rpcrt4_conn_np_cancel_call(RpcConnection *Connection) - { -@@ -547,11 +571,11 @@ +@@ -579,11 +601,11 @@ /* open and count connections */ *count = 1; conn = CONTAINING_RECORD(protseq->conn, RpcConnection_np, common); @@ -231,7 +262,7 @@ } /* make array of connections */ -@@ -568,11 +592,11 @@ +@@ -600,11 +622,11 @@ objs[0] = npps->mgr_event; *count = 1; @@ -244,7 +275,7 @@ } LeaveCriticalSection(&protseq->cs); return objs; -@@ -615,11 +639,11 @@ +@@ -647,11 +669,11 @@ b_handle = objs[res - WAIT_OBJECT_0]; /* find which connection got a RPC */ EnterCriticalSection(&protseq->cs); @@ -257,120 +288,3 @@ cconn = NULL; if (conn) RPCRT4_SpawnConnection(&cconn, &conn->common); -@@ -713,16 +737,18 @@ - RpcConnection_tcp *tcpc; - tcpc = HeapAlloc(GetProcessHeap(), 0, sizeof(RpcConnection_tcp)); - if (tcpc == NULL) - return NULL; - tcpc->sock = -1; -+#ifndef __REACTOS__ - if (socketpair(PF_UNIX, SOCK_STREAM, 0, tcpc->cancel_fds) < 0) - { - ERR("socketpair() failed: %s\n", strerror(errno)); - HeapFree(GetProcessHeap(), 0, tcpc); - return NULL; - } -+#endif - return &tcpc->common; - } - - static RPC_STATUS rpcrt4_ncacn_ip_tcp_open(RpcConnection* Connection) - { -@@ -783,12 +809,11 @@ - continue; - } - - /* RPC depends on having minimal latency so disable the Nagle algorithm */ - val = 1; -- setsockopt(sock, SOL_TCP, TCP_NODELAY, &val, sizeof(val)); -- fcntl(sock, F_SETFL, O_NONBLOCK); /* make socket nonblocking */ -+ setsockopt(sock, SOL_TCP, TCP_NODELAY, (char *)&val, sizeof(val)); - - tcpc->sock = sock; - - freeaddrinfo(ai); - TRACE("connected\n"); -@@ -806,10 +831,11 @@ - int sock; - int ret; - struct addrinfo *ai; - struct addrinfo *ai_cur; - struct addrinfo hints; -+ u_long blocking; - RpcConnection *first_connection = NULL; - - TRACE("(%p, %s)\n", protseq, endpoint); - - hints.ai_flags = AI_PASSIVE /* for non-localhost addresses */; -@@ -857,11 +883,11 @@ - ret = bind(sock, ai_cur->ai_addr, ai_cur->ai_addrlen); - if (ret < 0) - { - WARN("bind failed: %s\n", strerror(errno)); - close(sock); -- if (errno == EADDRINUSE) -+ if (errno == WSAEADDRINUSE) - status = RPC_S_DUPLICATE_ENDPOINT; - else - status = RPC_S_CANT_CREATE_ENDPOINT; - continue; - } -@@ -886,11 +912,12 @@ - } - /* need a non-blocking socket, otherwise accept() has a potential - * race-condition (poll() says it is readable, connection drops, - * and accept() blocks until the next connection comes...) - */ -- ret = fcntl(sock, F_SETFL, O_NONBLOCK); -+ blocking = 1; -+ ret = ioctlsocket(sock, FIONBIO, &blocking); - if (ret < 0) - { - WARN("couldn't make socket non-blocking, error %d\n", ret); - RPCRT4_DestroyConnection(&tcpc->common); - status = RPC_S_OUT_OF_RESOURCES; -@@ -929,10 +956,11 @@ - static RPC_STATUS rpcrt4_conn_tcp_handoff(RpcConnection *old_conn, RpcConnection *new_conn) - { - int ret; - struct sockaddr_in address; - socklen_t addrsize; -+ u_long blocking; - RpcConnection_tcp *server = (RpcConnection_tcp*) old_conn; - RpcConnection_tcp *client = (RpcConnection_tcp*) new_conn; - - addrsize = sizeof(address); - ret = accept(server->sock, (struct sockaddr*) &address, &addrsize); -@@ -940,11 +968,12 @@ - { - ERR("Failed to accept a TCP connection: error %d\n", ret); - return RPC_S_OUT_OF_RESOURCES; - } - /* reset to blocking behaviour */ -- fcntl(ret, F_SETFL, 0); -+ blocking = 0; -+ ret = ioctlsocket(ret, FIONBIO, &blocking); - client->sock = ret; - TRACE("Accepted a new TCP connection\n"); - return RPC_S_OK; - } - -@@ -1187,14 +1216,16 @@ - { - RpcServerProtseq_sock *ps = HeapAlloc(GetProcessHeap(), 0, sizeof(*ps)); - if (ps) - { - int fds[2]; -+ u_long blocking; - if (!socketpair(PF_UNIX, SOCK_DGRAM, 0, fds)) - { -- fcntl(fds[0], F_SETFL, O_NONBLOCK); -- fcntl(fds[1], F_SETFL, O_NONBLOCK); -+ blocking = 1; -+ ioctlsocket(fds[0], FIONBIO, &blocking); -+ ioctlsocket(fds[1], FIONBIO, &blocking); - ps->mgr_event_rcv = fds[0]; - ps->mgr_event_snd = fds[1]; - } - else - {

2 1

Re: [ros-dev] [ros-diffs] [jimtabor] 37223: - Fix WidenPath. Now Area.exe runs and crashes when using real hardware. That is a good thing. We now know our Xorg based region code has problems. It allocates all the memory building PolyPolygon region da
by James Tabor 07 Nov '08

07 Nov '08

Hi, LOL, Wine code does not work at all.... I tested Area.exe with the latest head and it dies and the application continues to work with out drawing the PATH figures. ReactOS: (subsystems/win32/win32k/objects/gdiobj.c:544) Object->cExclusiveLock = 1 (subsystems/win32/win32k/objects/path.c:1911) BeginPath 1 0xbc07024b (subsystems/win32/win32k/objects/path.c:1936) BeginPath 2 h 0xbd07024b p 0x8d9b4830 (subsystems/win32/win32k/objects/path.c:2022) EndPath 0xbd07024b (ntoskrnl/mm/rpoolmgr.h:820) Trying to allocate 8192 bytes from paged pool - nothing suitable found, returning NULL (subsystems/win32/win32k/objects/path.c:1609) Should never happen (subsystems/win32/win32k/objects/path.c:1609) Should never happen (subsystems/win32/win32k/objects/path.c:1609) Should never happen (subsystems/win32/win32k/objects/path.c:1609) Should never happen (subsystems/win32/win32k/objects/path.c:1609) Should never happen (subsystems/win32/win32k/objects/path.c:1612) Got path flag (ntoskrnl/mm/rpoolmgr.h:820) Trying to allocate 4096 bytes from paged pool - nothing suitable found, returning NULL <snip> (ntoskrnl/mm/rpoolmgr.h:820) Trying to allocate 11264 bytes from paged pool - nothing suitable found, returning NULL (subsystems/win32/win32k/objects/gdiobj.c:544) Object->cExclusiveLock = 1 (subsystems/win32/win32k/objects/path.c:1911) BeginPath 1 0xbd07024b (subsystems/win32/win32k/objects/path.c:1936) BeginPath 2 h 0xbe07024b p 0x8d9b4830 (subsystems/win32/win32k/objects/path.c:2022) EndPath 0xbe07024b (ntoskrnl/mm/rpoolmgr.h:820) Trying to allocate 2048 bytes from paged pool - nothing suitable found, returning NULL <snip> (ntoskrnl/mm/rpoolmgr.h:820) Trying to allocate 2400 bytes from paged pool - nothing suitable found, returning NULL Entered debugger on last-chance exception (Exception Code: 0xc0000005) (Page Fault) Memory at 0x000004B0 could not be written: Page not present. kdb:> bt Eip: <win32k.sys:84c9c (subsystems/win32/win32k/objects/bezier.c:160 (GDI_InternalBezier@20))> Frames: <win32k.sys:84dfd (subsystems/win32/win32k/objects/bezier.c:178 (GDI_InternalBezier@20))> <win32k.sys:84deb (subsystems/win32/win32k/objects/bezier.c:178 (GDI_InternalBezier@20))> <win32k.sys:84dfd (subsystems/win32/win32k/objects/bezier.c:178 (GDI_InternalBezier@20))> <win32k.sys:84deb (subsystems/win32/win32k/objects/bezier.c:178 (GDI_InternalBezier@20))> <win32k.sys:84dfd (subsystems/win32/win32k/objects/bezier.c:178 (GDI_InternalBezier@20))> <win32k.sys:84deb (subsystems/win32/win32k/objects/bezier.c:178 (GDI_InternalBezier@20))> <win32k.sys:84deb (subsystems/win32/win32k/objects/bezier.c:178 (GDI_InternalBezier@20))> <win32k.sys:84dfd (subsystems/win32/win32k/objects/bezier.c:178 (GDI_InternalBezier@20))> <win32k.sys:85008 (subsystems/win32/win32k/objects/bezier.c:216 (@GDI_Bezier@12))> <win32k.sys:a1760 (subsystems/win32/win32k/objects/path.c:988 (@PATH_AddFlatBezier@12))> <win32k.sys:a286a (subsystems/win32/win32k/objects/path.c:1019 (@PATH_FlattenPath@4))> <win32k.sys:a295e (subsystems/win32/win32k/objects/path.c:1514 (NtGdiWidenPath@4))> <NTOSKRNL.EXE:a145a (ntoskrnl/ke/i386/trap.s:244 (KiFastCallEntry))> <ntdll.dll:5f1e> <Area.exe:35ad> <04ec8353> Couldn't access memory at 0x56E58959! kdb:> The problem is in IntCreatePolyPolygonRgn, it is based on Xorg mipolygen.c. The figure is some what complex and this old Xorg code seems to become over whelmed by it. IntCreatePolyPolygonRgn calles REGION_InsertionSort hundreds or even thousands of times. Using Qemu you will sit there all night and that is the reason for using hardware for this test. The first figure was 3 polygons with a total of 516 points. Question is, why is that so hard to map and sort? I assume the next three figures have the same or close to the same amount of points. Since they do look and draw about the same. The bug report has GDI_InternalBezier faulting out the kernel, well since there is no more PagedPool available so it returned a NULL without faulting. I'm looking into alternative methods that are much simpler than the Xorg code for mapping and filling regions. My best one is from Graphapp, it is a modified variation of the same Xorgs poly code. This means more time I do not have to work out a hypothesise and rewrite all of the region code. FYI: Our Xorg code is the same Xorg code that is in wine....... I assume wine code breaks and bombs out when the memory pool empties. Which is not avalid excuse not to draw. Thanks, James On Thu, Nov 6, 2008 at 7:05 AM, Aleksey Bragin <aleksey(a)reactos.org> wrote: > How does this code work in Wine without this change? > > WBR, > Aleksey. >

1 0

Re: [ros-dev] [ros-diffs] [jimtabor] 37223: - Fix WidenPath. Now Area.exe runs and crashes when using real hardware. That is a good thing. We now know our Xorg based region code has problems. It allocates all the memory building PolyPolygon region data.
by Aleksey Bragin 06 Nov '08

06 Nov '08

How does this code work in Wine without this change? WBR, Aleksey. On Nov 6, 2008, at 2:55 PM, jimtabor(a)svn.reactos.org wrote: > Author: jimtabor > Date: Thu Nov 6 05:55:08 2008 > New Revision: 37223 > > URL: http://svn.reactos.org/svn/reactos?rev=37223&view=rev > Log: > - Fix WidenPath. Now Area.exe runs and crashes when using real > hardware. That is a good thing. We now know our Xorg based region > code has problems. It allocates all the memory building PolyPolygon > region data.

1 0

rewrite NtGdiPolyPolyDraw,
by James Tabor 06 Nov '08

06 Nov '08

Hi, This change broke GDI Path support..... http://svn.reactos.org/svn/reactos?view=rev&revision=36686

2 2

Small update on my activities
by Maya Posch 04 Nov '08

04 Nov '08

Hi guys, After a lot of requests from people in ReactOS, I have decided to continue my work on USB support, the new bootloader and eventually Firewire and audio support. Making use of the freedom within the project I'll use my own, fully spec'ed and documented working methods, attract devs to work for me when I deem necessary and rally for donations for a speedy completion of those tasks. Since there's no roadmap or central goals I'll also set those for myself and my team(s). I'll provide regular updates on all activities inside those projects on an as of yet unknown location (ReactOS wiki?) and use a central repository for all documentation and specification produced by these projects. Maya

2 1

Share Memory Issue
by James Tabor 03 Nov '08

03 Nov '08

Hi all, Fixing GetDeviceCaps exposed a thread process shared memory issue with WinLogon and Gimp.... Gimp bug, been around and the crash does not make sense until you see where the fault was located. Where? In client thread share memory. So, we need help and soon I will revert the hack in GetDeviceCaps. Maybe we are not passing everything to User32 that is needed. Thanks, James

2 3

Regarding documentation and attracting new developers
by Maya Posch 31 Oct '08

31 Oct '08

Gentlemen, If you don't mind me intruding, I'd like to propose some things I think may ease life for us poor ROS devs, existing and new ones :) First of all, I'd like to suggest 'apprenticeship programming', also known by other names, but which commonly involves having one seasoned programmer in charge of a particular (sub-)project and one or more programmers following his lead. These latter programmers would be less experienced but could work on relatively advanced stuff due to the lead of the seasoned programmer. This model is commonly used in companies already and if adapted for ROS it should make it much easier for 'newbie' devs to get started, pick up experience and become seasoned devs themselves. My own experience with picking up the USB subproject reflect this as well. It's hard to get started without much of a lead, especially when one's experience with the NT subsystems is limited. This is also where documentation would have helped, bringing me to my second point: Whenever I start a new project or implementation I first write a technical specification detailing the exact layout, APIs and implementation. I've heard that this is common practice in professional programming as well as other areas. Benefits include having a good overview of the project before one starts on it, being able to pick out obvious oversights before writing a single line of code, having a central place of reference (code does _not_ work for this), allows one to quickly pick up on things during maintenance sessions (many months later...). It'd also enable the apprentice programming system and make it easy for the central project leader(s) to get an overview of the progress being made. Documentation and specifications are often ignored by programmers because they're not deemed 'time-efficient', preferring to start programming right away instead. In my experience and those of everyone in high-level jobs involving anything from programming to hardware design (like my housemate who is a senior engineer in a Dutch company which designs chips for the telecom industry), specifications and documentation are the lifeblood of any project. I have elected to use both the apprentice method as well as the documentation approach in my work on the new installer, bootloader and USB stack for ReactOS, attracting two relatively inexperienced but highly motivated devs for the installer (RI2, or ROSE) project already. They have expressed interest in helping me with further projects in ROS as well, even more low-level things. I think that this is a good example of the future ROS should be heading towards. So yeah, that's my rant I guess :) *ducks and runs for cover* Maya Posch

12 28

Re: [ros-dev] [ros-diffs] [janderwald] 37110: - Add Documentation for netshell
by Aleksey Bragin 31 Oct '08

31 Oct '08

You're obliged to keep it up-to-date now :-), so it doesn't become like VFAT "documentation". On Oct 31, 2008, at 2:26 PM, janderwald(a)svn.reactos.org wrote: > Author: janderwald > Date: Fri Oct 31 06:26:23 2008 > New Revision: 37110 > > URL: http://svn.reactos.org/svn/reactos?rev=37110&view=rev > Log: > - Add Documentation for netshell > > Added: > trunk/reactos/dll/win32/netshell/README (with props)

1 0

Re: [ros-dev] [ros-diffs] [cfinck] 37104: Hack: Copy the toolbar image on our own instead of using CopyImage to hackfix the messed up toolbar graphics as it was done for previous releases.
by Aleksey Bragin 31 Oct '08

31 Oct '08

I thought this one was fixed? WBR, Aleksey. On Oct 30, 2008, at 9:15 PM, cfinck(a)svn.reactos.org wrote: > Author: cfinck > Date: Thu Oct 30 13:15:00 2008 > New Revision: 37104 > > URL: http://svn.reactos.org/svn/reactos?rev=37104&view=rev > Log: > Hack: Copy the toolbar image on our own instead of using CopyImage > to hackfix the messed up toolbar graphics as it was done for > previous releases. > > Modified: > branches/ros-branch-0_3_7/reactos/dll/win32/comctl32/toolbar.c > > Modified: branches/ros-branch-0_3_7/reactos/dll/win32/comctl32/ > toolbar.c > URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_7/ > reactos/dll/win32/comctl32/toolbar.c? > rev=37104&r1=37103&r2=37104&view=diff > ====================================================================== > ======== > --- branches/ros-branch-0_3_7/reactos/dll/win32/comctl32/toolbar.c > [iso-8859-1] (original) > +++ branches/ros-branch-0_3_7/reactos/dll/win32/comctl32/toolbar.c > [iso-8859-1] Thu Oct 30 13:15:00 2008 > @@ -2665,7 +2665,33 @@ > TRACE("adding hInst=%p nID=%d nButtons=%d\n", bitmap->hInst, > bitmap->nID, bitmap->nButtons); > /* Add bitmaps to the default image list */ > if (bitmap->hInst == NULL) /* a handle was passed */ > - hbmLoad = (HBITMAP)CopyImage(ULongToHandle(bitmap->nID), > IMAGE_BITMAP, 0, 0, 0); > + { > + BITMAP bmp; > + HBITMAP hOldBitmapBitmap, hOldBitmapLoad; > + HDC hdcImage, hdcBitmap; > + > + /* copy the bitmap before adding it so that the user's bitmap > + * doesn't get modified. > + */ > + GetObjectW ((HBITMAP)bitmap->nID, sizeof(BITMAP), (LPVOID) > &bmp); > + > + hdcImage = CreateCompatibleDC(0); > + hdcBitmap = CreateCompatibleDC(0); > + > + /* create new bitmap */ > + hbmLoad = CreateBitmap (bmp.bmWidth, bmp.bmHeight, > bmp.bmPlanes, bmp.bmBitsPixel, NULL); > + hOldBitmapBitmap = SelectObject(hdcBitmap, (HBITMAP)bitmap- > >nID); > + hOldBitmapLoad = SelectObject(hdcImage, hbmLoad); > + > + /* Copy the user's image */ > + BitBlt (hdcImage, 0, 0, bmp.bmWidth, bmp.bmHeight, > + hdcBitmap, 0, 0, SRCCOPY); > + > + SelectObject (hdcImage, hOldBitmapLoad); > + SelectObject (hdcBitmap, hOldBitmapBitmap); > + DeleteDC (hdcImage); > + DeleteDC (hdcBitmap); > + } > else > hbmLoad = CreateMappedBitmap(bitmap->hInst, bitmap->nID, > 0, NULL, 0); > >

2 1

Re: [ros-dev] [ros-diffs] [hyperion] 37054: deleted wine/mmsystem.h deleted wine/prsht.h deleted wine/winbase.h deleted wine/winnetwk.h deleted wine/winnt.h deleted wine/winuser.h Our SDK is in good enough shape to compile Wine: drop the #include_next hacks Wi
by Steven Edwards 31 Oct '08

31 Oct '08

On Wed, Oct 29, 2008 at 9:19 AM, <hyperion(a)svn.reactos.org> wrote: > Author: hyperion > Date: Wed Oct 29 08:19:21 2008 > New Revision: 37054 > > URL: http://svn.reactos.org/svn/reactos?rev=37054&view=rev > Log: > deleted wine/mmsystem.h > deleted wine/prsht.h > deleted wine/winbase.h > deleted wine/winnetwk.h > deleted wine/winnt.h > deleted wine/winuser.h > Our SDK is in good enough shape to compile Wine: drop the #include_next hacks > Wine compatibility fixes should go either in the SDK headers themselves or in the Wine porting SDK This is a little late but I wanted to let you know that I love you and want to bear your children! -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [ros-dev] [ros-diffs] [jimtabor] 37099: Implement GetFontUnicodeRanges, port from wine. Tested with wine gdi32 font crosstests.
by Steven Edwards 30 Oct '08

30 Oct '08

Hello, On Thu, Oct 30, 2008 at 9:33 AM, <jimtabor(a)svn.reactos.org> wrote: > URL: http://svn.reactos.org/svn/reactos?rev=37099&view=rev > Log: > Implement GetFontUnicodeRanges, port from wine. Tested with wine gdi32 font crosstests. If your using enough of the original implementation to credit Wine then to me that means someone else at least partly own copyright to these functions. Could you please use git blame or git web and see who the author was of the original implementation from Wine and credit them appropriately in the header? From time to time when someone says 'foo from wine' I get pinged from wine developers who's code is appropriated and they ask for proper attribution. If we don't do it right the first time, then at some point another audit of each commit from SVN will have to happen and we will have to go back and add those copyright holders to the files license header. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 3

generic graphics
by Matthias Kupfer 30 Oct '08

30 Oct '08

Hello, I would like to create a /media/graphics directory in trunk to store the template files for graphics we want to use in altered versions or different resolutions. I start with the replacement for the explorere shutdown icon and a question mark for message dialogs. Due to problems with drawing this icons at the moment I store the templates only, later we can create the icons from the templates and include in the resource files. I suggest to store all selfmade graphics (in alterable formats, e.g. svg) in this directory (if there is no other source). What do you think about the change of the message dialogs icons to the tango project icons and the question mark icon i provide, instead of the current icon set? Matthias -- Matthias Kupfer Telefon +49 (0) 371 236 46 52 Wilhelm-Firl-Straße 21 Mobil +49 (0) 160 859 43 54 09122 Chemnitz

1 0

Trunk freeze
by Aleksey Bragin 29 Oct '08

29 Oct '08

Hello, trunk has been frozen until 0.3.7 blockers are fixed. Bugfix team having commit access for this freeze: Colin, Herve, Johannes, me. With the best regards, Aleksey Bragin.

1 1

Win32k Foating Point
by James Tabor 28 Oct '08

28 Oct '08

Hi, I've tooled up libm from http://www.netlib.org/fdlibm/ and a hacked floatlib.c in lib/3rdparty. With -msoft-float added in win32k.rbuild, it works. I built the lib separate on XP mingw build environment and I compiled and ran a fp test program (tst-ieee754.c) than compared the results with standard gcc. The results are almost the same. The thing even boots and draws okay. Floatlib.c is very old and I will soon start testing with SoftFloat to replace the gcc soft float math. So,,,,, is it posiable to build our build environment (RosBE) to support full soft-float? So we can avoid more source in ReactOS..... Well, except libm.a ~ 93k. or,,, Just support the hardware floating point and move on........ Thanks, James

2 2

Re: [ros-dev] [ros-diffs] [janderwald] 37023: - Add PROVIDER_INFO_1 and PROVIDER_INFO_2 struct
by Aleksey Bragin 28 Oct '08

28 Oct '08

Is this providEr or providOr ? On Oct 27, 2008, at 6:16 PM, janderwald(a)svn.reactos.org wrote: > Author: janderwald > Date: Mon Oct 27 10:16:05 2008 > New Revision: 37023 > > URL: http://svn.reactos.org/svn/reactos?rev=37023&view=rev > Log: > - Add PROVIDER_INFO_1 and PROVIDER_INFO_2 struct > > Modified: > trunk/reactos/include/psdk/winspool.h > > Modified: trunk/reactos/include/psdk/winspool.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/ > winspool.h?rev=37023&r1=37022&r2=37023&view=diff > ====================================================================== > ======== > --- trunk/reactos/include/psdk/winspool.h [iso-8859-1] (original) > +++ trunk/reactos/include/psdk/winspool.h [iso-8859-1] Mon Oct 27 > 10:16:05 2008 > @@ -700,6 +700,24 @@ > ACCESS_MASK DesiredAccess; > } PRINTER_DEFAULTSW,*PPRINTER_DEFAULTSW,*LPPRINTER_DEFAULTSW; > > +typedef struct _PROVIDOR_INFO_1A{ > + LPSTR pName; > + LPSTR pEnvironment; > + LPSTR pDLLName; > +} PROVIDOR_INFO_1A, *PPROVIDOR_INFO_1A, *LPPROVIDOR_INFO_1A; > +typedef struct _PROVIDOR_INFO_1W{ > + LPWSTR pName; > + LPWSTR pEnvironment; > + LPWSTR pDLLName; > +} PROVIDOR_INFO_1W, *LPPROVIDOR_INFO_1W; > + > +typedef struct _PROVIDOR_INFO_2A{ > + LPSTR pOrder; > +} PROVIDOR_INFO_2A, *PPROVIDOR_INFO_2A, *LPPROVIDOR_INFO_2A; > +typedef struct _PROVIDOR_INFO_2W{ > + LPWSTR pOrder; > +} PROVIDOR_INFO_2W, *LPPROVIDOR_INFO_2W; > + > BOOL WINAPI AbortPrinter(HANDLE); > BOOL WINAPI AddFormA(HANDLE,DWORD,PBYTE); > BOOL WINAPI AddFormW(HANDLE,DWORD,PBYTE); > @@ -833,6 +851,10 @@ > typedef PRINTPROCESSOR_INFO_1W > PRINTPROCESSOR_INFO_1,*PPRINTPROCESSOR_INFO_1,*LPPRINTPROCESSOR_INFO_1 > ; > typedef FORM_INFO_1W FORM_INFO_1,*PFORM_INFO_1,*LPFORM_INFO_1; > typedef PRINTER_DEFAULTSW > PRINTER_DEFAULTS,*PPRINTER_DEFAULTS,*LPPRINTER_DEFAULTS; > +typedef PROVIDOR_INFO_1W PROVIDOR_INFO_1; > +typedef LPPROVIDOR_INFO_1W LPPROVIDOR_INFO_1; > +typedef PROVIDOR_INFO_2W PROVIDOR_INFO_2; > +typedef LPPROVIDOR_INFO_2W LPPROVIDOR_INFO_2; > #define AddForm AddFormW > #define AddJob AddJobW > #define AddMonitor AddMonitorW >

2 1

[ros-diffs] [dreimer] 36968: ok, Binutils and ccache reverted.
by Dmitry Gorbachev 26 Oct '08

26 Oct '08

Hi! Why not use newer GCC 4.3.2 and Binutils 2.19.50 in RosBE, they seems to work well with only a few changes in ReactOS sources.

4 4

[ros-diffs] [dreimer] 36968: ok, Binutils and ccache reverted.
by Dmitry Gorbachev 26 Oct '08

26 Oct '08

> If the current tree really builds 100% with GCC 4.3.2 or you (or someone > else) could provide patches for getting it to work, the update should be > done as soon as possible (but after 0.3.7 :P) I use GCC 4.3.2 and new binutils for about a month without difficulties; if you need any patches then please email me. Of course, I do not insist on including it in RosBE. Best wishes, Dmitry

1 0

[ros-diffs] [dreimer] 36968: ok, Binutils and ccache reverted.
by Dmitry Gorbachev 26 Oct '08

26 Oct '08

> Because it would fully break the possibility to build older revs. I dont > know if this counts as argument. With such an argument upgrade will never come...

2 1

Re: [ros-dev] [ros-diffs] [dreimer] 36968: ok, Binutils and ccache reverted.
by gedmurphy 26 Oct '08

26 Oct '08

I have to disagree with this binutils revert. If we aren't prepared to keep our tools up to date, then we'll have to resort to dropping RosBE and updating our tools manually. Build tools should _always_ be kept up to date. Ged -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dreimer(a)svn.reactos.org Sent: 25 October 2008 22:39 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dreimer] 36968: ok, Binutils and ccache reverted. Author: dreimer Date: Sat Oct 25 16:39:26 2008 New Revision: 36968 URL: http://svn.reactos.org/svn/reactos?rev=36968&view=rev Log: ok, Binutils and ccache reverted. Modified: trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt trunk/tools/RosBE/RosBE-Windows/RosBE.nsi Modified: trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Cha… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt [iso-8859-1] Sat Oct 25 16:39:26 2008 @@ -5,15 +5,12 @@ - Updated: NSIS to 2.40 (Daniel Reimer) - Updated: Subversion to 1.5.3 (Daniel Reimer) - Updated: GDB to 6.8-3 (Daniel Reimer) -- Updated: Binutils 2.18.50 Build 20080109. (Daniel Reimer) - Updated: MingW32 Make 3.81-3 (Daniel Reimer) - Updated: MingW32 Runtime DLL 3.15.1 (Daniel Reimer) - Other small Fixes here and there (Daniel Reimer) - Added: Basic PowerShell Version of RosBE (Daniel Reimer) - Added: YASM 0.72, which supports 64 bit asm too. (Daniel Reimer) - Added: Update command (Daniel Reimer) -- Added: A way to include rosapps and rostests into the build and ssvn script by modifying - one var. Add this var to options.exe (Maciej Bialas and slight changes by me) - Added: nostrip function (Christoph von Wittich) - Added: RosBE Debugging Feature which disables the @echo off. just set _ROSBE_DEBUG=1 (Daniel Reimer) Modified: trunk/tools/RosBE/RosBE-Windows/RosBE.nsi URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/RosBE.ns… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/RosBE.nsi [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/RosBE.nsi [iso-8859-1] Sat Oct 25 16:39:26 2008 @@ -201,6 +201,7 @@ SetOutPath "$INSTDIR\4.1.3\bin" SetOverwrite try File /r Components\Tools\ccache.exe + File /r Components\Tools\cygwin1.dll SectionEnd Section "GDB - The GNU Project Debugger" SEC07

4 3

Re: [ros-dev] [ros-diffs] [dchapyshev] 36934: - Change SetSysColorsTemp declaration
by Timo Kreuzer 25 Oct '08

25 Oct '08

That function shouldn't even be there. dchapyshev(a)svn.reactos.org schrieb: > Author: dchapyshev > Date: Sat Oct 25 02:39:33 2008 > New Revision: 36934 > > URL: http://svn.reactos.org/svn/reactos?rev=36934&view=rev > Log: > - Change SetSysColorsTemp declaration > > Modified: > trunk/reactos/include/psdk/winuser.h > > Modified: trunk/reactos/include/psdk/winuser.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/winuser.h?rev… > ============================================================================== > --- trunk/reactos/include/psdk/winuser.h [iso-8859-1] (original) > +++ trunk/reactos/include/psdk/winuser.h [iso-8859-1] Sat Oct 25 02:39:33 2008 > @@ -4201,7 +4201,7 @@ > int WINAPI SetScrollPos(HWND,int,int,BOOL); > BOOL WINAPI SetScrollRange(HWND,int,int,int,BOOL); > BOOL WINAPI SetSysColors(int,const INT *,const COLORREF *); > -HANDLE WINAPI SetSysColorsTemp(const COLORREF *, const HBRUSH *, int); > +DWORD WINAPI SetSysColorsTemp(const COLORREF *, const HBRUSH *, DWORD); > #define SetSysModalWindow(h) (NULL) > BOOL WINAPI SetSystemCursor(HCURSOR,DWORD); > BOOL WINAPI SetThreadDesktop(HDESK); > > >

1 0

Re: [ros-dev] [ros-diffs] [hyperion] 36929: modified tools/rbuild/backend/mingw/modulehandler.cpp Allow static libraries to "link" to other static libraries Removed some dead code modified dll/nls/normaliz_redist/normaliz_redist.rbuild modified dll/win32/kernel32/kernel32.rbuild No need to specify icu4ros explicitely anymore, thanks to the rbuild changes Make kernel32_base include normalize, rather than linking it as an external dependency of kernel32
by Aleksey Bragin 25 Oct '08

25 Oct '08

I'd like to bring attention to this change, I think it's a rather interesting one. So now, for example, if you have a static library A which uses something from a few small libraries B, C, D, you don't have to specify in every module that you link with A, B, C and D - you can just specify once that library A always goes with B,C,D and then link only to library A in your modules. WBR, Aleksey Bragin. On Oct 25, 2008, at 6:52 AM, hyperion(a)svn.reactos.org wrote: > Author: hyperion > Date: Fri Oct 24 21:52:24 2008 > New Revision: 36929 > > URL: http://svn.reactos.org/svn/reactos?rev=36929&view=rev > Log: > modified tools/rbuild/backend/mingw/modulehandler.cpp > Allow static libraries to "link" to other static libraries > Removed some dead code > > modified dll/nls/normaliz_redist/normaliz_redist.rbuild > modified dll/win32/kernel32/kernel32.rbuild > No need to specify icu4ros explicitely anymore, thanks to the > rbuild changes > Make kernel32_base include normalize, rather than linking it as > an external dependency of kernel32

1 0

Chemnitz linux days (Chemnitzer Linux Tage)
by Matthias Kupfer 24 Oct '08

24 Oct '08

Hello, I would like to announce, that the call for papers/lectures for the Chemnitz linux days (Chemnitz LinuxTage) has been started some days ago and will end at january 5th 2009. If one of you (or the devs in whole) want to present reactos in any kind (e.g. demonstration, lecture) please let me know. If there is no other developer, I would be glad to present the project instead of you, but i'm interested in more involved developers as well. AFAIK in special cases it's possible to get additional money for travel if necessary, but bear in mind - it's a non-commercial event. For the German(-speaking) developers I recommend the website for the event for more details (sorry, germyn only): http://chemnitzer.linux-tage.de/2009/info/ Comments are very welcome! Matthias P.S. I think such events are well suited for recruiting new developers. -- Matthias Kupfer fon +49 (0) 371 236 46 52 Wilhelm-Firl-Straße 21 mobile +49 (0) 160 859 43 54 09122 Chemnitz -- Matthias Kupfer Telefon +49 (0) 371 236 46 52 Wilhelm-Firl-Straße 21 Mobil +49 (0) 160 859 43 54 09122 Chemnitz

1 0

Re: [ros-dev] [ros-diffs] [sginsberg] 36894: - Notify umpnpmgr about logon after the shell has initialized - This makes it possible to progress if userinit crashes due to heavy debug output (due to timing issues in its communication with umpnpmgr), which would leave you stranded with no shell. Not really a hack, as it doesn't hide or fix the crash -- just limits it to a missing "Pending device installations" prompt in case there are any pending. Also, it appears to be done the same way on Windows.
by Aleksey Bragin 23 Oct '08

23 Oct '08

I would like to hear if this change is agreed with Herve or not, and if not, what's his opinion about it. On Oct 22, 2008, at 5:59 PM, sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Wed Oct 22 08:59:01 2008 > New Revision: 36894 > > URL: http://svn.reactos.org/svn/reactos?rev=36894&view=rev > Log: > - Notify umpnpmgr about logon after the shell has initialized > - This makes it possible to progress if userinit crashes due to > heavy debug output (due to timing issues in its communication with > umpnpmgr), which would leave you stranded with no shell. Not really > a hack, as it doesn't hide or fix the crash -- just limits it to a > missing "Pending device installations" prompt in case there are any > pending. Also, it appears to be done the same way on Windows.

2 2

NtUserCreateWindowEx parameters
by Jeetu Golani 23 Oct '08

23 Oct '08

Hi there, I've been snooping into the internals of Win XP and have setup a win32sys SDT hook on the NtUserCreateWindowEx function. I'd written sometime back to the list stating that the x,y,nWidth and nHeight parameters were showing values I couldn't understand - negative values et al. Since then I realized that this had to do with the fact that the parameter positions in the prototype I was using seemed to be in a different order (discovered a window.c file from this project on koders.com and was using this prototype). I think this could possibly be because maybe the ros team has been looking at a version of windows that isn't XP (possible??)..dunno Anyways the parameter ordering I've deduced seems to be : NtUserCreateWindowEx(DWORD dwExStyle,PUNICODE_STRING UnsafeClassName,PUNICODE_STRING UnsafeWindowName,DWORD dwUnknown1,DWORD dwStyle,LONG x, LONG y,LONG nWidth, LONG nHeight,HWND hWndParent,HMENU,hMenu,HINSTANCE hInstance,LPVOID lpParam,DWORD dwShowMode,DWORD dwUnknown2) This seems to be correct with regards the dwExStyle,dwStyle,x,y,nWidth,nHeight,hWndParent.hMenu,hInstance,lpParam arguments. I'm still not able to verify the rest. My immediate concern though are the UnsafeClassName and UnsafeWindowName arguments. I'm trying to print out these values...or test out what these values hold...but can't seem to get anywhere....don't even know for sure if these are UNICODE_STRING structure vals or LPCTSTR. I'd like to be able to retrieve/interpret the ClassName and WindowName......any help would be appreciated. Bye for now

3 6

Re: [ros-dev] [ros-diffs] [hyperion] 36761: added lib/rtl/rtl-common.rbuild modified lib/rtl/rtl.rbuild Compile rtl twice, as rtl_umode and rtl_kmode. Allows conditional compilation of RTL (finally!), instead of necessitating hacks like RtlpGetMode()
by Alex Ionescu 20 Oct '08

20 Oct '08

"It's like NT does" isn't an advantage... cloning *build methods* of the Core OS Division at Microsoft doesn't do anything positive (nor negative) to the quality and reliability of the code. You have to look at *what* the method involves and analyze that way. Your other argument applies: building RTL multiple times reduces the need for the small support library ReactOS uses and gives one consistent place for RTL code. Disadvantages: - Building RTL up to 4 times, increasing build time substantially (rtl is a pretty big library). - Quadruple-conditional compilation...meaning people will have to test their rtl changes by BUILDING FOUR TIMES with different conditionals. Will people really remember to do this? Will people really write code knowing exactly what do ifdef and where, and how? - To do this right, you'll need a host-rtl too. Have fun writing one. - Right now the commit did only half the work -- now compile time is doubled, but libsupp is still there, making the situation even worse. The commiter made the assumption "other people" will pick up the slack, which probably won't happen, and this will rot forever. Best regards, Alex Ionescu On Wed, Oct 15, 2008 at 2:41 PM, Aleksey Bragin <aleksey(a)reactos.org> wrote: > I knew about this post-factum, so let's gather opinions. > > Advantage: It's like NT does, less hacks, possible removal of libsupp > stuff in ntoskrnl, freeldr, ntdll, etc (which I actually thought > would be done in the same commit). > > Disadvantage: To be proper, you need a bootloader RTL too, otherwise > RTL will still contain "necessitating hacks" aka libsupp stuff. This > is gonna make at least 3x time RTL compilation. (thankfully / sadly > we don't test it directly). > > > WBR, > Aleksey. > > > > On Oct 15, 2008, at 10:02 PM, Alex Ionescu wrote: > >> Well, you just removed the one thing ReactOS did different from NT and >> that I thought was really revolutionary and innovative, because it >> saves on compile time. It's funny, because I've been trying to sell >> this as a better approach to building RTL (It's built at least 4 times >> in the real NT tree, I think -- loader, user-mode tools/testing, >> kernel, user-mode). >> >> Best regards, >> Alex Ionescu > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

2 2

Re : [ros-diffs] [pschweitzer] 36771: Apply fix at the right place.......
by Sylvain Petreolle 17 Oct '08

17 Oct '08

Good old patch seems ok to me. Kind regards, Sylvain Petreolle Support artists, not multinationals - http://Iwouldntsteal.net Supportez les artistes, pas les multinationales - http://Iwouldntsteal.net ----- Message d'origine ---- > De : Pierre SCHWEITZER <heis_spiter(a)hotmail.com> > À : ReactOS Development List <ros-dev(a)reactos.org> > Envoyé le : Vendredi, 17 Octobre 2008, 14h37mn 51s > Objet : Re: [ros-dev] [ros-diffs] [pschweitzer] 36771: Apply fix at the right place....... > > > Shamefully, yes. > I didn't find good programme to do it under Linux. Speaking of that, if someone > using Linux could give me some pieces of advice about GUI svn clients under > Linux, I would be glad :). > TIA, > Pierre > ---------------------------------------- > > From: aleksey(a)reactos.org > > Date: Fri, 17 Oct 2008 10:44:46 +0400 > > To: ros-dev(a)reactos.org > > Subject: Re: [ros-dev] [ros-diffs] [pschweitzer] 36771: Apply fix at the > right place....... > > > > Are you merging manually? > > > > On Oct 16, 2008, at 10:21 PM, pschweitzer(a)svn.reactos.org wrote: > > > >> Author: pschweitzer > >> Date: Thu Oct 16 13:21:05 2008 > >> New Revision: 36771 > >> > >> URL: http://svn.reactos.org/svn/reactos?rev=36771&view=rev > >> Log: > >> Apply fix at the right place....... > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > _________________________________________________________________ > Inédit ! Des Emoticônes Déjantées! Installez les dans votre Messenger ! > http://www.ilovemessenger.fr/Emoticones/EmoticonesDejantees.aspx > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev

1 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 36771: Apply fix at the right place.......
by Aleksey Bragin 17 Oct '08

17 Oct '08

Are you merging manually? On Oct 16, 2008, at 10:21 PM, pschweitzer(a)svn.reactos.org wrote: > Author: pschweitzer > Date: Thu Oct 16 13:21:05 2008 > New Revision: 36771 > > URL: http://svn.reactos.org/svn/reactos?rev=36771&view=rev > Log: > Apply fix at the right place.......

4 4

Re: [ros-dev] [ros-diffs] [sginsberg] 36773: - Unbreak GetTextFaceA/W, broken since 28730 by GreatLord
by gedmurphy 17 Oct '08

17 Oct '08

Why do you need to publically state it was broken and who broke it? Does it make you feel more important and help to boost your ego? -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of sginsberg(a)svn.reactos.org Sent: 16 October 2008 21:02 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [sginsberg] 36773: - Unbreak GetTextFaceA/W, broken since 28730 by GreatLord Author: sginsberg Date: Thu Oct 16 15:02:22 2008 New Revision: 36773 URL: http://svn.reactos.org/svn/reactos?rev=36773&view=rev Log: - Unbreak GetTextFaceA/W, broken since 28730 by GreatLord Modified: trunk/reactos/dll/win32/gdi32/objects/text.c Modified: trunk/reactos/dll/win32/gdi32/objects/text.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/gdi32/objects/te… ============================================================================== --- trunk/reactos/dll/win32/gdi32/objects/text.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/gdi32/objects/text.c [iso-8859-1] Thu Oct 16 15:02:22 2008 @@ -358,20 +358,24 @@ * @implemented */ INT -STDCALL +WINAPI GetTextFaceW(HDC hDC, - int nCount, - LPWSTR lpFaceName) -{ - INT retValue = 0; - if ((!lpFaceName) || (nCount)) - { - retValue = NtGdiGetTextFaceW(hDC,nCount,lpFaceName,0); + INT nCount, + PWSTR pFaceName) +{ + INT retValue; + + if ((pFaceName && nCount) || + !(pFaceName && nCount)) + { + retValue = NtGdiGetTextFaceW(hDC, nCount, pFaceName, 0); } else { SetLastError(ERROR_INVALID_PARAMETER); - } + retValue = 0; + } + return retValue; }

7 8

36773: - Unbreak GetTextFaceA/W, broken since 28730 by GreatLord
by Sylvain Petreolle 17 Oct '08

17 Oct '08

Isnt that condition always true ? + if ((pFaceName && nCount) || + !(pFaceName && nCount)) Kind regards, Sylvain Petreolle Support artists, not multinationals - http://Iwouldntsteal.net Supportez les artistes, pas les multinationales - http://Iwouldntsteal.net

2 1

Re: [ros-dev] [ros-diffs] [janderwald] 36762: - Implement Advanced Status IP Information Dialog - Import language strings from netcfgx - Add icon group (32x32) - ncpa is now a candidate for deletion
by gedmurphy 16 Oct '08

16 Oct '08

Well, we can't actually delete ncpa, it just needs to be rewritten to use the netshell library instead. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of janderwald(a)svn.reactos.org Sent: 15 October 2008 18:21 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [janderwald] 36762: - Implement Advanced Status IP Information Dialog - Import language strings from netcfgx - Add icon group (32x32) - ncpa is now a candidate for deletion - ncpa is now a candidate for deletion

1 0

Re: [ros-dev] [ros-diffs] [hyperion] 36761: added lib/rtl/rtl-common.rbuild modified lib/rtl/rtl.rbuild Compile rtl twice, as rtl_umode and rtl_kmode. Allows conditional compilation of RTL (finally!), instead of necessitating hacks like RtlpGetMode() "rtl" mod
by Alex Ionescu 15 Oct '08

15 Oct '08

Well, you just removed the one thing ReactOS did different from NT and that I thought was really revolutionary and innovative, because it saves on compile time. It's funny, because I've been trying to sell this as a better approach to building RTL (It's built at least 4 times in the real NT tree, I think -- loader, user-mode tools/testing, kernel, user-mode). Best regards, Alex Ionescu On Wed, Oct 15, 2008 at 11:45 AM, <hyperion(a)svn.reactos.org> wrote: > Author: hyperion > Date: Wed Oct 15 10:45:11 2008 > New Revision: 36761 > > URL: http://svn.reactos.org/svn/reactos?rev=36761&view=rev > Log: > added lib/rtl/rtl-common.rbuild > modified lib/rtl/rtl.rbuild > Compile rtl twice, as rtl_umode and rtl_kmode. Allows conditional compilation of RTL (finally!), instead of necessitating hacks like RtlpGetMode() > "rtl" module now a dummy static library for things like <include base="rtl"> > > modified boot/freeldr/freeldr/freeldr.rbuild > modified boot/freeldr/freeldr/setupldr.rbuild > modified ntoskrnl/ntoskrnl-generic.rbuild > rtl -> rtl_kmode > > modified dll/ntdll/ntdll.rbuild > rtl -> rtl_umode > > This commit dedicated to Fireball and Stefan100 (now get to work! >:3) > > Added: > trunk/reactos/lib/rtl/rtl-common.rbuild (with props) > Modified: > trunk/reactos/boot/freeldr/freeldr/freeldr.rbuild > trunk/reactos/boot/freeldr/freeldr/setupldr.rbuild > trunk/reactos/dll/ntdll/ntdll.rbuild > trunk/reactos/lib/rtl/rtl.rbuild > trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild > > Modified: trunk/reactos/boot/freeldr/freeldr/freeldr.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/freel… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/freeldr.rbuild [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/freeldr.rbuild [iso-8859-1] Wed Oct 15 10:45:11 2008 > @@ -11,7 +11,7 @@ > <library>freeldr_main</library> > <library>rossym</library> > <library>cmlib</library> > - <library>rtl</library> > + <library>rtl_kmode</library> > <library>libcntpr</library> > <linkerflag>-static</linkerflag> > <linkerflag>-lgcc</linkerflag> > > Modified: trunk/reactos/boot/freeldr/freeldr/setupldr.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/setup… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/setupldr.rbuild [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/setupldr.rbuild [iso-8859-1] Wed Oct 15 10:45:11 2008 > @@ -9,7 +9,7 @@ > <library>setupldr_main</library> > <library>rossym</library> > <library>cmlib</library> > - <library>rtl</library> > + <library>rtl_kmode</library> > <library>libcntpr</library> > <linkerflag>-nostartfiles</linkerflag> > <linkerflag>-nostdlib</linkerflag> > > Modified: trunk/reactos/dll/ntdll/ntdll.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ntdll.rbuild?rev… > ============================================================================== > --- trunk/reactos/dll/ntdll/ntdll.rbuild [iso-8859-1] (original) > +++ trunk/reactos/dll/ntdll/ntdll.rbuild [iso-8859-1] Wed Oct 15 10:45:11 2008 > @@ -12,7 +12,7 @@ > <define name="_WIN32_WINNT">0x0502</define> > <define name="_NTOSKRNL_" /> > <define name="__NO_CTYPE_INLINES" /> > - <library>rtl</library> > + <library>rtl_umode</library> > <library>ntdllsys</library> > <library>libcntpr</library> > <library>pseh</library> > > Added: trunk/reactos/lib/rtl/rtl-common.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/rtl-common.rbuild?… > ============================================================================== > --- trunk/reactos/lib/rtl/rtl-common.rbuild (added) > +++ trunk/reactos/lib/rtl/rtl-common.rbuild [iso-8859-1] Wed Oct 15 10:45:11 2008 > @@ -1,0 +1,98 @@ > +<?xml version="1.0"?> > + > +<include base="rtl">.</include> > +<define name="_NTOSKRNL_" /> > +<define name="__NO_CTYPE_INLINES" /> > +<define name="NO_RTL_INLINES" /> > +<define name="_NTSYSTEM_" /> > +<define name="_NTDLLBUILD_" /> > +<if property="ARCH" value="i386"> > + <directory name="i386"> > + <file>debug_asm.S</file> > + <file>except_asm.s</file> > + <file>except.c</file> > + <file>random_asm.S</file> > + <file>rtlswap.S</file> > + <file>rtlmem.s</file> > + <file>res_asm.s</file> > + <file>thread.c</file> > + </directory> > +</if> > +<if property="ARCH" value="powerpc"> > +<directory name="powerpc"> > + <file>debug.c</file> > + <file>except.c</file> > + <file>interlocked.c</file> > + <file>rtlmem.s</file> > + <file>rtlswap.s</file> > + <file>thread.c</file> > +</directory> > +</if> > +<if property="ARCH" value="arm"> > + <directory name="arm"> > + <file>debug_asm.S</file> > + </directory> > + <file>mem.c</file> > + <file>memgen.c</file> > +</if> > +<directory name="austin"> > + <file>avl.c</file> > + <file>tree.c</file> > +</directory> > + > +<file>access.c</file> > +<file>acl.c</file> > +<file>actctx.c</file> > +<file>atom.c</file> > +<file>bitmap.c</file> > +<file>bootdata.c</file> > +<file>compress.c</file> > +<file>condvar.c</file> > +<file>crc32.c</file> > +<file>critical.c</file> > +<file>dbgbuffer.c</file> > +<file>debug.c</file> > +<file>dos8dot3.c</file> > +<file>encode.c</file> > +<file>env.c</file> > +<file>error.c</file> > +<file>exception.c</file> > +<file>generictable.c</file> > +<file>handle.c</file> > +<file>heap.c</file> > +<file>image.c</file> > +<file>interlck.c</file> > +<file>message.c</file> > +<file>largeint.c</file> > +<file>luid.c</file> > +<file>network.c</file> > +<file>nls.c</file> > +<file>path.c</file> > +<file>ppb.c</file> > +<file>process.c</file> > +<file>propvar.c</file> > +<file>qsort.c</file> > +<file>random.c</file> > +<file>rangelist.c</file> > +<file>registry.c</file> > +<file>res.c</file> > +<file>resource.c</file> > +<file>sd.c</file> > +<file>security.c</file> > +<file>slist.c</file> > +<file>sid.c</file> > +<file>sprintf.c</file> > +<file>srw.c</file> > +<file>swprintf.c</file> > +<file>splaytree.c</file> > +<file>thread.c</file> > +<file>time.c</file> > +<file>timezone.c</file> > +<file>timerqueue.c</file> > +<file>unicode.c</file> > +<file>unicodeprefix.c</file> > +<file>vectoreh.c</file> > +<file>version.c</file> > +<file>wait.c</file> > +<file>workitem.c</file> > +<pch>rtl.h</pch> > > Propchange: trunk/reactos/lib/rtl/rtl-common.rbuild > ------------------------------------------------------------------------------ > svn:eol-style = native > > Modified: trunk/reactos/lib/rtl/rtl.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/rtl.rbuild?rev=367… > ============================================================================== > --- trunk/reactos/lib/rtl/rtl.rbuild [iso-8859-1] (original) > +++ trunk/reactos/lib/rtl/rtl.rbuild [iso-8859-1] Wed Oct 15 10:45:11 2008 > @@ -1,100 +1,15 @@ > <?xml version="1.0"?> > <!DOCTYPE module SYSTEM "../../tools/rbuild/project.dtd"> > -<module name="rtl" type="staticlibrary"> > - <define name="_NTOSKRNL_" /> > - <define name="__NO_CTYPE_INLINES" /> > - <define name="NO_RTL_INLINES" /> > - <define name="_NTSYSTEM_" /> > - <define name="_NTDLLBUILD_" /> > - <include base="rtl">.</include> > - <if property="ARCH" value="i386"> > - <directory name="i386"> > - <file>debug_asm.S</file> > - <file>except_asm.s</file> > - <file>except.c</file> > - <file>random_asm.S</file> > - <file>rtlswap.S</file> > - <file>rtlmem.s</file> > - <file>res_asm.s</file> > - <file>thread.c</file> > - </directory> > - </if> > - <if property="ARCH" value="powerpc"> > - <directory name="powerpc"> > - <file>debug.c</file> > - <file>except.c</file> > - <file>interlocked.c</file> > - <file>rtlmem.s</file> > - <file>rtlswap.s</file> > - <file>thread.c</file> > - </directory> > - </if> > - <if property="ARCH" value="arm"> > - <directory name="arm"> > - <file>debug_asm.S</file> > - </directory> > - <file>mem.c</file> > - <file>memgen.c</file> > - </if> > - <directory name="austin"> > - <file>avl.c</file> > - <file>tree.c</file> > - </directory> > > - <file>access.c</file> > - <file>acl.c</file> > - <file>actctx.c</file> > - <file>atom.c</file> > - <file>bitmap.c</file> > - <file>bootdata.c</file> > - <file>compress.c</file> > - <file>condvar.c</file> > - <file>crc32.c</file> > - <file>critical.c</file> > - <file>dbgbuffer.c</file> > - <file>debug.c</file> > - <file>dos8dot3.c</file> > - <file>encode.c</file> > - <file>env.c</file> > - <file>error.c</file> > - <file>exception.c</file> > - <file>generictable.c</file> > - <file>handle.c</file> > - <file>heap.c</file> > - <file>image.c</file> > - <file>interlck.c</file> > - <file>message.c</file> > - <file>largeint.c</file> > - <file>luid.c</file> > - <file>network.c</file> > - <file>nls.c</file> > - <file>path.c</file> > - <file>ppb.c</file> > - <file>process.c</file> > - <file>propvar.c</file> > - <file>qsort.c</file> > - <file>random.c</file> > - <file>rangelist.c</file> > - <file>registry.c</file> > - <file>res.c</file> > - <file>resource.c</file> > - <file>sd.c</file> > - <file>security.c</file> > - <file>slist.c</file> > - <file>sid.c</file> > - <file>sprintf.c</file> > - <file>srw.c</file> > - <file>swprintf.c</file> > - <file>splaytree.c</file> > - <file>thread.c</file> > - <file>time.c</file> > - <file>timezone.c</file> > - <file>timerqueue.c</file> > - <file>unicode.c</file> > - <file>unicodeprefix.c</file> > - <file>vectoreh.c</file> > - <file>version.c</file> > - <file>wait.c</file> > - <file>workitem.c</file> > - <pch>rtl.h</pch> > -</module> > +<group xmlns:xi="http://www.w3.org/2001/XInclude"> > + <module name="rtl_umode" type="staticlibrary"> > + <xi:include href="rtl-common.rbuild" /> > + </module> > + > + <module name="rtl_kmode" type="staticlibrary"> > + <xi:include href="rtl-common.rbuild" /> > + </module> > + > +  > + <module name="rtl" type="staticlibrary" /> > +</group> > > Modified: trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ntoskrnl-generic.… > ============================================================================== > --- trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild [iso-8859-1] Wed Oct 15 10:45:11 2008 > @@ -26,7 +26,7 @@ > <library>hal</library> > <library>pseh</library> > <library>cmlib</library> > - <library>rtl</library> > + <library>rtl_kmode</library> > <library>rossym</library> > <library>libcntpr</library> > <library>kdcom</library> > >

4 4

Re: [ros-dev] [ros-diffs] [cgutman] 36754: - Fix a crash that happens when DriverEntry doesn't complete successfully - Return the correct status when LoopRegisterAdapter fails
by gedmurphy 15 Oct '08

15 Oct '08

I know I'm being pedantic here, but this patch is pretty ugly. A prime case for a goto IMO. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of cgutman(a)svn.reactos.org Sent: 15 October 2008 00:15 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [cgutman] 36754: - Fix a crash that happens when DriverEntry doesn't complete successfully - Return the correct status when LoopRegisterAdapter fails Author: cgutman Date: Tue Oct 14 18:15:22 2008 New Revision: 36754 URL: http://svn.reactos.org/svn/reactos?rev=36754&view=rev Log: - Fix a crash that happens when DriverEntry doesn't complete successfully - Return the correct status when LoopRegisterAdapter fails Modified: branches/aicom-network-fixes/drivers/network/tcpip/tcpip/main.c Modified: branches/aicom-network-fixes/drivers/network/tcpip/tcpip/main.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/net… ============================================================================== --- branches/aicom-network-fixes/drivers/network/tcpip/tcpip/main.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/drivers/network/tcpip/tcpip/main.c [iso-8859-1] Tue Oct 14 18:15:22 2008 @@ -686,7 +686,8 @@ FILE_DEVICE_NETWORK, 0, FALSE, &RawIPDeviceObject); if (!NT_SUCCESS(Status)) { TI_DbgPrint(MIN_TRACE, ("Failed to create RawIP device object. Status (0x%X).\n", Status)); - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); return Status; } @@ -695,7 +696,9 @@ FILE_DEVICE_NETWORK, 0, FALSE, &UDPDeviceObject); if (!NT_SUCCESS(Status)) { TI_DbgPrint(MIN_TRACE, ("Failed to create UDP device object. Status (0x%X).\n", Status)); - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); return Status; } @@ -704,7 +707,10 @@ FILE_DEVICE_NETWORK, 0, FALSE, &TCPDeviceObject); if (!NT_SUCCESS(Status)) { TI_DbgPrint(MIN_TRACE, ("Failed to create TCP device object. Status (0x%X).\n", Status)); - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); return Status; } @@ -713,7 +719,11 @@ EntityList = ExAllocatePool(NonPagedPool, sizeof(TDIEntityID) * MAX_TDI_ENTITIES ); if (!EntityList) { TI_DbgPrint(MIN_TRACE, ("Insufficient resources.\n")); - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); + IoDeleteDevice(TCPDeviceObject); return STATUS_INSUFFICIENT_RESOURCES; } @@ -733,14 +743,25 @@ /* Allocate NDIS packet descriptors */ NdisAllocatePacketPool(&NdisStatus, &GlobalPacketPool, 100, sizeof(PACKET_CONTEXT)); if (NdisStatus != NDIS_STATUS_SUCCESS) { - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); + IoDeleteDevice(TCPDeviceObject); + ExFreePool(EntityList); return STATUS_INSUFFICIENT_RESOURCES; } /* Allocate NDIS buffer descriptors */ NdisAllocateBufferPool(&NdisStatus, &GlobalBufferPool, 100); if (NdisStatus != NDIS_STATUS_SUCCESS) { - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); + IoDeleteDevice(TCPDeviceObject); + ExFreePool(EntityList); + NdisFreePacketPool(GlobalPacketPool); return STATUS_INSUFFICIENT_RESOURCES; } @@ -762,19 +783,46 @@ /* Initialize transport level protocol subsystems */ Status = RawIPStartup(); if( !NT_SUCCESS(Status) ) { - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); + IoDeleteDevice(TCPDeviceObject); + ExFreePool(EntityList); + NdisFreePacketPool(GlobalPacketPool); + NdisFreeBufferPool(GlobalBufferPool); + IPShutdown(); return Status; } Status = UDPStartup(); if( !NT_SUCCESS(Status) ) { - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); + IoDeleteDevice(TCPDeviceObject); + ExFreePool(EntityList); + NdisFreePacketPool(GlobalPacketPool); + NdisFreeBufferPool(GlobalBufferPool); + IPShutdown(); + RawIPShutdown(); return Status; } Status = TCPStartup(); if( !NT_SUCCESS(Status) ) { - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); + IoDeleteDevice(TCPDeviceObject); + ExFreePool(EntityList); + NdisFreePacketPool(GlobalPacketPool); + NdisFreeBufferPool(GlobalBufferPool); + IPShutdown(); + RawIPShutdown(); + UDPShutdown(); return Status; } @@ -794,15 +842,41 @@ NULL, 0, NULL); - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); + IoDeleteDevice(TCPDeviceObject); + ExFreePool(EntityList); + NdisFreePacketPool(GlobalPacketPool); + NdisFreeBufferPool(GlobalBufferPool); + IPShutdown(); + RawIPShutdown(); + UDPShutdown(); + TCPShutdown(); + LANShutdown(); return Status; } /* Open loopback adapter */ - if (!NT_SUCCESS(LoopRegisterAdapter(NULL, NULL))) { + Status = LoopRegisterAdapter(NULL, NULL); + if (!NT_SUCCESS(Status)) { TI_DbgPrint(MIN_TRACE, ("Failed to create loopback adapter. Status (0x%X).\n", Status)); - TiUnload(DriverObject); - return STATUS_INSUFFICIENT_RESOURCES; + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); + IoDeleteDevice(TCPDeviceObject); + ExFreePool(EntityList); + NdisFreePacketPool(GlobalPacketPool); + NdisFreeBufferPool(GlobalBufferPool); + IPShutdown(); + RawIPShutdown(); + UDPShutdown(); + TCPShutdown(); + LANShutdown(); + LANUnregisterProtocol(); + return Status; } /* Use direct I/O */

1 0

Re: [ros-dev] Ros-dev Digest, Vol 50, Issue 14
by Olaf Siejka 14 Oct '08

14 Oct '08

If i may say anything, I dont think its a good idea to force NET 3.5 dependency. It`ll reduce the software usability range as not everyone is willing to upgrade from NET 2.0 Date: Mon, 13 Oct 2008 11:11:16 +0100 From: "gedmurphy" <gedmurphy(a)gmail.com> Subject: Re: [ros-dev] [ros-diffs] [gschneider] 36737: RosDbg Part 3/3: - Named pipe implementation based on .net namespace IO.Pipes with support of threads - Previous win32 test version would strip random characters from debug messages and crash on entering kdbg (related t To: <ros-dev(a)reactos.org> Message-ID: <001901c92d1c$083d7770$18b86650$@com> Content-Type: text/plain; charset="utf-8" I'd originally refrained from doing it this way, using pinvoke instead to keep .net 2.0 compatibility. Using classes such as NamedPipeServerStream forces a .net 3.5 dependency. Is this ok with everyone? Ged.

3 2

Re: [ros-dev] [ros-diffs] [gschneider] 36737: RosDbg Part 3/3: - Named pipe implementation based on .net namespace IO.Pipes with support of threads - Previous win32 test version would strip random characters from debug messages and crash on entering kdbg (related t
by gedmurphy 13 Oct '08

13 Oct '08

I'd originally refrained from doing it this way, using pinvoke instead to keep .net 2.0 compatibility. Using classes such as NamedPipeServerStream forces a .net 3.5 dependency. Is this ok with everyone? Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of gschneider(a)svn.reactos.org Sent: 12 October 2008 22:56 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [gschneider] 36737: RosDbg Part 3/3: - Named pipe implementation based on .net namespace IO.Pipes with support of threads - Previous win32 test version would strip random characters from debug messages and crash on entering kdbg (related to .n Author: gschneider Date: Sun Oct 12 16:55:50 2008 New Revision: 36737 URL: http://svn.reactos.org/svn/reactos?rev=36737&view=rev Log: RosDbg Part 3/3: - Named pipe implementation based on .net namespace IO.Pipes with support of threads - Previous win32 test version would strip random characters from debug messages and crash on entering kdbg (related to .net ReadFile approach) - Works with QEMU (Client mode), VirtualBox (Client and Server), VMware Server (Client and Server) - Usually faster than pure serial connection mode Known bugs: - Input to kdbg using /KDSERIAL is not displayed until enter pressed (but input works) - Reconnect issues, depending on virtual machine behaviour Modified: trunk/tools/reactosdbg/Pipe/namedpipe.cs trunk/tools/reactosdbg/Pipe/serialpipe.cs Modified: trunk/tools/reactosdbg/Pipe/namedpipe.cs URL: http://svn.reactos.org/svn/reactos/trunk/tools/reactosdbg/Pipe/namedpipe.cs… ============================================================================== --- trunk/tools/reactosdbg/Pipe/namedpipe.cs [iso-8859-1] (original) +++ trunk/tools/reactosdbg/Pipe/namedpipe.cs [iso-8859-1] Sun Oct 12 16:55:50 2008 @@ -1,227 +1,205 @@ ï»¿using System; +using System.Collections.Generic; +using System.ComponentModel; using System.IO; -using System.ComponentModel; +using System.IO.Pipes; using System.Runtime.InteropServices; - +using System.Text; +using System.Threading; namespace AbstractPipe { - class Kernel32 + public enum ConnectionMode { - [DllImport("kernel32.dll", SetLastError = true)] - public static extern IntPtr CreateNamedPipe( - String lpName, - OpenMode dwOpenMode, - uint dwPipeMode, - uint nMaxInstances, - uint nOutBufferSize, - uint nInBufferSize, - DefaultTimeout nDefaultTimeOut, - IntPtr pipeSecurityDescriptor - ); - - [DllImport("kernel32.dll", SetLastError = true)] - public static extern bool ConnectNamedPipe( - IntPtr hHandle, - IntPtr lpOverlapped - ); - - [DllImport("kernel32.dll", SetLastError = true)] - public static extern bool ReadFile( - IntPtr hHandle, - byte[] lpBuffer, - uint nNumberOfBytesToRead, - ref uint lpNumberOfBytesRead, - IntPtr lpOverlapped - ); - - [DllImport("kernel32.dll", SetLastError = true)] - public static extern bool WriteFile( - IntPtr hHandle, - byte[] lpBuffer, - uint nNumberOfBytesToWrite, - ref uint lpNumberOfBytesWritten, - IntPtr lpOverlapped - ); - - [DllImport("kernel32.dll", SetLastError = true)] - public static extern bool CloseHandle( - IntPtr hHandle); - - [DllImport("kernel32.dll", SetLastError = true)] - public static extern uint GetLastError(); - - [DllImport("kernel32.dll", SetLastError = true)] - public static extern bool DisconnectNamedPipe( - IntPtr hHandle); - - [DllImport("kernel32.dll", SetLastError = true)] - public static extern bool FlushFileBuffers(IntPtr handle); + MODE_CLIENT = 0x00000000, + MODE_SERVER = 0x00000001, + MODE_AUTO = 0x00000002 } - [StructLayout(LayoutKind.Sequential)] - public class Overlapped + public class NamedPipe : Pipe { - } - - public enum OpenMode : uint - { - PIPE_ACCESS_INBOUND = 0x00000001, - PIPE_ACCESS_OUTBOUND = 0x00000002, - PIPE_ACCESS_DUPLEX = 0x00000003, - FILE_FLAG_FIRST_PIPE_INSTANCE = 0x00080000, - FILE_FLAG_OVERLAPPED = 0x40000000, - FILE_FLAG_WRITE_THROUGH = 0x80000000 - } - - public enum DefaultTimeout : uint - { - NMPWAIT_USE_DEFAULT_WAIT = 0x00000000, - NMPWAIT_NOWAIT = 0x00000001, - NMPWAIT_WAIT_FOREVER = 0xffffffff - } - - [StructLayout(LayoutKind.Sequential)] - public struct SECURITY_ATTRIBUTES - { - public int nLength; - public IntPtr lpSecurityDescriptor; - public int bInheritHandle; - } - - public class NamedPipe// : Pipe - { - private const Int32 INVALID_HANDLE_VALUE = -1; - private const ulong ERROR_PIPE_CONNECTED = 535; - - private IntPtr handle; - //FileAccess mode; + public const int PIPE_SIZE = 1024; + + private PipeStream ioStream; /* stream for io operations */ + private String wCommand; /* buffer of a single command line */ + private List<String> cmdList; /*list of commands pending to be written */ + + public event PipeReceiveEventHandler PipeReceiveEvent; + public event PipeErrorEventHandler PipeErrorEvent; + + private static ManualResetEvent newWriteData = new ManualResetEvent(false); public NamedPipe() { - handle = IntPtr.Zero; - } - - public IntPtr Create(string name) - { - handle = Kernel32.CreateNamedPipe(name, - OpenMode.PIPE_ACCESS_DUPLEX | OpenMode.FILE_FLAG_OVERLAPPED, - 0, - 1, - 100, - 100, - DefaultTimeout.NMPWAIT_WAIT_FOREVER, - IntPtr.Zero); - if (handle.ToInt32() == INVALID_HANDLE_VALUE) - { - throw new Win32Exception("Error creating named pipe " + name + " . Internal error: " + Marshal.GetLastWin32Error().ToString()); - } - - return handle; - } - - public void Disconnect() - { - Kernel32.DisconnectNamedPipe(handle); + cmdList = new List<string>(); + } + + public bool CreateServerPipe(string name) + { + /* create a pipe and wait for a client */ + NamedPipeServerStream sStream = new NamedPipeServerStream(name, PipeDirection.InOut, 1, + PipeTransmissionMode.Byte, PipeOptions.Asynchronous, PIPE_SIZE, PIPE_SIZE); + sStream.WaitForConnection(); + + if (sStream.IsConnected) + { + ioStream = sStream; + return true; + } + else + { + return false; + } + } + + public bool CreateClientPipe(string name) + { + /* try to connect as a client */ + /* (QEMU -serial pipe or VMware in pipe server mode) */ + try + { + NamedPipeClientStream cStream = new NamedPipeClientStream(".", name, PipeDirection.InOut, PipeOptions.Asynchronous); + cStream.Connect(100); + + if (cStream.IsConnected) + { + ioStream = cStream; + return true; + } + else + { + return false; + } + } + catch (Exception) + { + return false; + } + } + + public bool CreatePipe(string name, ConnectionMode mode) + { + if (name == "" || name == null) + { + return false; + } + switch (mode) + { + case ConnectionMode.MODE_AUTO: + //check if pipe exists, if not create server pipe, wait certain time, check if pipe... + //TODO: server-client lookup should time out + while (true) + { + if (CreateClientPipe(name)) + { + break; + } + if (CreateServerPipe(name)) + { + break; + } + } + return true; + + case ConnectionMode.MODE_CLIENT: + while (!CreateClientPipe(name)) ; + + /* pipe open, everything fine */ + return true; + + case ConnectionMode.MODE_SERVER: + if (CreateServerPipe(name)) + { + /* wait for a client*/ + + return true; + } + break; + } + return false; } public void Close() { - Kernel32.CloseHandle(handle); - handle = IntPtr.Zero; - } - - public void Flush() - { - if (handle == IntPtr.Zero) - throw new ObjectDisposedException("NamedPipeStream", "The stream has already been closed"); - Kernel32.FlushFileBuffers(handle); - } - - public bool Listen() - { - Disconnect(); - if (Kernel32.ConnectNamedPipe(handle, IntPtr.Zero) != true) - { - uint lastErr = (uint)Marshal.GetLastWin32Error(); - if (lastErr == ERROR_PIPE_CONNECTED) - return true; - return false; + if (ioStream != null) + ioStream.Close(); + } + + public void WriteLoop() + { + try + { + while (true) + { + if (cmdList.Count > 0) + { + byte[] wBuf = new byte[cmdList[0].Length]; + UTF8Encoding.UTF8.GetBytes(cmdList[0], 0, cmdList[0].Length, wBuf, 0); + + ioStream.Write(wBuf, 0, cmdList[0].Length); + + /* remove written data from commandlist */ + cmdList.RemoveAt(0); + } + else if (cmdList.Count == 0) + { + /* wait until new data is signaled */ + newWriteData.Reset(); + newWriteData.WaitOne(); + } + } + } + catch (Exception e) + { + if (PipeErrorEvent != null) + PipeErrorEvent.Invoke(this, new PipeErrorEventArgs(e.Message)); + } + + } + + public void ReadLoop() + { + byte[] buf = new byte[PIPE_SIZE]; + int read = 0; + + try + { + while(true) + { + read = ioStream.Read(buf, 0, PIPE_SIZE); + if (read > 0) + { + if (PipeReceiveEvent != null) + PipeReceiveEvent.Invoke(this, new PipeReceiveEventArgs(UTF8Encoding.UTF8.GetString(buf, 0, read))); + } + else + { + /* connecion closed */ + break; + } + } + } + catch (Exception e) + { + if (PipeErrorEvent != null) + PipeErrorEvent.Invoke(this, new PipeErrorEventArgs(e.Message)); + } + } + + public bool Write(string str) + { + /* only forward a complete line */ + wCommand += str; + + if (str[str.Length-1] == '\r') + { + cmdList.Add(wCommand); + wCommand = null; + + /* wake up the write thread */ + newWriteData.Set(); } return true; - } - - public int Read(byte[] buffer, int offset, int count) - { - if (buffer == null) - throw new ArgumentNullException("buffer", "The buffer to read into cannot be null"); - if (buffer.Length < (offset + count)) - throw new ArgumentException("Buffer is not large enough to hold requested data", "buffer"); - if (offset < 0) - throw new ArgumentOutOfRangeException("offset", offset, "Offset cannot be negative"); - if (count < 0) - throw new ArgumentOutOfRangeException("count", count, "Count cannot be negative"); - if (handle == IntPtr.Zero) - throw new ObjectDisposedException("NamedPipeStream", "The stream has already been closed"); - - // first read the data into an internal buffer since ReadFile cannot read into a buf at - // a specified offset - uint read = 0; - - byte[] buf = buffer; - if (offset != 0) - { - buf = new byte[count]; - } - bool f = Kernel32.ReadFile(handle, buf, (uint)count, ref read, IntPtr.Zero); - if (!f) - { - throw new Win32Exception(Marshal.GetLastWin32Error(), "ReadFile failed"); - } - if (offset != 0) - { - for (int x = 0; x < read; x++) - { - buffer[offset + x] = buf[x]; - } - - } - return (int)read; - } - - public void Write(byte[] buffer, int offset, int count) - { - if (buffer == null) - throw new ArgumentNullException("buffer", "The buffer to write into cannot be null"); - if (buffer.Length < (offset + count)) - throw new ArgumentException("Buffer does not contain amount of requested data", "buffer"); - if (offset < 0) - throw new ArgumentOutOfRangeException("offset", offset, "Offset cannot be negative"); - if (count < 0) - throw new ArgumentOutOfRangeException("count", count, "Count cannot be negative"); - if (handle == IntPtr.Zero) - throw new ObjectDisposedException("NamedPipeStream", "The stream has already been closed"); - - // copy data to internal buffer to allow writing from a specified offset - if (offset != 0) - { - byte[] buf = new Byte[count]; - for (int x = 0; x < count; x++) - { - buf[x] = buffer[offset + x]; - } - buffer = buf; - } - uint written = 0; - bool result = Kernel32.WriteFile(handle, buffer, (uint)count, ref written, IntPtr.Zero); - - if (!result) - { - int err = (int)Marshal.GetLastWin32Error(); - throw new Win32Exception(err, "Writing to the stream failed"); - } - if (written < count) - throw new IOException("Unable to write entire buffer to stream"); } } } Modified: trunk/tools/reactosdbg/Pipe/serialpipe.cs URL: http://svn.reactos.org/svn/reactos/trunk/tools/reactosdbg/Pipe/serialpipe.c… ============================================================================== --- trunk/tools/reactosdbg/Pipe/serialpipe.cs [iso-8859-1] (original) +++ trunk/tools/reactosdbg/Pipe/serialpipe.cs [iso-8859-1] Sun Oct 12 16:55:50 2008 @@ -80,7 +80,7 @@ public void SerialPortErrorReceived(object sender, SerialErrorReceivedEventArgs args) { - mSerialPort.Close(); + /* port will be closed by debug connection */ if (PipeErrorEvent != null) PipeErrorEvent.Invoke(this, new PipeErrorEventArgs(args.EventType.ToString())); }

1 0

Re: [ros-dev] [ros-diffs] [mjmartin] 36732: - Implement REnumServicesStatusExA - REnumServicesStatusA/W: Fixed returned param values to match Windows - REnumServicesStatusExW: Dont try to access lpResumeIndex if it is NULL. Fixed returned param values to match wind
by gedmurphy 12 Oct '08

12 Oct '08

You're duplicating code here. REnumServicesStatusExA should call REnumServicesStatusExW to do the work. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of mjmartin(a)svn.reactos.org Sent: 12 October 2008 14:10 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [mjmartin] 36732: - Implement REnumServicesStatusExA - REnumServicesStatusA/W: Fixed returned param values to match Windows - REnumServicesStatusExW: Dont try to access lpResumeIndex if it is NULL. Fixed returned param values to match windows. Author: mjmartin Date: Sun Oct 12 08:10:05 2008 New Revision: 36732 URL: http://svn.reactos.org/svn/reactos?rev=36732&view=rev Log: - Implement REnumServicesStatusExA - REnumServicesStatusA/W: Fixed returned param values to match Windows - REnumServicesStatusExW: Dont try to access lpResumeIndex if it is NULL. Fixed returned param values to match windows. Modified: trunk/reactos/base/system/services/rpcserver.c Modified: trunk/reactos/base/system/services/rpcserver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/services/rpcse… ============================================================================== --- trunk/reactos/base/system/services/rpcserver.c [iso-8859-1] (original) +++ trunk/reactos/base/system/services/rpcserver.c [iso-8859-1] Sun Oct 12 08:10:05 2008 @@ -2371,6 +2371,12 @@ dwRequiredSize += dwSize; } + if (dwError != ERROR_MORE_DATA) + { + *pcbBytesNeeded = 0; + if (lpResumeHandle) *lpResumeHandle = 0; + } + Done:; /* FIXME: Unlock the service list */ @@ -3451,8 +3457,8 @@ continue; dwSize = sizeof(ENUM_SERVICE_STATUSA) + - ((wcslen(CurrentService->lpServiceName) + 1)) + - ((wcslen(CurrentService->lpDisplayName) + 1)); + wcslen(CurrentService->lpServiceName) + 1 + + wcslen(CurrentService->lpDisplayName) + 1; if (dwRequiredSize + dwSize > dwBufSize) { @@ -3487,9 +3493,9 @@ if ((dwState & dwServiceState) == 0) continue; - dwRequiredSize += (sizeof(ENUM_SERVICE_STATUSA) + - ((wcslen(CurrentService->lpServiceName) + 1)) + - ((wcslen(CurrentService->lpDisplayName) + 1))); + dwRequiredSize += sizeof(ENUM_SERVICE_STATUSA) + + wcslen(CurrentService->lpServiceName) + 1 + + wcslen(CurrentService->lpDisplayName) + 1; dwError = ERROR_MORE_DATA; } @@ -3524,8 +3530,8 @@ continue; dwSize = sizeof(ENUM_SERVICE_STATUSA) + - ((wcslen(CurrentService->lpServiceName) + 1)) + - ((wcslen(CurrentService->lpDisplayName) + 1)); + wcslen(CurrentService->lpServiceName) + 1 + + wcslen(CurrentService->lpDisplayName) + 1; if (dwRequiredSize + dwSize > dwBufSize) break; @@ -3561,6 +3567,12 @@ lpStatusPtr++; dwRequiredSize += dwSize; + } + + if (dwError != ERROR_MORE_DATA) + { + *pcbBytesNeeded = 0; + if (lpResumeHandle) *lpResumeHandle = 0; } Done:; @@ -4509,10 +4521,295 @@ LPBOUNDED_DWORD_256K lpResumeIndex, LPCSTR pszGroupName) { - UNIMPLEMENTED; + PMANAGER_HANDLE hManager; + PSERVICE lpService; + DWORD dwError = ERROR_SUCCESS; + PLIST_ENTRY ServiceEntry; + PSERVICE CurrentService; + DWORD dwState; + DWORD dwRequiredSize; + DWORD dwServiceCount; + DWORD dwSize; + DWORD dwLastResumeCount = 0; + LPENUM_SERVICE_STATUS_PROCESSA lpStatusPtr; + LPSTR lpStringPtr; + LPWSTR pszGroupNameW = NULL; + + DPRINT("REnumServicesStatusExA() called\n"); + + if (ScmShutdown) + return ERROR_SHUTDOWN_IN_PROGRESS; + + if (InfoLevel != SC_ENUM_PROCESS_INFO) + return ERROR_INVALID_LEVEL; + + hManager = (PMANAGER_HANDLE)hSCManager; + if (!hManager || hManager->Handle.Tag != MANAGER_TAG) + { + DPRINT1("Invalid manager handle!\n"); + return ERROR_INVALID_HANDLE; + } + *pcbBytesNeeded = 0; *lpServicesReturned = 0; - return ERROR_CALL_NOT_IMPLEMENTED; + + if ((dwServiceType!=SERVICE_DRIVER) && (dwServiceType!=SERVICE_WIN32)) + { + DPRINT1("Not a valid Service Type!\n"); + return ERROR_INVALID_PARAMETER; + } + + if ((dwServiceState<SERVICE_ACTIVE) || (dwServiceState>SERVICE_STATE_ALL)) + { + DPRINT1("Not a valid Service State!\n"); + return ERROR_INVALID_PARAMETER; + } + + /* Check access rights */ + if (!RtlAreAllAccessesGranted(hManager->Handle.DesiredAccess, + SC_MANAGER_ENUMERATE_SERVICE)) + { + DPRINT1("Insufficient access rights! 0x%lx\n", + hManager->Handle.DesiredAccess); + return ERROR_ACCESS_DENIED; + } + + if (lpResumeIndex) dwLastResumeCount = *lpResumeIndex; + + /* FIXME: Lock the service list shared */ + + lpService = ScmGetServiceEntryByResumeCount(dwLastResumeCount); + if (lpService == NULL) + { + dwError = ERROR_SUCCESS; + goto Done; + } + + dwRequiredSize = 0; + dwServiceCount = 0; + + if (pszGroupName) + { + pszGroupNameW = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, (strlen(pszGroupName) + 1) * sizeof(WCHAR)); + if (!pszGroupNameW) + { + DPRINT1("Failed to allocate buffer!\n"); + return ERROR_NOT_ENOUGH_MEMORY; + } + MultiByteToWideChar(CP_ACP, + 0, + pszGroupName, + -1, + pszGroupNameW, + strlen(pszGroupName) + 1); + } + + for (ServiceEntry = &lpService->ServiceListEntry; + ServiceEntry != &ServiceListHead; + ServiceEntry = ServiceEntry->Flink) + { + CurrentService = CONTAINING_RECORD(ServiceEntry, + SERVICE, + ServiceListEntry); + + if ((CurrentService->Status.dwServiceType & dwServiceType) == 0) + continue; + + dwState = SERVICE_ACTIVE; + if (CurrentService->Status.dwCurrentState == SERVICE_STOPPED) + dwState = SERVICE_INACTIVE; + + if ((dwState & dwServiceState) == 0) + continue; + + if (pszGroupNameW) + { + if (*pszGroupNameW == 0) + { + if (CurrentService->lpGroup != NULL) + continue; + } + else + { + if ((CurrentService->lpGroup == NULL) || + _wcsicmp(pszGroupNameW, CurrentService->lpGroup->lpGroupName)) + continue; + } + } + + dwSize = sizeof(ENUM_SERVICE_STATUS_PROCESSW) + + (wcslen(CurrentService->lpServiceName) + 1) + + (wcslen(CurrentService->lpDisplayName) + 1); + + if (dwRequiredSize + dwSize <= cbBufSize) + { + DPRINT("Service name: %S fit\n", CurrentService->lpServiceName); + dwRequiredSize += dwSize; + dwServiceCount++; + dwLastResumeCount = CurrentService->dwResumeCount; + } + else + { + DPRINT("Service name: %S no fit\n", CurrentService->lpServiceName); + break; + } + + } + + DPRINT("dwRequiredSize: %lu\n", dwRequiredSize); + DPRINT("dwServiceCount: %lu\n", dwServiceCount); + + for (; + ServiceEntry != &ServiceListHead; + ServiceEntry = ServiceEntry->Flink) + { + CurrentService = CONTAINING_RECORD(ServiceEntry, + SERVICE, + ServiceListEntry); + + if ((CurrentService->Status.dwServiceType & dwServiceType) == 0) + continue; + + dwState = SERVICE_ACTIVE; + if (CurrentService->Status.dwCurrentState == SERVICE_STOPPED) + dwState = SERVICE_INACTIVE; + + if ((dwState & dwServiceState) == 0) + continue; + + if (pszGroupNameW) + { + if (*pszGroupNameW == 0) + { + if (CurrentService->lpGroup != NULL) + continue; + } + else + { + if ((CurrentService->lpGroup == NULL) || + _wcsicmp(pszGroupNameW, CurrentService->lpGroup->lpGroupName)) + continue; + } + } + + dwRequiredSize += (sizeof(ENUM_SERVICE_STATUS_PROCESSW) + + (wcslen(CurrentService->lpServiceName) + 1) + + (wcslen(CurrentService->lpDisplayName) + 1)); + + dwError = ERROR_MORE_DATA; + } + + DPRINT("*pcbBytesNeeded: %lu\n", dwRequiredSize); + + if (lpResumeIndex) *lpResumeIndex = dwLastResumeCount; + *lpServicesReturned = dwServiceCount; + *pcbBytesNeeded = dwRequiredSize; + + /* If there was no services that matched */ + if (!dwServiceCount) + { + dwError = ERROR_SERVICE_DOES_NOT_EXIST; + goto Done; + } + + lpStatusPtr = (LPENUM_SERVICE_STATUS_PROCESSA)lpBuffer; + lpStringPtr = (LPSTR)((ULONG_PTR)lpBuffer + + dwServiceCount * sizeof(ENUM_SERVICE_STATUS_PROCESSA)); + + dwRequiredSize = 0; + for (ServiceEntry = &lpService->ServiceListEntry; + ServiceEntry != &ServiceListHead; + ServiceEntry = ServiceEntry->Flink) + { + CurrentService = CONTAINING_RECORD(ServiceEntry, + SERVICE, + ServiceListEntry); + + if ((CurrentService->Status.dwServiceType & dwServiceType) == 0) + continue; + + dwState = SERVICE_ACTIVE; + if (CurrentService->Status.dwCurrentState == SERVICE_STOPPED) + dwState = SERVICE_INACTIVE; + + if ((dwState & dwServiceState) == 0) + continue; + + if (pszGroupNameW) + { + if (*pszGroupNameW == 0) + { + if (CurrentService->lpGroup != NULL) + continue; + } + else + { + if ((CurrentService->lpGroup == NULL) || + _wcsicmp(pszGroupNameW, CurrentService->lpGroup->lpGroupName)) + continue; + } + } + + dwSize = sizeof(ENUM_SERVICE_STATUS_PROCESSW) + + ((wcslen(CurrentService->lpServiceName) + 1) * sizeof(WCHAR)) + + ((wcslen(CurrentService->lpDisplayName) + 1) * sizeof(WCHAR)); + + if (dwRequiredSize + dwSize <= cbBufSize) + { + /* Copy the service name */ + WideCharToMultiByte(CP_ACP, + 0, + CurrentService->lpServiceName, + -1, + lpStringPtr, + wcslen(CurrentService->lpServiceName), + 0, + 0); + lpStatusPtr->lpServiceName = (LPSTR)((ULONG_PTR)lpStringPtr - (ULONG_PTR)lpBuffer); + lpStringPtr += (wcslen(CurrentService->lpServiceName) + 1); + + /* Copy the display name */ + WideCharToMultiByte(CP_ACP, + 0, + CurrentService->lpDisplayName, + -1, + lpStringPtr, + wcslen(CurrentService->lpDisplayName), + 0, + 0); + lpStatusPtr->lpDisplayName = (LPSTR)((ULONG_PTR)lpStringPtr - (ULONG_PTR)lpBuffer); + lpStringPtr += (wcslen(CurrentService->lpDisplayName) + 1); + + /* Copy the status information */ + memcpy(&lpStatusPtr->ServiceStatusProcess, + &CurrentService->Status, + sizeof(SERVICE_STATUS)); + lpStatusPtr->ServiceStatusProcess.dwProcessId = CurrentService->ProcessId; /* FIXME */ + lpStatusPtr->ServiceStatusProcess.dwServiceFlags = 0; /* FIXME */ + + lpStatusPtr++; + dwRequiredSize += dwSize; + } + else + { + break; + } + } + + if (dwError != ERROR_MORE_DATA) + { + *pcbBytesNeeded = 0; + if (lpResumeIndex) *lpResumeIndex = 0; + } + +Done:; + /* Unlock the service list */ + + if (pszGroupNameW) HeapFree(GetProcessHeap(),0,pszGroupNameW); + + DPRINT("REnumServicesStatusExA() done (Error %lu)\n", dwError); + + return dwError; } @@ -4539,7 +4836,7 @@ DWORD dwRequiredSize; DWORD dwServiceCount; DWORD dwSize; - DWORD dwLastResumeCount; + DWORD dwLastResumeCount = 0; LPENUM_SERVICE_STATUS_PROCESSW lpStatusPtr; LPWSTR lpStringPtr; @@ -4556,6 +4853,21 @@ { DPRINT1("Invalid manager handle!\n"); return ERROR_INVALID_HANDLE; + } + + *pcbBytesNeeded = 0; + *lpServicesReturned = 0; + + if ((dwServiceType!=SERVICE_DRIVER) && (dwServiceType!=SERVICE_WIN32)) + { + DPRINT1("Not a valid Service Type!\n"); + return ERROR_INVALID_PARAMETER; + } + + if ((dwServiceState<SERVICE_ACTIVE) || (dwServiceState>SERVICE_STATE_ALL)) + { + DPRINT1("Not a valid Service State!\n"); + return ERROR_INVALID_PARAMETER; } /* Check access rights */ @@ -4567,10 +4879,7 @@ return ERROR_ACCESS_DENIED; } - *pcbBytesNeeded = 0; - *lpServicesReturned = 0; - - dwLastResumeCount = *lpResumeIndex; + if (lpResumeIndex) dwLastResumeCount = *lpResumeIndex; /* Lock the service list shared */ @@ -4681,9 +4990,16 @@ DPRINT("*pcbBytesNeeded: %lu\n", dwRequiredSize); - *lpResumeIndex = dwLastResumeCount; + if (lpResumeIndex) *lpResumeIndex = dwLastResumeCount; *lpServicesReturned = dwServiceCount; *pcbBytesNeeded = dwRequiredSize; + + /* If there was no services that matched */ + if (!dwServiceCount) + { + dwError = ERROR_SERVICE_DOES_NOT_EXIST; + goto Done; + } lpStatusPtr = (LPENUM_SERVICE_STATUS_PROCESSW)lpBuffer; lpStringPtr = (LPWSTR)((ULONG_PTR)lpBuffer + @@ -4755,7 +5071,12 @@ { break; } - + } + + if (dwError != ERROR_MORE_DATA) + { + *pcbBytesNeeded = 0; + if (lpResumeIndex) *lpResumeIndex = 0; } Done:;

1 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 36714: - Added "stub" for internal notification structure - Implemented FsRtlNotifyInitializeSync. It's not complete, not perfect. That's a WIP. See issue #2821 for more details.
by Alex Ionescu 12 Oct '08

12 Oct '08

UDT : _REAL_NOTIFY_SYNC Data : this+0x0, Member, Type: struct _FAST_MUTEX, FastMutex UDT : _FAST_MUTEX Data : this+0x20, Member, Type: unsigned long, OwningThread Data : this+0x24, Member, Type: unsigned long, OwnerCount It's just initializing a fast mutex and setting the owner to NULL and count to 0. On 11-Oct-08, at 7:29 AM, pschweitzer(a)svn.reactos.org wrote: > VOID > NTAPI > FsRtlNotifyInitializeSync(IN PNOTIFY_SYNC *NotifySync) > { > - KEBUGCHECK(0); > + PINT_NOTIFY_SYNC IntNotifySync; > + > + *NotifySync = NULL; > + > + IntNotifySync = FsRtlAllocatePoolWithTag(NonPagedPool, > sizeof(INT_NOTIFY_SYNC), TAG('F', 'S', 'N', 'S')); > + IntNotifySync->Unknown1 = 0; > + IntNotifySync->Unknown2 = 0; > + IntNotifySync->Unknown5 = 0; > + IntNotifySync->Unknown0 = 1; > + IntNotifySync->Unknown3 = 1; > + IntNotifySync->Unknown4 = 4; > + InitializeListHead(&(IntNotifySync->Unknown6)); > + IntNotifySync->Unknown8 = 0; > + IntNotifySync->Unknown9 = 0; > + > + *NotifySync = IntNotifySync; Best regards, Alex Ionescu

2 1

Re: [ros-dev] [ros-diffs] [pschweitzer] 36709: Fixed a FIXME A bit cleaned header
by Aleksey Bragin 11 Oct '08

11 Oct '08

Do you really need finally clause in this case? It's not the most beautiful way when doing it via PSEH. WBR, Aleksey. On Oct 10, 2008, at 11:26 PM, pschweitzer(a)svn.reactos.org wrote: > Author: pschweitzer > Date: Fri Oct 10 14:26:42 2008 > New Revision: 36709 > > URL: http://svn.reactos.org/svn/reactos?rev=36709&view=rev > Log: > Fixed a FIXME > A bit cleaned header > > Modified: > branches/pierre-fsd/drivers/filesystems/fastfat/finfo.c > branches/pierre-fsd/drivers/filesystems/fastfat/vfat.h > > Modified: branches/pierre-fsd/drivers/filesystems/fastfat/finfo.c > URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/drivers/ > filesystems/fastfat/finfo.c?rev=36709&r1=36708&r2=36709&view=diff > ====================================================================== > ======== > --- branches/pierre-fsd/drivers/filesystems/fastfat/finfo.c > [iso-8859-1] (original) > +++ branches/pierre-fsd/drivers/filesystems/fastfat/finfo.c > [iso-8859-1] Fri Oct 10 14:26:42 2008 > @@ -443,6 +443,10 @@ > } > > > +_SEH_FINALLYFUNC(VfatGetEaInformationFinal_PSEH) > +{ > +} > + > static NTSTATUS > VfatGetEaInformation(PFILE_OBJECT FileObject, > PVFATFCB Fcb, > @@ -452,15 +456,19 @@ > { > PDEVICE_EXTENSION DeviceExt = DeviceObject->DeviceExtension; > > - /* FIXME - use SEH to access the buffer! */ > - Info->EaSize = 0; > - *BufferLength -= sizeof(*Info); > - if (DeviceExt->FatInfo.FatType == FAT12 || > - DeviceExt->FatInfo.FatType == FAT16) > - { > - /* FIXME */ > - DPRINT1("VFAT: FileEaInformation not implemented!\n"); > - } > + _SEH_TRY > + { > + RtlZeroMemory(Info, sizeof(FILE_EA_INFORMATION)); > + if (DeviceExt->FatInfo.FatType == FAT12 || > + DeviceExt->FatInfo.FatType == FAT16) > + { > + /* FIXME */ > + DPRINT1("VFAT: FileEaInformation not implemented!\n"); > + } > + *BufferLength -= sizeof(FILE_EA_INFORMATION); > + } > + _SEH_FINALLY(VfatGetEaInformationFinal_PSEH) > + _SEH_END; > return STATUS_SUCCESS; > } > > > Modified: branches/pierre-fsd/drivers/filesystems/fastfat/vfat.h > URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/drivers/ > filesystems/fastfat/vfat.h?rev=36709&r1=36708&r2=36709&view=diff > ====================================================================== > ======== > --- branches/pierre-fsd/drivers/filesystems/fastfat/vfat.h > [iso-8859-1] (original) > +++ branches/pierre-fsd/drivers/filesystems/fastfat/vfat.h > [iso-8859-1] Fri Oct 10 14:26:42 2008 > @@ -608,15 +608,7 @@ > > /* -------------------------------------------------------- > string.c */ > > -VOID > -vfatSplitPathName(PUNICODE_STRING PathNameU, > - PUNICODE_STRING DirNameU, > - PUNICODE_STRING FileNameU); > - > BOOLEAN vfatIsLongIllegal(WCHAR c); > - > -BOOLEAN wstrcmpjoki (PWSTR s1, > - PWSTR s2); > > /* ----------------------------------------------------------- > fat.c */ > > @@ -702,6 +694,11 @@ > > /* ----------------------------------------------------------- > fcb.c */ > > +VOID > +vfatSplitPathName(PUNICODE_STRING PathNameU, > + PUNICODE_STRING DirNameU, > + PUNICODE_STRING FileNameU); > + > PVFATFCB vfatNewFCB (PDEVICE_EXTENSION pVCB, > PUNICODE_STRING pFileNameU); > >

2 1

Re: [ros-dev] confused by "rtlpInitDeferedCriticalSection"
by tamlin＠algonet.se 11 Oct '08

11 Oct '08

Colin wrote: >The name "Rtlp..." already says it: This is a private function only used >internally by ntdll. To elaborate: if the name has a "p" in it after the "namespace" name (here Rtl), it usually means "private". -- Mike

1 0

question about InterlockedCompareExchange.
by Jack Yi 10 Oct '08

10 Oct '08

question about InterlockedCompareExchange. MSDN says: The function returns the initial value of the destination. I just don't understand, why can we get the initial value of destination as return value by 'return 0Ch' ? Thank you! .text:7C8097A2 ; PVOID __stdcall InterlockedCompareExchange(PVOID *Destination,PVOID Exchange,PVOID Comperand) .text:7C8097A2 public _InterlockedCompareExchange@12 .text:7C8097A2 _InterlockedCompareExchange@12 proc near .text:7C8097A2 ; CODE XREF: BaseComputeProcessDllPath(x,x)+97B3p .text:7C8097A2 ; CreateActCtxW(x)+15D2Dp .text:7C8097A2 .text:7C8097A2 Destination = dword ptr 4 .text:7C8097A2 Exchange = dword ptr 8 .text:7C8097A2 Comperand = dword ptr 0Ch .text:7C8097A2 .text:7C8097A2 mov ecx, [esp+Destination] .text:7C8097A6 mov edx, [esp+Exchange] .text:7C8097AA mov eax, [esp+Comperand] .text:7C8097AE .text:7C8097AE loc_7C8097AE: ; DATA XREF: .data:7C884014o .text:7C8097AE lock cmpxchg [ecx], edx .text:7C8097B2 retn 0Ch .text:7C8097B2 _InterlockedCompareExchange@12 endp

3 2

confused by "rtlpInitDeferedCriticalSection"
by Jack Yi 10 Oct '08

10 Oct '08

hi, guys! How and when should I use this function(lib\rtl\critical.c, line 222) ? In fact,I can not find such a fuction in the export table of ntdll(XP sp2).

2 1

Re: [ros-dev] [ros-diffs] [cgutman] 36699: - Some of my work on NDIS 6.0 - Doesn't compile yet - Part 1 of X
by gedmurphy 08 Oct '08

08 Oct '08

please pair ExAllocatePoolWithTag with ExFreePoolWithTag -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of cgutman(a)svn.reactos.org Sent: 08 October 2008 22:17 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [cgutman] 36699: - Some of my work on NDIS 6.0 - Doesn't compile yet - Part 1 of X Author: cgutman Date: Wed Oct 8 16:17:10 2008 New Revision: 36699 URL: http://svn.reactos.org/svn/reactos?rev=36699&view=rev Log: - Some of my work on NDIS 6.0 - Doesn't compile yet - Part 1 of X Added: branches/aicom-network-fixes/drivers/network/ndis/ndis/object.c (with props) Added: branches/aicom-network-fixes/drivers/network/ndis/ndis/object.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/net… ============================================================================== --- branches/aicom-network-fixes/drivers/network/ndis/ndis/object.c (added) +++ branches/aicom-network-fixes/drivers/network/ndis/ndis/object.c [iso-8859-1] Wed Oct 8 16:17:10 2008 @@ -1,0 +1,40 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS NDIS library + * FILE: object.c + * PURPOSE: Implements the NDIS 6.0 object interface + * PROGRAMMERS: Cameron Gutman (aicommander(a)gmail.com) + */ + +#include "ndissys.h" + +PNDIS_GENERIC_OBJECT +EXPORT +NdisAllocateGenericObject( + IN PDRIVER_OBJECT DriverObject OPTIONAL, + IN ULONG Tag, + IN USHORT Size) +{ + PNDIS_GENERIC_OBJECT Object; + + Object = ExAllocatePoolWithTag(NonPagedPool, sizeof(NDIS_GENERIC_OBJECT) + Size, Tag); + if (!Object) return NULL; + + RtlZeroMemory(Object, sizeof(NDIS_GENERIC_OBJECT) + Size); + + Object->DriverObject = DriverObject; + Object->Header.Type = NDIS_OBJECT_TYPE_GENERIC_OBJECT; + Object->Header.Revision = NDIS_GENERIC_OBJECT_REVISION_1; + Object->Header.Size = sizeof(NDIS_GENERIC_OBJECT); + + return Object; +} + +VOID +EXPORT +NdisFreeGenericObject( + IN PNDIS_GENERIC_OBJECT NdisGenericObject) +{ + ExFreePool(NdisGenericObject); +} + Propchange: branches/aicom-network-fixes/drivers/network/ndis/ndis/object.c ------------------------------------------------------------------------------ svn:eol-style = native

1 0

WDK not working
by മഹേഷ് മുകുന്ദന് | Mahesh M 08 Oct '08

08 Oct '08

hi.. I tried the latest WDK provided by Micrsoft - http://download.microsoft.com/download/9/0/f/90f019ac-8243-48d3-91cf-81fc40… It was attached to Qemu as a CDROM. It did boot showing the D:\ But I couldnt install it. I tried installing via wine in Lenny.That too didnt work. Any help.. Can i get an alternative older one that works with ROS? -- Mahesh M Happy hacking... , , / \ ((__-^^-,-^^-__)) `-_---' `---_-' `--|o` 'o|--' \ ` / ): :( :o_o: "-"

5 6

[gedmurphy] 36658: Remove the address and command windows from the bottom of the file browser. They're buggy and they're not too pretty
by Gabriel ilardi 07 Oct '08

07 Oct '08

Commit by gedmurphy :: r36658 reactos/base/shell/explorer/shell/ (mainframe.cpp mainframe.h): Remove the address and command windows from the bottom of the file browser. They're buggy and they're not too pretty Hi everyone, Even though explorer looks nicer indeed with this change, bear in mind that you can't use the internal web browser anymore (you can't type any web address). Regards, Gabriel. _________________________________________________________________ Stanco della solita finestra? Personalizza la tua Hotmail! http://www.messenger.it/personalizza.html#sfondi

4 7

Re : Re : [gedmurphy] 36658: Remove the address and command windows from the bottom of the file browser. They're buggy and they're not too pretty
by Sylvain Petreolle 06 Oct '08

06 Oct '08

----- Message d'origine ---- > De : Christoph von Wittich <Christoph(a)apiviewer.de> > À : ReactOS Development List <ros-dev(a)reactos.org> > Envoyé le : Lundi, 6 Octobre 2008, 16h35mn 25s > Objet : Re: [ros-dev] Re : [gedmurphy] 36658: Remove the address and command windows from the bottom of the file browser. They're buggy and they're not too pretty > > > > iexplore doesnt compile now : > > shdocvw's IEWinMain is still a stub for now (shdocvw synced to 0.9.5 according > to README.WINE) > > > > Kind regards, > > Sylvain Petreolle > > > > > > Here is a patch to sync shdocvw - it builds - but Explorer crashes on > "Web" without any debug output. > > http://iso.reactos.org/temp/shdocvw_patch.diff > > Regards, > Christoph von Wittich With that patched shdocvw and wine msimtf (attached in msimtf.zip), you can run iexplore without problem. In iexplore_mozillaactivex.zip : 1/winemshtml.reg adds needed registry keys for mshtml in order load gecko. 2/put version in mozilla activex directory (mshtml checks for it). Last: regsvr32 msimtf. Screenshots: Reactos Home http://img234.imageshack.us/my.php?image=iexploremozillaactivexzg8.png Maximized(better) http://img444.imageshack.us/my.php?image=iexploremaximzedbetterwq8.png Acid3 test :) http://img397.imageshack.us/my.php?image=iexploreacid3id3.png

1 0

Event invitation [jornadas Imaginática 2009]
by Marc Piulachs 06 Oct '08

06 Oct '08

Hi All, I have been contacted/invited to participate and give a talk about ReactOS in an event organized by the university of Seville, spain (very beautiful city!) on 2-6 March 2009. It would be great if some of the other spanish based members are also interested on participate, I have been disconnected from the project lately due to offline life but would be willing to participate in this event and help to spread the word about reactos in academic circles. More information here (in spanish): http://imaginatica.org/2009/descargas/Dossier.pdf Regards, /Marc

1 0

Re : [gedmurphy] 36658: Remove the address and command windows from the bottom of the file browser. They're buggy and they're not too pretty
by Sylvain Petreolle 06 Oct '08

06 Oct '08

----- Message d'origine ---- > De : Steven Edwards <winehacker(a)gmail.com> > À : ReactOS Development List <ros-dev(a)reactos.org> > Envoyé le : Lundi, 6 Octobre 2008, 13h55mn 01s > Objet : Re: [ros-dev] [gedmurphy] 36658: Remove the address and command windows from the bottom of the file browser. They're buggy and they're not too pretty > > On Mon, Oct 6, 2008 at 7:23 AM, gedmurphy wrote: > > I'll put an address bar in, along with a few other changes. > > Just remind me so I don't forget. > > Could you look at whats required or left to get iexplore working? The > Wine import of all of the dlls is done and it should download the wine > gecko package if you start it but I believe someone was having > problems when they tried to install/run it, under Wine there is a > registry key we set in the wine.inf that stores the gecko download url > so maybe that is whats needed. Just enable iexplore in > reactos/base/applications and try to run it under ReactOS. If it works > we could ship it with the wine gecko binary as part of the release > process. > > -- > Steven Edwards iexplore doesnt compile now : shdocvw's IEWinMain is still a stub for now (shdocvw synced to 0.9.5 according to README.WINE) Kind regards, Sylvain Petreolle

2 1

Re: [ros-dev] [ros-diffs] [cfinck] 36643: Update some links properly and update the description of Opera (sounds stupid to use the same for Firefox and Opera)
by Aleksey Bragin 05 Oct '08

05 Oct '08

Using "latest-X.0" looks more correct than specifying exact version number two times. WBR, Aleksey. On Oct 4, 2008, at 5:00 PM, cfinck(a)svn.reactos.org wrote: > Author: cfinck > Date: Sat Oct 4 08:00:33 2008 > New Revision: 36643 > > URL: http://svn.reactos.org/svn/reactos?rev=36643&view=rev > Log: > Update some links properly and update the description of Opera > (sounds stupid to use the same for Firefox and Opera) > > Modified: > trunk/rosapps/applications/downloader/downloader.xml > > Modified: trunk/rosapps/applications/downloader/downloader.xml > URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/ > downloader/downloader.xml?rev=36643&r1=36642&r2=36643&view=diff > ====================================================================== > ======== > --- trunk/rosapps/applications/downloader/downloader.xml > [iso-8859-1] (original) > +++ trunk/rosapps/applications/downloader/downloader.xml > [iso-8859-1] Sat Oct 4 08:00:33 2008 > @@ -12,13 +12,13 @@ > <licence>MPL/GPL/LGPL</licence> > <version>2.0.0.17</version> > <description>The most popular and one of the best free Web > Browsers out there.</description> > - <location>http://releases.mozilla.org/pub/mozilla.org/firefox/ > releases/latest-2.0/win32/en-US/Firefox%20Setup%202.0.0.17.exe</ > location> > + <location>http://releases.mozilla.org/pub/mozilla.org/firefox/ > releases/2.0.0.17/win32/en-US/Firefox%20Setup%202.0.0.17.exe</ > location> > </application> > <application name="Opera"> > <regname>Opera</regname> > <licence>Freeware</licence> > <version>9.26</version> > - <description>The most popular and one of the best free Web > Browsers out there.</description> > + <description>The popular Opera Browser with many advanced > features and including a Mail and BitTorrent client.</description> > <location>http://mirror.nwps.ws/opera/win/926/en/ > Opera_9.26_Classic_Setup.exe</location> > </application> > <application name="Thunderbird 1.5"> > @@ -26,20 +26,20 @@ > <licence>MPL/GPL/LGPL</licence> > <version>1.5.0.14</version> > <description>The most popular and one of the best free Mail > Clients out there.</description> > - <location>http://releases.mozilla.org/pub/mozilla.org/ > thunderbird/releases/latest-1.5/win32/en-US/Thunderbird%20Setup% > 201.5.0.14.exe</location> > + <location>http://releases.mozilla.org/pub/mozilla.org/ > thunderbird/releases/1.5.0.14/win32/en-US/Thunderbird%20Setup% > 201.5.0.14.exe</location> > </application> > <application name="Thunderbird 2.0"> > <regname>Mozilla Thunderbird (2.0.0.16)</regname> > <licence>MPL/GPL/LGPL</licence> > <version>2.0.0.16</version> > <description>The most popular and one of the best free Mail > Clients out there.</description> > - <location>http://releases.mozilla.org/pub/mozilla.org/ > thunderbird/releases/latest-2.0/win32/en-US/Thunderbird%20Setup% > 202.0.0.16.exe</location> > + <location>http://releases.mozilla.org/pub/mozilla.org/ > thunderbird/releases/2.0.0.17/win32/en-US/Thunderbird%20Setup% > 202.0.0.17.exe</location> > </application> > <application name="SeaMonkey"> > <regname>SeaMonkey (1.1.9)</regname> > <version>1.1.9</version> > <description>Mozilla Suite is alive. This is the one and only > Browser, Mail, Chat, and Composer bundle you will ever need.</ > description> > - <location>http://releases.mozilla.org/pub/mozilla.org/seamonkey/ > releases/1.1.9/seamonkey-1.1.9.en-US.win32.installer.exe</location> > + <location>http://releases.mozilla.org/pub/mozilla.org/seamonkey/ > releases/1.1.12/seamonkey-1.1.12.en-US.win32.installer.exe</location> > </application> > <application name="Mozilla ActiveX Control"> > <regname>Mozilla ActiveX Control v1.7.12 (ReactOS special)</ > regname> >

2 1

Re: [ros-dev] [ros-diffs] [fireball] 36426: [FORMATTING] - Reformat to the kernel coding style.
by Alex Ionescu 05 Oct '08

05 Oct '08

Please show me where the developers of this code agreed to having their code GPL V3 licensed. I would like to see a full trail of every developer that wrote this code, as well as written permission from them for you to slap on this license. Thank you. On 23-Sep-08, at 7:45 AM, fireball(a)svn.reactos.org wrote: > + * LICENSE: GPL v2 or later - See COPYING in the top level > directory Best regards, Alex Ionescu

7 9

Re: [ros-dev] Reformat to the kernel coding style.
by chris evans 04 Oct '08

04 Oct '08

Pasting gpl notices in every file of a project, takes up space. better to put in license.txt in project root to encompass all source files. but most that don't like a license will refuse to use it and just copy paste the code anyways, and not say where they got it. (happens all the time). kinda makes me wonder why we got licenses for software in the first place, seems to be silly constructs of obstructionism. GPLv3 don't allow you to control the software that runs on the custom hardware, inability to link to the code with out upsetting the original author. ce From: James Tabor <jimtabor.rosdev(a)gmail.com> To: ReactOS Development List <ros-dev(a)reactos.org> Sent: Saturday, October 4, 2008 12:38:23 AM Subject: Re: Reformat to the kernel coding style. 1st: No to v3! 2nd: No to v3! 3rd: No to v3! On Fri, Oct 3, 2008 at 11:44 PM, Alex Ionescu <ionucu(a)videotron.ca> wrote: > You basically assumed that a header from another file (probably copy- > pasted) applies to the file you modified. > > While I'm certainly being pedantic, and I admit it -- this shouldn't > be a change to brush over. > > Someone needs to figure out if the devs agree with v3 or not -- I

1 0

[ros-diffs] [sginsberg] 36624: - Add missing APIENTRY to ntgdi.h, syscalls are always stdcall.
by James Tabor 02 Oct '08

02 Oct '08

Hi! Something looks wrong with this patch..... >From the latest SDK I have Version 6. __kernel_entry W32KAPI BOOL NtGdiUpdateTransform( __in HDC hdc ); __kernel_entry W32KAPI BOOL NtGdiSetPUMPDOBJ( __in_opt HUMPD humpd, __in BOOL bStoreID, __inout_opt HUMPD *phumpd, __out_opt BOOL *pbWOW64 ); __kernel_entry W32KAPI BOOL NtGdiBRUSHOBJ_DeleteRbrush( __in_opt BRUSHOBJ *pbo, __in_opt BRUSHOBJ *pboB ); __kernel_entry W32KAPI BOOL NtGdiUMPDEngFreeUserMem( __in KERNEL_PVOID *ppv ); Thanks, James

1 0

Re: [ros-dev] [ros-diffs] [hyperion] 36610: modified ke/i386/cpu.c Added CMPXCHG8B enabling/detection code for TransMeta, Centaur and Rise (source: <URL: http://www.geoffchappell.com/notes/windows/kernel/cpu/cx8.htm>). Code dead until each vendor will be officially supported Alex and others: please review
by Aleksey Bragin 01 Oct '08

01 Oct '08

Why wrap into #ifdefs? I thought it's supposed to be runtime, not compile time. WBR, Aleksey. On Oct 1, 2008, at 3:54 PM, hyperion(a)svn.reactos.org wrote: > Author: hyperion > Date: Wed Oct 1 06:54:29 2008 > New Revision: 36610 > > URL: http://svn.reactos.org/svn/reactos?rev=36610&view=rev > Log: > modified ke/i386/cpu.c > Added CMPXCHG8B enabling/detection code for TransMeta, Centaur > and Rise (source: <URL: http://www.geoffchappell.com/notes/windows/ > kernel/cpu/cx8.htm>). Code dead until each vendor will be > officially supported > Alex and others: please review

2 1

CMPXHG8B Support
by Alex Ionescu 01 Oct '08

01 Oct '08

I was asked on IRC to add support for non-Intel and AMD CPUs to the kernel. Obviously I can't do that -- but I mentioned that some special "magic tricks" need to be done to enable support for the instruction on other CPUs, which is why I made the kernel bugcheck. Thankfully, someone documented the steps required, so I won't get in trouble for pointing out this link for you: http://www.geoffchappell.com/notes/windows/kernel/cpu/cx8.htm. I can confirm that's what the kernel does. Do that too, and you can then support Transmeta/Rise/VIA CPUs. Best regards, Alex Ionescu

2 1

Re: [ros-dev] [ros-diffs] [jimtabor] 36596: - Patch by Vincent Povirk, Handle undocumented WM_POPUPSYSTENNEBU message.
by Alex Ionescu 30 Sep '08

30 Sep '08

James, if it's undocumented, please don't add it to the SDK headers. On 29-Sep-08, at 8:27 PM, jimtabor(a)svn.reactos.org wrote: > WM_POPUPSYSTEMMENU Best regards, Alex Ionescu

2 1

Re: [ros-dev] [ros-diffs] [hyperion] 36586: modified dll/win32/kernel32/kernel32.def modified dll/win32/kernel32/kernel32.rbuild added dll/win32/kernel32/misc/icustubs.cpp Export NormalizeString and IsStringNormalized from kernel32.dll. This (finally) makes normaliz.dll (50%) functional. Link kernel32.dll to ICU. Finally. Binary size increased by about 300 KB on a debug build (this is only the beginning). Umpteenth copy of C++ and Win32 stubs required to get ICU to link properly added to kernel32.dll. This
by Aleksey Bragin 29 Sep '08

29 Sep '08

It's going (if not already) to overflow the baseaddress range given to it, thus making ntdll.dll relocated, which leads to obvious problems. WBR, Aleksey. On Sep 29, 2008, at 2:39 AM, hyperion(a)svn.reactos.org wrote: > Author: hyperion > Date: Sun Sep 28 17:39:45 2008 > New Revision: 36586 > > URL: http://svn.reactos.org/svn/reactos?rev=36586&view=rev > Log: > modified dll/win32/kernel32/kernel32.def > modified dll/win32/kernel32/kernel32.rbuild > added dll/win32/kernel32/misc/icustubs.cpp > Export NormalizeString and IsStringNormalized from kernel32.dll. > This (finally) makes normaliz.dll (50%) functional. > Link kernel32.dll to ICU. Finally. Binary size increased by > about 300 KB on a debug build (this is only the beginning). > Umpteenth copy of C++ and Win32 stubs required to get ICU to > link properly added to kernel32.dll. > This commit dedicated to Timo Kreuzer. <3.

1 0

Re: [ros-dev] [ros-diffs] [cgutman] 36580: - Raise IRQL to DISPATCH_LEVEL before using KeAcquireSpinLockAtDpcLevel/KeReleaseSpinLockFromDpcLevel
by Aleksey Bragin 29 Sep '08

29 Sep '08

Is it really supposed to be so? Why don't you just use KeAcquireSpinlock, which would save you the current IRQL level? For me it looks like a hack. WBR, Aleksey Bragin. On Sep 28, 2008, at 11:58 PM, cgutman(a)svn.reactos.org wrote: > Author: cgutman > Date: Sun Sep 28 14:58:09 2008 > New Revision: 36580 > > URL: http://svn.reactos.org/svn/reactos?rev=36580&view=rev > Log: > - Raise IRQL to DISPATCH_LEVEL before using > KeAcquireSpinLockAtDpcLevel/KeReleaseSpinLockFromDpcLevel > > Modified: > branches/aicom-network-fixes/drivers/network/ndis/ndis/protocol.c > > Modified: branches/aicom-network-fixes/drivers/network/ndis/ndis/ > protocol.c > URL: http://svn.reactos.org/svn/reactos/branches/aicom-network- > fixes/drivers/network/ndis/ndis/protocol.c? > rev=36580&r1=36579&r2=36580&view=diff > ====================================================================== > ======== > --- branches/aicom-network-fixes/drivers/network/ndis/ndis/ > protocol.c [iso-8859-1] (original) > +++ branches/aicom-network-fixes/drivers/network/ndis/ndis/ > protocol.c [iso-8859-1] Sun Sep 28 14:58:09 2008 > @@ -67,6 +67,7 @@ > { > UINT BufferedLength; > UINT PacketLength; > + KIRQL OldIrql; > > NDIS_DbgPrint(MAX_TRACE, ("Called.\n")); > > @@ -75,6 +76,8 @@ > #endif > > NdisQueryPacket(Packet, NULL, NULL, NULL, &PacketLength); > + > + KeRaiseIrql(DISPATCH_LEVEL, &OldIrql); > > NDIS_DbgPrint(MAX_TRACE, ("acquiring miniport block lock\n")); > KeAcquireSpinLockAtDpcLevel(&Adapter->NdisMiniportBlock.Lock); > @@ -102,6 +105,8 @@ > Adapter->NdisMiniportBlock.IndicatedPacket > [KeGetCurrentProcessorNumber()] = NULL; > } > KeReleaseSpinLockFromDpcLevel(&Adapter->NdisMiniportBlock.Lock); > + > + KeLowerIrql(OldIrql); > > return STATUS_SUCCESS; > } >

1 0

VFS implementation
by മഹേഷ് മുകുന്ദന് | Mahesh M 27 Sep '08

27 Sep '08

Hi, I am doing a project on "Implementation of VFS in ReactOS". What I am doing is extract the VFS layer from Linux Kernel and create a driver to ROS kernel. I am aware of the Installable FS but I feel that VFS is a better option. I would like to request for suggestions and help on the same. -- Mahesh M Happy hacking... , , / \ ((__-^^-,-^^-__)) `-_---' `---_-' `--|o` 'o|--' \ ` / ): :( :o_o: "-"

3 3

Re: [ros-dev] [ros-diffs] [pschweitzer] 36539: Get rid off recursive FsRtlIsNameInExpression once again. Fix a typo in iterative function that fixes it properly. We now get ReactOS up to 2nd stage with that fix. 2nd stage is broken...
by Aleksey Bragin 27 Sep '08

27 Sep '08

That's probably because FsRtlIsNameInExpression is not really used that much in the 1st stage, but in the 2nd stage it's used to load fonts (*.ttf from the media fonts, resulting in quite a few calls to this FsRtl function). WBR, Aleksey. On Sep 27, 2008, at 12:05 AM, pschweitzer(a)svn.reactos.org wrote: > Author: pschweitzer > Date: Fri Sep 26 14:50:39 2008 > New Revision: 36539 > > URL: http://svn.reactos.org/svn/reactos?rev=36539&view=rev > Log: > Get rid off recursive FsRtlIsNameInExpression once again. > Fix a typo in iterative function that fixes it properly. We now get > ReactOS up to 2nd stage with that fix. 2nd stage is broken...

1 0

Trying to push ideas (again:) )
by Alexandru Lovin 25 Sep '08

25 Sep '08

Hello everyone, Aleksey suggested that I discuss this here, on the mailing list. First and foremost, these are enhancements to do for later, much later (what I would want for the next release is support for RAID / SCSI controllers). But I know that a developer doesn't actually keep something in his plans unless he's figured out a way to do it. I will paste and add additional comments to each of my suggestions. 1. Compatibility with every version of Windows, from Vista until Windows 3.1/ 3.11 That means applications written for 3.1 should work flawlessly on ReactOS, just like apps written for any other Windows. This is probably not hard, as at least XP does the same thing. However, drivers for Windows 3.1 most probably do not work. If the user actually has hardware that was left unsupported since 3.1, he should be able to use it. The same goes for the combination Vista-only driver / old Windows '95 or Windows 3.1 application. oiaohm said it's not really possible because VxD drivers are not well documented. So, maybe in the distant future, maybe when Linux devs will have reversed VxD's on their own. Just don't forget this. 2. Compatibility with DOS** This will probably not mean DOS drivers, as probably any hardware with DOS drivers also has some sort of Windows drivers. It would only mean application compatibility. However, applications with direct access to hardware will probably have to remain used from within DOS (e.g. BIOS update software). The major thing are games here. The ideal way to run DOS games is: - anything requested by the game is interpreted and passed on to the ROS API - Glide commands are interpreted and passed on to OpenGL or Direct3D, resulting in maybe a better image quality, via the use of features OpenGL has and Glide doesn't. - software rendering requested by games should be interpreted and passed on to OpenGL or Direct3D, again resulting in a better image quality. Of course, this will probably result in a compatibility layer, like you suggested. - redbook audio commands should be passed on to ReactOS, who will read in analog mode or digital mode, depending on what the ROS global settings are for that specific optical drive. My own thing about Descent, quickly: the game tries to access file " 1.midi" but ReactOS plays "1.mp3". I have all the mp3's and will provide them whenever needed in order to make this happen. This will transform the old Descent for DOS in the CD version, that had redbook audio tracks. Such enhancements were also created for Tomb Raider 1, by Paul that created Glidos ( www.glidos.net ). Please see http://www.glidos.net/retext.html?lang=en and http://www.glidos.net/audio.html?lang=en Whenever Tomb Raider 1 asked for certain textures / audio data, it was "hijacked" or "redirected" to the better textures or audio files. Certainly, this DOS compatibility layer would probably need a Glidos-like application to control various specific settings from various DOS applications. Another DOS related thing would be a command prompt (terminal?) in ReactOS that has drag'n'drop, copy and paste functionality. Still oiaohm: for the distant future. Got it, understood it, I just want to convince you to keep it in your plans. oiaohm even said a compatibility layer already exists. 3. Processors as a devices, in Device Manager * * For example, let's say a PC has a Pentium 4 at 3 GHz, with HyperThreading. Windows XP reports this processor as two identical ones in Device Manager. ReactOS should also do that. Apart from Windows, if the user does a right-click on a processor as a device, in the Device Manager tree, and chooses the Properties page of the processor device, that page should also mention the SPEED of the processor. More than that, it would be a blessing to also see the L1, L2 and L3 cache size, FSB and multiplier, like those SiSoft Sandra / Everest applications report. Maybe even further, the instruction sets supported - MMX, 3DNow!, SSE, etc. oiaohm again: can be done, but not right now. Stability and usability beat extra information. Got it, too. Bug 2644. 4. Clustering I discussed this with oiaohm and he said it's doable, as soon as ROS gets Active Directory Server. Only clustered in terms of processing power, the user has more machines in a cluster and he still sees ROS the normal way, it just works faster because there are more processors available. No hard drives in some sort of JBOD, and 3D data is only handled by the "master" machine(otherwise you need about 10 GB/sec between machines), the one the user actually interacts with. This is what he said would be the limitations. I have other details for this, but since it's very far away, it wouldn't make sense to bring them up right now. 5. Driver extraction tool I already got one, DoubleDriver, that backs up the drivers for devices in the device manager. I was thinking about the hardware that only gets drivers from Windows Publisher (like my MSI Starkey 2.0). Users would need one. Again, oiaohm said replicating a freeware tool is not high on the list. I'm fine with that. 6. A Windows Media Center equivalent **WMC doesn't do much. Just lists program schedules, can do scheduled recordings, is able to duplicate streams so that you may record whatever you're watching. It stops suddenly while doing a "record once" capture, when it should have waited for the user to say stop (it happened on Vista Home Premium, on a HP laptop). It has a "touchscreen" kind of interface, that would probably be great on an actual touchscreen, works ok when using a PC remote control, but is kind of stupid when using the mouse. It can record from one channel and let you watch another channel if you have at least two TV tuners in your computer. Naturally, ROS should do this with "n" TV tuners. It doesn't have composite or S-video capturing, like the vast majority of TV tuner software out there. It only captures in Microsoft's special "Microsoft recorded TV Show" format, extension .dvr-ms I think (no AVI capture, no mpg capture). It won't let you specify how the tuner provides sound from the antenna/cable signal to the sound card (PCI audio, internal cable, external cable, and if any of the last two, what sound card channel it is). While watching, it should be easier to find out what channel you're on, and what the time is, via some sort of OSD (on-screen display) that appears when you move the mouse or something, just like in WMC. The recording should not be affected by this (i.e. the OSD shouldn't show up on the recording if you moved the mouse, again just like in WMC). While watching, it's not possible (or at least not easy) to jump directly to a specific channel, it may only be used as a TV (next channel, next channel...). If the user tries to switch channels while recording, he gets "warning, you're recording, if you switch channels it's going to stop, you want that?" It should just stop, or at least let the user specify that he doesn't want to see that message again somehow. It doesn't let the user specify exactly the framerate, video size, video standard...just the country of origin. And, as an example, Romaniaofficially uses the PAL D standard on "air" broadcast, that you can get with an antenna. But cable providers use PAL B, which is the German official standard. So, in WMC a guy with cable from Romania must say he's from Germany or else he won't hear anything! All of these should be properly implemented in ReactOS Media Center. Apart from them, "ROSMC" should have all the deinterlacing options and deinterlacing-method autodetection routines from Dscaler. That program also offers a whole lot of other image improvement things, like a good enough TV station logo killer and image de-noising that actually works. Even better than Dscaler, REMEMBER the settings the next time the user runs the program. Maybe also provide the user with basic video editing functionality, meaning most of the features from VirtualDub (the one I find most important is the ability to edit a film with "direct stream copy", meaning it just copies the video and/or audio stream, it doesn't re-encode it. Edit as in cutting parts of the film. In this scenario, the ability to go frame by frame is also very useful). And since it's the Media Center and not the Media Player, this should be the application that rips audio cd's or audio dvd's. Most of all, it should be "cluster-aware." Regardless of ROS being cluster aware or not, this one should be. oiaohm said this is not your job, but a job for other projects. He pointed me to MediaPortal. I e-mailed all of them (Virtualdub, Dscaler and MediaPortal) but I doubt they'll combine the three projects. Still, that's why John User still buys Windows. Linux is all over the Internet (docs all over forums, drivers all over sites, applications all over sites as well). Instead, Linux has "cool" stuff like "mousespedometa" (measures the speed with which you move the mouse). Some people don't even have Internet to get what they need (X servers, for instance). To be a Windows alternative, it should contain a lot of things Windows has. 7. Running on 16-bit systems like 286/386/486 in a "ReactOS Essentials" (equivalent to a stripped-down XP) mode * * It should be the same operating system, but in 16-bit mode only. That's an ideal scenario and I'm sure it cannot be done no matter how good the programmers are. So, what can someone do on a 286 ? Listen to mp3's ? No way. Listen to audio CD's, yes, and hopefully digital playback, too. Watch TV ? Yes, if the user can find an ISA TV tuner (ATI made such tuners, but they required a PCI ATI video card, and if you have PCI why not get a better tuner?). Record TV shows ? Not on that kind of computer. Browse the internet ? That may be possible, with some really outdated, 16-bit browser, like the Internet Explorer for Windows 3.1. And I don't know how many sites will work on it. Play games ? Yes, either old DOS or Windows 3.1 ones or the ones that come with ReactOS, written in 16-bit especially for this mode. Join a hive as either master or slave ? Hopefully it will be possible, but probably in the year 2015 at least. Use office applications ? Sure, if the user can find that last Microsoft Office or maybe Microsoft Works version compatible with Windows 3.1. Run a web server ? I know a guy who had a server running on a 386 system, on Windows 3.11. So yes, it is possible, only I don't know what software he used to actually serve the data. Act as a router ? Again, hopefully. That is, if the entire network is on 10 megabit, because I don't think there are ISA 100 megabit network cards (ISA bandwith is not enough). 2D graphics ? It was possible in Windows 3.1, why not ? Maybe the first Photoshop versions actually were 16-bit. 3D graphics ? The first 3D Studio Max (that is, 3D Studio) was for DOS only. That probably means 16-bit right from the start, and that should mean yes, you can do it, with the DOS compatibility layer. Web design ? If you can find a 16-bit application, yes. A separate ReactOS for 16-bit only, or just all the 16-bit functionality included in the normal ReactOS ? Things look better when it works out of the box, but it's a waste of space to include applications written for 16-bit only. People that really need the 16-bit version will not mind paying extra attention to actually download this one and not the normal one. Besides that, ReactOS is free. And the presence of such a version would mean a selfless devotion to people. An act of charity for real. Allowing people to use their computers and do as many modern things as possible on them. An open source Windows 3.11 with better compatibility and adherence to standards. Compatible with all the 9x and ME. Has been tried in Free Win 95, oiaohm said "dead and staying that way" about it, but maybe VxD documentation and whatever else you would need will appear (or be reverse engineered by someone). Once a bigger effort will be done, the missing info is probably easier to uncover. Those are my suggestions. They are not for now, they are not easy to do, etc. Just don't discard them, please. Alex

10 12

Off-topic: Understanding win32k system calls - help please
by Jeetu Golani 25 Sep '08

25 Sep '08

Hi, First, I'd like to apologize since what I'm asking doesn't directly relate to ReactOS however I'm hoping someone here might be able to shed some light. I've built a rudimentary win32k profiler and I've hooked the win32k SDT and hooked onto the NtUserCreateWindowEx function in the hope of studying values returned by it. I see some strange (to me) values for the x and y coordinates - values such as 1547372 etc. I'm not sure how to interpret these values and convert them into pixel units or traditional coordinate mechanisms. I first thought there must be something wrong with my code however I'm not so sure anymore. Would someone here be able to guide me on how to interpret these values??? Thanks and sorry again Bye for now

3 3

Re: [ros-dev] Trying to push ideas (again:) )
by chris evans 24 Sep '08

24 Sep '08

> > 7. Running on 16-bit systems like 286/386/486 in a "ReactOS Essentials" > > (equivalent to a stripped-down XP) mode * > > It should be the same operating system, but in 16-bit mode only. That's > > an ideal scenario and I'm sure it cannot be done no matter how good the > > programmers are. So, what can someone do on a 286 ? Listen to mp3's ? No Safe Mode. Just load Video, File and network drivers and allow direct access to int13 so fdisk and format can run so user can diag/fix it. Curious if ReactOS has a an Emergency Boot Disk system that it can make ? Perhaps, keep a Freedos 1.44m disk image and allow suer to rawrite it when needed. Or even a dual bootable Freedos partition (FAT16) with the appropriate recovery tools on it. --chris 1-916-410-7677 http://nxdos.sourceforge.net/ http://bbx.flnet.org/ http://teknopup.angelfire.com/

2 1

Re: [ros-dev] [ros-diffs] [sginsberg] 36436: - Attempt satisfy Alex
by Aleksey Bragin 24 Sep '08

24 Sep '08

For consistency, I would think OB, IO, PS and other modules having such tracing system should be turned off by default then too. WBR, Aleksey. On Sep 23, 2008, at 11:54 PM, sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Tue Sep 23 14:54:13 2008 > New Revision: 36436 > > URL: http://svn.reactos.org/svn/reactos?rev=36436&view=rev > Log: > - Attempt to satisfy Alex

1 0

Re: [ros-dev] [ros-diffs] [gedmurphy] 36435: Don't risk a negative array subscript. Fixes our one and only REVERSE_NEGATIVE error Fix for Coverity error CID: 766
by Timo Kreuzer 24 Sep '08

24 Sep '08

For me it looks like you try to trick Coverity here. No real fix, unless you check for (nColor >= 0) gedmurphy(a)svn.reactos.org schrieb: > Author: gedmurphy > Date: Tue Sep 23 14:02:32 2008 > New Revision: 36435 > > URL: http://svn.reactos.org/svn/reactos?rev=36435&view=rev > Log: > Don't risk a negative array subscript. Fixes our one and only REVERSE_NEGATIVE error > Fix for Coverity error CID: 766 > > Modified: > trunk/reactos/dll/cpl/desk/advappdlg.c > > Modified: trunk/reactos/dll/cpl/desk/advappdlg.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/advappdlg.c?r… > ============================================================================== > --- trunk/reactos/dll/cpl/desk/advappdlg.c [iso-8859-1] (original) > +++ trunk/reactos/dll/cpl/desk/advappdlg.c [iso-8859-1] Tue Sep 23 14:02:32 2008 > @@ -23,7 +23,6 @@ > RECT rect; > HBRUSH hbrush; > HWND hwndColorButton; > - COLORREF crColor = g->ThemeAdv.crColor[nColor]; > HGDIOBJ hgdiTmp; > > if (nColor != -1) > @@ -42,7 +41,7 @@ > rect.top = 2; > rect.right = 22; > rect.bottom = 13; > - hbrush = CreateSolidBrush(crColor); > + hbrush = CreateSolidBrush(g->ThemeAdv.crColor[nColor]); > FillRect(hdcCompat, &rect, hbrush); > DeleteObject(hbrush); > > > >

2 1

Re: [ros-dev] [ros-diffs] [sginsberg] 36428: - Add basic tracing to CmpReferenceKeyControlBlock, CmpDereferenceKeyControlBlock and CmpDereferenceKeyControlBlockWithLock
by Alex Ionescu 23 Sep '08

23 Sep '08

Do you think you could maybe turn OFF debugging by default so that not every build gets spammed with this code? On 23-Sep-08, at 10:15 AM, sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Tue Sep 23 09:15:56 2008 > New Revision: 36428 > > URL: http://svn.reactos.org/svn/reactos?rev=36428&view=rev > Log: > - Add basic tracing to CmpReferenceKeyControlBlock, > CmpDereferenceKeyControlBlock and > CmpDereferenceKeyControlBlockWithLock > > Modified: > trunk/reactos/ntoskrnl/config/cmkcbncb.c > > Modified: trunk/reactos/ntoskrnl/config/cmkcbncb.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmkcbncb.c… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/config/cmkcbncb.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/config/cmkcbncb.c [iso-8859-1] Tue Sep 23 > 09:15:56 2008 > @@ -354,6 +354,9 @@ > NTAPI > CmpReferenceKeyControlBlock(IN PCM_KEY_CONTROL_BLOCK Kcb) > { > + CMTRACE(CM_REFERENCE_DEBUG, > + "%s - Referencing KCB: %p\n", __FUNCTION__, Kcb); > + > /* Check if this is the KCB's first reference */ > if (Kcb->RefCount == 0) > { > @@ -570,6 +573,8 @@ > { > LONG OldRefCount, NewRefCount; > ULONG ConvKey; > + CMTRACE(CM_REFERENCE_DEBUG, > + "%s - Dereferencing KCB: %p\n", __FUNCTION__, Kcb); > > /* Get the ref count and update it */ > OldRefCount = *(PLONG)&Kcb->RefCount; > @@ -602,6 +607,9 @@ > CmpDereferenceKeyControlBlockWithLock(IN PCM_KEY_CONTROL_BLOCK Kcb, > IN BOOLEAN LockHeldExclusively) > { > + CMTRACE(CM_REFERENCE_DEBUG, > + "%s - Dereferencing KCB: %p\n", __FUNCTION__, Kcb); > + > /* Sanity check */ > ASSERT_KCB_VALID(Kcb); > > Best regards, Alex Ionescu

2 2

Re: [ros-dev] [ros-diffs] [cwittich] 36368: sync msiexec with wine 1.1.5
by Aleksey Bragin 21 Sep '08

21 Sep '08

I wonder why this A/W mess? WBR, Aleksey. On Sep 21, 2008, at 4:00 PM, cwittich(a)svn.reactos.org wrote: > Author: cwittich > Date: Sun Sep 21 07:00:07 2008 > New Revision: 36368 > > URL: http://svn.reactos.org/svn/reactos?rev=36368&view=rev > Log: > sync msiexec with wine 1.1.5 > > Modified: > trunk/reactos/base/system/msiexec/msiexec.c > trunk/reactos/base/system/msiexec/service.c

2 1

Re: [ros-dev] [ros-diffs] [tkreuzer] 36379: preprocess all spec files
by Aleksey Bragin 21 Sep '08

21 Sep '08

There is a big problem with this change, originally this was added only for "our own" .spec files, which don't have comments starting with #. Wine .spec files have such comments, and thus will be preprocessed incorrectly. WBR, Aleksey. On Sep 21, 2008, at 6:34 PM, tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Sun Sep 21 09:34:48 2008 > New Revision: 36379 > > URL: http://svn.reactos.org/svn/reactos?rev=36379&view=rev > Log: > preprocess all spec files > > Modified: > branches/ros-amd64-bringup/reactos/tools/rbuild/backend/mingw/ > modulehandler.cpp > > Modified: branches/ros-amd64-bringup/reactos/tools/rbuild/backend/ > mingw/modulehandler.cpp > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/ > reactos/tools/rbuild/backend/mingw/modulehandler.cpp? > rev=36379&r1=36378&r2=36379&view=diff

2 2

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev