- Ros-dev - ReactOS.org

RE: [Spam] [ros-diffs] [royce] 13129: added 'first' attribute to <file>
by Casper Hornstrup 19 Jan '05

19 Jan '05

That should be: <file first="yes">multiboot.S</file> or similar. Modified: branches/xmlbuildsystem/reactos/ntoskrnl/ntoskrnl.xml --- branches/xmlbuildsystem/reactos/ntoskrnl/ntoskrnl.xml 2005-01-19 01:11:43 UTC (rev 13128) +++ branches/xmlbuildsystem/reactos/ntoskrnl/ntoskrnl.xml 2005-01-19 01:37:35 UTC (rev 13129) @@ -26,10 +26,10 @@ </output> </invoke> - <directory name="ke">  + <directory name="ke"> <if property="ARCH" value="i386"> <directory name="i386"> - <file>multiboot.S</file>  + <file first>multiboot.S</file> <file>bios.c</file> <file>brkpoint.c</file> <file>bthread.S</file>

1 0

Re: [ros-svn] [hbirr] 13102: - Set the limit of the user mode code/data segment back to 4GB.
by Alex Ionescu 18 Jan '05

18 Jan '05

hbirr(a)svn.reactos.com wrote: >- Set the limit of the user mode code/data segment back to 4GB. > > > >Updated files: >trunk/reactos/ntoskrnl/ke/i386/gdt.c > > > Thanks! Do you know however if any of ROS Kernel depends on the old GDT? There are two weird issues with SYSEXIT: 1) GvG reported that FPU is broken 2) Explorer now crashes in shlwapi when clicking on a disk. Best regards, Alex Ionescu

3 7

RE: [hbirr] 13125: - Fixed the disabling of interrupts on thestack before sysexit.
by Ge van Geldorp 18 Jan '05

18 Jan '05

> From: hbirr(a)svn.reactos.com > > - Fixed the disabling of interrupts on the stack before sysexit. Only good news left: no more fpu crashes. All your base now belong to Hartmut! Gé van Geldorp.

1 0

NtFlushVirtualMemory
by Steven Edwards 18 Jan '05

18 Jan '05

Hi, Can someone have a look at implementing this? I am having good progress getting IE and Office 2k going but this function is marked as unimplemented and the installs will hang there. I could try to stub it out but if someone knows what needs to be implemented I would much rather it be done right rather than just another stub. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Mail - You care about security. So do we. http://promotions.yahoo.com/new_mail

3 2

RE: [ros-dev] 13090: SYSENTER support, INT2E Optimization
by Ge van Geldorp 18 Jan '05

18 Jan '05

The good and the bad news continues... The good news is that Hartmut's change fixed the VMware 4.0.5 problem I had and also fixes some of the floating point problems. The bad news is that it doesn't fix all the fpu problems, I still see a usermode crash in rosperf, always near a fp instruction. Gé van Geldorp.

1 0

foo.exe.local override support
by Steven Edwards 18 Jan '05

18 Jan '05

anyone know what it would take to add foo.exe.local override support? If this was working IE5/6 could get to the install screen. It tries to use the advpack.dll that it ships with during the install and of course it fails because it loads ours. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Mail - Helps protect you from nasty viruses. http://promotions.yahoo.com/new_mail

1 0

RE: 13090: new Syscall Table/Stub generator
by Ge van Geldorp 17 Jan '05

17 Jan '05

> From: ion(a)svn.reactos.com > > Added files: > trunk/reactos/tools/nci/ncitool.c I need to add "#include <malloc.h>" to get ncitool.c to compile on Windows. Adding it doesn't seem to harm Linux compilation. Gé van Geldorp.

2 1

Re: [ros-svn] [ion] 13090: SYSENTER support, INT2E Optimization, new Syscall Table/Stub generator and svn:ignore fixes. Please read associated Mailing List Post.
by Hartmut Birr 17 Jan '05

17 Jan '05

ion(a)svn.reactos.com schrieb: >SYSENTER support, INT2E Optimization, new Syscall Table/Stub generator and svn:ignore fixes. Please read associated Mailing List Post. > > >Updated files: >trunk/reactos/ntoskrnl/ke/i386/gdt.c > > *Modified: trunk/reactos/ntoskrnl/ke/i386/gdt.c* --- trunk/reactos/ntoskrnl/ke/i386/gdt.c 2005-01-17 01:30:26 UTC (rev 13089) +++ trunk/reactos/ntoskrnl/ke/i386/gdt.c 2005-01-17 07:10:34 UTC (rev 13090) @@ -40,10 +40,10 @@ 0x0, 0x0, 0x0, 0x0, /* Null */ 0xffff, 0x0, 0x9a00, 0xcf, /* Kernel CS */ 0xffff, 0x0, 0x9200, 0xcf, /* Kernel DS */ - 0x0, 0x0, 0xfa00, 0xcc, /* User CS */ - 0x0, 0x0, 0xf200, 0xcc, /* User DS */ + 0x0, 0x0, 0xfa00, 0xcf, /* User CS */ + 0x0, 0x0, 0xf200, 0xcf, /* User DS */ 0x0, 0x0, 0x0, 0x0, /* TSS */ - 0x1000, 0x0000, 0x9200, 0xff00, /* PCR */ + 0x1000, 0x0000, 0x9200, 0xffc0, /* PCR */ 0x1000, 0x0, 0xf200, 0x0, /* TEB */ 0x0, 0x0, 0x0, 0x0, /* Reserved */ 0x0, 0x0, 0x0, 0x0, /* LDT */ This changes expand the user mode data/code segment to 4GB. This is wrong. If I change it back to the correct limit, the sysenter support doesn't work. Ros does crash within the first application (smss). See the debug output. - Hartmut ... DriverBase for \SystemRoot\system32\drivers\msfs.sys: dd2fa000 DriverBase for \SystemRoot\system32\drivers\npfs.sys: dd319000 KeBugCheckWithTf at ke/catch.c:193 Bug detected (code 1e param 0 0 0 0) KMODE_EXCEPTION_NOT_HANDLED General Protection Exception: 13(0) Processor: 0 CS:EIP 8:c0003829 <ntoskrnl.exe: 3829 (D:\DOKUME~1\hb\LOKALE~1\Temp/ccG6aaaa.s:33 (_KiSystemService))> cr2 7ffde000 cr3 158dc000 Proc: c06a6598 Pid: 2 <smss.exe> Thrd: c06abca0 Tid: 18 DS 23 ES 23 FS 3b GS 23 EAX: 00000000 EBX: 00000000 ECX: 00000000 EDX: 00000000 EBP: 00000000 ESI: 00000000 ESP: dd34cd58 EDI: 00000000 EFLAGS: 00210202 kESP dd34cd58 kernel stack base dd34a000 Frames: ke/main.c:1043 0xc0003829 -> syscall.S line 270 ------------------------------------------------------------------------

2 2

Build announcements
by Murphy, Ged (Bolton) 17 Jan '05

17 Jan '05

With the question continually arising regarding the binutils issue, would it not be an idea to have an build announcement section on the site where notes can be placed for all to see. A lot of people don't use IRC or read the mailing list, so it might also be useful to keep people updated with the happenings in SVN too. e.g. when accept was committed, current status of USB, etc. Gedi ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

3 3

Re: [ros-svn] [ion] 13090: SYSENTER support, INT2E Optimization, new Syscall Table/Stub generator and svn:ignore fixes. Please read associated Mailing List Post.
by Alex Ionescu 17 Jan '05

17 Jan '05

ion(a)svn.reactos.com wrote: >SYSENTER support, INT2E Optimization, new Syscall Table/Stub generator and svn:ignore fixes. Please read associated Mailing List Post. > > >Added files: >trunk/reactos/tools/nci/ >trunk/reactos/tools/nci/makefile >trunk/reactos/tools/nci/ncitool.c >trunk/reactos/tools/nci/sysfuncs.lst >trunk/reactos/tools/nci/w32ksvc.db > >Updated files: >trunk/reactos/Makefile >trunk/reactos/config >trunk/reactos/include/napi/shared_data.h >trunk/reactos/ntoskrnl/Makefile >trunk/reactos/ntoskrnl/include/internal/i386/ke.h >trunk/reactos/ntoskrnl/include/internal/i386/ps.h >trunk/reactos/ntoskrnl/ke/i386/bthread.S >trunk/reactos/ntoskrnl/ke/i386/exp.c >trunk/reactos/ntoskrnl/ke/i386/gdt.c >trunk/reactos/ntoskrnl/ke/i386/kernel.c >trunk/reactos/ntoskrnl/ke/i386/stkswitch.S >trunk/reactos/ntoskrnl/ke/i386/syscall.S >trunk/reactos/ntoskrnl/ke/i386/usercall.c >trunk/reactos/ntoskrnl/ke/kthread.c >trunk/reactos/ntoskrnl/ke/process.c >trunk/reactos/ntoskrnl/ps/i386/continue.c >trunk/reactos/subsys/system/vmwinst/vmwinst.c > >Deleted files: >trunk/reactos/iface/ > > > First and foremost, I would really like to thank all the people behind the scenes of this patch; Filip Navara, for the initial implementation and thoughts, and his consistent help, Art Yerkes for his invaluable testing, and everyone else who lent a hand (too many people to list here). This patch improves by around 15-20% (tested but not scientific) the speed of ReactOS on all hardware and virtual machines. Furthermore, it improves speed by over 50% (tested but not scientific) on hardware supporting the SYSENTER/SYSEXIT call pair. On VMWare however, due to causes still under investigation, SYSENTER/SYSEXIT must be disabled, or else there is a 3X slowdown. Vmwinst takes care of writing the Windows-compatible Value in the Registry, and it is read before choosing which kind of call to execute. This means that vmware is able to take advantage of the ~20% speedup, but not of all the full capability of this patch. It also combines the previous iface tools into a single, much more dynamic and small utility, which I called NCITool (Native Call Interface Tool). Although it is almost final, I still have to set-up the macros for portability and msvc compatibility, so this is a known issue (note however that the previous version suffered from the same incompatibilies). I will fix it during the week. I would like to thank Emanuelle and KJK::Hyperion for the original tool, and most of the parsing code has remained intact, apart from some code-duplication removal and simplification. The following two issues remain in this patch, which I will look at this week as well: 1) SMP. I have not tested SYSENTER on an SMP machine, and I believe that the MSRs must be written on other CPUs as well, perhaps using an IPI? 2) Pentium Pro. It erronously reports the SEP flag but does not support SYSENTER. Code must be added at the related FIXME in order to check for this. I have, along with others, tested this patch for more then a week now, and I have found no visible problems, apart from the VMWare weirdness. If any problems are noticed due to it, please post accordingly and I will have a look at it. Best regards, Alex Ionescu

3 2

Re: [ros-svn] [gvg] 13073: Implement LOAD_LIBRARY_AS_DATAFILE flag
by Thomas Weidenmueller 16 Jan '05

16 Jan '05

gvg(a)svn.reactos.com wrote: >Implement LOAD_LIBRARY_AS_DATAFILE flag > > > Typecasting PVOID to ULONG isn't portable...ULONG_PTR is supposed to be used. Also BOOLEAN should be prefered over BOOL for internal stuff. Best Regards Thomas

4 5

Data types: compatibility and porting
by Emanuele Aliberti 15 Jan '05

15 Jan '05

Reading the forum, it seems that porting ROS to 64-bit (x86-64) is the most wanted target. Should we begin using (and converting existing code) the new data types MS defined for Win64, to make easy that one and any other future porting effort? Emanuele See also: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winprog/wi… http://msdn.microsoft.com/library/default.asp?url=/library/en-us/win64/win6…

3 2

usb - UHCI, OHCI and EHCI implementations
by Ryan O'Connor 14 Jan '05

14 Jan '05

Hi, This is Polonium from the irc channel (although I’m not in there all the time) Just trying to gather what’s happening with USB support, more specifically the host controller interfaces that are required to lie below the usb device drivers. Is there anyone currently working on this? If not, are there any programmers who would like to solely focus on implementing, for example, a universal host controller interface for ReactOS. While I do not know much about the topic myself, with ample resources and team members I may be able to make a good start. Anyone else interested? The specifications for the interfaces can be found on the Intel website. Regards Ryan O’Connor --- Outgoing mail is certified Virus Free. Checked by AVG anti-virus system (http://www.grisoft.com). Version: 6.0.808 / Virus Database: 550 - Release Date: 12/8/2004

5 5

Re: [ros-svn] [arty] 13014: Added forgotten .h ext2lib.h
by James Tabor 13 Jan '05

13 Jan '05

WOW! arty(a)svn.reactos.com wrote: > Added forgotten .h ext2lib.h > > > > Added files: > branches/ext2/reactos/include/fslib/ext2lib.h > Does this mean we have ext2 support? James

4 3

[PATCH] minor fix for RtlStoreUlong()
by d_layer 13 Jan '05

13 Jan '05

Hi, Attached patch should fix some problems of RtlStoreUlong(). 1) store SECONDBYTE of the value correctly. 2) store a ULONG value but not a ULONG_PTR value. There is RtlStoreUlongPtr() which stores a ULONG_PTR value. http://msdn.microsoft.com/library/en-us/kmarch/hh/kmarch/k109_2dd28516-e8e4… -- d_layer

1 0

Re:Re: [ros-dev] Who want to help a newbie?
by yang 13 Jan '05

13 Jan '05

Thank you for your help.I will ask your question at there. regards, yang > > Hi yang, > come to irc channel, #reactos, there are many people, and some will > definately answer your question. When I'm online, I can try to help you > also. > > > With the best regards, > Aleksey Bragin (aka "Fireball" on irc). >

1 0

Re:Re: [ros-dev] Who want to help a newbie?
by yang 13 Jan '05

13 Jan '05

> Probably you need to practice C a little more ;-) Thank you very much,I will try my best to practice. > > I think this depends a lot on which part of the code you want to read. If you > are trying to understand parts of NTOSKRNL it will be helpful to read at > least the thing about memory management in the IA32 manual. On the other side > if you are looking at our Mesa3D copy, you should probably be good at maths. Now I'm studing about 80x86 assembly. Do you think it work? > > > HTH, > blight regards, yang

1 0

Who want to help a newbie?
by yang 12 Jan '05

12 Jan '05

Hello everyone! I am a newbie, now I am a sophomore. I learn the C programming language last year. And one month ago I found this project, and begin to read the source code last three week. But I found there are to many thing that doesn't mention in my book. I can't undertand the source code. Who want to tell me what I had to study and answer some question as a teacher even if some question may be stupid. Thanks to help a chinese open source software fan. Regards, yang

3 2

Janitorial Task - Get rid of TAG_NONE
by Steven Edwards 12 Jan '05

12 Jan '05

Hi, Royce suggested that we need to get rid of TAG_NONE and I remeber EA posting a list of tags a while back so maybe its a good time to look at the issue again. We have quite a few cases where ExAllocatePool() and ExAllocatePoolWithQuota() is calling ExAllocatePagedPoolWithTag ( TAG_NONE ). I propose that we change the headers for these two functions to throw a compile error if we try to use them internally. We would still keep it implemented to support third party drivers but this way it will force developers to not use them. Thanks Steven __________________________________ Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard. http://promotions.yahoo.com/new_mail

4 3

RE: [ros-svn] [gdalsnes] 12942: -move alert stuff into own file
by Ge van Geldorp 12 Jan '05

12 Jan '05

> From: gdalsnes(a)svn.reactos.com > > -move alert stuff into own file > -only use Thread->Alerted[0]. Alerted[1] is not used. > -misc Building with DBG := 1 I get a compile-time error on ntoskrnl/ps/thread.c line 480: ASSERT(Thread->WaitBlockList == NULL); ps/thread.c: In function `PsUnblockThread': ps/thread.c:480: error: structure has no member named `WaitBlockList' Gé van Geldorp.

3 2

Creative SB! Live audio card - driver loading problem
by Gge 11 Jan '05

11 Jan '05

I have setup the registry for the Audio card "Creative SB! Live " with the audio driver "kx.sys" from www.kxproject.com The driver starts to load but fails to initialize the SB card with the following debug messages Any idea ? Is it possible to implement the function "_audddrvm" in ntoskrnl ? --------------------------------------------------------------------- DriverBase for \SystemRoot\system32\drivers\kx.sys: dce72000 DriverBase for \SystemRoot\system32\drivers\portcls.sys: dcf2f000 (ldr/loader.c:1476) LdrPEGetExportByName(): failed to find _aulldvrm (ldr/loader.c:1561) Failed to import _aulldvrm from ntoskrnl.exe (ldr/loader.c:373) Could not process module (ldr/loader.c:319) Could not open module file: \SystemRoot\system32\portcls.sys (ldr/loader.c:1323) Unknown import module: portcls.sys (Status c0000034) (ldr/loader.c:373) Could not process module (io/pnpmgr.c:1518) Initialization of service emu10kx failed (Status c0000034) (io/pnpmgr.c:1452) IopActionInitChildServices(ccc26b60, ccc48ef8, 0) ---------------------------------------------------------------------- Best regards Gerard

3 3

Add French translation for timedate.cpl
by Sylvain Petreolle 10 Jan '05

10 Jan '05

Add French translation for timedate.cpl Please find patch attched. ===== Sylvain Petreolle (spetreolle_at_users.sourceforge.net) humans are like computers, yesterday the BIOS was all - today its just a word

1 0

ROS crashes after splash screen
by Murphy, Ged (Bolton) 10 Jan '05

10 Jan '05

When installing ROS (0.2.5 & svn) on an old PII machine I have (real hardware), the initial install goes smoothly, machine reboots, splash screen flashes up and then it hangs on the blue screen just before configuration. Viewing in debug mode, I get masses of text streaming up the screen, much to fast to read. After around 10 seconds or so the machine reboots. I've attached the debug log in the hope someone can figure out what's happening. (you can see what I mean by the 'masses of text') There seems to be quite a few strange messages in there. I have had older versions of 0.2.4 installed on this machine before. Thanks, Gedi ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

3 2

Re: [ros-svn] [frik85] 12909: 8 german language files (update)
by Steven Edwards 09 Jan '05

09 Jan '05

--- frik85(a)svn.reactos.com wrote: > trunk/reactos/lib/shell32/shell32_De.rc > trunk/reactos/lib/winmm/winmm_De.rc > trunk/reactos/subsys/system/taskmgr/De.rc Please send these changes to wine-patches as well so they wont get lost on the next merge. Thanks Steven __________________________________ Do you Yahoo!? All your favorites on one personal page � Try My Yahoo! http://my.yahoo.com

1 0

[ros-dev] Thankyou everybody, but still i dont manage to compile it.
by Lucio Diaz 09 Jan '05

09 Jan '05

--- ros-dev-request(a)reactos.com escribió: > Send Ros-dev mailing list submissions to > ros-dev(a)reactos.com > > To subscribe or unsubscribe via the World Wide Web, > visit > http://reactos.com:8080/mailman/listinfo/ros-dev > or, via email, send a message with subject or body > 'help' to > ros-dev-request(a)reactos.com > > You can reach the person managing the list at > ros-dev-owner(a)reactos.com > > When replying, please edit your Subject line so it > is more specific > than "Re: Contents of Ros-dev digest..." > > > Today's Topics: > > 1. Re: Anyone to help a newbie? (Anich Gregor) > 2. RE: Application Regression (vim.exe) (Ge van > Geldorp) > 3. tickcount (David Kredba) > 4. RE: [ros-svn] [hyperion] 12838: honor > __USE_W32API > (Ge van Geldorp) > 5. Creative SB Live audio card : Driver loading > fails (Gge) > 6. Re: Application Regression (vim.exe) > (WaxDragon) > 7. Wine I/O Manager for Kernel Services (Brad > DeMorrow) > 8. /nt Removal Patch (Alex Ionescu) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Wed, 5 Jan 2005 15:14:28 +0100 > From: Anich Gregor <blight(a)blight.eu.org> > Subject: Re: [ros-dev] Anyone to help a newbie? > To: ros-dev(a)reactos.com > Message-ID: > <200501051514.28630.blight(a)blight.eu.org> > Content-Type: text/plain; charset="iso-8859-1" > > On Wednesday 05 January 2005 00:44, Lucio Diaz > wrote: > > I installed the SVN and could make it work, i > > downloaded MinGW-3.1.0-1.exe ,gcc-core 3.3.3 , > gcc-g++ > > 3.3.3 and nasm-0.98-win32.zip Installed them and > set > > the path. > > > > > > i tried to build ReactOs (at the reactos folder) > with > > make (I did previously a make clean) > > > > And i get the following error: > > > > Compiling arch/i386/i386rt > > l > > cc1.exe: unrecognized option > > `-fno-zero-initialized-in-bss' > > make[2]: *** [arch/i386/i386rtl.o] Error 1 > > make[1]: *** [all] Error 2 > > make: *** [freeldr] Error 2 > > > > C:\Internet\ReactOS\Subersion\trunk\reactos> > > What's the output of gcc -dumpversion? Are you sure > you have 3.3.3 installed? > > > > > ------------------------------------------------ > > > > > > Nevertheless i try to make install and get the > > following error: > > > > make[1]: *** No rule to make target > > `../../dk/w32/lib/libvfatlib.a', needed by ` > > fmifs.nostrip.dll'. Stop. > > make: *** [fmifs_install] Error 2 > > > > C:\Internet\ReactOS\Subersion\trunk\reactos> > > > > This happend because "make install" doesnt do the > same as "make && make > install" - you have to "make" once for things like > dk/w32/lib/libvfatlib.a to > be built. > > > > > I dont know what i am making wrong, any idea? > > > > > > Thanks in advance and my best wishes for 2005. > > - blight > > ------------------------------ Thankyou for your help, i was using "make", geting the error and then trying to "make install" (of course getting another error). Once i did -dumpversion i realized i had the version 3.2.3 (even if the ziped files stated 3.3.3 a typo i supouse) so i updated to 3.4.2 Again i tried "make"... and then i ran out of memory somewere with rosrtl I set the virtual memory up to 2Gigas... Then i went further and got an error about not finding cc1 where it belongs...so i put (and all the files in that folder)it where gcc was searching for them. Now i can avance further, but even making a "make clean" and going with "make" again i get stuck with cc1.exe Now gcc fings it, but it gives an error about not understanding some comand or argument: rosrtl: [DEPENDS] thread/.create.d rosrtl: [DEPENDS] misc/.intrlck.d gcc: installation problem, cannot exec `C:\Internet\ReactOS\Subersion\MinGW\bin\ ..\libexec\gcc\mingw32\3.4.2\cc1.exe': Invalid argument rosrtl: [DEPENDS] misc/.devmode.d gcc: installation problem, cannot exec `C:\Internet\ReactOS\Subersion\MinGW\bin\ ..\libexec\gcc\mingw32\3.4.2\cc1.exe': Invalid argument rosrtl: [DEPENDS] thread/i386/.context.d gcc: installation problem, cannot exec `C:\Internet\ReactOS\Subersion\MinGW\bin\ ..\libexec\gcc\mingw32\3.4.2\cc1.exe': Invalid argument rosrtl: [DEPENDS] thread/.linearstack.d gcc: installation problem, cannot exec `C:\Internet\ReactOS\Subersion\MinGW\bin\ ..\libexec\gcc\mingw32\3.4.2\cc1.exe': Invalid argument rosrtl: [DEPENDS] thread/.priv.d rosrtl: [DEPENDS] thread/.stack.d rosrtl: [DEPENDS] thread/.exit.d rosrtl: [DEPENDS] thread/.create.d gcc: installation problem, cannot exec `C:\Internet\ReactOS\Subersion\MinGW\bin\ ..\libexec\gcc\mingw32\3.4.2\cc1.exe': Invalid argument rosrtl: [DEPENDS] thread/.priv.d gcc: installation problem, cannot exec `C:\Internet\ReactOS\Subersion\MinGW\bin\ ..\libexec\gcc\mingw32\3.4.2\cc1.exe': Invalid argument El sistema no puede ejecutar el programa especificado. make[1]: *** [thread/.priv.d] Error 255 make: *** [rosrtl] Error 2 The cc1.exe states its version is 3.4.2.I have also updated the SVN tree a few times with the same problem.I dont know where is the problem, please help, i cant imagine what i am doing wrong. Thanks all for your help and good luck. ______________________________________________ Renovamos el Correo Yahoo!: ¡250 MB GRATIS! Nuevos servicios, más seguridad http://correo.yahoo.es

1 0

RE: [ros-svn] [gvg] 12895: Include COFF symbols in our .sym files
by Ge van Geldorp 09 Jan '05

09 Jan '05

> From: gvg(a)svn.reactos.com > > Include COFF symbols in our .sym files Since this changes the layout of the .sym files (header becomes bigger) this will unfortunately require a clean make if you're using .sym files. Gé van Geldorp.

1 0

RE: [ros-diffs] [mf] 12852: migrate substitution keywords to SVN
by Casper Hornstrup 07 Jan '05

07 Jan '05

Can't we remove them from the files where they are not compiled into ReactOS? Or at least add them to all files and make it a rule that they should always be there? Casper ________________________________ From: ros-diffs-bounces(a)reactos.com [mailto:ros-diffs-bounces@reactos.com <mailto:ros-diffs-bounces@reactos.com> ] On Behalf Of mf(a)svn.reactos.com Sent: 6. januar 2005 15:02 To: ros-diffs(a)reactos.com Subject: [ros-diffs] [mf] 12852: migrate substitution keywords to SVN migrate substitution keywords to SVN Modified: trunk/reactos/apps/Makefile

2 1

Samba anyone
by sly i 07 Jan '05

07 Jan '05

Hi, Has one tried getting the samba client working? As strangely there is a win32 port on the web??? http://leenux.org.uk/lpackham/smbclient/ slyi

3 3

RE: [ros-dev] explorer build failure
by Murphy, Ged (Bolton) 07 Jan '05

07 Jan '05

I hadn't noticed that. That's strange though as I'm using 3.4.2. Not sure whets happened there, I'll rebuild my build environment tonight and go from there. Thanks. -----Original Message----- From: Ge van Geldorp [mailto:gvg@reactos.com] Sent: 07 January 2005 09:47 To: 'ReactOS Development List' Subject: RE: [ros-dev] explorer build failure > From: Murphy, Ged (Bolton) > > E:/reactos/build/MinGW/include/c++/3.2.3/bits/stl_map.h:225: Wrong gcc/g++ version, you need at least 3.3.1 Gé van Geldorp. _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

2 1

explorer build failure
by Murphy, Ged (Bolton) 07 Jan '05

07 Jan '05

Hi all, I haven't tried building for a while and after installing SVN last night I thought it a good a time as any. This was last night so I'm guessing it was build 12857 Upon reaching explorer it tries to generate the depends but is failing as shown <--snip--> cmd: [LD] cmd.exe cmd.exe was successfully built. explorer: [DEPENDS] utility/.xmlstorage.d cc1plus: unrecognized option `-E' explorer: [DEPENDS] utility/.shellbrowserimpl.d cc1plus: unrecognized option `-E' explorer: [DEPENDS] utility/.dragdropimpl.d cc1plus: unrecognized option `-E' explorer: [DEPENDS] utility/.window.d </--snip--> This then continues for all resulting in massive failure upon building <--snip--> E:/reactos/build/MinGW/include/c++/3.2.3/bits/stl_map.h:225: instantiated from `_Tp& std::map<_Key, _Tp, _Compare, _Alloc>::operator[](const _Key&) [with _Key = String, _Tp = ICON_ID, _Compare = std::less<String>, _Alloc = std::allocator< std::pair<const String, ICON_ID> >]' explorer.cpp:398: instantiated from here E:/reactos/build/MinGW/include/c++/3.2.3/bits/stl_pair.h:88: invalid use of undefined type `struct String' utility/utility.h:737: forward declaration of `struct String' mingw32-make[1]: *** [explorer.o] Error 1 mingw32-make: *** [explorer] Error 2 E:\reactos\source\trunk\reactos> </--snip--> so I manually checked cc1plus with the -E option: E:\reactos\source\trunk\reactos>cc1plus -E cc1plus: unrecognized option `-E' A quick search through the help showed that no -E existed for cc1plus: E:\reactos\source\trunk\reactos>cc1plus --help | grep -e -E E:\reactos\source\trunk\reactos> Does anyone have any ideas what is happening here?? I've attached the full log as it was too big to paste here. <<exp_fail.txt>> Thanks, Gedi ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

2 1

[ros-dev] Re: [ros-svn] [ion] 12862: Remove /nt directory, part two.
by Alex Ionescu 07 Jan '05

07 Jan '05

ion(a)svn.reactos.com wrote: >Remove /nt directory, > > > I should've placed zw.c in /ex, rather then in ke, since it's a much more correct place. I'll make the change tomorrow morning (it's 2am). Best regards, Alex Ionescu

1 0

apps/utils/net/ftp svnignore
by Alex Ionescu 07 Jan '05

07 Jan '05

Hi, Please add .sym, .map, .exe, etc to svnignore for apps/utils/net/ftp. Best regards, Alex Ionescu

1 0

Creative SB Live audio card : Driver loading fails
by Gge 06 Jan '05

06 Jan '05

Hello, I setup the audio card using the existing registry + snblst.sys + snblst.dll from NT The driver intialisation fails as per debug messages below , with a Ros build from current SVN ? Any idea/suggestion ? -------------------------------------------------------------- DriverBase for \SystemRoot\system32\drivers\beep.sys: dcefc000 DriverBase for \SystemRoot\system32\drivers\sndblst.sys: dcf11000 (cm/ntfunc.c:243) NtDeleteKey(KeyHandle 48) called (cm/ntfunc.c:280) PointerCount 1 (io/resource.c:721) IoReportResourceUsage is unimplemented (io/resource.c:721) IoReportResourceUsage is unimplemented --------------------------------------------------------------- Regards Gerard

2 3

feature request - ros-svn mailing list
by Steven Edwards 06 Jan '05

06 Jan '05

Hi, How hard would it be to add the url pointing to the diff for each commit message? I don't want to have to subscribe to another mailing list or have to go hunting in websvn if I want to view the diff of a svn commit. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Mail - now with 250MB free storage. Learn more. http://info.mail.yahoo.com/mail_250

1 0

Shutdown order error?
by Mike Nordell 06 Jan '05

06 Jan '05

After starting up Shell=Explorer and crashing the seemingly not-enough-(P)SEH-using Explorer (trying to view the RPC Control branch of the NT Objects namespace is a sure way), I get the following. Disregarding the crashing Explorer that I only included for completeness, could this be related to the recent work of having a separate thread doing the shutdown? (KERNEL32:except/except.c:132) Unhandled exception (KERNEL32:except/except.c:133) Address: (KERNEL32:except/except.c:136) 44a912 C:\ReactOS\explorer.exe CS:EIP 1b:44a912 DS 23 ES 23 FS 3b GS 23 EAX: 00000000 EBX: 000001dc ECX: 007af1fa EDX: 00000250 EBP: 007ae448 ESI: 007afb1c ESP: 007ae440 EDI: 007afa78 EFLAGS: 00000202 (KERNEL32:except/except.c:139) Frames: (KERNEL32:except/except.c:147) 421b2c C:\ReactOS\explorer.exe (KERNEL32:except/except.c:147) 40f5cc C:\ReactOS\explorer.exe (KERNEL32:except/except.c:147) 4170b4 C:\ReactOS\explorer.exe (KERNEL32:except/except.c:147) 415871 C:\ReactOS\explorer.exe (KERNEL32:except/except.c:147) 416c86 C:\ReactOS\explorer.exe (KERNEL32:except/except.c:147) 44ffb5 C:\ReactOS\explorer.exe (KERNEL32:except/except.c:147) 77e71ef4 C:\ReactOS\system32\user32.dll (KERNEL32:except/except.c:147) 77e72833 C:\ReactOS\system32\user32.dll (KERNEL32:except/except.c:147) 77ea5934 C:\ReactOS\system32\user32.dll (KERNEL32:except/except.c:147) 77ea7604 C:\ReactOS\system32\user32.dll (KERNEL32:except/except.c:147) 77ea7839 C:\ReactOS\system32\user32.dll (KERNEL32:except/except.c:147) 77e71ef4 C:\ReactOS\system32\user32.dll (KERNEL32:except/except.c:147) 77e72059 C:\ReactOS\system32\user32.dll (KERNEL32:except/except.c:147) 450459 C:\ReactOS\explorer.exe (KERNEL32:except/except.c:147) 422e9d C:\ReactOS\explorer.exe (KERNEL32:except/except.c:147) 450404 C:\ReactOS\explorer.exe (KERNEL32:except/except.c:147) 77e71ef4 C:\ReactOS\system32\user32.dll (KERNEL32:except/except.c:147) 77e72152 C:\ReactOS\system32\user32.dll (KERNEL32:except/except.c:147) 4518b5 C:\ReactOS\explorer.exe (KERNEL32:except/except.c:147) 40447b C:\ReactOS\explorer.exe (KERNEL32:except/except.c:147) 404bcd C:\ReactOS\explorer.exe (KERNEL32:except/except.c:147) 40460c C:\ReactOS\explorer.exe (KERNEL32:except/except.c:147) 40120d C:\ReactOS\explorer.exe (KERNEL32:except/except.c:147) 401258 C:\ReactOS\explorer.exe (KERNEL32:except/except.c:147) 7c8279c1 C:\ReactOS\system32\kernel32.dll (ntuser/class.c:114) Failed to lookup class atom! (ntuser/class.c:114) Failed to lookup class atom! (ntuser/class.c:114) Failed to lookup class atom! (ntuser/class.c:114) Failed to lookup class atom! (ntuser/class.c:114) Failed to lookup class atom! (ntuser/class.c:114) Failed to lookup class atom! (smss.c:90) SM: NtWaitForMultipleObjects failed! (ke/error.c:51) Hard error c000021a (api/wapi.c:175) CSR: NtListenPort() failed (ke/catch.c:149) Unhandled UserMode exc(api/wapi.c:120) CSR: NtReplyWaitReceivePort failed eption, terminating thread (api/wapi.c:120) CSR: NtReplyWaitReceivePort failed (api/wapi.c:120) CSR: Nt(api/wapi.c:120) CSR: NtReplyWaitReceivePort failed ReplyWaitReceivePort failed ex/power.c:91 -- /Mike

2 1

Wine I/O Manager for Kernel Services
by Brad DeMorrow 06 Jan '05

06 Jan '05

Safedisc installs a kernel service called secdrv.sys. As wine is a user-space only implementation of the win32 API, we need to implement part of the windows kernel API (ntoskrnl.exe) in user-space, and emulate what can't be implemented. Our biggest problem is the I/O Manager. The kernel services is started by StartService, which currently only supports user-space services. We need to understand how kernel services work in windows to fix that. When a kernel service is started, it's DriverEntry routine is called with a DRIVER_OBJECT. In which thread does that happen ? Is a new kernel thread started for that ? Can DriverEntry block or must it return immediately ? If it can block, can the driver dispatch routines be called before it returns ? When it returns, if it has been started in a new kernel thread, what happens to the thread ? In which thread do the dispatch routines run when they are called from user-space ? The MSDN documentation is not very clear about all that. I suppose it hasn't been written with windows cloners in mind :-)

3 2

Application Regression (vim.exe)
by WaxDragon 06 Jan '05

06 Jan '05

Devs, I installed the win32 vim package from vim.org back around 0.2.3-0.2.4, and was quite surprised when the console vim.exe mostly worked. Recently, while testing PuTTY, I tried the command line tools (psftp specifically) and they would not accept input. I could ^C out of it and then all the input I had typed showed up on the command line. So, I tried the console vim again and it doesn't accept input also. I checked both vim.exe and the command line putty tools under 0.2.4 and 0.2.5-rc2, and they both work, so it is something after the 0.2.5 branch. I'm reporting this to the ML because I'm not very familiar with the console code. Any ideas or pointers would be appreciated. Andy -- The cheese stands alone.

4 7

RE: [ros-svn] [hyperion] 12838: honor __USE_W32API
by Ge van Geldorp 06 Jan '05

06 Jan '05

> From: hyperion(a)svn.reactos.com > > honor __USE_W32API > > > Updated files: > trunk/reactos/include/tchar.h I made the same change about half a year ago, but it turns out that it breaks compilation on Linux. Gé van Geldorp.

2 1

/nt Removal Patch
by Alex Ionescu 06 Jan '05

06 Jan '05

Hi, Most of the developers I've talked to (including myself) want to get rid of the /nt directory, since it is architecturally incorrect and should instead be migrated into other parts of the kernel. Since the nt functions that were in the directory were part of the Executive (note the ExXXXObjectType), I've placed the functions in \ex, and renamed all Ntp stuff by Exp, with the exception of some LPC stuff which I've renamed from Ni to Lpcp. profiles were harder, since both the Executive and Kernel parts were in the nt file (actually we're not implementing the Executive part properly imo, we don't even have EPROFILE, but that's another story). Anyways, attached is the patch so you can see what was changed and where it was displaced. I don't think anyone wants to keep the /nt directory, based on previous discussions, but I want to make sure people will be aware of it. Best regards, Alex Ionescu

1 1

tickcount
by David Kredba 05 Jan '05

05 Jan '05

Hello, I got this while compiling svn tree with DBG=1, gcc-3.4.1 : mingw32-gcc -Wall -Werror -D__USE_W32API -I. -I../../../include -I../../../w32api/include -pipe -march=i486 -D_M_IX86 -g -c tickcount.c -o tickcount.o tickcount.c: In function `parse_print': tickcount.c:143: warning: implicit declaration of function `_ttoi64' Thanks, David

1 0

Anyone to help a newbie?
by Lucio Diaz 05 Jan '05

05 Jan '05

I installed the SVN and could make it work, i downloaded MinGW-3.1.0-1.exe ,gcc-core 3.3.3 , gcc-g++ 3.3.3 and nasm-0.98-win32.zip Installed them and set the path. i tried to build ReactOs (at the reactos folder) with make (I did previously a make clean) And i get the following error: ----------------------------------------------- ...win32k: [DLLTOOL] libwin32k.a win32csr: [DLLTOOL] libwin32csr.a notifyhook: [DLLTOOL] libnotifyhook.a regtests: [DLLTOOL] libregtests.a ===================================================== Compiling deptool ===================================================== Compiling bin2c Tools are up to date. Tools are up to date. ===================================================== Assembling dosmbr ===================================================== Assembling fat ===================================================== Assembling fat32 ===================================================== Assembling isoboot ===================================================== Assembling ext2 ===================================================== Assembling arch/i386/fathe lp ===================================================== Assembling arch/i386/arch ===================================================== Assembling arch/i386/i386i dt ===================================================== Assembling arch/i386/i386t rap ===================================================== Assembling arch/i386/i386c pu ===================================================== Assembling arch/i386/i386p np ===================================================== Assembling arch/i386/boot ===================================================== Assembling arch/i386/linux ===================================================== Assembling arch/i386/mb ===================================================== Compiling arch/i386/i386rt l cc1.exe: unrecognized option `-fno-zero-initialized-in-bss' make[2]: *** [arch/i386/i386rtl.o] Error 1 make[1]: *** [all] Error 2 make: *** [freeldr] Error 2 C:\Internet\ReactOS\Subersion\trunk\reactos> ------------------------------------------------ Nevertheless i try to make install and get the following error: --------------------------------------- expat: [OBJDUMP] expat.map expat: [LD] expat.dll expat.dll was successfully built. expat: [INSTALL] expat.dll to system32/expat.dll fmifs: [DEPENDS] .media.d fmifs: [DEPENDS] .label.d fmifs: [DEPENDS] .init.d fmifs: [DEPENDS] .format.d fmifs: [DEPENDS] .extend.d fmifs: [DEPENDS] .diskcopy.d fmifs: [DEPENDS] .compress.d fmifs: [DEPENDS] .chkdsk.d fmifs: [RC] fmifs.rc fmifs: [CC] chkdsk.c fmifs: [CC] compress.c fmifs: [CC] diskcopy.c fmifs: [CC] extend.c fmifs: [CC] format.c fmifs: [CC] init.c fmifs: [CC] label.c fmifs: [CC] media.c fmifs: [AR] fmifs.a make[1]: *** No rule to make target `../../dk/w32/lib/libvfatlib.a', needed by ` fmifs.nostrip.dll'. Stop. make: *** [fmifs_install] Error 2 C:\Internet\ReactOS\Subersion\trunk\reactos> --------------------------------------------------- I dont know what i am making wrong, any idea? Thanks in advance and my best wishes for 2005. ______________________________________________ Renovamos el Correo Yahoo!: ¡250 MB GRATIS! Nuevos servicios, más seguridad http://correo.yahoo.es

2 1

Need someone to upload patch for me
by Neil Blackburn 05 Jan '05

05 Jan '05

Fixed a few spelling mistakes The patch is in attachment. Thank You!

2 1

[PATCH] Fix LUID constants
by Nedko Arnaudov 05 Jan '05

05 Jan '05

The attached patch fixes "warnings + -Werror = not compile" for rosapps/tests/tokentest/tokentest.c tokentest.c: In function `CreateInitialSystemToken': tokentest.c:359: warning: braces around scalar initializer tokentest.c:359: warning: (near initialization for `authId.LowPart') tokentest.c:359: warning: excess elements in scalar initializer tokentest.c:359: warning: (near initialization for `authId.LowPart') I think SYSTEM_LUID and similar macros for initial values are intended as initializers of LUID variables, not LARGE_INTEGER ones. I've posted this (and not commited it myself) because I can be missing something important. Is there other issue with LUID <-> LARGE_INTEGER ? <#secure method=pgpmime mode=sign> -- Nedko Arnaudov <GnuPG KeyID: DE1716B0>

1 0

Re:Re: [ros-dev] Re: [ros-diffs] [ion] 12774: Add more Critical Section
by yang 05 Jan '05

05 Jan '05

Alex Ionescu wrote: > > > > Well, yes, win32. I've been setup before, but I haven't > > kept up with the tool chain. > > > > Do we still need the djcc stuff for building freeloader? > > > > What would be really cool was an MSI that would get me > > a complete 'ReactoOS' build environment in one simple > > step. Maybe I'll look into it. > > I'm currently working on this exact project! I'm a newbie. I'm looking for it. Can you tell me something about it?? Thanks. yang ___________________ Come from China

1 0

Re: [ros-diffs] [ion] 12774: Add more Critical Section Debug Data and fix two bugs.
by Joseph Galbraith 05 Jan '05

05 Jan '05

ion(a)svn.reactos.com wrote: > + DPRINT("Waiting on Critical Section: %x\n", CriticalSection); > + if (CriticalSection->DebugInfo) CriticalSection->DebugInfo->EntryCount++; I'm just reading the diffs here, so I could be way off, but shouldn't this use an InterlockedIncrement... otherwise you could get a context switch between in the middle of your increment to another threading attempting to lock the critical section. It is just debug information, but still... Also, looking at the rest of the code, I notice that spin count doesn't appear to be implemented. I don't have a build environment even setup, so take the attached patch with a grain of salt. The changes in RtlpCreateCriticalSEctionSem() are because the InterlockCompareExchangePointer() should already have written the new event into the data structure. Maybe on day I'll manage to get my build environment setup again. - Joseph Index: C:/Users/galb/ReactOS/reactos/lib/ntdll/rtl/critical.c =================================================================== --- C:/Users/galb/ReactOS/reactos/lib/ntdll/rtl/critical.c (revision 12774) +++ C:/Users/galb/ReactOS/reactos/lib/ntdll/rtl/critical.c (working copy) @@ -133,7 +133,17 @@ { HANDLE Thread = (HANDLE)NtCurrentTeb()->Cid.UniqueThread; - /* Try to Lock it */ + /* Try for SpinCount times to Lock it */ + for(LONG i = 0; i < CriticalSection->SpinCount; i++) + { + if ( RtlTryEnterCriticalSection(CriticalSection) ) + return STATUS_SUCCESS; + } + + /* + * Still didn't get it; we have to bump the LockCount, which + * might get it for us, and then wait + */ if (InterlockedIncrement(&CriticalSection->LockCount)) { /* @@ -398,12 +408,12 @@ /* Increase the Debug Entry count */ DPRINT("Waiting on Critical Section: %x\n", CriticalSection); - if (CriticalSection->DebugInfo) CriticalSection->DebugInfo->EntryCount++; + if (CriticalSection->DebugInfo) InterlockedIncrement(&CriticalSection->DebugInfo->EntryCount); for (;;) { /* Increase the number of times we've had contention */ - if (CriticalSection->DebugInfo) CriticalSection->DebugInfo->ContentionCount++; + if (CriticalSection->DebugInfo) InterlockedIncrement(&CriticalSection->DebugInfo->ContentionCount); /* Wait on the Event */ DPRINT("Waiting on Event: %x\n", CriticalSection->LockSemaphore); @@ -523,21 +533,14 @@ return; } - if (!(hEvent = InterlockedCompareExchangePointer((PVOID*)&CriticalSection->LockSemaphore, - (PVOID)hNewEvent, - 0))) { - - /* We created a new event succesffuly */ - hEvent = hNewEvent; - } else { - - /* Some just created an event */ - DPRINT("Closing already created event!\n"); - NtClose(hNewEvent); + + if ( InterlockedCompareExchangePointer((PVOID*)&CriticalSection->LockSemaphore, + (PVOID)hNewEvent, + 0)) != 0) { + /* Someone else just created the event */ + NtClose(hNewEvent); } - - /* Set either the new or the old */ - CriticalSection->LockSemaphore = hEvent; + DPRINT("Event set!\n"); }

4 7

PSID -> PISID and /rtl /ntoskrnl/se duplication.
by Alex Ionescu 04 Jan '05

04 Jan '05

Hi, Attached is a patch with uses the proper PSID/PISID types. Also, I've noticed that we currently have duplicated code between /lib/rtl and /ntoskrnl/se. The removals are also in this patch. Is it OK to remove them, or is there some reason they must be duplicated? Best regards, Alex Ionescu

1 0

I need help to build reactos to develop reactos.
by yang 04 Jan '05

04 Jan '05

Hi I am a new comer. I began to read codes a few days ago, now I installed reactos 0.2.4 in vmware, but it can't do any thing even if I want to copy a file(both command line and GUI), when I do this in GUI, it show me a blue face or do nothing. what do you make up your reactos develop system? It means read, edit, and compile code in reactos. I was on win 32, which emulater is better to run reactos on it? any idea would be appreciated.

2 1

object types (was [ros-svn] [ion] 12748: Fix incorrect LPC Object ...)
by Hartmut Birr 04 Jan '05

04 Jan '05

Hi, I've add the following line to my test driver: extern __attribute__((dllimport)) POBJECT_TYPE* ExEventObjectType; DbgPrint("%x %x %x %x\n", ExEventObjectType, *(PULONG)ExEventObjectType, MmGetSystemRoutineAddress(&NameU), *(PULONG)MmGetSystemRoutineAddress(&NameU)); Running on W2K, I get this result: GCC: 81ebd540 81ebd440 8047a888 81ebd540 MSVC: 8047a888 81ebd540 8047a888 81ebd540 Running on ROS: GCC: c0692ef8 54545645 c00e0760 c0692ef8 MSVC: c00e0760 c0692ef8 c00e0760 c0692ef8 It seems that GCC and MSVC does handle imported data symbols different. In MSVC is an imported data symbol a pointer to the variable and in GCC the value of the variable. - Hartmut

5 4

Re: 12775: don't pass vector<pointer> by value unless you are looking for trouble, also fixed Assert() to take stdargs to make it's usage simpler and less error-prone. Also fixed IsTrue(), etc, to take file and line info by args and created macros to pass that info automatically.
by Royce Mitchell III 04 Jan '05

04 Jan '05

royce(a)svn.reactos.com wrote: >don't pass vector<pointer> by value unless you are looking for trouble, also fixed Assert() to take stdargs to make it's usage simpler and less error-prone. Also fixed IsTrue(), etc, to take file and line info by args and created macros to pass that info automatically. > > > Casper, I made some changes to Assert() and the code that calls it, in the hope that this is what you really wanted. I apologize sincerely if you had wanted to do something else with message[], but if you do, I think it would be easier to do so from within Assert(). I will revert that part of this patch if you needed the buffer in Assert()'s callers.

1 0

Re:[ros-svn] [ion] 12748: Fix incorrect LPC Object export...we export pointers not the object itself! Also remove more TIME stuf
by ea＠iol.it 04 Jan '05

04 Jan '05

> Fix incorrect LPC Object export...we export pointers not the object itself! Why? Aren't DATA symbols exported by DLLs pointers? Emanuele ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega. E poi hai l'Adsl senza limiti a meno di 1 euro al giorno. Abbonati subito senza costi di attivazione su http://www.libero.it

6 11

Re: 12739: Add sample build script.
by Martin Fuchs 03 Jan '05

03 Jan '05

Hi, if you want to replace the Makefile build system, please consider using bjam: http://boost.org/tools/build/jam_src/ It has the following advantages: - automatic dependency checking - resolves dependencies in memory without invoking multiple levels of Makefiles - supports nearly every compiler toolset out there, see: http://boost.org/more/getting_started.html#Tools On 02.01.2005 23:17:03 chorns(a)svn.reactos.com wrote: > Add sample build script. > Added files: > branches/xmlbuildsystem/reactos/ReactOS.xml

3 3

Re: [ros-svn] [ion] 12740: Fix my previous patch and fix ACCESS_TOKEN being declared as a structure. This is incompatible with DDK/W32API because ACCESS_TOKEN is a PVOID. The real structure is TOKEN. Also, structure has been updated.
by eric.kohl＠t-online.de 03 Jan '05

03 Jan '05

ion(a)svn.reactos.com wrote: > Fix my previous patch and fix ACCESS_TOKEN being declared as a structure. This is incompatible with DDK/W32API because ACCESS_TOKEN is a PVOID. The real structure is TOKEN. Also, structure has been updated. > I think Microsoft declared PACCESS_TOKEN as a void pointer in order to hide the internals of ACCESS_TOKEN because the average developer does not need to access it or they don't want to reveal more information than needed. Please don't break what's working and revert this patch! We are using our own set of headers because we need to fix crippled declarations and add missing ones. If you want to build ReactOS using the MS SDK and DDK fix them instead of breaking our headers and code. Regards, Eric

3 2

Re: [ros-svn] [ion] 12738: Fix KeRaiseUserException and rename Object Information Structure
by eric.kohl＠t-online.de 03 Jan '05

03 Jan '05

ion(a)svn.reactos.com schrieb: > Fix KeRaiseUserException and rename Object Information Structure Alex, Please explain why you renamed the DIRECTORY_BASIC_INFORMATION structure to OBJECT_DIRECTORY_INFORMATION? All publicly available sources call it DIRECTORY_BASIC_INFORMATION so I think there is no need to rename it. Please revert that modification because you are replacing a well-known structure by an unknown one. Regards, Eric

2 1

Re: [ros-dev] Re:[ros-svn] [ion] 12748: Fix incorrect LPC Object export...we export pointers not the object itself! Also remove
by ea＠iol.it 03 Jan '05

03 Jan '05

> > I think that Alex's changes are correct. If Alex's changes are wrong, > > all other type object initialisations are also wrong. There is only > > one little bug, the EXPORTED/IMPORTED definition is missing. > > Hmm, you might be right... > > POBJECT_TYPE _LpcPortObjectType; /* <- Debug symbols */ > extern NTOSAPI POBJECT_TYPE LpcPortObjectType; /* <- W32API headers */ > > POBJECT_TYPE _IoFileObjectType; /* <- Debug symbols */ > extern POBJECT_TYPE *IoFileObjectType; /* <- Official DDK headers */ > extern NTOSAPI POBJECT_TYPE IoFileObjectType; /* <- W32API headers */ > DATA symbols are pointers to outside referers. When you lookup IoFileObjectType in the .edata section you get the RVA, that is a (sort of) base address of OBJECT_TYPE, i.e. a POBJECT_TYPE. Emanuele ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega. E poi hai l'Adsl senza limiti a meno di 1 euro al giorno. Abbonati subito senza costi di attivazione su http://www.libero.it

1 0

Re: [ros-dev] Re:[ros-svn] [ion] 12748: Fix incorrect LPC Object export...we export pointers not the object itself! Also remove
by ea＠iol.it 03 Jan '05

03 Jan '05

> I think that Alex's changes are correct. If Alex's changes are wrong, > all other type object initialisations are also wrong. There is only one > little bug, the EXPORTED/IMPORTED definition is missing. Imho "all other type object initialisations are also wrong". I made the Ob type descriptor for the LPC Port static and exported its addess, because it makes no sense to me dynamically allocating it (first try was tag-allocating it). Ob type objects live for as long as the executive lives: why are they dynamic? Will we support Ob restarting? Anyway, I did not mean starting a religion war. Emanuele ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega. E poi hai l'Adsl senza limiti a meno di 1 euro al giorno. Abbonati subito senza costi di attivazione su http://www.libero.it

1 0

Re: [ros-svn] [ion] 12738: Fix KeRaiseUserException and rename Object Information Structure
by Hartmut Birr 02 Jan '05

02 Jan '05

ion(a)svn.reactos.com schrieb: >Fix KeRaiseUserException and rename Object Information Structure > > >Updated files: >trunk/reactos/config >trunk/reactos/include/ntos/zwtypes.h >trunk/reactos/ntoskrnl/ke/i386/exp.c >trunk/reactos/ntoskrnl/ob/dirobj.c > >_______________________________________________ > > Hi, this changes does break the compiling of reactos. - Hartmut services: [CC] database.c database.c: In function `ScmCheckDriver': database.c:393: error: `PDIRECTORY_BASIC_INFORMATION' undeclared (first use in this function) database.c:393: error: (Each undeclared identifier is reported only once database.c:393: error: for each function it appears in.) database.c:393: error: syntax error before "DirInfo" database.c:427: error: `DIRECTORY_BASIC_INFORMATION' undeclared (first use in this function) database.c:429: error: `DirInfo' undeclared (first use in this function) _make[1]: *** [database.o] Error 1 _make: *** [services] Error 2

2 1

[Fwd: Re: [ros-dev] We have a web browser] - Test of ActiveX Control NOK
by Gge 02 Jan '05

02 Jan '05

I tested this feature as described in the initial mail ( urlmon+shdocvw dlls are included in the build ) but it fails when I hit the "Web" button with the following debug messages . Any idea about this behavior ? ---------------------------------------------------------------- (shell32_main.c:396:SHGetFileInfoW) set icon to link, stub (shell32_main.c:396:SHGetFileInfoW) set icon to link, stub (compobj.c:1612:CoCreateInstance) no classfactory created for CLSID {8856f961-340a-11d0-a96b-00c04fd705a2}, hres is 0x80040154 (compobj.c:1612:CoCreateInstance) no classfactory created for CLSID {1339b54c-3453-11d2-93b9-000000000000}, hres is 0x80040154 (shell32_main.c:396:SHGetFileInfoW) set icon to link, stub (shell32_main.c:396:SHGetFileInfoW) set icon to link, stub --------------------------------------------------------------- Regards Gerard

1 0

packet manager
by Maarten Bosma 02 Jan '05

02 Jan '05

Hi, Me and some guys on the forum were thinking, about coding a packet manager for ROS. (http://reactos.com/forum/viewtopic.php?t=164) But we would need some kind of script language. We were also thinking about using XML instead of a real lang., but a real one like python would offer much more flexibility. So my question is if you think about the packet manager idea and if you would agree to a lib like python to the tree. Maarten Bosma alias Dr. Fred

4 6

svn?
by Ryan O'Connor 02 Jan '05

02 Jan '05

Can we use SVN yet? I have TortoiseSVN but what are the connection details? --- Outgoing mail is certified Virus Free. Checked by AVG anti-virus system (http://www.grisoft.com). Version: 6.0.808 / Virus Database: 550 - Release Date: 12/8/2004

3 2

Re: [ros-svn] [ekohl] 12676: Don't start services until the control pipe issues are fixed.
by Hartmut Birr 02 Jan '05

02 Jan '05

ekohl(a)svn.reactos.com schrieb: >Don't start services until the control pipe issues are fixed. > > >Updated files: >trunk/reactos/subsys/system/services/database.c > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-svn > > > > Hi, it is more wrong with the pipes. Compiling ros on ros doesn't work. - Hartmut

3 4

Memory Area Patch
by Filip Navara 02 Jan '05

02 Jan '05

Hi! For the past few nights I've been working on a patch to convert MEMORY_AREAs from using lists to use binary search tree. The result of the work is attached. It's not optimized yet, but in the worst case it will be as slow as the list implementation. Since the patch is getting rather big I want to commit it in SVN before further working on it. So I'm hereby asking for review/testing in order to ensure that it will not break anything. Thanks, Filip P.S. Many thanks to Royce Michell III and Mike Nordell for helping me to get this beast working. Index: ps/w32call.c =================================================================== --- ps/w32call.c (revision 12712) +++ ps/w32call.c (working copy) @@ -163,11 +163,10 @@ PsFreeCallbackStack(PVOID StackLimit) { MmLockAddressSpace(MmGetKernelAddressSpace()); - MmFreeMemoryArea(MmGetKernelAddressSpace(), - StackLimit, - MM_STACK_SIZE, - PsFreeCallbackStackPage, - NULL); + MmFreeMemoryAreaByPtr(MmGetKernelAddressSpace(), + StackLimit, + PsFreeCallbackStackPage, + NULL); MmUnlockAddressSpace(MmGetKernelAddressSpace()); } Index: include/internal/mm.h =================================================================== --- include/internal/mm.h (revision 12712) +++ include/internal/mm.h (working copy) @@ -184,15 +184,17 @@ #endif /* __USE_W32API */ -typedef struct +typedef struct _MEMORY_AREA { + PVOID StartingAddress; + PVOID EndingAddress; + struct _MEMORY_AREA *Parent; + struct _MEMORY_AREA *LeftChild; + struct _MEMORY_AREA *RightChild; ULONG Type; - PVOID BaseAddress; - ULONG Length; ULONG Attributes; - LIST_ENTRY Entry; ULONG LockCount; - struct _EPROCESS* Process; + struct _EPROCESS* Process; /* FIXME: We don't need this! */ BOOLEAN DeleteInProgress; ULONG PageOpCount; union @@ -215,7 +217,7 @@ typedef struct _MADDRESS_SPACE { - LIST_ENTRY MAreaListHead; + PMEMORY_AREA MemoryAreaRoot; FAST_MUTEX Lock; PVOID LowestAddress; struct _EPROCESS* Process; @@ -333,6 +335,10 @@ LIST_ENTRY RegionListEntry; } MM_REGION, *PMM_REGION; +typedef VOID (*PMM_FREE_PAGE_FUNC)(PVOID Context, PMEMORY_AREA MemoryArea, + PVOID Address, PFN_TYPE Page, + SWAPENTRY SwapEntry, BOOLEAN Dirty); + /* FUNCTIONS */ /* aspace.c ******************************************************************/ @@ -354,49 +360,68 @@ /* marea.c *******************************************************************/ -NTSTATUS MmCreateMemoryArea(struct _EPROCESS* Process, - PMADDRESS_SPACE AddressSpace, - ULONG Type, - PVOID* BaseAddress, - ULONG Length, - ULONG Attributes, - MEMORY_AREA** Result, - BOOL FixedAddress, - BOOL TopDown, - PHYSICAL_ADDRESS BoundaryAddressMultiple OPTIONAL); +NTSTATUS INIT_FUNCTION +MmInitMemoryAreas(VOID); -MEMORY_AREA* MmOpenMemoryAreaByAddress(PMADDRESS_SPACE AddressSpace, - PVOID Address); +NTSTATUS STDCALL +MmCreateMemoryArea( + struct _EPROCESS* Process, + PMADDRESS_SPACE AddressSpace, + ULONG Type, + PVOID *BaseAddress, + ULONG_PTR Length, + ULONG Attributes, + PMEMORY_AREA *Result, + BOOLEAN FixedAddress, + BOOLEAN TopDown, + PHYSICAL_ADDRESS BoundaryAddressMultiple OPTIONAL); -ULONG MmFindGapAtAddress(PMADDRESS_SPACE AddressSpace, - PVOID Address); +PMEMORY_AREA STDCALL +MmOpenMemoryAreaByAddress( + PMADDRESS_SPACE AddressSpace, + PVOID Address); -NTSTATUS MmInitMemoryAreas(VOID); +ULONG STDCALL +MmFindGapAtAddress( + PMADDRESS_SPACE AddressSpace, + PVOID Address); -NTSTATUS MmFreeMemoryArea(PMADDRESS_SPACE AddressSpace, - PVOID BaseAddress, - ULONG Length, - VOID (*FreePage)(PVOID Context, MEMORY_AREA* MemoryArea, - PVOID Address, PFN_TYPE Page, SWAPENTRY SwapEntry, - BOOLEAN Dirty), - PVOID FreePageContext); +NTSTATUS STDCALL +MmFreeMemoryArea( + PMADDRESS_SPACE AddressSpace, + PMEMORY_AREA MemoryArea, + PMM_FREE_PAGE_FUNC FreePage, + PVOID FreePageContext); -VOID MmDumpMemoryAreas(PLIST_ENTRY ListHead); +NTSTATUS STDCALL +MmFreeMemoryAreaByPtr( + PMADDRESS_SPACE AddressSpace, + PVOID BaseAddress, + PMM_FREE_PAGE_FUNC FreePage, + PVOID FreePageContext); -NTSTATUS MmLockMemoryArea(MEMORY_AREA* MemoryArea); +VOID STDCALL +MmDumpMemoryAreas(PMADDRESS_SPACE AddressSpace); -NTSTATUS MmUnlockMemoryArea(MEMORY_AREA* MemoryArea); +PMEMORY_AREA STDCALL +MmOpenMemoryAreaByRegion( + PMADDRESS_SPACE AddressSpace, + PVOID Address, + ULONG_PTR Length); -MEMORY_AREA* MmOpenMemoryAreaByRegion(PMADDRESS_SPACE AddressSpace, - PVOID Address, - ULONG Length); +PVOID STDCALL +MmFindGap( + PMADDRESS_SPACE AddressSpace, + ULONG_PTR Length, + ULONG_PTR Granularity, + BOOLEAN TopDown); -PVOID MmFindGap(PMADDRESS_SPACE AddressSpace, ULONG Length, ULONG Granularity, BOOL TopDown); +VOID STDCALL +MmReleaseMemoryAreaIfDecommitted( + PEPROCESS Process, + PMADDRESS_SPACE AddressSpace, + PVOID BaseAddress); -void MmReleaseMemoryAreaIfDecommitted(PEPROCESS Process, - PMADDRESS_SPACE AddressSpace, - PVOID BaseAddress); - /* npool.c *******************************************************************/ VOID MiDebugDumpNonPagedPool(BOOLEAN NewOnly); Index: cc/view.c =================================================================== --- cc/view.c (revision 12712) +++ cc/view.c (working copy) @@ -813,8 +813,7 @@ #else MmLockAddressSpace(MmGetKernelAddressSpace()); MmFreeMemoryArea(MmGetKernelAddressSpace(), - CacheSeg->BaseAddress, - CacheSeg->Bcb->CacheSegmentSize, + CacheSeg->MemoryArea, CcFreeCachePage, NULL); MmUnlockAddressSpace(MmGetKernelAddressSpace()); Index: ke/i386/exp.c =================================================================== --- ke/i386/exp.c (revision 12712) +++ ke/i386/exp.c (working copy) @@ -320,7 +320,7 @@ { KeRosPrintAddress((PVOID)Frame[1]); Frame = (PULONG)Frame[0]; - DbgPrint(" "); + DbgPrint("\n"); } #else DbgPrint("Frames: "); @@ -663,7 +663,7 @@ break; StackBase = Frame; Frame = (PULONG)Frame[0]; - DbgPrint(" "); + DbgPrint("\n"); } } _SEH_HANDLE Index: ke/bug.c =================================================================== --- ke/bug.c (revision 12712) +++ ke/bug.c (working copy) @@ -116,6 +116,11 @@ Ke386DisableInterrupts(); DebugLogDumpMessages(); + if (MmGetKernelAddressSpace()->Lock.Owner == KeGetCurrentThread()) + { + MmUnlockAddressSpace(MmGetKernelAddressSpace()); + } + if (KeGetCurrentIrql() < DISPATCH_LEVEL) { KeRaiseIrql(DISPATCH_LEVEL, &OldIrql); Index: ke/kthread.c =================================================================== --- ke/kthread.c (revision 12712) +++ ke/kthread.c (working copy) @@ -90,11 +90,10 @@ if (Thread->StackLimit != (ULONG_PTR)&init_stack) { MmLockAddressSpace(MmGetKernelAddressSpace()); - MmFreeMemoryArea(MmGetKernelAddressSpace(), - (PVOID)Thread->StackLimit, - MM_STACK_SIZE, - KeFreeStackPage, - NULL); + MmFreeMemoryAreaByPtr(MmGetKernelAddressSpace(), + (PVOID)Thread->StackLimit, + KeFreeStackPage, + NULL); MmUnlockAddressSpace(MmGetKernelAddressSpace()); } Thread->StackLimit = 0; Index: mm/section.c =================================================================== --- mm/section.c (revision 12712) +++ mm/section.c (working copy) @@ -611,7 +611,7 @@ ULONG Offset; PFN_TYPE Page; NTSTATUS Status; - ULONG PAddress; + PVOID PAddress; PSECTION_OBJECT Section; PMM_SECTION_SEGMENT Segment; ULONG Entry; @@ -635,12 +635,12 @@ return(STATUS_SUCCESS); } - PAddress = (ULONG)PAGE_ROUND_DOWN(((ULONG)Address)); - Offset = PAddress - (ULONG)MemoryArea->BaseAddress; + PAddress = MM_ROUND_DOWN(Address, PAGE_SIZE); + Offset = (ULONG_PTR)PAddress - (ULONG_PTR)MemoryArea->StartingAddress; Segment = MemoryArea->Data.SectionData.Segment; Section = MemoryArea->Data.SectionData.Section; - Region = MmFindRegion(MemoryArea->BaseAddress, + Region = MmFindRegion(MemoryArea->StartingAddress, &MemoryArea->Data.SectionData.RegionListHead, Address, NULL); /* @@ -1129,7 +1129,7 @@ PFN_TYPE NewPage; PVOID NewAddress; NTSTATUS Status; - ULONG PAddress; + PVOID PAddress; ULONG Offset; PMM_PAGEOP PageOp; PMM_REGION Region; @@ -1148,12 +1148,12 @@ /* * Find the offset of the page */ - PAddress = (ULONG)PAGE_ROUND_DOWN(((ULONG)Address)); - Offset = PAddress - (ULONG)MemoryArea->BaseAddress; + PAddress = MM_ROUND_DOWN(Address, PAGE_SIZE); + Offset = (ULONG_PTR)PAddress - (ULONG_PTR)MemoryArea->StartingAddress; Segment = MemoryArea->Data.SectionData.Segment; Section = MemoryArea->Data.SectionData.Section; - Region = MmFindRegion(MemoryArea->BaseAddress, + Region = MmFindRegion(MemoryArea->StartingAddress, &MemoryArea->Data.SectionData.RegionListHead, Address, NULL); /* @@ -1181,7 +1181,7 @@ PFN_FROM_SSE(Entry) != OldPage) { /* This is a private page. We must only change the page protection. */ - MmSetPageProtect(AddressSpace->Process, (PVOID)PAddress, Region->Protect); + MmSetPageProtect(AddressSpace->Process, PAddress, Region->Protect); return(STATUS_SUCCESS); } @@ -1244,7 +1244,7 @@ */ NewAddress = ExAllocatePageWithPhysPage(NewPage); - memcpy(NewAddress, (PVOID)PAddress, PAGE_SIZE); + memcpy(NewAddress, PAddress, PAGE_SIZE); ExUnmapPage(NewAddress); /* @@ -1267,7 +1267,7 @@ KEBUGCHECK(0); return(Status); } - MmInsertRmap(NewPage, AddressSpace->Process, (PVOID)PAddress); + MmInsertRmap(NewPage, AddressSpace->Process, PAddress); if (!NT_SUCCESS(Status)) { DbgPrint("Unable to create virtual mapping\n"); @@ -1282,7 +1282,7 @@ /* * Unshare the old page. */ - MmDeleteRmap(OldPage, AddressSpace->Process, (PVOID)PAddress); + MmDeleteRmap(OldPage, AddressSpace->Process, PAddress); MmLockSectionSegment(Segment); MmUnsharePageEntrySectionSegment(Section, Segment, Offset, FALSE, FALSE); MmUnlockSectionSegment(Segment); @@ -1351,7 +1351,7 @@ Context.Segment = MemoryArea->Data.SectionData.Segment; Context.Section = MemoryArea->Data.SectionData.Section; - Context.Offset = (ULONG)((char*)Address - (ULONG)MemoryArea->BaseAddress); + Context.Offset = (ULONG_PTR)Address - (ULONG_PTR)MemoryArea->StartingAddress; FileOffset = Context.Offset + Context.Segment->FileOffset; IsImageSection = Context.Section->AllocationAttributes & SEC_IMAGE ? TRUE : FALSE; @@ -1691,7 +1691,7 @@ Address = (PVOID)PAGE_ROUND_DOWN(Address); - Offset = (ULONG)((char*)Address - (ULONG)MemoryArea->BaseAddress); + Offset = (ULONG_PTR)Address - (ULONG_PTR)MemoryArea->StartingAddress; /* * Get the segment and section. @@ -1855,7 +1855,7 @@ ULONG Entry; PFN_TYPE Page; - Offset = (ULONG)Address - (ULONG)MemoryArea->BaseAddress; + Offset = (ULONG_PTR)Address - (ULONG_PTR)MemoryArea->StartingAddress; Entry = MmGetPageEntrySectionSegment(Segment, Offset); Page = MmGetPfnForProcess(AddressSpace->Process, Address); @@ -1889,12 +1889,12 @@ NTSTATUS Status; Length = - min(Length, (ULONG) ((char*)MemoryArea->BaseAddress + MemoryArea->Length - (char*)BaseAddress)); - Region = MmFindRegion(MemoryArea->BaseAddress, + min(Length, (ULONG_PTR)MemoryArea->EndingAddress - (ULONG_PTR)BaseAddress); + Region = MmFindRegion(MemoryArea->StartingAddress, &MemoryArea->Data.SectionData.RegionListHead, BaseAddress, NULL); *OldProtect = Region->Protect; - Status = MmAlterRegion(AddressSpace, MemoryArea->BaseAddress, + Status = MmAlterRegion(AddressSpace, MemoryArea->StartingAddress, &MemoryArea->Data.SectionData.RegionListHead, BaseAddress, Length, Region->Type, Protect, MmAlterViewAttributes); @@ -1915,7 +1915,7 @@ PMEMORY_AREA CurrentMArea; KIRQL oldIrql; - Region = MmFindRegion(MemoryArea->BaseAddress, + Region = MmFindRegion((PVOID)MemoryArea->StartingAddress, &MemoryArea->Data.SectionData.RegionListHead, Address, &RegionBaseAddress); if (Region == NULL) @@ -1934,11 +1934,11 @@ CurrentEntry = CurrentEntry->Flink; if (Info->AllocationBase == NULL) { - Info->AllocationBase = CurrentMArea->BaseAddress; + Info->AllocationBase = CurrentMArea->StartingAddress; } - else if (CurrentMArea->BaseAddress < Info->AllocationBase) + else if (CurrentMArea->StartingAddress < Info->AllocationBase) { - Info->AllocationBase = CurrentMArea->BaseAddress; + Info->AllocationBase = CurrentMArea->StartingAddress; } } KeReleaseSpinLock(&Section->ViewListLock, oldIrql); @@ -1949,11 +1949,12 @@ else { Info->BaseAddress = RegionBaseAddress; - Info->AllocationBase = MemoryArea->BaseAddress; + Info->AllocationBase = MemoryArea->StartingAddress; Info->AllocationProtect = MemoryArea->Attributes; Info->Type = MEM_MAPPED; } - Info->RegionSize = PAGE_ROUND_UP(MemoryArea->Length); + Info->RegionSize = PAGE_ROUND_UP((ULONG_PTR)MemoryArea->EndingAddress - + (ULONG_PTR)MemoryArea->StartingAddress); Info->State = MEM_COMMIT; Info->Protect = Region->Protect; @@ -3583,7 +3584,7 @@ Address = (PVOID)PAGE_ROUND_DOWN(Address); - Offset = ((ULONG_PTR)Address - (ULONG_PTR)MArea->BaseAddress) + + Offset = ((ULONG_PTR)Address - (ULONG_PTR)MArea->StartingAddress) + MemoryArea->Data.SectionData.ViewOffset; Section = MArea->Data.SectionData.Section; @@ -3711,16 +3712,14 @@ if (Section->AllocationAttributes & SEC_PHYSICALMEMORY) { Status = MmFreeMemoryArea(AddressSpace, - BaseAddress, - 0, + MemoryArea, NULL, NULL); } else { Status = MmFreeMemoryArea(AddressSpace, - BaseAddress, - 0, + MemoryArea, MmFreeSectionPage, MemoryArea); } @@ -4087,7 +4086,7 @@ KEBUGCHECK(0); } Status = MmCreateVirtualMapping (NULL, - ((char*)Result + (i * PAGE_SIZE)), + (PVOID)(Result + (i * PAGE_SIZE)), PAGE_READWRITE, &Page, 1); @@ -4178,7 +4177,7 @@ { ULONG i; ULONG NrSegments; - PVOID ImageBase; + ULONG_PTR ImageBase; ULONG ImageSize; PMM_IMAGE_SECTION_OBJECT ImageSectionObject; PMM_SECTION_SEGMENT SectionSegments; @@ -4188,10 +4187,10 @@ NrSegments = ImageSectionObject->NrSegments; - ImageBase = *BaseAddress; - if (ImageBase == NULL) + ImageBase = (ULONG_PTR)*BaseAddress; + if (ImageBase == 0) { - ImageBase = (PVOID)ImageSectionObject->ImageBase; + ImageBase = ImageSectionObject->ImageBase; } ImageSize = 0; @@ -4207,7 +4206,7 @@ } /* Check there is enough space to map the section at that point. */ - if (MmOpenMemoryAreaByRegion(AddressSpace, ImageBase, + if (MmOpenMemoryAreaByRegion(AddressSpace, (PVOID)ImageBase, PAGE_ROUND_UP(ImageSize)) != NULL) { /* Fail if the user requested a fixed base address. */ @@ -4217,8 +4216,8 @@ return(STATUS_UNSUCCESSFUL); } /* Otherwise find a gap to map the image. */ - ImageBase = MmFindGap(AddressSpace, PAGE_ROUND_UP(ImageSize), PAGE_SIZE, FALSE); - if (ImageBase == NULL) + ImageBase = (ULONG_PTR)MmFindGap(AddressSpace, PAGE_ROUND_UP(ImageSize), PAGE_SIZE, FALSE); + if (ImageBase == 0) { MmUnlockAddressSpace(AddressSpace); return(STATUS_UNSUCCESSFUL); @@ -4250,7 +4249,7 @@ } } - *BaseAddress = ImageBase; + *BaseAddress = (PVOID)ImageBase; } else { Index: mm/mm.c =================================================================== --- mm/mm.c (revision 12712) +++ mm/mm.c (working copy) @@ -99,13 +99,13 @@ DPRINT("MmReleaseMemoryArea(Process %x, Marea %x)\n",Process,Marea); DPRINT("Releasing %x between %x %x (type %d)\n", - Marea, Marea->BaseAddress, (char*)Marea->BaseAddress + Marea->Length, + Marea, Marea->StartingAddress, Marea->EndingAddress, Marea->Type); switch (Marea->Type) { case MEMORY_AREA_SECTION_VIEW: - Status = MmUnmapViewOfSection(Process, Marea->BaseAddress); + Status = MmUnmapViewOfSection(Process, (PVOID)Marea->StartingAddress); ASSERT(Status == STATUS_SUCCESS); return(STATUS_SUCCESS); @@ -116,8 +116,7 @@ case MEMORY_AREA_SHARED_DATA: case MEMORY_AREA_NO_ACCESS: Status = MmFreeMemoryArea(&Process->AddressSpace, - Marea->BaseAddress, - 0, + Marea, NULL, NULL); break; @@ -135,20 +134,35 @@ NTSTATUS MmReleaseMmInfo(PEPROCESS Process) { - PLIST_ENTRY CurrentEntry; - PMEMORY_AREA Current; +/* PMEMORY_AREA CurrentNode;*/ +/* PMEMORY_AREA NextNode;*/ DPRINT("MmReleaseMmInfo(Process %x (%s))\n", Process, Process->ImageFileName); MmLockAddressSpace(&Process->AddressSpace); - while(!IsListEmpty(&Process->AddressSpace.MAreaListHead)) +#if 0 + for (CurrentNode = Process->AddressSpace.MemoryAreaRoot; + CurrentNode != NULL; + CurrentNode = NextNode) { - CurrentEntry = Process->AddressSpace.MAreaListHead.Flink; - Current = CONTAINING_RECORD(CurrentEntry, MEMORY_AREA, Entry); - MmReleaseMemoryArea(Process, Current); + if (CurrentNode->LeftChild == NULL) + { + NextNode = CurrentNode->RightChild; + MmReleaseMemoryArea(Process, CurrentNode); + } + else + { + NextNode = CurrentNode->LeftChild; + CurrentNode->LeftChild = NextNode->RightChild; + NextNode->RightChild = CurrentNode; + } } +#else + while (Process->AddressSpace.MemoryAreaRoot != NULL) + MmReleaseMemoryArea(Process, Process->AddressSpace.MemoryAreaRoot); +#endif Mmi386ReleaseMmInfo(Process); @@ -208,7 +222,7 @@ } NTSTATUS MmAccessFault(KPROCESSOR_MODE Mode, - ULONG Address, + ULONG Address, /* FiN TODO: Should be ULONG_PTR! */ BOOLEAN FromMdl) { PMADDRESS_SPACE AddressSpace; @@ -330,7 +344,7 @@ } NTSTATUS MmNotPresentFault(KPROCESSOR_MODE Mode, - ULONG Address, + ULONG Address, /* FiN TODO: Should be ULONG_PTR! */ BOOLEAN FromMdl) { PMADDRESS_SPACE AddressSpace; Index: mm/mdl.c =================================================================== --- mm/mdl.c (revision 12712) +++ mm/mdl.c (working copy) @@ -269,7 +269,7 @@ KEBUGCHECK(0); } - Base = (char*)MiMdlMappingRegionBase + StartingOffset * PAGE_SIZE; + Base = (PVOID)((ULONG_PTR)MiMdlMappingRegionBase + StartingOffset * PAGE_SIZE); if (MiMdlMappingRegionHint == StartingOffset) { @@ -384,7 +384,7 @@ NULL); } - if ((DWORD)BaseAddress >= KERNEL_BASE) + if ((ULONG_PTR)BaseAddress >= KERNEL_BASE) { ASSERT(Mdl->MdlFlags & MDL_MAPPED_TO_SYSTEM_VA); @@ -416,7 +416,7 @@ KEBUGCHECK(0); } - MmFreeMemoryArea( &Mdl->Process->AddressSpace, Marea->BaseAddress, 0, NULL, NULL ); + MmFreeMemoryArea( &Mdl->Process->AddressSpace, Marea, NULL, NULL ); Mdl->Process = NULL; } Index: mm/ncache.c =================================================================== --- mm/ncache.c (revision 12712) +++ mm/ncache.c (working copy) @@ -129,11 +129,10 @@ IN ULONG NumberOfBytes) { MmLockAddressSpace(MmGetKernelAddressSpace()); - MmFreeMemoryArea (MmGetKernelAddressSpace(), - BaseAddress, - NumberOfBytes, - MmFreeNonCachedPage, - NULL); + MmFreeMemoryAreaByPtr(MmGetKernelAddressSpace(), + BaseAddress, + MmFreeNonCachedPage, + NULL); MmUnlockAddressSpace(MmGetKernelAddressSpace()); } Index: mm/marea.c =================================================================== --- mm/marea.c (revision 12712) +++ mm/marea.c (working copy) @@ -35,331 +35,465 @@ #define TAG_MAREA TAG('M', 'A', 'R', 'E') +/* #define VALIDATE_MEMORY_AREAS */ + /* FUNCTIONS *****************************************************************/ -VOID MmDumpMemoryAreas(PLIST_ENTRY ListHead) +/** + * @name MmIterateFirstNode + * + * @param Head + * Head node of the MEMORY_AREA tree. + * + * @return The leftmost MEMORY_AREA node (ie. the one with lowest + * address) + */ + +static PMEMORY_AREA MmIterateFirstNode(PMEMORY_AREA Head) { - PLIST_ENTRY current_entry; - MEMORY_AREA* current; + PMEMORY_AREA Node = Head; + while (Node->LeftChild != NULL) + Node = Node->LeftChild; + + return Node; +} + +/** + * @name MmIterateNextNode + * + * @param Node + * Current node in the tree. + * + * @return Next node in the tree (sorted by address). + */ + +static PMEMORY_AREA MmIterateNextNode(PMEMORY_AREA Node) +{ + if (Node->RightChild != NULL) + { + Node = Node->RightChild; + while (Node->LeftChild != NULL) + Node = Node->LeftChild; + } + else + { + PMEMORY_AREA TempNode = NULL; + + do + { + /* Check if we're at the end of tree. */ + if (Node->Parent == NULL) + return NULL; + + TempNode = Node; + Node = Node->Parent; + } + while (TempNode == Node->RightChild); + } + return Node; +} + +/** + * @name MmIterateFirstNode + * + * @param Head + * Head node of the MEMORY_AREA tree. + * + * @return The rightmost MEMORY_AREA node (ie. the one with highest + * address) + */ + +static PMEMORY_AREA MmIterateLastNode(PMEMORY_AREA Head) +{ + PMEMORY_AREA Node = Head; + + while (Node->RightChild != NULL) + Node = Node->RightChild; + + return Node; +} + +/** + * @name MmIterateNextNode + * + * @param Node + * Current node in the tree. + * + * @return Previous node in the tree (sorted by address). + */ + +static PMEMORY_AREA MmIteratePrevNode(PMEMORY_AREA Node) +{ + if (Node->LeftChild != NULL) + { + Node = Node->LeftChild; + while (Node->RightChild != NULL) + Node = Node->RightChild; + } + else + { + PMEMORY_AREA TempNode = NULL; + + do + { + /* Check if we're at the end of tree. */ + if (Node->Parent == NULL) + return NULL; + + TempNode = Node; + Node = Node->Parent; + } + while (TempNode == Node->LeftChild); + } + return Node; +} + +#ifdef VALIDATE_MEMORY_AREAS +static VOID MmVerifyMemoryAreas(PMADDRESS_SPACE AddressSpace) +{ + PMEMORY_AREA Node; + + ASSERT(AddressSpace != NULL); + + /* Special case for empty tree. */ + if (AddressSpace->MemoryAreaRoot == NULL) + return; + + /* Traverse the tree from left to right. */ + for (Node = MmIterateFirstNode(AddressSpace->MemoryAreaRoot); + Node != NULL; + Node = MmIterateNextNode(Node)) + { + /* FiN: The starting address can be NULL if someone explicitely asks + * for NULL address. */ + ASSERT(Node->StartingAddress >= AddressSpace->LowestAddress || + Node->StartingAddress == NULL); + ASSERT(Node->EndingAddress >= Node->StartingAddress); + } +} +#else +#define MmVerifyMemoryAreas(x) +#endif + +VOID STDCALL +MmDumpMemoryAreas(PMADDRESS_SPACE AddressSpace) +{ + PMEMORY_AREA Node; + DbgPrint("MmDumpMemoryAreas()\n"); + + /* Special case for empty tree. */ + if (AddressSpace->MemoryAreaRoot == NULL) + return; - current_entry = ListHead->Flink; - while (current_entry!=ListHead) + /* Traverse the tree from left to right. */ + for (Node = MmIterateFirstNode(AddressSpace->MemoryAreaRoot); + Node != NULL; + Node = MmIterateNextNode(Node)) { - current = CONTAINING_RECORD(current_entry,MEMORY_AREA,Entry); - DbgPrint("Base %x Length %x End %x Attributes %x Flink %x\n", - current->BaseAddress,current->Length, - (char*)current->BaseAddress+current->Length,current->Attributes, - current->Entry.Flink); - current_entry = current_entry->Flink; + DbgPrint("Start %x End %x Attributes %x\n", + Node->StartingAddress, Node->EndingAddress, + Node->Attributes); } + DbgPrint("Finished MmDumpMemoryAreas()\n"); } -MEMORY_AREA* MmOpenMemoryAreaByAddress(PMADDRESS_SPACE AddressSpace, - PVOID Address) +PMEMORY_AREA STDCALL +MmOpenMemoryAreaByAddress( + PMADDRESS_SPACE AddressSpace, + PVOID Address) { - PLIST_ENTRY current_entry; - MEMORY_AREA* current; - PLIST_ENTRY previous_entry; + PMEMORY_AREA Node = AddressSpace->MemoryAreaRoot; DPRINT("MmOpenMemoryAreaByAddress(AddressSpace %x, Address %x)\n", - AddressSpace, Address); + AddressSpace, Address); - previous_entry = &AddressSpace->MAreaListHead; - current_entry = AddressSpace->MAreaListHead.Flink; - while (current_entry != &AddressSpace->MAreaListHead) + if (!(KdDebugState & KD_DEBUG_SCREEN)) + MmVerifyMemoryAreas(AddressSpace); + + while (Node != NULL) { - current = CONTAINING_RECORD(current_entry, - MEMORY_AREA, - Entry); - ASSERT(current_entry->Blink->Flink == current_entry); - ASSERT(current_entry->Flink->Blink == current_entry); - ASSERT(previous_entry->Flink == current_entry); - if (current->BaseAddress <= Address && - (PVOID)((char*)current->BaseAddress + current->Length) > Address) + if (Address < Node->StartingAddress) + Node = Node->LeftChild; + else if (Address >= Node->EndingAddress) + Node = Node->RightChild; + else { - DPRINT("%s() = %x\n",__FUNCTION__,current); - return(current); + DPRINT("MmOpenMemoryAreaByAddress(%x): %x [%x - %x]\n", + Address, Node, Node->StartingAddress, Node->EndingAddress); + return Node; } - if (current->BaseAddress > Address) - { - DPRINT("%s() = NULL\n",__FUNCTION__); - return(NULL); - } - previous_entry = current_entry; - current_entry = current_entry->Flink; } - DPRINT("%s() = NULL\n",__FUNCTION__); - return(NULL); + + DPRINT("MmOpenMemoryAreaByAddress(%x): 0\n", Address); + return NULL; } -MEMORY_AREA* MmOpenMemoryAreaByRegion(PMADDRESS_SPACE AddressSpace, - PVOID Address, - ULONG Length) +PMEMORY_AREA STDCALL +MmOpenMemoryAreaByRegion( + PMADDRESS_SPACE AddressSpace, + PVOID Address, + ULONG_PTR Length) { - PLIST_ENTRY current_entry; - MEMORY_AREA* current; - ULONG Extent; + PMEMORY_AREA Node; + PVOID Extent = (PVOID)((ULONG_PTR)Address + Length); - DPRINT("MmOpenMemoryByRegion(AddressSpace %x, Address %x, Length %x)\n", - AddressSpace, Address, Length); + MmVerifyMemoryAreas(AddressSpace); - current_entry = AddressSpace->MAreaListHead.Flink; - while (current_entry != &AddressSpace->MAreaListHead) + /* Special case for empty tree. */ + if (AddressSpace->MemoryAreaRoot == NULL) + return NULL; + + /* Traverse the tree from left to right. */ + for (Node = MmIterateFirstNode(AddressSpace->MemoryAreaRoot); + Node != NULL; + Node = MmIterateNextNode(Node)) { - current = CONTAINING_RECORD(current_entry, - MEMORY_AREA, - Entry); - DPRINT("current->BaseAddress %x current->Length %x\n", - current->BaseAddress,current->Length); - if (current->BaseAddress >= Address && - current->BaseAddress < (PVOID)((char*)Address+Length)) + if (Node->StartingAddress >= Address && + Node->StartingAddress < Extent) { - DPRINT("Finished MmOpenMemoryAreaByRegion() = %x\n", - current); - return(current); + DPRINT("MmOpenMemoryAreaByRegion(%x - %x): %x - %x\n", + Address, Address + Length, Node->StartingAddress, + Node->EndingAddress); + return Node; } - Extent = (ULONG)current->BaseAddress + current->Length; - if (Extent > (ULONG)Address && - Extent < (ULONG)((char*)Address+Length)) + if (Node->EndingAddress > Address && + Node->EndingAddress < Extent) { - DPRINT("Finished MmOpenMemoryAreaByRegion() = %x\n", - current); - return(current); + DPRINT("MmOpenMemoryAreaByRegion(%x - %x): %x - %x\n", + Address, Address + Length, Node->StartingAddress, + Node->EndingAddress); + return Node; } - if (current->BaseAddress <= Address && - Extent >= (ULONG)((char*)Address+Length)) + if (Node->StartingAddress <= Address && + Node->EndingAddress >= Extent) { - DPRINT("Finished MmOpenMemoryAreaByRegion() = %x\n", - current); - return(current); + DPRINT("MmOpenMemoryAreaByRegion(%x - %x): %x - %x\n", + Address, Address + Length, Node->StartingAddress, + Node->EndingAddress); + return Node; } - if (current->BaseAddress >= (PVOID)((char*)Address+Length)) + if (Node->StartingAddress >= Extent) { - DPRINT("Finished MmOpenMemoryAreaByRegion()= NULL\n",0); - return(NULL); + DPRINT("Finished MmOpenMemoryAreaByRegion() = NULL\n"); + return NULL; } - current_entry = current_entry->Flink; } - DPRINT("Finished MmOpenMemoryAreaByRegion() = NULL\n",0); - return(NULL); + + return NULL; } -static VOID MmInsertMemoryArea(PMADDRESS_SPACE AddressSpace, - MEMORY_AREA* marea) +static VOID +MmInsertMemoryArea( + PMADDRESS_SPACE AddressSpace, + PMEMORY_AREA marea) { - PLIST_ENTRY ListHead; - PLIST_ENTRY current_entry; - PLIST_ENTRY inserted_entry = &marea->Entry; - MEMORY_AREA* current; - MEMORY_AREA* next; + PMEMORY_AREA Node; + PMEMORY_AREA PreviousNode; - DPRINT("MmInsertMemoryArea(marea %x)\n", marea); - DPRINT("marea->BaseAddress %x\n", marea->BaseAddress); - DPRINT("marea->Length %x\n", marea->Length); + MmVerifyMemoryAreas(AddressSpace); - ListHead = &AddressSpace->MAreaListHead; - - current_entry = ListHead->Flink; - if (IsListEmpty(ListHead)) + if (AddressSpace->MemoryAreaRoot == NULL) { - InsertHeadList(ListHead,&marea->Entry); + AddressSpace->MemoryAreaRoot = marea; + marea->LeftChild = marea->RightChild = marea->Parent = NULL; return; } - current = CONTAINING_RECORD(current_entry,MEMORY_AREA,Entry); - if (current->BaseAddress > marea->BaseAddress) + + Node = AddressSpace->MemoryAreaRoot; + do { - InsertHeadList(ListHead,&marea->Entry); - return; + DPRINT("marea->EndingAddress: %x Node->StartingAddress: %x\n", + marea->EndingAddress, Node->StartingAddress); + DPRINT("marea->StartingAddress: %x Node->EndingAddress: %x\n", + marea->StartingAddress, Node->EndingAddress); + ASSERT(marea->EndingAddress <= Node->StartingAddress || + marea->StartingAddress >= Node->EndingAddress); + PreviousNode = Node; + if (marea->StartingAddress < Node->StartingAddress) + Node = Node->LeftChild; + else + Node = Node->RightChild; } - while (current_entry->Flink!=ListHead) - { - current = CONTAINING_RECORD(current_entry,MEMORY_AREA,Entry); - next = CONTAINING_RECORD(current_entry->Flink,MEMORY_AREA,Entry); - if (current->BaseAddress < marea->BaseAddress && - current->Entry.Flink==ListHead) - { - current_entry->Flink = inserted_entry; - inserted_entry->Flink=ListHead; - inserted_entry->Blink=current_entry; - ListHead->Blink = inserted_entry; - return; - } - if (current->BaseAddress < marea->BaseAddress && - next->BaseAddress > marea->BaseAddress) - { - inserted_entry->Flink = current_entry->Flink; - inserted_entry->Blink = current_entry; - inserted_entry->Flink->Blink = inserted_entry; - current_entry->Flink=inserted_entry; - return; - } - current_entry = current_entry->Flink; - } - InsertTailList(ListHead,inserted_entry); + while (Node != NULL); + + marea->LeftChild = marea->RightChild = NULL; + marea->Parent = PreviousNode; + if (marea->StartingAddress < PreviousNode->StartingAddress) + PreviousNode->LeftChild = marea; + else + PreviousNode->RightChild = marea; } -static PVOID MmFindGapBottomUp(PMADDRESS_SPACE AddressSpace, ULONG Length, ULONG Granularity) +static PVOID +MmFindGapBottomUp( + PMADDRESS_SPACE AddressSpace, + ULONG_PTR Length, + ULONG_PTR Granularity) { - PLIST_ENTRY ListHead; - PLIST_ENTRY current_entry; - MEMORY_AREA* current; - MEMORY_AREA* next; - ULONG Gap; - PVOID Address; + PVOID HighestAddress = AddressSpace->LowestAddress < (PVOID)KERNEL_BASE ? + (PVOID)KERNEL_BASE : (PVOID)MAXULONG_PTR; + PVOID AlignedAddress; + PMEMORY_AREA Node; + PMEMORY_AREA FirstNode; + PMEMORY_AREA PreviousNode; - DPRINT("MmFindGapBottomUp(Length %x)\n",Length); + MmVerifyMemoryAreas(AddressSpace); -#ifdef DBG - Length += PAGE_SIZE; /* For a guard page following the area */ -#endif + DPRINT("LowestAddress: %x HighestAddress: %x\n", + AddressSpace->LowestAddress, HighestAddress); - ListHead = &AddressSpace->MAreaListHead; + AlignedAddress = MM_ROUND_UP(AddressSpace->LowestAddress, Granularity); - current_entry = ListHead->Flink; - while (current_entry->Flink!=ListHead) + /* Special case for empty tree. */ + if (AddressSpace->MemoryAreaRoot == NULL) { - current = CONTAINING_RECORD(current_entry,MEMORY_AREA,Entry); - next = CONTAINING_RECORD(current_entry->Flink,MEMORY_AREA,Entry); - Address = (PVOID) ((char*)current->BaseAddress + PAGE_ROUND_UP(current->Length)); -#ifdef DBG - Address = (PVOID) ((char *) Address + PAGE_SIZE); /* For a guard page preceding the area */ -#endif - Address = (PVOID) MM_ROUND_UP(Address, Granularity); - if (Address < next->BaseAddress) + if (HighestAddress - AlignedAddress >= Length) { - Gap = (char*)next->BaseAddress - ((char*)current->BaseAddress + PAGE_ROUND_UP(current->Length)); - if (Gap >= Length) - { - return Address; - } + DPRINT("MmFindGapBottomUp: %x\n", AlignedAddress); + return AlignedAddress; } - current_entry = current_entry->Flink; + DPRINT("MmFindGapBottomUp: 0\n"); + return 0; } - if (current_entry == ListHead) + /* Go to the node with lowest address in the tree. */ + FirstNode = Node = MmIterateFirstNode(AddressSpace->MemoryAreaRoot); + + /* Traverse the tree from left to right. */ + PreviousNode = Node; + for (;;) { - Address = (PVOID) MM_ROUND_UP(AddressSpace->LowestAddress, Granularity); + Node = MmIterateNextNode(Node); + if (Node == NULL) + break; + + AlignedAddress = MM_ROUND_UP(PreviousNode->EndingAddress, Granularity); + if (Node->StartingAddress > AlignedAddress && + Node->StartingAddress - AlignedAddress >= Length) + { + DPRINT("MmFindGapBottomUp: %x\n", AlignedAddress); + return AlignedAddress; + } + + PreviousNode = Node; } - else + + /* Check if there is enough space after the last memory area. */ + AlignedAddress = MM_ROUND_UP(PreviousNode->EndingAddress, Granularity); + if (HighestAddress - AlignedAddress >= Length) { - current = CONTAINING_RECORD(current_entry,MEMORY_AREA,Entry); - Address = (char*)current->BaseAddress + PAGE_ROUND_UP(current->Length); -#ifdef DBG - Address = (PVOID) ((char *) Address + PAGE_SIZE); /* For a guard page preceding the area */ -#endif - Address = (PVOID) MM_ROUND_UP(Address, Granularity); + DPRINT("MmFindGapBottomUp: %x\n", AlignedAddress); + return AlignedAddress; } - /* Check if enough space for the block */ - if (AddressSpace->LowestAddress < (PVOID)KERNEL_BASE) + + /* Check if there is enough space before the first memory area. */ + AlignedAddress = MM_ROUND_UP(AddressSpace->LowestAddress, Granularity); + if (FirstNode->StartingAddress > AlignedAddress && + FirstNode->StartingAddress - AlignedAddress >= Length) { - if ((ULONG_PTR) Address >= KERNEL_BASE || Length > KERNEL_BASE - (ULONG_PTR) Address) - { - DPRINT1("Failed to find gap\n"); - return NULL; - } + DPRINT("MmFindGapBottomUp: %x\n", AlignedAddress); + return AlignedAddress; } - else - { - if (Length >= ~ ((ULONG_PTR) 0) - (ULONG_PTR) Address) - { - DPRINT1("Failed to find gap\n"); - return NULL; - } - } - return Address; + + DPRINT("MmFindGapBottomUp: 0\n"); + return 0; } -static PVOID MmFindGapTopDown(PMADDRESS_SPACE AddressSpace, ULONG Length, ULONG Granularity) +static PVOID +MmFindGapTopDown( + PMADDRESS_SPACE AddressSpace, + ULONG_PTR Length, + ULONG_PTR Granularity) { - PLIST_ENTRY ListHead; - PLIST_ENTRY current_entry; - MEMORY_AREA* current; - ULONG Gap; - PVOID Address; - PVOID TopAddress; - PVOID BottomAddress; - PVOID HighestAddress; + PVOID HighestAddress = AddressSpace->LowestAddress < (PVOID)KERNEL_BASE ? + (PVOID)KERNEL_BASE : (PVOID)MAXULONG_PTR; + PVOID AlignedAddress; + PMEMORY_AREA Node; + PMEMORY_AREA PreviousNode; - DPRINT("MmFindGapTopDown(Length %lx)\n",Length); + MmVerifyMemoryAreas(AddressSpace); -#ifdef DBG - Length += PAGE_SIZE; /* For a guard page following the area */ -#endif + DPRINT("LowestAddress: %x HighestAddress: %x\n", + AddressSpace->LowestAddress, HighestAddress); - if (AddressSpace->LowestAddress < (PVOID)KERNEL_BASE) //(ULONG_PTR)MmSystemRangeStart) - { - HighestAddress = MmHighestUserAddress; - } - else - { - HighestAddress = (PVOID)0xFFFFFFFF; - } + AlignedAddress = MM_ROUND_DOWN(HighestAddress - Length + 1, Granularity); - TopAddress = HighestAddress; + /* Check for overflow. */ + if (AlignedAddress > HighestAddress) + return NULL; - ListHead = &AddressSpace->MAreaListHead; - current_entry = ListHead->Blink; - while (current_entry->Blink != ListHead) + /* Special case for empty tree. */ + if (AddressSpace->MemoryAreaRoot == NULL) { - current = CONTAINING_RECORD(current_entry,MEMORY_AREA,Entry); - BottomAddress = (char*)current->BaseAddress + PAGE_ROUND_UP(current->Length); -#ifdef DBG - BottomAddress = (PVOID) ((char *) BottomAddress + PAGE_SIZE); /* For a guard page preceding the area */ -#endif - BottomAddress = (PVOID) MM_ROUND_UP(BottomAddress, Granularity); - DPRINT("Base %p Length %lx\n", current->BaseAddress, PAGE_ROUND_UP(current->Length)); - - if (BottomAddress < TopAddress && BottomAddress < HighestAddress) + if (AlignedAddress >= (PVOID)AddressSpace->LowestAddress) { - Gap = (char*)TopAddress - (char*) BottomAddress + 1; - DPRINT("Bottom %p Top %p Gap %lx\n", BottomAddress, TopAddress, Gap); - if (Gap >= Length) - { - DPRINT("Found gap at %p\n", (char*) TopAddress - Length); - return (PVOID) MM_ROUND_DOWN((char*) TopAddress - Length + 1, Granularity); - } + DPRINT("MmFindGapTopDown: %x\n", AlignedAddress); + return AlignedAddress; } - TopAddress = (char*)current->BaseAddress - 1; - current_entry = current_entry->Blink; + DPRINT("MmFindGapTopDown: 0\n"); + return 0; } - if (current_entry == ListHead) + /* Go to the node with lowest address in the tree. */ + Node = MmIterateLastNode(AddressSpace->MemoryAreaRoot); + + /* Check if there is enough space after the last memory area. */ + if (Node->EndingAddress <= AlignedAddress) { - Address = (PVOID) MM_ROUND_DOWN((char*) HighestAddress - Length + 1, Granularity); + DPRINT("MmFindGapTopDown: %x\n", AlignedAddress); + return AlignedAddress; } - else + + /* Traverse the tree from left to right. */ + PreviousNode = Node; + for (;;) { - Address = (PVOID) MM_ROUND_DOWN((char*)TopAddress - Length + 1, Granularity); - } + Node = MmIteratePrevNode(Node); + if (Node == NULL) + break; - /* Check if enough space for the block */ - if (AddressSpace->LowestAddress < (PVOID)KERNEL_BASE) - { - if ((ULONG_PTR) Address >= KERNEL_BASE || Length > KERNEL_BASE - (ULONG_PTR) Address) + AlignedAddress = MM_ROUND_DOWN(PreviousNode->StartingAddress - Length + 1, Granularity); + + /* Check for overflow. */ + if (AlignedAddress > PreviousNode->StartingAddress) + return NULL; + + if (Node->EndingAddress <= AlignedAddress) { - DPRINT1("Failed to find gap\n"); - return NULL; + DPRINT("MmFindGapTopDown: %x\n", AlignedAddress); + return AlignedAddress; } + + PreviousNode = Node; } - else + + AlignedAddress = MM_ROUND_DOWN(PreviousNode->StartingAddress - Length + 1, Granularity); + + /* Check for overflow. */ + if (AlignedAddress > PreviousNode->StartingAddress) + return NULL; + + if (AlignedAddress >= (PVOID)AddressSpace->LowestAddress) { - if (Length >= ~ ((ULONG_PTR) 0) - (ULONG_PTR) Address) - { - DPRINT1("Failed to find gap\n"); - return NULL; - } + DPRINT("MmFindGapTopDown: %x\n", AlignedAddress); + return AlignedAddress; } - DPRINT("Found gap at %p\n", Address); - return Address; + DPRINT("MmFindGapTopDown: 0\n"); + return 0; } -PVOID MmFindGap(PMADDRESS_SPACE AddressSpace, ULONG Length, ULONG Granularity, BOOL TopDown) +PVOID STDCALL +MmFindGap( + PMADDRESS_SPACE AddressSpace, + ULONG_PTR Length, + ULONG_PTR Granularity, + BOOLEAN TopDown) { if (TopDown) return MmFindGapTopDown(AddressSpace, Length, Granularity); @@ -367,13 +501,20 @@ return MmFindGapBottomUp(AddressSpace, Length, Granularity); } -ULONG MmFindGapAtAddress(PMADDRESS_SPACE AddressSpace, PVOID Address) +ULONG_PTR STDCALL +MmFindGapAtAddress( + PMADDRESS_SPACE AddressSpace, + PVOID Address) { - PLIST_ENTRY current_entry, ListHead; - PMEMORY_AREA current; + PMEMORY_AREA Node = AddressSpace->MemoryAreaRoot; + PMEMORY_AREA RightNeighbour = NULL; + PVOID HighestAddress = AddressSpace->LowestAddress < (PVOID)KERNEL_BASE ? + (PVOID)KERNEL_BASE : (PVOID)MAXULONG_PTR; - Address = (PVOID)PAGE_ROUND_DOWN(Address); + MmVerifyMemoryAreas(AddressSpace); + Address = MM_ROUND_DOWN(Address, PAGE_SIZE); + if (AddressSpace->LowestAddress < (PVOID)KERNEL_BASE) { if (Address >= (PVOID)KERNEL_BASE) @@ -383,159 +524,255 @@ } else { - if ((ULONG_PTR)Address < (ULONG_PTR)AddressSpace->LowestAddress) + if (Address < AddressSpace->LowestAddress) { return 0; } } - ListHead = &AddressSpace->MAreaListHead; - - current_entry = ListHead->Flink; - while (current_entry != ListHead) + while (Node != NULL) { - current = CONTAINING_RECORD(current_entry,MEMORY_AREA,Entry); - if (current->BaseAddress <= Address && (char*)Address < (char*)current->BaseAddress + current->Length) + if (Address < Node->StartingAddress) { - return 0; + RightNeighbour = Node; + Node = Node->LeftChild; } - else if (current->BaseAddress > Address) + else if (Address >= Node->EndingAddress) { - return (ULONG_PTR)current->BaseAddress - (ULONG_PTR)Address; + Node = Node->RightChild; } - current_entry = current_entry->Flink; + else + { + DPRINT("MmFindGapAtAddress: 0\n"); + return 0; + } } - if (AddressSpace->LowestAddress < (PVOID)KERNEL_BASE) + + if (RightNeighbour) { - return KERNEL_BASE - (ULONG_PTR)Address; + DPRINT("MmFindGapAtAddress: %x [%x]\n", Address, RightNeighbour->StartingAddress - Address); + return RightNeighbour->StartingAddress - Address; } else { - return 0 - (ULONG_PTR)Address; + DPRINT("MmFindGapAtAddress: %x [%x]\n", Address, HighestAddress - Address); + return HighestAddress - Address; } } +/** + * @name MmInitMemoryAreas + * + * Initialize the memory area list implementation. + */ + NTSTATUS INIT_FUNCTION MmInitMemoryAreas(VOID) -/* - * FUNCTION: Initialize the memory area list - */ { DPRINT("MmInitMemoryAreas()\n",0); return(STATUS_SUCCESS); } -NTSTATUS -MmFreeMemoryArea(PMADDRESS_SPACE AddressSpace, - PVOID BaseAddress, - ULONG Length, - VOID (*FreePage)(PVOID Context, MEMORY_AREA* MemoryArea, - PVOID Address, PFN_TYPE Page, - SWAPENTRY SwapEntry, BOOLEAN Dirty), - PVOID FreePageContext) + +NTSTATUS STDCALL +MmFreeMemoryArea( + PMADDRESS_SPACE AddressSpace, + PMEMORY_AREA MemoryArea, + PMM_FREE_PAGE_FUNC FreePage, + PVOID FreePageContext) { - MEMORY_AREA* MemoryArea; - char* Address; - char* EndAddress; + PMEMORY_AREA *ParentReplace; + PVOID Address; + PVOID EndAddress; PEPROCESS CurrentProcess = PsGetCurrentProcess(); - DPRINT("MmFreeMemoryArea(AddressSpace %x, BaseAddress %x, Length %x," - "FreePageContext %d)\n",AddressSpace,BaseAddress,Length, - FreePageContext); - - MemoryArea = MmOpenMemoryAreaByAddress(AddressSpace, - BaseAddress); - if (MemoryArea == NULL) - { - KEBUGCHECK(0); - return(STATUS_UNSUCCESSFUL); - } if (AddressSpace->Process != NULL && - AddressSpace->Process != CurrentProcess) + AddressSpace->Process != CurrentProcess) { KeAttachProcess(&AddressSpace->Process->Pcb); } - EndAddress = (char*)MemoryArea->BaseAddress + PAGE_ROUND_UP(MemoryArea->Length); - for (Address = MemoryArea->BaseAddress; Address < EndAddress; Address += PAGE_SIZE) + + EndAddress = MM_ROUND_UP(MemoryArea->EndingAddress, PAGE_SIZE); + for (Address = MemoryArea->StartingAddress; Address < EndAddress; Address += PAGE_SIZE) { - if (MemoryArea->Type == MEMORY_AREA_IO_MAPPING) { - MmRawDeleteVirtualMapping(Address); + MmRawDeleteVirtualMapping((PVOID)Address); } else { - BOOL Dirty = FALSE; + BOOL Dirty = FALSE; SWAPENTRY SwapEntry = 0; - PFN_TYPE Page = 0; + PFN_TYPE Page = 0; - - if (MmIsPageSwapEntry(AddressSpace->Process, Address)) + if (MmIsPageSwapEntry(AddressSpace->Process, (PVOID)Address)) { - MmDeletePageFileMapping(AddressSpace->Process, Address, &SwapEntry); + MmDeletePageFileMapping(AddressSpace->Process, (PVOID)Address, &SwapEntry); } else { - MmDeleteVirtualMapping(AddressSpace->Process, Address, FALSE, &Dirty, &Page); + MmDeleteVirtualMapping(AddressSpace->Process, (PVOID)Address, FALSE, &Dirty, &Page); } if (FreePage != NULL) { - FreePage(FreePageContext, MemoryArea, Address, - Page, SwapEntry, (BOOLEAN)Dirty); + FreePage(FreePageContext, MemoryArea, (PVOID)Address, + Page, SwapEntry, (BOOLEAN)Dirty); } } } + if (AddressSpace->Process != NULL && - AddressSpace->Process != CurrentProcess) + AddressSpace->Process != CurrentProcess) { KeDetachProcess(); } - RemoveEntryList(&MemoryArea->Entry); + + /* Remove the tree item. */ + { + if (MemoryArea->Parent != NULL) + { + if (MemoryArea->Parent->LeftChild == MemoryArea) + ParentReplace = &MemoryArea->Parent->LeftChild; + else + ParentReplace = &MemoryArea->Parent->RightChild; + } + else + ParentReplace = &AddressSpace->MemoryAreaRoot; + + if (MemoryArea->RightChild == NULL) + { + *ParentReplace = MemoryArea->LeftChild; + if (MemoryArea->LeftChild) + MemoryArea->LeftChild->Parent = MemoryArea->Parent; + } + else + { + if (MemoryArea->RightChild->LeftChild == NULL) + { + MemoryArea->RightChild->LeftChild = MemoryArea->LeftChild; + if (MemoryArea->LeftChild) + MemoryArea->LeftChild->Parent = MemoryArea->RightChild; + + *ParentReplace = MemoryArea->RightChild; + MemoryArea->RightChild->Parent = MemoryArea->Parent; + } + else + { + PMEMORY_AREA LowestNode; + + LowestNode = MemoryArea->RightChild->LeftChild; + while (LowestNode->LeftChild != NULL) + LowestNode = LowestNode->LeftChild; + + LowestNode->Parent->LeftChild = LowestNode->RightChild; + if (LowestNode->RightChild) + LowestNode->RightChild->Parent = LowestNode->Parent; + + LowestNode->LeftChild = MemoryArea->LeftChild; + if (MemoryArea->LeftChild) + MemoryArea->LeftChild->Parent = LowestNode; + + LowestNode->RightChild = MemoryArea->RightChild; + MemoryArea->RightChild->Parent = LowestNode; + + *ParentReplace = LowestNode; + LowestNode->Parent = MemoryArea->Parent; + } + } + } + ExFreePool(MemoryArea); - DPRINT("MmFreeMemoryArea() succeeded\n"); + DPRINT("MmFreeMemoryAreaByNode() succeeded\n"); - return(STATUS_SUCCESS); + return STATUS_SUCCESS; } -NTSTATUS MmCreateMemoryArea(PEPROCESS Process, - PMADDRESS_SPACE AddressSpace, - ULONG Type, - PVOID* BaseAddress, - ULONG Length, - ULONG Attributes, - MEMORY_AREA** Result, - BOOL FixedAddress, - BOOL TopDown, - PHYSICAL_ADDRESS BoundaryAddressMultiple) + +NTSTATUS STDCALL +MmFreeMemoryAreaByPtr( + PMADDRESS_SPACE AddressSpace, + PVOID BaseAddress, + PMM_FREE_PAGE_FUNC FreePage, + PVOID FreePageContext) +{ + PMEMORY_AREA MemoryArea; + + DPRINT("MmFreeMemoryArea(AddressSpace %x, BaseAddress %x, Length %x," + "FreePageContext %d)\n",AddressSpace,BaseAddress,Length, + FreePageContext); + + MmVerifyMemoryAreas(AddressSpace); + + MemoryArea = MmOpenMemoryAreaByAddress(AddressSpace, + BaseAddress); + if (MemoryArea == NULL) + { + KEBUGCHECK(0); + return(STATUS_UNSUCCESSFUL); + } + + return MmFreeMemoryArea(AddressSpace, MemoryArea, FreePage, FreePageContext); +} + /* - * FUNCTION: Create a memory area - * ARGUMENTS: - * AddressSpace = Address space to create the area in - * Type = Type of the address space - * BaseAddress = - * Length = Length to allocate - * Attributes = Protection attributes for the memory area - * Result = Receives a pointer to the memory area on exit - * RETURNS: Status - * NOTES: Lock the address space before calling this function + * @name MmCreateMemoryArea + * + * Create a memory area. + * + * @param AddressSpace + * Address space to create the area in. + * @param Type + * Type of the memory area. + * @param BaseAddress + * Base address for the memory area we're about the create. On + * input it contains either 0 (auto-assign address) or preferred + * address. On output it contains the starting address of the + * newly created area. + * @param Length + * Length of the area to allocate. + * @param Attributes + * Protection attributes for the memory area. + * @param Result + * Receives a pointer to the memory area on successful exit. + * + * @return Status + * + * @remarks Lock the address space before calling this function. */ + +NTSTATUS STDCALL +MmCreateMemoryArea(PEPROCESS Process, + PMADDRESS_SPACE AddressSpace, + ULONG Type, + PVOID *BaseAddress, + ULONG_PTR Length, + ULONG Attributes, + PMEMORY_AREA *Result, + BOOLEAN FixedAddress, + BOOLEAN TopDown, + PHYSICAL_ADDRESS BoundaryAddressMultiple) { PVOID EndAddress; ULONG Granularity; ULONG tmpLength; - DPRINT("MmCreateMemoryArea(Type %d, BaseAddress %x," - "*BaseAddress %x, Length %x, Attributes %x, Result %x)\n", - Type,BaseAddress,*BaseAddress,Length,Attributes,Result); + DPRINT("MmCreateMemoryArea(Type %d, BaseAddress %x, " + "*BaseAddress %x, Length %x, Attributes %x, TopDown: %x, " + "FixedAddress %x, Result %x)\n", + Type, BaseAddress, *BaseAddress, Length, Attributes, TopDown, + FixedAddress, Result); + + MmVerifyMemoryAreas(AddressSpace); + Granularity = (MEMORY_AREA_VIRTUAL_MEMORY == Type ? MM_VIRTMEM_GRANULARITY : PAGE_SIZE); if ((*BaseAddress) == 0 && !FixedAddress) { tmpLength = PAGE_ROUND_UP(Length); *BaseAddress = MmFindGap(AddressSpace, - PAGE_ROUND_UP(Length), + tmpLength, Granularity, - TopDown); + TopDown != 0); if ((*BaseAddress) == 0) { DPRINT("No suitable gap\n"); @@ -544,26 +781,28 @@ } else { - tmpLength = Length + ((ULONG_PTR) *BaseAddress - - (ULONG_PTR) MM_ROUND_DOWN(*BaseAddress, Granularity)); + tmpLength = Length + ((ULONG_PTR) *BaseAddress + - (ULONG_PTR) MM_ROUND_DOWN(*BaseAddress, Granularity)); *BaseAddress = MM_ROUND_DOWN(*BaseAddress, Granularity); if (AddressSpace->LowestAddress == (PVOID)KERNEL_BASE && - (*BaseAddress) < (PVOID)KERNEL_BASE) + *BaseAddress < (PVOID)KERNEL_BASE) { + CHECKPOINT; return STATUS_ACCESS_VIOLATION; } if (AddressSpace->LowestAddress < (PVOID)KERNEL_BASE && - (PVOID)((char*)(*BaseAddress) + tmpLength) > (PVOID)KERNEL_BASE) + (ULONG_PTR)(*BaseAddress) + tmpLength > KERNEL_BASE) { + CHECKPOINT; return STATUS_ACCESS_VIOLATION; } if (BoundaryAddressMultiple.QuadPart != 0) { EndAddress = ((char*)(*BaseAddress)) + tmpLength-1; - ASSERT(((DWORD_PTR)*BaseAddress/BoundaryAddressMultiple.QuadPart) == ((DWORD_PTR)EndAddress/BoundaryAddressMultiple.QuadPart)); + ASSERT(((ULONG_PTR)*BaseAddress/BoundaryAddressMultiple.QuadPart) == ((DWORD_PTR)EndAddress/BoundaryAddressMultiple.QuadPart)); } if (MmOpenMemoryAreaByRegion(AddressSpace, @@ -579,8 +818,8 @@ TAG_MAREA); RtlZeroMemory(*Result,sizeof(MEMORY_AREA)); (*Result)->Type = Type; - (*Result)->BaseAddress = *BaseAddress; - (*Result)->Length = tmpLength; + (*Result)->StartingAddress = *BaseAddress; + (*Result)->EndingAddress = *BaseAddress + tmpLength; (*Result)->Attributes = Attributes; (*Result)->LockCount = 0; (*Result)->Process = Process; @@ -589,38 +828,40 @@ MmInsertMemoryArea(AddressSpace, *Result); - DPRINT("MmCreateMemoryArea() succeeded\n"); + DPRINT("MmCreateMemoryArea() succeeded (%x)\n", *BaseAddress); return STATUS_SUCCESS; } -void +VOID STDCALL MmReleaseMemoryAreaIfDecommitted(PEPROCESS Process, PMADDRESS_SPACE AddressSpace, PVOID BaseAddress) { - PMEMORY_AREA MemoryArea; - PLIST_ENTRY Entry; - PMM_REGION Region; - BOOLEAN Reserved; + PMEMORY_AREA MemoryArea; + PLIST_ENTRY Entry; + PMM_REGION Region; + BOOLEAN Reserved; - MemoryArea = MmOpenMemoryAreaByAddress(AddressSpace, BaseAddress); - if (NULL != MemoryArea) - { + MmVerifyMemoryAreas(AddressSpace); + + MemoryArea = MmOpenMemoryAreaByAddress(AddressSpace, BaseAddress); + if (MemoryArea != NULL) + { Entry = MemoryArea->Data.VirtualMemoryData.RegionListHead.Flink; Reserved = TRUE; while (Reserved && Entry != &MemoryArea->Data.VirtualMemoryData.RegionListHead) - { - Region = CONTAINING_RECORD(Entry, MM_REGION, RegionListEntry); - Reserved = (MEM_RESERVE == Region->Type); - Entry = Entry->Flink; - } + { + Region = CONTAINING_RECORD(Entry, MM_REGION, RegionListEntry); + Reserved = (MEM_RESERVE == Region->Type); + Entry = Entry->Flink; + } if (Reserved) - { - MmFreeVirtualMemory(Process, MemoryArea); - } - } + { + MmFreeVirtualMemory(Process, MemoryArea); + } + } } /* EOF */ Index: mm/virtual.c =================================================================== --- mm/virtual.c (revision 12712) +++ mm/virtual.c (working copy) @@ -204,9 +204,10 @@ Info->State = MEM_FREE; Info->Protect = MemoryArea->Attributes; Info->AllocationProtect = MemoryArea->Attributes; - Info->BaseAddress = MemoryArea->BaseAddress; - Info->AllocationBase = MemoryArea->BaseAddress; - Info->RegionSize = MemoryArea->Length; + Info->BaseAddress = MemoryArea->StartingAddress; + Info->AllocationBase = MemoryArea->StartingAddress; + Info->RegionSize = (ULONG_PTR)MemoryArea->EndingAddress - + (ULONG_PTR)MemoryArea->StartingAddress; Status = STATUS_SUCCESS; *ResultLength = sizeof(MEMORY_BASIC_INFORMATION); break; @@ -215,9 +216,10 @@ Info->State = MEM_COMMIT; Info->Protect = MemoryArea->Attributes; Info->AllocationProtect = MemoryArea->Attributes; - Info->BaseAddress = MemoryArea->BaseAddress; - Info->AllocationBase = MemoryArea->BaseAddress; - Info->RegionSize = MemoryArea->Length; + Info->BaseAddress = MemoryArea->StartingAddress; + Info->AllocationBase = MemoryArea->StartingAddress; + Info->RegionSize = (ULONG_PTR)MemoryArea->EndingAddress - + (ULONG_PTR)MemoryArea->StartingAddress; Status = STATUS_SUCCESS; *ResultLength = sizeof(MEMORY_BASIC_INFORMATION); break; @@ -235,9 +237,10 @@ Info->State = MEM_COMMIT; Info->Protect = MemoryArea->Attributes; Info->AllocationProtect = MemoryArea->Attributes; - Info->BaseAddress = MemoryArea->BaseAddress; - Info->AllocationBase = MemoryArea->BaseAddress; - Info->RegionSize = MemoryArea->Length; + Info->BaseAddress = MemoryArea->StartingAddress; + Info->AllocationBase = MemoryArea->StartingAddress; + Info->RegionSize = (ULONG_PTR)MemoryArea->EndingAddress - + (ULONG_PTR)MemoryArea->StartingAddress; Status = STATUS_SUCCESS; *ResultLength = sizeof(MEMORY_BASIC_INFORMATION); break; @@ -255,9 +258,10 @@ Info->State = MEM_COMMIT; Info->Protect = MemoryArea->Attributes; Info->AllocationProtect = MemoryArea->Attributes; - Info->BaseAddress = MemoryArea->BaseAddress; - Info->AllocationBase = MemoryArea->BaseAddress; - Info->RegionSize = MemoryArea->Length; + Info->BaseAddress = MemoryArea->StartingAddress; + Info->AllocationBase = MemoryArea->StartingAddress; + Info->RegionSize = (ULONG_PTR)MemoryArea->EndingAddress - + (ULONG_PTR)MemoryArea->StartingAddress; Status = STATUS_SUCCESS; *ResultLength = sizeof(MEMORY_BASIC_INFORMATION); break; Index: mm/anonmem.c =================================================================== --- mm/anonmem.c (revision 12712) +++ mm/anonmem.c (working copy) @@ -261,7 +261,7 @@ /* * Get the segment corresponding to the virtual address */ - Region = MmFindRegion(MemoryArea->BaseAddress, + Region = MmFindRegion(MemoryArea->StartingAddress, &MemoryArea->Data.VirtualMemoryData.RegionListHead, Address, NULL); if (Region->Type == MEM_RESERVE || Region->Protect == PAGE_NOACCESS) @@ -525,6 +525,7 @@ { PEPROCESS Process; MEMORY_AREA* MemoryArea; + ULONG_PTR MemoryAreaLength; ULONG Type; NTSTATUS Status; PMADDRESS_SPACE AddressSpace; @@ -582,40 +583,44 @@ MemoryArea = MmOpenMemoryAreaByAddress(AddressSpace, BaseAddress); - if (MemoryArea != NULL && - MemoryArea->Type == MEMORY_AREA_VIRTUAL_MEMORY && - MemoryArea->Length >= RegionSize) + if (MemoryArea != NULL) { - Status = - MmAlterRegion(AddressSpace, - MemoryArea->BaseAddress, - &MemoryArea->Data.VirtualMemoryData.RegionListHead, - BaseAddress, RegionSize, - Type, Protect, MmModifyAttributes); - MmUnlockAddressSpace(AddressSpace); - ObDereferenceObject(Process); - DPRINT("NtAllocateVirtualMemory() = %x\n",Status); - return(Status); + MemoryAreaLength = (ULONG_PTR)MemoryArea->EndingAddress - + (ULONG_PTR)MemoryArea->StartingAddress; + if (MemoryArea->Type == MEMORY_AREA_VIRTUAL_MEMORY && + MemoryAreaLength >= RegionSize) + { + Status = + MmAlterRegion(AddressSpace, + MemoryArea->StartingAddress, + &MemoryArea->Data.VirtualMemoryData.RegionListHead, + BaseAddress, RegionSize, + Type, Protect, MmModifyAttributes); + MmUnlockAddressSpace(AddressSpace); + ObDereferenceObject(Process); + DPRINT("NtAllocateVirtualMemory() = %x\n",Status); + return(Status); + } + else if (MemoryAreaLength >= RegionSize) + { + Status = + MmAlterRegion(AddressSpace, + MemoryArea->StartingAddress, + &MemoryArea->Data.SectionData.RegionListHead, + BaseAddress, RegionSize, + Type, Protect, MmModifyAttributes); + MmUnlockAddressSpace(AddressSpace); + ObDereferenceObject(Process); + DPRINT("NtAllocateVirtualMemory() = %x\n",Status); + return(Status); + } + else + { + MmUnlockAddressSpace(AddressSpace); + ObDereferenceObject(Process); + return(STATUS_UNSUCCESSFUL); + } } - else if (MemoryArea != NULL && MemoryArea->Length >= RegionSize) - { - Status = - MmAlterRegion(AddressSpace, - MemoryArea->BaseAddress, - &MemoryArea->Data.SectionData.RegionListHead, - BaseAddress, RegionSize, - Type, Protect, MmModifyAttributes); - MmUnlockAddressSpace(AddressSpace); - ObDereferenceObject(Process); - DPRINT("NtAllocateVirtualMemory() = %x\n",Status); - return(Status); - } - else if (MemoryArea != NULL) - { - MmUnlockAddressSpace(AddressSpace); - ObDereferenceObject(Process); - return(STATUS_UNSUCCESSFUL); - } } Status = MmCreateMemoryArea(Process, @@ -626,7 +631,7 @@ Protect, &MemoryArea, PBaseAddress != 0, - (AllocationType & MEM_TOP_DOWN), + (AllocationType & MEM_TOP_DOWN) == MEM_TOP_DOWN, BoundaryAddressMultiple); if (!NT_SUCCESS(Status)) { @@ -635,18 +640,22 @@ DPRINT("NtAllocateVirtualMemory() = %x\n",Status); return(Status); } + + MemoryAreaLength = (ULONG_PTR)MemoryArea->EndingAddress - + (ULONG_PTR)MemoryArea->StartingAddress; + MmInitialiseRegion(&MemoryArea->Data.VirtualMemoryData.RegionListHead, - MemoryArea->Length, Type, Protect); + MemoryAreaLength, Type, Protect); if ((AllocationType & MEM_COMMIT) && ((Protect & PAGE_READWRITE) || (Protect & PAGE_EXECUTE_READWRITE))) { - MmReserveSwapPages(MemoryArea->Length); + MmReserveSwapPages(MemoryAreaLength); } *UBaseAddress = BaseAddress; - *URegionSize = MemoryArea->Length; + *URegionSize = MemoryAreaLength; DPRINT("*UBaseAddress %x *URegionSize %x\n", BaseAddress, RegionSize); MmUnlockAddressSpace(AddressSpace); @@ -702,7 +711,11 @@ */ if (MemoryArea->PageOpCount > 0) { - for (i = 0; i < PAGE_ROUND_UP(MemoryArea->Length) / PAGE_SIZE; i++) + ULONG_PTR MemoryAreaLength = (ULONG_PTR)MemoryArea->EndingAddress - + (ULONG_PTR)MemoryArea->StartingAddress; + + /* FiN TODO: Optimize loop counter! */ + for (i = 0; i < PAGE_ROUND_UP(MemoryAreaLength) / PAGE_SIZE; i++) { PMM_PAGEOP PageOp; @@ -712,7 +725,7 @@ } PageOp = MmCheckForPageOp(MemoryArea, Process->UniqueProcessId, - (char*)MemoryArea->BaseAddress + (i * PAGE_SIZE), + (PVOID)((ULONG_PTR)MemoryArea->StartingAddress + (i * PAGE_SIZE)), NULL, 0); if (PageOp != NULL) { @@ -745,8 +758,7 @@ /* Actually free the memory area. */ MmFreeMemoryArea(&Process->AddressSpace, - MemoryArea->BaseAddress, - 0, + MemoryArea, MmFreeVirtualMemoryPage, (PVOID)Process); } @@ -814,7 +826,7 @@ { case MEM_RELEASE: /* We can only free a memory area in one step. */ - if (MemoryArea->BaseAddress != BaseAddress || + if (MemoryArea->StartingAddress != BaseAddress || MemoryArea->Type != MEMORY_AREA_VIRTUAL_MEMORY) { MmUnlockAddressSpace(AddressSpace); @@ -829,7 +841,7 @@ case MEM_DECOMMIT: Status = MmAlterRegion(AddressSpace, - MemoryArea->BaseAddress, + MemoryArea->StartingAddress, &MemoryArea->Data.VirtualMemoryData.RegionListHead, BaseAddress, RegionSize, @@ -856,11 +868,11 @@ PMM_REGION Region; NTSTATUS Status; - Region = MmFindRegion(MemoryArea->BaseAddress, + Region = MmFindRegion(MemoryArea->StartingAddress, &MemoryArea->Data.VirtualMemoryData.RegionListHead, BaseAddress, NULL); *OldProtect = Region->Protect; - Status = MmAlterRegion(AddressSpace, MemoryArea->BaseAddress, + Status = MmAlterRegion(AddressSpace, MemoryArea->StartingAddress, &MemoryArea->Data.VirtualMemoryData.RegionListHead, BaseAddress, Length, Region->Type, Protect, MmModifyAttributes); @@ -878,11 +890,11 @@ Info->BaseAddress = (PVOID)PAGE_ROUND_DOWN(Address); - Region = MmFindRegion(MemoryArea->BaseAddress, + Region = MmFindRegion(MemoryArea->StartingAddress, &MemoryArea->Data.VirtualMemoryData.RegionListHead, Address, &RegionBase); Info->BaseAddress = RegionBase; - Info->AllocationBase = MemoryArea->BaseAddress; + Info->AllocationBase = MemoryArea->StartingAddress; Info->AllocationProtect = MemoryArea->Attributes; Info->RegionSize = (char*)RegionBase + Region->Length - (char*)Info->BaseAddress; Info->State = Region->Type; Index: mm/rmap.c =================================================================== --- mm/rmap.c (revision 12712) +++ mm/rmap.c (working copy) @@ -91,7 +91,7 @@ } Process = entry->Process; Address = entry->Address; - if ((((ULONG)Address) & 0xFFF) != 0) + if ((((ULONG_PTR)Address) & 0xFFF) != 0) { KEBUGCHECK(0); } @@ -131,7 +131,7 @@ Type = MemoryArea->Type; if (Type == MEMORY_AREA_SECTION_VIEW) { - Offset = (ULONG)((char*)Address - (ULONG)MemoryArea->BaseAddress); + Offset = (ULONG_PTR)Address - (ULONG_PTR)MemoryArea->StartingAddress; /* * Get or create a pageop @@ -220,7 +220,7 @@ } Process = entry->Process; Address = entry->Address; - if ((((ULONG)Address) & 0xFFF) != 0) + if ((((ULONG_PTR)Address) & 0xFFF) != 0) { KEBUGCHECK(0); } @@ -255,7 +255,7 @@ Type = MemoryArea->Type; if (Type == MEMORY_AREA_SECTION_VIEW) { - Offset = (ULONG)((char*)Address - (ULONG)MemoryArea->BaseAddress); + Offset = (ULONG_PTR)Address - (ULONG_PTR)MemoryArea->StartingAddress; /* * Get or create a pageop Index: mm/cont.c =================================================================== --- mm/cont.c (revision 12712) +++ mm/cont.c (working copy) @@ -42,7 +42,7 @@ { PMEMORY_AREA MArea; NTSTATUS Status; - PVOID BaseAddress = 0; + PVOID BaseAddress = NULL; PFN_TYPE PBase; ULONG Attributes; ULONG i; @@ -83,8 +83,7 @@ { MmLockAddressSpace(MmGetKernelAddressSpace()); MmFreeMemoryArea(MmGetKernelAddressSpace(), - BaseAddress, - 0, + MArea, NULL, NULL); MmUnlockAddressSpace(MmGetKernelAddressSpace()); @@ -174,11 +173,10 @@ MmFreeContiguousMemory(IN PVOID BaseAddress) { MmLockAddressSpace(MmGetKernelAddressSpace()); - MmFreeMemoryArea(MmGetKernelAddressSpace(), - BaseAddress, - 0, - MmFreeContinuousPage, - NULL); + MmFreeMemoryAreaByPtr(MmGetKernelAddressSpace(), + BaseAddress, + MmFreeContinuousPage, + NULL); MmUnlockAddressSpace(MmGetKernelAddressSpace()); } @@ -260,11 +258,10 @@ IN MEMORY_CACHING_TYPE CacheType) { MmLockAddressSpace(MmGetKernelAddressSpace()); - MmFreeMemoryArea(MmGetKernelAddressSpace(), - BaseAddress, - NumberOfBytes, - MmFreeContinuousPage, - NULL); + MmFreeMemoryAreaByPtr(MmGetKernelAddressSpace(), + BaseAddress, + MmFreeContinuousPage, + NULL); MmUnlockAddressSpace(MmGetKernelAddressSpace()); } Index: mm/iospace.c =================================================================== --- mm/iospace.c (revision 12712) +++ mm/iospace.c (working copy) @@ -127,7 +127,7 @@ KEBUGCHECK(0); } } - return ((PVOID)((char*)Result + Offset)); + return (PVOID)((ULONG_PTR)Result + Offset); } @@ -160,16 +160,17 @@ IN ULONG NumberOfBytes) { ULONG Offset; - Offset = (ULONG_PTR)BaseAddress % PAGE_SIZE; - BaseAddress = (PVOID)((PUCHAR)BaseAddress - Offset); + PVOID Address = BaseAddress; + + Offset = (ULONG_PTR)Address % PAGE_SIZE; + Address -= Offset; NumberOfBytes += Offset; MmLockAddressSpace(MmGetKernelAddressSpace()); - MmFreeMemoryArea(MmGetKernelAddressSpace(), - BaseAddress, - NumberOfBytes, - NULL, - NULL); + MmFreeMemoryAreaByPtr(MmGetKernelAddressSpace(), + Address, + NULL, + NULL); MmUnlockAddressSpace(MmGetKernelAddressSpace()); } Index: mm/drvlck.c =================================================================== --- mm/drvlck.c (revision 12712) +++ mm/drvlck.c (working copy) @@ -64,7 +64,7 @@ MmLockPagableDataSection(IN PVOID AddressWithinSection) { PVOID Handle; - Handle = MmOpenMemoryAreaByAddress(NULL,AddressWithinSection); + Handle = MmOpenMemoryAreaByAddress(NULL, AddressWithinSection); MmLockPagableSectionByHandle(Handle); return(Handle); } Index: mm/aspace.c =================================================================== --- mm/aspace.c (revision 12712) +++ mm/aspace.c (working copy) @@ -68,7 +68,7 @@ MmInitializeAddressSpace(PEPROCESS Process, PMADDRESS_SPACE AddressSpace) { - InitializeListHead(&AddressSpace->MAreaListHead); + AddressSpace->MemoryAreaRoot = NULL; ExInitializeFastMutex(&AddressSpace->Lock); if (Process != NULL) { Index: mm/mminit.c =================================================================== --- mm/mminit.c (revision 12712) +++ mm/mminit.c (working copy) @@ -480,10 +480,9 @@ MiFreeInitMemory(VOID) { MmLockAddressSpace(MmGetKernelAddressSpace()); - MmFreeMemoryArea(MmGetKernelAddressSpace(), - (PVOID)&_init_start__, - PAGE_ROUND_UP((ULONG)&_init_end__) - (ULONG)&_init_start__, - MiFreeInitMemoryPage, - NULL); + MmFreeMemoryAreaByPtr(MmGetKernelAddressSpace(), + (PVOID)&_init_start__, + MiFreeInitMemoryPage, + NULL); MmUnlockAddressSpace(MmGetKernelAddressSpace()); }

1 0

Re: [ros-svn] [hbirr] 12690: - Implemented KeAcquireInterruptSpinLock and KeReleaseInterruptSpinLock.
by Alex Ionescu 01 Jan '05

01 Jan '05

hbirr(a)svn.reactos.com wrote: >- Implemented KeAcquireInterruptSpinLock and KeReleaseInterruptSpinLock. >- Implemented the interrupt handling for smp machines. > > > >Updated files: >trunk/reactos/include/ddk/kefuncs.h >trunk/reactos/include/ntos/zwtypes.h >trunk/reactos/ntoskrnl/io/irq.c >trunk/reactos/ntoskrnl/ke/i386/irq.c >trunk/reactos/ntoskrnl/ke/spinlock.c > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-svn > > > Hi, Thanks for adding this feature to the kernel, I only have one problem with it... Would it be possible to modify the code to use the documented KINTERRUPT structure? This would (already does) wreck havoc on the new header system, which uses documented Windows structures (except in extreme cases where our code is very old, and those structures were unavailable, ie the Ob Manager structures... although enventually that code will have to be updated). The correct KINTERRUPT structure is: typedef struct _KINTERRUPT { CSHORT Type; CSHORT Size; LIST_ENTRY InterruptListEntry; PKSERVICE_ROUTINE ServiceRoutine; PVOID ServiceContext; KSPIN_LOCK SpinLock; ULONG TickCount; PKSPIN_LOCK ActualLock; PVOID DispatchAddress; ULONG Vector; KIRQL Irql; KIRQL SynchronizeIrql; BOOLEAN FloatingSave; BOOLEAN Connected; CHAR Number; UCHAR ShareVector; KINTERRUPT_MODE Mode; ULONG ServiceCount; ULONG DispatchCount; ULONG DispatchCode[106]; } *KINTERRUPT*, *PKINTERRUPT; vs ours: typedef struct _KINTERRUPT { ULONG Vector; KAFFINITY ProcessorEnableMask; KSPIN_LOCK SpinLock; PKSPIN_LOCK ActualLock; BOOLEAN Shareable; BOOLEAN FloatingSave; CHAR ProcessorNumber; PKSERVICE_ROUTINE ServiceRoutine; PVOID ServiceContext; LIST_ENTRY Entry; KIRQL Irql; KIRQL SynchLevel; KINTERRUPT_MODE InterruptMode; } KINTERRUPT; Type/Size are Windows Ob Manager headers for each Object...if you look in KOBJECTS you'll find the right value...but we don't check for this yet, so it's not important yet. I don't know what "Shareable" is however. But we only need to rename/reposition some of the items. ProcessorEnableMask also seems to be missing in the real defintion. If you'd be kind enough to do these changes, I would really appreciate it. If you have any comments, let me know. Best regards, and happy new year, Alex Ionescu

2 3

KeConnectInterrupt & ListHeads
by David Kredba 01 Jan '05

01 Jan '05

Hello, I got this with current svn tree : make[1]: Entering directory `/home/dave2/ros/reactos/ntoskrnl' ../tools/regtests ./tests/tests ./tests/_regtests.c ./tests/Makefile.tests -e ./tests/_rtstub.c ../tools/regtests -s ./tests/stubs.tst ./tests/_stubs.S ./tests/_hooks.c mingw32-windres --include-dir ../include --include-dir ../w32api/include ntoskrnl.rc -o ntoskrnl.coff mingw32-gcc -c -x assembler-with-cpp -I./include -g -I../include -I../w32api/include -D__ASM__ -D_M_IX86 -D__3GB__ -c ke/i386/multiboot.S -o ke/i386/multiboot.o mingw32-gcc -I./include -I../lib/kjs/include -Wall -Werror -D_DISABLE_TIDENTS -D__3GB__ -D__NTOSKRNL__ -I. -D_SEH_NO_NATIVE_NLG -I../include -I../w32api/include -pipe -march=i486 -D_M_IX86 -g include/ntoskrnl.h mingw32-gcc -I./include -I../lib/kjs/include -Wall -Werror -D_DISABLE_TIDENTS -D__3GB__ -D__NTOSKRNL__ -I. -D_SEH_NO_NATIVE_NLG -I../include -I../w32api/include -pipe -march=i486 -D_M_IX86 -g -c ex/i386/interlck.c -o ex/i386/interlck.o mingw32-gcc -I./include -I../lib/kjs/include -Wall -Werror -D_DISABLE_TIDENTS -D__3GB__ -D__NTOSKRNL__ -I. -D_SEH_NO_NATIVE_NLG -I../include -I../w32api/include -pipe -march=i486 -D_M_IX86 -g -c ke/i386/exp.c -o ke/i386/exp.o mingw32-gcc -I./include -I../lib/kjs/include -Wall -Werror -D_DISABLE_TIDENTS -D__3GB__ -D__NTOSKRNL__ -I. -D_SEH_NO_NATIVE_NLG -I../include -I../w32api/include -pipe -march=i486 -D_M_IX86 -g -c ke/i386/irq.c -o ke/i386/irq.o ke/i386/irq.c: In function `KeConnectInterrupt': ke/i386/irq.c:496: error: structure has no member named `ListHeads' make[1]: *** [ke/i386/irq.o] Error 1 make[1]: Leaving directory `/home/dave2/ros/reactos/ntoskrnl' make: *** [ntoskrnl] Error 2 Thanks, David

3 3

¿Serious Bug with ReactOS liveCD RC-2?
by Lucio Diaz 01 Jan '05

01 Jan '05

I tested the live cd in a: -Intel 1.6 GHZ -Mainboard Intel 82801BA and CD drives -TEAC CD-540E -Yamaha CRW8424E The liveCD was in the Yamaha drive, all worked normally till i log off, the computer resets as normally and sudenly when the computer loads again it does not detect the yamaha CD, i tried reseting several times to try to put back online but not even the light of the yamaha turned on. I finaly turned down the power and swiched on again, the both CD drives where detected. Never something similar have happened to me, it is too much casual it happens on testing the liveCD just in THAT CD, but still i can not say if it is a bug of reactos or not. Another less important isue: I get the following error when accessing to the HDD E_ACCESSDENIED_WIN32 ACCESS DENIED ERROR Context:Shellfolder::Shellfolder(IShellfolder*,LPCITEMIDLST) Location: Utility/Shellclasses CPP:280 Still i can access the HDD (this happened two with the RC-1) Best Regards and Happy New Year, Lucio Diaz. ______________________________________________ Renovamos el Correo Yahoo!: ¡250 MB GRATIS! Nuevos servicios, más seguridad http://correo.yahoo.es

8 13

Re: [ros-diffs] [ion] 12682: Fix DMA_OPERATIONS to use stdcall.
by Filip Navara 01 Jan '05

01 Jan '05

ion(a)svn.reactos.com wrote: >Fix DMA_OPERATIONS to use stdcall. > >Modified: trunk/reactos/include/ddk/iotypes.h >Modified: trunk/reactos/ntoskrnl/io/pnpdma.c > > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/include/ddk/iotypes.h* > >--- trunk/reactos/include/ddk/iotypes.h 2005-01-01 08:20:47 UTC (rev 12681) >+++ trunk/reactos/include/ddk/iotypes.h 2005-01-01 08:43:02 UTC (rev 12682) >@@ -1196,18 +1196,18 @@ > > SCATTER_GATHER_ELEMENT Elements[1]; > } SCATTER_GATHER_LIST, *PSCATTER_GATHER_LIST; > > > >-typedef VOID (*PPUT_DMA_ADAPTER)( > > >+typedef VOID STDCALL (*PPUT_DMA_ADAPTER)( > > This should be written as "typedef VOID (STDCALL *PPUT_DMA_ADAPTER)" Same for the other changes you made. - Filip

1 0

(no subject)
by Stephen Hodges 01 Jan '05

01 Jan '05

Will the CVS server sync up with SVN? It would keep the cvsweb app running. Why not also sync the sourceforge project cvs with SVN? As an extra mirror How often will it sync up? Stephen Hodges HYPERLINK "http://www.thespoke.net/MyBlog/stevo/MyBlog.aspx"http://www.thespoke.net/My Blog/stevo/MyBlog.aspx -- No virus found in this outgoing message. Checked by AVG Anti-Virus. Version: 7.0.296 / Virus Database: 265.6.7 - Release Date: 12/30/2004

3 2

Generated file in repo
by Mike Lerwill 31 Dec '04

31 Dec '04

The file "wine_unicode.map" in "\lib\unicode" appears to be a file generated at build time and as such needs to be deleted from the repository Mike

1 0

CVS has been converted to Subversion
by Casper Hornstrup 31 Dec '04

31 Dec '04

See subject. Casper

5 7

Re: [ros-cvs] CVS Update: reactos
by Filip Navara 31 Dec '04

31 Dec '04

ekohl(a)cvs.reactos.com wrote: >CVSROOT: /CVS/ReactOS >Module name: reactos >Repository: reactos/drivers/fs/np/ >Changes by: ekohl(a)mok.osexperts.com 04/12/30 04:34:27 > >Modified files: > reactos/drivers/fs/np/: create.c fsctrl.c > >Log message: > Use a new passive pipe state (0) to ensure that client ends don't connect to server ends in calls to WaitNamed Pipe(). > > This change breaks services.exe. Now it stops loading auto-start drivers because it ends up waiting in ConnectNamedPipe call. Trace w/ old version (CVS 29/12): (database.c:729) Group 'Event log' (database.c:532) ScmStartService() called (database.c:535) Service->Type: 16 (database.c:568) ImagePath: 'C:\ReactOS\system32\eventlog.exe' (database.c:569) Type: 10 (create.c:224) NpfsCreateNamedPipe(DeviceObject c03ac950 Irp c04cb228) (create.c:229) FileObject c04cb038 (create.c:230) Pipe name \net\NtControlPipe (database.c:580) CreateNamedPipeW() done (database.c:621) Process Id: 7 Handle 8c (database.c:624) Thread Id: 44 Handle 90 database.c:633 (fsctrl.c:391) NpfsFileSystemContol(DeviceObject c03ac950 Irp c04cf870) (fsctrl.c:395) IoStack: c04cf8e0 (fsctrl.c:397) FileObject: c04cb038 (fsctrl.c:399) Fcb: c04cbe70 (fsctrl.c:401) Pipe: c04cbef0 (fsctrl.c:402) PipeName: \net\NtControlPipe (fsctrl.c:417) Connecting pipe \net\NtControlPipe (fsctrl.c:29) NpfsConnectPipe() (fsctrl.c:40) Waiting for connection... (fsctrl.c:84) No listening client fcb found -- waiting for client (create.c:81) NpfsCreate(DeviceObject c03ac950 Irp c05e3528) (create.c:87) FileObject c05e3440 (create.c:88) FileName \net\NtControlPipe (create.c:36) <\net\NtControlPipe> = <\net\NtControlPipe> (create.c:59) Server found! Fcb c04cbe70 (create.c:195) Setting the ConnectEvent for c04cbe70 (create.c:206) Success! (fsctrl.c:391) NpfsFileSystemContol(DeviceObject c03ac950 Irp c05e3528) (fsctrl.c:395) IoStack: c05e3598 (fsctrl.c:397) FileObject: c05e3440 (fsctrl.c:399) Fcb: c05dc788 (fsctrl.c:401) Pipe: c04cbef0 (fsctrl.c:402) PipeName: \net\NtControlPipe (fsctrl.c:437) Waitin(fsctrl.c:101) Client Fcb: c05dc788 (database.c:638) Control pipe connected! Trace w/ new version (CVS frozen): (database.c:729) Group 'Event log' (database.c:532) ScmStartService() called (database.c:535) Service->Type: 16 (database.c:568) ImagePath: 'C:\ReactOS\system32\eventlog.exe' (database.c:569) Type: 10 (create.c:237) NpfsCreateNamedPipe(DeviceObject c03aa9b0 Irp c04cb098) (create.c:242) FileObject c04caef8 (create.c:243) Pipe name \net\NtControlPipe (database.c:580) CreateNamedPipeW() done (database.c:621) Process Id: 7 Handle 8c (database.c:624) Thread Id: 44 Handle 90 database.c:633 (fsctrl.c:406) NpfsFileSystemContol(DeviceObject c03aa9b0 Irp c04cf870) (fsctrl.c:410) IoStack: c04cf8e0 (fsctrl.c:412) FileObject: c04caef8 (fsctrl.c:414) Fcb: c04cb158 (fsctrl.c:416) Pipe: c04cbe38 (fsctrl.c:417) PipeName: \net\NtControlPipe (fsctrl.c:432) Connecting pipe \net\NtControlPipe (fsctrl.c:29) NpfsConnectPipe() (fsctrl.c:40) Waiting for connection... (fsctrl.c:95) No listening client fcb found -- waiting for client (create.c:81) NpfsCreate(DeviceObject c03aa9b0 Irp c05e3728) (create.c:86) FileObject c05e3640 (create.c:87) FileName \net\NtControlPipe (create.c:94) NpfsCreate() open client end for special use! (create.c:36) <\net\NtControlPipe> = <\net\NtControlPipe> <<-- Here is doesn't connect because the server pipe is not in listening state. (create.c:219) Success! (fsctrl.c:406) NpfsFileSystemContol(DeviceObject c03aa9b0 Irp c05e3728) (fsctrl.c:410) IoStack: c05e3798 (fsctrl.c:412) FileObject: c05e3640 (fsctrl.c:414) Fcb: c05e77a0 (fsctrl.c:416) Pipe: c04cbe38 (fsctrl.c:417) PipeName: \net\NtControlPipe (fsctrl.c:452) Waiting for pipe \net\NtControlPipe (fsctrl.c:166) NpfsWaitPipe (fsctrl.c:188) Listening server fcb found -- connecting (create.c:451) NpfsClose(DeviceObject c03aa9b0 Irp c05e3728) (create.c:466) Fcb c05e77a0 (create.c:469) Closing pipe \net\NtControlPipe (create.c:483) Client (create.c:81) NpfsCreate(DeviceObject c03aa9b0 Irp c05e3618) (create.c:86) FileObject c05e7ef0 (create.c:87) FileName \net\NtControlPipe (create.c:94) NpfsCreate() open client end for special use! (create.c:36) <\net\NtControlPipe> = <\net\NtControlPipe> (create.c:219) Success! (fsctrl.c:406) NpfsFileSystemContol(DeviceObject c03aa9b0 Irp c05e3618) (fsctrl.c:410) IoStack: c05e3688 (fsctrl.c:412) FileObject: c05e7ef0 (fsctrl.c:414) Fcb: c05e9070 (fsctrl.c:416) Pipe: c04cbe38 (fsctrl.c:417) PipeName: \net\NtControlPipe (fsctrl.c:472) Get state (fsctrl.c:276) Status (0x0). (fsctrl.c:406) NpfsFileSystemContol(DeviceObject c03aa9b0 Irp c05e3618) (fsctrl.c:410) IoStack: c05e3688 (fsctrl.c:412) FileObject: c05e7ef0 (fsctrl.c:414) Fcb: c05e9070 (fsctrl.c:416) Pipe: c04cbe38 (fsctrl.c:417) PipeName: \net\NtControlPipe (fsctrl.c:477) Set state (fsctrl.c:349) Status (0x0). (rw.c:278) NpfsWrite() (rw.c:282) FileObject c05e7ef0 (rw.c:283) Pipe name \net\NtControlPipe (rw.c:302) Pipe is NOT connected! (rw.c:432) NpfsWrite done (Status c0000001)

2 1

CVS being converted to SVN
by Casper Hornstrup 31 Dec '04

31 Dec '04

The conversion process has begun. I expect it to take about 30 hours to complete. I have tagged CVS HEAD with the tag "SVN". Casper

3 4

RE: [ros-cvs] I can't find some head files
by Ge van Geldorp 31 Dec '04

31 Dec '04

> From: yang > > I got the source from cvs,but I can't find some head files > like roscfg.h. Why? And where can I get it? roscfg.h (and a few others) should be generated during build. Generated files are normally not stored in CVS. Gé van Geldorp.

1 0

Re: [ros-cvs] CVS Update: CVSROOT
by Filip Navara 30 Dec '04

30 Dec '04

Rex Jolliff wrote: >CVSROOT: /CVS/ReactOS >Module name: CVSROOT >Repository: ./ >Changes by: rex(a)mok.osexperts.com 04/12/30 10:57:07 > >Added files: > ./: writers > >Log message: > made repo read-only > > The CVS build is currently broken (blame Alex)! The attached patch fixes it. - Filip Index: lib/dbghelp/Makefile =================================================================== RCS file: /CVS/ReactOS/reactos/lib/dbghelp/Makefile,v retrieving revision 1.1 diff -u -r1.1 Makefile --- lib/dbghelp/Makefile 16 Dec 2004 17:42:10 -0000 1.1 +++ lib/dbghelp/Makefile 2 Jan 2004 21:49:46 -0000 @@ -1,409 +1,9 @@ -TOPSRCDIR = ../.. -TOPOBJDIR = ../.. -SRCDIR = . +# $Id: makefile,v 1.6 2004/01/02 19:49:45 gvg Exp $ -MODULE = dbghelp.dll -IMPORTS = psapi kernel32 ntdll +PATH_TO_TOP = ../.. -C_SRCS = \ - coff.c \ - dbghelp.c \ - elf_module.c \ - image.c \ - memory.c \ - minidump.c \ - module.c \ - msc.c \ - path.c \ - pe_module.c \ - source.c \ - stabs.c \ - stack.c \ - storage.c \ - symbol.c \ - type.c +TARGET_TYPE = winedll +include $(PATH_TO_TOP)/rules.mak -# Global rules for building dlls -*-Makefile-*- -# -# Each individual makefile should define the following variables: -# MODULE : name of the main module being built -# EXTRALIBS : extra libraries to link in (optional) -# SPEC_SRCS16 : interface definition files for 16-bit dlls (optional) -# SUBSYSTEM : (optional) subsystem (for native dlls) -# -# plus all variables required by the global Make.rules.in -# - -DLLDEFS = -DLLFLAGS = -D_REENTRANT -fPIC -DLLEXT = .so -DEFS = -D__WINESRC__ $(DLLDEFS) $(EXTRADEFS) -MAINSPEC = $(MODULE:%.dll=%).spec -SPEC_DEF = $(MAINSPEC).def -WIN16_FILES = $(SPEC_SRCS16:.spec=.spec.o) $(C_SRCS16:.c=.o) $(EXTRA_OBJS16) -ALL_OBJS = $(WIN16_FILES) $(OBJS) $(MODULE).dbg.o -ALL_LIBS = $(LIBWINE) $(EXTRALIBS) $(LIBPORT) $(LDFLAGS) $(LIBS) -IMPORTLIBS = $(DELAYIMPORTS:%=$(DLLDIR)/lib%.$(IMPLIBEXT)) $(IMPORTS:%=$(DLLDIR)/lib%.$(IMPLIBEXT)) - -all: $(MODULE)$(DLLEXT) $(SUBDIRS) - - -# Global rules shared by all makefiles -*-Makefile-*- -# -# Each individual makefile must define the following variables: -# TOPSRCDIR : top-level source directory -# TOPOBJDIR : top-level object directory -# SRCDIR : source directory for this module -# MODULE : name of the module being built -# -# Each individual makefile may define the following additional variables: -# C_SRCS : C sources for the module -# C_SRCS16 : 16-bit C sources for the module -# RC_SRCS : resource source files -# EXTRA_SRCS : extra source files for make depend -# EXTRA_OBJS : extra object files -# IMPORTS : dlls to import -# DELAYIMPORTS : dlls to import in delayed mode -# SUBDIRS : subdirectories that contain a Makefile -# EXTRASUBDIRS : subdirectories that do not contain a Makefile -# INSTALLSUBDIRS : subdirectories to run make install/uninstall into - -# First some useful definitions - -SHELL = /bin/sh -CC = gcc -CFLAGS = -g -O2 -CPPFLAGS = -LIBS = -BISON = bison -YACC = $(BISON) -y -LEX = flex -LEXLIB = -lfl -EXEEXT = -OBJEXT = o -LIBEXT = so -DLLEXT = .so -IMPLIBEXT = def -LDSHARED = $(CC) -shared $(SONAME:%=-Wl,-soname,%) $(VERSCRIPT:%=-Wl,--version-script=%) -DLLTOOL = false -DLLWRAP = -AR = ar rc -RANLIB = ranlib -STRIP = strip -WINDRES = false -LN = ln -LN_S = ln -s -TOOLSDIR = $(TOPOBJDIR) -AS = as -LD = ld -LDFLAGS = -RM = rm -f -MV = mv -LINT = -LINTFLAGS = -FONTFORGE = false -INCLUDES = -I$(SRCDIR) -I. -I$(TOPSRCDIR)/include -I$(TOPOBJDIR)/include $(EXTRAINCL) -EXTRACFLAGS = -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -ALLCFLAGS = $(INCLUDES) $(DEFS) $(DLLFLAGS) $(EXTRACFLAGS) $(CPPFLAGS) $(CFLAGS) -ALLLINTFLAGS = $(INCLUDES) $(DEFS) $(LINTFLAGS) -IDLFLAGS = $(INCLUDES) $(DEFS) $(EXTRAIDLFLAGS) -MKINSTALLDIRS= $(TOPSRCDIR)/tools/mkinstalldirs -m 755 -WINAPI_CHECK = $(TOPSRCDIR)/tools/winapi_check/winapi_check -WINEWRAPPER = $(TOPSRCDIR)/tools/winewrapper -C2MAN = $(TOPSRCDIR)/tools/c2man.pl -RUNTEST = $(TOPSRCDIR)/tools/runtest -WINEBUILD = $(TOOLSDIR)/tools/winebuild/winebuild -MAKEDEP = $(TOOLSDIR)/tools/makedep -WRC = $(TOOLSDIR)/tools/wrc/wrc -BIN2RES = $(TOOLSDIR)/tools/bin2res -WMC = $(TOOLSDIR)/tools/wmc/wmc -WIDL = $(TOOLSDIR)/tools/widl/widl -WINEGCC = $(TOOLSDIR)/tools/winegcc/winegcc -SFNT2FNT = $(TOOLSDIR)/tools/sfnt2fnt -FNT2FON = $(TOOLSDIR)/tools/fnt2fon -RC = $(WRC) -RC16 = $(WRC) -RCFLAGS = --nostdinc $(INCLUDES) $(DEFS) $(EXTRARCFLAGS) -RC16FLAGS = -O res16 $(RCFLAGS) -LDPATH = LD_LIBRARY_PATH="$(TOOLSDIR)/libs/unicode:$$LD_LIBRARY_PATH" -DLLDIR = $(TOPOBJDIR)/dlls -LIBDIR = $(TOPOBJDIR)/libs -LIBPORT = -L$(TOPOBJDIR)/libs/port -lwine_port -LIBUNICODE = -L$(TOPOBJDIR)/libs/unicode -lwine_unicode -LIBWINE = -L$(TOPOBJDIR)/libs/wine -lwine - - - -# Installation infos - -INSTALL = /usr/bin/ginstall -c $(INSTALL_FLAGS) -INSTALL_PROGRAM = ${INSTALL} $(INSTALL_PROGRAM_FLAGS) -INSTALL_SCRIPT = ${INSTALL} $(INSTALL_SCRIPT_FLAGS) -INSTALL_DATA = ${INSTALL} -m 644 $(INSTALL_DATA_FLAGS) -prefix = /usr/local -exec_prefix = ${prefix} -bindir = ${exec_prefix}/bin -libdir = ${exec_prefix}/lib -datadir = ${prefix}/share -infodir = ${prefix}/info -mandir = ${prefix}/man -sysconfdir = ${prefix}/etc -includedir = ${prefix}/include/wine -dlldir = ${exec_prefix}/lib/wine -prog_manext = 1 -api_manext = 3w -conf_manext = 5 -CLEAN_FILES = *.o *.a *.so *.ln *.$(LIBEXT) \\\#*\\\# *~ *% .\\\#* *.bak *.orig *.rej \ - *.flc *.spec.c *.spec.def *.dbg.c *.tab.c *.tab.h lex.yy.c core - -OBJS = $(C_SRCS:.c=.o) $(EXTRA_OBJS) - -RCOBJS = $(RC_SRCS:.rc=.res.o) -LINTS = $(C_SRCS:.c=.ln) - -# Implicit rules - -.SUFFIXES: .mc .rc .mc.rc .res .res.o .spec .spec.c .spec.def .idl .h .ok .sfd .ttf - -.c.o: - $(CC) -c $(ALLCFLAGS) -o $@ $< - -.s.o: - $(AS) -o $@ $< - -.mc.mc.rc: - $(LDPATH) $(WMC) -i -U -H /dev/null -o $@ $< - -.rc.res: - $(LDPATH) $(RC) $(RCFLAGS) -fo$@ $< - -.res.res.o: - $(WINDRES) -i $< -o $@ - -.spec.spec.c: - $(WINEBUILD) $(DEFS) -o $@ --main-module $(MODULE) --dll $< - -.spec.spec.def: - $(WINEBUILD) -w $(DEFS) -o $@ --def $< - -.idl.h: - $(WIDL) $(IDLFLAGS) -h -H $@ $< - -.c.ln: - $(LINT) -c $(ALLLINTFLAGS) $< || ( $(RM) $@ && exit 1 ) - -.c.ok: - $(RUNTEST) $(RUNTESTFLAGS) $< && touch $@ - -.sfd.ttf: - $(FONTFORGE) -script $(TOPSRCDIR)/fonts/genttf.ff $< - -# 'all' target first in case the enclosing Makefile didn't define any target - -all: Makefile - -filter: - @$(TOPSRCDIR)/tools/winapi/make_filter --make $(MAKE) all - -.PHONY: all filter - -# Rules for resources - -$(RC_BINARIES): $(BIN2RES) $(RC_BINSRC) - $(BIN2RES) -f -o $@ $(SRCDIR)/$(RC_BINSRC) - -$(RC_SRCS:.rc=.res) $(RC_SRCS16:.rc=.res): $(WRC) $(RC_BINARIES) - -# Rule for main module debug channels - -$(MODULE).dbg.c: $(C_SRCS) $(C_SRCS16) $(WINEBUILD) - $(WINEBUILD) $(DEFS) -o $@ --debug -C$(SRCDIR) $(C_SRCS) $(C_SRCS16) - -# Rules for makefile - -Makefile: Makefile.in $(TOPSRCDIR)/configure - @echo Makefile is older than $?, please rerun $(TOPSRCDIR)/configure - @exit 1 - -# Rule for linting - -$(MODULE).ln : $(LINTS) - if test "$(LINTS)" ; \ - then \ - $(LINT) $(ALLLINTFLAGS) -o$(MODULE) $(LINTS) ; \ - $(MV) llib-l$(MODULE).ln $(MODULE).ln ; \ - else \ - $(LINT) $(ALLLINTFLAGS) -C$(MODULE) /dev/null ; \ - fi - -lint:: $(MODULE).ln - -# Rules for Windows API checking - -winapi_check:: dummy - $(WINAPI_CHECK) $(WINAPI_CHECK_FLAGS) $(WINAPI_CHECK_EXTRA_FLAGS) . - -.PHONY: winapi_check - -# Rules for dependencies - -$(SUBDIRS:%=%/__depend__): dummy - cd `dirname $@` && $(MAKE) depend - -depend: $(IDL_SRCS:.idl=.h) $(SUBDIRS:%=%/__depend__) - $(MAKEDEP) $(INCLUDES) -C$(SRCDIR) $(C_SRCS) $(C_SRCS16) $(RC_SRCS) $(RC_SRCS16) $(MC_SRCS) $(IDL_SRCS) $(EXTRA_SRCS) - -.PHONY: depend $(SUBDIRS:%=%/__depend__) - -# Rules for cleaning - -$(SUBDIRS:%=%/__clean__): dummy - cd `dirname $@` && $(MAKE) clean - -$(SUBDIRS:%=%/__testclean__): dummy - cd `dirname $@` && $(MAKE) testclean - -$(EXTRASUBDIRS:%=%/__clean__): dummy - -cd `dirname $@` && $(RM) $(CLEAN_FILES) - -testclean:: $(SUBDIRS:%=%/__testclean__) - -clean:: $(SUBDIRS:%=%/__clean__) $(EXTRASUBDIRS:%=%/__clean__) - $(RM) $(CLEAN_FILES) $(RC_SRCS:.rc=.res) $(RC_SRCS16:.rc=.res) $(MC_SRCS:.mc=.mc.rc) $(IDL_SRCS:.idl=.h) $(PROGRAMS) $(RC_BINARIES) - -.PHONY: clean testclean $(SUBDIRS:%=%/__clean__) $(SUBDIRS:%=%/__testclean__) $(EXTRASUBDIRS:%=%/__clean__) - -# Rules for installing - -$(SUBDIRS:%=%/__install__): dummy - cd `dirname $@` && $(MAKE) install - -$(SUBDIRS:%=%/__install-lib__): dummy - cd `dirname $@` && $(MAKE) install-lib - -$(SUBDIRS:%=%/__install-dev__): dummy - cd `dirname $@` && $(MAKE) install-dev - -$(SUBDIRS:%=%/__uninstall__): dummy - cd `dirname $@` && $(MAKE) uninstall - -install:: $(INSTALLSUBDIRS:%=%/__install__) - -uninstall:: $(INSTALLSUBDIRS:%=%/__uninstall__) - -.PHONY: install install-lib install-dev uninstall \ - $(SUBDIRS:%=%/__install__) $(SUBDIRS:%=%/__uninstall__) \ - $(SUBDIRS:%=%/__install-lib__) $(SUBDIRS:%=%/__install-dev__) - -# Rules for checking that no imports are missing - -$(SUBDIRS:%=%/__checklink__): dummy - @cd `dirname $@` && $(MAKE) checklink - -.PHONY: checklink $(SUBDIRS:%=%/__checklink__) - -# Rules for testing - -$(SUBDIRS:%=%/__test__): dummy - @cd `dirname $@` && $(MAKE) test - -$(SUBDIRS:%=%/__crosstest__): dummy - @cd `dirname $@` && $(MAKE) crosstest - -.PHONY: check test crosstest $(SUBDIRS:%=%/__test__) $(SUBDIRS:%=%/__crosstest__) - -# Misc. rules - -$(MC_SRCS:.mc=.mc.rc): $(WMC) - -$(IDL_SRCS:.idl=.h): $(WIDL) - -$(SUBDIRS): dummy - @cd $@ && $(MAKE) - -dummy: - -.PHONY: dummy $(SUBDIRS) - -# End of global rules - -# Rules for .so files - -$(MODULE).so: $(MAINSPEC) $(RC_SRCS:.rc=.res) $(ALL_OBJS) $(IMPORTLIBS) Makefile.in - $(WINEGCC) -B$(TOOLSDIR)/tools/winebuild -shared $(SRCDIR)/$(MAINSPEC) $(ALL_OBJS) $(RC_SRCS:.rc=.res) $(SUBSYSTEM:%=-Wb,--subsystem,%) -o $@ -L$(DLLDIR) $(DELAYIMPORTS:%=-Wb,-d%) $(IMPORTS:%=-l%) $(ALL_LIBS) - -# Rules for .dll files - -$(MODULE): $(RCOBJS) $(OBJS) $(MODULE).dbg.o $(SPEC_DEF) $(IMPORTLIBS) Makefile.in - $(DLLWRAP) -k --def $(SPEC_DEF) -o $@ $(RCOBJS) $(OBJS) $(MODULE).dbg.o -L$(DLLDIR) $(DELAYIMPORTS:%=-l%) $(IMPORTS:%=-l%) $(ALL_LIBS) - -$(SPEC_DEF): $(WINEBUILD) - -# Rules for checking that no imports are missing - -.PHONY: checklink16 $(WIN16_FILES:%=__checklink16__%) - -$(WIN16_FILES:%=__checklink16__%): checklink16 - -checklink16:: $(MAINSPEC).o $(OBJS) $(MODULE).dbg.o dummy - $(CC) -o checklink -Wl,-rpath,$(TOPOBJDIR)/libs $(TOPSRCDIR)/dlls/checklink.c $(MAINSPEC).o $(OBJS) $(MODULE).dbg.o -L$(DLLDIR) $(ALL_LIBS) -lm && $(RM) checklink $(MAINSPEC).c $(MAINSPEC).o - -checklink:: $(WIN16_FILES:%=__checklink16__%) - -# Rules for testing - -check test:: $(SUBDIRS:%=%/__test__) - -crosstest:: $(SUBDIRS:%=%/__crosstest__) - -# Rule to explicitly generate the .spec.c for debugging - -$(MAINSPEC).c: $(MAINSPEC) $(RC_SRCS:.rc=.res) $(ALL_OBJS) $(IMPORTLIBS) $(WINEBUILD) - $(WINEBUILD) $(DEFS) $(DLLFLAGS) -o $@ --dll $(SRCDIR)/$(MAINSPEC) $(SUBSYSTEM:%=--subsystem %) $(RC_SRCS:.rc=.res) $(ALL_OBJS) -L$(DLLDIR) $(DELAYIMPORTS:%=-d%) $(IMPORTS:%=-l%) - -# Rules for auto documentation - -man: $(C_SRCS) - $(C2MAN) -o $(TOPOBJDIR)/documentation/man$(api_manext) -R$(TOPOBJDIR) -S$(api_manext) $(INCLUDES) $(MAINSPEC:%=-w %) $(SPEC_SRCS16:%=-w %) $(C_SRCS) $(C_SRCS16) - -doc-html: $(C_SRCS) - $(C2MAN) -o $(TOPOBJDIR)/documentation/html -R$(TOPOBJDIR) $(INCLUDES) -Th $(MAINSPEC:%=-w %) $(SPEC_SRCS16:%=-w %) $(C_SRCS) $(C_SRCS16) - -doc-sgml: $(C_SRCS) - $(C2MAN) -o $(TOPOBJDIR)/documentation/api-guide -R$(TOPOBJDIR) $(INCLUDES) -Ts $(MAINSPEC:%=-w %) $(SPEC_SRCS16:%=-w %) $(C_SRCS) $(C_SRCS16) - -.PHONY: man doc-html doc-sgml - -# Rules for installation - -EXE_SPECS16 = $(SPEC_SRCS16:.exe.spec=.exe) -DRV_SPECS16 = $(EXE_SPECS16:.drv.spec=.drv) -ALL_SPECS16 = $(DRV_SPECS16:.spec=.dll) - -WIN16_INSTALL = $(ALL_SPECS16:%=_install_/%) - -.PHONY: install_lib $(ALL_SPECS16:%=_install_/%) $(ALL_SPECS16:%=_uninstall_/%) - -$(ALL_SPECS16:%=_install_/%): install_lib - cd $(dlldir) && $(RM) `basename $@`$(DLLEXT) && $(LN_S) $(MODULE)$(DLLEXT) `basename $@`$(DLLEXT) - -$(ALL_SPECS16:%=_uninstall_/%): dummy - $(RM) $(dlldir)/`basename $@`$(DLLEXT) - -install_lib: $(MODULE)$(DLLEXT) - $(MKINSTALLDIRS) $(dlldir) - $(INSTALL_PROGRAM) $(MODULE)$(DLLEXT) $(dlldir)/$(MODULE)$(DLLEXT) - -install:: install_lib $(WIN16_INSTALL) - -uninstall:: $(ALL_SPECS16:%=_uninstall_/%) - $(RM) $(dlldir)/$(MODULE)$(DLLEXT) - -# Misc. rules - -$(SPEC_SRCS16:.spec=.spec.c): $(WINEBUILD) - -# End of global dll rules - -### Dependencies: +include $(TOOLS_PATH)/helper.mk Index: lib/dbghelp/dbghelp.c =================================================================== RCS file: /CVS/ReactOS/reactos/lib/dbghelp/dbghelp.c,v retrieving revision 1.2 diff -u -r1.2 dbghelp.c --- lib/dbghelp/dbghelp.c 30 Dec 2004 18:24:19 -0000 1.2 +++ lib/dbghelp/dbghelp.c 30 Dec 2004 18:49:34 -0000 @@ -26,8 +26,6 @@ #include "wine/debug.h" WINE_DEFAULT_DEBUG_CHANNEL(dbghelp); -#define YDEBUG -#define DBG /* TODO * - support for symbols' types is still partly missing Index: lib/dbghelp/stack.c =================================================================== RCS file: /CVS/ReactOS/reactos/lib/dbghelp/stack.c,v retrieving revision 1.2 diff -u -r1.2 stack.c --- lib/dbghelp/stack.c 30 Dec 2004 18:24:19 -0000 1.2 +++ lib/dbghelp/stack.c 30 Dec 2004 18:57:42 -0000 @@ -33,6 +33,9 @@ #include "thread.h" /* FIXME: must be included before winternl.h */ #include "winternl.h" #include "wine/debug.h" +#ifndef __REACTOS__ +#include "stackframe.h" +#endif WINE_DEFAULT_DEBUG_CHANNEL(dbghelp); @@ -75,7 +78,7 @@ PGET_MODULE_BASE_ROUTINE GetModuleBaseRoutine, PTRANSLATE_ADDRESS_ROUTINE f_xlat_adr) { -#if 0 +#ifndef __REACTOS__ STACK32FRAME frame32; STACK16FRAME frame16; char ch; @@ -385,5 +388,8 @@ done_err: curr_mode = stm_done; return FALSE; +#else + /* FIXME */ + return FALSE; #endif } Index: lib/dbghelp/type.c =================================================================== RCS file: /CVS/ReactOS/reactos/lib/dbghelp/type.c,v retrieving revision 1.2 diff -u -r1.2 type.c --- lib/dbghelp/type.c 30 Dec 2004 18:24:19 -0000 1.2 +++ lib/dbghelp/type.c 30 Dec 2004 18:58:56 -0000 @@ -371,10 +371,10 @@ struct symt* type; void* pos = NULL; - /* TRACE("(%p %s %p %p)\n", + TRACE("(%p %s %p %p)\n", hProcess, wine_dbgstr_longlong(BaseOfDll), EnumSymbolsCallback, UserContext); -*/ + if (!(pcs = process_find_by_handle(hProcess))) return FALSE; module = module_find_by_addr(pcs, BaseOfDll, DMT_UNKNOWN); if (!(module = module_get_debug(pcs, module))) return FALSE; @@ -755,7 +755,9 @@ module = module_find_by_addr(pcs, ModBase, DMT_UNKNOWN); if (!(module = module_get_debug(pcs, module))) { - // FIXME("Someone didn't properly set ModBase (%s)\n", wine_dbgstr_longlong(ModBase)); +#ifndef __REACTOS__ + FIXME("Someone didn't properly set ModBase (%s)\n", wine_dbgstr_longlong(ModBase)); +#endif return FALSE; }

2 3

RE: [ros-cvs] CVS Update: reactos
by Casper Hornstrup 30 Dec '04

30 Dec '04

It should be on the bootable CD too. > -----Original Message----- > From: ros-cvs-bounces(a)reactos.com > [mailto:ros-cvs-bounces@reactos.com] On Behalf Of ion(a)cvs.reactos.com > Sent: 30. december 2004 10:32 > To: ros-cvs(a)reactos.com > Subject: [ros-cvs] CVS Update: reactos > > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: ./ > Changes by: ion(a)mok.osexperts.com 04/12/30 10:31:43 > > Modified files: > ./: Makefile > > Log message: > Added dbghelp to build because it builds for now. > > _______________________________________________ > Ros-cvs mailing list > Ros-cvs(a)reactos.com > http://reactos.com/mailman/listinfo/ros-cvs >

1 0

[Patch] oskilttcp warnings
by Quandary 30 Dec '04

30 Dec '04

I've attached a patch that eliminates an irritating/verbose set of warnings generated in the vicinity of drivers/lib/oskittcp. Please check for sanity :). I added the -fno-builtin-log flag to the CFLAGS in the makefile in oskittcp; this kind of assumes GCC. I'm not sure what hooks are in place to switch between GCC/VC compiler settings, and I'm fairly certain this won't play too nice with CL.EXE. So... if there's anyone who knows the make system better than I who would resolve this loose end, that would be great :). -- Travis __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

1 0

Image downloads...
by Andrew Smith 30 Dec '04

30 Dec '04

Hi, It's my first time posting here, but I've been reading it for a little while now and I've just looked at the download section of the website again and noticed that there are premade images for Qemu and Bochs yet none for VMware or Virtual PC. Is this just because no one has created one? or are there other reasons (like licencing reasons)? If it's because no one makes one then I'd be happy to make a ZIP of the files needed that you can host. With the 0.2.4 release the ZIP is 6,232,010 bytes which includes ROS VMware driver 6.0 GB sparse virtual hard drive split into 2 GB files (setup as IDE 0:0) Auto-detect CD-ROM (setup as IDE1:0) Floppy drive Bridged NIC1 USB Controller Audio 256MB virtual RAM If you're interested then let me know. I know having a 0.2.4 ZIP is kind of pointless now with 0.2.5's release date set for the 31st. But I could get a ZIP of that release if you'd like one. -- Andy Smith - Def since birth

4 5

Crash in win32k.sys
by Maarten Bosma 30 Dec '04

30 Dec '04

After calling "NtGdiDdCreateDirectDrawObject" (ntddraw/ddraw.c) I get a bsod. The problem seams to be this line: > HANDLE hDirectDraw = GDIOBJ_AllocObj(GDI_OBJECT_TYPE_DIRECTDRAW); The debug output says: > (objects/gdiobj.c:179) Can't find lookaside list for object type 0x00600000

2 4

Re: [ros-cvs] CVS Update: reactos
by Filip Navara 30 Dec '04

30 Dec '04

Ge van Geldorp wrote: >CVSROOT: /CVS/ReactOS >Module name: reactos >Repository: reactos/subsys/win32k/objects/ >Changes by: gvg(a)mok.osexperts.com 04/12/27 12:06:56 > >Modified files: > reactos/subsys/win32k/objects/: text.c > >Log message: > Consolidate filling of TEXTMETRICS to a single location. > > This patch breaks displaying the underscore latter (in ROS console). - Filip

3 4

0.2.5 code freeze
by Ge van Geldorp 29 Dec '04

29 Dec '04

We're now in code freeze for 0.2.5. That means that only fixes for showstopper bugs will be allowed into the 0.2.5 branch and developers should discuss their fixes on the mailinglist before committing. 0.2.5 RC2 is available from our SourceForge download page. The official release for 0.2.5 will be tomorrow, just before the move to SubVersion starts. Gé van Geldorp.

1 0

Re: [ros-cvs] CVS Update: reactos - Loading of PCTV Rave drivers = Fixed
by Gge 28 Dec '04

28 Dec '04

navaraf(a)cvs.reactos.com wrote: > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: reactos/ntoskrnl/ > Changes by: navaraf(a)mok.osexperts.com 04/12/26 09:48:20 > > Modified files: > reactos/ntoskrnl/ke/: wait.c > reactos/ntoskrnl/nt/: ntsem.c > reactos/ntoskrnl/: ntoskrnl.def > > Log message: > - Export ExSemaphoreObjectType. > > _______________________________________________ This fix corrected the loading error of the BT848.SYS driver ( Tuner TV PCTV Rave) due to this non implemented funcion Regards Gerard

3 3

CVS-SVN: when will freeze & convert actually happen?
by ea＠iol.it 28 Dec '04

28 Dec '04

CVS->SVN: when will freeze & convert actually happen (date/time/UTC)? Emanuele ____________________________________________________________ Regala e regalati Libero ADSL: 3 mesi gratis e navighi veloce. 1.2 Mega di musica, film, video e sport. Abbonati subito senza costi di attivazione su http://www.libero.it

4 3

Todays CVS and PuTTY
by WaxDragon 28 Dec '04

28 Dec '04

Gang, I wasn't paying real close attention to IRC today, but I saw that someone said that with todays networking changes they were able to get to the "login:" prompt of PuTTY, but were unable to type anything into the window. Well, I couldn't help myself, so when I got home I tried out PuTTY with the same results. Not to be outdone by a bug, I pulled my private key off my existing PuTTY install and loaded the key under ros. I was able to login using auto-username and key authentication to my linux box. Of course, I was unable to type anything into the window, but I thought I would let everyone know that I was technically able to establish a SSH2 connection from ReactOS to linux. ;0) Good work! WD -- The cheese stands alone.

3 2

Fwd: Open Source Forum Russia
by Jason Filby 28 Dec '04

28 Dec '04

Hi all Please read the attached message if you live in or near Russia. Is someone willing to take the lead in manning a booth? You can even make a speech if you like :) Cheers Jason ---------- Forwarded message ---------- From: "Vera Semyonova" <vera.semyonova(a)fort-ross.ru> To: <jasonfilby(a)yahoo.com> Date: Mon, 27 Dec 2004 17:57:49 +0300 Subject: Open Source Forum Russia Dear Jason Filby, Please find hereby information about the first Open Source Forum in Russia. We will be delighted if you find an opportunity to participate with a booth in the exhibition part or (and) attend as a speaker in the conferecne program. Looking forward to hear from you, Sincerely, Vera Semyonova CEO Fort-Ross Open Source World Russia 27-29 April, 2005 Moscow, Radisson SAS Hotel Mission statement The Open Source World Russia is the first conference and exhibition in Russia which will be entirely dedicated to open source software development. The open source model has become extremely popular all over the world, and Russia is no exception. Many major international companies show their interest in promoting the open source solutions in Russia. About 75% of Russian software development companies already use the open source model for their international customers. The mission of this conference is to boost the confidence of the Russian IT market for open source solutions. Audience IT-directors, project managers, software developers, system administrators, industrial enterprise directors, representatives of the governmental authorities and others will be the visitors of the exhibition and participants of the conference. Overall number of the exhibition visitors expected: 3000+. Overall number of the conference participants expected: 500+. Organizers of the Conference 1.Fort-Ross, the leading marketing and event company organizing varied conferences and trade shows in the field of IT and software in Russia, 2.Linux Ink., since 1993 the pioneer of professional support and distribution of Linux systems in Russia. Programme Committee John Maddog Hall (Linux International), Ceren Cerenov (MERT RF), Alexei Smirnov (ALT Linux), Vyacheslav Zvyagintsev (Linux Ink) Valentim Makarov (RUSSOFT) Alexander Andreev (Softjoys) IBM Novell Duration of the Conference: 3 days Plan of the Conference 1.The Opening Ceremony Speakers: representatives of the Russian Government, organizers of the event, several VIP speakers. 2.Exhibition (free for visitors): 1.Linux City: a specially decorated area where visitors can see live demonstrations of various open source solutions that together build a common infrastructure. Linux City will present a model of real enterprises, small offices, communication infrastructure, entertainment zone etc. Each node of this model might have its own sponsor. 2.Exhibition Area This area invites the open source projects (maintainers or their representatives, team members) and companies to demonstrate their state-of-the-art technologies. 3.Conference (requires registration and tickets) 1.plenary sessions, held by vendors 2.specific sections, presenting the talks 3.round-table discussions, moderated Conference Sections and Round-Tables 1.Open Source Community (code: OSCom) Topics for discussion: 1.project management in the Open Source software development 2.training for Open Source software development 2.Open Source Security (code: OSSec) Topics for discussion: 1.security of software products and technologies based on the open source model 2.implementing national security standards in open source solutions 3.Open Source to e-Government (code: OS2eG) Topics for discussion: 1.open source solutions for governmental agencies 2.communication and docflow standards 3.e-Government portals 4.Open Source to Business (code: OS2B) Topics for discussion: 1.open source solutions for the corporate market 2.particular features of the open source business model 3.commercial support of open source solutions 5.Open Source in Education (code: OS2Ed) Topics for discussion: 1.open source solutions for education 2.training resources and applications 3.learning process management 6.Open Source Legal Issues (code: OSLegal) Topics for discussion: 1.open source licenses 2.intellectual property rights, copyright/copyleft, patents Agenda 24 April 2005 (Wednesday) 13.00 – registration of participants 15.00 – grand opening of the exhibition 16.00 – beginning of the conference. Plenary session with participation of the keynote speakers: - representatives of the RF government at minister level, - managers of leading international open source organizations and companies - Linux International, Open Source Development League, Red Hat, MySQL - general sponsors of the Conference 19.00 – Gala reception for the VIP guests (by individual invitations) 28 April 2005 (Thursday) 9.00 - the exhibition opens 10.00 – parallel sections (OSCom, OS2eG, OS2B) 11.00 – coffee-break 12.00 – parallel sections (OSCom, OS2eG, OS2B) 13.30 – lunch for conference participants 15.00 - parallel round tables (OSCom, OS2eG, OS2B ) 16.30 – coffee-break 18.00 – Reception for conference participants April 29, 2005 (Friday) 9.00 - the exhibition opens 10.00 – parallel sections (OSEd, OSSec, OSLegal) 11.30 – coffee-break 12.00 – parallel sections and round-tables continue (OSEd, OSSec, OSLegal) 13.30 – lunch for conference participants 15.00 – round-tables (OSEd, OSSec, OSLegal) 17.0– Official closing of the conference, summary. Keynote speakers give closing speeches. Practical Information Conference Location The conference and exhibition are to be held in the "Radisson SAS Hotel". This is almost the only hotel in Moscow with a big conference-hall and sufficient space for the exhibition. The following areas of the Hotel will be used: 1.foyer of the Hotel main hall (as Hospitality Desk and as area for the main sponsors' stands) 2.big cinema hall (up to 500 people) - for Official Opening and Plenary session. 3.Group of "Composer halls" - for exhibition and negotiations, for Linux City (total space is 1100 sq. m.). 4.Group of "Writers' hall" - for sections and round-tables (two halls for 100 and 500 people) Lunches and dinners for the conference participants will be served in the restaurants on the first floor. Exhibition The total number of available stands is about 50. Among participants of the exhibition there are Sponsors, software development companies and system integrators. Additional features in order to make Conference participation more effective Besides the conference and the exhibition we are planning the following additional features, which are intended to attract more participants and add novelty to the event: 1.Registration for the exhibition will be done on-line, each participant will be able to print a badge in advance by Internet, in order not to waste time at the registration. Participants of the conference and of the exhibition will have badges of different colors. Number of stands to visit is checked by bar code on a badge. 2.Wireless Internet and Internet-cafe will be organized in the exhibition area 3.Linux City: live demonstration of the open source solutions can be tested by any visitor 4.Demonstration of technologies and products based on Open Source software will be arranged in the exhibition area. Press coverage The press is invited to participate in this event for free, but preliminary accreditation is required. Wide advertising campaign in business and computer mass media, as well as invitation of leading periodical media as informational sponsors, will be organized in advance. All leading Russian IT and business newspapers and magazines will be involved into information sponsorship and partnership with the show. The number of mass media representatives visiting the conference will be about 100.

2 1

sob not compiling
by Ryan O'Connor 28 Dec '04

28 Dec '04

Updated with CVS last night an just now.. still doesn’t compile. I did a make clean then make I got some errors which someone on the irc channel said were maybe because the person forgot to commit a file in a completely different dir to CVS. Relevant part of log is below, this is near the start where it’s going through all the [DEPENDS] which I don’t remember last time I built it: ../../dk/w32/lib/libepsapi.a was successfully built. wine_uuid: [DEPENDS] .uuid.d wine_uuid: [CC] uuid.c In file included from ../../w32api/include/windows.h:80, from ../../include/windows.h:37, from ../../w32api/include/rpc.h:2, from ../../w32api/include/objbase.h:3, from ../../include/wine/objbase.h:27, from uuid.c:36: ../../include/wine/mmsystem.h:44: error: syntax error before "hDriver" In file included from uuid.c:59: ../../w32api/include/vfw.h:527: error: syntax error before "FOURCC"{standard inp ut}: Assembler messages: {standard input}:18: Warning: Ignoring changed section attributes for .text ../../w32api/include/vfw.h:541: error: syntax error before '}' token ../../w32api/include/vfw.h: In function `ICGetDefaultQuality': ../../w32api/include/vfw.h:968: error: `DRV_USER' undeclared (first use in this function) ../../w32api/include/vfw.h:968: error: (Each undeclared identifier is reported o nly once ../../w32api/include/vfw.h:968: error: for each function it appears in.) ../../w32api/include/vfw.h: In function `ICGetDefaultKeyFrameRate': ../../w32api/include/vfw.h:975: error: `DRV_USER' undeclared (first use in this function) ../../w32api/include/vfw.h: In function `ICDrawSuggestFormat': ../../w32api/include/vfw.h:989: error: `DRV_USER' undeclared (first use in this function) ../../w32api/include/vfw.h: In function `ICSetStatusProc': ../../w32api/include/vfw.h:998: error: `DRV_USER' undeclared (first use in this function) ../../w32api/include/vfw.h: In function `ICDecompressEx': ../../w32api/include/vfw.h:1017: error: `DRV_USER' undeclared (first use in this function) ../../w32api/include/vfw.h: In function `ICDecompressExBegin': ../../w32api/include/vfw.h:1036: error: `DRV_USER' undeclared (first use in this function) ../../w32api/include/vfw.h: In function `ICDecompressExQuery': ../../w32api/include/vfw.h:1055: error: `DRV_USER' undeclared (first use in this function) make[1]: *** [uuid.o] Error 1 make: *** [uuid] Error 2 Any ideas? I’m stumpted.. who was working on this stuff? --- Outgoing mail is certified Virus Free. Checked by AVG anti-virus system (http://www.grisoft.com). Version: 6.0.808 / Virus Database: 550 - Release Date: 12/8/2004

1 0

RE: [ros-dev] SYSCALL instruction
by Waldo Alvarez Cañizares 27 Dec '04

27 Dec '04

Hi Filip: Yes that could work better so we have a single DLL and that does not consume RAM anyway ReactOS would be ready for a CPU downgrade too. btw I built some cvs snapshot today and saw the OARCH flag in the configuration file, the cpls being worked out mesa building (usable?), some text strings not in source code anymore. It failed at some point compiling explorer and I really needed to leave home but i'll keep playing with it for a while (not too much am on final exams almost) Regards Waldo ________________________________ From: ros-dev-bounces(a)reactos.com on behalf of Filip Navara Sent: Thu 12/23/2004 12:37 PM To: ReactOS Development List Subject: Re: [ros-dev] SYSCALL instruction Waldo Alvarez Cañizares wrote: >Another thing that could be done is to detect the CPU at some time during initialization and use one of two ntdll (on with SYSCALL an another without it). > It's implemented in WinXP much easier than that. On startup it's detected if the processor supports SYSCALL and the appropriate code is sticked into the user shared page. The user mode code then just does jmp at the place in user shared page and it uses the correct code. Easy ;-) - Filip _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev

1 0

Linux build && _mingw.h
by David Kredba 26 Dec '04

26 Dec '04

Hello. I have problems on linux with missing _mingw.h with both gcc-3.4.1 and 3.4.2. It is probably caused by the last cvs commit to reactos/include/msvcrt/string.h file. There is mingw32/include/_mingw.h in the cross compiler directory. Thanks, David ROS Version : 0.3-CVS (Build 20041226) ar: creating zlib.host.a In file included from ../../include/tchar.h:41, from ../../include/tgetopt.h:4, from ../../include/getopt.h:1, from /usr/include/unistd.h:783, from ../../include/wine/port.h:44, from import.c:23: ../../include/msvcrt/string.h:42:20: _mingw.h: není souborem ani adresářem make[2]: *** [import.o] Error 1

2 7

PCTV Rave - Driver loading problem
by Gge 26 Dec '04

26 Dec '04

I am testing the PCTV Rave from Pinnaclesystem . Hivesys.inf was setup accordingly and the Pctvrave drivers installed (bt848.sys,stream.sys,ks.sys) The drivers of this Tuner TV card starts to load but fails to initialize as per Debug messages below The driver is from http://btwincap.sourceforge.net/ Please anybody have a look ? Thanks Gerard -------------------------------------------------------------------- DriverBase for \SystemRoot\system32\drivers\bt848.sys: dce37000 DriverBase for \SystemRoot\system32\drivers\STREAM.SYS: dcea8000 DriverBase for \SystemRoot\system32\drivers\ks.sys: dcedc000 (ldr/loader.c:1476) LdrPEGetExportByName(): failed to find ExSemaphoreObjectType (ldr/loader.c:1561) Failed to import ExSemaphoreObjectType from ntoskrnl.exe (ldr/loader.c:373) Could not process module (ldr/loader.c:319) Could not open module file: \SystemRoot\system32\ks.sys (ldr/loader.c:1323) Unknown import module: ks.sys (Status c0000034) (ldr/loader.c:373) Could not process module (ldr/loader.c:319) Could not open module file: \SystemRoot\system32\STREAM.SYS (ldr/loader.c:1323) Unknown import module: STREAM.SYS (Status c0000034) (ldr/loader.c:373) Could not process module (io/pnpmgr.c:1518) Initialization of service pctvrave failed (Status c0000034) (io/pnpmgr.c:1452) IopActionInitChildServices(ccc227e8, ccc40ef8, 0) DriverBase for \SystemRoot\system32\drivers\bt848.sys: dcefd000 DriverBase for \SystemRoot\system32\drivers\STREAM.SYS: dcf59000 DriverBase for \SystemRoot\system32\drivers\ks.sys: dcf66000 (ldr/loader.c:1476) LdrPEGetExportByName(): failed to find ExSemaphoreObjectType (ldr/loader.c:1561) Failed to import ExSemaphoreObjectType from ntoskrnl.exe (ldr/loader.c:373) Could not process module (ldr/loader.c:319) Could not open module file: \SystemRoot\system32\ks.sys (ldr/loader.c:1323) Unknown import module: ks.sys (Status c0000034) (ldr/loader.c:373) Could not process module (ldr/loader.c:319) Could not open module file: \SystemRoot\system32\STREAM.SYS (ldr/loader.c:1323) Unknown import module: STREAM.SYS (Status c0000034) (ldr/loader.c:373) Could not process module (io/pnpmgr.c:1518) Initialization of service pctvrave failed (Status c0000034) (io/pnpmgr.c:1452) IopActionInitChildServices(ccc22910, ccc40ef8, 0) (io/pnpmgr.c:1523) Service <NULL> is disabled or already initialized (io/pnpmgr.c:1452) IopActionInitChildServices(ccc22a38, ccc40ef8, 0) (io/pnpmgr.c:1523) Service <NULL> is disabled or already initialized (io/pnpmgr.c:1452) IopActionInitChildServices(ccc22b60, ccc40ef8, 0) (io/pnpmgr.c:1523) Service <NULL> is disabled or already initialized (io/pnpmgr.c:1452) IopActionInitChildServices(ccc22c88, ccc40ef8, 0)

2 1

Patch for win32k/eng/gradient.c
by Stephen Hodges 26 Dec '04

26 Dec '04

This fixes the build error for building with optimized = 1 , DBG =1 Stephen Hodges Cell: (786)256-0339 AIM: theteofscuba Web: http://www.thespoke.net/MyBlog/stevo/MyBlog.aspx

8 13

RE: [ros-dev] Binary download
by Murphy, Ged (Bolton) 24 Dec '04

24 Dec '04

On occasions I have grabbed the latest binaries and replaced the ReactOS folder. It always works for me and seems to be a very quick and easy way of updating ROS without the need for burning a CD everytime. I would say the binaries are very useful Gedi -----Original Message----- From: Jason Filby [mailto:jason.filby@gmail.com] Sent: 23 December 2004 20:07 To: ReactOS Development List Subject: [ros-dev] Binary download Hi all Do we really need the binary download anymore? The binary is highly downloaded, but I suspect that those that do download it then proceed to the iso/livecd/bochs/qemu downloads which are more usable (if they aren't too frustrated at that point). Should we remove it? Does anyone object to that? Cheers Jason _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

3 4

RE: [ros-dev] Binary download
by Murphy, Ged (Bolton) 24 Dec '04

24 Dec '04

-----Original Message----- From: Casper Hornstrup [mailto:chorns@users.sourceforge.net] Sent: 24 December 2004 11:13 To: 'ReactOS Development List' Subject: RE: [ros-dev] Binary download > It was to be dropped for releases only, not daily builds. The > registry is more likely to change from release to release than > from day to day. If you are living on the edge and are using the > daily builds then you are on your own and need to handle the > errors that can occur from overwriting the installation with > the binaries (eg. by making a clean install). Hi Casper. For some reason I assumed we were talking about the binaries on your site. If your only talking about dropping the binaries on major releases via sourceforge, then I don't see this causing a problem. Gedi. ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

1 0

RE: [ros-cvs] CVS Update: reactos
by Casper Hornstrup 24 Dec '04

24 Dec '04

Unless it will fix a bug this shouldn't go to the release branch. PS. We should write some rules in wiki about preparing for releases. I can make a draft version unless someone else already beat me to it. Casper > -----Original Message----- > From: ros-cvs-bounces(a)reactos.com > [mailto:ros-cvs-bounces@reactos.com] On Behalf Of > royce(a)cvs.reactos.com > Sent: 23. december 2004 22:01 > To: ros-cvs(a)reactos.com > Subject: [ros-cvs] CVS Update: reactos > > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: reactos/subsys/win32k/eng/ > Changes by: royce(a)mok.osexperts.com 04/12/23 22:01:13 > > Modified files: > reactos/subsys/win32k/eng/: Tag: ros-branch-0_2_5 gradient.c > > Log message: > IntEngGradientFill() fix ASSERT statements > > _______________________________________________ > Ros-cvs mailing list > Ros-cvs(a)reactos.com > http://reactos.com/mailman/listinfo/ros-cvs >

2 1

RE: [ros-dev] Binary download
by Murphy, Ged (Bolton) 24 Dec '04

24 Dec '04

-----Original Message----- From: Jason Filby [mailto:jason.filby@gmail.com] Sent: 24 December 2004 10:06 To: ReactOS Development List Subject: Re: [ros-dev] Binary download > Sounds good; but what about registry entries that have been created by > applications; would such an update wipe the registry or just add new > entries and modify system entries? That's a good point. I suppose for that to work, it would need someone to write an update script every day to patch the existing system. That doesn't seem viable. It takes M$ a month to do theirs, lol. What would be the best way of updating an existing system without the need to a complete reinstall from a CD. Burning a CD everyday to get the latest binaries would become tedious and expensive. Ged. ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

2 1

Binary download
by Jason Filby 24 Dec '04

24 Dec '04

Hi all Do we really need the binary download anymore? The binary is highly downloaded, but I suspect that those that do download it then proceed to the iso/livecd/bochs/qemu downloads which are more usable (if they aren't too frustrated at that point). Should we remove it? Does anyone object to that? Cheers Jason

2 2

RE: [ros-dev] more sharing with Wine?
by Waldo Alvarez Cañizares 23 Dec '04

23 Dec '04

Hi guys: May I suggest something? I believe that the current code flow ros-wine is something like this Let's hope this ASCII drawing won't break on the way ROS developers WINE developers | | | | v v ROS Code <--- merges ---> WINE Code ^ | ---- Here seems that things won't merge quite well sometimes that takes considerable work and also a source of lost work. So what about this? I beleive it will be better for everybody in the long run. ROS developers ------- (ROS + WINE changes) -----><--------------- WINE developers | | | (ROS only changes) | v v ROS code in <--- Automatic Mirroring (scripts?)---- WINE code in cvs server (subversion?) of common code I bet WINE people will be happy with this without doubt (thing won't change too much for them) I guess there will be some friction at the beginning here(maybe) because now ROS developers have to use both systems also ROS code implementing things not present or better than the one in wine will need to be merged into WINE but the good part is that is only once. Also ROS needs to be changed to be able to receive WINE code without changes but again this is only once and also does not needs to be done for all dlls/applications at once. I suggest to do this in small scale to see how it works. Well guys you all know more about this than me so I guess you could improve this. Regards Waldo Alvarez ________________________________ From: ros-dev-bounces(a)reactos.com on behalf of Alex Ionescu Sent: Tue 12/21/2004 1:41 PM To: ReactOS Development List Subject: Re: [ros-dev] more sharing with Wine? Gunnar Dalsnes wrote: > Hi, > > I'm tired of fixing bugs in code ported from wine <x> years ago. In > most cases the bugs has already been fixed in the wine code we ripped > from, but the ros variant is forked so much its impossible to inc. > those fixes into ros, so the only choice is to rip the whole wine > source over again, loosing any possible fixes/improvements we had made > to the ros variant vs. the wine variant. > > Take for example the file lib\kernel32\misc\profile.c. This file is > 99.9% unchanged from wine, and only includes and some prototypes > needed changes. I want to move files like this into wine subdirs. like > lib\kernel32\misc\wine\profile.c and generate an initial diff > lib\kernel32\misc\wine\profile.diff with changes made to make it run > on ros using the wine porting headers. It does not mean that this diff > will contain ERR changed to DPRINT etc. Only the bare changes to make > it compile. Moving files into wine dirs in off course not necesary, > but it makes it clear that this file(s) are shared thus there are > rules to follow when changing them. > > I have made scripts that updates our profile.c, using the profile.diff > and any updated profile.c from wine, and i have made a script for > generating patches that we send to wine. It all seems to work fine. > HELP: where does the winehq2ros.patch files used in comctl32 etc. fit > into this? > > The only problem is wines strange unicode strings, their FIXME, ERR > etc. and indentation. I think its worth it if we can share more, but > dunno if the majority agrees. > > From what i can see, much of kernel32 and ntdll can be shared this > way, and probably much stuff in user32/gdi32 also. > > Regards > Gunnar Personally, what bugs me is that if Wine fixes something, it's our responsability to merge it and cope with it. If we fix something, it's still our responsability. This latter statement bugs me. Of course it's up to us to implement Wine's changes, but why should we be the ones that also send our pathces back to wine, and have them all formatted back into Wine mode. It seems unfair to me that they don't submit their bug fixes to us, and it's up to us to sync and make them proper, while it's ALSO up to us to wineize our patches and send them to Wine. Anyways, whatever tool/script makes importing Wine's code into ROS and making it look nice is 100% OK with me. Best regards, Alex Ionescu _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev

3 2

RE: [ros-dev] SYSCALL instruction
by Waldo Alvarez Cañizares 23 Dec '04

23 Dec '04

Hi Martin: Last time I saw it no I haven't checked in a while), but I guess my answer should be not yet since I have not seen any discussion about that on the list until now that you ask. If you want to be sure check ntdll (the interface is machine generated so you need to check the program that builds it, what I remember is that it generated an .asm, you can also check the asm after you build the system). Also the ROS build system needs sub architectures configurable to use this one since this instruction is PII+ hey I bet we all know we are missing a lot of great stuff only implemented in more recent processors, SYSCALL is only one of them. Another thing that could be done is to detect the CPU at some time during initialization and use one of two ntdll (on with SYSCALL an another without it). The question is: should an installed ReactOS resist a CPU downgrade? Probably yes but most of the times is just a waste. regards Waldo ________________________________ From: ros-dev-bounces(a)reactos.com on behalf of Maritn "E.T." Misuth Sent: Wed 12/22/2004 5:10 PM To: ReactOS Development List Subject: [ros-dev] SYSCALL instruction Does ReactOS use optimized SYSCALL instruction on modern processors when invoking kernel functions? _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev

3 2

The hanging after 2nd stage install bug
by art yerkes 23 Dec '04

23 Dec '04

This patch works around the 'hanging after 2nd stage install' bug but I don't really understand what's going on here. Basically, It looks like ProcessData is null on the very last call (the one that would seemingly flush the registry and reboot). If i comment the break, nothing breaks and reactos reboots as expected when i press the reboot button. -- Here's a simple experiment. Stand on a train track between two locomotives which are pushing on you with equal force in opposite directions. You will exhibit no net motion. None the less, you may soon begin to notice that something important is happening. -- Robert Stirniman

2 1

SYSCALL instruction
by Maritn "E.T." Misuth 23 Dec '04

23 Dec '04

Does ReactOS use optimized SYSCALL instruction on modern processors when invoking kernel functions?

2 1

more sharing with Wine?
by Gunnar Dalsnes 22 Dec '04

22 Dec '04

Hi, I'm tired of fixing bugs in code ported from wine <x> years ago. In most cases the bugs has already been fixed in the wine code we ripped from, but the ros variant is forked so much its impossible to inc. those fixes into ros, so the only choice is to rip the whole wine source over again, loosing any possible fixes/improvements we had made to the ros variant vs. the wine variant. Take for example the file lib\kernel32\misc\profile.c. This file is 99.9% unchanged from wine, and only includes and some prototypes needed changes. I want to move files like this into wine subdirs. like lib\kernel32\misc\wine\profile.c and generate an initial diff lib\kernel32\misc\wine\profile.diff with changes made to make it run on ros using the wine porting headers. It does not mean that this diff will contain ERR changed to DPRINT etc. Only the bare changes to make it compile. Moving files into wine dirs in off course not necesary, but it makes it clear that this file(s) are shared thus there are rules to follow when changing them. I have made scripts that updates our profile.c, using the profile.diff and any updated profile.c from wine, and i have made a script for generating patches that we send to wine. It all seems to work fine. HELP: where does the winehq2ros.patch files used in comctl32 etc. fit into this? The only problem is wines strange unicode strings, their FIXME, ERR etc. and indentation. I think its worth it if we can share more, but dunno if the majority agrees. From what i can see, much of kernel32 and ntdll can be shared this way, and probably much stuff in user32/gdi32 also. Regards Gunnar

8 12

Re: [ros-cvs] CVS Update: reactos
by Alex Ionescu 22 Dec '04

22 Dec '04

royce(a)cvs.reactos.com wrote: >CVSROOT: /CVS/ReactOS >Module name: reactos >Repository: reactos/ntoskrnl/mm/ >Changes by: royce(a)mok.osexperts.com 04/12/21 21:17:46 > >Modified files: > reactos/ntoskrnl/include/internal/: test.h > reactos/ntoskrnl/ke/i386/: exp.c > reactos/ntoskrnl/mm/: virtual.c > >Log message: > MiQueryVirtualMemory(): created because ZwQueryVirtualMemory() didn't work for me, added cases for memory area types that I needed to walk stack traces. > Stack traces now use MiQueryVirtualMemory to make sure they never step outside the allocated stack they started in ( this prevents page faults at high irql ) - for some reason this patch eliminates the NtW32Callback() crash everybody is seeing with GDI_DEBUG enabled, tho I don't understand why. > > > > Nice fix Royce. Keep it up! Best regards, Alex Ionescu

1 0

Crash in ppool
by Hartmut Birr 20 Dec '04

20 Dec '04

Hi, I've problems with the paged pool routines and if the optimisation is enabled. Ros does crash. It seems that the line numbers for ppool.c are wrong. - Hartmut KeBugCheckWithTf at ke/catch.c:180 Bug detected (code 1e param 0 0 0 0) KMODE_EXCEPTION_NOT_HANDLED Page Fault Exception: 14(0) Processor: 0 CS:EIP 8:80044769 <ntoskrnl.exe: 44769 (mm/ppool.c:292 (RFreeInit))> cr2 4 cr3 29f000 Proc: 805e2068 Pid: 1 <SYSTEM> Thrd: 805e2c40 Tid: 1 DS 10 ES 10 FS 30 GS 10 EAX: 00000004 EBX: 8cdd593c ECX: 00000000 EDX: 00000004 EBP: 800a9a80 ESI: 8cdd593c ESP: 800a9a04 EDI: 00000002 EFLAGS: 00210202 kESP 800a9a04 kernel stack base 800a7000 Frames: <ntoskrnl.exe: 44efc (mm/ppool.c:596 (RFreeSplit))> <ntoskrnl.exe: 4557d (mm/ppool.c:505 (ExAllocatePagedPoolWithTag))> <ntoskrnl.exe: 44019 (mm/pool.c:63 (EiAllocatePool))> <800779EB> <ntoskrnl.exe: b6fc (ke/main.c:863 (KiSystemStartup))> <8007849F> <ntoskrnl.exe: 1140

2 2

rcopy && gcc-3.4.2 on linux
by David Kredba 20 Dec '04

20 Dec '04

Hello, I got : Current date: 2004-12-20 ROS Version : 0.3-CVS (Build 20041220) rcopy.c: In function `copy_file': rcopy.c:90: error: storage size of `ut_buffer' isn't known rcopy.c:132: warning: implicit declaration of function `utime' rcopy.c:90: warning: unused variable `ut_buffer' make[1]: *** [rcopy] Error 1 make: *** [tools] Error 2 Regards, David

2 2

Version info
by Ge van Geldorp 20 Dec '04

20 Dec '04

After reading a question on the forum, I decided to find out exactly what is keeping Visual Basic programs from running and see if it's easy to fix. It turns out that about the first thing that the VB runtime (msvbvm60.dll) does is check the version number of the OS. At the moment we return: dwMajorVersion = 4 dwMinorVersion = 0 dwBuildNumber = 0 dwPlatformId = 2 szCSDVersion = "ReactOS 0.2.5-CVS (Build 20041216)" wServicePackMajor = 6 wServicePackMinor = 0 wSuiteMask = 0 wProductType = 0 The VB runtime wants at least NT4/SP3. The checks that currently fail are dwBuildNumber (needs at least 1381) and the check for the service pack. It expects the szCSDVersion field to be "Service Pack x" and extracts the service pack number from that. (Good thing btw that there are not more than 10 service packs for NT4...). Anyway, dwBuildNumber will have to be increased to 1381, that's no problem. But the szCSDVersion is currently the only way for usermode programs to get the ReactOS version. I know it's used by e.g. cmd.exe to display the version number. So, I don't think we have much choice, szCSDVersion will have to be set to "Service Pack 6". Question is how to make the ReactOS version string available. I've been thinking about adding it after the "Service Pack 6" string (so the sp6 string is terminated with a nul byte, following the nul byte is the ReactOS version string). Another option would be to store it in the registry, but that would mean that it could get out of sync with the version info in the kernel. So, I'd like to store it as second string in szCSDVersion. Any objections to that? Gé van Geldorp.

9 10

Re: LinuxWorld Boston 2005 .org Pavilion
by Steven Edwards 20 Dec '04

20 Dec '04

It will be faxed to you in 30. --- Debbie_Camerato(a)idg.com wrote: > Right now I have only have 2 spaces left....and it is first come, first > served, so I would send in your contract asap! __________________________________ Do you Yahoo!? Send a seasonal email greeting and help others. Do good. http://celebrity.mail.yahoo.com

1 0

RE: [ros-cvs] CVS Update: reactos
by Ge van Geldorp 20 Dec '04

20 Dec '04

> From: greatlrd(a)cvs.reactos.com > > Added files: > reactos/lib/dxdigan/: Makefile.in Makefile.ros-template > container.c dxdiag_main.c > dxdiag_private.h > dxdiagn.spec makefile provider.c regsvr.c > version.rc I'm afraid you're mixing up "dxdiagn" (correct name) with "dxdigan" in quite a few places. Could you make everything "dxdiagn" please? Gé van Geldorp.

2 1

[Patch] rcopy.c, utime/stat + Linux
by Quandary 20 Dec '04

20 Dec '04

Attached is a patch that lets rcopy.c compile for me under Linux. This seems like a bit of a hack (#define-ing away the Windows "_" before _utime,_stat and _utimbuf), but it works for me. Are the non-_ versions of these functions and the struct available under Windows? - Travis __________________________________ Do you Yahoo!? Dress up your holiday email, Hollywood style. Learn more. http://celebrity.mail.yahoo.com

1 0

Re: [ros-dev] Patch to get ROS Building under Linux
by Quandary 20 Dec '04

20 Dec '04

Hartmut Birr wrote: <snip> >Hi, >I thing that is a problem of mingw-runtime-3.5. The >definition of wcsdup >in string.h is: >_CRTIMP wchar_t* __cdecl wcsdup (wchar_t*); >But it must be: >_CRTIMP wchar_t* __cdecl wcsdup (const wchar_t*); >From the code in the mingw-runtime header, it looks like we can get around this by adding -D_NO_OLDNAMES to the compiler command. I'll try it out and see :). -- Travis __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 2

SMP - Recursive bugcheck
by David Kredba 19 Dec '04

19 Dec '04

With yesterdays cvs tree and SMP=1,ACPI=1,DBG=1,KDBG=1 and deleted vmwinst.exe I got this bugcheck on real HW, when it is doing initial boot to display ROS`s syssetup, SMP machine : (ke/ipi.c: 91) Waiting longer than 5 seconds to start the ipi routine KeBugCheck at ke/ipi.c: 92 snip (api.c: 758) Spurious interrupt on CPU(0) Regards, David

4 19

Patch to get ROS Building under Linux
by Quandary 19 Dec '04

19 Dec '04

I kept getting build errors related to wcsdup being multiply defined, so I went in and removed what appeared to be the offending code. A make clean + make resulted in a complete build for me; I run Linux, so if a Windows user could run a build to verify that this didn't break anything on -that- platform, that would be great. (my build errors can be found at http://www.nomorepasting.com/paste.php?pasteID=27171 ) Thanks, -- Travis Index: include/msvcrt/string.h =================================================================== RCS file: /CVS/ReactOS/reactos/include/msvcrt/string.h,v retrieving revision 1.6 diff -u -r1.6 string.h --- include/msvcrt/string.h 25 Aug 2003 01:37:47 -0000 1.6 +++ include/msvcrt/string.h 19 Dec 2004 15:56:57 -0000 @@ -166,7 +166,6 @@ /* NOTE: There is no _wcscmpi, but this is for compatibility. */ int wcscmpi(const wchar_t* ws1, const wchar_t* ws2); -wchar_t* wcsdup(const wchar_t* wsToDuplicate); int wcsicmp(const wchar_t* ws1, const wchar_t* ws2); int wcsicoll(const wchar_t* ws1, const wchar_t* ws2); wchar_t* wcslwr(wchar_t* wsToConvert); __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

4 4

Anouncement of ReactOS v 0.2.5 RC1
by Robert Köpferl 19 Dec '04

19 Dec '04

Hi developers, as you know we have feature freeze for ROS v0.2.5 RC1, today. Within a few hours, I will make a branch of the source. So please check in your last changes. However be careful of what you check-in and keep the make process working. As the change CVS->SVN is scheduled to start on Dec 30 there's a deadline for the release of Dec 29. If there are nice features, but not yet good enough to go into this release, dont worry: 0.3 wil be relatively fast after 0.2.5.

1 0

Tree Changes
by Alex Ionescu 19 Dec '04

19 Dec '04

Hi, Eric and Hartmut's suggestions to have static in lib and dlls in dll have been widely accepted, and a new idea to have 3rdparty lib/dll folder was also accepted. So here's the new version : http://mok.lvcm.com/cgi-bin/reactos/roswiki?New_Tree_Structure. Best regards, Alex Ionescu

3 5

crash after opening multi cmd.exe sessions in win32csr.dll
by Steven Edwards 19 Dec '04

19 Dec '04

If you attempt to spawn one cmd session after another you will run in to this crash after about 14 instances: (shelllink.c:1738:IShellLinkW_fnResolve) (007afc80)->(hwnd=00000000 flags=0) Failed to tell csrss about new process. Expect trouble. (api/handle.c:71) CsrGetObject returning invalid handle (objects/gdiobj.c:788) Attempted to lock foreign handle: 0x50147, Owner: 0x4 loc ked: 0x0 Caller: 0x8, stockobj: 0x0 (objects/gdiobj.c:790) -> called from objects/dc.c:1509 (NTDLL:rtl/critical.c:77) RtlEnterCriticalSection: Failed to wait (Status c00000 08) (KERNEL32:except/except.c:132) Unhandled exception (KERNEL32:except/except.c:133) Address: (KERNEL32:except/except.c:136) 5ffb7f8e C:\ReactOS\system32\win32csr.dll CS:EIP 1b:5ffb7f8e DS 23 ES 23 FS 3b GS 23 EAX: 5471e311 EBX: 0011f9f0 ECX: 0011f9f0 EDX: ffffffff EBP: 016dfdd8 ESI: 016dffbc ESP: 016dfd70 EDI: 016dff68 EFLAGS: 00000206 (KERNEL32:except/except.c:139) Frames: (KERNEL32:except/except.c:147) 5ffb8566 C:\ReactOS\system32\win32csr.dll (KERNEL32:except/except.c:147) 5ffb859e C:\ReactOS\system32\win32csr.dll (KERNEL32:except/except.c:147) 5ffb88b8 C:\ReactOS\system32\win32csr.dll (KERNEL32:except/except.c:147) 5ffb8ea4 C:\ReactOS\system32\win32csr.dll (KERNEL32:except/except.c:147) 77e7364b C:\ReactOS\system32\user32.dll (KERNEL32:except/except.c:147) 77e738a9 C:\ReactOS\system32\user32.dll (KERNEL32:except/except.c:147) 5ffb9170 C:\ReactOS\system32\win32csr.dll (KERNEL32:except/except.c:147) 7c825693 C:\ReactOS\system32\kernel32.dll (ntuser/windc.c:747) [000001d8] GetDC() without ReleaseDC()! __________________________________ Do you Yahoo!? Yahoo! Mail - now with 250MB free storage. Learn more. http://info.mail.yahoo.com/mail_250

4 6

Re: [ros-cvs] CVS Update: reactos
by Filip Navara 18 Dec '04

18 Dec '04

Hartmut Birr wrote: >CVSROOT: /CVS/ReactOS >Module name: reactos >Repository: reactos/hal/halx86/generic/ >Changes by: hbirr(a)mok.osexperts.com 04/12/18 10:04:22 > >Modified files: > reactos/hal/halx86/generic/: timer.c > >Log message: > - Fixed the timer calibration for processors without a tsc, spotted by Casper Hornstrup. > > I think the same code is in FreeLdr too. Can you fix it there too? Thanks, Filip

2 1

registry problem
by Hartmut Birr 18 Dec '04

18 Dec '04

Hi, I've some problems with the registry on my smp machine. I start ctm and cmd. Within cmd, I start compiling of reactos. After a short time ros does crash. It seems that are two problems. Look at the debug output. - Hartmut ... RegistryHive is NULL (must not be NULL) Assertion KeyObject->RegistryHive != NULL failed at cm/regfile.c:265 for CPU0 Bug detected (code 0 param 0 0 0 0) The bug code is undefined. Please use an existing code instead. Frames: <ntoskrnl.exe: bf4a (ke/bug.c:220 (KeBugCheckEx))> <ntoskrnl.exe: bf6a (ke/bug.c:237 (KeBugCheck))> <ntoskrnl.exe: 1971b (cm/regfile.c:265 (CmiVerifyKeyObject))> <ntoskrnl.exe: 20a7f (cm/regobj.c:224 (CmiObjectParse))> <ntoskrnl.exe: 6456c (ob/object.c:162 (ObFindObject))> <ntoskrnl.exe: 178f5 (cm/ntfunc.c:960 (NtOpenKey))> <ntoskrnl.exe: 2164b (cm/rtlfunc.c:122 (RtlpGetRegistryHandle))> <ntoskrnl.exe: 21af0 (cm/rtlfunc.c:359 (RtlQueryRegistryValues))> <win32k.sys: 522e7 (objects/text.c:2848 (SubstituteFontFamilyKey))> <win32k.sys: 5225b (objects/text.c:2870 (SubstituteFontFamily))> <win32k.sys: 52051 (objects/text.c:2897 (TextIntRealizeFont))> <win32k.sys: 3daa5 (objects/dc.c:1861 (NtGdiSelectObject))> <win32k.sys: 3c4f9 (objects/dc.c:1259 (NtGdiSetDCState))> <win32k.sys: 29d96 (ntuser/windc.c:248 (DceReleaseDC))> <win32k.sys: 2a79d (ntuser/windc.c:659 (NtUserReleaseDC))> <win32k.sys: 25771 (ntuser/painting.c:810 (NtUserEndPaint))> <ntoskrnl.exe: 3b87 (D:\DOKUME~1\HB0875~1.NEW\LOKALE~1\Temp/ccyKaaaa.s:154 (KeUserModeCallback))> <user32.dll: eb47 (misc/win32k.c:340 (NtUserEndPaint))> <user32.dll: 370d3 (windows/paint.c:105 (EndPaint))> <win32csr.dll: 8477 (guiconsole.c:392 (GuiConsoleHandlePaint))> <win32csr.dll: 8e9e (guiconsole.c:750 (GuiConsoleWndProc))> <user32.dll: 1364b (windows/message.c:926 (IntCallWindowProcW))> <user32.dll: 138a9 (windows/message.c:1061 (DispatchMessageW))> <win32csr.dll: 91a1 (guiconsole.c:871 (GuiConsoleGuiThread))> <kernel32.dll: 25653 (thread/thread.c:80 (ThreadStartup))> <DEADBEEF> ... ... (mm/npool.c:1643) Trying to allocate 858993464 bytes from nonpaged pool - nothing suitable found, returning NULL Frames: <ntoskrnl.exe: 54afb (mm/pool.c:47 (EiAllocatePool))> <ntoskrnl.exe: 54b81 (mm/pool.c:102 (ExAllocatePool))> <ntoskrnl.exe: 20f67 (cm/regobj.c:541 (CmiAddKeyToList))> <ntoskrnl.exe: 2090d (cm/regobj.c:163 (CmiObjectParse))> <ntoskrnl.exe: 6456c (ob/object.c:162 (ObFindObject))> <ntoskrnl.exe: 178f5 (cm/ntfunc.c:960 (NtOpenKey))> <ntoskrnl.exe: 3b3b (D:\DOKUME~1\HB0875~1.NEW\LOKALE~1\Temp/ccyKaaaa.s:154 (KeUserModeCallback))> <7C901E67> <7C909547> <7C9047EE> Page fault at high IRQL was 2 KeBugCheckWithTf at ke/catch.c:173 Page fault at high IRQL was 2 Bug detected (code 1e param 0 0 0 0) KMODE_EXCEPTION_NOT_HANDLED Page Fault Exception: 14(0) Processor: 1 CS:EIP 8:80082d21 <ntoskrnl.exe: 82d21 (D:\DOKUME~1\HB0875~1.NEW\LOKALE~1\Temp/ccw9aaaa.s:396 (RtlUnwind))> cr2 cccccccc cr3 10f94000 Proc: 80f224c0 Pid: 37 <rdel.exe> Thrd: 80ef31c8 Tid: 8f DS 10 ES 10 FS 30 GS 10 EAX: 80f1fff0 EBX: 00000010 ECX: 0ccccccc EDX: 33333330 EBP: 9ef13c40 ESI: cccccccc ESP: 9ef13bc4 EDI: 00000000 EFLAGS: 00010206 kESP 9ef13bc4 kernel stack base 9ef11000 Frames: <ntoskrnl.exe: 20f91 (cm/regobj.c:546 (CmiAddKeyToList))> <ntoskrnl.exe: 2090d (cm/regobj.c:163 (CmiObjectParse))> <ntoskrnl.exe: 6456c (ob/object.c:162 (ObFindObject))> <ntoskrnl.exe: 178f5 (cm/ntfunc.c:960 (NtOpenKey))> <ntoskrnl.exe: 3b3b (D:\DOKUME~1\HB0875~1.NEW\LOKALE~1\Temp/ccyKaaaa.s:154 (KeUserModeCallback))> <7C901E67> <7C909547> <7C9047EE> <7C904EC3> <7C909997> <DEADBEEF> ...

2 1

[Fwd: [ros-cvs] CVS Update: reactos] - Networking + CVS acces testing
by Gge 18 Dec '04

18 Dec '04

With this patch , Reactos can now access to CVS repository . (in real hardware) via my DSL router + Nic Realtek8139. A checkout of freeldr module starts but freezes after downloading a number of files as indicated below : ....... Cvs_checkout : Updating freeldr/tools ....... U freeldr/tools/rrmdir.c => Freeze at this time This is reproductible . Please confirm this is a known problem ? Regards Gerard

2 1

[Fwd: [ros-dev] [Fwd: [ros-cvs] CVS Update: reactos] - Networking + CVS acces testing = OK
by Gge 18 Dec '04

18 Dec '04

The CVS checkout in fact was correct as I just not waiting enough time for the end of checkout because "U freeldr/tools/rrmdir.c" is the last file in freeldr !!! Rosapps checkout was ok as well . I was able to access my mail box using the e-mail client "Jbmail" => So we can begin to use networking apps. REgards Gerard

1 0

console window problem
by Hartmut Birr 18 Dec '04

18 Dec '04

Hi, I've problems to start cmd.exe in gui mode. I get a very large (height) console window where the previous background is visible. The debug print shows this: ... (objects/bitmaps.c:454) got bad width 560 or height 421075580, please look for reason ... - Hartmut

5 5

Re: [ros-cvs] CVS Update: reactos
by Filip Navara 18 Dec '04

18 Dec '04

Ge van Geldorp wrote: >CVSROOT: /CVS/ReactOS >Module name: reactos >Repository: reactos/subsys/win32k/objects/ >Changes by: gvg(a)mok.osexperts.com 04/12/17 09:40:37 > >Modified files: > reactos/subsys/win32k/objects/: text.c > >Log message: > Pass parameters in correct order > > You can't just remove the code for negative font heights. Negative sizes aren't implemented correctly (see MSDN for CreateFont), but they still need to be handled. - Filip

2 1

Re: LinuxWorld Boston 2005 .org Pavilion
by Steven Edwards 18 Dec '04

18 Dec '04

Hello, --- Duncan_Newell(a)idg.com wrote: > Space in the .org Pavilion is limited, and available on a FIRST COME FIRST > SERVE BASIS, so we ask that you fax your completed contract to Debbie > Camerato at 508-988-7581 as soon as possible to avoid disappointment. On Monday I will fax the application on behalf of The ReactOS Foundation. Can you confirm that space is still available? Thanks Steven __________________________________ Do you Yahoo!? Send a seasonal email greeting and help others. Do good. http://celebrity.mail.yahoo.com

1 0

hyperthreading
by Stephen Hodges 18 Dec '04

18 Dec '04

"Symmetric multithreading (hyperthreading) is an interesting new concept that IMO deserves full scheduler support. Physical CPUs can have multiple (typically 2) logical CPUs embedded, and can run multiple tasks 'in parallel' by utilizing fast hardware-based context-switching between the two register sets upon things like cache-misses or special instructions. To the OSs the logical CPUs are almost undistinguishable from physical CPUs. In fact the current scheduler treats each logical CPU as a separate physical CPU - which works but does not maximize multiprocessing performance on SMT/HT boxes." Read on for Ingo's full explanation http://kerneltrap.org/node/391?PHPSESSID=ff817ec3db386b00075dca0c5d4c1864 Stephen

1 0

RE: [ros-dev] console window problem
by PETREOLLE Sylvain 18 Dec '04

18 Dec '04

Looking in the log, I got a "PAINTING BUG" too. Cordialement, Sylvain PETREOLLE Service de Production & d'Exploitation Informatique GEFCO - #DMIT/DATO/PSI/PEI Mail : <mailto:exploit@gefco.fr> Tel : 01.49.05.29.29 -----Message d'origine----- De : Steven Edwards [mailto:steven_ed4153@yahoo.com] Envoyé : samedi 18 décembre 2004 01:32 À : ReactOS Development List Objet : Re: [ros-dev] console window problem Hi, --- Hartmut Birr <hartmut.birr(a)gmx.de> wrote: > I've problems to start cmd.exe in gui mode. I get a very large (height) > console window where the previous background is visible. The debug print > shows this: > (objects/bitmaps.c:454) got bad width 560 or height 421075580, please > look for reason Me too... (objects/bitmaps.c:454) got bad width 560 or height 421075580, please look for r eason (objects/gdiobj.c:788) Attempted to lock foreign handle: 0x50143, Owner: 0x4 loc ked: 0x0 Caller: 0x8, stockobj: 0x0 (objects/gdiobj.c:790) -> called from objects/dc.c:1509 (ke/catch.c:146) Unhandled UserMode exception, terminating thread Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Mail - You care about security. So do we. http://promotions.yahoo.com/new_mail _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev ---------------------------------------------------------------------------- Ce message ainsi que toutes pièces jointes (le "message") sont confidentiels et sont exclusivement destinés à l'usage de la personne à laquelle ils sont adressés. Tout point de vue ou toute opinion contenus dans ce message expriment la pensée personnelle de leur auteur et ne représentent pas nécessairement la position des sociétés du Groupe GEFCO. Si vous n'êtes pas la personne à laquelle ce message est destiné, veuillez noter que vous avez reçu cet e-mail par erreur et qu'il vous est strictement interdit d'utiliser, de diffuser, de transférer, d'imprimer ou de copier ce message. Si vous avez reçu ce message par erreur, merci de contacter la personne qui vous l'a adressé et de l'effacer immédiatement. Les sociétés du Groupe GEFCO déclinent toute responsabilité en cas d'altération, de modification, d'édition, de diffusion sans autorisation de ce message ou en cas d'affection de ce message par un virus. This message and any attachments (the "message") are confidential and intended solely for the use of the individual to whom they are addressed. Any views or opinions presented are solely those of the author and do not necessarily represent those of the GEFCO Group of Companies. If you are not the intended recipient, be advised that you have received this email in error and that any use, dissemination, forwarding, printing, or copying of this message is strictly prohibited. If you have received this message in error please contact the sender and delete the message immediately. The GEFCO Group of Companies shall not be liable for the message if altered, changed, falsified, edited, diffused without authorization or affected by any virus. ----------------------------------------------------------------------------

1 0

For what it's worth, Helix and cmd.exe
by Wesley Parish 17 Dec '04

17 Dec '04

Helix is a computer forensics tool, an adaption of the Knoppix LiveCD. It's also got its tools ported to Windows, and appears to be using cmd.exe. At least one part of ReactOS is getting worked hard at the current moment! ;) -- Wesley Parish * * * Clinersterton beademung - in all of love. RIP James Blish * * * Mau e ki, "He aha te mea nui?" You ask, "What is the most important thing?" Maku e ki, "He tangata, he tangata, he tangata." I reply, "It is people, it is people, it is people."

3 3

Fix the template fs driver
by Sylvain Petreolle 17 Dec '04

17 Dec '04

- Fix the template fs driver - Add resources for it ===== Sylvain Petreolle (spetreolle_at_users.sourceforge.net) humans are like computers, yesterday the BIOS was all - today its just a word

1 0

Subversion Migration Plan
by Jason Filby 17 Dec '04

17 Dec '04

Hi all We're moving from CVS to SVN (Subversion) and here's the plan: * A two week testing period starts now! Please play around with the new setup and report any bugs to Casper Hornstrup (chorns(a)reactos.com). You will also need to email Casper for him to create an account for you. Your SVN username must be the same as your CVS username for auditability. * On the 30th of December 2004 our existing CVS repository will be set to read-only and imported into Subversion (removing anything done during the test phase in SVN). * On the 1st of January 2005 we will be using SVN for day-to-day source control! A wiki page describing how to use the new SVN system is here: http://mok.lvcm.com/cgi-bin/reactos/roswiki?Subversion Thanks to Casper for all his hard work in bringing SVN online and to Rex for maintaining CVS for so many years! Cheers Jason

11 15

LibEMF
by Steven Edwards 16 Dec '04

16 Dec '04

Would this be of use to the Win32k hackers? http://libemf.sourceforge.net/ Thanks Steven __________________________________ Do you Yahoo!? Send a seasonal email greeting and help others. Do good. http://celebrity.mail.yahoo.com

1 0

Plans for next release (0.2.5 or 0.3.0)
by eric.kohl＠t-online.de 16 Dec '04

16 Dec '04

Hi! When the branch for the next version will be created I plan to disable the 'Locale Page' and 'Progress Page' in the second stage setup because they are not usable yet. Regards, Eric

3 2

Empty fields of DeviceNode leading to Death
by art yerkes 16 Dec '04

16 Dec '04

Is there a reference for which registry keys fill (or are supposed to fill) which members of DeviceNode? I ask because I wind up finding all of the combinations that lead to zeros and have a tough time figuring out which registry values are needed to make them not be zero. We have a lot of unchecked string functions on the DeviceNode fields in io/pnpmgr.c, by the way. I think i've stumbled on four such places so far, but I suspect that the whole thing should be hardened together. In any case it would be nice if someone could post a cheat sheet about how to create a new device entry the right way, or write the code that fills the DeviceNode in a more obvious way, so that it's easy to find and see what fills what. -- Here's a simple experiment. Stand on a train track between two locomotives which are pushing on you with equal force in opposite directions. You will exhibit no net motion. None the less, you may soon begin to notice that something important is happening. -- Robert Stirniman

2 2

Changelog for 0.2.5
by Jason Filby 16 Dec '04

16 Dec '04

Hi all For the new changelog, I'd like to do away with the mere compilation of commit messages. Firstly because it takes forever for one person to do this and secondly because it doesn't mean much to people following the project. Could everyone write down their changes in a way meaningful to a technical end-user (that has no knowledge of our codebase) on the Wiki here: http://mok.lvcm.com/cgi-bin/reactos/roswiki?ChangeLog-0.2.5 Cheers Jason

8 12

RE: [ros-dev] Changelog for 0.2.5
by Murphy, Ged (Bolton) 16 Dec '04

16 Dec '04

Casper Hornstrup wrote: > > Is there an interrest in generating a draft version of the ChangeLog automatically from the > commit logs? How would you control if there were then changes to changes? There are changes made in the mailing list that are then altered again and again, or reverted completely. e.g. - Add notepad to the bootcd - @changelog Included Notepad on the bootable CD If then at a later date it was decided that was a bad idea, you would have: - Remove notepad from bootcd - @changelog Removed Notepad from the bootable CD. Gedi. ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

3 2

[ion] Set default Freeldr Timeout to 5 seconds
by Sylvain Petreolle 16 Dec '04

16 Dec '04

Looking to the change made to usetup/bootsup.c, I see we already have a TimeOut definition at line 61, but this one is #ifed and therefore disabled by default. You should remove it since it is now useless. ===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) humans are like computers, yesterday the BIOS was all - today its just a word

1 0

Re: [ros-cvs] CVS Update: reactos
by Steven Edwards 16 Dec '04

16 Dec '04

Hi, --- gdalsnes(a)cvs.reactos.com wrote: > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: reactos/lib/wininet/ > Changes by: gdalsnes(a)mok.osexperts.com 04/12/15 19:00:08 > > Modified files: > reactos/lib/wininet/: stubs.c wininet.def > > Log message: > add InternetOpenUrlA/W stubs Don't worry about doing to much stuff to this as I have ported wininet from wine to the MSVC+PSDK here and will be sending a patch to winehq and importing it in to ReactOS soon. Thanks Steven __________________________________ Do you Yahoo!? Send a seasonal email greeting and help others. Do good. http://celebrity.mail.yahoo.com

1 0

RE: [ros-dev] Wineism
by ea＠iol.it 15 Dec '04

15 Dec '04

> > Why would you want us to change from a very flexible debug > > logging system to a less flexible one? > > > > Rob > > I would vote for using the WINE system in this case as it is more flexible. Is the Wine debug logging system documented somewhere? ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

2 1

Re: [ros-dev] Wineism
by ea＠iol.it 15 Dec '04

15 Dec '04

> > This will work on Linux and Windows > > static const WCHAR KeyW[] = {'S','o','f','t','w','a','r','e','\\', > > 'M','i','c','r','o','s','o','f','t','\\', > > Aiee! That looks painful. Is there nothing that can be done on WINE's > side to make this easier? I suppose not or they would have done it > already. > > Are there any objections to the above changes from anyone? Let me ask a question. Is this piece of code static const WCHAR KeyW = L"Software\\Microsoft\\"; a Microsoft C language extension or does it conform to a public C language standard (C89, C99 et c.)? ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

2 1

I've just read the /. postings (XBox + ReactOS)
by Wesley Parish 15 Dec '04

15 Dec '04

Oh, well, can't win 'em all! Just for the record, one major reason why I'm with the ReactOS project is because I have to maintain a network of virus-traps going by the name of Microsoft Windows 98, and I dream of replacing the wretched stuff by a superior system. Keep it up. -- Wesley Parish * * * Clinersterton beademung - in all of love. RIP James Blish * * * Mau e ki, "He aha te mea nui?" You ask, "What is the most important thing?" Maku e ki, "He tangata, he tangata, he tangata." I reply, "It is people, it is people, it is people."

1 0

Re: [ros-dev] Wineism
by ea＠iol.it 15 Dec '04

15 Dec '04

> I had an idea about this.... > > ExRosSetDebugLevel() and ExRosGetDebugLevel() can be ntdll umode > syscalls into ntoskrnl. We should shadow the debug level in umode so > that ExRosGetDebugLevel() doesn't have to jump to kmode every time we > query it. ExWineSetDebugLevel() ExWineGetDebugLevel() ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

LinuxWord Boston
by Steven Edwards 14 Dec '04

14 Dec '04

Hi All, We have been invited to attend LinuxWorld in Boston on February 15-17, 2005. If anyone is interested in attending please let me know. Arty and I may be going. Thanks Steven __________________________________ Do you Yahoo!? Send a seasonal email greeting and help others. Do good. http://celebrity.mail.yahoo.com

3 2

Re: [ros-cvs] CVS Update: reactos
by James Tabor 14 Dec '04

14 Dec '04

Hi arty! arty(a)cvs.reactos.com wrote: > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: reactos/drivers/net/tcpip/datalink/ > Changes by: arty(a)mok.osexperts.com 04/12/14 00:00:48 > > Modified files: > reactos/drivers/lib/ip/network/: interface.c > reactos/drivers/net/tcpip/include/: ip.h > reactos/drivers/net/tcpip/datalink/: lan.c > > Log message: > Store interface speed to retrieve later. > I have a oops! ip: [CC] network/interface.c network/interface.c: In function `GetInterfaceSpeed': network/interface.c:66: warning: statement with no effect make[1]: *** [network/interface.o] Error 1 make: *** [ip] Error 2 Thanks, James

1 0

Wineism
by Gunnar Dalsnes 14 Dec '04

14 Dec '04

Again I must say that I don't like this. Taking code from wine and then changing it on purpose goes agains my beliefs that wine/ros should share as much as possible and that changes should go _both_ ways. My hope for the future of ros/wine is that ros/wine spesific stuff is placed into seperate files/libraries/etc. to make merging/sharing possible/easier. This would probably mean that most ros umode dlls eventually will be completely wineismed, but if that means we can share more code, i couldn't care less. Gunnar ekohl(a)cvs.reactos.com wrote: > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: reactos/lib/kernel32/misc/ > Changes by: ekohl(a)mok.osexperts.com 04/12/13 13:16:28 > > Modified files: > reactos/lib/kernel32/misc/: profile.c > > Log message: > - Remove Wine-isms from the profile code. > - Wrap single-line if-statements. > - Cleanup the indentation. > > _______________________________________________ > Ros-cvs mailing list > Ros-cvs(a)reactos.com > http://reactos.com/mailman/listinfo/ros-cvs > > > >

6 16

Re: [ros-dev] Wineism
by Steven Edwards 14 Dec '04

14 Dec '04

Hi, --- Jason Filby <jason.filby(a)gmail.com> wrote: > Out of interest, does WINE have a spacing standard, and if so where > can I read about it? Its mostly free form with a few exceptions. Its not really documented. You can read about it here http://www.kerneltraffic.org/wine/wn20020530_124.html#3 http://www.winehq.com/hypermail/wine-devel/2002/11/1340.html > Sounds good; why not change to WINEs macros everywhere in ReactOS? I am not opposed to it, I just don't know how we would support debugging a driver vs a dll if we had support to toggle the messages. I guess it could be done with little trouble everywhere. > Aiee! That looks painful. Is there nothing that can be done on WINE's > side to make this easier? I suppose not or they would have done it > already. The problem is in GCC on *nix. I don't think there is much we can do about it short of fixing GCC. If we ever do a ELF building using gcc on linux to build ReactOS for another CPU then we will have the same issue. Thanks Steven __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

3 2

Re: [ros-dev] Wineism
by Jason Filby 14 Dec '04

14 Dec '04

Hi On Tue, 14 Dec 2004 09:54:32 -0800 (PST), Steven Edwards <steven_ed4153(a)yahoo.com> wrote: > Also I am not talking about issues like tabs and spaces. That can be debated all day > long..... Out of interest, does WINE have a spacing standard, and if so where can I read about it? > DPRINT and DPRINT1 really need to go and we could just standise on using the Wine > macros in our Win32 system, FIXME, WARN, ERR, etc. It reduces the diff and if we ever > get support for switching the debug channels then it will make life less of a pain. Sounds good; why not change to WINEs macros everywhere in ReactOS? > This will work on Linux and Windows > static const WCHAR KeyW[] = {'S','o','f','t','w','a','r','e','\\', > 'M','i','c','r','o','s','o','f','t','\\', Aiee! That looks painful. Is there nothing that can be done on WINE's side to make this easier? I suppose not or they would have done it already. Are there any objections to the above changes from anyone? Cheers Jason

1 0

Re: [ros-cvs] CVS Update: reactos
by Alex Ionescu 14 Dec '04

14 Dec '04

gdalsnes(a)cvs.reactos.com wrote: > -NtSetInformationToken: lie and say we succeded > > > It would be nice to say what apps take advantage of this change, or why it was done? What app now works because of this? And in either case, this function is extremly easy to implement... Best regards, Alex Ionescu

1 0

Re: [ros-diffs] [CVS reactos] forgot this file
by Filip Navara 13 Dec '04

13 Dec '04

weiden(a)osexperts.com wrote: @@ -364,6 +380,7 @@ #if (_WIN32_WINNT >= 0x0501) typedef INHERITED_FROMW INHERITED_FROM, *PINHERITED_FROM; #endif +typedef INHERITED_FROMW INHERITED_FROM, *PINHERITED_FROM; #else #define ACCCTRL_DEFAULT_PROVIDER ACCCTRL_DEFAULT_PROVIDERA typedef TRUSTEE_A TRUSTEE_, *PTRUSTEE_; ^^^ This looks wrong. The typedef is alredy there, two lines above. @@ -381,6 +398,7 @@ #if (_WIN32_WINNT >= 0x0501) typedef INHERITED_FROMA INHERITED_FROM, *PINHERITED_FROM; #endif +typedef INHERITED_FROMA INHERITED_FROM, *PINHERITED_FROM; #endif /* UNICODE */ #ifdef __cplusplus ^^^ Same here. - Filip

1 0

RE: [ros-dev] Problem in dependancies
by Sylvain Petreolle 13 Dec '04

13 Dec '04

Couldnt we do like some software do today ? (like Wine ? :)) make depends && make --- Ge van Geldorp <ge(a)gse.nl> a écrit : > I agree, but it's a bit of a chicken-and-egg problem. The Makefiles include > the dependency files which refer to the now-removed header. To regenerate > the dependency files we have to run make, which uses the Makefiles... > > Gé van Geldorp. > > > -----Original Message----- > > From: Syl_sf [mailto:spetreolle@users.sourceforge.net] > > Sent: Thursday, December 09, 2004 23:34 > > To: Ge van Geldorp; spetreolle(a)users.sourceforge.net; > > 'ReactOS Development List' > > Subject: RE: [ros-dev] Problem in dependancies > > > > > > Actually I was already doing it to have a successful > > compilation. But I dont think running 'make clean' after > > every commit is the best thing to do. > > > > My "aclui" choice was totally random, but no file was changed > > in the aclui CVS since 7 weeks. (It doesnt use mmsystem nor > > imports it) > > > > Many thanks for your help. > > ===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) humans are like computers, yesterday the BIOS was all - today its just a word

1 0

Freetype compilation error
by Stefan 12 Dec '04

12 Dec '04

Hi! I asked on #ReactOS and ros-general, but received no answer. So I'm asking for help here. How to fix this error? Can anybody at least give ma a hint what files am I missing, please? WinME, GCC 3.3.1, fresh sources. [DEPENDS] i386/.setjmplongjmp.d [DEPENDS] .rosglue.d [RC] freetype.rc [CC] rosglue.c [AS] i386/setjmplongjmp.s [AR] freetype.a ar: objs/*.o: No such file or directory MAKE.EXE: *** [freetype.a] Error 1

2 1

Re: [ros-cvs] CVS Update: reactos
by Gunnar Dalsnes 12 Dec '04

12 Dec '04

I saw Steven doing some dewineism commits also. But why remove wineism? It will be much easier to see differences with wine code when fixing bugs etc. if the code in question was taken from wine and wine for example has fixed a bug we are hunting. In kernel32 there are some files that i have taken from wine and the only thing changed is the include files, to make it possible to merge wine changes back. > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: reactos/lib/advapi32/crypt/ > Changes by: ekohl(a)mok.osexperts.com 04/12/12 07:16:27 > > Modified files: > reactos/lib/advapi32/crypt/: crypt.c crypt.h crypt_des.c > crypt_lmhash.c crypt_md4.c > crypt_md5.c crypt_sha.c > > Log message: > - Remove Wine-isms from advapi32 because it's a ReactOS DLL! "because it's a ReactOS DLL"? So if we have to change one file out of many to adapt a wine dll as ours, we have to dewineism all other files also? > - Enforce a consistent coding style. > - Remove -D__REACTOS__ > > _______________________________________________ > Ros-cvs mailing list > Ros-cvs(a)reactos.com > http://reactos.com/mailman/listinfo/ros-cvs > > > >

3 2

Re: [ros-cvs] CVS Update: reactos
by Filip Navara 12 Dec '04

12 Dec '04

weiden(a)cvs.reactos.com wrote: >CVSROOT: /CVS/ReactOS >Module name: reactos >Repository: reactos/subsys/win32k/stubs/ >Changes by: weiden(a)mok.osexperts.com 04/12/11 17:40:44 > >Modified files: > ./: config > reactos/include/napi/: win32.h > reactos/include/win32k/: bitmaps.h brush.h dc.h gdiobj.h kapi.h > ntuser.h pen.h region.h text.h > reactos/lib/user32/include/: user32.h window.h > reactos/lib/user32/misc/: dllmain.c stubs.c > reactos/lib/user32/windows/: defwnd.c > reactos/subsys/win32k/eng/: bitblt.c clip.c mouse.c objects.h > surface.c xlate.c > reactos/subsys/win32k/include/: cursoricon.h dce.h inteng.h > intgdi.h mouse.h object.h > palette.h tags.h > reactos/subsys/win32k/main/: dllmain.c > reactos/subsys/win32k/: makefile w32k.h > reactos/subsys/win32k/misc/: object.c > reactos/subsys/win32k/ntddraw/: ddraw.c > reactos/subsys/win32k/ntuser/: desktop.c input.c misc.c stubs.c > windc.c window.c winpos.c > winsta.c > reactos/subsys/win32k/objects/: bitmaps.c brush.c cliprgn.c > color.c dc.c dib.c fillshap.c > gdiobj.c line.c palette.c pen.c > print.c region.c text.c > reactos/subsys/win32k/stubs/: stubs.c xpstubs.c >Added files: > reactos/subsys/win32k/include/: intddraw.h > reactos/subsys/win32k/ntuser/: cursoricon.c > reactos/subsys/win32k/objects/: stockobj.c >Removed files: > reactos/subsys/win32k/eng/: clip.h handle.c handle.h > reactos/subsys/win32k/objects/: cursoricon.c > >Log message: > 1. remove mouse cursor hacks from eng/mouse > 2. implemented more win2k-like gdi handle table (handle entry lookup is not yet optimized/cached!) > 3. moved cursoricon.c from objects to ntuser as it's part of the user api and not of the gdi > 4. get rid of the eng handle table > 5. minor fixes > > I'm not sure if it's exactly this commit, but Miranda IM now crashes win32k badly. Also the mouse cursor hacks had a reason... if you remove them, please fix the problem different way. Now there is no cursor set during the startup and so when Explorer tries to revert the hourglass cursor to a normal one, the call just fails. Regards, Filip

1 0

FreeLoader Exception output.
by WaxDragon 12 Dec '04

12 Dec '04

While trying to install a current CVS (both freeldr and reactos) bootcd on real hardware, I was greeted with a DIVIDE BY ZERO exception. After asking some people on IRC and poking around in Bugzilla, It turned out I was not getting all the output I needed, due to what seems to be doublespaced output.. Screenshot: http://waxdragon.homeip.net/~ford/freeldr_crash.png After poking around a bit, I rolled i386trap.S back to rev 1.5 and then I got the second half of the output. I stared at i386trap.S for a while, and cannot figure out where the problem is. FreeLoader gurus, can you help me, please? ;0) WD -- The cheese stands alone.

1 0

Ros build Ros lockup
by James Tabor 12 Dec '04

12 Dec '04

Hi all, Had a lockup. CVS from < 24 hours ago. Running in cmd only no gui. (KERNEL32:mem/global.c:412) Memory Load: 15 (ex/sysinfo.c:961) SystemFullMemoryInformation (ex/sysinfo.c:973) PID: 1, KernelTime: 8027895 PcrKTime: 8111975 PcrIdleTime: 80 14109 TickCount: 8269998 PFFree: 65536 PFUsed: 0 TickCount is good! MC_CACHE 29840, MC_USER 2208, MC_PPOOL 777, MC_NPPOOL 6726, MmStats.NrFreePages 214383 (KERNEL32:mem/global.c:412) Memory Load: 15 (conio.c:1029) Console_Api Ctrl-C (KERNEL32:misc/console.c:2966) GenerateConsoleCtrlEvent(0x0, 0x42c4) UNIMPLEMENT ED! PS dump; P PID PPID KTime UTime NAME t TID KTime UTime State WaitResson w PID Hwnd WndStile TID WndName P 1 0 22:50:45 0:00:00 ProcName: SYSTEM t 2 0:00:32 0:00:00 Unknown Executive t 3 22:48:26 0:00:00 Ready Executive t 4 0:00:00 0:00:00 Unknown WrQueue t 5 0:00:00 0:00:00 Unknown WrQueue t 6 0:00:00 0:00:00 Unknown WrQueue t 7 0:00:00 0:00:00 Unknown WrQueue t 8 0:00:00 0:00:00 Unknown WrQueue t 9 0:00:00 0:00:00 Unknown WrQueue t 10 0:00:00 0:00:00 Unknown WrQueue t 11 0:00:00 0:00:00 Unknown WrQueue t 12 0:00:00 0:00:00 Unknown WrQueue t 13 0:00:00 0:00:00 Unknown WrQueue t 14 0:00:00 0:00:00 Unknown WrQueue t 15 0:00:00 0:00:00 Unknown WrQueue t 16 0:00:00 0:00:00 Unknown WrQueue t 17 0:00:00 0:00:00 Unknown WrQueue t 18 0:00:00 0:00:00 Unknown WrQueue t 19 0:01:58 0:00:00 Unknown Executive t 20 0:00:00 0:00:00 Unknown Executive t 21 0:00:00 0:00:00 Unknown Executive t 22 0:00:03 0:00:00 Unknown Executive t 24 0:00:00 0:00:00 Unknown Executive t 29 0:00:00 0:00:00 Unknown Executive t 30 0:00:00 0:00:00 Unknown Executive t 31 0:00:00 0:00:00 Unknown Executive P 2 1 0:00:00 0:00:00 ProcName: smss.exe t 25 0:00:00 0:00:00 Unknown UserReq t 26 0:00:00 0:00:00 Unknown UserReq t 27 0:00:00 0:00:00 Unknown UserReq P 4 2 0:00:54 0:00:02 ProcName: csrss.exe t 33 0:00:09 0:00:00 Unknown UserReq t 34 0:00:00 0:00:00 Unknown UserReq t 35 0:00:00 0:00:00 Unknown Executive t 36 0:00:00 0:00:00 Unknown UserReq t 38 0:00:00 0:00:00 Unknown UserReq t 39 0:00:00 0:00:00 Unknown Executive w 4 4 00000000 39 t 40 0:00:00 0:00:00 Unknown Executive w 4 8 86000000 40 t 41 0:00:00 0:00:00 Unknown Executive w 4 c 86000000 41 t 43 0:00:00 0:00:00 Unknown UserReq t 46 0:00:00 0:00:00 Unknown UserReq t 49 0:00:00 0:00:00 Unknown UserReq t 46453 0:00:00 0:00:00 Unknown UserReq t 46467 0:00:00 0:00:00 Unknown UserReq P 5 2 0:00:00 0:00:00 ProcName: winlogon.exe t 37 0:00:00 0:00:00 Unknown UserReq w 5 10 84000000 37 SAS P 6 5 0:00:00 0:00:00 ProcName: services.exe t 42 0:00:00 0:00:00 Unknown UserReq t 44 0:00:00 0:00:00 Unknown UserReq P 7 6 0:00:00 0:00:00 ProcName: eventlog.exe t 45 0:00:00 0:00:00 Unknown UserReq t 47 0:00:00 0:00:00 Unknown UserReq P 8 5 0:00:00 0:00:00 ProcName: cmd.exe t 48 0:00:00 0:00:00 Unknown UserReq Look here! P 23169 17092 0:00:00 0:00:00 ProcName: make.exe P 23208 23169 0:00:00 0:00:00 ProcName: gcc.exe P 23210 23208 0:00:00 0:00:00 ProcName: as.exe t 46452 0:00:00 0:00:00 Unknown UserReq Ctrl-break did not kill these. FYI, James

8 19

Re: [ros-cvs] CVS Update: reactos
by James Tabor 12 Dec '04

12 Dec '04

Hi all! weiden(a)cvs.reactos.com wrote: > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: reactos/lib/advapi32/sec/ > Changes by: weiden(a)mok.osexperts.com 04/12/10 16:21:34 > > Modified files: > reactos/lib/advapi32/: advapi32.def advapi32.h makefile > reactos/lib/advapi32/misc/: sysfunc.c > reactos/lib/advapi32/token/: token.c > Added files: > reactos/lib/advapi32/crypt/: .cvsignore crypt.c crypt.h > crypt_des.c crypt_lmhash.c > crypt_md4.c crypt_md5.c crypt_sha.c > reactos/lib/advapi32/sec/: trustee.c > > Log message: > port crypt and trustee support from Wine. Patch by Steven Edwards. I'm getting this, [CC] crypt/crypt.c In file included from crypt/crypt.c:28: ../../include/wine/port.h:248: error: parse error before "pread" ../../include/wine/port.h:248: warning: type defaults to `int' in declaration of `pread' ../../include/wine/port.h:248: warning: data definition has no type or storage class ../../include/wine/port.h:252: error: parse error before "pwrite" ../../include/wine/port.h:252: warning: type defaults to `int' in declaration of `pwrite' ../../include/wine/port.h:252: warning: data definition has no type or storage class make: *** [crypt/crypt.o] Error 1 Good port, we need it for AbiWord 2.2.1, James

2 3

freeldr.ini syntax question
by Bernd Blaauw 12 Dec '04

12 Dec '04

Hello, I was just looking on how to add FreeDOS to the ReactOS loader, just as I did for NT bootmenu and Syslinux bootmenu (both should be working by now) There's one problem: I need to update one section "[Operating Systems]" with something like: FreeDOS="FreeDOS (Beta Distribution)" and add a section (that's the easy part, and same as for boot.ini), which I use the following (ASM) program for: http://www.coli.uni-sb.de/~eric/stuff/soft/specials/text-tool-iniadd.zip [FreeDOS] Description="FreeDOS Beta" BootType=Bootsector Bootsector=C:\FREEDOS.BSS I was wondering if you could not remove the [Operating Systems] section (all it does is provide a label/section description), and do the following (add description): [ReactOS] Description="ReactOS" BootType=ReactOS SystemPath=multi(0)disk(0)rdisk(0)partition(1)\ReactOS [ReactOS_DebugCom1] "ReactOS (Debug, COM1)" BootType=ReactOS SystemPath=multi(0)disk(0)rdisk(0)partition(1)\ReactOS Options=/DEBUGPORT=COM1 *****instead of:************ [Operating Systems] ReactOS="ReactOS" ReactOS_DebugCom1="ReactOS (Debug, COM1)" [ReactOS] BootType=ReactOS SystemPath=multi(0)disk(0)rdisk(0)partition(1)\ReactOS [ReactOS_DebugCom1] BootType=ReactOS SystemPath=multi(0)disk(0)rdisk(0)partition(1)\ReactOS Options=/DEBUGPORT=COM1 It would require to read the entire freeldr.ini for non-standard sections ([FREELDR] and [DISPLAY]) like for example [REACTOS] by the way, sample freeldr.ini does not show how to use Bootsector, I'll guess I'll just have to install ReactOS over FreeDOS then to figure this out. Final request: add a small delay on the LiveCD, so someone can boot to A: for example from the FreeLDR which is used on cdrom (boot to C: is already taken care of through cdrom bootsector). Bernd

1 0

Changing default output of the build system ("half-verbose" option)?
by Gregor Anich 11 Dec '04

11 Dec '04

Hi! I was playing around with the output of our build system a bit... I very much like the way Linux-2.6 does it - it looks like this: [RC] ntoskrnl.rc [AS] ke/i386/multiboot.S [PCH] include/ntoskrnl.h [CC] ex/i386/interlck.c [CC] ke/i386/exp.c ... [CC] inbv/inbv.c [AR] ntoskrnl.a [LD] ntoskrnl.nostrip.exe [RSYM] ntoskrnl.sym [OBJDUMP] ntoskrnl.map [LD] ntoskrnl.exe ntoskrnl.exe was successfully built. I think everybody will like this output - my question is wether 1) it should become the default (if VERBOSE is unset) and the old output can be produced if VERBOSE=yes or 2) the old output should stay the default and the fancy one should be used if VERBOSE=half or something like this - blight

2 1

RE: [ros-cvs] CVS Update: reactos
by Casper Hornstrup 11 Dec '04

11 Dec '04

Why would we want both variants? > -----Original Message----- > From: ros-cvs-bounces(a)reactos.com > [mailto:ros-cvs-bounces@reactos.com] On Behalf Of Gregor Anich > Sent: 10. december 2004 06:58 > To: ros-cvs(a)reactos.com > Subject: [ros-cvs] CVS Update: reactos > > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: reactos/ntoskrnl/include/ > Changes by: blight(a)mok.osexperts.com 04/12/10 06:58:26 > > Modified files: > reactos/ntoskrnl/dbg/: print.c > reactos/ntoskrnl/include/: config.h > > Log message: > Add an option to serialize DbgPrint - don't worry, it's > disabled by default and meant only for those who are tired of > reading mixed debug messages. > > _______________________________________________ > Ros-cvs mailing list > Ros-cvs(a)reactos.com > http://reactos.com/mailman/listinfo/ros-cvs >

3 3

winlogon three desktops
by Klemens Friedl 10 Dec '04

10 Dec '04

winlogin from Windows 2000 and XP creates desktops: application desktop, winlogon desktop (only winlogon can access this desktop) and a screen saver desktop. ReactOS only has one desktop at the moment (correct me if I am false). I know many security features like login are not implemented. But for a future release (0.4) ... Klemens Friedl <frik85> -- NEU +++ DSL Komplett von GMX +++ http://www.gmx.net/de/go/dsl GMX DSL-Netzanschluss + Tarif zum superg�nstigen Komplett-Preis!

3 3

SMP code testing
by David Kredba 10 Dec '04

10 Dec '04

I can test SMP code on dual PIII. David

1 0

Re: [ros-cvs] CVS Update: reactos
by Hartmut Birr 10 Dec '04

10 Dec '04

Gregor Anich schrieb: >CVSROOT: /CVS/ReactOS >Module name: reactos >Repository: reactos/ntoskrnl/include/ >Changes by: blight(a)mok.osexperts.com 04/12/10 06:58:26 > >Modified files: > reactos/ntoskrnl/dbg/: print.c > reactos/ntoskrnl/include/: config.h > >Log message: > Add an option to serialize DbgPrint - don't worry, it's disabled by default and meant only for those who are tired of reading mixed debug messages. > >_______________________________________________ >Ros-cvs mailing list >Ros-cvs(a)reactos.com >http://reactos.com/mailman/listinfo/ros-cvs > > > > Hi, I like your idea. For my smp build, I've add a simple spinlock which does serialize the access to the real debug print function. Your implementation has two problems. The first, it is possible to call DbgPrint from each interupt level, so it isn't possible to use ExAllocatePool. The second, we have nice macros like DPRINT, CPRINT or KEBUGCHECK, which calls DbgPrint for twice. This should be merged in one call. - Hartmut

2 1

Re: [ros-cvs] CVS Update: reactos
by Alex Ionescu 10 Dec '04

10 Dec '04

weiden(a)cvs.reactos.com wrote: >CVSROOT: /CVS/ReactOS >Module name: reactos >Repository: reactos/lib/kernel32/misc/ >Changes by: weiden(a)mok.osexperts.com 04/12/09 09:28:11 > >Modified files: > reactos/lib/kernel32/file/: dir.c > reactos/lib/kernel32/include/: kernel32.h > reactos/lib/kernel32/misc/: stubs.c > >Log message: > implemented SetDllDirectory() and GetDllDirectory(). LoadLibrary(Ex)() should be extended to use the dll directory when present! > >_______________________________________________ >Ros-cvs mailing list >Ros-cvs(a)reactos.com >http://reactos.com/mailman/listinfo/ros-cvs > > > Hi, Shouldn't kernel not use unicode_strings + rtl, and just stay within the domain of normal string functions and kernel32 stuff? Also, shouldn't the DllDirectory be in the registry, and not some local var that gets erased every time you reboot? Best regards, Alex Ionescu

5 8

Problem in dependancies
by Sylvain Petreolle 09 Dec '04

09 Dec '04

Im having a problem with dependancies. After an update of my tree to the current CVS, I got tons of errors linked to the file reactos/include/mmsystem.h, removed due to Wine-20041201 winmm sync. (see http://reactos.com:8080/archives/public/ros-cvs/2004-December/006233.html) For example compiling lib/aclui: make[1]: *** No rule to make target `../../include/mmsystem.h', needed by `.aclui.d'. Stop. make[1]: Leaving directory `/mnt/hdb5/reactos/reactos/lib/aclui' ===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) humans are like computers, yesterday the BIOS was all - today its just a word

2 1

ReactOS language support
by Klemens Friedl 08 Dec '04

08 Dec '04

Hi! ReactOS and some applications are translated in many different languages but a ReactOS language support is missing. The regitry keys (see hivesys.inf) are there but ROS ingore the keys. Is there a chance that ROS get language support until version 0.3? Is it a big step to add it? Which file is need an update? Maybe I can help adding this feature. Why are there some languages hard coded? reactos\lib\msvcrt\locale\locale.c - Code: const struct map_lcid2str { short langid; const char *langname; const char *country; } languages[]={ {0x0409,"English", "United States"}, {0x0809,"English", "United Kingdom"}, {0x0000,"Unknown", "Unknown"} }; const struct map_cntr { const char *abrev; const char *country; } abrev[] = { {"britain", "united kingdom"}, {"england", "united kingdom"}, {"gbr", "united kingdom"}, {"great britain", "united kingdom"}, {"uk", "united kingdom"}, {"united kingdom", "united kingdom"}, {"united-kingdom", "united kingdom"}, {"america", "united states" }, {"united states", "united states"}, {"united-states", "united states"}, {"us", "united states"}, {"usa" "united states"} }; Klemens Friedl <frik85> -- GMX ProMail mit bestem Virenschutz http://www.gmx.net/de/go/mail +++ Empfehlung der Redaktion +++ Internet Professionell 10/04 +++

3 3

cards.dll ???
by Klemens Friedl 08 Dec '04

08 Dec '04

Why does ReactOS need(?) the cards.dll (reactos\lib\cards)? -> "Cardplaying Helper DLL" Is there a card game included? Maybe someone know the answers ... Thanks! Klemens Friedl <frik85> -- GMX ProMail mit bestem Virenschutz http://www.gmx.net/de/go/mail +++ Empfehlung der Redaktion +++ Internet Professionell 10/04 +++

4 3

STDCALL.._FUNC
by Alex Ionescu 08 Dec '04

08 Dec '04

Hi, Why is everyone adding _FUNC to the definitions? I was removing them in my new headers because they seem totally useless, plus some people told me that they had no point. But I just see GvG adding more of them. I don't understand what their point is? Best regards, Alex Ionescu

2 2

csrss.exe and VDM ?
by Klemens Friedl 08 Dec '04

08 Dec '04

I read on the ms homepage that the crss.exe contains: + creating and deleting processes and threads + console (text) windows + 16-bit virtual DOS machine (VDM) Is in the csrss.exe (from ReactOS) the VDM process inluded? I read in the old forum that someone spoke about an DOS/win16 subsystem. Should the DOS (virtual maschine) be a part of the csrss.exe? And, does the Ros graphic run in kernel mode (like as in Win 2000 - GDI)? Klemens Friedl <frik85> -- GMX ProMail mit bestem Virenschutz http://www.gmx.net/de/go/mail +++ Empfehlung der Redaktion +++ Internet Professionell 10/04 +++

5 5

RosFS
by Rick Langschultz 08 Dec '04

08 Dec '04

For those of you who have heard nothing of my plans to write a RosFS service for ReactOS, here are some details about my plan. RosFS RosFS is a small service running on system initialization by default that indexes files, folders, users, devices, and network resources can hold metadata via MySQL, sleepycat DB, TCL, Apache, and Perl; which will all be embedded within the service itself. RosFS will hold encrypted resources based off of a key that is created with the first startup of ReactOS, it changes every 30 days to ensure security. The RosFS can be accessed online via the built in web server with can be an encrypted connection - SSL, or TLS. User ACLs can be set on a machine level or a domain level. RosFS will support a SQL-like querying language that can be written easily - it will have triggers, procedures, functions, and saved queries - which are all logged. Triggers will be supplied by a TCL-like language with features of Perl. An service will provide users with current system updates, patches, etc stored on a domain server - this option will only be installed on a powerful server with pretty good hardware - ie: not for home use!!! A few problems I know that will arise in developing such a project are: 1) Size 2) Security 3) Where to keep the files on the system 4) The RosFS query language will be trouble to write and maintain depending on if a user uses such Databases like ORACLE, MySQL, MSSQL, etc. 5) Explorer Integration - Will Explorer.exe need to be rewritten to allow the addition of Metadata structures, etc. 6) Web integration - Perl, PHP, TCL, CGI, ISAPI??? Please send me comments and concerns about the RosFS project.

9 12

Re: [ros-cvs] CVS Update: reactos
by eric.kohl＠t-online.de 07 Dec '04

07 Dec '04

navaraf(a)cvs.reactos.com wrote: > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: reactos/w32api/include/ > Changes by: navaraf(a)mok.osexperts.com 04/12/05 18:23:06 > > Modified files: > reactos/include/win32k/: ntuser.h > reactos/lib/user32/misc/: misc.c > reactos/subsys/system/winlogon/: winlogon.h > reactos/subsys/win32k/include/: desktop.h > reactos/subsys/win32k/ntuser/: desktop.c misc.c stubs.c > reactos/w32api/include/: winuser.h > > Log message: > - Basic implementation of (NtUser)UpdatePerUserSystemParameters. > - Move code querying for "PaintDesktopVersion" to NtUserUpdatePerUserSystemParameters. I think the code to query for "PaintDesktopVersion" should be moved back to its old location and get called from NtUserUpdatePerUserSystemParameters becaus this function needs to do a lot more initialization work on behalf of the user. For example, updating system colors, system metrics and setting the background pattern or wallpaper. Regatds, Eric

2 1

Tribes1 Loads!!!!!
by Steven Edwards 07 Dec '04

07 Dec '04

Hi All and GreatLord, I just tested Starseige Tribes under ReactOS and it does load. You need dsound.dll and dinput.dll from Wine. GreatLord is working on fixing these to work under Windows and ReactOS now. If you want to test it tribes is a free download you just may need to do a google search. Make sure you set the graphics to GDI under Windows and then copy your config over. Of course the mouse wont work under ReactOS until GreatLord is done with his dinput changes. I have not tested with ReactOS new direct input as I am short on time tonight. I will try that tommrow. Thanks Steven __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

3 3

Re: [ros-cvs] CVS Update: reactos
by James Tabor 07 Dec '04

07 Dec '04

Jim Tabor wrote: > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: reactos/lib/msi/ > Changes by: jimtabor(a)mok.osexperts.com 04/12/07 00:13:03 > > Modified files: > reactos/lib/msi/: action.c msi.c suminfo.c table.c > winehq2ros.patch > > Log message: > Code cleanup and sink with WindHq CVS. > Falling to sleep, Sync to WineHq CVS. James

1 0

Re: [ros-cvs] CVS Update: reactos
by Filip Navara 06 Dec '04

06 Dec '04

Thanks for fixing it! ----- PŮVODNÍ ZPRÁVA ----- Od: ion(a)cvs.reactos.com Komu: ros-cvs(a)reactos.com Předmět: [ros-cvs] CVS Update: reactos Datum: 6.12.2004 - 8:59:00 > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: reactos/lib/user32/misc/ > Changes by: ion(a)mok.osexperts.com 04/12/06 00:41:38 > > Modified files: > reactos/lib/user32/misc/: misc.c > > Log message: > Filip and Richard are both smoking something. > > Replaced syntax error and incorrect inversion. > > dwUnknown is a reserved parameter (dwReserved is more correct) > that is never used, but it's still incorrect to pass 0 because > we should respect what the user is sending us. > > _______________________________________________ > Ros-cvs mailing list > Ros-cvs(a)reactos.com > http://reactos.com/mailman/listinfo/ros-cvs > -- A za kolik kupujete ELEKTRO Vy? http://www.MALL.cz/penezenka Ověřte si přes SMS, kolik se dá UŠETŘIT!

1 0

Re: [ros-cvs] CVS Update: reactos
by Richard Campbell 06 Dec '04

06 Dec '04

lol, nah, just a bit of a coding session at 3am. btw didn't glance at the rest of the code so i didn't know those params weren't being passed in the right order (should have slowed down and investigated thoroughly, but i was trying to get the tree working again) ion(a)cvs.reactos.com wrote: >CVSROOT: /CVS/ReactOS >Module name: reactos >Repository: reactos/lib/user32/misc/ >Changes by: ion(a)mok.osexperts.com 04/12/06 00:41:38 > >Modified files: > reactos/lib/user32/misc/: misc.c > >Log message: > Filip and Richard are both smoking something. > > Replaced syntax error and incorrect inversion. > > dwUnknown is a reserved parameter (dwReserved is more correct) that is never used, but it's still incorrect to pass 0 because we should respect what the user is sending us. > >_______________________________________________ >Ros-cvs mailing list >Ros-cvs(a)reactos.com >http://reactos.com/mailman/listinfo/ros-cvs > > >

1 0

Inside Windows NT book (which version)
by Klemens Friedl 05 Dec '04

05 Dec '04

Hi! I want to buy "Inside Windows NT 2nd edition". But there is also "Inside Microsoft Windows 2000, Third Edition" available. Which version is better? Thanks Klemens Friedl <frik85> -- GMX ProMail mit bestem Virenschutz http://www.gmx.net/de/go/mail +++ Empfehlung der Redaktion +++ Internet Professionell 10/04 +++

6 7

Ros boot failure with networking enabled in real hardware - ed 2 with tcpip traces
by Gge 05 Dec '04

05 Dec '04

With current CVS + Realtek8139 nic driver enabled in Hivesy , Ros still fails to boot as per debug messages below => ed 2 based on Tcpip debug traces enabled. Ros build with KDBG+DBG=1 - Real hardware Note : Ntoskrnl+ICP+NDIS+HAL Sym files installed but only symbol from Ntoskrnl not displayed in the bugcheck Any help suggested ? This boot failure is a regression as it worked 2 weeks ago (Dpc problem) Regards Gerard ---------------------------------------------------------------------------- DriverBase for ndis.sys: dce70000 (ke/main.c:699) CommandLine: multi(0)disk(0)rdisk(0)partition(1)\reactos /DEBUGPORT=COM1/BAUDRATE=115200/KDSERIAL DriverBase for \SystemRoot\system32\drivers\RTL8139.SYS: dcec0000 DriverBase for \SystemRoot\system32\drivers\floppy.sys: dcf4c000 DriverBase for \SystemRoot\system32\drivers\cdrom.sys: dcf71000 DriverBase for \SystemRoot\system32\drivers\fs_rec.sys: dcf81000 (io/create.c:90) Parent is a Directory which is neither a file type nor a device type (io/create.c:90) Parent is a Directory which is neither a file type nor a device type (io/create.c:90) Parent is a Directory which is neither a file type nor a device type DriverBase for \SystemRoot\system32\drivers\beep.sys: dcf91000 (ldr/loader.c:319) Could not open module file: \SystemRoot\system32\drivers\sndblst.sys (ldr/loader.c:319) Could not open module file: \SystemRoot\system32\drivers\es137140.sys (ldr/loader.c:319) Could not open module file: \SystemRoot\system32\drivers\mpu401.sys DriverBase for \SystemRoot\system32\drivers\null.sys: dcfd6000 DriverBase for \SystemRoot\system32\drivers\serial.sys: dcfe6000 Serial Driver 0.0.2 DriverBase for \SystemRoot\system32\drivers\psaux.sys: dcffe000 DriverBase for \SystemRoot\system32\drivers\keyboard.sys: dd01a000 DriverBase for \SystemRoot\system32\drivers\mouclass.sys: dd02c000 DriverBase for \SystemRoot\system32\drivers\debugout.sys: dd03b000 DriverBase for \SystemRoot\system32\drivers\blue.sys: dd04a000 DriverBase for \SystemRoot\system32\drivers\vbemp.sys: dd05a000 DriverBase for \SystemRoot\system32\drivers\videoprt.sys: dd07c000 DriverBase for \SystemRoot\system32\drivers\vgamp.sys: dd091000 DriverBase for \SystemRoot\system32\drivers\msfs.sys: dd0a2000 DriverBase for \SystemRoot\system32\drivers\npfs.sys: dd0bb000 DriverBase for \SystemRoot\system32\win32k.sys: ddb95000 DriverBase for \SystemRoot\system32\freetype.dll: ddcb3000 DriverBase for \SystemRoot\System32\kbdfr.dll: ddd3b000 (io/create.c:90) Parent is a Directory which is neither a file type nor a device type (io/create.c:90) Parent is a Directory which is neither a file type nor a device type (io/create.c:90) Parent is a Directory which is neither a file type nor a device type (io/create.c:90) Parent is a Directory which is neither a file type nor a device type (io/create.c:90) Parent is a Directory which is neither a file type nor a device type (io/create.c:90) Parent is a Directory which is neither a file type nor a device type (io/create.c:90) Parent is a Directory which is neither a file type nor a device type (io/create.c:90) Parent is a Directory which is neither a file type nor a device type WL-Status: ReactOS is starting up... (io/create.c:90) Parent is a Directory which is neither a file type nor a device type RtlQueryRegistryValues() failed (Status c0000034) RtlQueryRegistryValues() failed (Status c0000034) (service/sctrl.c:120) ScDispatcherLoop() called DriverBase for \SystemRoot\system32\drivers\tcpip.sys: de345000 (tcpip/main.c:703)(DriverEntry) Called. (network/ip.c:352)(IPStartup) Called. (network/router.c:416)(RouterStartup) Called. (network/neighbor.c:174)(NBStartup) Called. (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (4096) bytes at (0xC06D2000). Here1 kmem_malloc(1) (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (4096) bytes at (0xC0788000). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC06CFE68). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c0788000 fbsd (*:0) (Called from *:0) kmem_malloc done Freeing c0788000 onto the free list Freeing c0788800 onto the free list done with m_clalloc Here2 (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (4) bytes at (0xC06C2698). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC06CFEA8). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c06c2698 fbsd (*:0) (Called from *:0) (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (4096) bytes at (0xC078A000). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC06CFEE8). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c078a000 fbsd (*:0) (Called from *:0) (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (508) bytes at (0xC06D1C60). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC06CFF28). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c06d1c60 fbsd (*:0) (Called from *:0) domaininit starting (1) Domain internet initializing Registering protocols for internet (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (508) bytes at (0xC06C65F8). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC06CFF68). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c06c65f8 fbsd (*:0) (Called from *:0) Domaininit done (datalink/lan.c:1106)(LANRegisterProtocol) Called. (datalink/lan.c:475)(ProtocolBindAdapter) Called with registry path \Registry\Machine\System\CurrentControlSet\Services\Rtl81391\Parameters\Tcpip for \Device\Rtl81391 (datalink/lan.c:904)(LANRegisterAdapter) Called. (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (92) bytes at (0xC06C6898). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC06C6B38). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c06c6898 ExAl (datalink/lan.c:906) (Called from datalink/lan.c:906) (datalink/lan.c:925)(LANRegisterAdapter) opening adapter \Device\Rtl81391 (datalink/lan.c:740)(BindAdapter) Called. (network/ip.c:171)(IPCreateInterface) Called. BindInfo (0xDE1019C0). (network/ip.c:177)(IPCreateInterface) Interface address (00 10 A7 13 97 61). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (156) bytes at (0xC06C6C78). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC06C6D40). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c06c6c78 ExAl (network/ip.c:181) (Called from network/ip.c:181) (tcpip/info.c:33)(InsertTDIInterfaceEntity) Inserting interface c06c6c78 (2 entities already) (datalink/lan.c:623)(ReadIPAddressFromRegistry) Information DataLength: 0x18 (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (13) bytes at (0xC06D1FC8). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC06C6F10). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c06d1fc8 ExAl (datalink/lan.c:633) (Called from datalink/lan.c:633) (datalink/lan.c:623)(ReadIPAddressFromRegistry) Information DataLength: 0x14 (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (11) bytes at (0xC06C6F50). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC06C6F88). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c06c6f50 ExAl (datalink/lan.c:633) (Called from datalink/lan.c:633) (datalink/lan.c:623)(ReadIPAddressFromRegistry) Information DataLength: 0x1e (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (16) bytes at (0xC07870E8). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC0787120). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c07870e8 ExAl (datalink/lan.c:633) (Called from datalink/lan.c:633) (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (12) bytes at (0xC0787160). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC0787198). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c0787160 ExAl (datalink/lan.c:709) (Called from datalink/lan.c:709) (datalink/lan.c:823)(BindAdapter) --> Our IP address on this interface: '10.0.0.3' (datalink/lan.c:828)(BindAdapter) --> Our net mask on this interface: '255.255.255.0' (datalink/lan.c:834)(BindAdapter) --> Our gateway is: '10.0.0.138' (network/neighbor.c:401)(NBFindOrCreateNeighbor) Called. Interface (0xC06C6C78) Address (0xDE1019A0). (network/neighbor.c:360)(NBLocateNeighbor) Called. Address (0xDE1019A0). (network/neighbor.c:379)(NBLocateNeighbor) Leaving. (network/neighbor.c:272)(NBAddNeighbor) Called. Interface (0xC06C6C78) Address (0xDE1019A0) LinkAddress (0x0) LinkAddressLength (6) State (0x1) (network/neighbor.c:294)(NBAddNeighbor) NCE: c07871d8 (network/router.c:185)(RouterAddRoute) Called. NetworkAddress (0xDE101980) Netmask (0xDE101980) Router (0xC07871D8) Metric (1). (network/router.c:190)(RouterAddRoute) NetworkAddress (10.0.0.138) Netmask (10.0.0.138) Router (10.0.0.138). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (68) bytes at (0xC0787250). (network/ip.c:246)(IPRegisterInterface) Called. IF (0xC06C6C78). (network/neighbor.c:272)(NBAddNeighbor) Called. Interface (0xC06C6C78) Address (0xC06C6C9C) LinkAddress (0xC06C68C8) LinkAddressLength (6) State (0x80) (network/neighbor.c:294)(NBAddNeighbor) NCE: c07872c0 (network/router.c:185)(RouterAddRoute) Called. NetworkAddress (0xDE101920) Netmask (0xC06C6CCC) Router (0xC07872C0) Metric (1). (network/router.c:190)(RouterAddRoute) NetworkAddress (255.255.255.0) Netmask (255.255.255.0) Router (255.255.255.0). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (68) bytes at (0xC0787338). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (56) bytes at (0xC07873A8). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC0787408). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c07873a8 ExAl (transport/tcp/if.c:36) (Called from transport/tcp/if.c:36) (transport/tcp/if.c:41)(TCPPrepareInterface) Called (transport/tcp/if.c:56)(TCPPrepareInterface) Prepare interface c06c6c78 : addr 300000a (transport/tcp/if.c:63)(TCPPrepareInterface) Leaving (datalink/lan.c:1041)(LANRegisterAdapter) Leaving. (network/loopback.c:71)(LoopRegisterAdapter) Called. (network/ip.c:171)(IPCreateInterface) Called. BindInfo (0xDE101B60). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (156) bytes at (0xC0787448). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC0787510). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c0787448 ExAl (network/ip.c:181) (Called from network/ip.c:181) (tcpip/info.c:33)(InsertTDIInterfaceEntity) Inserting interface c0787448 (3 entities already) (tcpip/info.c:42)(InsertTDIInterfaceEntity) Entity 2 is an IF. Found 1 (network/ip.c:246)(IPRegisterInterface) Called. IF (0xC0787448). (network/neighbor.c:272)(NBAddNeighbor) Called. Interface (0xC0787448) Address (0xC078746C) LinkAddress (0x0) LinkAddressLength (0) State (0x80) (network/neighbor.c:294)(NBAddNeighbor) NCE: c0787550 (network/router.c:185)(RouterAddRoute) Called. NetworkAddress (0xDE101B10) Netmask (0xC078749C) Router (0xC0787550) Metric (1). (network/router.c:190)(RouterAddRoute) NetworkAddress (255.255.255.0) Netmask (255.255.255.0) Router (255.255.255.0). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (68) bytes at (0xC07875C0). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (56) bytes at (0xC0787630). (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC0787690). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c0787630 ExAl (transport/tcp/if.c:36) (Called from transport/tcp/if.c:36) (transport/tcp/if.c:41)(TCPPrepareInterface) Called (transport/tcp/if.c:56)(TCPPrepareInterface) Prepare interface c0787448 : addr 100007f (transport/tcp/if.c:63)(TCPPrepareInterface) Leaving (network/loopback.c:89)(LoopRegisterAdapter) Leaving. DriverBase for \SystemRoot\system32\drivers\afd.sys: de405000 (NTDLL:ldr/utils.c:2060) Relocating (78000000 -> 891000) C:\reactos\system32\dnsapi.dll DriverBase for \SystemRoot\System32\framebuf.DLL: de5b4000 (network/neighbor.c:92)(NCETimeout) Called. NCE (0xC07871D8). (network/neighbor.c:93)(NCETimeout) NCE->State is (0x1). (network/neighbor.c:226)(NBSendSolicit) Called. NCE (0xC07871D8). (network/neighbor.c:233)(NBSendSolicit) NCE: c07871d8 (network/arp.c:124)(ARPTransmit) Called. (network/arp.c:45)(PrepareARPPacket) Called. (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC0892778). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c0892710 ExAl (network/arp.c:54) (Called from network/arp.c:54) (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC08927B8). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c06d0010 npkt (network/arp.c:54) (Called from network/arp.c:54) (tcpip/pool.c:29)(PoolAllocateBuffer) Allocated (24) bytes at (0xC08927F8). (network/memtrack.c:36)(ShowTrackedThing) [Alloc] Thing c06cf030 nbuf (network/arp.c:54) (Called from network/arp.c:54) (network/arp.c:157)(ARPTransmit) Sending ARP Packet (datalink/lan.c:505)(LANTransmit) Called( NdisPacket c06d0010, Offset 14, Adapter c06c6898 ) (datalink/lan.c:514)(LANTransmit) Adapter Address [00 10 a7 13 97 61] (datalink/lan.c:563)(LANTransmit) LinkAddress: 0 (datalink/lan.c:577)(LANTransmit) NdisSend (datalink/lan.c:579)(LANTransmit) NdisSend Done (datalink/lan.c:183)(ProtocolSendComplete) Calling completion routine (network/arp.c:106)(ARPTransmitComplete) Called. (tcpip/buffer.c:395)(FreeNdisPacketX) Packet (0xC06D0010) (tcpip/buffer.c:405)(FreeNdisPacketX) Freeing ndis buffer (0xC06CF030) (network/memtrack.c:36)(ShowTrackedThing) [Free ] Thing c06cf030 nbuf (network/arp.c:54) (Called from network/arp.c:107) (tcpip/pool.c:45)(PoolFreeBuffer) Freeing buffer at (0xC08927F8). (tcpip/buffer.c:408)(FreeNdisPacketX) Freeing exal buffer (0xC0892710) (network/memtrack.c:36)(ShowTrackedThing) [Free ] Thing c0892710 ExAl (network/arp.c:54) (Called from network/arp.c:107) (tcpip/pool.c:45)(PoolFreeBuffer) Freeing buffer at (0xC0892778). (network/memtrack.c:36)(ShowTrackedThing) [Free ] Thing c06d0010 npkt (network/arp.c:54) (Called from network/arp.c:107) (tcpip/pool.c:45)(PoolFreeBuffer) Freeing buffer at (0xC08927B8). (datalink/lan.c:188)(ProtocolSendComplete) Finished (datalink/lan.c:183)(ProtocolSendComplete) Calling completion routine (network/arp.c:106)(ARPTransmitComplete) Called. (tcpip/buffer.c:395)(FreeNdisPacketX) Packet (0xC06D0010) (tcpip/buffer.c:405)(FreeNdisPacketX) Freeing ndis buffer (0xC06D0058) (network/memtrack.c:132)(TrackDumpFL) Dump: network/arp.c:107 (network/memtrack.c:47)(ShowTrackedThing) [Dump ] Thing c0788000 fbsd (*:0) (network/memtrack.c:47)(ShowTrackedThing) [Dump ] Thing c06c2698 fbsd (*:0) (network/memtrack.c:47)(ShowTrackedThing) [Dump ] Thing c078a000 fbsd (*:0) (network/memtrack.c:47)(ShowTrackedThing) [Dump ] Thing c06d1c60 fbsd (*:0) (network/memtrack.c:47)(ShowTrackedThing) [Dump ] Thing c06c65f8 fbsd (*:0) (network/memtrack.c:47)(ShowTrackedThing) [Dump ] Thing c06c6898 ExAl (datalink/lan.c:906) (network/memtrack.c:47)(ShowTrackedThing) [Dump ] Thing c06c6c78 ExAl (network/ip.c:181) (network/memtrack.c:47)(ShowTrackedThing) [Dump ] Thing c06d1fc8 ExAl (datalink/lan.c:633) (network/memtrack.c:47)(ShowTrackedThing) [Dump ] Thing c06c6f50 ExAl (datalink/lan.c:633) (network/memtrack.c:47)(ShowTrackedThing) [Dump ] Thing c07870e8 ExAl (datalink/lan.c:633) (network/memtrack.c:47)(ShowTrackedThing) [Dump ] Thing c0787160 ExAl (datalink/lan.c:709) (network/memtrack.c:47)(ShowTrackedThing) [Dump ] Thing c07873a8 ExAl (transport/tcp/if.c:36) (network/memtrack.c:47)(ShowTrackedThing) [Dump ] Thing c0787448 ExAl (network/ip.c:181) (network/memtrack.c:47)(ShowTrackedThing) [Dump ] Thing c0787630 ExAl (transport/tcp/if.c:36) UNTRACK: SPECIFIED ALREADY FREE ITEM c06d0058 (ke/process.c:72) Invalid attach (Thread is executing a DPC!) KeBugCheck at ke/process.c:73 Spinning on spinlock c014ceb0 current value 1 KeBugCheck at ke/spinlock.c:190 Spinning on spinlock c014ceb0 current value 1 KeBugCheck at ke/spinlock.c:190 Spinning on spinlock c014ceb0 current value 1 KeBugCheck at ke/spinlock.c:190 Spinning on spinlock c014ceb0 current value 1 KeBugCheck at ke/spinlock.c:190 Spinning on spinlock c014ceb0 current value 1 KeBugCheck at ke/spinlock.c:190 Spinning on spinlock c014ceb0 current value 1 KeBugCheck at ke/spinlock.c:190 Spinning on spinlock c014ceb0 current value 1 KeBugCheck at ke/spinlock.c:190 Spinning on spinlock c014ceb0 current value 1 KeBugCheck at ke/spinlock.c:190 Spinning on spinlock c014ceb0 current value 1 KeBugCheck at ke/spinlock.c:190 Spinning on spinlock c014ceb0 current value 1 KeBugCheck at ke/spinlock.c:190 Spinning on spinlock c014ceb0 current value 1 KeBugCheck at ke/spinlock.c:190 Spinning on spinlock c014ceb0 current value 1 KeBugCheck at ke/spinlock.c:190 Spinning on spinlock c014ceb0 current value 1 KeBugCheck at ke/spinlock.c:190 Spinning on spinlock c014ceb0 current value 1 KeBugCheck at ke/spinlock.c:190 Spinning on spinlock c014ceb0 current value 1 KeBugChecDouble Fault Exception: 8(0) CS:EIP 8:c033928a <hal.dll: 428a> cr2 dcdb0ffc cr3 338000 Proc: c056a068 Pid: 1 <SYSTEM> Thrd: c0571718 Tid: c DS 10 ES 10 FS 30 GS 10 EAX: 000000f8 EBX: 00000004 ECX: 00000000 EDX: 00000001 EBP: dcdb1020 ESI: c0592548 ESP: dcdb1000EDI: 00001000 EFLAGS: 00010002 kESP dcdb1000 kernel stack base dcdb1000 Frames: <ntoskrnl.exe: 26d4 (ke/i386/irq.c:310 (KiInterruptDispatch))> <ntoskrnl.exe: 2e27 (C:\DOCUME~1\home\LOCALS~1\Temp/ccCKaaaa.s:223 (RemoveEntryList))> <hal.dll: 4de6> <ntoskrnl.exe: b0ba5 (kd/kdebug.c:333 (KdSerialDebugPrint))> <ntoskrnl.exe: b0c58 (kd/kdebug.c:366 (KdpPrintString))> <ntoskrnl.exe: 322be (dbg/print.c:73 (DbgPrint))> <ntoskrnl.exe: 144e2 (ke/spinlock.c:190 (KiAcquireSpinLock))> <hal.dll: 6e7b> <hal.dll: 6d7e> <ntoskrnl.exe: 160f5 (ke/wait.c:61 (KeAcquireDispatcherDatabaseLock))> <ntoskrnl.exe: 13086 (ke/process.c:68 (KeAttachProcess))> <videoprt.sys: 24e9> <videoprt.sys: 183d> <vbemp.sys: 1de4> <vbemp.sys: 1975> <videoprt.sys: 1046> <hal.dll: 316d> <ntoskrnl.exe: e77c (ke/bug.c:110 (KeBugCheckWithTf))> <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <ntoskrnl.exe: 144ef (ke/spinlock.c:190 (KiAcquireSpinLock))> <hal.dll: 6e7b> <hal.dll: 6d7e> <ntoskrnl.exe: 160f5 (ke/wait.c:61 (KeAcquireDispatcherDatabaseLock))> <ntoskrnl.exe: 13086 (ke/process.c:68 (KeAttachProcess))> <videoprt.sys: 24e9> <videoprt.sys: 183d> <vbemp.sys: 1de4> <vbemp.sys: 1975> <videoprt.sys: 1046> <hal.dll: 316d> <ntoskrnl.exe: e77c (ke/bug.c:110 (KeBugCheckWithTf))> <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <ntoskrnl.exe: 144ef (ke/spinlock.c:190 (KiAcquireSpinLock))> <hal.dll: 6e7b> <hal.dll: 6d7e> <ntoskrnl.exe: 160f5 (ke/wait.c:61 (KeAcquireDispatcherDatabaseLock))> <ntoskrnl.exe: 13086 (ke/process.c:68 (KeAttachProcess))> <videoprt.sys: 24e9> <videoprt.sys: 183d> <vbemp.sys: 1de4> <vbemp.sys: 1975> <videoprt.sys: 1046> <hal.dll: 316d> <ntoskrnl.exe: e77c (ke/bug.c:110 (KeBugCheckWithTf))> <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <ntoskrnl.exe: 144ef (ke/spinlock.c:190 (KiAcquireSpinLock))> <hal.dll: 6e7b> <hal.dll: 6d7e> <ntoskrnl.exe: 160f5 (ke/wait.c:61 (KeAcquireDispatcherDatabaseLock))> <ntoskrnl.exe: 13086 (ke/process.c:68 (KeAttachProcess))> <videoprt.sys: 24e9> <videoprt.sys: 183d> <vbemp.sys: 1de4> <vbemp.sys: 1975> <videoprt.sys: 1046> <hal.dll: 316d> <ntoskrnl.exe: e77c (ke/bug.c:110 (KeBugCheckWithTf))> <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <ntoskrnl.exe: 144ef (ke/spinlock.c:190 (KiAcquireSpinLock))> <hal.dll: 6e7b> <hal.dll: 6d7e> <ntoskrnl.exe: 160f5 (ke/wait.c:61 (KeAcquireDispatcherDatabaseLock))> <ntoskrnl.exe: 13086 (ke/process.c:68 (KeAttachProcess))> <videoprt.sys: 24e9> <videoprt.sys: 183d> <vbemp.sys: 1de4> <vbemp.sys: 1975> <videoprt.sys: 1046> <hal.dll: 316d> <ntoskrnl.exe: e77c (ke/bug.c:110 (KeBugCheckWithTf))> <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <ntoskrnl.exe: 144ef (ke/spinlock.c:190 (KiAcquireSpinLock))> <hal.dll: 6e7b> <hal.dll: 6d7e> <ntoskrnl.exe: 160f5 (ke/wait.c:61 (KeAcquireDispatcherDatabaseLock))> <ntoskrnl.exe: 13086 (ke/process.c:68 (KeAttachProcess))> <videoprt.sys: 24e9> <videoprt.sys: 183d> <vbemp.sys: 1de4> <vbemp.sys: 1975> <videoprt.sys: 1046> <hal.dll: 316d> <ntoskrnl.exe: e77c (ke/bug.c:110 (KeBugCheckWithTf))> <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <ntoskrnl.exe: 144ef (ke/spinlock.c:190 (KiAcquireSpinLock))> <hal.dll: 6e7b> <hal.dll: 6d7e> <ntoskrnl.exe: 160f5 (ke/wait.c:61 (KeAcquireDispatcherDatabaseLock))> <ntoskrnl.exe: 13086 (ke/process.c:68 (KeAttachProcess))> <videoprt.sys: 24e9> <videoprt.sys: 183d> <vbemp.sys: 1de4> <vbemp.sys: 1975> <videoprt.sys: 1046> <hal.dll: 316d> <ntoskrnl.exe: e77c (ke/bug.c:110 (KeBugCheckWithTf))> <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <ntoskrnl.exe: 144ef (ke/spinlock.c:190 (KiAcquireSpinLock))> <hal.dll: 6e7b> <hal.dll: 6d7e> <ntoskrnl.exe: 160f5 (ke/wait.c:61 (KeAcquireDispatcherDatabaseLock))> <ntoskrnl.exe: 13086 (ke/process.c:68 (KeAttachProcess))> <videoprt.sys: 24e9> <videoprt.sys: 183d> <vbemp.sys: 1de4> <vbemp.sys: 1975> <videoprt.sys: 1046> <hal.dll: 316d> <ntoskrnl.exe: e77c (ke/bug.c:110 (KeBugCheckWithTf))> <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <ntoskrnl.exe: 144ef (ke/spinlock.c:190 (KiAcquireSpinLock))> <hal.dll: 6e7b> <hal.dll: 6d7e> <ntoskrnl.exe: 160f5 (ke/wait.c:61 (KeAcquireDispatcherDatabaseLock))> <ntoskrnl.exe: 13086 (ke/process.c:68 (KeAttachProcess))> <videoprt.sys: 24e9> <videoprt.sys: 183d> <vbemp.sys: 1de4> <vbemp.sys: 1975> <videoprt.sys: 1046> <hal.dll: 316d> <ntoskrnl.exe: e77c (ke/bug.c:110 (KeBugCheckWithTf))> <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <ntoskrnl.exe: 144ef (ke/spinlock.c:190 (KiAcquireSpinLock))> <hal.dll: 6e7b> <hal.dll: 6d7e> <ntoskrnl.exe: 160f5 (ke/wait.c:61 (KeAcquireDispatcherDatabaseLock))> <ntoskrnl.exe: 13086 (ke/process.c:68 (KeAttachProcess))> <videoprt.sys: 24e9> <videoprt.sys: 183d> <vbemp.sys: 1de4> <vbemp.sys: 1975> <videoprt.sys: 1046> <hal.dll: 316d> <ntoskrnl.exe: e77c (ke/bug.c:110 (KeBugCheckWithTf))> <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <ntoskrnl.exe: 144ef (ke/spinlock.c:190 (KiAcquireSpinLock))> <hal.dll: 6e7b> <hal.dll: 6d7e> <ntoskrnl.exe: 160f5 (ke/wait.c:61 (KeAcquireDispatcherDatabaseLock))> <ntoskrnl.exe: 13086 (ke/process.c:68 (KeAttachProcess))> <videoprt.sys: 24e9> <videoprt.sys: 183d> <vbemp.sys: 1de4> <vbemp.sys: 1975> <videoprt.sys: 1046> <hal.dll: 316d> <ntoskrnl.exe: e77c (ke/bug.c:110 (KeBugCheckWithTf))> <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <ntoskrnl.exe: 144ef (ke/spinlock.c:190 (KiAcquireSpinLock))> <hal.dll: 6e7b> <hal.dll: 6d7e> <ntoskrnl.exe: 160f5 (ke/wait.c:61 (KeAcquireDispatcherDatabaseLock))> <ntoskrnl.exe: 13086 (ke/process.c:68 (KeAttachProcess))> <videoprt.sys: 24e9> <videoprt.sys: 183d> <vbemp.sys: 1de4> <vbemp.sys: 1975> <videoprt.sys: 1046> <hal.dll: 316d> <ntoskrnl.exe: e77c (ke/bug.c:110 (KeBugCheckWithTf))> <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <ntoskrnl.exe: 144ef (ke/spinlock.c:190 (KiAcquireSpinLock))> <hal.dll: 6e7b> <hal.dll: 6d7e> <ntoskrnl.exe: 160f5 (ke/wait.c:61 (KeAcquireDispatcherDatabaseLock))> <ntoskrnl.exe: 13086 (ke/process.c:68 (KeAttachProcess))> <videoprt.sys: 24e9> <videoprt.sys: 183d> <vbemp.sys: 1de4> <vbemp.sys: 1975> <videoprt.sys: 1046> <hal.dll: 316d> <ntoskrnl.exe: e77c (ke/bug.c:110 (KeBugCheckWithTf))> <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <ntoskrnl.exe: 144ef (ke/spinlock.c:190 (KiAcquireSpinLock))> <hal.dll: 6e7b> <hal.dll: 6d7e> <ntoskrnl.exe: 160f5 (ke/wait.c:61 (KeAcquireDispatcherDatabaseLock))> <ntoskrnl.exe: 13086 (ke/process.c:68 (KeAttachProcess))> <videoprt.sys: 24e9> <videoprt.sys: 183d> <vbemp.sys: 1de4> <vbemp.sys: 1975> <videoprt.sys: 1046> <hal.dll: 316d> <ntoskrnl.exe: e77c (ke/bug.c:110 (KeBugCheckWithTf))> <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <ntoskrnl.exe: 144ef (ke/spinlock.c:190 (KiAcquireSpinLock))> <hal.dll: 6e7b> <hal.dll: 6d7e> <ntoskrnl.exe: 160f5 (ke/wait.c:61 (KeAcquireDispatcherDatabaseLock))> <ntoskrnl.exe: 13086 (ke/process.c:68 (KeAttachProcess))> <videoprt.sys: 24e9> <videoprt.sys: 183d> <vbemp.sys: 1de4> <vbemp.sys: 1975> <videoprt.sys: 1046> <hal.dll: 316d> <ntoskrnl.exe: e77c (ke/bug.c:110 (KeBugCheckWithTf))> <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <ntoskrnl.exe: 130da (ke/process.c:73 (KeAttachProcess))> <videoprt.sys: 24e9> <videoprt.sys: 183d> <vbemp.sys: 1de4> <vbemp.sys: 1975> <videoprt.sys: 1046> <hal.dll: 316d> <ntoskrnl.exe: e77c (ke/bug.c:110 (KeBugCheckWithTf))> <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <tcpip.sys: 92a3> <tcpip.sys: 15697> <tcpip.sys: 1d8c> <tcpip.sys: 15af9> <tcpip.sys: b40e> <ndis.sys: 7c00> <RTL8139.SYS: 2de5> <RTL8139.SYS: 528> <ndis.sys: 48c7> <ntoskrnl.exe: 10029 (ke/dpc.c:524 (KiDispatchInterrupt))> <hal.dll: 3ff1> <hal.dll: 4104> <hal.dll: 6f4c> <hal.dll: 6dcd> <tcpip.sys: 904b> <tcpip.sys: 199eb> <tcpip.sys: 100f5> <ntoskrnl.exe: 84f13 (ex/work.c:57 (ExWorkerThreadEntryPoint))> <ntoskrnl.exe: 39e0 (C:\DOCUME~1\home\LOCALS~1\Temp/ccYzaaaa.s:156 (KeUserModeCallback))>

3 4

vmware 4.5.2 crashes...
by Richard Campbell 05 Dec '04

05 Dec '04

With recent changes to ROS, vmware 4.5.2 crashes while booting from the bootcd. The last thing loaded is blue.sys. Can't really tell much more then that. Plan on investigating further, but figured i'd throw this at the list now in case someone already knows whats going on. Richard

3 2

msi.dll
by David Kredba 05 Dec '04

05 Dec '04

After the last Jim Tabor`s cvs commit msi.dll builds fine for me. Is it time to put it in the main Makefile ? Thanks, David -- David Kredba <kredba at ibot.cas.cz> GPG: ID 1024D/5B6B02DE Fingerprint: F0B3312596BEDCF91DFB 0699E06AACD75B6B02DE

8 8

Ros boot failure with networking enabled in real hardware
by Gge 05 Dec '04

05 Dec '04

With current CVS + Realtek8139 nic driver enabled in Hivesy , Ros still fails to boot as per debug messages below. Ros build with KDBG+DBG=1 - Real hardware Note : Ntoskrnl+ICP+NDIS+HAL Sym files installed but only symbol not displayed in the bugcheck Any help suggested ? This boot failure is a regression as it worked 2 weeks ago (Dpc problem) Regards Gerard ----------------------------------------------------------------- DriverBase for \SystemRoot\system32\drivers\pci.sys: dce04000 Peripheral Component Interconnect Bus Driver (io/create.c:90) Parent is a Directory which is neither a file type nor a device type (io/create.c:90) Parent is a Directory which is neither a file type nor a device type (ldr/loader.c:319) Could not open module file: \SystemRoot\system32\drivers\RTL8139.SYS (io/pnpmgr.c:1518) Initialization of service Rtl8139 failed (Status c0000001) (io/create.c:90) Parent is a Directory which is neither a file type nor a device type (ldr/loader.c:319) Could not open module file: \SystemRoot\system32\drivers\RTL8139.SYS (io/pnpmgr.c:1518) Initialization of service Rtl8139 failed (Status c0000001) DriverBase for scsiport.sys: dce0e000 DriverBase for atapi.sys: dce1a000 DriverBase for class2.sys: dce29000 DriverBase for disk.sys: dce33000 DriverBase for vfatfs.sys: dce3b000 DriverBase for bootvid.sys: dce50000 DriverBase for ndis.sys: dce70000 (ke/main.c:699) CommandLine: multi(0)disk(0)rdisk(0)partition(1)\reactos /DEBUGPORT=COM1/BAUDRATE=115200/KDSERIAL DriverBase for \SystemRoot\system32\drivers\RTL8139.SYS: dcec0000 DriverBase for \SystemRoot\system32\drivers\floppy.sys: dcf4c000 DriverBase for \SystemRoot\system32\drivers\cdrom.sys: dcf71000 DriverBase for \SystemRoot\system32\drivers\fs_rec.sys: dcf81000 DriverBase for \SystemRoot\system32\drivers\beep.sys: dcf91000 (ldr/loader.c:319) Could not open module file: \SystemRoot\system32\drivers\sndblst.sys (ldr/loader.c:319) Could not open module file: \SystemRoot\system32\drivers\es137140.sys (ldr/loader.c:319) Could not open module file: \SystemRoot\system32\drivers\mpu401.sys DriverBase for \SystemRoot\system32\drivers\null.sys: dcfd6000 DriverBase for \SystemRoot\system32\drivers\serial.sys: dcfe6000 Serial Driver 0.0.2 DriverBase for \SystemRoot\system32\drivers\psaux.sys: dcffe000 DriverBase for \SystemRoot\system32\drivers\keyboard.sys: dd01a000 DriverBase for \SystemRoot\system32\drivers\mouclass.sys: dd02c000 DriverBase for \SystemRoot\system32\drivers\debugout.sys: dd03b000 DriverBase for \SystemRoot\system32\drivers\blue.sys: dd04a000 DriverBase for \SystemRoot\system32\drivers\vbemp.sys: dd05a000 DriverBase for \SystemRoot\system32\drivers\videoprt.sys: dd07c000 DriverBase for \SystemRoot\system32\drivers\vgamp.sys: dd091000 DriverBase for \SystemRoot\system32\drivers\msfs.sys: dd0a2000 DriverBase for \SystemRoot\system32\drivers\npfs.sys: dd0bb000 DriverBase for \SystemRoot\system32\win32k.sys: ddb95000 DriverBase for \SystemRoot\system32\freetype.dll: ddcb3000 DriverBase for \SystemRoot\System32\kbdfr.dll: ddd3b000 WL-Status: ReactOS is starting up... (service/sctrl.c:120) ScDispatcherLoop() called DriverBase for \SystemRoot\system32\drivers\tcpip.sys: de345000 Here1 kmem_malloc(1) kmem_malloc done Freeing c0788000 onto the free list Freeing c0788800 onto the free list done with m_clalloc Here2 domaininit starting (1) Domain internet initializing Registering protocols for internet Domaininit done DriverBase for \SystemRoot\system32\drivers\afd.sys: de405000 UNTRACK: SPECIFIED ALREADY FREE ITEM c06d0058 Bug detected (code 0 param 0 0 0 0) The bug code is undefined. Please use an existing code instead. Frames: <ntoskrnl.exe: e8da (ke/bug.c:203 (KeBugCheckEx))> <ntoskrnl.exe: e8fa (ke/bug.c:220 (KeBugCheck))> <tcpip.sys: 92a3> <tcpip.sys: 15697> <tcpip.sys: 1d8c> <tcpip.sys: 15af9> <tcpip.sys: b40e> <ndis.sys: 7c00> <RTL8139.SYS: 2de5> <RTL8139.SYS: 528> <ndis.sys: 48c7> <ntoskrnl.exe: 10029 (ke/dpc.c:524 (KiDispatchInterrupt))> <hal.dll: 3ff1> <hal.dll: 4104> <hal.dll: 6f4c> <hal.dll: 6dcd> <tcpip.sys: 904b> <tcpip.sys: 199eb> <tcpip.sys: 100f5> <ntoskrnl.exe: 84f13 (ex/work.c:57 (ExWorkerThreadEntryPoint))> <ntoskrnl.exe: 39e0 (C:\DOCUME~1\home\LOCALS~1\Temp/ccYzaaaa.s:156 (KeUserModeCallback))>

1 0

winecalc Translation - De.rc
by Klemens Friedl 04 Dec '04

04 Dec '04

Hi! I translated winecalc to german. Files: \subsys\system\calc\rsrc.rc - Line 32: #include "De.rc" Language-File: De.rc Please add the files to ReactOS CVS. Klemens Friedl <frik85> -- GMX ProMail mit bestem Virenschutz http://www.gmx.net/de/go/mail +++ Empfehlung der Redaktion +++ Internet Professionell 10/04 +++

3 2

Must Read!!!! Msi.dll and Bison Alert!!!!
by James Tabor 04 Dec '04

04 Dec '04

Hi All! Jim Tabor wrote: > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: reactos/lib/msi/ > Changes by: jimtabor(a)mok.osexperts.com 04/11/30 11:10:55 > > Added files: > reactos/lib/msi/: .cvsignore Makefile Makefile.in > Makefile.ros-template action.c cond.y create.c > distinct.c handle.c insert.c msi.c msi.spec > msipriv.h msiquery.c order.c package.c query.h > record.c regsvr.c select.c sql.y string.c > suminfo.c table.c tokenize.c update.c > version.rc where.c winehq2ros.patch > > Log message: > First port of Wine projects msi.dll > With this commit, we will be using bison to build cond.y and sql.y. Okay, for those using a Window 32 based system 8^p you will need *bison*! http://gnuwin32.sourceforge.net/packages/bison.htm http://www.mingw.org Good luck, James

13 29

RE: [ros-cvs] CVS Update: reactos
by Ge van Geldorp 04 Dec '04

04 Dec '04

> From: Ge van Geldorp > > Log message: > Current versions of VMware provide a correct BIOS memory map I removed this code: #ifndef ACPI /* FIXME: VMware does not like it when ReactOS is using the BIOS memory map */ KeLoaderBlock.Flags &= ~MB_FLAGS_MMAP_INFO; #endif Casper added this code a few years back, at that point using the BIOS memory map prevented ReactOS from booting. It appears to work fine now (with VMware 4). This email is just a heads-up for everyone, if ReactOS fails to boot now this change may cause it (and I will reverse the change if it causes problems). Gé van Geldorp

2 1

msiexec.exe
by David Kredba 04 Dec '04

04 Dec '04

There is little problem with msiexec.exe : make[1]: Entering directory `/home/dave2/ros/reactos/subsys/system/msiexec' mingw32-gcc -I../../../include/wine -D_WIN32_IE=0x0501 -D_WIN32_WINNT=0x0501 -D__USE_W32API -I. -I../../../include -I../../../w32api/include -pipe -march=i486 -D_M_IX86 -g -M msiexec.c | ../../../tools/depends . .msiexec.d make[1]: Leaving directory `/home/dave2/ros/reactos/subsys/system/msiexec' make[1]: Entering directory `/home/dave2/ros/reactos/subsys/system/msiexec' mingw32-windres --include-dir ../../../include --include-dir ../../../w32api/include version.rc -o version.coff mingw32-gcc -I../../../include/wine -D_WIN32_IE=0x0501 -D_WIN32_WINNT=0x0501 -D__USE_W32API -I. -I../../../include -I../../../w32api/include -pipe -march=i486 -D_M_IX86 -g -c msiexec.c -o msiexec.o mingw32-ar -rc msiexec.a msiexec.o make[1]: *** No rule to make target `../../../dk/w32/lib/liblibwine.a', needed by `msiexec.nostrip.exe'. Stop. make[1]: Leaving directory `/home/dave2/ros/reactos/subsys/system/msiexec' make: *** [msiexec] Error 2 fixable by deleting 'lib' from libwine in subsys/system/msiexec/ /Makefile. Regards, David -- David Kredba <kredba at ibot.cas.cz> GPG: ID 1024D/5B6B02DE Fingerprint: F0B3312596BEDCF91DFB 0699E06AACD75B6B02DE

1 0

Re: [ros-cvs] CVS Update: reactos
by James Tabor 03 Dec '04

03 Dec '04

Hi! navaraf(a)cvs.reactos.com wrote: > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: reactos/w32api/include/ > Changes by: navaraf(a)mok.osexperts.com 04/12/01 12:06:18 > > Modified files: > reactos/include/wine/: objidl.h > reactos/lib/oleaut32/: Makefile.in oaidl_p.c olefont.c > tmarshal.c typelib.c typelib.h typelib2.c > reactos/lib/uuid/: uuid.c > reactos/w32api/include/: oaidl.h objidl.h ocidl.h oleauto.h > rpc.h rpcndr.h rpcproxy.h > > Log message: > - Get full OLEAUT32 to compile. > I dont understand what happen but when the oleaut32.a is first generated it is 297702 bytes in dk/w32/lib. After oleaut32.dll it built, oleaut32.a is 492292 bytes. With the larger file in dk/w32/lib, it causes build errors with explorer. When making msi.dll with the smaller or first file, I get undefined reference to `LoadTypeLib', with the larger; ../../dk/w32/lib/oleaut32.a(oleaut.o)(.text+0x803):oleaut.c: multiple definition of `DllMain@12' msi.o(.text+0x3ad3):msi.c: first defined here make: *** [msi.nostrip.dll] Error 1 Explorer; ../../../dk/w32/lib/oleaut32.a(variant.o)(.text+0x2004):variant.c: undefined reference to `DbgPrint' ../../../dk/w32/lib/oleaut32.a(variant.o)(.text+0x201a):variant.c: undefined reference to `DbgPrint' ../../../dk/w32/lib/oleaut32.a(variant.o)(.text+0x2d05):variant.c: undefined reference to `DbgPrint' ../../../dk/w32/lib/oleaut32.a(variant.o)(.text+0x2d21):variant.c: undefined reference to `DbgPrint' ../../../dk/w32/lib/oleaut32.a(variant.o)(.text+0x2da5):variant.c: undefined reference to `DbgPrint' ../../../dk/w32/lib/oleaut32.a(variant.o)(.text+0x2dc1):variant.c: more undefined references to `DbgPrint' follow ../../../dk/w32/lib/oleaut32.a(oleaut.o)(.text+0x314):oleaut.c: undefined reference to `StringFromGUID2@12' ../../../dk/w32/lib/oleaut32.a(oleaut.o)(.text+0x333):oleaut.c: undefined reference to `CreateItemMoniker@12' ../../../dk/w32/lib/oleaut32.a(oleaut.o)(.text+0x367):oleaut.c: undefined reference to `GetRunningObjectTable@8' ../../../dk/w32/lib/oleaut32.a(oleaut.o)(.text+0x42a):oleaut.c: undefined reference to `GetRunningObjectTable@8' ../../../dk/w32/lib/oleaut32.a(oleaut.o)(.text+0x4a1):oleaut.c: undefined reference to `StringFromGUID2@12' ../../../dk/w32/lib/oleaut32.a(oleaut.o)(.text+0x4c0):oleaut.c: undefined reference to `CreateItemMoniker@12' ../../../dk/w32/lib/oleaut32.a(oleaut.o)(.text+0x4f4):oleaut.c: undefined reference to `GetRunningObjectTable@8' ../../../dk/w32/lib/oleaut32.a(oleaut.o)(.text+0x6a0):oleaut.c: undefined reference to `DbgPrint' ../../../dk/w32/lib/oleaut32.a(oleaut.o)(.text+0x6b0):oleaut.c: undefined reference to `DbgPrint' ../../../dk/w32/lib/oleaut32.a(oleaut.o)(.text+0x784):oleaut.c: undefined reference to `GetPaletteEntries@16' ../../../dk/w32/lib/oleaut32.a(safearray.o)(.text+0x57f):safearray.c: undefined reference to `DbgPrint' ../../../dk/w32/lib/oleaut32.a(safearray.o)(.text+0x595):safearray.c: undefined reference to `DbgPrint' ../../../dk/w32/lib/oleaut32.a(safearray.o)(.text+0xf42):safearray.c: undefined reference to `DbgPrint' ../../../dk/w32/lib/oleaut32.a(safearray.o)(.text+0xf52):safearray.c: undefined reference to `DbgPrint' ../../../dk/w32/lib/oleaut32.a(vartype.o)(.text+0x453c):vartype.c: undefined reference to `DbgPrint' ../../../dk/w32/lib/oleaut32.a(vartype.o)(.text+0x4552):vartype.c: more undefined references to `DbgPrint' follow ../../../dk/w32/lib/oleaut32.a(vartype.o)(.text+0x602f):vartype.c: undefined reference to `strtoulW' ../../../dk/w32/lib/oleaut32.a(vartype.o)(.text+0x803e):vartype.c: undefined reference to `DbgPrint' ../../../dk/w32/lib/oleaut32.a(vartype.o)(.text+0x8058):vartype.c: undefined reference to `DbgPrint' make: *** [explorer.nostrip.exe] Error 1 So, with the smaller, there are no refs to the typelib code. FYI, James

2 2

HAL reorganisation
by Ge van Geldorp 02 Dec '04

02 Dec '04

As most of you know, I'm dabbling around a little bit with a port of ReactOS to the Xbox. I think most of the differences between a standard PC and the Xbox can be handled by using a custom HAL for the Xbox, after all, that's what the HAL is for. At the moment, we build 1 HAL, based on the value of MP in config it's either a UniProcessor HAL or a MultiProcessor HAL. Which code is compiled is based on preprocessor statements. I'd like to be able to build 3 HALs in parallel, the UP, MP and Xbox HALs. When installing ("make install"), the correct HAL would be selected based on the MP config var. When creating a boot cd, all three would be copied to the CD and the setup program would select the correct one to copy to the harddisk. This will allow us to build a single boot CD for different configurations. I'm aware that we'll need a NTKRNLMP.EXE on the boot CD too (I will try very very hard not to need a different kernel for Xbox) for this "single boot CD" idea to work, but that's a different problem and I'd like to tackle that later. The three HALs will share a lot of the code. To avoid code duplication, I propose to create a directory structure like this: hal | --- hal | --- halx86 | | | +----- generic | | | | | +----- include | | | +----- up | | | +----- mp | | | +----- xbox | +-- hal68k :-) | +-- etc... The "generic" subdir will contain most of the code. The "up" subdir will contain mostly simple .c files which just include a .c file from generic. For example, the HalMakeBeep() function will be defined in generic/beep.c. In "up" there will be a file beep_up.c which contains only 'include "beep.c"', which will be compiled with the include path set to "../generic". The "mp" and "xbox" directories can either include "generic" files or have their own implementation of a given routine (e.g. display_xbox.c for HalDisplay* functions on the Xbox). Doing it this way we should have little code duplication and our dependency tracking system should work. Comments? Gé van Geldorp.

7 11

DirectX
by Maarten Bosma 02 Dec '04

02 Dec '04

Hi, I have started coding the Direct3d 9 dll. It isn't something usable yet, but only a few kernel calls have to be made to run the first (very simple) Direct3D program. I have already looked up those functions, but most of them need some huge structs as parameters. At the moment I don't have the time to work on it. Maybe one of you would like to do so. But be warned this is the first time that i am working on an open source project and my coding style isn't the best. Maarten Bosma

3 5

RE: [ros-dev] Very bad Idea.
by Waldo Alvarez Cañizares 01 Dec '04

01 Dec '04

Hi Robert: How are you? I think that putting a little generated file won´t hurt, notice that you could add a warning like /* ======================================== this is a machine generated code modify xfile.l instead ========================================*/ I think that dealing with bison could make the build system a little more complex and remember that with the current one some people gets confused when starting. In fact lots of compilers source packages have both files in case you want to modify grammar rules the (.l .lex .y .ycc) and the .c in case you don´t have a parser generator, the gcc team does that and they are not the only ones, so seems to be a good choice. Regards Waldo Alvarez ________________________________ From: ros-dev-bounces(a)reactos.com on behalf of Robert Köpferl Sent: Wed 12/1/2004 4:16 PM To: ReactOS Development List Subject: [ros-dev] Very bad Idea. Sorry guys, but some of you never heared about (lets say) compiler and code. Never, never import generated artifacts into a VCS. The only thing allowed is doc and code (models). At a generated peace of code is not worked on (one mustn't). Instead one has to work on it's model (its source). This sadly implies that the matching tool (a compiler/transformer) must be available. As you mentioned: People will start working on generated code (baaaad). Also I hate projects where establishing a build env. seems like programming an app. But you can't ascribe everything back to Gcc as a minimum dominator. Gcc is not the high-level language to produce parsers. Try to run a make script with gcc :-/ Thus I am for adding bison to our tool list and against importing generated code (=not source). And think: Bison is litle more C++ affine than a Pascal compiler or the like. In my sight it's not harder than providing an archive which contains bison beneath mingw etc. If you want me to, I'd create that archive. Steven Edwards wrote: > Hi Alex, > > I understand everyones problem with bison and I agree with Filip, > Casper and GvG. Importing the generated C file in to CVS is fine as far > as I see it. The issue I worry about is people not submitting stuff > back toi Winehq and having thier code get lost in the merges. I have > some ideas about how to deal with this problem but I need to talk them > over with GvG, Eric, Filip and others that have done a lot of work on > ported Wine code. > > I have tried to address some of the other questions inline. > > --- Alex Ionescu <ionucu(a)videotron.ca> wrote: > >>All great points but I must ask, why should be bend our "rules" in >>order >>to be able to mingle cleanly with WINE, and why shouldn't they be the > > >>ones that should also try to be more flexible. From what you're >>saying >>(I have no personal experience to base this upon), it seems that they >>aren't trying very hard to make sure everything stays easily >>portable. I >>agree we need wine for the user dlls, but they also need our fixes to >>be >>easily implementable in their tree. > > > The Wine developers spent a year looking in to how to implement MSI you > would have come to the same answer they did and that was using bison to > generate the database was the best way to go. This is a tool that is > going to be used on Linux by Linux people for Linux people. I mean when > you talk about porting Wine you have to understand that Winelib runs on > Linux, Solaris, Mac OS/X. It does not get much more portable than that > for a Unix application. And yes its audited vs MS_VC from time to time. > I can build more of Wine with MS_VC than I can ReactOS. > > Most of the world still laughs at the ideal of ReactOS but Wine project > (and Mingw) have been one of our closest supporters. A good number of > the Wine developers lurk on this lists and try to do things to help > both projects. > > If you give a example of a real problem we have had working with them > so far then we can have that problem addressed in little to no time. > The Wine development process is a little slow but its also for all the > bad talk it gets one of the most stable and cleanest FreeSoftware > projects there is. I have never checked out Wine CVS and had the build > be broken, had a major regression that lasted more than a day or had > any problem getting a good answer as to why something could not go in > to CVS. > > >>I think the best solution is for everyone to work together, and to >>try >>to respect our project's guidelines. If they really need to do stuff >>their own way, we really need to do stuff our own way too. Maybe some > > >>sort of mega conversion tool could be built or something of the sort. >>I >>think WINE has gotten really far, but because they are such an old >>project, they are carrying a lot of cruft that needs to cleaned out >>(just like any other project). It would be unsensical to have to >>import >>such cruft (I'm not referring to Bison, but those x-level DLL >>messes). > > > This is not going to happen overnight. If you look at the revision > history of Wine you will see where Alexandre and the Wine team has > added many things to aid in our development. Supporting seperating the > Win16 and Win32 dlls in the build, adding cross-compiling support, > cleaning up the header dependancy mess in the Wine tree, removing > Wineisms/Unixisms etc.... > > An import/conversion tool would be nice and GvG started working on > making it a little less painful by adding support for Wine makefiles to > the build system. Importing some of the other Wine tools would make > things easy too such as WIDL and using the Wine headers but most of the > ReactOS does not want to do that. > > >>I don't see why the .C code would force everyone to use linux? Why >>would >>mingw32 not want to build it? Anyways, I restate, I'm against Bison > > > Sure and I am not opposed to having the generated sources imported in > the CVS. We already do this for the Wine Message Compiler that we have > used in ntoskrnl and kernel32 for years. > > Anyway if anyone has any ideas about how to make code sharing with Wine > more simple I am all ears. My patches to fix Wine building on MS_VC are > almost never rejected, ditto for the Win16/32 cleanups or anything else > that would make sharing code less of a pain. > > Thanks > Steven > > > > > __________________________________ > Do you Yahoo!? > Yahoo! Mail - Helps protect you from nasty viruses. > http://promotions.yahoo.com/new_mail > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.com > http://reactos.com:8080/mailman/listinfo/ros-dev > _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev

1 0

RE: [ros-dev] HAL reorganisation
by Waldo Alvarez Cañizares 01 Dec '04

01 Dec '04

Hi Ge: Now that you talk it think that if some port is to be done that would be the ideal been a lot like the PC. IMHO the next could be a little endian well known arch. Regards Waldo ________________________________ From: ros-dev-bounces(a)reactos.com on behalf of Ge van Geldorp Sent: Tue 11/30/2004 5:21 PM To: 'ReactOS Development List' Subject: [ros-dev] HAL reorganisation As most of you know, I'm dabbling around a little bit with a port of ReactOS to the Xbox. I think most of the differences between a standard PC and the Xbox can be handled by using a custom HAL for the Xbox, after all, that's what the HAL is for. At the moment, we build 1 HAL, based on the value of MP in config it's either a UniProcessor HAL or a MultiProcessor HAL. Which code is compiled is based on preprocessor statements. I'd like to be able to build 3 HALs in parallel, the UP, MP and Xbox HALs. When installing ("make install"), the correct HAL would be selected based on the MP config var. When creating a boot cd, all three would be copied to the CD and the setup program would select the correct one to copy to the harddisk. This will allow us to build a single boot CD for different configurations. I'm aware that we'll need a NTKRNLMP.EXE on the boot CD too (I will try very very hard not to need a different kernel for Xbox) for this "single boot CD" idea to work, but that's a different problem and I'd like to tackle that later. The three HALs will share a lot of the code. To avoid code duplication, I propose to create a directory structure like this: hal | --- hal | --- halx86 | | | +----- generic | | | | | +----- include | | | +----- up | | | +----- mp | | | +----- xbox | +-- hal68k :-) | +-- etc... The "generic" subdir will contain most of the code. The "up" subdir will contain mostly simple .c files which just include a .c file from generic. For example, the HalMakeBeep() function will be defined in generic/beep.c. In "up" there will be a file beep_up.c which contains only 'include "beep.c"', which will be compiled with the include path set to "../generic". The "mp" and "xbox" directories can either include "generic" files or have their own implementation of a given routine (e.g. display_xbox.c for HalDisplay* functions on the Xbox). Doing it this way we should have little code duplication and our dependency tracking system should work. Comments? Gé van Geldorp. _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev

1 0

Re: [ros-cvs] CVS Update: reactos
by Filip Navara 01 Dec '04

01 Dec '04

greatlrd(a)cvs.reactos.com wrote: >CVSROOT: /CVS/ReactOS >Module name: reactos >Repository: reactos/lib/dinput/ >Changes by: greatlrd(a)mok.osexperts.com 04/12/01 07:20:14 > >Added files: > reactos/lib/dinput/: dinput.spec.def > >Log message: > forget add file dinput.spec.def > other wise dinput will not build > > This is wrong and this file should be autogenerated. Only the dinput.spec file should be in CVS! - Filip

2 1

RE: [ros-dev] HAL reorganisation
by Colin Burn 01 Dec '04

01 Dec '04

CXBX would not be suitable for developing ROS. CXBX doesn't try to emulate any of the hardware of an Xbox, it instead tries to convert an xbox executable (xbe) into a windows executable (exe). The conversion is done by locating DirectX calls in the xbe (Note: On an xbox the executables are directly linked to the DirectX libraries) and redirecting them appropriately under windows. -----Original Message----- From: Richard Campbell [mailto:eek2121@comcast.net] Sent: 01 December 2004 09:31 To: ReactOS Development List Subject: Re: [ros-dev] HAL reorganisation Keep in mind there is an XBOX emulator: CXBX available at http://www.caustik.com/cxbx/, that, though incomplete, runs at least 1 commercial game and might be complete enough to run an xbox port of ROS. Also, i'm sure you already know about the OpenXDK at http://www.openxdk.org/.

2 1

Re: [ros-cvs] CVS Update: reactos
by James Tabor 01 Dec '04

01 Dec '04

weiden(a)cvs.reactos.com wrote: > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: ./ > Changes by: weiden(a)mok.osexperts.com 04/11/30 12:21:34 > > Modified files: > ./: Makefile > > Log message: > don't build msi for now as it uses a 3rd party build utility until situation is cleared > It build on a windows box, right? It worked on my wifes XP here, but it did build right? Ducken behind the desk waiting for more flamers, James

2 1

Msi.dll was Re: working together on stdole.tlb and a end to dcom9x
by James Tabor 30 Nov '04

30 Nov '04

Wow! To complete the port for msi.dll, I need LoadTypeLib, RegisterTypeLib and ITypeLib_Release. So, is stdole32 a "32 bit" replacement for Wine typelib oleaut32 functions? I see only CreateTypeLib2 in the file. Thanks, James ps. I can compile msi w/o those functions, ha! just comment them out. So here is a patch and makefiles, just remove the "msi-" and go. Steven Edwards wrote: > Hi Sam, > --- Sam Lauber <sam124(a)operamail.com> wrote: > >>I tried it with MS mktyplib (with Wine DLLs). Strangly, it produced >>the exact same FIXMEs that the C program generated, but generated a >>diffrent typelib. And more then two bytes differed. The two typelibs >>are attached. I'll try it with InstallShield. > > > Try this one > > http://www.volny.cz/xnavara/stdole32.c > > Thanks > Steven > > Only in /root/wine/wine/dlls/msi: .cvsignore Only in /root/wine/wine/dlls/msi: CVS Only in ./: Makefile Only in ./: Makefile.ros-template diff -u /root/wine/wine/dlls/msi/action.c ./action.c --- /root/wine/wine/dlls/msi/action.c 2004-10-27 20:43:05.000000000 -0500 +++ ./action.c 2004-10-30 12:14:17.000000000 -0500 @@ -28,6 +28,7 @@ #include <stdarg.h> #include <stdio.h> +#include <fcntl.h> #define COBJMACROS @@ -39,7 +40,7 @@ #include "fdi.h" #include "msi.h" #include "msiquery.h" -#include "msvcrt/fcntl.h" +//#include "msvcrt/fcntl.h" #include "objbase.h" #include "objidl.h" #include "msipriv.h" @@ -3477,7 +3478,7 @@ continue; } - res = LoadTypeLib(package->files[index].TargetPath,&ptLib); +// res = LoadTypeLib(package->files[index].TargetPath,&ptLib); if (SUCCEEDED(res)) { WCHAR help[MAX_PATH]; @@ -3488,7 +3489,7 @@ resolve_folder(package,helpid,help,FALSE,FALSE,NULL); - res = RegisterTypeLib(ptLib,package->files[index].TargetPath,help); +// res = RegisterTypeLib(ptLib,package->files[index].TargetPath,help); if (!SUCCEEDED(res)) ERR("Failed to register type library %s\n", debugstr_w(package->files[index].TargetPath)); @@ -3503,8 +3504,9 @@ debugstr_w(package->files[index].TargetPath)); } - if (ptLib) - ITypeLib_Release(ptLib); + if (ptLib){ + //ITypeLib_Release(ptLib); + } } else ERR("Failed to load type library %s\n", Only in ./: patch.diff diff -u /root/wine/wine/dlls/msi/suminfo.c ./suminfo.c --- /root/wine/wine/dlls/msi/suminfo.c 2004-10-18 13:20:12.000000000 -0500 +++ ./suminfo.c 2004-10-30 00:09:12.000000000 -0500 @@ -23,6 +23,8 @@ #define COBJMACROS #define NONAMELESSUNION +#define PRSPEC_PROPID (1) + #include "windef.h" #include "winbase.h" #include "winreg.h" # $Id: Makefile,v 1.12 2004/02/25 20:00:41 sedwards Exp $ PATH_TO_TOP = ../.. TARGET_TYPE = winedll include $(PATH_TO_TOP)/rules.mak include $(TOOLS_PATH)/helper.mk # $Id: Makefile.ros-template TARGET_NAME = msi TARGET_OBJECTS = @C_SRCS@ @EXTRA_OBJS@ TARGET_CFLAGS = -D__REACTOS__ @EXTRADEFS@ TARGET_SDKLIBS = @IMPORTS@ libwine.a wine_uuid.a ntdll.a TARGET_BASE = $(TARGET_BASE_LIB_WINMM) TARGET_RC_SRCS = @RC_SRCS@ TARGET_RC_BINSRC = @RC_BINSRC@ TARGET_RC_BINARIES = @RC_BINARIES@ TARGET_CLEAN = *.tab.c *.tab.h default: all DEP_OBJECTS = $(TARGET_OBJECTS) include $(TOOLS_PATH)/depend.mk # # Bison is requiered for building msi.dll. If MingW32 for windows, # download bison from http://gnuwin32.sourceforge.net/ # Make sure bison.exe is placed in your command path for execution. # # sql.tab.c sql.tab.h: sql.y bison -p SQL_ -d ./sql.y -o sql.tab.c cond.tab.c cond.tab.h: cond.y bison -p COND_ -d ./cond.y -o cond.tab.c

1 0

compile failure on debian with mingw32msvc
by Damian Dimmich 29 Nov '04

29 Nov '04

Hi, Just like to let you know that the latest cvs code does not compile out of the box using mingw on a debian testing box. $i586-mingw32msvc-cc --version i586-mingw32msvc-cc (GCC) 3.4.2 (mingw-special) The problem is some functions are re-declared in the string.h (line 169, wchar_t() ) and stdio.h (line 269, putwc() )files. Also the loadlib.c test file failed to compile since it was not including stdlib.h and could not find the mbstowcs function. This is the latest cvs code from 5:30'ish GMT. Cheers, Damian output from cvs diff: Index: apps/testsets/loadlib/loadlib.c =================================================================== RCS file: /CVS/ReactOS/reactos/apps/testsets/loadlib/loadlib.c,v retrieving revision 1.2 diff -r1.2 loadlib.c 26a27 > #include <stdlib.h> Index: include/msvcrt/stdio.h =================================================================== RCS file: /CVS/ReactOS/reactos/include/msvcrt/stdio.h,v retrieving revision 1.8 diff -r1.8 stdio.h 269c269 < int putwc(wint_t wc, FILE* fileWrite); --- > //int putwc(wint_t wc, FILE* fileWrite); Index: include/msvcrt/string.h =================================================================== RCS file: /CVS/ReactOS/reactos/include/msvcrt/string.h,v retrieving revision 1.6 diff -r1.6 string.h 169c169 < wchar_t* wcsdup(const wchar_t* wsToDuplicate); --- > //wchar_t* wcsdup(const wchar_t* wsToDuplicate);

1 0

ELF mapping support for ntoskrnl, for anybody who is interested (untested)
by Gregor Anich 29 Nov '04

29 Nov '04

Hi! I have attached a elf.h file (to be put into the toplevel include directory) with ELF structures/constants and a patch for ntoskrnl/mm/section.c which should add support for mapping ELF files with NtCreateSection. It is completly untested I think. We also have to port a runtime linker (rtld) - it has to be statically linked/use only syscalls because if an ELF file contains an interpreter name (on linux something like /lib/rtld-elf.so) the kernel usually maps the interpreter instead (or additionally) and begins execution at the interpreter's entry point, passing it a file handle or the base address of the file to be linked & ran and the interpreter does the rest. - blight #ifndef __INCLUDE_ELF_H #define __INCLUDE_ELF_H #ifdef __64BITS__ /* FIXME: how to check for 64 bits? */ # define ELF_ARCH_SIZE 64 #else # define ELF_ARCH_SIZE 32 #endif /* 32-bit data types */ typedef unsigned long ELF32_ADDR; /* Unsigned program address */ typedef unsigned short ELF32_HALF; /* Unsigned medium integer */ typedef unsigned long ELF32_OFF; /* Unsigned file offset */ typedef unsigned long ELF32_SWORD; /* Signed large integer */ typedef unsigned long ELF32_WORD; /* Unsigned large integer */ typedef ELF32_OFF ELF32_HASHELT; /* Hash element? */ /* Elf data encodings */ #define IMAGE_ELF_DATA_NONE 0 /* Invalid data encoding */ #define IMAGE_ELF_DATA_2LSB 1 /* 2's complement, LSB first */ #define IMAGE_ELF_DATA_2MSB 2 /* 2's complement, MSB first */ /* Elf object file types */ #define IMAGE_ELF_TYPE_NONE 0 /* No file type */ #define IMAGE_ELF_TYPE_REL 1 /* Relocatable file */ #define IMAGE_ELF_TYPE_EXEC 2 /* Executable file */ #define IMAGE_ELF_TYPE_DYN 3 /* Shared object file */ #define IMAGE_ELF_TYPE_CORE 4 /* Core file */ /* Elf machines */ #define IMAGE_ELF_MACHINE_NONE 0 /* No machine */ #define IMAGE_ELF_MACHINE_M32 1 /* AT&T WE 32100 */ #define IMAGE_ELF_MACHINE_SPARC 2 /* SPARC */ #define IMAGE_ELF_MACHINE_386 3 /* Intel 80386 */ #define IMAGE_ELF_MACHINE_68K 4 /* Motorola 68000 */ #define IMAGE_ELF_MACHINE_88K 5 /* Motorola 88000 */ /* 6 is reserved */ #define IMAGE_ELF_MACHINE_860 7 /* Intel 80860 */ #define IMAGE_ELF_MACHINE_MIPS 8 /* MIPS RS3000 (MIPS I) */ #define IMAGE_ELF_MACHINE_S370 9 /* IBM System/370 Processor */ #define IMAGE_ELF_MACHINE_MIPS_RS3_LE 10 /* MIPS RS3000 Little-endian */ /* 11-14 are reserved */ #define IMAGE_ELF_MACHINE_PARISC 15 /* Hewlett-Packard PA-RISC */ /* 16 is reserved */ #define IMAGE_ELF_MACHINE_VPP500 17 /* Fujitsu VPP500 */ #define IMAGE_ELF_MACHINE_SPARC32PLUS 18 /* Enhanced instruction set SPARC */ #define IMAGE_ELF_MACHINE_960 19 /* Intel 80960 */ #define IMAGE_ELF_MACHINE_PPC 20 /* PowerPC */ #define IMAGE_ELF_MACHINE_PPC64 21 /* 64-bit PowerPC */ /* 22-35 are reserved */ #define IMAGE_ELF_MACHINE_V800 36 /* NEC V800 */ #define IMAGE_ELF_MACHINE_FR20 37 /* Fujitsu FR20 */ #define IMAGE_ELF_MACHINE_RH32 38 /* TRW RH-32 */ #define IMAGE_ELF_MACHINE_RCE 39 /* Motorola RCE */ #define IMAGE_ELF_MACHINE_ARM 40 /* Advanced RISC Machines ARM */ #define IMAGE_ELF_MACHINE_ALPHA 41 /* Digital Alpha */ #define IMAGE_ELF_MACHINE_SH 42 /* Hitachi SH */ #define IMAGE_ELF_MACHINE_SPARCV9 43 /* SPARC Version 9 */ #define IMAGE_ELF_MACHINE_TRICORE 44 /* Siemens Tricore embedded processor */ #define IMAGE_ELF_MACHINE_ARC 45 /* Argonaut RISC Core, Argonaut Technologies Inc. */ #define IMAGE_ELF_MACHINE_H8_300 46 /* Hitachi H8/300 */ #define IMAGE_ELF_MACHINE_H8_300H 47 /* Hitachi H8/300H */ #define IMAGE_ELF_MACHINE_H8S 48 /* Hitachi H8S */ #define IMAGE_ELF_MACHINE_H8_500 49 /* Hitachi H8/500 */ #define IMAGE_ELF_MACHINE_IA_64 50 /* Intel IA-64 processor architecture */ #define IMAGE_ELF_MACHINE_MIPS_X 51 /* Stanford MIPS-X */ #define IMAGE_ELF_MACHINE_COLDFIRE 52 /* Motorola ColdFire */ #define IMAGE_ELF_MACHINE_68HC12 53 /* Motorola M68HC12 */ #define IMAGE_ELF_MACHINE_MMA 54 /* Fujitsu MMA Multimedia Accelerator */ #define IMAGE_ELF_MACHINE_PCP 55 /* Siemens PCP */ #define IMAGE_ELF_MACHINE_NCPU 56 /* Sony nCPU embedded RISC processor */ #define IMAGE_ELF_MACHINE_NDR1 57 /* Denso NDR1 microprocessor */ #define IMAGE_ELF_MACHINE_STARCORE 58 /* Motorola Star*Core processor */ #define IMAGE_ELF_MACHINE_ME16 59 /* Toyota ME16 processor */ #define IMAGE_ELF_MACHINE_ST100 60 /* STMicroelectronics ST100 processor */ #define IMAGE_ELF_MACHINE_TINYJ 61 /* Advanced Logic Corp. TinyJ embedded processor family */ /* 62-65 are reserved */ #define IMAGE_ELF_MACHINE_FX66 66 /* Siemens FX66 microcontroller */ #define IMAGE_ELF_MACHINE_ST9PLUS 67 /* STMicroelectronics ST9+ 8/16 bit microcontroller */ #define IMAGE_ELF_MACHINE_ST7 68 /* STMicroelectronics ST7 8-bit microcontroller */ #define IMAGE_ELF_MACHINE_68HC16 69 /* Motorola MC68HC16 Microcontroller */ #define IMAGE_ELF_MACHINE_68HC11 70 /* Motorola MC68HC11 Microcontroller */ #define IMAGE_ELF_MACHINE_68HC08 71 /* Motorola MC68HC08 Microcontroller */ #define IMAGE_ELF_MACHINE_68HC05 72 /* Motorola MC68HC05 Microcontroller */ #define IMAGE_ELF_MACHINE_SVX 73 /* Silicon Graphics SVx */ #define IMAGE_ELF_MACHINE_ST19 74 /* STMicroelectronics ST19 8-bit microcontroller */ #define IMAGE_ELF_MACHINE_VAX 75 /* Digital VAX */ #define IMAGE_ELF_MACHINE_CRIS 76 /* Axis Communications 32-bit embedded processor */ #define IMAGE_ELF_MACHINE_JAVELIN 77 /* Infineon Technologies 32-bit embedded processor */ #define IMAGE_ELF_MACHINE_FIREPATH 78 /* Element 14 64-bit DSP Processor */ #define IMAGE_ELF_MACHINE_ZSP 79 /* LSI Logic 16-bit DSP Processor */ #define IMAGE_ELF_MACHINE_MMIX 80 /* Donald Knuth's educational 64-bit processor */ #define IMAGE_ELF_MACHINE_HUANY 81 /* Harvard University machine-independent object files */ #define IMAGE_ELF_MACHINE_PRISM 82 /* SiTera Prism */ #define IMAGE_ELF_MACHINE_AVR 83 /* Atmel AVR 8-bit microcontroller */ #define IMAGE_ELF_MACHINE_FR30 84 /* Fujitsu FR30 */ #define IMAGE_ELF_MACHINE_D10V 85 /* Mitsubishi D10V */ #define IMAGE_ELF_MACHINE_D30V 86 /* Mitsubishi D30V */ #define IMAGE_ELF_MACHINE_V850 87 /* NEC v850 */ #define IMAGE_ELF_MACHINE_M32R 88 /* Mitsubishi M32R */ #define IMAGE_ELF_MACHINE_MN10300 89 /* Matsushita MN10300 */ #define IMAGE_ELF_MACHINE_MN10200 90 /* Matsushita MN10200 */ #define IMAGE_ELF_MACHINE_PJ 91 /* picoJava */ #define IMAGE_ELF_MACHINE_OPENRISC 92 /* OpenRISC 32-bit embedded processor */ /* Elf versions */ #define IMAGE_ELF_VERSION_NONE 0 /* Invalid version */ #define IMAGE_ELF_VERSION_CURRENT 1 /* Current version */ /* Elf identification */ #define IMAGE_ELF_SIZEOF_IDENT 16 #define IMAGE_ELF_IDENT_MAGIC0 0 /* Magic */ #define IMAGE_ELF_IDENT_MAGIC1 1 #define IMAGE_ELF_IDENT_MAGIC2 2 #define IMAGE_ELF_IDENT_MAGIC3 3 #define IMAGE_ELF_IDENT_CLASS 4 /* File class */ #define IMAGE_ELF_IDENT_DATA 5 /* Data encoding */ #define IMAGE_ELF_IDENT_VERSION 6 /* File version */ #define IMAGE_ELF_IDENT_OSABI 7 /* Operating system/ABI identification */ #define IMAGE_ELF_IDENT_ABIVERSION 8 /* ABI version */ #define IMAGE_ELF_IDENT_PAD 9 /* Start of padding bytes */ /* Magic numbers */ #define IMAGE_ELF_MAGIC0 0x7f #define IMAGE_ELF_MAGIC1 'E' #define IMAGE_ELF_MAGIC2 'L' #define IMAGE_ELF_MAGIC3 'F' /* Elf file classes */ #define IMAGE_ELF_CLASS_NONE 0 /* Invalid class */ #define IMAGE_ELF_CLASS_32 1 /* 32-bit object */ #define IMAGE_ELF_CLASS_64 2 /* 64-bit object */ /* Check elf magic */ #define IMAGE_IS_ELF(hdr) ((hdr).Ident[IMAGE_ELF_IDENT_MAGIC0] == IMAGE_ELF_MAGIC0 && \ (hdr).Ident[IMAGE_ELF_IDENT_MAGIC1] == IMAGE_ELF_MAGIC1 && \ (hdr).Ident[IMAGE_ELF_IDENT_MAGIC2] == IMAGE_ELF_MAGIC2 && \ (hdr).Ident[IMAGE_ELF_IDENT_MAGIC3] == IMAGE_ELF_MAGIC3) /* 32-bit Elf header */ typedef struct _IMAGE_ELF32_HEADER { unsigned char Ident[IMAGE_ELF_SIZEOF_IDENT]; /* Identification */ ELF32_HALF Type; /* Object file type */ ELF32_HALF Machine; /* Required architecture */ ELF32_WORD Version; /* Object file version */ ELF32_ADDR Entry; /* Virtual address of entry point */ ELF32_OFF PhOff; /* Program header table offset in file */ ELF32_OFF ShOff; /* Section header offset in file */ ELF32_WORD Flags; /* Processor specific flags - zero for SPARC and x86 */ ELF32_HALF EhSize; /* Elf header size in bytes (this struct) */ ELF32_HALF PhEntSize; /* Size of an entry in the program header table */ ELF32_HALF PhNum; /* Number of entries in the program header table */ ELF32_HALF ShEntSize; /* Size of an entry in the section header table */ ELF32_HALF ShNum; /* Number of entries in the section header table */ ELF32_HALF ShStrNdx; /* Index into the section header table for the entry of the section name string table */ } IMAGE_ELF32_HEADER, *PIMAGE_ELF32_HEADER; /* Special section indexes */ #define IMAGE_ELF_SECTION_INDEX_UNDEF 0 /*#define IMAGE_ELF_SECTION_INDEX_LORESERVE 0xff00 #define IMAGE_ELF_SECTION_INDEX_LOPROC 0xff00 #define IMAGE_ELF_SECTION_INDEX_HIPROC 0xff1f*/ #define IMAGE_ELF_SECTION_INDEX_ABS 0xfff1 #define IMAGE_ELF_SECTION_INDEX_COMMON 0xfff2 /*#define IMAGE_ELF_SECTION_INDEX_HIRESERVE 0xffff*/ /* Section types */ #define IMAGE_ELF_SECTION_TYPE_NULL 0 /* Incactive section header */ #define IMAGE_ELF_SECTION_TYPE_PROGBITS 1 /* Program defined section */ #define IMAGE_ELF_SECTION_TYPE_SYMTAB 2 /* Symbol table (for link editing) */ #define IMAGE_ELF_SECTION_TYPE_STRTAB 3 /* String table */ #define IMAGE_ELF_SECTION_TYPE_RELA 4 /* Relocation table (with explicit addends) */ #define IMAGE_ELF_SECTION_TYPE_HASH 5 /* Symbol hash table */ #define IMAGE_ELF_SECTION_TYPE_DYNAMIC 6 /* Information for dynamic linking */ #define IMAGE_ELF_SECTION_TYPE_NOTE 7 /* Note section ;-) */ #define IMAGE_ELF_SECTION_TYPE_NOBITS 8 /* Occupies no space in the file, otherwise like PROGBITS */ #define IMAGE_ELF_SECTION_TYPE_REL 9 /* Relocation table (without explicit addends) */ #define IMAGE_ELF_SECTION_TYPE_SHLIB 10 /* Reserved, unspecified */ #define IMAGE_ELF_SECTION_TYPE_DYNSYM 11 /* Symbol table (for dynamic linking) */ /*#define IMAGE_ELF_SECTION_TYPE_LOPROC 0x70000000 #define IMAGE_ELF_SECTION_TYPE_HIPROC 0x7fffffff #define IMAGE_ELF_SECTION_TYPE_LOUSER 0x80000000 #define IMAGE_ELF_SECTION_TYPE_HIUSER 0xffffffff*/ /* Section flags/attributes */ #define SHF_WRITE 0x1 /* Section must be writeable */ #define SHF_ALLOC 0x2 /* Section must be loaded/mapped into memory */ #define SHF_EXECINSTR 0x4 /* The section contains executable code */ /*#define SHF_MASKPROC 0xf0000000*/ /* 32-bit Section header entry */ typedef struct _IMAGE_ELF32_SECTION_HEADER { ELF32_WORD Name; /* Name of the section (index into the section header string table) */ ELF32_WORD Type; /* Type of section */ ELF32_WORD Flags; /* Attributes */ ELF32_ADDR Addr; /* Virtual address to load section at */ ELF32_OFF Offset; /* Offset into the file of the section's data */ ELF32_WORD Size; /* Size of the section */ ELF32_WORD Link; /* Section header table index link... */ ELF32_WORD Info; /* Extra information... */ ELF32_WORD AddrAlign; /* Required alignment */ ELF32_WORD EntSize; /* Size of entries in the table */ } IMAGE_ELF32_SECTION_HEADER, *PIMAGE_ELF32_SECTION_HEADER; /* Symbol table indexes */ #define IMAGE_ELF_SYMBOL_INDEX_UNDEF 0 /* Undefined symbol */ /* Symbol binding/types */ #define IMAGE_ELF32_SYMBOL_BIND(Info) ((Info) >> 4) #define IMAGE_ELF32_SYMBOL_TYPE(Info) ((Info) & 0x0f) #define IMAGE_ELF32_SYMBOL_INFO(Bind, Type) (((Bind) << 4) | ((Type) & 0x0f)) #define IMAGE_ELF_SYMBOL_BINDING_LOCAL 0 /* Local ("static") symbol */ #define IMAGE_ELF_SYMBOL_BINDING_GLOBAL 1 /* Global symbol */ #define IMAGE_ELF_SYMBOL_BINDING_WEAK 2 /* Weak symbol... */ /*#define IMAGE_ELF_SYMBOL_BINDING_LOPROC 13 #define IMAGE_ELF_SYMBOL_BINDING_HIPROC 15*/ #define IMAGE_ELF_SYMBOL_TYPE_NOTYPE 0 /* Unspecified symbol type */ #define IMAGE_ELF_SYMBOL_TYPE_OBJECT 1 /* Data object (i.e. an array, variable, ...) */ #define IMAGE_ELF_SYMBOL_TYPE_FUNC 2 /* Function (or other executable code) */ #define IMAGE_ELF_SYMBOL_TYPE_SECTION 3 /* Symbol for relocating (usually has local binding) */ #define IMAGE_ELF_SYMBOL_TYPE_FILE 4 /* Name of the associated source file */ #define IMAGE_ELF_SYMBOL_TYPE_LOPROC 13 #define IMAGE_ELF_SYMBOL_TYPE_HIPROC 15 /* 32-bit Symbol entry */ typedef struct _IMAGE_ELF32_SYMBOL { ELF32_WORD Name; /* Symbol name (index into the symbol string table) */ ELF32_ADDR Value; /* Value of symbol */ ELF32_WORD Size; /* Size of symbol (0 means unknown) */ unsigned char Info; /* Type and binding attributes */ unsigned char Other; /* Unused - 0 */ ELF32_HALF Shndx; /* Section index */ } IMAGE_ELF32_SYMBOL, *PIMAGE_ELF32_SYMBOL; /* Relocation macros */ #define IMAGE_ELF32_RELOC_SYM(Info) ((Info) >> 8) #define IMAGE_ELF32_RELOC_TYPE(Info) ((unsigned char)(Info)) #define IMAGE_ELF32_RELOC_INFO(Sym,Type) (((Sym) << 8) | (unsigned char)(Type)) /* 386 Relocation types */ #define IMAGE_ELF_RELOC_386_NONE 0 /* none */ #define IMAGE_ELF_RELOC_386_32 1 #define IMAGE_ELF_RELOC_386_PC32 2 #define IMAGE_ELF_RELOC_386_GOT32 3 #define IMAGE_ELF_RELOC_386_PLT32 4 #define IMAGE_ELF_RELOC_386_COPY 5 #define IMAGE_ELF_RELOC_386_GLOB_DAT 6 #define IMAGE_ELF_RELOC_386_JMP_SLOT 7 #define IMAGE_ELF_RELOC_386_RELATIVE 8 #define IMAGE_ELF_RELOC_386_GOTOFF 9 #define IMAGE_ELF_RELOC_386_GOTPC 10 /* 386 TLS Relocation types */ #define IMAGE_ELF_RELOC_386_TLS_GD_PLT 12 #define IMAGE_ELF_RELOC_386_TLS_LDM_PLT 13 #define IMAGE_ELF_RELOC_386_TLS_TPOFF 14 #define IMAGE_ELF_RELOC_386_TLS_IE 15 #define IMAGE_ELF_RELOC_386_TLS_GOTIE 16 #define IMAGE_ELF_RELOC_386_TLS_LE 17 #define IMAGE_ELF_RELOC_386_TLS_GD 18 #define IMAGE_ELF_RELOC_386_TLS_LDM 19 #define IMAGE_ELF_RELOC_386_TLS_LDO_32 32 #define IMAGE_ELF_RELOC_386_TLS_DTPMOD32 35 #define IMAGE_ELF_RELOC_386_TLS_DTPOFF32 36 /* 32-bit Relocation entries */ typedef struct _IMAGE_ELF32_RELOC { ELF32_ADDR Offset; /* Section offset/virtual address */ ELF32_WORD Info; /* Symbol table index/relocation type */ } IMAGE_ELF32_RELOC, *PIMAGE_ELF32_RELOC; typedef struct _IMAGE_ELF32_RELOCA { ELF32_ADDR Offset; /* Section offset/virtual address */ ELF32_WORD Info; /* Symbol table index/relocation type */ ELF32_SWORD Addend; /* Addend */ } IMAGE_ELF32_RELOCA, *PIMAGE_ELF32_RELOCA; /* Program header/segment types */ #define IMAGE_ELF_SEGMENT_TYPE_NULL 0 /* Unused array entry */ #define IMAGE_ELF_SEGMENT_TYPE_LOAD 1 /* Loadable segment */ #define IMAGE_ELF_SEGMENT_TYPE_DYNAMIC 2 /* Dynamic linking info... */ #define IMAGE_ELF_SEGMENT_TYPE_INTERP 3 /* Interpreter */ #define IMAGE_ELF_SEGMENT_TYPE_NOTE 4 /* Note... */ #define IMAGE_ELF_SEGMENT_TYPE_SHLIB 5 /* Reserved but unspecified */ #define IMAGE_ELF_SEGMENT_TYPE_PHDR 6 /* Program header table */ #define IMAGE_ELF_SEGMENT_TYPE_TLS 7 /* Thread local storage */ #define IMAGE_ELF_SEGMENT_TYPE_GNU_EH_FRAME 0x6474e550 /* GCC .eh_frame_hdr segment */ #define IMAGE_ELF_SEGMENT_TYPE_GNU_STACK 0x6474e551 /* Indicates stack executability */ /*#define IMAGE_ELF_SEGMENT_TYPE_LOPROC 0x70000000 #define IMAGE_ELF_SEGMENT_TYPE_HIPROC 0x7fffffff*/ /* Program header/segment flags */ #define IMAGE_ELF_SEGMENT_FLAG_EXEC 0x01 #define IMAGE_ELF_SEGMENT_FLAG_WRITE 0x02 #define IMAGE_ELF_SEGMENT_FLAG_READ 0x04 /*#define IMAGE_ELF_SEGMENT_FLAG_MASKPROC 0xf0000000*/ /* 32-bit Program header entry */ typedef struct _IMAGE_ELF32_PROGRAM_HEADER { ELF32_WORD Type; /* Type of segment */ ELF32_OFF Offset; /* File offset of segment data */ ELF32_ADDR VAddr; /* Virtual address to load segment at */ ELF32_ADDR PAddr; /* Physical address to load segment at */ ELF32_WORD FileSz; /* Size in file of segment */ ELF32_WORD MemSz; /* Size in memory of segment */ ELF32_WORD Flags; /* Flags of segment */ ELF32_WORD Align; /* Required alignment */ } IMAGE_ELF32_PROGRAM_HEADER, *PIMAGE_ELF32_PROGRAM_HEADER; /* Dynamic array tags */ #define IMAGE_ELF_DYNAMIC_TAG_NULL 0 /* End of array */ #define IMAGE_ELF_DYNAMIC_TAG_NEEDED 1 /* Dependency */ #define IMAGE_ELF_DYNAMIC_TAG_PLTRELSZ 2 /* Size in bytes of the relocation entries associated with the plt */ #define IMAGE_ELF_DYNAMIC_TAG_PLTGOT 3 /* Address associated with got/plt */ #define IMAGE_ELF_DYNAMIC_TAG_HASH 4 /* Hash table for symbol table indicated by SYMTAB */ #define IMAGE_ELF_DYNAMIC_TAG_STRTAB 5 /* Address of string table */ #define IMAGE_ELF_DYNAMIC_TAG_SYMTAB 6 /* Address of the symbol table */ #define IMAGE_ELF_DYNAMIC_TAG_RELA 7 /* Address of reloc table with addends */ #define IMAGE_ELF_DYNAMIC_TAG_RELASZ 8 /* Size of reloc table in bytes */ #define IMAGE_ELF_DYNAMIC_TAG_RELAENT 9 /* Size of reloc table entry in bytes? */ #define IMAGE_ELF_DYNAMIC_TAG_STRSZ 10 /* Size of the string table in bytes */ #define IMAGE_ELF_DYNAMIC_TAG_SYMENT 11 /* Size of symbol table entry in bytes */ #define IMAGE_ELF_DYNAMIC_TAG_INIT 12 /* Address of initialization function */ #define IMAGE_ELF_DYNAMIC_TAG_FINI 13 /* Address of termination function */ #define IMAGE_ELF_DYNAMIC_TAG_SONAME 14 /* Name of the shared object (string table offset) */ #define IMAGE_ELF_DYNAMIC_TAG_RPATH 15 /* Library search path (string table offset) */ #define IMAGE_ELF_DYNAMIC_TAG_SYMBOLIC 16 /* Alter runtime-linkers symbol resolution... */ #define IMAGE_ELF_DYNAMIC_TAG_REL 17 /* Address of reloc table without addends */ #define IMAGE_ELF_DYNAMIC_TAG_RELSZ 18 /* Size of reloc table in bytes */ #define IMAGE_ELF_DYNAMIC_TAG_RELENT 19 /* Size of reloc table entry in bytes? */ #define IMAGE_ELF_DYNAMIC_TAG_PLTREL 20 /* Type of relocation entry for plt (...TAG_REL or ...TAG_RELA) */ #define IMAGE_ELF_DYNAMIC_TAG_DEBUG 21 /* Used for debugging */ #define IMAGE_ELF_DYNAMIC_TAG_TEXTREL 22 /* If present informs the linker that a relocation might update a non-writable segment */ #define IMAGE_ELF_DYNAMIC_TAG_JMPREL 23 /* Address of relocation entries associated solely with the plt */ #define IMAGE_ELF_DYNAMIC_TAG_FILTER 24 /* Specifies the name of a shared objects for which this one acts as a filter */ #define IMAGE_ELF_DYNAMIC_TAG_RUNPATH 29 /* String table offset of a null-terminated library search path string. */ #define IMAGE_ELF_DYNAMIC_TAG_FLAGS 30 /* Object specific flag values. */ /* Dynamic flags (for IMAGE_ELF_DYNAMIC_TAG_FLAGS) */ #define IMAGE_ELF_DYNAMIC_FLAG_ORIGIN 0x0001 /* Indicates that the object being loaded may make reference to the $ORIGIN substitution string.*/ #define IMAGE_ELF_DYNAMIC_FLAG_SYMBOLIC 0x0002 /* Indicates "symbolic" linking. */ #define IMAGE_ELF_DYNAMIC_FLAG_TEXTREL 0x0004 /* Indicates there may be relocations in non-writable segments. */ #define IMAGE_ELF_DYNAMIC_FLAG_BIND_NOW 0x0008 /* Indicates that the dynamic linker should process all relocations for the object containing this entry before transferring control to the program. */ #define IMAGE_ELF_DYNAMIC_FLAG_STATIC_TLS 0x0010 /* Indicates that the shared object or executable contains code using a static thread-local storage scheme. */ /* Dynamic array entry */ typedef struct _IMAGE_ELF32_DYNAMIC { ELF32_SWORD Tag; union { ELF32_WORD Val; ELF32_ADDR Ptr; } Un; } IMAGE_ELF32_DYNAMIC, *PIMAGE_ELF32_DYNAMIC; /* Auxiliary types */ #define IMAGE_ELF_AUX_TYPE_NULL 0 /* Terminates the vector. */ #define IMAGE_ELF_AUX_TYPE_IGNORE 1 /* Ignored entry. */ #define IMAGE_ELF_AUX_TYPE_EXECFD 2 /* File descriptor of program to load. */ #define IMAGE_ELF_AUX_TYPE_PHDR 3 /* Program header of program already loaded. */ #define IMAGE_ELF_AUX_TYPE_PHENT 4 /* Size of each program header entry. */ #define IMAGE_ELF_AUX_TYPE_PHNUM 5 /* Number of program header entries. */ #define IMAGE_ELF_AUX_TYPE_PAGESZ 6 /* Page size in bytes. */ #define IMAGE_ELF_AUX_TYPE_BASE 7 /* Interpreter's base address. */ #define IMAGE_ELF_AUX_TYPE_FLAGS 8 /* Flags (unused for i386). */ #define IMAGE_ELF_AUX_TYPE_ENTRY 9 /* Where interpreter should transfer control. */ /* * The following non-standard values are used for passing information * from John Polstra's testbed program to the dynamic linker. These * are expected to go away soon. * * Unfortunately, these overlap the Linux non-standard values, so they * must not be used in the same context. */ #define IMAGE_ELF_AUX_TYPE_BRK 10 /* Starting point for sbrk and brk. */ #define IMAGE_ELF_AUX_TYPE_DEBUG 11 /* Debugging level. */ /* * The following non-standard values are used in Linux ELF binaries. */ #define IMAGE_ELF_AUX_TYPE_NOTELF 10 /* Program is not ELF ?? */ #define IMAGE_ELF_AUX_TYPE_UID 11 /* Real uid. */ #define IMAGE_ELF_AUX_TYPE_EUID 12 /* Effective uid. */ #define IMAGE_ELF_AUX_TYPE_GID 13 /* Real gid. */ #define IMAGE_ELF_AUX_TYPE_EGID 14 /* Effective gid. */ #define IMAGE_ELF_AUX_TYPE_COUNT 15 /* Count of defined aux entry types. */ /* Auxiliary vector entry on initial stack */ typedef struct _IMAGE_ELF32_AUXINFO { ELF32_SWORD Type; /* Entry type. */ union { ELF32_SWORD Val; /* Integer value. */ ELF32_ADDR Ptr; /* Address. */ void (*Fcn)(void); /* Function pointer (not used). */ } Un; } IMAGE_ELF32_AUXINFO, *PIMAGE_ELF32_AUXINFO; /* arch data types */ #if ELF_ARCH_SIZE == 32 #define IMAGE_ELF_SYMBOL_BIND(args...) IMAGE_ELF32_SYMBOL_BIND(args) #define IMAGE_ELF_SYMBOL_TYPE(args...) IMAGE_ELF32_SYMBOL_TYPE(args) #define IMAGE_ELF_SYMBOL_INFO(args...) IMAGE_ELF32_SYMBOL_INFO(args) #define IMAGE_ELF_RELOC_SYM(args...) IMAGE_ELF32_RELOC_SYM(args) #define IMAGE_ELF_RELOC_TYPE(args...) IMAGE_ELF32_RELOC_TYPE(args) #define IMAGE_ELF_RELOC_INFO(args...) IMAGE_ELF32_RELOC_INFO(args) typedef ELF32_ADDR ELF_ADDR; typedef ELF32_HALF ELF_HALF; typedef ELF32_OFF ELF_OFF; typedef ELF32_SWORD ELF_SWORD; typedef ELF32_WORD ELF_WORD; typedef ELF32_HASHELT ELF_HASHELT; typedef IMAGE_ELF32_HEADER IMAGE_ELF_HEADER, *PIMAGE_ELF_HEADER; typedef IMAGE_ELF32_SECTION_HEADER IMAGE_ELF_SECTION_HEADER, *PIMAGE_ELF_SECTION_HEADER; typedef IMAGE_ELF32_SYMBOL IMAGE_ELF_SYMBOL, *PIMAGE_ELF_SYMBOL; typedef IMAGE_ELF32_RELOC IMAGE_ELF_RELOC, *PIMAGE_ELF_RELOC; typedef IMAGE_ELF32_RELOCA IMAGE_ELF_RELOCA, *PIMAGE_ELF_RELOCA; typedef IMAGE_ELF32_PROGRAM_HEADER IMAGE_ELF_PROGRAM_HEADER, *PIMAGE_ELF_PROGRAM_HEADER; typedef IMAGE_ELF32_DYNAMIC IMAGE_ELF_DYNAMIC, *PIMAGE_ELF_DYNAMIC; typedef IMAGE_ELF32_AUXINFO IMAGE_ELF_AUXINFO, *PIMAGE_ELF_AUXINFO; #elif ELF_ARCH_SIZE == 64 # error 64 bits unsupported #else # error Undefined architecture size! #endif /* target macros */ #ifdef _M_IX86 # define IMAGE_ELF_TARGET_CLASS IMAGE_ELF_CLASS_32 # define IMAGE_ELF_TARGET_DATA IMAGE_ELF_DATA_2LSB # define IMAGE_ELF_TARGET_MACHINE IMAGE_ELF_MACHINE_386 # define IMAGE_ELF_TARGET_VERSION 1 #else # error Unsupported architecture! #endif #undef ELF_ARCH_SIZE #endif /* __INCLUDE_ELF_H */ Index: ntoskrnl/mm/section.c =================================================================== RCS file: /CVS/ReactOS/reactos/ntoskrnl/mm/section.c,v retrieving revision 1.163 diff -u -r1.163 section.c --- ntoskrnl/mm/section.c 28 Sep 2004 20:58:29 -0000 1.163 +++ ntoskrnl/mm/section.c 19 Sep 2004 19:55:31 -0000 @@ -16,7 +16,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -/* $Id: section.c,v 1.163 2004/09/28 20:58:29 gvg Exp $ +/* $Id: section.c,v 1.162 2004/08/28 22:18:24 navaraf Exp $ * * PROJECT: ReactOS kernel * FILE: ntoskrnl/mm/section.c @@ -29,6 +29,8 @@ /* INCLUDES *****************************************************************/ #include <ntoskrnl.h> +#include <elf.h> + #define NDEBUG #include <internal/debug.h> @@ -2506,6 +2508,18 @@ PAGE_EXECUTE_READWRITE, // 15 = WRITABLE, READABLE, EXECUTABLE, SHARED }; +static ULONG ElfProgramHeaderFlagsToProtect[8] = + { + PAGE_NOACCESS, /* 0 = NONE */ + PAGE_EXECUTE, /* 1 = EXECUTABLE */ + PAGE_READWRITE, /* 2 = WRITABLE */ + PAGE_EXECUTE_READWRITE, /* 3 = WRITABLE, EXECUTABLE */ + PAGE_READONLY, /* 4 = READABLE */ + PAGE_EXECUTE_READ, /* 5 = READABLE, EXECUTABLE */ + PAGE_READWRITE, /* 6 = READABLE, WRITABLE */ + PAGE_EXECUTE_READWRITE, /* 7 = READABLE, EXECUTABLE, WRITABLE */ + }; + NTSTATUS MmCreateImageSection(PSECTION_OBJECT *SectionObject, ACCESS_MASK DesiredAccess, @@ -2518,7 +2532,12 @@ PSECTION_OBJECT Section; NTSTATUS Status; PFILE_OBJECT FileObject; - IMAGE_DOS_HEADER DosHeader; + union { + IMAGE_DOS_HEADER DosHeader; +#ifdef _ELF_SUPPORT + IMAGE_ELF_HEADER ElfHeader; +#endif /* _ELF_SUPPORT */ + } FileHeader; IO_STATUS_BLOCK Iosb; LARGE_INTEGER Offset; IMAGE_NT_HEADERS PEHeader; @@ -2560,9 +2579,15 @@ if (!NT_SUCCESS(Status) || FileObject->SectionObjectPointer->ImageSectionObject == NULL) { - PIMAGE_SECTION_HEADER ImageSections; + PIMAGE_SECTION_HEADER ImageSections = NULL; +#ifdef _ELF_SUPPORT + PIMAGE_ELF_PROGRAM_HEADER ElfImagePHeaders = NULL; + BOOL ElfImageDynamic = FALSE; + PCHAR ElfImageInterp = NULL; +#endif + /* - * Read the dos header and check the DOS signature + * Read the DOS/ELF header and check the signature */ Offset.QuadPart = 0; Status = ZwReadFile(FileHandle, @@ -2570,8 +2595,8 @@ NULL, NULL, &Iosb, - &DosHeader, - sizeof(DosHeader), + &FileHeader, + sizeof(FileHeader), &Offset, NULL); if (!NT_SUCCESS(Status)) @@ -2581,78 +2606,357 @@ } /* - * Check the DOS signature + * Check the DOS/ELF signature */ - if (Iosb.Information != sizeof(DosHeader) || - DosHeader.e_magic != IMAGE_DOS_SIGNATURE) + if (Iosb.Information != sizeof(FileHeader) || + (FileHeader.DosHeader.e_magic != IMAGE_DOS_SIGNATURE && +#ifdef _ELF_SUPPORT + !IMAGE_IS_ELF(FileHeader.ElfHeader))) +#else + TRUE)) +#endif { ObDereferenceObject(FileObject); return(STATUS_INVALID_IMAGE_FORMAT); } - /* - * Read the PE header - */ - Offset.QuadPart = DosHeader.e_lfanew; - Status = ZwReadFile(FileHandle, - NULL, - NULL, - NULL, - &Iosb, - &PEHeader, - sizeof(PEHeader), - &Offset, - NULL); - if (!NT_SUCCESS(Status)) + if (FileHeader.DosHeader.e_magic == IMAGE_DOS_SIGNATURE) { - ObDereferenceObject(FileObject); - return(Status); - } - - /* - * Check the signature - */ - if (Iosb.Information != sizeof(PEHeader) || - PEHeader.Signature != IMAGE_NT_SIGNATURE) - { - ObDereferenceObject(FileObject); - return(STATUS_INVALID_IMAGE_FORMAT); - } + /* + * Read the PE header + */ + Offset.QuadPart = FileHeader.DosHeader.e_lfanew; + Status = ZwReadFile(FileHandle, + NULL, + NULL, + NULL, + &Iosb, + &PEHeader, + sizeof(PEHeader), + &Offset, + NULL); + if (!NT_SUCCESS(Status)) + { + ObDereferenceObject(FileObject); + return(Status); + } - /* - * Read in the section headers - */ - Offset.QuadPart = DosHeader.e_lfanew + sizeof(PEHeader); - ImageSections = ExAllocatePool(NonPagedPool, - PEHeader.FileHeader.NumberOfSections * - sizeof(IMAGE_SECTION_HEADER)); - if (ImageSections == NULL) - { - ObDereferenceObject(FileObject); - return(STATUS_NO_MEMORY); - } + /* + * Check the signature + */ + if (Iosb.Information != sizeof(PEHeader) || + PEHeader.Signature != IMAGE_NT_SIGNATURE) + { + ObDereferenceObject(FileObject); + return(STATUS_INVALID_IMAGE_FORMAT); + } - Status = ZwReadFile(FileHandle, - NULL, - NULL, - NULL, - &Iosb, - ImageSections, - PEHeader.FileHeader.NumberOfSections * - sizeof(IMAGE_SECTION_HEADER), - &Offset, - 0); - if (!NT_SUCCESS(Status)) - { - ObDereferenceObject(FileObject); - ExFreePool(ImageSections); - return(Status); + /* + * Read in the section headers + */ + Offset.QuadPart = FileHeader.DosHeader.e_lfanew + sizeof(PEHeader); + ImageSections = ExAllocatePool(NonPagedPool, + PEHeader.FileHeader.NumberOfSections * + sizeof(IMAGE_SECTION_HEADER)); + if (ImageSections == NULL) + { + ObDereferenceObject(FileObject); + return(STATUS_NO_MEMORY); + } + + Status = ZwReadFile(FileHandle, + NULL, + NULL, + NULL, + &Iosb, + ImageSections, + PEHeader.FileHeader.NumberOfSections * + sizeof(IMAGE_SECTION_HEADER), + &Offset, + 0); + if (!NT_SUCCESS(Status)) + { + ObDereferenceObject(FileObject); + ExFreePool(ImageSections); + return(Status); + } + if (Iosb.Information != (PEHeader.FileHeader.NumberOfSections * sizeof(IMAGE_SECTION_HEADER))) + { + ObDereferenceObject(FileObject); + ExFreePool(ImageSections); + return(STATUS_INVALID_IMAGE_FORMAT); + } + NrSegments = PEHeader.FileHeader.NumberOfSections; } - if (Iosb.Information != (PEHeader.FileHeader.NumberOfSections * sizeof(IMAGE_SECTION_HEADER))) + else { - ObDereferenceObject(FileObject); - ExFreePool(ImageSections); - return(STATUS_INVALID_IMAGE_FORMAT); +#ifdef _ELF_SUPPORT + BOOL ElfImageOk = TRUE; + + assert(IMAGE_IS_ELF(FileHeader.ElfHeader)); + + /* + * Check the ELF type, target, ... + */ + if (FileHeader.ElfHeader.Ident[IMAGE_ELF_IDENT_CLASS] != IMAGE_ELF_TARGET_CLASS || + FileHeader.ElfHeader.Ident[IMAGE_ELF_IDENT_DATA] != IMAGE_ELF_TARGET_DATA) + { + DPRINT1("ELF: unsupported file layout\n"); + ElfImageOk = FALSE; + } + else if (FileHeader.ElfHeader.Ident[IMAGE_ELF_IDENT_VERSION] != IMAGE_ELF_VERSION_CURRENT || + FileHeader.ElfHeader.Version != IMAGE_ELF_VERSION_CURRENT) + { + DPRINT1("ELF: unsupported file version\n"); + ElfImageOk = FALSE; + } + else if (FileHeader.ElfHeader.Type != IMAGE_ELF_TYPE_EXEC && + FileHeader.ElfHeader.Type != IMAGE_ELF_TYPE_DYN) + { + DPRINT1("ELF: unsupported file type\n"); + ElfImageOk = FALSE; + } + else if (FileHeader.ElfHeader.Machine != IMAGE_ELF_TARGET_MACHINE) + { + DPRINT1("ELF: unsupported machine\n"); + ElfImageOk = FALSE; + } + else if (FileHeader.ElfHeader.PhEntSize != sizeof(IMAGE_ELF_PROGRAM_HEADER)) + { + DPRINT1("ELF: invalid object: ElfHeader.PhEntSize != sizeof(IMAGE_ELF_PROGRAM_HEADER)\n"); + ElfImageOk = FALSE; + } + else if (FileHeader.ElfHeader.PhOff == 0) + { + DPRINT1("ELF: file does not contain a program header table (PhOff == 0)\n"); + ElfImageOk = FALSE; + } + else if (FileHeader.ElfHeader.PhNum == 0) + { + DPRINT1("ELF: file does not contain a program header table (PhNum == 0)\n"); + ElfImageOk = FALSE; + } + + if (!ElfImageOk) + { + ObDereferenceObject(FileObject); + return(STATUS_INVALID_IMAGE_FORMAT); + } + + /* + * Read in the program header table + */ + Offset.QuadPart = FileHeader.ElfHeader.PhOff; + ElfImagePHeaders = ExAllocatePool(NonPagedPool, + FileHeader.ElfHeader.PhNum * + sizeof(IMAGE_ELF_PROGRAM_HEADER)); + if (ElfImagePHeaders == NULL) + { + ObDereferenceObject(FileObject); + return(STATUS_NO_MEMORY); + } + + Status = ZwReadFile(FileHandle, + NULL, + NULL, + NULL, + &Iosb, + ElfImagePHeaders, + FileHeader.ElfHeader.PhNum * + sizeof(IMAGE_ELF_PROGRAM_HEADER), + &Offset, + 0); + if (!NT_SUCCESS(Status)) + { + ObDereferenceObject(FileObject); + ExFreePool(ElfImagePHeaders); + return(Status); + } + if (Iosb.Information != (FileHeader.ElfHeader.PhNum * sizeof(IMAGE_ELF_PROGRAM_HEADER))) + { + ObDereferenceObject(FileObject); + ExFreePool(ElfImagePHeaders); + return(STATUS_INVALID_IMAGE_FORMAT); + } + + /* + * Get some important program headers (.dynamic, .interp), count number of loadable segments + */ + NrSegments = 0; + for (i = 0; i < FileHeader.ElfHeader.PhNum; i++) + { + switch (ElfImagePHeaders[i].Type) + { + case IMAGE_ELF_SEGMENT_TYPE_NULL: + case IMAGE_ELF_SEGMENT_TYPE_PHDR: + break; + + case IMAGE_ELF_SEGMENT_TYPE_LOAD: + /* Check alignment of segment */ + if (ElfImagePHeaders[i].Align > 1 && ElfImagePHeaders[i].Align < PAGE_SIZE) + { + ObDereferenceObject(FileObject); + ExFreePool(ElfImagePHeaders); + if (ElfImageInterp != NULL) + ExFreePool(ElfImageInterp); + + DPRINT1("ELF: IMAGE_ELF_SEGMENT_TYPE_LOAD Segment %d not page-aligned\n", i); + return(STATUS_INVALID_IMAGE_FORMAT); + } + NrSegments++; + break; + + case IMAGE_ELF_SEGMENT_TYPE_DYNAMIC: /* dynamically linked image */ + ElfImageDynamic = TRUE; + break; + + case IMAGE_ELF_SEGMENT_TYPE_INTERP: + /* Allocate memory for interpreter */ + if (ElfImageInterp != NULL) + { + ObDereferenceObject(FileObject); + ExFreePool(ElfImagePHeaders); + ExFreePool(ElfImageInterp); + DPRINT1("ELF: Only one IMAGE_ELF_SEGMENT_TYPE_INTERP segment allowed\n"); + return(STATUS_INVALID_IMAGE_FORMAT); + } + Size = max(ElfImagePHeaders[i].MemSz, ElfImagePHeaders[i].FileSz + 1); + ElfImageInterp = ExAllocatePool(NonPagedPool, Size); + if (ElfImageInterp == NULL) + { + ObDereferenceObject(FileObject); + ExFreePool(ElfImagePHeaders); + return(STATUS_NO_MEMORY); + } + + /* Read interpreter path */ + Offset.QuadPart = ElfImagePHeaders[i].Offset; + Status = ZwReadFile(FileHandle, + NULL, + NULL, + NULL, + &Iosb, + ElfImageInterp, + ElfImagePHeaders[i].FileSz, + &Offset, + 0); + if (!NT_SUCCESS(Status)) + { + ObDereferenceObject(FileObject); + ExFreePool(ElfImagePHeaders); + ExFreePool(ElfImageInterp); + return(Status); + } + if (Iosb.Information != ElfImagePHeaders[i].FileSz) + { + ObDereferenceObject(FileObject); + ExFreePool(ElfImagePHeaders); + ExFreePool(ElfImageInterp); + return(STATUS_INVALID_IMAGE_FORMAT); + } + ElfImageInterp[Size - 1] = '\0'; + break; + +#if 0 + case IMAGE_ELF_SEGMENT_TYPE_GNU_STACK: + ElfImageStackExec = TRUE; /* Stack should be executable */ + break; +#endif + default: /* Unknown/unused type */ + DPRINT1("ELF: Segment %d has unknown type %d\n", i, ElfImagePHeaders[i].Type); + break; + } + } + + if (NrSegments == 0) /* No loadable segments found */ + { + ObDereferenceObject(FileObject); + ExFreePool(ElfImagePHeaders); + if (ElfImageInterp != NULL) + ExFreePool(ElfImageInterp); + DPRINT1("ELF: No loadable segments found!\n"); + return(STATUS_INVALID_IMAGE_FORMAT); + } + + if (ElfImageDynamic) + { + HANDLE hInterpFile; + OBJECT_ATTRIBUTES Attribs; + ANSI_STRING AnsiInterp; + UNICODE_STRING UnicodeInterp; + + if(ElfImageInterp == NULL) + { + ObDereferenceObject(FileObject); + ExFreePool(ElfImagePHeaders); + DPRINT1("ELF: Dynamic image needs interpreter!\n"); + return(STATUS_INVALID_IMAGE_FORMAT); + } + + /* + * Release resources + */ + ObDereferenceObject(FileObject); + ExFreePool(ElfImagePHeaders); + + /* + * The ELF file contains an interpreter, let's try to map it instead... + */ + RtlInitAnsiString(&AnsiInterp, ElfImageInterp); + Status = RtlAnsiStringToUnicodeString(&UnicodeInterp, &AnsiInterp, TRUE); + ExFreePool(ElfImageInterp); + if (!NT_SUCCESS(Status)) + { + DPRINT1("ELF: Couldn't convert interpreter from ansi to unicode!\n"); + return(Status); + } + + InitializeObjectAttributes(&Attribs, + &UnicodeInterp, + (OBJ_CASE_INSENSITIVE | OBJ_INHERIT), /* FIXME: which flags to use? */ + NULL, + NULL); + + Status = ZwCreateFile(&hInterpFile, + GENERIC_READ | GENERIC_EXECUTE, + &Attribs, + &Iosb, + NULL, + FILE_ATTRIBUTE_NORMAL, + FILE_SHARE_READ, + FILE_OPEN, + FILE_NON_DIRECTORY_FILE, + NULL, + 0); + + if (!NT_SUCCESS(Status)) + { + DPRINT1("ELF: Couldn't open interpreter '%wZ'!\n", &UnicodeInterp); + RtlFreeUnicodeString(&UnicodeInterp); + return(Status); + } + RtlFreeUnicodeString(&UnicodeInterp); + + Status = MmCreateImageSection(SectionObject, + DesiredAccess, + NULL, + NULL, + PAGE_EXECUTE | PAGE_WRITECOPY, + SEC_IMAGE, + hInterpFile); + ZwClose(hInterpFile); + if (!NT_SUCCESS(Status)) + { + DPRINT1("ELF: Couldn't create section for interpreter (0x%x)\n", Status); + } + return(Status); /* The interpreter should take care of the rest... */ + } + + NrSegments = FileHeader.ElfHeader.PhNum; + +#else /* _ELF_SUPPORT */ + assert(0); /* should never be executed */ +#endif } /* @@ -2670,7 +2974,14 @@ if (!NT_SUCCESS(Status)) { ObDereferenceObject(FileObject); - ExFreePool(ImageSections); + if (ImageSections != NULL) + ExFreePool(ImageSections); +#ifdef _ELF_SUPPORT + if (ElfImagePHeaders != NULL) + ExFreePool(ElfImagePHeaders); + if (ElfImageInterp != NULL) + ExFreePool(ElfImageInterp); +#endif return(Status); } @@ -2684,8 +2995,8 @@ KeInitializeSpinLock(&Section->ViewListLock); /* - * Check file access required - */ + * Check file access required + */ if (SectionPageProtection & (PAGE_READWRITE|PAGE_EXECUTE_READWRITE)) { FileAccess = FILE_READ_DATA | FILE_WRITE_DATA; @@ -2703,14 +3014,21 @@ { ObDereferenceObject(Section); ObDereferenceObject(FileObject); - ExFreePool(ImageSections); + if (ImageSections != NULL) + ExFreePool(ImageSections); +#ifdef _ELF_SUPPORT + if (ElfImagePHeaders != NULL) + ExFreePool(ElfImagePHeaders); + if (ElfImageInterp != NULL) + ExFreePool(ElfImageInterp); +#endif return(Status); } /* - * allocate the section segments to describe the mapping + * allocate and fill the section segments to describe the mapping */ - NrSegments = PEHeader.FileHeader.NumberOfSections + 1; + NrSegments += 1; /* the first segment is special i guess... */ Size = sizeof(MM_IMAGE_SECTION_OBJECT) + sizeof(MM_SECTION_SEGMENT) * NrSegments; ImageSectionObject = ExAllocatePoolWithTag(NonPagedPool, Size, TAG_MM_SECTION_SEGMENT); if (ImageSectionObject == NULL) @@ -2718,110 +3036,241 @@ KeSetEvent((PVOID)&FileObject->Lock, IO_NO_INCREMENT, FALSE); ObDereferenceObject(Section); ObDereferenceObject(FileObject); - ExFreePool(ImageSections); + if (ImageSections != NULL) + ExFreePool(ImageSections); +#ifdef _ELF_SUPPORT + if (ElfImagePHeaders != NULL) + ExFreePool(ElfImagePHeaders); + if (ElfImageInterp != NULL) + ExFreePool(ElfImageInterp); +#endif return(STATUS_NO_MEMORY); } Section->ImageSection = ImageSectionObject; ImageSectionObject->NrSegments = NrSegments; - ImageSectionObject->ImageBase = (PVOID)PEHeader.OptionalHeader.ImageBase; - ImageSectionObject->EntryPoint = (PVOID)PEHeader.OptionalHeader.AddressOfEntryPoint; - ImageSectionObject->StackReserve = PEHeader.OptionalHeader.SizeOfStackReserve; - ImageSectionObject->StackCommit = PEHeader.OptionalHeader.SizeOfStackCommit; - ImageSectionObject->Subsystem = PEHeader.OptionalHeader.Subsystem; - ImageSectionObject->MinorSubsystemVersion = PEHeader.OptionalHeader.MinorSubsystemVersion; - ImageSectionObject->MajorSubsystemVersion = PEHeader.OptionalHeader.MajorSubsystemVersion; - ImageSectionObject->ImageCharacteristics = PEHeader.FileHeader.Characteristics; - ImageSectionObject->Machine = PEHeader.FileHeader.Machine; - ImageSectionObject->Executable = (PEHeader.OptionalHeader.SizeOfCode != 0); - SectionSegments = ImageSectionObject->Segments; - SectionSegments[0].FileOffset = 0; - SectionSegments[0].Characteristics = IMAGE_SECTION_CHAR_DATA; - SectionSegments[0].Protection = PAGE_READONLY; - SectionSegments[0].RawLength = PAGE_SIZE; - SectionSegments[0].Length = PAGE_SIZE; - SectionSegments[0].Flags = 0; - SectionSegments[0].ReferenceCount = 1; - SectionSegments[0].VirtualAddress = 0; - SectionSegments[0].WriteCopy = TRUE; - SectionSegments[0].Attributes = 0; - ExInitializeFastMutex(&SectionSegments[0].Lock); - RtlZeroMemory(&SectionSegments[0].PageDirectory, sizeof(SECTION_PAGE_DIRECTORY)); - for (i = 1; i < NrSegments; i++) - { - SectionSegments[i].FileOffset = ImageSections[i-1].PointerToRawData; - SectionSegments[i].Characteristics = ImageSections[i-1].Characteristics; - /* - * Set up the protection and write copy variables. - */ - Characteristics = ImageSections[i - 1].Characteristics; - if (Characteristics & (IMAGE_SECTION_CHAR_READABLE|IMAGE_SECTION_CHAR_WRITABLE|IMAGE_SECTION_CHAR_EXECUTABLE)) - { - SectionSegments[i].Protection = SectionCharacteristicsToProtect[Characteristics >> 28]; - SectionSegments[i].WriteCopy = !(Characteristics & IMAGE_SECTION_CHAR_SHARED); - } - else if (Characteristics & IMAGE_SECTION_CHAR_CODE) - { - SectionSegments[i].Protection = PAGE_EXECUTE_READ; - SectionSegments[i].WriteCopy = TRUE; - } - else if (Characteristics & IMAGE_SECTION_CHAR_DATA) - { - SectionSegments[i].Protection = PAGE_READWRITE; - SectionSegments[i].WriteCopy = TRUE; - } - else if (Characteristics & IMAGE_SECTION_CHAR_BSS) - { - SectionSegments[i].Protection = PAGE_READWRITE; - SectionSegments[i].WriteCopy = TRUE; - } - else + if (FileHeader.DosHeader.e_magic == IMAGE_DOS_SIGNATURE) + { + ImageSectionObject->ImageBase = (PVOID)PEHeader.OptionalHeader.ImageBase; + ImageSectionObject->EntryPoint = (PVOID)PEHeader.OptionalHeader.AddressOfEntryPoint; + ImageSectionObject->StackReserve = PEHeader.OptionalHeader.SizeOfStackReserve; + ImageSectionObject->StackCommit = PEHeader.OptionalHeader.SizeOfStackCommit; + ImageSectionObject->Subsystem = PEHeader.OptionalHeader.Subsystem; + ImageSectionObject->MinorSubsystemVersion = PEHeader.OptionalHeader.MinorSubsystemVersion; + ImageSectionObject->MajorSubsystemVersion = PEHeader.OptionalHeader.MajorSubsystemVersion; + ImageSectionObject->ImageCharacteristics = PEHeader.FileHeader.Characteristics; + ImageSectionObject->Machine = PEHeader.FileHeader.Machine; + ImageSectionObject->Executable = (PEHeader.OptionalHeader.SizeOfCode != 0); + + SectionSegments[0].FileOffset = 0; + SectionSegments[0].Characteristics = IMAGE_SECTION_CHAR_DATA; + SectionSegments[0].Protection = PAGE_READONLY; + SectionSegments[0].RawLength = PAGE_SIZE; + SectionSegments[0].Length = PAGE_SIZE; + SectionSegments[0].Flags = 0; + SectionSegments[0].ReferenceCount = 1; + SectionSegments[0].VirtualAddress = 0; + SectionSegments[0].WriteCopy = TRUE; + SectionSegments[0].Attributes = 0; + ExInitializeFastMutex(&SectionSegments[0].Lock); + RtlZeroMemory(&SectionSegments[0].PageDirectory, sizeof(SECTION_PAGE_DIRECTORY)); + for (i = 1; i < NrSegments; i++) { - SectionSegments[i].Protection = PAGE_NOACCESS; - SectionSegments[i].WriteCopy = TRUE; - } + SectionSegments[i].FileOffset = ImageSections[i-1].PointerToRawData; + SectionSegments[i].Characteristics = ImageSections[i-1].Characteristics; - /* - * Set up the attributes. - */ - if (Characteristics & IMAGE_SECTION_CHAR_CODE) - { - SectionSegments[i].Attributes = 0; + /* + * Set up the protection and write copy variables. + */ + Characteristics = ImageSections[i - 1].Characteristics; + if (Characteristics & (IMAGE_SECTION_CHAR_READABLE|IMAGE_SECTION_CHAR_WRITABLE|IMAGE_SECTION_CHAR_EXECUTABLE)) + { + SectionSegments[i].Protection = SectionCharacteristicsToProtect[Characteristics >> 28]; + SectionSegments[i].WriteCopy = !(Characteristics & IMAGE_SECTION_CHAR_SHARED); + } + else if (Characteristics & IMAGE_SECTION_CHAR_CODE) + { + SectionSegments[i].Protection = PAGE_EXECUTE_READ; + SectionSegments[i].WriteCopy = TRUE; + } + else if (Characteristics & IMAGE_SECTION_CHAR_DATA) + { + SectionSegments[i].Protection = PAGE_READWRITE; + SectionSegments[i].WriteCopy = TRUE; + } + else if (Characteristics & IMAGE_SECTION_CHAR_BSS) + { + SectionSegments[i].Protection = PAGE_READWRITE; + SectionSegments[i].WriteCopy = TRUE; + } + else + { + SectionSegments[i].Protection = PAGE_NOACCESS; + SectionSegments[i].WriteCopy = TRUE; + } + + /* + * Set up the attributes. + */ + if (Characteristics & IMAGE_SECTION_CHAR_CODE) + { + SectionSegments[i].Attributes = 0; + } + else if (Characteristics & IMAGE_SECTION_CHAR_DATA) + { + SectionSegments[i].Attributes = 0; + } + else if (Characteristics & IMAGE_SECTION_CHAR_BSS) + { + SectionSegments[i].Attributes = MM_SECTION_SEGMENT_BSS; + } + else + { + SectionSegments[i].Attributes = 0; + } + + SectionSegments[i].RawLength = ImageSections[i-1].SizeOfRawData; + if (ImageSections[i-1].Misc.VirtualSize != 0) + { + SectionSegments[i].Length = ImageSections[i-1].Misc.VirtualSize; + } + else + { + SectionSegments[i].Length = ImageSections[i-1].SizeOfRawData; + } + SectionSegments[i].Flags = 0; + SectionSegments[i].ReferenceCount = 1; + SectionSegments[i].VirtualAddress = (PVOID)ImageSections[i-1].VirtualAddress; + ExInitializeFastMutex(&SectionSegments[i].Lock); + RtlZeroMemory(&SectionSegments[i].PageDirectory, sizeof(SECTION_PAGE_DIRECTORY)); } - else if (Characteristics & IMAGE_SECTION_CHAR_DATA) + } + else + { +#ifdef _ELF_SUPPORT + ULONG j; + + ImageSectionObject->ImageBase = (PVOID)ElfImagePHeaders[0].VAddr; + ImageSectionObject->EntryPoint = (PVOID)FileHeader.ElfHeader.Entry; + if (FileHeader.ElfHeader.Entry != (ELF_ADDR)NULL) + { + ImageSectionObject->EntryPoint = (PVOID)((UINT_PTR)FileHeader.ElfHeader.Entry - + (UINT_PTR)ImageSectionObject->ImageBase); + } + ImageSectionObject->StackReserve = 0x10000; /* FIXME: does ELF provide such info? */ + ImageSectionObject->StackCommit = 0x1000; /* FIXME: does ELF provide such info? */ + ImageSectionObject->Subsystem = IMAGE_SUBSYSTEM_WINDOWS_CUI; /* FIXME: we need to extend ELF */ + ImageSectionObject->MajorSubsystemVersion = 4; + ImageSectionObject->MinorSubsystemVersion = 0; /* WinNT 4.0 */ + ImageSectionObject->Executable = TRUE; + ImageSectionObject->ImageCharacteristics = IMAGE_FILE_32BIT_MACHINE; + if (FileHeader.ElfHeader.Type == IMAGE_ELF_TYPE_EXEC) { - SectionSegments[i].Attributes = 0; + ImageSectionObject->ImageCharacteristics |= IMAGE_FILE_EXECUTABLE_IMAGE; } - else if (Characteristics & IMAGE_SECTION_CHAR_BSS) + else { - SectionSegments[i].Attributes = MM_SECTION_SEGMENT_BSS; - } + assert(FileHeader.ElfHeader.Type == IMAGE_ELF_TYPE_DYN); + ImageSectionObject->ImageCharacteristics |= IMAGE_FILE_DLL; + } + + if (FileHeader.ElfHeader.Machine == IMAGE_ELF_MACHINE_386) + ImageSectionObject->Machine = IMAGE_FILE_MACHINE_I386; else { - SectionSegments[i].Attributes = 0; + /* + * This should never be reached because we check if + * ElfHeader.Machine is IMAGE_ELF_TARGET_MACHINE above + * and fail if it is not. + */ + assert(0); } - SectionSegments[i].RawLength = ImageSections[i-1].SizeOfRawData; - if (ImageSections[i-1].Misc.VirtualSize != 0) + /* FIXME: what is this first segment used for? */ + SectionSegments[0].FileOffset = 0; + SectionSegments[0].Characteristics = IMAGE_SECTION_CHAR_DATA; + SectionSegments[0].Protection = PAGE_READONLY; + SectionSegments[0].RawLength = PAGE_SIZE; + SectionSegments[0].Length = PAGE_SIZE; + SectionSegments[0].Flags = 0; + SectionSegments[0].ReferenceCount = 1; + SectionSegments[0].VirtualAddress = 0; + SectionSegments[0].WriteCopy = TRUE; + SectionSegments[0].Attributes = 0; + ExInitializeFastMutex(&SectionSegments[0].Lock); + RtlZeroMemory(&SectionSegments[0].PageDirectory, sizeof(SECTION_PAGE_DIRECTORY)); + for (i = 1, j = 0; j < (NrSegments - 1); j++) { - SectionSegments[i].Length = ImageSections[i-1].Misc.VirtualSize; - } - else - { - SectionSegments[i].Length = ImageSections[i-1].SizeOfRawData; - } - SectionSegments[i].Flags = 0; - SectionSegments[i].ReferenceCount = 1; - SectionSegments[i].VirtualAddress = (PVOID)ImageSections[i-1].VirtualAddress; - ExInitializeFastMutex(&SectionSegments[i].Lock); - RtlZeroMemory(&SectionSegments[i].PageDirectory, sizeof(SECTION_PAGE_DIRECTORY)); + if (ElfImagePHeaders[j].Type != IMAGE_ELF_SEGMENT_TYPE_LOAD) + continue; + + SectionSegments[i].FileOffset = ElfImagePHeaders[j].Offset; + + /* + * Fill in characteristics + */ + Characteristics = 0; + if (ElfImagePHeaders[j].Flags & IMAGE_ELF_SEGMENT_FLAG_READ) + Characteristics |= IMAGE_SECTION_CHAR_READABLE; + if (ElfImagePHeaders[j].Flags & IMAGE_ELF_SEGMENT_FLAG_WRITE) + Characteristics |= IMAGE_SECTION_CHAR_WRITABLE; + if (ElfImagePHeaders[j].Flags & IMAGE_ELF_SEGMENT_FLAG_EXEC) + Characteristics |= IMAGE_SECTION_CHAR_EXECUTABLE | IMAGE_SECTION_CHAR_CODE; + else /* not executable, must be some kind of data */ + Characteristics |= (ElfImagePHeaders[j].FileSz > 0) ? IMAGE_SECTION_CHAR_DATA : + IMAGE_SECTION_CHAR_BSS; + SectionSegments[i].Characteristics = Characteristics; + + /* + * Set up the protection and write copy variables. + */ + SectionSegments[i].Protection = ElfProgramHeaderFlagsToProtect[ElfImagePHeaders[j].Flags & 7]; + SectionSegments[i].WriteCopy = TRUE; /* ELF does not support shared segments */ + + /* + * Set up the attributes. + */ + if (Characteristics & IMAGE_SECTION_CHAR_CODE) + { + SectionSegments[i].Attributes = 0; + } + else if (Characteristics & IMAGE_SECTION_CHAR_DATA) + { + SectionSegments[i].Attributes = 0; + } + else if (Characteristics & IMAGE_SECTION_CHAR_BSS) + { + SectionSegments[i].Attributes = MM_SECTION_SEGMENT_BSS; + } + else + { + SectionSegments[i].Attributes = 0; + } + + SectionSegments[i].RawLength = ElfImagePHeaders[j].FileSz; + SectionSegments[i].Length = ElfImagePHeaders[j].MemSz; /* FIXME: I hope these are correct */ + + SectionSegments[i].Flags = 0; + SectionSegments[i].ReferenceCount = 1; + SectionSegments[i].VirtualAddress = (PVOID)((UINT_PTR)ElfImagePHeaders[j].VAddr - + (UINT_PTR)ImageSectionObject->ImageBase); + ExInitializeFastMutex(&SectionSegments[i].Lock); + RtlZeroMemory(&SectionSegments[i].PageDirectory, sizeof(SECTION_PAGE_DIRECTORY)); + + i++; + } + ImageSectionObject->NrSegments = i; + +#else /* if !_ELF_SUPPORT */ + assert(0); +#endif /* !_ELF_SUPPORT */ } if (0 != InterlockedCompareExchange((PLONG)&FileObject->SectionObjectPointer->ImageSectionObject, (LONG)ImageSectionObject, 0)) { /* - * An other thread has initialized the some image in the background + * An other thread has initialized the same image in the background */ ExFreePool(ImageSectionObject); ImageSectionObject = FileObject->SectionObjectPointer->ImageSectionObject; @@ -2833,7 +3282,10 @@ InterlockedIncrement((LONG *)&SectionSegments[i].ReferenceCount); } } - ExFreePool(ImageSections); + if (ImageSections != NULL) + ExFreePool(ImageSections); + if (ElfImagePHeaders != NULL) + ExFreePool(ElfImagePHeaders); } else { @@ -3809,7 +4261,7 @@ return(STATUS_UNSUCCESSFUL); } /* Otherwise find a gap to map the image. */ - ImageBase = MmFindGap(AddressSpace, PAGE_ROUND_UP(ImageSize), PAGE_SIZE, FALSE); + ImageBase = MmFindGap(AddressSpace, PAGE_ROUND_UP(ImageSize), FALSE); if (ImageBase == NULL) { MmUnlockAddressSpace(AddressSpace);

9 12

Re: [ros-cvs] CVS Update: reactos
by James Tabor 29 Nov '04

29 Nov '04

Hay!!!! greatlrd(a)cvs.reactos.com wrote: > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: reactos/include/ > Changes by: greatlrd(a)mok.osexperts.com 04/11/28 16:15:24 > > Added files: > reactos/include/: dinput.h > > Log message: > first port of wine directx support to reactos I want to commit my port of msi.dll from wine! 8^) James

2 3

Web site actualization
by Lucio Diaz 28 Nov '04

28 Nov '04

PD: Humm, send me a contact mail and i will send you the files ziped. Best Regards, Lucio Diaz ______________________________________________ Renovamos el Correo Yahoo!: ¡100 MB GRATIS! Nuevos servicios, más seguridad http://correo.yahoo.es

1 0

Web site actualization
by Lucio Diaz 28 Nov '04

28 Nov '04

Could Someone with autorization to edit the Reactos.com Web page look at my FAQ and Howto, to decide if he/she likes it and what have to be changed so it could be in the web page. I think it is a improvement over the actual texts. The texts i did are thought for everybody, even with screenshots to guide the people with little experience. Thankyou, Lucio Diaz. ______________________________________________ Renovamos el Correo Yahoo!: ¡100 MB GRATIS! Nuevos servicios, más seguridad http://correo.yahoo.es

1 0

GMT
by Lucio Diaz 28 Nov '04

28 Nov '04

>While attempting to guess the location isn't going to >be successful >100% >of the time, it would probably be better then the 99% >incorrect that >you >get with always defaulting to 1 set zone. >Also, are there any other user-set preferences that >come before the >date/time page (How do you call the different parts of >Setup?) that >might help determining location? It seems a pain in the @ss to code the whole thing, taking in acount ALL the countries and their probable timezones(countries with diferent timezone areas) for something as easy to the user as to look at his watch and set the time. I dont mind what standard (if GMT -8 or GMT 0) you chose, but i believe that making it more elaborate does not worth today when many other things, quite more important, are waiting to be implemented (like Networking). I am sure that time will come for those details. ______________________________________________ Renovamos el Correo Yahoo!: ¡100 MB GRATIS! Nuevos servicios, más seguridad http://correo.yahoo.es

4 6

Moving ntoskrnl configuration defines into ntoskrnl/include/config.h ?
by Gregor Anich 28 Nov '04

28 Nov '04

Hi! I have written a tool to configure the ReactOS source tree (customize the build) It builds a GUI interface from an XML file which lists all the possible options and how they are "realized" (in which file a value has to be changed to make the build-system do what is wanted, i.e. set KDBG in config to 1) I would like to add the possibility of configuring things like WHOLE_PAGE_ALLOCATIONS or TAG_STATISTICS_TRACKING (from ntoskrnl/mm/npool.c) It would be good if such defines were moved into a file like ntoskrnl/include/config.h which is then included by ntoskrnl.h and looks like this: /* Enable tracking of statistics about the tagged blocks in the pool */ #undef TAG_STATISTICS_TRACKING /* * Put each block in its own range of pages and position the block at the * end of the range so any accesses beyond the end of block are to invalid * memory locations. */ #undef WHOLE_PAGE_ALLOCATIONS I don't want to make the tool edit the C files directly. If anybody is against this please let me know, otherwise I will do it. (Note: The tool is written in python and will thus not be allowed into the reactos tree but I will provide it for whomever is interested) Thanks, blight

4 3

GMT
by Lucio Diaz 28 Nov '04

28 Nov '04

>The most intelligent solution is to stick to GMT 0. >Best regards, >Alex Ionescu I agree, is both the easier and the most logic option (also i live at GMT 0 ;) ______________________________________________ Renovamos el Correo Yahoo!: ¡100 MB GRATIS! Nuevos servicios, más seguridad http://correo.yahoo.es

1 0

Re: [ros-diffs] [CVS reactos] - Saved the state of the fpu at a win32 call and restored the state
by Gregor Anich 28 Nov '04

28 Nov '04

Hi Hartmut! You have changed the w32 callback to save the FPU state, this is wrong I think! I was wondering too wether it should be saved so GvG suggested to check myself and I modified our winhello app... It prints out the FPU control word, calls CreateWindow and printf the FPU control word again. In the callback for the WM_CREATE message (produced by CreateWindow) it also prints the control word, then modifies it (and prints the modified one) This is the output on windows2000: Original FPU control word: 0x8001f WM_CREATE: Original FPU control word: 0x8001f WM_CREATE: Modified FPU control word: 0xa001f FPU control word after CreateWindow: 0xa001f Of course I have attached the program. I am not sure but I think in the KiClearFloatingPointState which you have added you have to set KPCR->NpxThread to NULL if it's CurrentThread before you do the fn/xsave because it could raise a delayed FPU exception (which will be ignored when KPCR->CurrentThread is NULL and be delivered when the saved FPU state is restored for the thread) I think I have made the same mistake in tskswitch.S - I am pretty sure it has to be fixed there because we don't want a FPU exception to be raised while we are in a cli/sti block and switching to another task. - blight

2 4

ReactOS Setup Wizard Scroll Bar for Timezone.
by James Tabor 27 Nov '04

27 Nov '04

Hi all! Missing scroll bars for timezone. FYI, James

6 19

RE: [ros-dev] ReactOS and Viruses
by Waldo Alvarez Cañizares 27 Nov '04

27 Nov '04

Hi Thomas: There are some parts of your e-mail that I can't understand but I believe you try to give some kind of solution. And yes I think is correct at some point, I was wondering once about that, to do the same with native applications as for example what is done with java applets running in the browser. Containing them to some set of files. I think that yes it would be good to prevent applications corrupting other files and such things. And in fact could be great for advanced users But ... 1 - That is not a solution for viruses, there are kernel mode virus and trojans I wonder how that can get there. At the end human intelligence can't be stopped that easy and of course the opposite also happens, ignorance could be huge. I wonder how a virus like the I love you that can be written in a couple of minutes could spread that far. Believe me that won't work. 2 - That should not be enabled by default, sometimes if you present a password to users they will get lost. That happened to some users that switched from win98 to an NT based one. That was news, and was true. With the solution you propose there will be a lot that will press the Yes. Eh I even know ppl that click whatever they please when a message box appears. Regards Waldo ________________________________ De: ros-dev-bounces(a)reactos.com en nombre de Thomas Larsen Enviado el: jue 11/25/2004 12:42 Para: ReactOS Development List Asunto: RE: [ros-dev] ReactOS and Viruses Hi why would it be a could a idea simply becures we eliminate a lot of old viruses but we could allso make a function theire hold all exe files from execute when they contain some strange command f.eks the delete or format funtion or some other stuff or some kind of database and the send a signal out Maybe Reactos->MaybeVirusFile(Filename,Path); VirusApps<-TestingFile(Filename,Path); Ekstra Idea: And a funtion to Stop new apps from run (REGEDIT RUNAPPS etc.) Some New viruses use that way to start all the time and the user could be asked NEW APP STARTING UP RUN THE APP [X] DISMISS THE APP [ ] VIRUS TEST APP [ ] Information about file NEWER SHOW AGAIN [X] And then make a group of apps that run i secure mode FOLDER SECURERUN and then make a group of apps that run i unsecure mode FOLDER UNSECURERUN So those in SECURE can´t change the reg and delete file e.g. don´t know just and idea but think people should care more about getting reactos to work... Thomas >>Hi Rick: >Well I don't believe that would be a protection at all against viruses. Why? >If I where to write a virus and knowing that reactos has such protection that would not stop me at >all. I could simply write a function to calculate the hash in the virus (or simply tell the OS to >do it for me) and update such database. Look at windows file protection, virus laugh at it. I >think the verification of the PE checksum is enough to tell if a file is corrupt and would be >faster >wich means a faster load. If you want to know some more about viruses look for the e-zines of 29A >on the internet to find out more about the subject. Their articles are as advanced as those in Waldo __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev

2 1

CVS Build Bug
by Alex Ionescu 27 Nov '04

27 Nov '04

Hi, CVS seems to be rebuilding rosrtl in a loop...can anyone investigate please? Best regards, Alex Ionescu

4 3

Missing files on bootcd
by WaxDragon 27 Nov '04

27 Nov '04

Please add the following files to the bootcd: lib\dnsapi\dnsapi.dll 1 lib\iphlpapi\iphlpapi.dll 1 lib\rpcrt4\rpcrt4.dll 1 lib\ole32\ole32.dll 1 This fixes the reboot loop FloFri was seeing with current cvs bootcds. (ntuser/desktop.c:499) CreateDesktop: Screen-Saver (NTDLL:ldr/utils.c:2018) Failed to create or open dll section of 'dnsapi.dll' (Status c0000135) (NTDLL:ldr/utils.c:1357) failed to load dnsapi.dll (NTDLL:ldr/utils.c:1819) failed to load dnsapi.dll (NTDLL:ldr/utils.c:2085) LdrFixupImports failed for ws2_32.dll, status=c0000135 (NTDLL:ldr/utils.c:1357) failed to load ws2_32.dll (NTDLL:ldr/utils.c:1819) failed to load ws2_32.dll (NTDLL:ldr/utils.c:2085) LdrFixupImports failed for iphlpapi.dll, status=c0000135 (NTDLL:ldr/utils.c:1357) failed to load iphlpapi.dll (NTDLL:ldr/utils.c:1819) failed to load iphlpapi.dll (NTDLL:ldr/utils.c:2085) LdrFixupImports failed for rpcrt4.dll, status=c0000135 (NTDLL:ldr/utils.c:1357) failed to load rpcrt4.dll (NTDLL:ldr/utils.c:1819) failed to load rpcrt4.dll (NTDLL:ldr/utils.c:2085) LdrFixupImports failed for ole32.dll, status=c0000135 (NTDLL:ldr/utils.c:1357) failed to load ole32.dll (NTDLL:ldr/utils.c:1819) failed to load ole32.dll (NTDLL:ldr/utils.c:1941) LdrFixupImports() failed for setup.exe (NTDLL:ldr/startup.c:441) Failed to initialize image -- The cheese stands alone.

2 1

RE: [ros-diffs] [CVS reactos] Added gethostbyname implementation written by Adam Kelly (insulanus).
by Casper Hornstrup 26 Nov '04

26 Nov '04

This is the wrong way to do it. A Namespace Service Provider should be written for DNS instead. See http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winsock/wi…. DNS is a TCP/IP thing. Other protocols have their own namespace system so ws2_32 should remain generic and not depend on dnsapi. Casper _____ From: ros-diffs-bounces(a)reactos.com [mailto:ros-diffs-bounces@reactos.com] On Behalf Of arty(a)osexperts.com Sent: 26. november 2004 00:33 To: ros-diffs(a)reactos.com Subject: [ros-diffs] [CVS reactos] Added gethostbyname implementation written by Adam Kelly (insulanus). Commit in reactos/lib/ws2_32 on MAIN makefile <> +45 -44 1.18 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/makefile?rev=1.18&…> - <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/makefile.diff?r1=t…> > 1.19 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/makefile?rev=1.19&…> include/ws2_32.h <> +8 1.9 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/include/ws2_32.h?r…> - <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/include/ws2_32.h.d…> > 1.10 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/include/ws2_32.h?r…> misc/dllmain.c <> +11 1.18 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/dllmain.c?rev…> - <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/dllmain.c.dif…> > 1.19 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/dllmain.c?rev…> /event.c <> +6 1.6 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/event.c?rev=1…> - <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/event.c.diff?…> > 1.7 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/event.c?rev=1…> /ns.c <> +1216 -989 1.9 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/ns.c?rev=1.9&…> - <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/ns.c.diff?r1=…> > 1.10 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/ns.c?rev=1.10…> /stubs.c <> +1 -1 1.14 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/stubs.c?rev=1…> - <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/stubs.c.diff?…> > 1.15 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/stubs.c?rev=1…> +1287 -1034 6 modified files Added gethostbyname implementation written by Adam Kelly (insulanus). - Mostly complete, does not support multiple returned a records or hosts file though - Relies on dnsapi - Stores hostent struct in teb->Hostent _____ reactos <http://cvs.reactos.com/cgi-bin/cvsweb/reactos> /lib <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib> /ws2_32 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32> makefile 1.18 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/makefile?rev=1.18&…> - <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/makefile.diff?r1=t…> > 1.19 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/makefile?rev=1.19&…> diff -u -r1.18 -r1.19 --- makefile 17 Nov 2004 05:17:21 -0000 1.18 +++ makefile 25 Nov 2004 23:32:53 -0000 1.19 @@ -1,44 +1,45 @@ -# $Id: makefile,v 1.18 2004/11/17 05:17:21 arty Exp $ - -PATH_TO_TOP = ../.. - -TARGET_REGTESTS = yes - -TARGET_TYPE = dynlink - -TARGET_NAME = ws2_32 - -TARGET_PCH = include/ws2_32.h - -TARGET_BASE = $(TARGET_BASE_LIB_W2_32) - -TARGET_CFLAGS = \ - -I./include \ - -Wall \ - -Werror \ - -fno-builtin \ - -DUNICODE \ - -DLE \ - -D__USE_W32API - -# require os code to explicitly request A/W version of structs/functions -TARGET_CFLAGS += -D_DISABLE_TIDENTS - -TARGET_LFLAGS = -nostartfiles -nostdlib - -TARGET_SDKLIBS = ntdll.a kernel32.a advapi32.a - -TARGET_OBJECTS = \ - misc/bsd.o misc/catalog.o misc/dllmain.o \ - misc/event.o misc/handle.o misc/ns.o \ - misc/sndrcv.o misc/stubs.o misc/upcall.o - -DEP_OBJECTS = $(TARGET_OBJECTS) - -include $(PATH_TO_TOP)/rules.mak - -include $(TOOLS_PATH)/helper.mk - -include $(TOOLS_PATH)/depend.mk - -# EOF +# $Id: makefile,v 1.19 2004/11/25 23:32:53 arty Exp $ + +PATH_TO_TOP = ../.. + +TARGET_REGTESTS = yes + +TARGET_TYPE = dynlink + +TARGET_NAME = ws2_32 + +TARGET_PCH = include/ws2_32.h + +TARGET_BASE = $(TARGET_BASE_LIB_W2_32) + +TARGET_CFLAGS = \ + -I./include \ + -Wall \ + -Werror \ + -fno-builtin \ + -DUNICODE \ + -DLE \ + -D__USE_W32API \ + -D_WIN32_WINNT=0x0500 + +# require os code to explicitly request A/W version of structs/functions +TARGET_CFLAGS += -D_DISABLE_TIDENTS + +TARGET_LFLAGS = -nostartfiles -nostdlib + +TARGET_SDKLIBS = ntdll.a kernel32.a advapi32.a dnsapi.a + +TARGET_OBJECTS = \ + misc/bsd.o misc/catalog.o misc/dllmain.o \ + misc/event.o misc/handle.o misc/ns.o \ + misc/sndrcv.o misc/stubs.o misc/upcall.o + +DEP_OBJECTS = $(TARGET_OBJECTS) + +include $(PATH_TO_TOP)/rules.mak + +include $(TOOLS_PATH)/helper.mk + +include $(TOOLS_PATH)/depend.mk + +# EOF _____ reactos <http://cvs.reactos.com/cgi-bin/cvsweb/reactos> /lib <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib> /ws2_32 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32> /include <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/include> ws2_32.h 1.9 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/include/ws2_32.h?r…> - <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/include/ws2_32.h.d…> > 1.10 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/include/ws2_32.h?r…> diff -u -r1.9 -r1.10 --- ws2_32.h 15 Jul 2004 02:03:06 -0000 1.9 +++ ws2_32.h 25 Nov 2004 23:32:54 -0000 1.10 @@ -7,6 +7,7 @@ #ifndef __WS2_32_H #define __WS2_32_H +#include <roscfg.h> #include <ddk/ntddk.h> #include <ddk/ntifs.h> #include <ntos.h> @@ -17,6 +18,7 @@ #include <windows.h> #undef assert #include <debug.h> +#include <WinDNS.h> // DNS_A_DATA /* Exported by ntdll.dll, but where is the prototype? */ unsigned long strtoul(const char *nptr, char **endptr, int base); @@ -51,6 +53,7 @@ Getservbyname; /* Buffer used by getservbyname */ PWINSOCK_GETSERVBYPORT_CACHE Getservbyport; /* Buffer used by getservbyname */ + struct hostent* Hostent; } WINSOCK_THREAD_BLOCK, *PWINSOCK_THREAD_BLOCK; @@ -60,6 +63,11 @@ #define WSASETINITIALIZED (Initialized = TRUE) +/* ws2_32 internal Functions */ +void check_hostent(struct hostent **he); +void populate_hostent(struct hostent *he, char* name, DNS_A_DATA addr); +void free_hostent(struct hostent *he); +void free_servent(struct servent* s); #ifdef LE _____ reactos <http://cvs.reactos.com/cgi-bin/cvsweb/reactos> /lib <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib> /ws2_32 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32> /misc <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc> dllmain.c 1.18 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/dllmain.c?rev…> - <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/dllmain.c.dif…> > 1.19 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/dllmain.c?rev…> diff -u -r1.18 -r1.19 --- dllmain.c 17 Nov 2004 05:17:22 -0000 1.18 +++ dllmain.c 25 Nov 2004 23:32:54 -0000 1.19 @@ -663,6 +663,16 @@ return FALSE; } +void free_winsock_thread_block(PWINSOCK_THREAD_BLOCK p) { + if(p) { + if(p->Hostent) { free_hostent(p->Hostent); p->Hostent = 0; } + if(p->Getservbyname){} + if(p->Getservbyport) {} + + + } +} + BOOL STDCALL DllMain(HANDLE hInstDll, @@ -708,6 +718,7 @@ return FALSE; } + p->Hostent = NULL; p->LastErrorValue = NO_ERROR; p->Getservbyname = NULL; p->Getservbyport = NULL; _____ reactos <http://cvs.reactos.com/cgi-bin/cvsweb/reactos> /lib <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib> /ws2_32 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32> /misc <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc> event.c 1.6 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/event.c?rev=1…> - <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/event.c.diff?…> > 1.7 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/event.c?rev=1…> diff -u -r1.6 -r1.7 --- event.c 7 Aug 2003 04:03:24 -0000 1.6 +++ event.c 25 Nov 2004 23:32:54 -0000 1.7 @@ -157,6 +157,10 @@ INT Status; INT Errno; + WS_DbgPrint(MID_TRACE,("Called (Socket %x, hEventObject %x, " + "lpNetworkEvents %x)\n", + s, hEventObject, lpNetworkEvents)); + if (!lpNetworkEvents) { WSASetLastError(WSAEINVAL); return SOCKET_ERROR; @@ -180,6 +184,8 @@ if (Status == SOCKET_ERROR) WSASetLastError(Errno); + WS_DbgPrint(MID_TRACE,("Leaving %x\n", Status)); + return Status; } _____ reactos <http://cvs.reactos.com/cgi-bin/cvsweb/reactos> /lib <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib> /ws2_32 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32> /misc <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc> ns.c 1.9 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/ns.c?rev=1.9&…> - <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/ns.c.diff?r1=…> > 1.10 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/ns.c?rev=1.10…> diff -u -r1.9 -r1.10 --- ns.c 15 Jul 2004 02:03:07 -0000 1.9 +++ ns.c 25 Nov 2004 23:32:54 -0000 1.10 @@ -1,989 +1,1216 @@ -/* - * COPYRIGHT: See COPYING in the top level directory - * PROJECT: ReactOS WinSock 2 DLL - * FILE: misc/ns.c - * PURPOSE: Namespace APIs - * PROGRAMMERS: Casper S. Hornstrup (chorns(a)users.sourceforge.net) - * REVISIONS: - * CSH 01/09-2000 Created - */ -#include <ctype.h> -#include <ws2_32.h> - -#ifndef BUFSIZ -#define BUFSIZ 1024 -#endif/*BUFSIZ*/ - -/* Name resolution APIs */ - -/* - * @unimplemented - */ -INT -EXPORT -WSAAddressToStringA( - IN LPSOCKADDR lpsaAddress, - IN DWORD dwAddressLength, - IN LPWSAPROTOCOL_INFOA lpProtocolInfo, - OUT LPSTR lpszAddressString, - IN OUT LPDWORD lpdwAddressStringLength) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSAAddressToStringW( - IN LPSOCKADDR lpsaAddress, - IN DWORD dwAddressLength, - IN LPWSAPROTOCOL_INFOW lpProtocolInfo, - OUT LPWSTR lpszAddressString, - IN OUT LPDWORD lpdwAddressStringLength) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSAEnumNameSpaceProvidersA( - IN OUT LPDWORD lpdwBufferLength, - OUT LPWSANAMESPACE_INFOA lpnspBuffer) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSAEnumNameSpaceProvidersW( - IN OUT LPDWORD lpdwBufferLength, - OUT LPWSANAMESPACE_INFOW lpnspBuffer) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSAGetServiceClassInfoA( - IN LPGUID lpProviderId, - IN LPGUID lpServiceClassId, - IN OUT LPDWORD lpdwBufferLength, - OUT LPWSASERVICECLASSINFOA lpServiceClassInfo) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSAGetServiceClassInfoW( - IN LPGUID lpProviderId, - IN LPGUID lpServiceClassId, - IN OUT LPDWORD lpdwBufferLength, - OUT LPWSASERVICECLASSINFOW lpServiceClassInfo) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSAGetServiceClassNameByClassIdA( - IN LPGUID lpServiceClassId, - OUT LPSTR lpszServiceClassName, - IN OUT LPDWORD lpdwBufferLength) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSAGetServiceClassNameByClassIdW( - IN LPGUID lpServiceClassId, - OUT LPWSTR lpszServiceClassName, - IN OUT LPDWORD lpdwBufferLength) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSAInstallServiceClassA( - IN LPWSASERVICECLASSINFOA lpServiceClassInfo) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSAInstallServiceClassW( - IN LPWSASERVICECLASSINFOW lpServiceClassInfo) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSALookupServiceBeginA( - IN LPWSAQUERYSETA lpqsRestrictions, - IN DWORD dwControlFlags, - OUT LPHANDLE lphLookup) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSALookupServiceBeginW( - IN LPWSAQUERYSETW lpqsRestrictions, - IN DWORD dwControlFlags, - OUT LPHANDLE lphLookup) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSALookupServiceEnd( - IN HANDLE hLookup) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSALookupServiceNextA( - IN HANDLE hLookup, - IN DWORD dwControlFlags, - IN OUT LPDWORD lpdwBufferLength, - OUT LPWSAQUERYSETA lpqsResults) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSALookupServiceNextW( - IN HANDLE hLookup, - IN DWORD dwControlFlags, - IN OUT LPDWORD lpdwBufferLength, - OUT LPWSAQUERYSETW lpqsResults) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSARemoveServiceClass( - IN LPGUID lpServiceClassId) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSASetServiceA( - IN LPWSAQUERYSETA lpqsRegInfo, - IN WSAESETSERVICEOP essOperation, - IN DWORD dwControlFlags) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSASetServiceW( - IN LPWSAQUERYSETW lpqsRegInfo, - IN WSAESETSERVICEOP essOperation, - IN DWORD dwControlFlags) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSAStringToAddressA( - IN LPSTR AddressString, - IN INT AddressFamily, - IN LPWSAPROTOCOL_INFOA lpProtocolInfo, - OUT LPSOCKADDR lpAddress, - IN OUT LPINT lpAddressLength) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * @unimplemented - */ -INT -EXPORT -WSAStringToAddressW( - IN LPWSTR AddressString, - IN INT AddressFamily, - IN LPWSAPROTOCOL_INFOW lpProtocolInfo, - OUT LPSOCKADDR lpAddress, - IN OUT LPINT lpAddressLength) -{ - UNIMPLEMENTED - - return 0; -} - - -/* WinSock 1.1 compatible name resolution APIs */ - -/* - * @unimplemented - */ -LPHOSTENT -EXPORT -gethostbyaddr( - IN CONST CHAR FAR* addr, - IN INT len, - IN INT type) -{ - UNIMPLEMENTED - - return (LPHOSTENT)NULL; -} - -/* - * @unimplemented - */ -LPHOSTENT -EXPORT -gethostbyname( - IN CONST CHAR FAR* name) -{ - UNIMPLEMENTED - - return (LPHOSTENT)NULL; -} - - -/* - * @unimplemented - */ -INT -EXPORT -gethostname( - OUT CHAR FAR* name, - IN INT namelen) -{ - UNIMPLEMENTED - - return 0; -} - - -/* - * XXX arty -- Partial implementation pending a better one. This one will - * do for normal purposes. - * - * Return the address of a static LPPROTOENT corresponding to the named - * protocol. These structs aren't very interesting, so I'm not too ashamed - * to have this function work on builtins for now. - * - * @unimplemented - */ -LPPROTOENT -EXPORT -getprotobyname( - IN CONST CHAR FAR* name) -{ - static CHAR *udp_aliases = 0; - static PROTOENT udp = { "udp", &udp_aliases, 17 }; - static CHAR *tcp_aliases = 0; - static PROTOENT tcp = { "tcp", &tcp_aliases, 6 }; - if( !_stricmp( name, "udp" ) ) { - return &udp; - } else if( !_stricmp( name, "tcp" ) ) { - return &tcp; - } - - return 0; -} - -/* - * @unimplemented - */ -LPPROTOENT -EXPORT -getprotobynumber( - IN INT number) -{ - UNIMPLEMENTED - - return (LPPROTOENT)NULL; -} - -#define SKIPWS(ptr,act) \ -{while(*ptr && isspace(*ptr)) ptr++; if(!*ptr) act;} -#define SKIPANDMARKSTR(ptr,act) \ -{while(*ptr && !isspace(*ptr)) ptr++; \ - if(!*ptr) {act;} else { *ptr = 0; ptr++; }} - - -static BOOL DecodeServEntFromString( IN PCHAR ServiceString, - OUT PCHAR *ServiceName, - OUT PCHAR *PortNumberStr, - OUT PCHAR *ProtocolStr, - IN PCHAR *Aliases, - IN DWORD MaxAlias ) { - UINT NAliases = 0; - - WS_DbgPrint(MAX_TRACE, ("Parsing service ent [%s]\n", ServiceString)); - - SKIPWS(ServiceString, return FALSE); - *ServiceName = ServiceString; - SKIPANDMARKSTR(ServiceString, return FALSE); - SKIPWS(ServiceString, return FALSE); - *PortNumberStr = ServiceString; - SKIPANDMARKSTR(ServiceString, ;); - - while( *ServiceString && NAliases < MaxAlias - 1 ) { - SKIPWS(ServiceString, break); - if( *ServiceString ) { - SKIPANDMARKSTR(ServiceString, ;); - if( strlen(ServiceString) ) { - WS_DbgPrint(MAX_TRACE, ("Alias: %s\n", ServiceString)); - *Aliases++ = ServiceString; - NAliases++; - } - } - } - *Aliases = NULL; - - *ProtocolStr = strchr(*PortNumberStr,'/'); - if( !*ProtocolStr ) return FALSE; - **ProtocolStr = 0; (*ProtocolStr)++; - - WS_DbgPrint(MAX_TRACE, ("Parsing done: %s %s %s %d\n", - *ServiceName, *ProtocolStr, *PortNumberStr, - NAliases)); - - return TRUE; -} - -#define ADJ_PTR(p,b1,b2) p = (p - b1) + b2 - -/* - * @implemented - */ -LPSERVENT -EXPORT -getservbyname( - - IN CONST CHAR FAR* name, - IN CONST CHAR FAR* proto) -{ - BOOL Found = FALSE; - HANDLE ServicesFile; - CHAR ServiceDBData[BUFSIZ] = { 0 }; - PCHAR SystemDirectory = ServiceDBData; /* Reuse this stack space */ - PCHAR ServicesFileLocation = "\\drivers\\etc\\services"; - PCHAR ThisLine = 0, NextLine = 0, ServiceName = 0, PortNumberStr = 0, - ProtocolStr = 0, Comment = 0; - PCHAR Aliases[WS2_INTERNAL_MAX_ALIAS] = { 0 }; - UINT i,SizeNeeded = 0, - SystemDirSize = sizeof(ServiceDBData) - 1; - DWORD ReadSize = 0, ValidData = 0; - PWINSOCK_THREAD_BLOCK p = NtCurrentTeb()->WinSockData; - - if( !p ) { - WSASetLastError( WSANOTINITIALISED ); - return NULL; - } - - if( !name ) { - WSASetLastError( WSANO_RECOVERY ); - return NULL; - } - - if( !GetSystemDirectoryA( SystemDirectory, SystemDirSize ) ) { - WSASetLastError( WSANO_RECOVERY ); - WS_DbgPrint(MIN_TRACE, ("Could not get windows system directory.\n")); - return NULL; /* Can't get system directory */ - } - - strncat( SystemDirectory, ServicesFileLocation, SystemDirSize ); - - ServicesFile = CreateFileA( SystemDirectory, - GENERIC_READ, - FILE_SHARE_READ, - NULL, - OPEN_EXISTING, - FILE_ATTRIBUTE_NORMAL | - FILE_FLAG_SEQUENTIAL_SCAN, - NULL ); - - if( ServicesFile == INVALID_HANDLE_VALUE ) { - WSASetLastError( WSANO_RECOVERY ); - return NULL; - } - - /* Scan the services file ... - * - * We will read up to BUFSIZ bytes per pass, until the buffer does not - * contain a full line, then we will try to read more. - * - * We fall from the loop if the buffer does not have a line terminator. - */ - - /* Initial Read */ - while( !Found && - ReadFile( ServicesFile, ServiceDBData + ValidData, - sizeof( ServiceDBData ) - ValidData, - &ReadSize, NULL ) ) { - ValidData += ReadSize; - ReadSize = 0; - NextLine = ThisLine = ServiceDBData; - - /* Find the beginning of the next line */ - while( NextLine < ServiceDBData + ValidData && - *NextLine != '\r' && *NextLine != '\n' ) NextLine++; - - /* Zero and skip, so we can treat what we have as a string */ - if( NextLine >= ServiceDBData + ValidData ) - break; - - *NextLine = 0; NextLine++; - - Comment = strchr( ThisLine, '#' ); - if( Comment ) *Comment = 0; /* Terminate at comment start */ - - if( DecodeServEntFromString( ThisLine, - &ServiceName, - &PortNumberStr, - &ProtocolStr, - Aliases, - WS2_INTERNAL_MAX_ALIAS ) && - !strcmp( ServiceName, name ) && - (proto ? !strcmp( ProtocolStr, proto ) : TRUE) ) { - - WS_DbgPrint(MAX_TRACE,("Found the service entry.\n")); - Found = TRUE; - SizeNeeded = sizeof(WINSOCK_GETSERVBYNAME_CACHE) + - (NextLine - ThisLine); - break; - } - - /* Get rid of everything we read so far */ - while( NextLine <= ServiceDBData + ValidData && - isspace( *NextLine ) ) NextLine++; - - WS_DbgPrint(MAX_TRACE,("About to move %d chars\n", - ServiceDBData + ValidData - NextLine)); - - memmove( ServiceDBData, NextLine, - ServiceDBData + ValidData - NextLine ); - ValidData -= NextLine - ServiceDBData; - WS_DbgPrint(MAX_TRACE,("Valid bytes: %d\n", ValidData)); - } - - /* This we'll do no matter what */ - CloseHandle( ServicesFile ); - - if( !Found ) { - WS_DbgPrint(MAX_TRACE,("Not found\n")); - WSASetLastError( WSANO_DATA ); - return NULL; - } - - if( !p->Getservbyname || p->Getservbyname->Size < SizeNeeded ) { - /* Free previous getservbyname buffer, allocate bigger */ - if( p->Getservbyname ) - HeapFree(GlobalHeap, 0, p->Getservbyname); - p->Getservbyname = HeapAlloc(GlobalHeap, 0, SizeNeeded); - if( !p->Getservbyname ) { - WS_DbgPrint(MIN_TRACE,("Couldn't allocate %d bytes\n", - SizeNeeded)); - WSASetLastError( WSATRY_AGAIN ); - return NULL; - } - p->Getservbyname->Size = SizeNeeded; - } - - /* Copy the data */ - memmove( p->Getservbyname->Data, - ThisLine, - NextLine - ThisLine ); - - ADJ_PTR(ServiceName,ThisLine,p->Getservbyname->Data); - ADJ_PTR(ProtocolStr,ThisLine,p->Getservbyname->Data); - WS_DbgPrint(MAX_TRACE, - ("ServiceName: %s, Protocol: %s\n", ServiceName, ProtocolStr)); - - for( i = 0; Aliases[i]; i++ ) { - ADJ_PTR(Aliases[i],ThisLine,p->Getservbyname->Data); - WS_DbgPrint(MAX_TRACE,("Aliase %d: %s\n", i, Aliases[i])); - } - - memcpy(p->Getservbyname,Aliases,sizeof(Aliases)); - - /* Create the struct proper */ - p->Getservbyname->ServerEntry.s_name = ServiceName; - p->Getservbyname->ServerEntry.s_aliases = p->Getservbyname->Aliases; - p->Getservbyname->ServerEntry.s_port = htons(atoi(PortNumberStr)); - p->Getservbyname->ServerEntry.s_proto = ProtocolStr; - - return &p->Getservbyname->ServerEntry; -} - - -/* - * @implemented - */ -LPSERVENT -EXPORT -getservbyport( - IN INT port, - IN CONST CHAR FAR* proto) -{ - BOOL Found = FALSE; - HANDLE ServicesFile; - CHAR ServiceDBData[BUFSIZ] = { 0 }; - PCHAR SystemDirectory = ServiceDBData; /* Reuse this stack space */ - PCHAR ServicesFileLocation = "\\drivers\\etc\\services"; - PCHAR ThisLine = 0, NextLine = 0, ServiceName = 0, PortNumberStr = 0, - ProtocolStr = 0, Comment = 0; - PCHAR Aliases[WS2_INTERNAL_MAX_ALIAS] = { 0 }; - UINT i,SizeNeeded = 0, - SystemDirSize = sizeof(ServiceDBData) - 1; - DWORD ReadSize = 0, ValidData = 0; - PWINSOCK_THREAD_BLOCK p = NtCurrentTeb()->WinSockData; - - if( !p ) { - WSASetLastError( WSANOTINITIALISED ); - return NULL; - } - - if ( !port ) { - WSASetLastError( WSANO_RECOVERY ); - return NULL; - } - - if( !GetSystemDirectoryA( SystemDirectory, SystemDirSize ) ) { - WSASetLastError( WSANO_RECOVERY ); - WS_DbgPrint(MIN_TRACE, ("Could not get windows system directory.\n")); - return NULL; /* Can't get system directory */ - } - - strncat( SystemDirectory, ServicesFileLocation, SystemDirSize ); - - ServicesFile = CreateFileA( SystemDirectory, - GENERIC_READ, - FILE_SHARE_READ, - NULL, - OPEN_EXISTING, - FILE_ATTRIBUTE_NORMAL | - FILE_FLAG_SEQUENTIAL_SCAN, - NULL ); - - if( ServicesFile == INVALID_HANDLE_VALUE ) { - WSASetLastError( WSANO_RECOVERY ); - return NULL; - } - - /* Scan the services file ... - * - * We will read up to BUFSIZ bytes per pass, until the buffer does not - * contain a full line, then we will try to read more. - * - * We fall from the loop if the buffer does not have a line terminator. - */ - - /* Initial Read */ - while( !Found && - ReadFile( ServicesFile, ServiceDBData + ValidData, - sizeof( ServiceDBData ) - ValidData, - &ReadSize, NULL ) ) { - ValidData += ReadSize; - ReadSize = 0; - NextLine = ThisLine = ServiceDBData; - - /* Find the beginning of the next line */ - while( NextLine < ServiceDBData + ValidData && - *NextLine != '\r' && *NextLine != '\n' ) NextLine++; - - /* Zero and skip, so we can treat what we have as a string */ - if( NextLine >= ServiceDBData + ValidData ) - break; - - *NextLine = 0; NextLine++; - - Comment = strchr( ThisLine, '#' ); - if( Comment ) *Comment = 0; /* Terminate at comment start */ - - if( DecodeServEntFromString( ThisLine, - &ServiceName, - &PortNumberStr, - &ProtocolStr, - Aliases, - WS2_INTERNAL_MAX_ALIAS ) && - (htons(atoi( PortNumberStr )) == port ) && - (proto ? !strcmp( ProtocolStr, proto ) : TRUE) ) { - - WS_DbgPrint(MAX_TRACE,("Found the port entry.\n")); - - Found = TRUE; - SizeNeeded = sizeof(WINSOCK_GETSERVBYPORT_CACHE) + - (NextLine - ThisLine); - break; - } - - /* Get rid of everything we read so far */ - while( NextLine <= ServiceDBData + ValidData && - isspace( *NextLine ) ) NextLine++; - - WS_DbgPrint(MAX_TRACE,("About to move %d chars\n", - ServiceDBData + ValidData - NextLine)); - - memmove( ServiceDBData, NextLine, - ServiceDBData + ValidData - NextLine ); - ValidData -= NextLine - ServiceDBData; - WS_DbgPrint(MAX_TRACE,("Valid bytes: %d\n", ValidData)); - } - - /* This we'll do no matter what */ - CloseHandle( ServicesFile ); - - if( !Found ) { - WS_DbgPrint(MAX_TRACE,("Not found\n")); - WSASetLastError( WSANO_DATA ); - return NULL; - } - - if( !p->Getservbyport || p->Getservbyport->Size < SizeNeeded ) { - /* Free previous getservbyport buffer, allocate bigger */ - if( p->Getservbyport ) - HeapFree(GlobalHeap, 0, p->Getservbyport); - p->Getservbyport = HeapAlloc(GlobalHeap, 0, SizeNeeded); - if( !p->Getservbyport ) { - WS_DbgPrint(MIN_TRACE,("Couldn't allocate %d bytes\n", - SizeNeeded)); - WSASetLastError( WSATRY_AGAIN ); - return NULL; - } - p->Getservbyport->Size = SizeNeeded; - } - /* Copy the data */ - memmove( p->Getservbyport->Data, - ThisLine, - NextLine - ThisLine ); - - ADJ_PTR(PortNumberStr,ThisLine,p->Getservbyport->Data); - ADJ_PTR(ProtocolStr,ThisLine,p->Getservbyport->Data); - WS_DbgPrint(MAX_TRACE, - ("Port Number: %s, Protocol: %s\n", PortNumberStr, ProtocolStr)); - - for( i = 0; Aliases[i]; i++ ) { - ADJ_PTR(Aliases[i],ThisLine,p->Getservbyport->Data); - WS_DbgPrint(MAX_TRACE,("Aliases %d: %s\n", i, Aliases[i])); - } - - memcpy(p->Getservbyport,Aliases,sizeof(Aliases)); - - /* Create the struct proper */ - p->Getservbyport->ServerEntry.s_name = ServiceName; - p->Getservbyport->ServerEntry.s_aliases = p->Getservbyport->Aliases; - p->Getservbyport->ServerEntry.s_port = port; - p->Getservbyport->ServerEntry.s_proto = ProtocolStr; - - WS_DbgPrint(MID_TRACE,("s_name: %s\n", ServiceName)); - - return &p->Getservbyport->ServerEntry; - -} - - -/* - * @implemented - */ -ULONG -EXPORT -inet_addr( - IN CONST CHAR FAR* cp) -/* - * FUNCTION: Converts a string containing an IPv4 address to an unsigned long - * ARGUMENTS: - * cp = Pointer to string with address to convert - * RETURNS: - * Binary representation of IPv4 address, or INADDR_NONE - */ -{ - UINT i; - PCHAR p; - ULONG u = 0; - - p = (PCHAR)cp; - - if (strlen(p) == 0) - return INADDR_NONE; - - if (strcmp(p, " ") == 0) - return 0; - - for (i = 0; i <= 3; i++) { - u += (strtoul(p, &p, 0) << (i * 8)); - - if (strlen(p) == 0) - return u; - - if (p[0] != '.') - return INADDR_NONE; - - p++; - } - - return u; -} - - -/* - * @implemented - */ -CHAR FAR* -EXPORT -inet_ntoa( - IN IN_ADDR in) -{ - CHAR b[10]; - PCHAR p; - - p = ((PWINSOCK_THREAD_BLOCK)NtCurrentTeb()->WinSockData)->Intoa; - _itoa(in.S_un.S_addr & 0xFF, b, 10); - strcpy(p, b); - _itoa((in.S_un.S_addr >> 8) & 0xFF, b, 10); - strcat(p, "."); - strcat(p, b); - _itoa((in.S_un.S_addr >> 16) & 0xFF, b, 10); - strcat(p, "."); - strcat(p, b); - _itoa((in.S_un.S_addr >> 24) & 0xFF, b, 10); - strcat(p, "."); - strcat(p, b); - return (CHAR FAR*)p; -} - - -/* - * @unimplemented - */ -HANDLE -EXPORT -WSAAsyncGetHostByAddr( - IN HWND hWnd, - IN UINT wMsg, - IN CONST CHAR FAR* addr, - IN INT len, - IN INT type, - OUT CHAR FAR* buf, - IN INT buflen) -{ - UNIMPLEMENTED - - return (HANDLE)0; -} - - -/* - * @unimplemented - */ -HANDLE -EXPORT -WSAAsyncGetHostByName( - IN HWND hWnd, - IN UINT wMsg, - IN CONST CHAR FAR* name, - OUT CHAR FAR* buf, - IN INT buflen) -{ - UNIMPLEMENTED - - return (HANDLE)0; -} - - -/* - * @unimplemented - */ -HANDLE -EXPORT -WSAAsyncGetProtoByName( - IN HWND hWnd, - IN UINT wMsg, - IN CONST CHAR FAR* name, - OUT CHAR FAR* buf, - IN INT buflen) -{ - UNIMPLEMENTED - - return (HANDLE)0; -} - - -/* - * @unimplemented - */ -HANDLE -EXPORT -WSAAsyncGetProtoByNumber( - IN HWND hWnd, - IN UINT wMsg, - IN INT number, - OUT CHAR FAR* buf, - IN INT buflen) -{ - UNIMPLEMENTED - - return (HANDLE)0; -} - - -/* - * @unimplemented - */ -HANDLE -EXPORT -WSAAsyncGetServByName( - IN HWND hWnd, - IN UINT wMsg, - IN CONST CHAR FAR* name, - IN CONST CHAR FAR* proto, - OUT CHAR FAR* buf, - IN INT buflen) -{ - UNIMPLEMENTED - - return (HANDLE)0; -} - - -/* - * @unimplemented - */ -HANDLE -EXPORT -WSAAsyncGetServByPort( - IN HWND hWnd, - IN UINT wMsg, - IN INT port, - IN CONST CHAR FAR* proto, - OUT CHAR FAR* buf, - IN INT buflen) -{ - UNIMPLEMENTED - - return (HANDLE)0; -} - -/* EOF */ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS WinSock 2 DLL + * FILE: misc/ns.c + * PURPOSE: Namespace APIs + * PROGRAMMERS: Casper S. Hornstrup (chorns(a)users.sourceforge.net) + * REVISIONS: [truncated at 1000 lines; 1209 more skipped] _____ reactos <http://cvs.reactos.com/cgi-bin/cvsweb/reactos> /lib <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib> /ws2_32 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32> /misc <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc> stubs.c 1.14 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/stubs.c?rev=1…> - <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/stubs.c.diff?…> > 1.15 <http://cvs.reactos.com/cgi-bin/cvsweb/reactos/lib/ws2_32/misc/stubs.c?rev=1…> diff -u -r1.14 -r1.15 --- stubs.c 17 Nov 2004 05:17:22 -0000 1.14 +++ stubs.c 25 Nov 2004 23:32:54 -0000 1.15 @@ -147,7 +147,7 @@ * @implemented */ INT -EXPORT +EXPORT __stdcall setsockopt( IN SOCKET s, IN INT level, CVSspam <http://www.badgers-in-foil.co.uk/projects/cvsspam/> 0.2.8

3 4

RE: [ros-diffs] [CVS reactos] FPU/SSE state saving on taskswitching, FPU and SSE exception support.
by Hartmut Birr 25 Nov '04

25 Nov '04

Hi Gregor, I've some problems with your changes. On my smp machine I get an assertion from fpu.c line 452. I think, it isn't possible to use KPCR.PrcbData.NpxThread on a smp machine. With your first patch I don't have any problems. - Hartmut

3 6

NTDLL.DLL
by Thomas Larsen 25 Nov '04

25 Nov '04

Hi got a problem i Reactos The Kernel32.Def File LIBERY KERNEL32.DLL EXPORTS NTDLL.RTLALLOCHEAP And all the other def files where HAL.Somefunction NTDLL.Somefunction etc are in I know that NTDLL.DLL IMPORTS "RtlAllocateHeap etc." those funktions from a lib in rtl.lib but don�t know if thats the problem becures SCSIPORT.SYS allso import some HAL.somefunction witch allso are broke The tool DependX86 a tool use to find broke link in files can�t either find them and it a littel strange problem becures i should work microsoft allso do that kind of linking against files and allso use lib files to import Use the most recent CVS of Reactos and the newest edition of MingGW Allso tried differet option and differt compilere versions but seems to me theire must lay a strange problem in reactos og MingGw Simpl don�t support that... Crashlist of Files: Kernel32.dll depend on NTdll.dll User32.dll depend on kernel32.dll Atapi.sys depend on Scsiport.sys depend on HAL.DLL The Subsystem CRSS And Many more Anybody Help Me Please Thomas __________________________________ Do you Yahoo!? The all-new My Yahoo! - What will yours do? http://my.yahoo.com

3 2

RE: [ros-dev] ReactOS and Viruses
by Waldo Alvarez Cañizares 25 Nov '04

25 Nov '04

Hi Rick: Well I don't believe that would be a protection at all against viruses. Why? If I where to write a virus and knowing that reactos has such protection that would not stop me at all. I could simply write a function to calculate the hash in the virus (or simply tell the OS to do it for me) and update such database. Look at windows file protection, virus laugh at it. I think the verification of the PE checksum is enough to tell if a file is corrupt and would be faster wich means a faster load. If you want to know some more about viruses look for the e-zines of 29A on the internet to find out more about the subject. Their articles are as advanced as those in phrack (the latest). I think there is not solution for viruses, users will always do insecure things and viruses will be there waiting for them to do it. Regards Waldo ________________________________ De: ros-dev-bounces(a)reactos.com en nombre de Rick Langschultz Enviado el: Lun 11/22/2004 11:25 p.m. Para: ReactOS Development List Asunto: [ros-dev] ReactOS and Viruses Sun will be releasing Solaris 10 shortly as a commercial product available for purchase. There is a new file system that is 128-bit, and is protected by md5 checksums, I think this is a great idea for reactos. I think before a program executes there should be a binary verifier that checks this checksum and then allows the program to run. This would help in deterring Windows viruses from attaching themselves to reactos binaries. Since ReactOS is open source it will be harder to protect a binary if there is an attack and a malicious user replaces a dll or an exe. Perhaps this can be done using a small xml file or a txt file called md5sums or something. Please let me know what you think.

2 1

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev