Ros-dev October 2004

ros-dev@reactos.org

46 participants
92 discussions

FreeLdr: FsOpenVolume
by Filip Navara 30 Oct '04

30 Oct '04

Hi, since there have been several reports of the ROS CDs failing to boot with the "Invalid partition table magic" message I though if the line 85 in freeldr/fs/fs.c can be the cause. If the CD-ROM drive would get assigned the 0x80 BIOS number (can this everr happen?) then we would end up reading partition table from it and crash later. Any thoughts? Regards, Filip Index: freeldr/fs/fs.c =================================================================== RCS file: /CVS/ReactOS/freeldr/freeldr/fs/fs.c,v retrieving revision 1.14 diff -u -r1.14 fs.c --- freeldr/fs/fs.c 25 May 2004 21:31:27 -0000 1.14 +++ freeldr/fs/fs.c 30 Oct 2004 15:01:41 -0000 @@ -82,7 +82,7 @@ } // Check for ISO9660 file system type - if (DriveNumber > 0x80 && FsRecIsIso9660(DriveNumber)) + if (DriveNumber >= 0x80 && FsRecIsIso9660(DriveNumber)) { DbgPrint((DPRINT_FILESYSTEM, "Drive is a cdrom drive. Assuming ISO-9660 file system.\n"));

2 1

Msi.dll
by James Tabor 30 Oct '04

30 Oct '04

Hi, Is it okay to commit a broken port of wine Msi.dll source to our cvs? 8^P I'm working on avdpack.dll with msiexec.exe. I have bison working with building the port, that was not the problem. It's this; i386-mingw32-gcc -Wl,--base-file,base.tmp \ -Wl,--entry,_DllMain@12 \ -mdll -Wl,--image-base,0x777c0000 \ -o junk.tmp \ version.coff action.o create.o distinct.o handle.o insert.o msi.o msiquery.o order.o package.o record.o regsvr.o select.o string.o suminfo.o table.o tokenize.o update.o where.o sql.tab.o cond.tab.o ../../dk/w32/lib/shell32.a ../../dk/w32/lib/cabinet.a ../../dk/w32/lib/oleaut32.a ../../dk/w32/lib/ole32.a ../../dk/w32/lib/version.a ../../dk/w32/lib/user32.a ../../dk/w32/lib/advapi32.a ../../dk/w32/lib/kernel32.a ../../dk/w32/lib/libwine.a ../../dk/w32/lib/wine_uuid.a ../../dk/w32/lib/ntdll.a Warning: resolving _MsiGetFileVersionW by linking to _MsiGetFileVersionW@20 Use --enable-stdcall-fixup to disable these warnings Use --disable-stdcall-fixup to disable these fixups action.o(.text+0x879e):action.c: undefined reference to `LoadTypeLib@8' action.o(.text+0x8830):action.c: undefined reference to `RegisterTypeLib@12' action.o(.text+0x88c6):action.c: undefined reference to `ITypeLib_Release' suminfo.o(.text+0x3e):suminfo.c: undefined reference to `IPropertyStorage_Release' suminfo.o(.text+0x324):suminfo.c: undefined reference to `IPropertySetStorage_Open' suminfo.o(.text+0x396):suminfo.c: undefined reference to `IPropertyStorage_AddRef' suminfo.o(.text+0x3e9):suminfo.c: undefined reference to `IPropertyStorage_Release' suminfo.o(.text+0x3fd):suminfo.c: undefined reference to `IPropertySetStorage_Release' suminfo.o(.text+0x569):suminfo.c: undefined reference to `IPropertyStorage_ReadMultiple' make: *** [msi.nostrip.dll] Error 1 Thanks, James

3 4

Re: [ros-cvs] CVS Update: reactos
by Aliberti Emanuele 29 Oct '04

29 Oct '04

chorns(a)cvs.reactos.com wrote: >CVSROOT: /CVS/ReactOS >Module name: reactos >Repository: reactos/tools/ >Changes by: chorns(a)mok.osexperts.com 04/10/28 12:02:01 > >Log message: > 2004-10-28 Casper S. Hornstrup <chorns(a)users.sourceforge.net> > > * drivers/net/tcpip/tests/setup.c: Include windows.h. > * lib/gdiplus/tests/setup.c: Ditto. > * lib/kernel32/tests/setup.c: Ditto. > * lib/ws2_32/tests/setup.c: Ditto. > * subsys/win32k/tests/setup.c: Ditto. > * ntoskrnl/tests/setup.c: Ditto. > * ntoskrnl/include/ntoskrnl.h: Include test.h. > * ntoskrnl/mm/virtual.c (NtLockVirtualMemoryInternal): New function. > (NtLockVirtualMemory): Use NtLockVirtualMemoryInternal. > > Should we define a sort of "best practice" in inserting a little "p" after the subsystem prefix and before the proper function's o structure's name, to mark the *p*rivate symbols, or use the "Internal" suffix? 1) NtpLockVirtualMemory (MmpLockVirtualMemory) 2) NtLockVirtualMemoryInternal IMHO, not only an aesthetics problem. Option (1) means that any symbol in ntoskrnl/include have a "p" or "P" in their names. > * ntoskrnl/tests/Makefile (TARGET_CFLAGS): Add -I../include. > * ntoskrnl/tests/stubs.tst: Remove stubs for functions in libgcc. > * regtests/shared/regtests.h: Make independent of windows.h. > * tools/helper.mk (run): Link with libgcc. > * tools/regtests.c (EXESTUB): Include windows.h. > * ntoskrnl/include/internal/test.h: New file. > * ntoskrnl/tests/tests/VirtualMemory.c: Ditto. > > > Emanuele

5 6

FPU saving + V86 problem - not sure how to solve it
by Anich Gregor 28 Oct '04

28 Oct '04

Hi! I have a problem with my FPU state saving changes and v86 mode. In ke/i386/v86m_sup.S are the functions which enter/leave v86 mode... Ki386RetToV86Mode enters v86 mode. It changes CurrentThread->InitialStack and TSS->Esp0 to %esp to make the exception handler run below the used stack and not overwrite it. The exception handler (KeV86GPF) uses a PKV86M_TRAP_FRAME, which contains a KTRAP_FRAME at the beginning and some additional info behind. This additional info is the data on the stack of Ki386RetToV86Mode, since it sets TSS->Esp0 to %esp, the CPU will push the trap-frame below when an exception is raised and the additional info will be after the trap-frame. The problem is that for reserving a FX_SAVE_AREA at the top of the kernel-stack (without changing the KTHREAD->InitialStack value) i changed tskswitch.S to set TSS->Esp0 to NewThread->InitialStack - sizeof(FX_SAVE_AREA), not NewThread->InitialStack. Now if it's switching away and back to a v86 task TSS->Esp0 will be sizeof(FX_SAVE_AREA) less than before, and the V86 exception handler will be unable to find the additional info from Ki386RetToV86Mode's original stack. I am not sure how to solve it. I think it could be done by 1) Adding another variable somewhere (or maybe there is already one somewhere which is meant to be used for this) for the exception-handler stack of the thread, which can then be used by tskswitch.S to update TSS->Esp0. 2) only substract sizeof(FX_SAVE_AREA) from InitalStack for setting up TSS->Esp0 in tskswitch.S if the VM bit of the EFLAGS is not set. Problem is that the CPU unsets the VM bit if using protected-mode exception handlers for v86 tasks, so we would need to get a copy (or pointer to) the eflags pushed by the CPU for the IRQ handler into tskswitch.S (change PsDispatchThread/PsDispatchThreadNoLock prototypes) All this assumes that the FPU would never be used in V86 mode (and I hope that this assumption is correct ;-)) Any suggestions are welcome. - blight

2 1

Re: [ros-cvs] CVS Update: reactos
by Alex Ionescu 27 Oct '04

27 Oct '04

navaraf(a)cvs.reactos.com wrote: >CVSROOT: /CVS/ReactOS >Module name: reactos >Repository: reactos/w32api/include/ddk/ >Changes by: navaraf(a)mok.osexperts.com 04/10/17 06:08:27 > >Modified files: > reactos/include/ddk/: exfuncs.h > reactos/ntoskrnl/ex/: interlck.c list.c > reactos/ntoskrnl/: ntoskrnl.def > reactos/w32api/include/ddk/: winddk.h > >Log message: > - Fix calling convention of ExInterlocked* functions. > >_______________________________________________ >Ros-cvs mailing list >Ros-cvs(a)reactos.com >http://reactos.com/mailman/listinfo/ros-cvs > > > Hi, Please reverse this change. ExInterlocked* functions are FASTCALL, as previously defined. Best regards, Alex Ionescu

2 4

Recommended dev Tools (was Re: INACCESSIBLE_BOOT_DEVICE)
by Enrico Bartky 25 Oct '04

25 Oct '04

Hello, I have searched for the error in the subject but can not find a solution. The daily snapshots (http://reactos.csh-consult.dk/) works fine. I have tried gcc 3.3.1, 3.4.1, 3.4.2. I use the binutils 2.15.91. Is there an error in my build tools? EnricoB

2 2

About tagging memory blocks
by Aliberti Emanuele 25 Oct '04

25 Oct '04

The DDK says ExAllocatePool is obsolete. We sould use ExAllocatePoolWithTag instead. The same applies to other generic pool APIs. Here is a unofficial list of memory pool tags: http://alter.org.ua/docs/win/pooltag/index.php Emanuele

1 0

PDNS_RECORDA
by Carlos Manuel Duclos Vergara 25 Oct '04

25 Oct '04

Hi, now I have some spare time I'm back with gethostbyname and gethostbyaddr (I don't know if they are still needed but according to my last update of my cvs tree they are still unimplemented), I was not able to find the declaration of PDNS_RECORDA. It would be nice to know where can I find it or at least how can I operate with it. My research and guess makes me believe that I should probably deal with DNS_STRUCT, but I think that would be better to have some functionality to avoid messing with the whole structure. Am I totally lost here? bye -- Carlos Manuel Duclos Vergara carlos(a)embedded.cl

1 0

RE: [ros-cvs] CVS Update: reactos
by Casper Hornstrup 25 Oct '04

25 Oct '04

Hmm, generated files in CVS? Also kmregtests/, kmrtint/ and win32base/ is removed in HEAD. > -----Original Message----- > From: ros-cvs-bounces(a)reactos.com > [mailto:ros-cvs-bounces@reactos.com] On Behalf Of ion(a)cvs.reactos.com > Sent: 24. oktober 2004 18:37 > To: ros-cvs(a)reactos.com > Subject: [ros-cvs] CVS Update: reactos > > CVSROOT: /CVS/ReactOS > Module name: reactos > Repository: reactos/regtests/win32base/ > Changes by: ion(a)mok.osexperts.com 04/10/24 18:36:41 > > Added files: > reactos/regtests/: Tag: new_headers Makefile > reactos/regtests/kmregtests/: Tag: new_headers Makefile.tests > _regtests.c kmregtests.map > kmregtests.nostrip.sys > kmregtests.sym kmregtests.sys > reactos/regtests/kmrtint/: Tag: new_headers kmrtint.dll > kmrtint.map kmrtint.nostrip.dll > kmrtint.sym > reactos/regtests/regtests/: Tag: new_headers .cvsignore > Makefile > regtests.c regtests.def > reactos/regtests/shared/: Tag: new_headers .cvsignore Makefile > regtests.c regtests.h > reactos/regtests/win32base/: Tag: new_headers Makefile.tests > _regtests.c win32base.dll > win32base.map > win32base.nostrip.dll > win32base.sym > > Log message: > Final addition, regtests. (These additions are due due > cvs crashing when making the branch and not adding everythign > properly) > > _______________________________________________ > Ros-cvs mailing list > Ros-cvs(a)reactos.com > http://reactos.com/mailman/listinfo/ros-cvs >

2 1

RE: [ros-dev] RE: LinuxWorld Germany
by Theodor Willax 25 Oct '04

25 Oct '04

Sorry I could not translate. I was not online last weekend. Theo >From: "Ge van Geldorp" <gvg(a)reactos.com> >Reply-To: ReactOS Development List <ros-dev(a)reactos.com> >To: "'ReactOS Development List'" <ros-dev(a)reactos.com> >Subject: RE: [ros-dev] RE: LinuxWorld Germany >Date: Sun, 24 Oct 2004 19:57:36 +0200 > > > From: Freeworld > > > > Is the translation done? When has it to be ready? > > If nobody else does it, I could help out. > >Yes, the translation is already done. Thanks to apollo11 for doing it and >thanks to you for your offer. > >Gé van Geldorp. > > >_______________________________________________ >Ros-dev mailing list >Ros-dev(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-dev _________________________________________________________________ Nicht lange suchen finden! MSN Suche. http://search.msn.de/ Jetzt testen!

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev October 2004