Ros-dev January 2005

ros-dev@reactos.org

55 participants
118 discussions

Re: 12775: don't pass vector<pointer> by value unless you are looking for trouble, also fixed Assert() to take stdargs to make it's usage simpler and less error-prone. Also fixed IsTrue(), etc, to take file and line info by args and created macros to pass that info automatically.
by Royce Mitchell III 04 Jan '05

04 Jan '05

royce(a)svn.reactos.com wrote: >don't pass vector<pointer> by value unless you are looking for trouble, also fixed Assert() to take stdargs to make it's usage simpler and less error-prone. Also fixed IsTrue(), etc, to take file and line info by args and created macros to pass that info automatically. > > > Casper, I made some changes to Assert() and the code that calls it, in the hope that this is what you really wanted. I apologize sincerely if you had wanted to do something else with message[], but if you do, I think it would be easier to do so from within Assert(). I will revert that part of this patch if you needed the buffer in Assert()'s callers.

1 0

Re:[ros-svn] [ion] 12748: Fix incorrect LPC Object export...we export pointers not the object itself! Also remove more TIME stuf
by ea＠iol.it 04 Jan '05

04 Jan '05

> Fix incorrect LPC Object export...we export pointers not the object itself! Why? Aren't DATA symbols exported by DLLs pointers? Emanuele ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega. E poi hai l'Adsl senza limiti a meno di 1 euro al giorno. Abbonati subito senza costi di attivazione su http://www.libero.it

6 11

Re: 12739: Add sample build script.
by Martin Fuchs 03 Jan '05

03 Jan '05

Hi, if you want to replace the Makefile build system, please consider using bjam: http://boost.org/tools/build/jam_src/ It has the following advantages: - automatic dependency checking - resolves dependencies in memory without invoking multiple levels of Makefiles - supports nearly every compiler toolset out there, see: http://boost.org/more/getting_started.html#Tools On 02.01.2005 23:17:03 chorns(a)svn.reactos.com wrote: > Add sample build script. > Added files: > branches/xmlbuildsystem/reactos/ReactOS.xml

3 3

Re: [ros-svn] [ion] 12740: Fix my previous patch and fix ACCESS_TOKEN being declared as a structure. This is incompatible with DDK/W32API because ACCESS_TOKEN is a PVOID. The real structure is TOKEN. Also, structure has been updated.
by eric.kohl＠t-online.de 03 Jan '05

03 Jan '05

ion(a)svn.reactos.com wrote: > Fix my previous patch and fix ACCESS_TOKEN being declared as a structure. This is incompatible with DDK/W32API because ACCESS_TOKEN is a PVOID. The real structure is TOKEN. Also, structure has been updated. > I think Microsoft declared PACCESS_TOKEN as a void pointer in order to hide the internals of ACCESS_TOKEN because the average developer does not need to access it or they don't want to reveal more information than needed. Please don't break what's working and revert this patch! We are using our own set of headers because we need to fix crippled declarations and add missing ones. If you want to build ReactOS using the MS SDK and DDK fix them instead of breaking our headers and code. Regards, Eric

3 2

Re: [ros-svn] [ion] 12738: Fix KeRaiseUserException and rename Object Information Structure
by eric.kohl＠t-online.de 03 Jan '05

03 Jan '05

ion(a)svn.reactos.com schrieb: > Fix KeRaiseUserException and rename Object Information Structure Alex, Please explain why you renamed the DIRECTORY_BASIC_INFORMATION structure to OBJECT_DIRECTORY_INFORMATION? All publicly available sources call it DIRECTORY_BASIC_INFORMATION so I think there is no need to rename it. Please revert that modification because you are replacing a well-known structure by an unknown one. Regards, Eric

2 1

Re: [ros-dev] Re:[ros-svn] [ion] 12748: Fix incorrect LPC Object export...we export pointers not the object itself! Also remove
by ea＠iol.it 03 Jan '05

03 Jan '05

> > I think that Alex's changes are correct. If Alex's changes are wrong, > > all other type object initialisations are also wrong. There is only > > one little bug, the EXPORTED/IMPORTED definition is missing. > > Hmm, you might be right... > > POBJECT_TYPE _LpcPortObjectType; /* <- Debug symbols */ > extern NTOSAPI POBJECT_TYPE LpcPortObjectType; /* <- W32API headers */ > > POBJECT_TYPE _IoFileObjectType; /* <- Debug symbols */ > extern POBJECT_TYPE *IoFileObjectType; /* <- Official DDK headers */ > extern NTOSAPI POBJECT_TYPE IoFileObjectType; /* <- W32API headers */ > DATA symbols are pointers to outside referers. When you lookup IoFileObjectType in the .edata section you get the RVA, that is a (sort of) base address of OBJECT_TYPE, i.e. a POBJECT_TYPE. Emanuele ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega. E poi hai l'Adsl senza limiti a meno di 1 euro al giorno. Abbonati subito senza costi di attivazione su http://www.libero.it

1 0

Re: [ros-dev] Re:[ros-svn] [ion] 12748: Fix incorrect LPC Object export...we export pointers not the object itself! Also remove
by ea＠iol.it 03 Jan '05

03 Jan '05

> I think that Alex's changes are correct. If Alex's changes are wrong, > all other type object initialisations are also wrong. There is only one > little bug, the EXPORTED/IMPORTED definition is missing. Imho "all other type object initialisations are also wrong". I made the Ob type descriptor for the LPC Port static and exported its addess, because it makes no sense to me dynamically allocating it (first try was tag-allocating it). Ob type objects live for as long as the executive lives: why are they dynamic? Will we support Ob restarting? Anyway, I did not mean starting a religion war. Emanuele ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega. E poi hai l'Adsl senza limiti a meno di 1 euro al giorno. Abbonati subito senza costi di attivazione su http://www.libero.it

1 0

Re: [ros-svn] [ion] 12738: Fix KeRaiseUserException and rename Object Information Structure
by Hartmut Birr 02 Jan '05

02 Jan '05

ion(a)svn.reactos.com schrieb: >Fix KeRaiseUserException and rename Object Information Structure > > >Updated files: >trunk/reactos/config >trunk/reactos/include/ntos/zwtypes.h >trunk/reactos/ntoskrnl/ke/i386/exp.c >trunk/reactos/ntoskrnl/ob/dirobj.c > >_______________________________________________ > > Hi, this changes does break the compiling of reactos. - Hartmut services: [CC] database.c database.c: In function `ScmCheckDriver': database.c:393: error: `PDIRECTORY_BASIC_INFORMATION' undeclared (first use in this function) database.c:393: error: (Each undeclared identifier is reported only once database.c:393: error: for each function it appears in.) database.c:393: error: syntax error before "DirInfo" database.c:427: error: `DIRECTORY_BASIC_INFORMATION' undeclared (first use in this function) database.c:429: error: `DirInfo' undeclared (first use in this function) _make[1]: *** [database.o] Error 1 _make: *** [services] Error 2

2 1

[Fwd: Re: [ros-dev] We have a web browser] - Test of ActiveX Control NOK
by Gge 02 Jan '05

02 Jan '05

I tested this feature as described in the initial mail ( urlmon+shdocvw dlls are included in the build ) but it fails when I hit the "Web" button with the following debug messages . Any idea about this behavior ? ---------------------------------------------------------------- (shell32_main.c:396:SHGetFileInfoW) set icon to link, stub (shell32_main.c:396:SHGetFileInfoW) set icon to link, stub (compobj.c:1612:CoCreateInstance) no classfactory created for CLSID {8856f961-340a-11d0-a96b-00c04fd705a2}, hres is 0x80040154 (compobj.c:1612:CoCreateInstance) no classfactory created for CLSID {1339b54c-3453-11d2-93b9-000000000000}, hres is 0x80040154 (shell32_main.c:396:SHGetFileInfoW) set icon to link, stub (shell32_main.c:396:SHGetFileInfoW) set icon to link, stub --------------------------------------------------------------- Regards Gerard

1 0

packet manager
by Maarten Bosma 02 Jan '05

02 Jan '05

Hi, Me and some guys on the forum were thinking, about coding a packet manager for ROS. (http://reactos.com/forum/viewtopic.php?t=164) But we would need some kind of script language. We were also thinking about using XML instead of a real lang., but a real one like python would offer much more flexibility. So my question is if you think about the packet manager idea and if you would agree to a lib like python to the tree. Maarten Bosma alias Dr. Fred

4 6

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev January 2005