Currently the resource files in comdlg contain a listbox entry similar
to below:
LISTBOX IDC_SHELLSTATIC,4,20,272,85, LBS_SORT |
LBS_NOINTEGRALHEIGHT | LBS_MULTICOLUMN | WS_HSCROLL | NOT WS_VISIBLE
shouldn't it be
LISTBOX IDC_SHELLSTATIC,4,20,272,85, LBS_SORT |
LBS_NOINTEGRALHEIGHT | LBS_MULTICOLUMN | WS_HSCROLL
the NOT WS_VISIBLE causes windres errors (windres doesn't recognize NOT,
and even if it did, saying NOT WS_VISIBLE instead of just not |
WS_VISIBLE is redundant.), which causes the DLL to fail to build. While
this appears to be merely a goofup, figured i'd ask about it in the list
before i make any changes to the tree in case this is there for a reason.
Richard
royce(a)svn.reactos.com wrote:
> added 'first' attribute to <file>
> Modified: branches/xmlbuildsystem/reactos/ntoskrnl/ntoskrnl.xml
...
> + <file first>multiboot.S</file>
According to the XML spec, all attributes must have a value. [1]
So, the above line must be written like this:
<file first="true">multiboot.S</file>
[1] http://www.w3.org/TR/REC-xml/#NT-Attribute
--
d_layer
That should be:
<file first="yes">multiboot.S</file>
or similar.
Modified: branches/xmlbuildsystem/reactos/ntoskrnl/ntoskrnl.xml
--- branches/xmlbuildsystem/reactos/ntoskrnl/ntoskrnl.xml 2005-01-19 01:11:43 UTC (rev 13128)
+++ branches/xmlbuildsystem/reactos/ntoskrnl/ntoskrnl.xml 2005-01-19 01:37:35 UTC (rev 13129)
@@ -26,10 +26,10 @@
</output>
</invoke>
- <directory name="ke"> <!-- leave this at the top -->
+ <directory name="ke">
<if property="ARCH" value="i386">
<directory name="i386">
- <file>multiboot.S</file> <!-- leave this at the top -->
+ <file first>multiboot.S</file>
<file>bios.c</file>
<file>brkpoint.c</file>
<file>bthread.S</file>
hbirr(a)svn.reactos.com wrote:
>- Set the limit of the user mode code/data segment back to 4GB.
>
>
>
>Updated files:
>trunk/reactos/ntoskrnl/ke/i386/gdt.c
>
>
>
Thanks!
Do you know however if any of ROS Kernel depends on the old GDT? There
are two weird issues with SYSEXIT:
1) GvG reported that FPU is broken
2) Explorer now crashes in shlwapi when clicking on a disk.
Best regards,
Alex Ionescu
> From: hbirr(a)svn.reactos.com
>
> - Fixed the disabling of interrupts on the stack before sysexit.
Only good news left: no more fpu crashes. All your base now belong to
Hartmut!
Gé van Geldorp.
Hi,
Can someone have a look at implementing this? I am having good progress getting IE and Office 2k
going but this function is marked as unimplemented and the installs will hang there. I could try
to stub it out but if someone knows what needs to be implemented I would much rather it be done
right rather than just another stub.
Thanks
Steven
__________________________________
Do you Yahoo!?
Yahoo! Mail - You care about security. So do we.
http://promotions.yahoo.com/new_mail
The good and the bad news continues...
The good news is that Hartmut's change fixed the VMware 4.0.5 problem I had
and also fixes some of the floating point problems. The bad news is that it
doesn't fix all the fpu problems, I still see a usermode crash in rosperf,
always near a fp instruction.
Gé van Geldorp.
anyone know what it would take to add foo.exe.local override support? If this was working IE5/6
could get to the install screen. It tries to use the advpack.dll that it ships with during the
install and of course it fails because it loads ours.
Thanks
Steven
__________________________________
Do you Yahoo!?
Yahoo! Mail - Helps protect you from nasty viruses.
http://promotions.yahoo.com/new_mail
> From: ion(a)svn.reactos.com
>
> Added files:
> trunk/reactos/tools/nci/ncitool.c
I need to add "#include <malloc.h>" to get ncitool.c to compile on Windows.
Adding it doesn't seem to harm Linux compilation.
Gé van Geldorp.