ion(a)svn.reactos.com wrote:
> - Message Queue Fix, resolves a number of application regressions (Total Commander works again, for example). Patch by Hartmut Birr. To be commited into 0.2.7 after more testing.
>
>
>Updated files:
>trunk/reactos/subsys/win32k/ntuser/window.c
>
>
>
Hi,
this fix wasn't for commiting, because it doesn't solve the real
problem. The destroying of the message queues is intitiated by calling
Win32kThreadCallback which calls MsqDestroyMessageQueue. After this
call, it shouldn't exist anymore a window for this thread.
- Hartmut
hbirr(a)svn.reactos.com wrote:
> Lock the handle table if we trying to get a pointer from a handle.
These changes are incorrect. Please revert them.
Actually, a handle lookup requires _no_ locks at all. If you don't
believe me, read up Windows Internals (4th Edition). The algorithms to
allocate subtables are implemented in such a way that it is impossible
to page fault on a lookup. However, it is not allowed to do a lookup in
a table unless attached to the process that owns it (except it is a
global handle table).
Best Regards,
Thomas
Hello all devs, I am running Mozilla-Embedded (same as BartPE) because I can not get the Mozilla Controll to work, usually this is alright, but since some weeks ago Moz-Embedded locks the computer after the shell says "You're embedded man..." and before the mainwindow starts.
It usually took a long time for the mainwindow to start, but it used to work, and I think it takes aproximately the same time for the mouse (and the rest of the system) to lock in r16740.
I do not get any error-messages, someone with debugging skills has to look at this.
Mozilla embedded can be found here:
http://ftp.mozilla.org/pub/mozilla.org/mozilla/releases/mozilla1.6a/mozilla…
Yours sincerely,
Jaix Bly
Hi,
it seems there exist a problem with the message queues. If a process is
terminated (killed) from outside, the thread message queue is deleted
before the last window is deleted. If there is a message (key or mouse)
for this window, the window does access the already freed message queue.
This will crash the system. Possible it is related to the paged pool
memory corruption bug. I've a (dirty) fix for this problem.
- Hartmut
Index: subsys/win32k/ntuser/window.c
===================================================================
--- subsys/win32k/ntuser/window.c (Revision 16707)
+++ subsys/win32k/ntuser/window.c (Arbeitskopie)
@@ -1577,6 +1577,7 @@
IntSetMenu(WindowObject, hMenu, &MenuChanged);
}
WindowObject->MessageQueue = PsGetWin32Thread()->MessageQueue;
+ IntReferenceMessageQueue(WindowObject->MessageQueue);
WindowObject->Parent = (ParentWindow ? ParentWindow->Self : NULL);
if((OwnerWindow = IntGetWindowObject(OwnerWindowHandle)))
{
@@ -2180,7 +2181,7 @@
if (Window->MessageQueue->CaptureWindow == Window->Self)
Window->MessageQueue->CaptureWindow = NULL;
IntUnLockMessageQueue(Window->MessageQueue);
-
+ IntDereferenceMessageQueue(Window->MessageQueue);
/* Call hooks */
#if 0 /* FIXME */
if (HOOK_CallHooks(WH_CBT, HCBT_DESTROYWND, (WPARAM) hwnd, 0, TRUE))
Hey all,
I am hiring an entry level web programmer for the winter and would like to
know what you would suggest to be a good starting salary. We are a small
company that deals with serving users with portal services, such as database
portals, collaboration portals, e-learning portals, web services, and simple
PHP + MySQL websites. What would you want to be paid? Please be reasonable
cause I am going to base someones salary on these statistics.
Also please only respond directly to me, not to this list. No use clogging
it up.
Thanks,
Rick Langschultz
I found that SCM is not started in livecd. This is wrong imho (I use
livecd to debug ROS and I need SCM).
This small patch will fix this.
Index: winlogon.c
===================================================================
--- winlogon.c (revision 16707)
+++ winlogon.c (working copy)
@@ -593,6 +593,8 @@
DbgPrint("WL: Cannot switch to Winlogon desktop (0x%X)\n", GetLastError());
}
+ InitServices();
+
/* Check for pending setup */
if (GetSetupType () != 0)
{
@@ -616,8 +618,6 @@
return 2;
}
- InitServices();
-
#if 0
/* real winlogon uses "Winlogon" */
RtlInitUnicodeString((PUNICODE_STRING)&ProcessName, L"Winlogon");
Agreed. This is a perfect opportunity to bring in the new website.
-----Original Message-----
From: mf [mailto:mf@mufunyo.net]
Sent: 23 July 2005 11:27
To: ros-dev(a)reactos.com
Cc: ros-general(a)reactos.com
Subject: [ros-dev] Re: Reactos.com problems
Ge van Geldorp wrote:
> For the moment, I've moved the mailing lists to a backup box. I am not
> moving the website, since it seems the attack was carried out via the
> website (a vulnerability in one of the php script packages we use).
> I'll put up a dummy page informing visitors.
Am I the only one thinking this is the perfect moment to put up the new
static webpage along with the new design *hint hint* ?
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev
************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
postmaster(a)exideuk.co.uk
<mailto:postmaster@exideuk.co.uk> and then delete this message.
Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com