Ros-dev August 2005

ros-dev@reactos.org

62 participants
118 discussions

Re: [ros-diffs] [weiden] 17542: add stubs for CreateSymbolicLinkA/W

by Joseph Galbraith

weiden(a)svn.reactos.com wrote: > add stubs for CreateSymbolicLinkA/W > > Modified: trunk/reactos/lib/kernel32/file/create.c > Modified: trunk/reactos/lib/kernel32/kernel32.def > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/lib/kernel32/file/create.c* > > --- trunk/reactos/lib/kernel32/file/create.c 2005-08-25 17:38:15 UTC (rev 17541) > +++ trunk/reactos/lib/kernel32/file/create.c 2005-08-25 18:21:50 UTC (rev 17542) > @@ -357,4 +357,51 @@ > > return FileHandle; > } > > > + > +/* > + * @unimplemented > + */ > +BOOL STDCALL > +CreateSymbolicLinkW(IN LPCWSTR lpSymlinkFileName, > + IN LPCWSTR lpTargetFileName, > + IN DWORD dwFlags) > +{ > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return FALSE; > +} > + > + > +/* > + * @implemented > + */ > +BOOL STDCALL > +CreateSymbolicLinkA(IN LPCSTR lpSymlinkFileName, > + IN LPCSTR lpTargetFileName, > + IN DWORD dwFlags) > +{ > + PWCHAR SymlinkW, TargetW; > + BOOL Ret; > + > + if(!lpSymlinkFileName || !lpTargetFileName) > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return FALSE; > + } > + > + if (!(SymlinkW = FilenameA2W(lpSymlinkFileName, FALSE))) > + return FALSE; > + > + if (!(TargetW = FilenameA2W(lpTargetFileName, TRUE))) > + return FALSE; > + > + Ret = CreateSymbolicLinkW(SymlinkW, > + TargetW, > + dwFlags); > + > + RtlFreeHeap(RtlGetProcessHeap(), 0, TargetW); > + > + return Ret; > +} Does this leak SymlinkW ? Thanks, Joseph

20 years

Re: [ros-svn] [royce] 17517: invoke _generate_dsp() have it open the output file, and fix some path parsing and const issues.

by Royce Mitchell III

royce(a)svn.reactos.com wrote: >invoke _generate_dsp() have it open the output file, and fix some path parsing and const issues. > > >Updated files: >trunk/reactos/tools/rbuild/backend/msvc/msvc.cpp >trunk/reactos/tools/rbuild/backend/msvc/msvc.h >trunk/reactos/tools/rbuild/backend/msvc/msvcmaker.cpp > > "make msvc" now creates a DSW file and DSP files such that msvc6 can load them. I seriously doubt anything will build yet, tho.

20 years

Re: [ros-svn] [hbirr] 17538: Fixed a bug in RtlLeaveCriticalSection. We have only to signal the event if someone waits on it.

by Thomas Weidenmueller

hbirr(a)svn.reactos.com wrote: > Fixed a bug in RtlLeaveCriticalSection. We have only to signal the event if someone waits on it. I believe this change is incorrect. This change introduces the exact same bug I fixed in r14326. The reason why this change is incorrect is, that you can't rely on LockCount. It may be incremented anytime a thread enters a critical section and waits for it. That's why there's the RecursionCount field, it is the only information we can rely on to determine whether we're about to release the lock or not. In this code path we already know that we left the last recursion, so no matter what the LockCount is at the moment (depends on how many threads are waiting for the critical section), we always need to unwait one waiter! This change most likely will introduce a dead-lock of cygwin. Best Regards, Thomas

20 years

Re: Re: [ros-dev] reactos.com or reactos.org?

by yash

>major Operating System manufacturer uses .org as their domain suffix. >Microsoft.com, Apple.com, Redhat.com. Given .ORG should be considered ROS is not a manufacturer, not a company, actually ROS community is a part of ReactOS source code and must be located at sourceforge. Will they register "dot sf" as a first level domain?

20 years

Re: [ros-dev] reactos.com or reactos.org?

by yash

My humble point is like this. Once ROS get's to it's first production release, you'll get many commercial offers and may need .com site for doing some commerce, like selling CD's and rotating ads. So many end users will come for download and support. Is it FreeBSD or RedHat way? Turning into monster is no good, but ROS might get huge end (very end) user hit, it is not freebsd and not even linux, it positions as a replacement for windoze itself and windoze means so much commercial and end user.... Yet my personal vision is to have www.reactos.com displaying "Server not found". So you gogo google and type reactos and if you're lucky you get to reactos.org and think "oh dear it is so cool and open source". >I was wondering if, together with the launch of the new website, we should >switch our "primary" domain from reactos.com to reactos.org? We have control >of both domains. An .org domain seems better suited for a open source >project. What do you all think? > >Ge van Geldorp (aka gvg(a)reactos.org :-)) > > >_______________________________________________ >Ros-dev mailing list >Ros-dev(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-dev

20 years

RE: [ros-diffs] [navaraf] 17511: Implement the most over-optimized lockin NT - the NDIS_RW_LOCK.

by Casper Hornstrup

Some constants for the magic numbers would be nice. ________________________________________ From: ros-diffs-bounces(a)reactos.com [mailto:ros-diffs-bounces@reactos.com] On Behalf Of navaraf(a)svn.reactos.com Sent: 24. august 2005 14:21 To: ros-diffs(a)reactos.com Subject: [ros-diffs] [navaraf] 17511: Implement the most over-optimized lockin NT - the NDIS_RW_LOCK. Implement the most over-optimized lock in NT - the NDIS_RW_LOCK. Modified: trunk/reactos/drivers/net/ndis/ndis/control.c Modified: trunk/reactos/drivers/net/ndis/ndis/main.c Modified: trunk/reactos/drivers/net/ndis/ndis/stubs.c +/* + * @implemented + */ +VOID +EXPORT NdisAcquireReadWriteLock( IN PNDIS_RW_LOCK Lock, IN BOOLEAN fWrite, @@ -29,13 +48,88 @@ * NDIS 5.0 */ { - UNIMPLEMENTED + ULONG RefCount; + UCHAR ProcessorNumber; + UCHAR BusyLoop; + + ASSERT_IRQL(DISPATCH_LEVEL); + + if (fWrite) { + if (Lock->Context == PsGetCurrentThread()) { + LockState->LockState = 2; + } else { + KeAcquireSpinLock(&Lock->SpinLock, &LockState->OldIrql); + /* Check if any other processor helds a shared lock. */ + for (ProcessorNumber = KeNumberProcessors; ProcessorNumber--; ) { + if (ProcessorNumber != KeGetCurrentProcessorNumber()) { + /* Wait till the shared lock is released. */ + while (Lock->RefCount[ProcessorNumber].RefCount != 0) { + for (BusyLoop = 32; BusyLoop--; ) + ; + } + } + } + Lock->Context = PsGetCurrentThread(); + LockState->LockState = 4; + } + } else { + KeRaiseIrql(DISPATCH_LEVEL, &LockState->OldIrql); + RefCount = InterlockedIncrement((PLONG)&Lock->RefCount[KeGetCurrentProcessorNumber()].RefCount); + /* Racing with a exclusive write lock case. */ + if (Lock->SpinLock != 0) { + if (RefCount == 1) { + if (Lock->Context != PsGetCurrentThread()) { + /* Wait for the exclusive lock to be released. */ + Lock->RefCount[KeGetCurrentProcessorNumber()].RefCount--; + KefAcquireSpinLockAtDpcLevel(&Lock->SpinLock); + Lock->RefCount[KeGetCurrentProcessorNumber()].RefCount++; + KefReleaseSpinLockFromDpcLevel(&Lock->SpinLock); + } + } + } + LockState->LockState = 3; + } } /* * @implemented */ +VOID +EXPORT +NdisReleaseReadWriteLock( + IN PNDIS_RW_LOCK Lock, + IN PLOCK_STATE LockState) +/* + * FUNCTION: + * ARGUMENTS: + * NOTES: + * NDIS 5.0 + */ +{ + switch (LockState->LockState) { + case 2: /* Exclusive write lock, recursive */ + return; + + case 3: /* Shared read lock */ + Lock->RefCount[KeGetCurrentProcessorNumber()].RefCount--; + LockState->LockState = -1; + if (LockState->OldIrql < DISPATCH_LEVEL) + KeLowerIrql(LockState->OldIrql); + return; + + case 4: /* Exclusive write lock */ + Lock->Context = NULL; + LockState->LockState = -1; + KfReleaseSpinLock(&Lock->SpinLock, LockState->OldIrql); + return; + } +} + +

20 years

ATTN frik85: Website related bugs in Bugzilla

by WaxDragon

Here is the list of website related bugs currently in Bugzilla. Please keep these in mind when implementing the new site. When the new site is in place, please resolve the applicable bugs. "Bugzilla username/password weirdness" http://www.reactos.com/bugzilla/show_bug.cgi?id=22 "Roles on reactos.com" http://www.reactos.com/bugzilla/show_bug.cgi?id=68 "Various minor reactos.com issues" http://www.reactos.com/bugzilla/show_bug.cgi?id=76 "Taking a bug in bugzilla doesn't change the assignee" http://www.reactos.com/bugzilla/show_bug.cgi?id=196 "Hardware Compatiblity List (HCL)" http://www.reactos.com/bugzilla/show_bug.cgi?id=296 "rss feeds for reactos would be nice" http://www.reactos.com/bugzilla/show_bug.cgi?id=383 "users.reactos.com" http://www.reactos.com/bugzilla/show_bug.cgi?id=438 "Account Creation and Bugzilla is flaky" http://www.reactos.com/bugzilla/show_bug.cgi?id=459 "invisible graphic on the website seems not to exist" http://www.reactos.com/bugzilla/show_bug.cgi?id=612 "News Section on User Site is screwed up" http://www.reactos.com/bugzilla/show_bug.cgi?id=613 Thanks! WD -- #irc.freenode.net #reactos 01:03PM <filip2307> i don't know about any bug 01:04PM <filip2307> none exist 01:04PM <filip2307> ReactOS is prefect

20 years

We are linked from microsoft.com!!!

by reactos

Hello guys, Just want to encourage you about that we are linked from Microsoft.com!!! Nothing really nice, but we are... ...that's what matters, right? http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dnsoftware… Yours sincerely, Jaix Bly

20 years

RE: Ros-dev Digest, Vol 12, Issue 38

by Lucio Diaz

The bug appears only in the instalation. I tried the livecd and it works fine. Best regards, Lucio Diaz. --------------------------------- Correo Yahoo! Comprueba qué es nuevo, aquí http://correo.yahoo.es

20 years

Re: ReactOS

by Jason Filby

Thanks Jim, I passed your regards on to the development team. I think sometimes we forget the great promise that ReactOS holds, but then someone like yourself reminds us. Cheers Jason On 8/23/05, Jim101 <jim101(a)bellsouth.net> wrote: > > I had hoped beyond hopes that someone was working on a truly open source > alternative to windows that could easily run any program ever made for > it, and I stumble across this project. > > All I can say is THANK YOU, and I wish your whole group the most > heartfelt best of luck. It would be the one thing that squared a wrong > done many years back by that little thief. To have an OS that would be > completely compatible with them all is a dream that far to many of us > share, and for it to be open source well. I just don't know what to say > I am ecstatic about it. Once again the very very best to each and > everyone of you that make it happen. > > For people like myself being disabled and on a fixed income the prices > that MS puts on their programs just sickens me. I have never intended to > be a thief in my life, I served my County and worked up until the day I > fell to the ground, never to recover completely. Then fought nearly 3 > years to get the measly little they give me back of my own money. And it > just irks me to see then do as they do, I mean I am all for a person > getting paid for their time and effort, it is only fair. but to charge > prices that most people can not archive, that is not how it was meant to > be. Anyway I am rambling, I just wanted to be sure you all knew that > there are many of us that would love to see your dream "and ours" come > true! > Best of luck! and God Bless! > >

20 years

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev August 2005