Ros-dev January 2006

ros-dev@reactos.org

69 participants
136 discussions

by Thomas Weidenmueller

Hey devs, I hope the new rules we established will prevent something similar in the future and I really hope this project will one day succeed. It's not going to be an easy task, but it can be done. I wish you all best luck to succeed. However, the amount of effort more or less wasted, and personal reasons made me decide that it's better for me to step back for now until ReactOS some day reaches this point of maturity again. I basically don't have the resources and energy to devote so much time, again. Re-inventing the wheel already is controversial, but I personally can't do it yet another time. I've met many very talented people ever since I joined almost three years ago, so it's very sad for me to leave most of this behind. Even though there were disagreements occasionally, it was great fun for me to collaborate and create something unique and outstanding. However, I'm going to try to stay in touch at least. I encourage everyone to stay if somehow possible and rebuild ReactOS! Thanks for everything that was done for me and the countless hours of fun I had with this project. Best Regards, Thomas

18 years, 11 months

NTVFS from Samba 4.0TP

by Rick Langschultz

I was wondering if NTVFS from the Samba 4.0TP would be able to be integrated with ReactOS? This might add some support for NTFS over Fat32 or like file systems...

18 years, 11 months

svn: No access allowed to this repository

by Reuben Perelman

What's going on with subversion?

18 years, 11 months

ROS 21010: KMODE on start of installer

by Reuben Perelman

I'm getting a KMODE_EXCEPTION_NOT_HANDLED on bootup of ROS 21010 on QEMU. Technical information: ***STOP: 0x0000001E (0xc0000005,0x7c90b49,0x0000000,0x0000000) Page Fault Exception: 14(0) Processor: 0 CS:EIP 1b:7c907b49 cr2 0 cr3 567000 Proc: 009a02a0 DS 23 ES 23 FS 3v GS - EAX: 00000000 EBX: 0000001 ECX: 0000002 EDX: 00000003 EBP: 0000000 ESI: 0000008 NTDDK: Pageable code called at IRQL > APC_LEVEL (31) Assertion 'FALSE' failed at ./ntoskrnl/ob/handle.c line 888

18 years, 11 months

Another NDIS bug fix.

by Jerry

Inproved the implimentation of NdisWriteConfiguration(), by Crashfourit. Index: drivers/net/ndis/ndis/config.c =================================================================== --- drivers/net/ndis/ndis/config.c (revision 21005) +++ drivers/net/ndis/ndis/config.c (working copy) @@ -66,6 +66,18 @@ ULONG ParameterType = ParameterValue->ParameterType; ULONG DataSize; PVOID Data; + + /* + The next few lines of code before teh first if statement are used when + ParameterType equals NdisParameterHexInteger or NdisParameterInteger. + This is done so that Buff can be used beyond the switch statement. + */ + UNICODE_STRING buff; + WCHAR str[25]; + + Buff->Length=0; + Buff->MaximumLength = sizeof(str) / sizeof(str[0]); + Buff->Buffer=str; if(ParameterType != NdisParameterInteger && ParameterType != NdisParameterHexInteger && @@ -81,12 +93,29 @@ /* reset parameter type to standard reg types */ switch(ParameterType) { - /* TODO: figure out what do do with these; are they different? */ + /* + TODO: figure out what do do with these; are they different? + Done by Crashfourit + */ case NdisParameterHexInteger: - case NdisParameterInteger: - ParameterType = REG_SZ; - Data = &ParameterValue->ParameterData.IntegerData; - DataSize = sizeof(ULONG); + case NdisParameterInteger: + { + if (!NT_SUCCESS(RtlIntegerToUnicodeString( + ParameterValue->ParameterData.IntegerData, + ( ParameterType == NdisParameterHexInteger ) ? 16 : 10, + &buff)) + ) + { + *Status = NDIS_STATUS_FAILURE; + return; + } + else + { + ParameterType = REG_SZ; + Data = &Buff->Buffer; + DataSize = Buff->Length; + } + } break; case NdisParameterString:

18 years, 11 months

Keyboard Lights

by James Tabor

Hi all, Has anyone noticed the keyboard lights not working. I guess sometime around first part of December. Thanks, James

18 years, 11 months

Code Auditing Questions

by M Bealby

Hey all, As my exams are now over I will hopefully be having more free time available to put into ReactOS security. I would like to perform a security audit of the code base. I've jotted down a few thoughts and suggestions of mine below and would appreciate feedback on them. Methodology I hope to work on the kernel mode code first, working up through the layers up to application API level code. I feel this is the best method because, as it has been mentioned before to me on IRC / email , some functions canot check the parameters that are passed down to lower functions. I understand the following code to run in kernel mode: /lib/rtl/ /lib/string/ /lib/kjs/ /lib/freetype/ /lib/pseh/ /hal/ /drivers/ /subsys/win32k/ /ntoskrnl/ If you know of any more please let me know. I was thinking of checking out an entire svn revision and updating only after I had checked an entire library. What do other people think on this? I will predominatly be working just from the code source, but after playing around with Doxygen I have found it to be incredibly useful for quick referencing typedefs and function parameter calls. What am I looking for? I am only a single person, so code auditing will be a slow process at the moment. I wish to check for the following vulnerabilities: Incorrect null termination. Buffer overflows. Premature termination. Lack of input validation. Bad calculations. Off by one / few. Personally I feel this list of six common vulnerability types should be enough to thwart the most common of attacks, but if anyone else feels some other class of vulnerability is missing from the list please let me know. Obviously if I find any other bugs then they will be reported as well. Reporting of errors? How should I go about reporting the errors? I was previously told to report all occasions of the incorrect uses of the RtlAllocateHeap function under the same bug number (no 1110, some still unfixed). Is this the preferred method for my code auditing results? I would like to submit the bugs as quickly as possible, so I can keep my working tree as close to possible to head, but this may mean submitting multiple bug reports for the same problem. I think that the best option is to submit similar bugs in the same module under the same report, but open a new bug if the same vulnerability occurs in another module. Thoughts? These are just some of my ideas that are floating around in my head at the moment. I would welcome all feedback on this matter and I think I may create a wiki page with the same information on. Again, thoughts on this would be nice as I haven't really used wiki's before. Cheers, Martin

18 years, 11 months

New patch for NDIS:config.c

by Jerry

I noticed that the implimentation of NdisReadConfiguration() is slightly off, so I fixed it. The reason why this was so is located in the diff as a comment. Thanks. Index: drivers/net/ndis/ndis/config.c =================================================================== --- drivers/net/ndis/ndis/config.c (revision 20999) +++ drivers/net/ndis/ndis/config.c (working copy) @@ -493,8 +493,17 @@ str.Buffer = (PWCHAR)KeyInformation->Data; (*ParameterValue)->ParameterType = ParameterType; - *Status = RtlUnicodeStringToInteger(&str, 16, &(*ParameterValue)->ParameterData.IntegerData); + + /* + If ParameterType is NdisParameterInteger then the base of str is decimal. + If ParameterType is NdisParameterHexInteger then the base of str is hexadecimal. + */ + if (ParameterType == NdisParameterInteger) + *Status = RtlUnicodeStringToInteger(&str, 10, &(*ParameterValue)->ParameterData.IntegerData); + else if (ParameterType == NdisParameterHexInteger) + *Status = RtlUnicodeStringToInteger(&str, 16, &(*ParameterValue)->ParameterData.IntegerData); ExFreePool(KeyInformation); if(*Status != STATUS_SUCCESS)

18 years, 11 months

Re: [ros-svn] [weiden] 20972: fixed compiling

by James Tabor

weiden(a)svn.reactos.org wrote: > fixed compiling > > > Updated files: > trunk/reactos/lib/gdi32/objects/font.c > Oops, sorry about that, thanks, James

18 years, 11 months

Re: [ros-diffs] [greatlrd] 20960: corret a member name in DD_SURFACECALLBACKS so it is same as ddk

by Royce Mitchell III

greatlrd(a)svn.reactos.org wrote: >corret a member name in DD_SURFACECALLBACKS so it is same as ddk > >Modified: trunk/reactos/w32api/include/ddk/ddrawint.h > > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/w32api/include/ddk/ddrawint.h* > >--- trunk/reactos/w32api/include/ddk/ddrawint.h 2006-01-21 02:19:27 UTC (rev 20959) >+++ trunk/reactos/w32api/include/ddk/ddrawint.h 2006-01-21 14:22:17 UTC (rev 20960) >@@ -421,7 +421,7 @@ > > PDD_SURFCB_GETFLIPSTATUS GetFlipStatus; > PDD_SURFCB_UPDATEOVERLAY UpdateOverlay; > PDD_SURFCB_SETOVERLAYPOSITION SetOverlayPosition; > > >- PVOID Reserved; > > >+ PVOID reserved4; > > > PDD_SURFCB_SETPALETTE SetPalette; > } DD_SURFACECALLBACKS, *PDD_SURFACECALLBACKS; > > > why is this necessary?

18 years, 11 months

← Newer
1
2
3
4
5
6
7
8
...
14
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev January 2006