Ros-dev August 2006

ros-dev@reactos.org

41 participants
59 discussions

Re: [ros-dev] [ros-bugs] [Bug 1743] The MOVEFILE_DELAY_UNTIL_REBOOT flag is incorrect processed in the MoveFileWithProgressW function

by Brandon Turner

ReactOS.Bugzilla(a)reactos.org wrote: > http://www.reactos.org/bugzilla/show_bug.cgi?id=1743 > > > shedon(a)mail.ru changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > AssignedTo|ros-bugs(a)reactos.org |shedon(a)mail.ru > Status|NEW |ASSIGNED > > > > > ------- Comment #1 from shedon(a)mail.ru 2006-08-08 23:55 CET ------- > Created an attachment (id=1015) > --> (http://www.reactos.org/bugzilla/attachment.cgi?id=1015&action=view) > The patch for this bug > > > I just skimmed the patch, but this: - DPRINT("MoveFileWithProgressW()\n"); + DPRINT1("MoveFileWithProgressW()\n"); probably isnt a good idea. -- Brandon Turner turnerb7(a)msu.edu http://www.amateurgramming.com 810-516-6236

18 years, 1 month

Revision 23521 - Infinite loop in CreateProcessW

by Hervé Poussineau

Hi, I've an (mostly) infinite loop in CreateProcessW, probably due to a bug in ntdll/loader/utils.c or in kernel APCs. To reproduce: - Download revision >= 23433 - Enable the call to StartService in base/system/winlogon/winlogon.c:StartCustomService This call leads to base/system/services/database.c:ScmStartUserModeService, which calls CreateProcessW The debug log is: (KERNEL32:dll\win32\kernel32\process\create.c:679) CreateProcessW: lpApplicationName: <NULL> lpCommandLine: lsass.exe lp Environment: 00000000 lpCurrentDirectory: <NULL> dwCreationFlags: 8 (ntoskrnl\ps\process.c:692) FIX PS SDs!! (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 00B50000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 00C2B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 00407000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 00C57000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 00C80000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 010C0000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 0119B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 00411000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 011C7000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 011F0000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 01630000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 0170B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 00421000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 01737000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 01760000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 01BA0000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 01C7B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 01CA7000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 01CB0000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 01CD9000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 02120000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 021FB000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 01D04000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 02227000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 02250000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 02690000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 0276B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 02797000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 027A0000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 027C9000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 02C10000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 02CEB000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 027F4000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 02D17000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 02D40000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 03180000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 0325B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 03287000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 03290000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 032B9000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 03700000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 037DB000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 032E4000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 03807000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 03830000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 03C70000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 03D4B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 03D77000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 03D80000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 03DA9000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 041F0000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 042CB000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 03DD4000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 042F7000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 04320000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 04760000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 0483B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 04867000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 04870000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 04899000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 04CE0000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 04DBB000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 048C4000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 04DE7000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 04E10000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 05250000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 0532B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 05357000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 05360000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 05389000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 057D0000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 058AB000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 053B4000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 058D7000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 05900000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 05D40000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 05E1B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 05E47000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 05E50000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 05E79000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 062C0000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 0639B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 05EA4000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 063C7000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 063F0000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 06830000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 0690B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 06937000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 06940000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 06969000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 06DB0000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 06E8B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 06994000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 06EB7000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 06EE0000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 07320000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 073FB000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 07427000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 07430000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 07459000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 078A0000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 0797B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 07484000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 079A7000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 079D0000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 07E10000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 07EEB000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 07F17000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 07F20000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 07F49000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 08390000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 0846B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 07F74000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 08497000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 084C0000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 08900000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 089DB000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 08A07000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 08A10000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 08A39000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 08E80000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 08F5B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 08A64000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 08F87000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 08FB0000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 093F0000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 094CB000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 094F7000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 09500000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 09529000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 09970000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 09A4B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 09554000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 09A77000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 09AA0000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 09EE0000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 09FBB000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 09FE7000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 09FF0000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 0A019000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 0A460000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 0A53B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 0A044000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 0A567000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 0A590000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 0A9D0000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 0AAAB000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 0AAD7000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 0AAE0000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 0AB09000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 0AF50000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 0B02B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 0AB34000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 0B057000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 0B080000) C:\ReactOS\system32\advapi32.dll (ntoskrnl\ps\thread.c:500) FIX PS SDs!! (dll\ntdll\ldr\utils.c:2076) Relocating (7c800000 -> 0B4C0000) C:\ReactOS\system32\KERNEL32.dll (dll\ntdll\ldr\utils.c:2076) Relocating (78000000 -> 0B59B000) C:\ReactOS\System32\msvcrt.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76540000 -> 0B5C7000) C:\ReactOS\System32\lsasrv.dll (dll\ntdll\ldr\utils.c:2076) Relocating (76000000 -> 0B5D0000) C:\ReactOS\System32\rpcrt4.dll (dll\ntdll\ldr\utils.c:2076) Relocating (77dc0000 -> 0B5F9000) C:\ReactOS\system32\advapi32.dll (dll\ntdll\ldr\startup.c:485) Failed to initialize image (ntoskrnl\ke\kthread.c:406) Mutant: 80FD17D8. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 80FD8540. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 80FDF2B8. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 80FE6048. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 80FECE90. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 80FF3C20. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 80FFA980. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 810016F8. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 81008488. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 8100F218. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 81016028. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 8101CDB8. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 81023B80. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 8102A980. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 810317C8. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 810385C8. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 8103F390. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 81046120. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 8104CE98. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 81053C68. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 8105AA28. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 81061820. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 81068610. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 8106F3E8. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 81076190. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 8107CF30. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 81083CF8. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 8108AA80. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 810918A0. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 81098700. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 80FC2B88. Type, Size 2 8 (ntoskrnl\ke\kthread.c:406) Mutant: 80FCA9E8. Type, Size 2 8 See that kernel32.dll and others are loaded multiple times, and each time at a different address. I've no clue how to debug this. Anyone can take a look at it? Thanks in advance, Hervé

18 years, 1 month

Re: [ros-dev] [ros-diffs] [ekohl] 23521: - Implement ScmStartServiceA and revert the last modification of StartServiceA. - Fix EnumServicesStatusExW.

by Hervé Poussineau

Hi, > Subject: [ros-diffs] [ekohl] 23521: > - Implement ScmStartServiceA and revert the last modification of StartServiceA. > - Fix EnumServicesStatusExW. We now have an exact code duplication between StartServiceA/StartServiceW (except strlen/wcslen and strcpy/wcscpy) and ScmrStartServiceA/ScmrStartServiceW. I don't think it's a good thing because we will have some problems to keep the code in sync. I did r23519 to prevent this code duplication and because ScmrStartServiceA() was not called except in StartServiceA. By the way, I also implemented argument conversion between ANSI and Unicode in StartServiceA before calling StartServiceW, which meant that arguments were ignored only in ScmrStartServiceW. Now, you have 2 places to take care of them (ScmrStartServiceA/W)... That was just to say my feeling... Hervé

18 years, 1 month

Registry

by Timo Kreuzer

> Commit by *fireball* :: r*23508* *reactos*/ntoskrnl/ (cm/regobj.c > ob/obhandle.c): > > Goodbye REGISTRY_ERROR bsod! > > * Change UserMode -> KernelMode in ObReferenceObject*() calls, > because that calls failed > * Remove Cm-specific hack from Ob "advapi32_winetest.exe registry" > shows 0 failures on the first run and 2 failures on further > runs. I suppose there might be a leakage in the CM. To be > investigated further (or wait till complete Cm rewrite in October). > Still regedit crashes when trying to open a key that contains one or more values.

18 years, 1 month

Re: [ros-dev] [ros-diffs] [fireball] 23508: Goodbye REGISTRY_ERROR bsod! - Change UserMode -> KernelMode in ObReferenceObject*() calls, because that calls failed - Remove Cm-specific hack from Ob "advapi32_winetest.exe registry" shows 0 failures on the first run and 2 failures on further runs. I suppose there might be a leakage in the CM. To be investigated further (or wait till complete Cm rewrite in October).

by Alex Ionescu

Hi, Alex-from-Texas here. WOW, that was awesome. I forgive you for comitting that satanic LDT "patch" because of this. Best regards, Alex Ionescu fireball(a)svn.reactos.org wrote: >Author: fireball >Date: Mon Aug 7 01:15:55 2006 >New Revision: 23508 > >URL: http://svn.reactos.org/svn/reactos?rev=23508&view=rev >Log: >Goodbye REGISTRY_ERROR bsod! > >- Change UserMode -> KernelMode in ObReferenceObject*() calls, because that calls failed >- Remove Cm-specific hack from Ob > >"advapi32_winetest.exe registry" shows 0 failures on the first run and 2 failures on further runs. >I suppose there might be a leakage in the CM. To be investigated further (or wait till complete Cm rewrite in October). > >Modified: > trunk/reactos/ntoskrnl/cm/regobj.c > trunk/reactos/ntoskrnl/ob/obhandle.c > >Modified: trunk/reactos/ntoskrnl/cm/regobj.c >URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/cm/regobj.c?rev=2… >============================================================================== >--- trunk/reactos/ntoskrnl/cm/regobj.c (original) >+++ trunk/reactos/ntoskrnl/cm/regobj.c Mon Aug 7 01:15:55 2006 >@@ -148,7 +148,7 @@ > ObReferenceObjectByPointer(FoundObject, > STANDARD_RIGHTS_REQUIRED, > CmiKeyType, >- UserMode); >+ KernelMode); > if (End != NULL) > { > *End = L'\\'; >@@ -790,7 +790,7 @@ > ObReferenceObjectByPointer(ParentKey, > STANDARD_RIGHTS_REQUIRED, > CmiKeyType, >- UserMode); >+ KernelMode); > NewKey->ParentKey = ParentKey; > } > > >Modified: trunk/reactos/ntoskrnl/ob/obhandle.c >URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obhandle.c?rev… >============================================================================== >--- trunk/reactos/ntoskrnl/ob/obhandle.c (original) >+++ trunk/reactos/ntoskrnl/ob/obhandle.c Mon Aug 7 01:15:55 2006 >@@ -239,17 +239,8 @@ > /* Dereference the object as well */ > ASSERT(ObjectHeader->Type); > ASSERT(ObjectHeader->PointerCount != 0xCCCCCCCC); >- if (!wcscmp(ObjectHeader->Type->Name.Buffer, L"Key")) >- { >- // >- // WE DONT CLOSE REGISTRY HANDLES BECAUSE CM IS BRAINDEAD >- // >- DPRINT("NOT CLOSING THE KEY\n"); >- } >- else >- { >- ObDereferenceObject(Body); >- } >+ >+ ObDereferenceObject(Body); > > /* Return to caller */ > OBTRACE(OB_HANDLE_DEBUG, > > > >

18 years, 1 month

Broken Build

by James Tabor

From http://reactos.dyndns.org:8010/ [CC] drivers\network\ndis\ndis\control.c drivers\network\ndis\ndis\control.c: In function `NdisAcquireReadWriteLock': drivers\network\ndis\ndis\control.c:63: warning: assignment makes integer from pointer without a cast make: *** [obj-i386\drivers\network\ndis\ndis\control.o] Error 1 program finished with exit code 2 From Linux, [CC] drivers/network/ndis/ndis/control.c drivers/network/ndis/ndis/control.c: In function `NdisAcquireReadWriteLock': drivers/network/ndis/ndis/control.c:63: warning: assignment makes integer from pointer without a cast make[1]: *** [obj-i386/drivers/network/ndis/ndis/control.o] Error 1 make: *** [ndis] Error 2 8^) James

18 years, 1 month

Re: [ros-dev] [ros-diffs] [fireball] 23491: [AUDIT] Configuration Manager Cm part of the kernel was developed from scratch for a long time ago, and based only on legally clean information sources. After going through the code, it doesn't have any signs of questionable origin. Authorship information will be added during formatting of the code.

by Alex Ionescu

fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Sun Aug 6 01:39:29 2006 > New Revision: 23491 > > URL: http://svn.reactos.org/svn/reactos?rev=23491&view=rev > Log: > [AUDIT] > Configuration Manager > > After going through the code, it doesn't have any signs of questionable origin. If it did, where are all those REGISTRY_ERROR bugchecks I should be getting in Windows NT? :P -- Best regards, Alex Ionescu Project Lead, TinyKRNL Kernel-Mode Software Design Engineer, ReactOS

18 years, 1 month

Re: [ros-dev] [ros-diffs] [fireball] 23489: Fix DbgPrint / DbgPrintEx definitions to use PCCHAR instead of PCCH (recent WDK uses PCCHAR). This change fixes compiling.

by Alex Ionescu

fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Sun Aug 6 00:57:36 2006 > New Revision: 23489 > > URL: http://svn.reactos.org/svn/reactos?rev=23489&view=rev > Log: > Fix DbgPrint / DbgPrintEx definitions to use PCCHAR instead of PCCH (recent WDK uses PCCHAR). > This change fixes compiling. > Um, no, this is the latest definition: ULONG __cdecl DbgPrint ( __in PCCH Format, ... ); Why do you think I had changed it in the first place?! A PCCHAR is *NOT* a const char, it's just typedef char*. So my change correctly changed the definition to use const char (Because dbgprint fails if you're not sending a const char), and also allowed building with the fixed WDKs, and you just reverted that... when you asked on Google Talk if you could fix it, I assumed you know what you were doing :) -- Best regards, Alex Ionescu Project Lead, TinyKRNL Kernel-Mode Software Design Engineer, ReactOS

18 years, 1 month

WinLogon

by Alex Ionescu

Hi, I'm really excited by all the recent WinLogon work! Congratulations to Hervé for working on this. Some questions: Will the GINA be 100% compatible with NT WinLogon? I hope so. Also, there is a fully FOSS GINA project out there, I'm sure it can be useful. MSDN also has a lot of information, and I can help with some Winlogon internals, by email only please, I'm not and won't be on IRC for a while. Are we also going to support GUI-on-demand? That was largely the big problem with Winlogon, and both Thomas and I (And others) think GUI On Demand is a big hack that currently screws up more stuff then it helps... If yes, then how's winlogon going to work? As a text-mode login problem as well? Hopefully that won't hack GINA compatibility. Since this was supposed to be an SoC program, I propose that we setup a personal fund (and advertise) on the website for Hervé to get paid. I'll also try talking to Google (since our SoC GINA guy failed) to see if they'd be willing to set up an exchange. Unless Hervé disagrees, of course. Good luck to all. -- Best regards, Alex Ionescu Project Lead, TinyKRNL Kernel-Mode Software Design Engineer, ReactOS

18 years, 1 month

Registry binary hives -- "problem"

by Aleksey Bragin

Hello, it looks like it is a common problem that people don't like to read commit messages :-) So I post here - starting from the introduction of cmlib patch into our tree, the binary hives became compatible with Windows XP binary hives, BUT incompatible to ReactOS binary hives made with the previous versions of ReactOS (this includes the current 0.3 release). In order to overcome this problem, simply reinstall your reactos with formatting the harddrive partition during setup. Or manually delete the contents of \system32\config directory, issue a "make install_registry" command, and don't forget to upgrade your freeldr.sys too (in case you install all that manually without bootcd). WBR, Aleksey Bragin.

18 years, 1 month

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev August 2006