NtGdiBitBlt calls IntEngBitBlt, wich calls DrvBitBlt if available.
There's no DrvScroll function.
Timo
> Author: weiden
> Date: Fri Oct 19 07:23:04 2007
> New Revision: 29670
>
> URL: http://svn.reactos.org/svn/reactos?rev=29670&view=rev <http://svn.reactos.org/svn/reactos?rev=29670&view=rev>
> Log:
> Tweak the ScrollDC implementation a bit so that it produces a better output. The implementation still is completely incorrect as it should call the driver for this operation instead of doing a BitBlt operation...
>
> Modified:
> trunk/reactos/subsystems/win32/win32k/ntuser/painting.c
>
Hello,
honestly, your enthusiasm seems a bit to exagerated to me!
In the specific case, it looks like that all TCHARs in Taskmgr have been converted to WCHAR because the programme receives from the API some informations that are UNICODE only.
I can understand and I agree to that, afterall it can be made working with unicows layer, if someone wants (and infact, I did it).
Athough you should also admit that two WideCharToMultiByte() calls are not exactly something we can call "drammatic" code, which is automatically excluded by the presence of the magic UNICODE macro.
I also agree with the fact that there could be the source code which interacts with UNICODE-only variables and the direct usage of WCHAR instead of TCHAR is very helpful and clean.
But how many functions have this behavior (WCHAR-only)?
It is not too difficult to count them and in my opinion this does not justify a refresh of sources for making TCHAR>WCHAR, or MessageBox>MessageBoxW...
Last but not last... human beings can do errors, their changes may always introduce new errors, so more time for testing, etc...
If I can do a suggestion, I would avoid unnecesary changes for this reason too.
Afterall the binary code of the executable won't change by a single bit when TCHARs are converted to WCHARs at compile time, if there are not drawbacks like tons of conversions which will make the source code unreadable (it's also important that people understand the code for contribuiting).
But if there are just TCHARs/_tcscpy/... I don't understand the reason.
Sincerely,
Carlo Bramini.
---------- Initial Header -----------
>From : ros-dev-bounces(a)reactos.org
To : "ReactOS Development List" ros-dev(a)reactos.org
Cc :
Date : Mon, 5 Nov 2007 23:55:35 +0000
Subject : Re: [ros-dev] About UNICODE<->ASCII support.
> On Nov 5, 2007 5:53 PM, Colin Finck <mail(a)colinfinck.de> wrote:
> > Hi Ged,
> >
> > > Ged wrote:
> > > This is the wrong way to be working. We should be dropping
> > > support for ASCII where ever possible now.
> >
> > Is this really the official course now?
>
> This has pretty much always been the course.
> There is absolutely no reason to use TCHAR, it was relevant 10 years
> ago, but not any more.
>
> (btw, in case anyone thinks I'm contradicting myself with mstsc, TCHAR
> is only being used as it's currently a port of an ASCII app)
> _______________________________________________
> Ros-dev mailing list
> Ros-dev(a)reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
>
Hi,
welcome.
The best is to join #reactos on freenode and have a live talk with
devs. The language used throughout ReactOS is mostly C, with very few
exceptions to C++. And if you have WinAPI knowledge, it would be
appreciated.
WBR,
Aleksey Bragin.
On Nov 14, 2007, at 12:16 AM, James Holland wrote:
> My name is James Holland. I am interested in helping with the
> development of ReactOS. I am fairly adept with C++. I also have used
> APL (not very well) and MS Visual Basic at past times. I am currently
> using Java in my Computer Science class.
>
> For background, I am a Student at New Mexico Tech. My major is
> Electrical Engineering.
>
> I am open for any suggestions as to what I should do.
>
> James Holland
My name is James Holland. I am interested in helping with the
development of ReactOS. I am fairly adept with C++. I also have used
APL (not very well) and MS Visual Basic at past times. I am currently
using Java in my Computer Science class.
For background, I am a Student at New Mexico Tech. My major is
Electrical Engineering.
I am open for any suggestions as to what I should do.
James Holland
Hello,
Probably, you are right.
It's better to close this discussion here.
I will move my interests elsewhere, where your nice replies won't reach me.
Greetings to all.
Sincerely,
Carlo Bramini.
"unsubscribe"... <click>
---------- Initial Header -----------
>From : ros-dev-bounces(a)reactos.org
To : "ReactOS Development List" ros-dev(a)reactos.org
Cc :
Date : Tue, 13 Nov 2007 15:07:35 -0000
Subject : Re: [ros-dev] About UNICODE<->ASCII support.
> carlo.bramix wrote:
>
> > But, for an ascii-based OS, it's a compromise for getting the
> > application working because that application, if compiled in that
> > configuration, will work only on Win9x/ME.
>
> We have no interest in ascii-based OS's, we have no interest in 9x/ME.
>
> > And this is what I cannot understand: the ability to work in both
> enviroment
> > is an *added*value* to the software, not a defect.
>
> Why? ReactOS apps have no value in being built as ASCII.
> ASCII is both rude and prehistoric. Move on, this is the 21st century,
> ReactOS is a unicode operating system.
> As far as we're concerned Win9x is dead.
>
> > Just another small bit: besides the functions with the 'W' suffix (while
> the
> > remaining part of the planet uses at least the unified function names),
> > sometimes debugging directly unicode is a pain, at least for me...
>
> Well you stay on your prefered half of the planet and stop bothering us with
> your
> ASCII ranting...
>
> I'd hate to see you work with C#, you'd have a fit as it's unicode only.
> I have visions of you p/invoking everything to make sure you can still build
> your .NET apps as ASCII.
>
> > The strings into the debuggers are shown as a vector of words instead of a
>
> > clear string, same condition when declaring some constant strings into the
>
> > sources, as vector of single chars...
> > Horrible (urgh!).
>
> Get yourself a decent debugger then, or close your eyes, or give up.
>
>
> Ged.
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept liability for any errors or omissions in the contents of this message, which arise as a result of e-mail transmission. If verification is required please request a hard-copy version.
>
> Amteus Secure Communications Ltd
> 57 Cardigan Lane,
> Leeds,
> LS4 2LE
> t: +44 (0) 870 8368770
> f: +44 (0) 870 8368701
>
> Registered in England No 4760795
>
> http://www.amteus.com
>
>
> _______________________________________________
> Ros-dev mailing list
> Ros-dev(a)reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
>
Hello,
> > Athough you should also admit that two WideCharToMultiByte()
> > calls are not exactly something we can call "drammatic" code
> As I also said, WideCharToMultiByte() can cause data corruption if a Unicode
> character isn't supported by the currently selected ANSI codepage.
> MultiByteToWideChar() is no problem, but the other direction can be
> problematic.
> After all, we're coding for Windows Server 2003-compatibility here.
> We don't have to care about compatibility with Win9x (ANSI-only) or previous
> NT versions.
That's right, it can cause corruption.
But, for an ascii-based OS, it's a compromise for getting the application working because that application, if compiled in that configuration, will work only on Win9x/ME.
If someone wants to make an object working on his old OS, he must also be ready to the drawbacks, this has never been a news.
Afterall, unicows is doing the same job when wrapping the vaious widechar APIs.
But for NT and later, everything just need to be compiled as UNICODE, no?
And this is what I cannot understand: the ability to work in both enviroment is an *added*value* to the software, not a defect.
I just wanted to clarify that I was not asking to release the accessories and/or other parts of ReactOS' binaries compiled for ASCII. Absolutely not, in no way!
Read: I want the most flexible international support available.
Just another small bit: besides the functions with the 'W' suffix (while the remaining part of the planet uses at least the unified function names), sometimes debugging directly unicode is a pain, at least for me...
The strings into the debuggers are shown as a vector of words instead of a clear string, same condition when declaring some constant strings into the sources, as vector of single chars...
Horrible (urgh!).
Sincerely,
Carlo Bramini
>From all changes introduced on my rbuild branch auto generated resources
seems to be the most controversial by far so I will try to explain here the
design decision behind it
One of my particular obsessions is trying to optimize and automate the
maxium ammout of things, if something can be reasonably created
automatically why do it by hand?
CURRENT SITUATION
=================
Currently the version common defines REACTOS_STR_FILE_DESCRIPTION ,
REACTOS_STR_INTERNAL_NAME and REACTOS_STR_ORIGINAL_FILENAME , localized
resources and theme manifest are added to [modulename].rc , rsrc.rc or
splitted between both.
Problems:
- Theme manifests files "manifest.xml" are architecture
dependent (X86)
- Duplicated content, we will have hundreds of identical
manifest files for every aplication
- No way to compile an aplication without manifest
- No way to compile an aplication with only specified
localizations
- Duplicated work, rbuild has all the information required to
automatically generate the defines
- If we decide to rename or introduce a new define in the future
we will have to edit all resources by hand.
- Resource localizations are compiled with any control , the
only way to check if they are included is by hand.
Advantatges to my proposal:
- It solve all the above problems.
- Reduce man work
- Allows future changes in the format (editing the resource
generator source code (1 file) vs all resources files on SVN)
- It's the base to other future enchancments , when a new
feature is added to rbuild we have just to modify it and all modules will
automatically inherit it.
An most important of all , it represents a change of the model to a metadata
oriented build process. You describe the content (source code , resources
...) rather than the build , rbuild uses that information to generate the
apropiate image (as always) but this information can also be used for
multiple other things, analitics , reports , web ....
How does it work?
=================
First of all IT'S OPTIONAL , you can decide to use it or not, your choice.
We will use the eventvwr.rbuild as sample:
<?xml version="1.0"?>
<module name="eventvwr" type="win32gui" installbase="system32"
installname="eventvwr.exe">
<include base="eventvwr">.</include>
<include base="eventvwr" root="intermediate">.</include>
...
<!-- Auto generated stuff -->
<automanifest>manifest.xml</automanifest>
<autoresource>auto.rc</autoresource>
<!-- Authors -->
<developer>mpiulachs</developer>
<translator>cfinck</translator>
<translator>fireball</translator>
<translator>mpiulachs</translator>
<metadata description="ReactOS Event Log Viewer" />
<!-- Avialable localizations for this module -->
<localization isoname="de-DE">lang/de-DE.rc</localization>
<localization isoname="en-US">lang/en-US.rc</localization>
<localization isoname="es-ES">lang/es-ES.rc</localization>
<localization isoname="fr-FR">lang/fr-FR.rc</localization>
<localization isoname="ru-RU">lang/ru-RU.rc</localization>
</module>
to turn auto resources on we have to add the <autoresource> element with the
name of the resource that will be created in the INTERMEDIATE folder in this
case it will be named "auto.rc".
It will also automatically create the apropiate manifest.xml file for the
architecture being build (x86 or PPC) and will reference it in "auto.rc"
Also it will validate and include the localizations, even it has
localizations for 5 languages it will only compile those specified on
languages.rbuild
See attached files for autogenerated content
I tried to explain the motivation behind my changes and why I think they are
positive , of course I'm open to your questions , ideas or comments but
please be contructive and argument your point of view , "I don't like it ,
we won't use it" as someone said is not an expected opinion.
/Marc
How is it possible to tell XP what specific IRQ to put your audio
card on in Standard PC mode?
1 In the motherboard BIOS.
2 In the Device Manager.
3 Put the card in the corresponding slot.
4 There are jumpers on most motherboards that you can change to
direct IRQs.
5 None of the above.
_________________________________
Dave Johnson
http://www.davefilms.us DaveFILMS®
San Diego, CA & Nashville, TN
http://perditioncity.us/
Voice Talent
Writer, Producer, Director
Independent Audio Theater Producer
Voice mail and Fax#:(206)350-2915
Voice (615)722-2249
Skype & Msn Live messanger "DaveFilms"
AIM / iChat AV "DaveFilms2007"