Hi!
Sorry for the delay here,,,
This is what we know to be correct sofar. The "Book" section 3.4
GdiTableCell structure is not necessarily correct.
typedef struct _GDI_TABLE_ENTRY
{
PVOID KernelData;
SHORT Count:15; Count number of refs.
SHORT Lock:1; Does set if locked by process. It also
explains why the count shows 1 -> 3 most of the time.
SHORT ProcessId; Process Id is here.
SHORT nUpper; should match the upper half of the handle.
CHAR ObjectType; example-> 0x0401, // not all memdc, dc =1, etc,,,
CHAR Flags; --> 0x04 is here, set if memdc, sometimes~.
PVOID UserData;
} GDI_TABLE_ENTRY, *PGDI_TABLE_ENTRY;
Thanks,
James
why waste the last handle?
> author: jimtabor
> Date: Thu Dec 13 23:27:28 2007
> New Revision: 31204
> - for ( i = RESERVE_ENTRIES_COUNT; i < GDI_HANDLE_COUNT; i++ )
> + for ( i = RESERVE_ENTRIES_COUNT; i < GDI_HANDLE_COUNT-1; i++
> - if (HandleIndex >= GDI_HANDLE_COUNT)
> + if (HandleIndex >= GDI_HANDLE_COUNT-1)
On Dec 12, 2007 7:08 AM, <hpoussin(a)svn.reactos.org> wrote:
> Author: hpoussin
> Date: Wed Dec 12 15:08:11 2007
> New Revision: 31182
> - * Copyright (C) 2002, 2003, 2004 ReactOS Team
> + * Copyright (C) ReactOS Team
A proper copyright header needs to show all of the years like
* Copyright (C) 2002-2004,2007 ReactOS Team
Thanks
--
Steven Edwards
"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo
dchapyshev(a)svn.reactos.org wrote:
> Author: dchapyshev
> Date: Thu Dec 6 22:49:12 2007
> New Revision: 31048
> URL: http://svn.reactos.org/svn/reactos?rev=31048&view=rev
> Log:
> - Move all hardcode strings to resource
This isn't actually used. It should be deleted.
Ged.
Marc, I think I haven't been very clear on this. What I mean, is that
the .spec format already includes *everything* needed to produce
either gcc or msvc-format .def file. So no point in creating yet
another format. Nothing more nothing less, that's what I ment.
I'm glad to hear disadvantages of that way.
WBR,
Aleksey Bragin.
On Nov 24, 2007, at 7:01 PM, Marc Piulachs wrote:
>
>> There is absolutely no need to invent yet another format for storing
>> export functions. It was invented once by MSVC, it was invented by
>> GCC/MinGW, both are incompatible, it was invented by Wine to have
>> ability of easy functions stubbing. Should there be another invention
>> of the same wheel by ReactOS now?
>
>> If GCC/MinGW wouldn't be that *strange*, it could stdcall-fixup, and
>> then properly link, this way .def could be created in the lowest
>> common denominator format.
>
> That's the problem I'm trying to solve..:) The point on this change
> is not
> really store them in xml inset of plain text, is not that
> important, for me
> there are two reasons, first declare this information so rbuild can
> manipulate it as objects and apply checking , logic , whatever ...
> and the
> most important store the information on a neutral , compiler
> agnostic and
> rich format that allow us to generate (export to) ANY format we
> desire out
> of it. Currently def files are tided to mingw which is bad.
>
> At the end the information must be there so what's the difference
> between
> having it in a file with extension .def or .spec and having it on a
> file
> with .rbuild extension? IMO It's not reinventing the wheel
>
> /Marc
Hello,
As I don't know how to contact Eric, I post this on the mailing list now:
With the change in r30958, the build is broken (at least for the BuildBot,
see http://reactos.org:8010/ReactOS_%28Debug%29/builds/5979/step-shell_2/0).
LD misses the "NetUserSetInfo" function. I looked into
dll/win32/netapi32/netapi32.spec and it's declared there, but only as a
stub.
Don't know how to properly fix this now. Maybe it requires a real
implementation of this function.
Regards,
Colin