Ros-dev February 2007

ros-dev@reactos.org

23 participants
37 discussions

Re: [ros-dev] [ros-diffs] [weiden] 25828: - Move around definitions to make the code a bit more modular - Use an about menu instead of an button
by Murphy, Ged (Bolton) 19 Feb '07

19 Feb '07

weiden(a)svn.reactos.org wrote: > > Modified: trunk/reactos/base/applications/charmap/charmap.c > + case WM_SYSCOMMAND: > + { > + switch(wParam) > + { > + case ID_ABOUT: > DialogBox(hInstance, > MAKEINTRESOURCE(IDD_ABOUTBOX), > hDlg, > AboutDialogProc); Modified: trunk/reactos/base/applications/charmap/map.c + if (RegisterClass(&wc)) + { + wc.lpfnWndProc = LrgCellWndProc; + wc.cbWndExtra = 0; + wc.lpszClassName = szLrgCellWndClass; > Modified: trunk/reactos/base/applications/charmap/precomp.h > -INT_PTR CALLBACK AboutDialogProc(HWND hDlg, UINT message, WPARAM wParam, LPARAM lParam); > -LRESULT CALLBACK LrgCellWndProc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam); Maybe I'm reading the diff wrong, but does this not break the build? (not been able to svn up this weekend) I'm guessing the 'case ID_ABOUT' should now call ShowAboutDlg, but what about the assignment of LrgCellWndProc? Ged. Registered Office: PO Box 1 Salford Road, Over Hulton, Bolton, BL5 1DD. Registered in England: No. 2375355 The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)eu.exide.com <mailto:postmaster@eu.exide.com> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com <www.exide.com>

1 0

Re: [ros-dev] [ros-diffs] [mbosma] 25812: Lester Kortenhoeven (lester(at)ko rtenhoeven(dot)de)
by Murphy, Ged (Bolton) 16 Feb '07

16 Feb '07

mbosma(a)svn.reactos.org wrote: > +WCHAR ApplicationText[700]; ... > - StrCatW(DescriptionText, Strings[IDS_VERSION]); > - StrCatW(DescriptionText, SelectedApplication->Version); > - StrCatW(DescriptionText, L"\n"); > + StrCatW(ApplicationText, Strings[IDS_VERSION]); > + StrCatW(ApplicationText, SelectedApplication->Version); > + StrCatW(ApplicationText, L"\n"); This doesn't fix anything, there is still a potential overflow issue. Quickly skimming through the app, there are numerous other issues too. Ged. Registered Office: PO Box 1 Salford Road, Over Hulton, Bolton, BL5 1DD. Registered in England: No. 2375355 The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)eu.exide.com <mailto:postmaster@eu.exide.com> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com <www.exide.com>

1 0

Changelog for 0.3.1
by Zachary Gorden 15 Feb '07

15 Feb '07

Hi all, I'm one of the release engineers (with Colin_Finck) and we're starting to put together the changelog. We're asking any devs that want to to add what they feel might be a noteworthy accomplishment/change made to 0.3.1 in the Highlights of this Release section on the changelog. Here's the link: http://www.reactos.org/wiki/index.php/ChangeLog-0.3.1 Also, as we branch out and begin cataloging the changes in more detail, you're all welcome to add in or clarify things. However, we do reserve the right to make edits to your contributions either for formatting, clarity, or general readability issues. Thank you for your attention, we now return to your regular programming. Z98

3 4

15 Feb '07

On 2/14/07, Saveliy Tretiakov <saveliyt(a)gmail.com> wrote: > Ged Murphy пишет: > > IIRC, Julliard stated that if test cases were submitted along with the > > patch, he would accept code. > > No, not always. My rpc code with testcases was not accepted, because it > was from reactos. I think Alexandre has loosened his restrictions a bit. If I recall correctly you had a widl patch, he might be interested in some of them now as he is having to do a bit of work on that code. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

5 7

WIDL
by Jacques Mony 15 Feb '07

15 Feb '07

Hi, I've read somewhere on a Wine list archive that WIDL was supposed to be imported into RosBE, back in... 2005? Can someone tell me what happened and if there is a reason why it's not present at the moment. Thanks, -- Jacques Mony

2 1

Re: [ros-dev] [ros-diffs] [greatlrd] 25794: patch from Physicus, implement TOOLTIPS_NotifyFormat, it now retrurn the type of the string if it unicode or ansi. before it did not return any type at all. it did a heap crash from downloader mangers when it try figout what type of sting the toolstips use. it is tested in 0.3.1 and not whole implemnent is tested yet. it should be right for all case.
by Ged Murphy 14 Feb '07

14 Feb '07

greatlrd(a)svn.reactos.org wrote: > URL: http://svn.reactos.org/svn/reactos?rev=25794&view=rev > Log: > patch from Physicus, Did anyone actually bother to read Thomas' last email about keeping our comctl32 in line with Wines?

5 5

Re: [ros-dev] about commit 25758 is wrong
by magnus＠itkonsult-olsen.com 13 Feb '07

13 Feb '07

Thomas : ZwQueryDefaultLocale is located in ntoskrnl and it is call on NtQueryDefaultLocale check by my self let us take a look at NtUserGetKeyboardLayoutName 1. it return a keyboard name the keyboard name is the current active Keyboard LCID to optain it we can use ZwQueryDefaultLocale (check reactos code in ntoskrnl how it works) so let us use ZwQueryDefaultLocale to optain the current activate keyboard with follow call ZwQueryDefaultLocale(FALSE, &LocaleId); what happen then let us take a look at ZwQueryDefaultLocale if (UserProfile) *DefaultLocaleId = PsDefaultThreadLocaleId; else *DefaultLocaleId = PsDefaultSystemLocaleId; return DefaultLocaleId; etiher we get current threed local or local system keyboard LCID with this call depns on it is current user or not. depns what we whant. so it is a correct impement to use it. now we can check other thing as well please check how it works in ntoskrnl in ex/local.c then we can talk how it works.

4 6

Re: [ros-dev] [ros-diffs] [tretiakov] 25758: Add multiple keyboard layout support. Implemented NtUserLoadKeyboardLayoutEx, NtUserActivateKeyboardLayout, NtUserGetKeyboardLayoutList, NtUserGetKeyboardLayoutName.
by Aleksey Bragin 13 Feb '07

13 Feb '07

On Feb 9, 2007, at 11:48 PM, tretiakov(a)svn.reactos.org wrote: > Author: tretiakov > Date: Fri Feb 9 23:48:37 2007 > New Revision: 25758 > > URL: http://svn.reactos.org/svn/reactos?rev=25758&view=rev > Log: > Add multiple keyboard layout support. Implemented > NtUserLoadKeyboardLayoutEx, NtUserActivateKeyboardLayout, > NtUserGetKeyboardLayoutList, NtUserGetKeyboardLayoutName. > > > -NtUserLoadKeyboardLayoutEx 6 > +NtUserLoadKeyboardLayoutEx 2 Magnus says that this change is incorrect (and respective change of the prototype is incorrect too, because, he says, we had a Win2003- compatible prototype). Can you comment on this please? WBR, Aleksey Bragin.

4 6

Re: [ros-dev] [ros-diffs] [tkreuzer] 25768: Property sheet: - Set focus to defpushbutton or to first WC_EDIT child window if present, like it works on windows. - update wine diff This fixes the regression in 2nd stage setup when no keyboard focus was present.
by Thomas Weidenmueller 11 Feb '07

11 Feb '07

tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Sun Feb 11 01:02:45 2007 > New Revision: 25768 > > URL: http://svn.reactos.org/svn/reactos?rev=25768&view=rev > Log: > Property sheet: > - Set focus to defpushbutton or to first WC_EDIT child window if present, like it works on windows. > - update wine diff > This fixes the regression in 2nd stage setup when no keyboard focus was present. > > Modified: > trunk/reactos/dll/win32/comctl32/comctl32_ros.diff > trunk/reactos/dll/win32/comctl32/propsheet.c Why is it so difficult to keep differences with wine code as minimal as possible? Who's supposed to merge all these things in case conflicts appear in the future? Why not submit the patches to wine? - Thomas

2 1

Re: [ros-dev] [ros-diffs] [greatlrd] 25763: reverting 25758 : for follow reason 1. it cause regress of loading keyboard layout from the regsiter when reatcos booting. 2. it does not follow windows implement 3. it does not using ntoskrnl for it is ntoskrnl that handling the keyboard not the win32k. 4. it does not using right protoype for some syscall 5. some syscall does not working like windows. it mess it up instead. 6. Do not implement own design on public api and syscall
by Aleksey Bragin 10 Feb '07

10 Feb '07

REVERT WARS ARE NOT ALLOWED in the repository. Fix the code together with its author or wait my approval for reverting. Your SVN account has been temporarily suspended now for periodical violation of the established revert-rules (major part of which were proposed actually by Magnus). Aleksey Bragin. On Feb 10, 2007, at 5:52 PM, greatlrd(a)svn.reactos.org wrote: > Author: greatlrd > Date: Sat Feb 10 17:52:46 2007 > New Revision: 25763 > > URL: http://svn.reactos.org/svn/reactos?rev=25763&view=rev > Log: > reverting 25758 : for follow reason > 1. it cause regress of loading keyboard layout from the regsiter > when reatcos booting. > 2. it does not follow windows implement > 3. it does not using ntoskrnl for it is ntoskrnl that handling the > keyboard not the win32k. > 4. it does not using right protoype for some syscall > 5. some syscall does not working like windows. it mess it up instead. > 6. Do not implement own design on public api and syscall

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev February 2007