Ros-dev July 2007

ros-dev@reactos.org

28 participants
79 discussions

Re: [ros-dev] Update patches into BugZilla

by carlo.bramix

Hello, Patch for bug #2365 has been updated with "svn diff taskmgr". Sincerely, Carlo Bramini ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ros-dev" ros-dev(a)reactos.org Cc : Date : Fri, 6 Jul 2007 15:04:24 +0200 Subject : [ros-dev] Update patches into BugZilla > Hello, > I updated the patch into bug #2356 and I generated it with "svn diff regedit" instead of using "diff -u" or Winmerge with a local copy. > I should do the same with the other patches that I posted, am I right? > > Sincerely, > > Carlo Bramini. > > ---------- Initial Header ----------- > > >From : ros-dev-bounces(a)reactos.org > To : "ros-dev" ros-dev(a)reactos.org > Cc : > Date : Thu, 5 Jul 2007 13:55:47 +0200 > Subject : [ros-dev] Italian fixes to TaskMgr > > > Hello, > > I posted some fixes to bug #2365. > > It fixes few things into the italian translation and I did a small improvement of the source code into affinity.c > > > > Sincerely, > > > > Carlo Bramini > > > > > > > > ------------------------------------------------------ > > Leggi GRATIS le tue mail con il telefonino i-mode di Wind > > http://i-mode.wind.it/ > > > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > > ------------------------------------------------------ > Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom > http://click.libero.it/infostrada > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Leggi GRATIS le tue mail con il telefonino i-mode di Wind http://i-mode.wind.it/

18 years, 1 month

ReactOS doesn't compile well

by carlo.bramix

Hello, it looks like something wrong happens when I compile ReactOS. I also did a complete clean and a make for a total rebuild, but I'm still having problems. I saw the first problem when I tried to test Regedit after committed changes. The tree window and the listview window aren't visible (or they aren't created successfully, I didn't check this yet). I tested that executable into WinXP and those child windows aren't visible too. So I did these steps: 1) I compiled Regedit with Visual C and I verified that it worked fine. 2) I grabbed regedit.res and I manually generated regedit.coff with "windres -i regedit.res -o regedit.coff". 3) I launched "make" again and it regenerated regedit.exe. This last regedit.exe works fine and it has all child window controls visible. It's really a problem when generating te coff file from resources. I also saw a possible second problem when compiling. Some compilation of '.coff' files failed. On the console I read some messages like this one: [WRC] obj-i386\dll\win32\comdlg32\rsrc.coff <built-in>:0: fatal error: when writing output to : Invalid argument compilation terminated. Actually I'm using RosBE 0.3.6 but I never got such problems with previouses svn versions of the sources. Sincerely, Carlo Bramini ------------------------------------------------------ Leggi GRATIS le tue mail con il telefonino i-mode di Wind http://i-mode.wind.it/

18 years, 1 month

Re: [ros-dev] Trunk freeze

by Aleksey Bragin

Trunk unfrozen, guilty revision partially reverted. WBR, Aleksey Bragin.

18 years, 1 month

Trunk freeze

by Aleksey Bragin

Hello, trunk is frozen right now due to inability to boot into 2nd stage (it crashes with "Failure rendering glyph"). As soon as the issue is fixed, trunk will be unfrozen. Thanks for your patience. WBR, Aleksey Bragin.

18 years, 1 month

Re: [ros-dev] [ros-diffs] [ekohl] 27514: - Fix indentation. - Replace tabs by spaces. - Replace STDCALL by WINAPI. - Replace Alex' unreadable single-line statements by readable ones. - No code changes.

by Alex Ionescu

While I don't mind your other re-formats, what's the purpose of insulting my code (which respected ReactOS Coding Guidelines, (please read them: http://www.reactos.org/wiki/index.php/Coding_Style)) and replacing it with non-ReactOS compliant code? Is a 71-character line so hard to read? -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of ekohl(a)svn.reactos.org Sent: July 8, 2007 1:09 PM To: ros-diffs(a)reactos.org Subject: [ros-diffs] [ekohl] 27514: - Fix indentation. - Replace tabs by spaces. - Replace STDCALL by WINAPI. - Replace Alex' unreadable single-line statements by readable ones. - No code changes. Author: ekohl Date: Mon Jul 9 00:09:22 2007 New Revision: 27514 URL: http://svn.reactos.org/svn/reactos?rev=27514&view=rev Log: - Fix indentation. - Replace tabs by spaces. - Replace STDCALL by WINAPI. - Replace Alex' unreadable single-line statements by readable ones. - No code changes. Modified: trunk/reactos/dll/win32/kernel32/file/npipe.c Modified: trunk/reactos/dll/win32/kernel32/file/npipe.c URL:

18 years, 1 month

Update patches into BugZilla

by carlo.bramix

Hello, I updated the patch into bug #2356 and I generated it with "svn diff regedit" instead of using "diff -u" or Winmerge with a local copy. I should do the same with the other patches that I posted, am I right? Sincerely, Carlo Bramini. ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ros-dev" ros-dev(a)reactos.org Cc : Date : Thu, 5 Jul 2007 13:55:47 +0200 Subject : [ros-dev] Italian fixes to TaskMgr > Hello, > I posted some fixes to bug #2365. > It fixes few things into the italian translation and I did a small improvement of the source code into affinity.c > > Sincerely, > > Carlo Bramini > > > > ------------------------------------------------------ > Leggi GRATIS le tue mail con il telefonino i-mode di Wind > http://i-mode.wind.it/ > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom http://click.libero.it/infostrada

18 years, 1 month

Italian fixes to TaskMgr

by carlo.bramix

Hello, I posted some fixes to bug #2365. It fixes few things into the italian translation and I did a small improvement of the source code into affinity.c Sincerely, Carlo Bramini ------------------------------------------------------ Leggi GRATIS le tue mail con il telefonino i-mode di Wind http://i-mode.wind.it/

18 years, 1 month

Re: [ros-dev] [ros-diffs] [cwittich] 27397: ZeroMemory the correct amount of bytes

by Aleksey Bragin

I think those changes are incorrect, because you're effectively zeroing sizeof(void *) instead of zeroing sizeof(PORT_DEVICE_EXTENSION). WBR, Aleksey Bragin. On Jul 5, 2007, at 5:24 AM, cwittich(a)svn.reactos.org wrote: > Author: cwittich > Date: Thu Jul 5 05:24:57 2007 > New Revision: 27397 > > URL: http://svn.reactos.org/svn/reactos?rev=27397&view=rev > Log: > ZeroMemory the correct amount of bytes > > Modified: > trunk/reactos/drivers/input/kbdclass/kbdclass.c > > Modified: trunk/reactos/drivers/input/kbdclass/kbdclass.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/ > kbdclass/kbdclass.c?rev=27397&r1=27396&r2=27397&view=diff > ====================================================================== > ======== > --- trunk/reactos/drivers/input/kbdclass/kbdclass.c (original) > +++ trunk/reactos/drivers/input/kbdclass/kbdclass.c Thu Jul 5 > 05:24:57 2007 > @@ -695,7 +695,7 @@ > } > > DeviceExtension = (PPORT_DEVICE_EXTENSION)Fdo->DeviceExtension; > - RtlZeroMemory(DeviceExtension, sizeof(CLASS_DEVICE_EXTENSION)); > + RtlZeroMemory(DeviceExtension, sizeof(PPORT_DEVICE_EXTENSION)); > DeviceExtension->Common.IsClassDO = FALSE; > DeviceExtension->DeviceObject = Fdo; > DeviceExtension->PnpState = dsStopped; > >

18 years, 1 month

Re: [ros-dev] BugFixing in RegEdit

by carlo.bramix

Hello, following the suggestions that I received, I would like put your attention on these patches posted into bugzilla: - patch Posted into bug #2356. It closes these bugs: #982: some languages had IDOK and IDCANCEL in conflict because both declared as DEFPUSHBUTTON. It should be fixed. #1009: Context menu is now fully working. Fixed. - Patch posted into bug #2356. It fixes itself. - Patch posted into bug #2232 It fixes itself and some unsignaled bugs. I hope I didn't mistakes this time. Sincerely, Carlo Bramini. ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ReactOS Development List" ros-dev(a)reactos.org Cc : Date : Tue, 03 Jul 2007 12:30:36 +0200 Subject : Re: [ros-dev] BugFixing in RegEdit > carlo.bramix ha scritto: > > I'm also wondering why the patches sent to bugzilla aren't replied too. > > I don't know, perhaps I'm just unlucky. > > Just misguided. You post on Bugzilla for the posterity, and then you > post your Bugzilla number on the mailing list for the attention. You > need to get noticed *and* remembered. > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom http://click.libero.it/infostrada

18 years, 1 month

GPLv3 Migration - flamewar warning

by Steven Edwards

Hi, I've been inactive for a while and most likely will be so for a while however I thought this would be a good time to bring up the GPLv3 due to its recent release. Does anyone have any objections to license as it stands now? If you've not had a chance to review it I suggest you do so. I am happy to help answer any questions regarding the license as I did take part in early drafting on behalf of the ReactOS and Wine Projects although I am not a lawyer and anything I say should be at least reviewed by the SFLC or your own lawyers. It is my suggestion that if there are no objections then we start to contact each developer requesting them to dual license existing code as GPLv2/GPLv3 and use the same tracking system as the audit system to do the migration. ReactOS has never been really clear on the "or later version" clause in the GPL. The ReactOS license includes the text and the license number is not specified in most of the ReactOS sources, though I don't think it would be fair to simply take all of the source and re-license it without some discussions and a vote. It would also be possible to distribute ReactOS under both licenses via dual licensing as a possible compromise if a dispute arises. This would mean if some third party (Third Party A) wants to take ReactOS enhance it and then resell it, they would not have to worry about another third party (Third Party B) taking their modifications and redistributing them for profit without the patent protections of the GPLv3 and the Anti-Tivoization clauses. The only downside to this is if Third Party A is only making changes under GPLv3 then those changes could not go back in to ReactOS trunk. I don't think this is a major issue, as I expect both third parties to be proprietary vendors making enhancements that the Project might not want/need in the trunk in any case. Third Party A in the interest of keeping forking to a minimal would still send bug fixes back up both licenses. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

18 years, 1 month

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev July 2007