Ros-dev August 2007

ros-dev@reactos.org

38 participants
58 discussions

Re: [ros-dev] [ros-diffs] [fireball] 28351: Dmitry Chapyshev <lentind@yandex.ru>: - Fix so that letters like "p" or "y" are correctly displayed in messageboxes.
by Ged 29 Sep '07

29 Sep '07

IMO, this change is wrong, it's a hack to a problem we have with text placement. Text is cut short on other controls too, not just messageboxes. Check out labels for example. Ged. fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Wed Aug 15 18:49:44 2007 > New Revision: 28351 > > URL: http://svn.reactos.org/svn/reactos?rev=28351&view=rev > Log: > Dmitry Chapyshev <lentind(a)yandex.ru>: > - Fix so that letters like "p" or "y" are correctly displayed in messageboxes. > > Modified: > trunk/reactos/dll/win32/user32/windows/messagebox.c > > Modified: trunk/reactos/dll/win32/user32/windows/messagebox.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m… > ============================================================================== > --- trunk/reactos/dll/win32/user32/windows/messagebox.c (original) > +++ trunk/reactos/dll/win32/user32/windows/messagebox.c Wed Aug 15 18:49:44 2007 > @@ -491,7 +491,7 @@ > txtrect.right = GetSystemMetrics(SM_CXSCREEN) / 5 * 4; > if(Icon) > txtrect.right -= GetSystemMetrics(SM_CXICON) + MSGBOXEX_SPACING; > - txtrect.top = txtrect.left = txtrect.bottom = 0; > + txtrect.top = txtrect.left = txtrect.bottom = 5; > SelectObject(hDC, hFont); > if (textlen != 0) > { > > > >

7 6

Re: [ros-dev] [ros-diffs] [hpoussin] 28693: Implement IsUserAnAdmin(), by copying implementation of IsUserAdmin() in setupapi (was implemented by Eric Kohl) Redirect setupapi.IsUserAdmin to shell32.IsUserAnAdmin
by Jeremy Drake 31 Aug '07

31 Aug '07

Umm, this implementation of IsUserAnAdmin is not quite correct. I just had to deal with a function almost identical to this in real life, which gave the wrong answer on Vista due to the filtered token containing the Administrators group with the "for deny only" attribute. You need to either check the attribute portion of the SID_AND_ATTRIBUTE struct as well, or use something like CheckTokenMembership (assuming that is implemented properly), or construct a security descriptor and use AccessCheck (again, assuming that is implemented correctly (I would hope so...)). Of course, this is probably just overly anal on ReactOS, as you don't have the whole Vista filtered token/elevation mess (yet), but probably best to be technically correct... On Fri, 31 Aug 2007, hpoussin(a)svn.reactos.org wrote: > Author: hpoussin > Date: Fri Aug 31 13:49:48 2007 > New Revision: 28693 > > URL: http://svn.reactos.org/svn/reactos?rev=28693&view=rev > Log: > Implement IsUserAnAdmin(), by copying implementation of IsUserAdmin() in setupapi (was implemented by Eric Kohl) > Redirect setupapi.IsUserAdmin to shell32.IsUserAnAdmin > > Modified: > trunk/reactos/dll/win32/setupapi/cfgmgr.c > trunk/reactos/dll/win32/setupapi/misc.c > trunk/reactos/dll/win32/setupapi/setupapi.spec > trunk/reactos/dll/win32/shell32/shellord.c > > Modified: trunk/reactos/dll/win32/setupapi/cfgmgr.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/cfgmgr.… > ============================================================================== > --- trunk/reactos/dll/win32/setupapi/cfgmgr.c (original) > +++ trunk/reactos/dll/win32/setupapi/cfgmgr.c Fri Aug 31 13:49:48 2007 > @@ -135,7 +135,7 @@ > if (!PnpGetLocalHandles(&BindingHandle, NULL)) > return CR_FAILURE; > > - bAdmin = IsUserAdmin(); > + bAdmin = IsUserAnAdmin(); > > for (i = 0; i < 30; i++) > { > @@ -182,7 +182,7 @@ > FIXME("%p %p %lu %lx %p\n", > plcLogConf, dnDevInst, Priority, ulFlags, hMachine); > > - if (!IsUserAdmin()) > + if (!IsUserAnAdmin()) > return CR_ACCESS_DENIED; > > if (plcLogConf == NULL) > @@ -298,7 +298,7 @@ > > TRACE("%p %s %lx %p\n", dnDevInst, debugstr_w(pszID), ulFlags, hMachine); > > - if (!IsUserAdmin()) > + if (!IsUserAnAdmin()) > return CR_ACCESS_DENIED; > > if (dnDevInst == 0) > @@ -490,7 +490,7 @@ > FIXME("%p %s %p %lx %p\n", > pdnDevInst, debugstr_w(pDeviceID), dnParent, ulFlags, hMachine); > > - if (!IsUserAdmin()) > + if (!IsUserAnAdmin()) > return CR_ACCESS_DENIED; > > if (pdnDevInst == NULL) > @@ -637,7 +637,7 @@ > > FIXME("%p %lx %p\n", dnDevInst, ulFlags, hMachine); > > - if (!IsUserAdmin()) > + if (!IsUserAnAdmin()) > return CR_ACCESS_DENIED; > > if (dnDevInst == 0) > @@ -725,7 +725,7 @@ > > FIXME("%p %lx %p\n", dnDevInst, ulFlags, hMachine); > > - if (!IsUserAdmin()) > + if (!IsUserAnAdmin()) > return CR_ACCESS_DENIED; > > if (dnDevInst == 0) > @@ -961,7 +961,7 @@ > > TRACE("%lx %lx %lx\n", lcLogConfToBeFreed, ulFlags, hMachine); > > - if (!IsUserAdmin()) > + if (!IsUserAnAdmin()) > return CR_ACCESS_DENIED; > > pLogConfInfo = (PLOG_CONF_INFO)lcLogConfToBeFreed; > @@ -2707,7 +2707,7 @@ > FIXME("%lx %lx %lx %lx\n", > dnFromDevInst, dnToDevInst, ulFlags, hMachine); > > - if (!IsUserAdmin()) > + if (!IsUserAnAdmin()) > return CR_ACCESS_DENIED; > > if (dnFromDevInst == 0 || dnToDevInst == 0) > @@ -3051,7 +3051,7 @@ > > TRACE("%lx %lx\n", ulFlags, hMachine); > > - if (!IsUserAdmin()) > + if (!IsUserAnAdmin()) > return CR_ACCESS_DENIED; > > if (ulFlags & ~CM_DETECT_BITS) > @@ -3525,7 +3525,7 @@ > > FIXME("%lx %lx %lx\n", dnDevInst, ulFlags, hMachine); > > - if (!IsUserAdmin()) > + if (!IsUserAnAdmin()) > return CR_ACCESS_DENIED; > > if (dnDevInst == 0) > > Modified: trunk/reactos/dll/win32/setupapi/misc.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/misc.c?… > ============================================================================== > --- trunk/reactos/dll/win32/setupapi/misc.c (original) > +++ trunk/reactos/dll/win32/setupapi/misc.c Fri Aug 31 13:49:48 2007 > @@ -246,84 +246,6 @@ > MyFree(*lpData); > > return lError; > -} > - > - > -/************************************************************************** > - * IsUserAdmin [SETUPAPI.@] > - * > - * Checks whether the current user is a member of the Administrators group. > - * > - * PARAMS > - * None > - * > - * RETURNS > - * Success: TRUE > - * Failure: FALSE > - */ > -BOOL WINAPI IsUserAdmin(VOID) > -{ > - SID_IDENTIFIER_AUTHORITY Authority = {SECURITY_NT_AUTHORITY}; > - HANDLE hToken; > - DWORD dwSize; > - PTOKEN_GROUPS lpGroups; > - PSID lpSid; > - DWORD i; > - BOOL bResult = FALSE; > - > - TRACE("\n"); > - > - if (!OpenProcessToken(GetCurrentProcess(), TOKEN_QUERY, &hToken)) > - { > - return FALSE; > - } > - > - if (!GetTokenInformation(hToken, TokenGroups, NULL, 0, &dwSize)) > - { > - if (GetLastError() != ERROR_INSUFFICIENT_BUFFER) > - { > - CloseHandle(hToken); > - return FALSE; > - } > - } > - > - lpGroups = MyMalloc(dwSize); > - if (lpGroups == NULL) > - { > - CloseHandle(hToken); > - return FALSE; > - } > - > - if (!GetTokenInformation(hToken, TokenGroups, lpGroups, dwSize, &dwSize)) > - { > - MyFree(lpGroups); > - CloseHandle(hToken); > - return FALSE; > - } > - > - CloseHandle(hToken); > - > - if (!AllocateAndInitializeSid(&Authority, 2, SECURITY_BUILTIN_DOMAIN_RID, > - DOMAIN_ALIAS_RID_ADMINS, 0, 0, 0, 0, 0, 0, > - &lpSid)) > - { > - MyFree(lpGroups); > - return FALSE; > - } > - > - for (i = 0; i < lpGroups->GroupCount; i++) > - { > - if (EqualSid(lpSid, lpGroups->Groups[i].Sid)) > - { > - bResult = TRUE; > - break; > - } > - } > - > - FreeSid(lpSid); > - MyFree(lpGroups); > - > - return bResult; > } > > > > Modified: trunk/reactos/dll/win32/setupapi/setupapi.spec > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/setupap… > ============================================================================== > --- trunk/reactos/dll/win32/setupapi/setupapi.spec (original) > +++ trunk/reactos/dll/win32/setupapi/setupapi.spec Fri Aug 31 13:49:48 2007 > @@ -216,7 +216,7 @@ > @ stdcall InstallHinfSectionW(long long wstr long) > @ stub InstallStop > @ stub InstallStopEx > -@ stdcall IsUserAdmin() > +@ stdcall IsUserAdmin=shell32.IsUserAnAdmin() > @ stub LookUpStringInTable > @ stub MemoryInitialize > @ stdcall MultiByteToUnicode(str long) > > Modified: trunk/reactos/dll/win32/shell32/shellord.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shellord… > ============================================================================== > --- trunk/reactos/dll/win32/shell32/shellord.c (original) > +++ trunk/reactos/dll/win32/shell32/shellord.c Fri Aug 31 13:49:48 2007 > @@ -1227,10 +1227,78 @@ > /************************************************************************* > * IsUserAnAdmin [SHELL32.680] NT 4.0 > * > + * Checks whether the current user is a member of the Administrators group. > + * > + * PARAMS > + * None > + * > + * RETURNS > + * Success: TRUE > + * Failure: FALSE > */ > BOOL WINAPI IsUserAnAdmin(VOID) > -{ FIXME("stub\n"); > - return TRUE; > +{ > + SID_IDENTIFIER_AUTHORITY Authority = {SECURITY_NT_AUTHORITY}; > + HANDLE hToken; > + DWORD dwSize; > + PTOKEN_GROUPS lpGroups; > + PSID lpSid; > + DWORD i; > + BOOL bResult = FALSE; > + > + TRACE("\n"); > + > + if (!OpenProcessToken(GetCurrentProcess(), TOKEN_QUERY, &hToken)) > + { > + return FALSE; > + } > + > + if (!GetTokenInformation(hToken, TokenGroups, NULL, 0, &dwSize)) > + { > + if (GetLastError() != ERROR_INSUFFICIENT_BUFFER) > + { > + CloseHandle(hToken); > + return FALSE; > + } > + } > + > + lpGroups = HeapAlloc(GetProcessHeap(), 0, dwSize); > + if (lpGroups == NULL) > + { > + CloseHandle(hToken); > + return FALSE; > + } > + > + if (!GetTokenInformation(hToken, TokenGroups, lpGroups, dwSize, &dwSize)) > + { > + HeapFree(GetProcessHeap(), 0, lpGroups); > + CloseHandle(hToken); > + return FALSE; > + } > + > + CloseHandle(hToken); > + > + if (!AllocateAndInitializeSid(&Authority, 2, SECURITY_BUILTIN_DOMAIN_RID, > + DOMAIN_ALIAS_RID_ADMINS, 0, 0, 0, 0, 0, 0, > + &lpSid)) > + { > + HeapFree(GetProcessHeap(), 0, lpGroups); > + return FALSE; > + } > + > + for (i = 0; i < lpGroups->GroupCount; i++) > + { > + if (EqualSid(lpSid, lpGroups->Groups[i].Sid)) > + { > + bResult = TRUE; > + break; > + } > + } > + > + FreeSid(lpSid); > + HeapFree(GetProcessHeap(), 0, lpGroups); > + > + return bResult; > } > > /************************************************************************* > > > > -- Fortune's Real-Life Courtroom Quote #19: Q: Doctor, how many autopsies have you performed on dead people? A: All my autopsies have been performed on dead people.

1 0

GDI_TABLE_ENTRY structure
by Timo Kreuzer 31 Aug '07

31 Aug '07

Our current gdi handle and handle table entry code uses a bunch of macros, masks, bitshifts and even hardcoded values, iirc. This leads imo to errors, will make the code less portable and cannot make use of better compiler optimizations. So I have created a new GDI_TABLE_ENTRY struct and a new type GDIHANDLE. Both use unions and packed structs to directly access all fields. GDI_TABLE_ENTRY is completely compatible to our current one, so all the code would still be valid. + the compiler can optimize access of single elements better (movzx, byte ptr ...) + no more need for additional masks, shifts and macros + no more messed up code because of wrong hardcoded values + better readable code + probably easier porting to 64 bits - must be redefined for big-endian systems - direct access of stockbit is slightly slower, but could still be handled by a macro #pragma pack(push,1) typedef struct { PVOID KernelData; /* Points to the kernel mode structure */ union { DWORD ProcessId; /* process id that created the object, 0 for kernel objects */ struct { unsigned ProcessId16: 16; unsigned Unused: 16; }; }; union { ULONG Type; struct { union { unsigned TypeLower: 16; struct { union { unsigned HandleTypeStock: 8; struct { unsigned HandleType: 7; unsigned StockBit: 1; }; }; unsigned ReuseCount: 8; }; }; union { unsigned TypeUpper: 16; struct { unsigned StorageType: 8; /* PEN uses same value as BRUSH here, no stock bit */ unsigned Flags: 8; }; }; }; }; PVOID UserData; /* Points to the user mode structure, usually NULL though */ } GDI_TABLE_ENTRY, *PGDI_TABLE_ENTRY;; typedef union { HGDIOBJ Handle; struct { unsigned Index: 16; union { unsigned Upper: 16; struct { union { unsigned HandleTypeStock: 8; struct { unsigned HandleType: 7; unsigned StockBit: 1; }; }; unsigned ReuseCount: 8; }; }; }; } GDIHANDLE, *PGDIHANDLE; #pragma pack(pop)

6 16

Re: [ros-dev] [ros-diffs] [greatlrd] 28680: implement GdiConvertPalette, GdiConvertRegion
by Ged 30 Aug '07

30 Aug '07

Hi Magnus. Can you explain these please, they seem a bit weird? Cheers, Ged. greatlrd(a)svn.reactos.org wrote: > Author: greatlrd > Date: Thu Aug 30 23:05:43 2007 > New Revision: 28680 > > URL: http://svn.reactos.org/svn/reactos?rev=28680&view=rev > Log: > implement GdiConvertPalette, GdiConvertRegion > > Modified: > trunk/reactos/dll/win32/gdi32/misc/stubs.c > > Modified: trunk/reactos/dll/win32/gdi32/misc/stubs.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/gdi32/misc/stubs… > ============================================================================== > --- trunk/reactos/dll/win32/gdi32/misc/stubs.c (original) > +++ trunk/reactos/dll/win32/gdi32/misc/stubs.c Thu Aug 30 23:05:43 2007 > @@ -1431,15 +1431,13 @@ > } > > /* > - * @unimplemented > + * @implemented > */ > HPALETTE > STDCALL > GdiConvertPalette(HPALETTE hpal) > { > - UNIMPLEMENTED; > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return 0; > + return hpal; > } > > /* > @@ -1449,9 +1447,7 @@ > STDCALL > GdiConvertRegion(HRGN hregion) > { > - UNIMPLEMENTED; > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return 0; > + return hregion; > } > > /* > > > >

2 1

Re: [ros-dev] current status of xen support
by Aleksey Bragin 30 Aug '07

30 Aug '07

There is still a branch "xen", where some work has been done, however it's greatly outdated. If someone has a wish, he could make a new branch. But we don't have any volunteers at the moment. WBR, Aleksey Bragin. On Aug 30, 2007, at 6:32 PM, Brian wrote: > i was curious as to the status of reactos on xen. does it work(boot > at all)? i haven't seen anything new about it on the site, and i > interested. > > thanks in advance > -- > brian

2 1

current status of xen support
by Brian 30 Aug '07

30 Aug '07

i was curious as to the status of reactos on xen. does it work(boot at all)? i haven't seen anything new about it on the site, and i interested. thanks in advance -- brian

3 2

0.33rc2?
by Bernd Blaauw 30 Aug '07

30 Aug '07

Is there going to be a new release candidate of ReactOS version 0.3.3? I tested it very shortly and was very impressed with how it looked in comparison to version 0.3.0. Is there a list of known bugs as feedback from 0.3.3rc1 testers? Searching through Bugzilla might be a bit too much :). Anyway, the issues I experience in VMware 6.00 on WinXP Pro x64 host so far are: * diskette drive not visible (and/or working). Ever since 0.2.8 or so? * shutdown does not close the virtual machine (might be improper shutdown). Screen goes all black and need to enter VMware menu to shutdown the ReactOS virtual machine. Is the AUTORUN.INF by now the only file on the root of the CD? icons and readme files can go in subdirectories I guess, which makes adding ReactOS to multi-installation CDs a lot easier (a CD/DVD containing setup or LiveCD of various operating systems, mostly using the Isolinux bootloader for a frontend menu and chainloading bootsectors). I've not extensively tested the RC1 on for example if it still can complete installation and bootup with 32MB or less RAM installed (VMware allows anywhere from 4MB to 8GB in increments of 4MB, Bochs/Qemu allow 1MB increases). A resolved item I noticed in this new release was the ability to enter digits for the computername, wasnt possible previously in 0.3.0 or 0.3.1. ReactOS is getting interesting by now..a Win32 operating system with a size of about 50MB and capable of playing huge games sooner or later. Looks like a blessing to my limited size (16GB) DRAM based solid state disk.

4 4

[ros-diffs] [jimtabor] 22523: GetGlyphOutline, large wine port. Still testing.
by James Tabor 30 Aug '07

30 Aug '07

Hi, I have it half way done. Run the test program and you can see. Program works in W2k, XP and Wine. mingw32-gcc -mwindows -Os GetGlyphOutline.c -o ggo.exe I stopped messing with it two weeks ago, I needed to work on something else. When testing you can select the alphanumeric character with the keyboard. The original program had "a" but I changed it to "L" something simple to draw at first. You will see the problem. The test program from Dr. Dobb's Journal http://www.ddj.com/184409154?pgno=12 Thanks, James Runs and hides~

1 1

Re: [ros-dev] Will ROS and WINE still be steady be synchronized ?
by theUser BL 29 Aug '07

29 Aug '07

>Personal preference. >Wine are nearing to a 1.0 product and are very careful about what code >enters their repository. >ReactOS does not currently meet their strict policy. > >If you want to get code into Wine, you must submit your patches with test >cases and if required, relevant links to documentation. I have also ask the question on the WINE-mailinglist. The answer at http://www.winehq.org/pipermail/wine-devel/2007-August/058929.html looks like, that the test-suites are not the only reason. Greatings theuserbl _________________________________________________________________ Sie suchen E-Mails, Dokumente oder Fotos? Die neue MSN Suche Toolbar mit Windows-Desktopsuche liefert in sekundenschnelle Ergebnisse. Jetzt neu! http://desktop.msn.de/ Jetzt gratis downloaden!

3 2

Re: [ros-dev] Will ROS and WINE still be steady be synchronized ?
by Aleksey Bragin 29 Aug '07

29 Aug '07

As I already said, the difference between ReactOS and WINE, as it's written in that Wine mailing list, is that ReactOS "is known" [by some] for reversing MS binaries, and Wine is not known for reversing MS binaries (though it does not imply ReactOS is always doing it, and Wine did [does] not reverse engineer). Also, Wine is not "Open Source community", it is *part* of Open source community, as are thousands of other projects, which somehow form the general perception of projects. WBR, Aleksey Bragin. On Aug 29, 2007, at 7:01 PM, Marc Piulachs wrote: > > Does it mean ReactOS is not respected/trusted among the Open Source > community for disassembling Microsoft binaries? > > I don't know if this accusation is really true or not but if it's > not I > think it's even worse because that means that something is failing > (probably > communication) between the project and the OS community. Doing > nothing about > that is IMHO a very bad idea. > > I think it deserves some deep reflection and a *serious* strategy > to change > that general opinion. Earn respect is a KEY thing to do if the > project wants > to attract new developers. > > My two cents, > Marc

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev August 2007