Let's try to calm down the emotions, otherwise people may be
offended :-)
I know Jim is the one who, I think, *never* commited a patch that
breaks something (testing a patch before commiting for one week -
easy), but we have to tolerate that other people (including myself)
tend to do mistakes from time to time.
WBR,
Aleksey Bragin.
On Aug 1, 2007, at 11:38 PM, Ged wrote:
> James Tabor wrote:
>> Man! You are right! The newbies are creating more work for me at
>> every
>> turn! I wish they would stop committing on crack!
>>
>> Thank you for the extra work!
>>
>
> That's rather harsh and partonising!
> These so called 'newbies' have done a great deal of good work
> recently.
>
>
>
> _______________________________________________
> Ros-dev mailing list
> Ros-dev(a)reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
Thanks for all wishes, I really had a nice vacation in Montenegro
(I'll maybe post some photos soon).
Great work on the reactos tree, ros-diffs sounds very promising. I'm
fully back into ReactOS by tomorrow.
WBR,
Aleksey Bragin.
On Jul 24, 2007, at 10:08 PM, Aleksey Bragin wrote:
> Hello,
> I'll be on vacation, starting from tomorrow (25th of July) and
> lasting till 1st of August.
>
>
>
> Have fun with development while I'm away!
>
> WBR,
> Aleksey Bragin.
> _______________________________________________
> Ros-dev mailing list
> Ros-dev(a)reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
So, is it reverted?
iirc, I even marked those files as "shared with Wine" in the
README.WINE file. I did the merging of Wine changes once or twice
there, and it's not a big fun to go change-by-change, trace revision
when it was changed, look up why and was it a necessary change or not.
WBR,
Aleksey Bragin.
On Aug 1, 2007, at 11:05 AM, Thomas Weidenmueller wrote:
> No it's not worth the hazzle because those changes result in *NO*
> optimizations anyway. The code that was changed were calls to
> InvalidateRect to NtUserInvalidateRect. Since InvalidateRect is
> already
> forwarded to NtUserInvalidateRect this doesn't really improve
> anything,
> it's the same overhead. These changes should be reverted, not just
> because it makes no sense to optimize these function calls even more
> because they're absolutely not time-critical.
>
> Please revert.
>
> - Thomas
>
> Steven Edwards wrote:
>> On 7/31/07, greatlrd(a)svn.reactos.org <greatlrd(a)svn.reactos.org>
>> wrote:
>>> user32 cleanup lite
>>> redirect the InvalidateRect@12 to NtUserInvalidateRect@12 in the
>>> def file
>>
>>> Modified:
>>> trunk/reactos/dll/win32/user32/controls/button.c
>>> trunk/reactos/dll/win32/user32/controls/combo.c
>>
On 7/31/07, greatlrd(a)svn.reactos.org <greatlrd(a)svn.reactos.org> wrote:
> user32 cleanup lite
> redirect the InvalidateRect@12 to NtUserInvalidateRect@12 in the def file
> Modified:
> trunk/reactos/dll/win32/user32/controls/button.c
> trunk/reactos/dll/win32/user32/controls/combo.c
Is it really worth the merge hassle to change it in these two files?
They are almost 100% shared with Wine and I doubt the overhead in
calling InvalidateRect vs NtUserInvalidateRect is worth the hassle on
whoever the maintainer is going to be....
--
Steven Edwards
"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo
Hello.
This bug contains an useful patch that removes a large amount of duplicated code from taskmgr.
Sincerely,
Carlo Bramini
------------------------------------------------------
Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom
http://click.libero.it/infostrada
There was a patch on bugzilla replacing some of the greyscale images
from wine's card.dll with colored ones.
http://www.reactos.org/bugzilla/show_bug.cgi?id=2476
Ged noticed that they looked exactly like windows images. The wine
images seem to be windows images converted to greyscale.
Maybe we should replace these images. I have found an opensource project
with nice images: MacSolitaire
http://sourceforge.net/projects/macsolitairex
Noone (with exception to a few reactos devs) really bothered to actually heavily use those tests to check the developed code for errors.
If they were used from the beginning, there would be lots more supported apps by now.
Speaking on topic, updating is important, but 2 years ago means that that test isn't really updated in wine.
Wbr,
Aleksey.
-----???????? ?????????-----
??: "Daniel Reimer" <reimer.daniel(a)freenet.de>
????: "ReactOS Development List" <ros-dev(a)reactos.org>
??????????: 30.07.07 22:14
????: [ros-dev] Winetests
Hi,
I dont talk very often here, but this is, in my eyes, quite urgent. Some
days ago Magnus said he was able to fix some bugs thanks to the old
winetests we have in SVN. When I looked at the tests I saw that some had
their last update in r16000, TWO Years ago. I know its some work to port
the tests, but dont you agree that newer tests could help to find even
more bugs in ROS and that a update should be performed? If I could, I
would do so, but I'm not skilled enough yet...
Daniel "EmuandCo" Reimer
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
