Ros-dev November 2008

ros-dev@reactos.org

27 participants
42 discussions

Re: [ros-dev] [ros-diffs] [jimtabor] 37345: - Add path support for ExtTextOut.
by Steven Edwards 19 Nov '08

19 Nov '08

Dmitry, On Tue, Nov 18, 2008 at 2:22 AM, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > http://www.reactos.org/archives/public/ros-diffs/2008-November/027021.html > > Please stop copying Wine code without any copyright and source > reference into reactos. This became very bad practice from your > side during last years. I have no power with the ReactOS project other than to ask and try to get policy changed in a democratic manner. I've made the case for the ReactOS to do a better job at proper attribution in code that is imported based on feedback from you in the past. In fact, just yesterday I replied to ros-dev proposing some guidelines for how to handle code imported from Wine. There is nothing more I can do. I have CC'd Alexandre and Jeremy for there thoughts on the subject. I welcome feedback from the Software Freedom Law Center or the FSF with reguards to this issue because on one hand I understand the attribution is important but on the other hand ReactOS is persona non-grata with Wine. Given Wine's reluctance to accept any contributions from ReactOS developers, totally based on guilt by assocation I think its in your best interested not to be credited. The Software is still being released under the terms you granted so I don't see a major violation. >From the LGPL preamble: "...Also, if the library is modified by someone else and passed on, the recipients should know that what they have is not the original version, so that the original author's reputation will not be affected by problems that might be introduced by others." Clearly the ReactOS developer is doing you a favor by not hurting your reputation if ReactOS is as Toxic as Wine makes it out to be. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

5 6

Southern California Linux Expo
by Zachary Gorden 19 Nov '08

19 Nov '08

So we've been invited to SCALE and I'm wondering whether any of the devs can actually make it. Arty is a logical choice because he's so close and we might be able to pull in some community members who are close by if we can only get one dev there. We'd get a booth on the show floor which includes table, chairs, power, ethernet drop, and 3-5 passes to the show. Are we going to be able to make it this year at all?

2 1

Re: [ros-dev] [ros-diffs] [dchapyshev] 37396: - Implement BindIoCompletionCallback, ReadFileScatter, WriteFileGather (based on Wine) - Move DnsHostnameToComputerNameA/W to computername.c
by gedmurphy 19 Nov '08

19 Nov '08

Steven has repeatedly asked for credit, and I quote: " Please add the appropriate copyright headers to the source file stating the original author when implementing code based on third party sources." Is there a reason for not doing it this time? Secondly, why are things being implemented in stubs? Thirdly, it's worth checking implementations before moving out of stubs. Just because Wine does something, doesn't mean it's correct for us. DnsHostnameToComputerName should call RtlDnsHostNameToComputerName. I stopped checking the rest of the code as soon as I read that, in case someone assumes I looked at everything. Fourthly, I'm willing to bet this email gets ignored too. Please take a little more time over commits. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dchapyshev(a)svn.reactos.org Sent: 17 November 2008 11:54 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dchapyshev] 37396: - Implement BindIoCompletionCallback, ReadFileScatter, WriteFileGather (based on Wine) - Move DnsHostnameToComputerNameA/W to computername.c Author: dchapyshev Date: Mon Nov 17 05:53:59 2008 New Revision: 37396 URL: http://svn.reactos.org/svn/reactos?rev=37396&view=rev Log: - Implement BindIoCompletionCallback, ReadFileScatter, WriteFileGather (based on Wine) - Move DnsHostnameToComputerNameA/W to computername.c Modified: trunk/reactos/dll/win32/kernel32/misc/computername.c trunk/reactos/dll/win32/kernel32/misc/stubs.c Modified: trunk/reactos/dll/win32/kernel32/misc/computername.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/misc/co… ============================================================================== --- trunk/reactos/dll/win32/kernel32/misc/computername.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/misc/computername.c [iso-8859-1] Mon Nov 17 05:53:59 2008 @@ -461,4 +461,73 @@ } } + +/* + * @implemented + */ +BOOL +STDCALL +DnsHostnameToComputerNameA(LPCSTR Hostname, + LPSTR ComputerName, + LPDWORD nSize) +{ + DWORD len; + + DPRINT("(%s, %p, %p)\n", Hostname, ComputerName, nSize); + + if (!Hostname || !nSize) + return FALSE; + + len = lstrlenA(Hostname); + + if (len > MAX_COMPUTERNAME_LENGTH) + len = MAX_COMPUTERNAME_LENGTH; + + if (*nSize < len) + { + *nSize = len; + return FALSE; + } + + if (!ComputerName) return FALSE; + + memcpy( ComputerName, Hostname, len ); + ComputerName[len + 1] = 0; + return TRUE; +} + + +/* + * @implemented + */ +BOOL +STDCALL +DnsHostnameToComputerNameW ( + LPCWSTR hostname, + LPWSTR computername, + LPDWORD size + ) +{ + DWORD len; + + DPRINT("(%s, %p, %p): stub\n", hostname, computername, size); + + if (!hostname || !size) return FALSE; + len = lstrlenW(hostname); + + if (len > MAX_COMPUTERNAME_LENGTH) + len = MAX_COMPUTERNAME_LENGTH; + + if (*size < len) + { + *size = len; + return FALSE; + } + if (!computername) return FALSE; + + memcpy( computername, hostname, len * sizeof(WCHAR) ); + computername[len + 1] = 0; + return TRUE; +} + /* EOF */ Modified: trunk/reactos/dll/win32/kernel32/misc/stubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/misc/st… ============================================================================== --- trunk/reactos/dll/win32/kernel32/misc/stubs.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/misc/stubs.c [iso-8859-1] Mon Nov 17 05:53:59 2008 @@ -342,18 +342,29 @@ } /* - * @unimplemented - */ -BOOL -STDCALL -BindIoCompletionCallback ( - HANDLE FileHandle, - LPOVERLAPPED_COMPLETION_ROUTINE Function, - ULONG Flags - ) -{ - STUB; - return 0; + * @implemented + */ +BOOL +STDCALL +BindIoCompletionCallback(HANDLE FileHandle, + LPOVERLAPPED_COMPLETION_ROUTINE Function, + ULONG Flags) +{ + NTSTATUS Status = 0; + + DPRINT("(%p, %p, %d)\n", FileHandle, Function, Flags); + + Status = RtlSetIoCompletionCallback(FileHandle, + (PRTL_OVERLAPPED_COMPLETION_ROUTINE) Function, + Flags); + + if (!NT_SUCCESS(Status)) + { + SetLastError(RtlNtStatusToDosError(Status)); + return FALSE; + } + + return TRUE; } /* @@ -562,20 +573,45 @@ } /* - * @unimplemented - */ -BOOL -STDCALL -ReadFileScatter( - HANDLE hFile, - FILE_SEGMENT_ELEMENT aSegmentArray[], - DWORD nNumberOfBytesToRead, - LPDWORD lpReserved, - LPOVERLAPPED lpOverlapped - ) -{ - STUB; - return 0; + * @implemented + */ +BOOL +STDCALL +ReadFileScatter(HANDLE hFile, + FILE_SEGMENT_ELEMENT aSegmentArray[], + DWORD nNumberOfBytesToRead, + LPDWORD lpReserved, + LPOVERLAPPED lpOverlapped) +{ + PIO_STATUS_BLOCK pIOStatus; + LARGE_INTEGER Offset; + NTSTATUS Status; + + DPRINT("(%p %p %u %p)\n", hFile, aSegmentArray, nNumberOfBytesToRead, lpOverlapped); + + Offset.LowPart = lpOverlapped->Offset; + Offset.HighPart = lpOverlapped->OffsetHigh; + pIOStatus = (PIO_STATUS_BLOCK) lpOverlapped; + pIOStatus->Status = STATUS_PENDING; + pIOStatus->Information = 0; + + Status = NtReadFileScatter(hFile, + NULL, + NULL, + NULL, + pIOStatus, + aSegmentArray, + nNumberOfBytesToRead, + &Offset, + NULL); + + if (!NT_SUCCESS(Status)) + { + SetLastError(RtlNtStatusToDosError(Status)); + return FALSE; + } + + return TRUE; } /* @@ -678,20 +714,45 @@ } /* - * @unimplemented - */ -BOOL -STDCALL -WriteFileGather( - HANDLE hFile, - FILE_SEGMENT_ELEMENT aSegmentArray[], - DWORD nNumberOfBytesToWrite, - LPDWORD lpReserved, - LPOVERLAPPED lpOverlapped - ) -{ - STUB; - return 0; + * @implemented + */ +BOOL +STDCALL +WriteFileGather(HANDLE hFile, + FILE_SEGMENT_ELEMENT aSegmentArray[], + DWORD nNumberOfBytesToWrite, + LPDWORD lpReserved, + LPOVERLAPPED lpOverlapped) +{ + PIO_STATUS_BLOCK IOStatus; + LARGE_INTEGER Offset; + NTSTATUS Status; + + DPRINT("%p %p %u %p\n", hFile, aSegmentArray, nNumberOfBytesToWrite, lpOverlapped); + + Offset.LowPart = lpOverlapped->Offset; + Offset.HighPart = lpOverlapped->OffsetHigh; + IOStatus = (PIO_STATUS_BLOCK) lpOverlapped; + IOStatus->Status = STATUS_PENDING; + IOStatus->Information = 0; + + Status = NtWriteFileGather(hFile, + NULL, + NULL, + NULL, + IOStatus, + aSegmentArray, + nNumberOfBytesToWrite, + &Offset, + NULL); + + if (!NT_SUCCESS(Status)) + { + SetLastError(RtlNtStatusToDosError(Status)); + return FALSE; + } + + return TRUE; } /* @@ -705,39 +766,6 @@ { STUB; return 0; -} - -/* - * @unimplemented - */ -BOOL -STDCALL -DnsHostnameToComputerNameW ( - LPCWSTR hostname, - LPWSTR computername, - LPDWORD size - ) -{ - DWORD len; - - DPRINT("(%s, %p, %p): stub\n", hostname, computername, size); - - if (!hostname || !size) return FALSE; - len = lstrlenW(hostname); - - if (len > MAX_COMPUTERNAME_LENGTH) - len = MAX_COMPUTERNAME_LENGTH; - - if (*size < len) - { - *size = len; - return FALSE; - } - if (!computername) return FALSE; - - memcpy( computername, hostname, len * sizeof(WCHAR) ); - computername[len + 1] = 0; - return TRUE; } /* @@ -919,21 +947,6 @@ /* * @unimplemented */ -BOOL -STDCALL -DnsHostnameToComputerNameA ( - LPCSTR Hostname, - LPSTR ComputerName, - LPDWORD nSize - ) -{ - STUB; - return 0; -} - -/* - * @unimplemented - */ HANDLE STDCALL FindFirstVolumeMountPointA( @@ -947,23 +960,22 @@ } /* - * @unimplemented - */ -BOOL -STDCALL -FindNextVolumeA( - HANDLE handle, - LPSTR volume, - DWORD len - ) -{ - WCHAR *buffer = HeapAlloc( GetProcessHeap(), 0, len * sizeof(WCHAR) ); + * @implemented + */ +BOOL +STDCALL +FindNextVolumeA(HANDLE handle, + LPSTR volume, + DWORD len) +{ + WCHAR *buffer = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); BOOL ret; if ((ret = FindNextVolumeW( handle, buffer, len ))) { if (!WideCharToMultiByte( CP_ACP, 0, buffer, -1, volume, len, NULL, NULL )) ret = FALSE; } + HeapFree( GetProcessHeap(), 0, buffer ); return ret; }

4 5

Re: [ros-dev] [ros-diffs] [jimtabor] 37436: - Fixes bug 3864. While I was at it I fixed most of the gdi max bit max info sizes too. - Added notes for the SEH abuse in win32k dibobj.c. - Tested WinMerge 2.10.2, AbiWord 2.4.1, Firefox 1.5.0.3 and wine gdi32 bitmap cross test. - When testing with gdi cross test in 24 and 32 bit display mode, we have a pixel conversion mismatch. Please fix it!
by Aleksey Bragin 18 Nov '08

18 Nov '08

May I ask why those if (!Info) checks are required? To me it makes no sense to call those APIs with the cruicial, mandatory working (and in one case the only) parameter being NULL, and I would put an ASSERT (Info) there to catch bad callers and fix them. WBR, Aleksey. On Nov 18, 2008, at 8:36 AM, jimtabor(a)svn.reactos.org wrote: > Author: jimtabor > Date: Mon Nov 17 23:36:19 2008 > New Revision: 37436 > > UINT > FASTCALL > DIB_BitmapMaxBitsSize( PBITMAPINFO Info, UINT ScanLines ) > { > UINT MaxBits = 0; > + > + if (!Info) return 0; > > > +UINT > +FASTCALL > +DIB_BitmapBitsSize( PBITMAPINFO Info ) > +{ > + UINT Ret; > + > + if (!Info) return 0;

1 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 37431: forgot this file
by Matthieu Suiche 18 Nov '08

18 Nov '08

+ return !!(Flags & EFLAGS_INTERRUPT_MASK); Why do you donnot use something like that instead ? return (Flags & EFLAGS_INTERRUPT_MASK) ? TRUE: FALSE; -- Matthieu Suiche On Tue, Nov 18, 2008 at 3:27 AM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Mon Nov 17 20:27:04 2008 > New Revision: 37431 > > URL: http://svn.reactos.org/svn/reactos?rev=37431&view=rev > Log: > forgot this file > > Added: > branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/interrupt.c (with props) > > Added: branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/interrupt.c > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk… > ============================================================================== > --- branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/interrupt.c (added) > +++ branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/interrupt.c [iso-8859-1] Mon Nov 17 20:27:04 2008 > @@ -1,0 +1,62 @@ > +/* > + * PROJECT: ReactOS Kernel > + * LICENSE: GPL - See COPYING in the top level directory > + * FILE: ntoskrnl/ke/i386/irq.c > + * PURPOSE: Manages the Kernel's IRQ support for external drivers, > + * for the purpopses of connecting, disconnecting and setting > + * up ISRs for drivers. The backend behind the Io* Interrupt > + * routines. > + * PROGRAMMERS: Timo Kreuzer (timo.kreuzer(a)web.de) > + */ > + > +/* INCLUDES *****************************************************************/ > + > +#include <ntoskrnl.h> > +#define NDEBUG > +#include <debug.h> > + > +/* FUNCTIONS ****************************************************************/ > + > + > + > +BOOLEAN > +NTAPI > +KeDisableInterrupts(VOID) > +{ > + ULONG64 Flags; > + > + /* Get the flags */ > + Flags = __readeflags(); > + > + /* Disable interrupts */ > + _disable(); > + > + return !!(Flags & EFLAGS_INTERRUPT_MASK); > +} > + > + > +BOOLEAN > +NTAPI > +KeDisconnectInterrupt(IN PKINTERRUPT Interrupt) > +{ > + UNIMPLEMENTED; > + return FALSE; > +} > + > +VOID > +NTAPI > +KeInitializeInterrupt(IN PKINTERRUPT Interrupt, > + IN PKSERVICE_ROUTINE ServiceRoutine, > + IN PVOID ServiceContext, > + IN PKSPIN_LOCK SpinLock, > + IN ULONG Vector, > + IN KIRQL Irql, > + IN KIRQL SynchronizeIrql, > + IN KINTERRUPT_MODE InterruptMode, > + IN BOOLEAN ShareVector, > + IN CHAR ProcessorNumber, > + IN BOOLEAN FloatingSave) > +{ > + UNIMPLEMENTED; > +} > + > > Propchange: branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/interrupt.c > ------------------------------------------------------------------------------ > svn:eol-style = native > >

1 0

Another WIDL sync, another build breakage
by Olaf Siejka 17 Nov '08

17 Nov '08

This is just getting repetitive: [WIDL] obj-i386\include\reactos\idl\lsa_c.c include\reactos\idl\lsa.idl:17: Error: NTSTATUS: redefinition error; original definition was at ( ť: 21 mingw32-make: *** [obj-i386\include\reactos\idl\lsa_c.c] Error 1 mingw32-make: *** Waiting for unfinished jobs.... [WIDL] obj-i386\include\reactos\idl\eventlogrpc_c.c include\reactos\idl\eventlogrpc.idl:7: Error: NTSTATUS: redefinition error; original definition was at Ş■.:21 mingw32-make: *** [obj-i386\include\reactos\idl\eventlogrpc_c.c] Error 1 With all due respect, Eric, would you be so kind and test your commits on more OS than your PC/buildbot???

1 0

Re: [ros-dev] [ros-diffs] [greatlrd] 37343: Bugfix : Do not link to LPDDRAWI_DIRECTDRAW_INT->lpLink when we do not have any LPDDRAWI_DIRECTDRAW_INT->lpLcl
by gedmurphy 16 Nov '08

16 Nov '08

Is it not time to start getting rid of IsBadWritePtr and friends? I don't see a good reason for these in our own code, especially when we can just use SEH directly. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of greatlrd(a)svn.reactos.org Sent: 13 November 2008 19:52 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [greatlrd] 37343: Bugfix : Do not link to LPDDRAWI_DIRECTDRAW_INT->lpLink when we do not have any LPDDRAWI_DIRECTDRAW_INT->lpLcl Author: greatlrd Date: Thu Nov 13 13:52:20 2008 New Revision: 37343 URL: http://svn.reactos.org/svn/reactos?rev=37343&view=rev Log: Bugfix : Do not link to LPDDRAWI_DIRECTDRAW_INT->lpLink when we do not have any LPDDRAWI_DIRECTDRAW_INT->lpLcl Modified: branches/reactx/reactos/dll/directx/ddraw/startup.c Modified: branches/reactx/reactos/dll/directx/ddraw/startup.c URL: http://svn.reactos.org/svn/reactos/branches/reactx/reactos/dll/directx/ddra… ============================================================================== --- branches/reactx/reactos/dll/directx/ddraw/startup.c [iso-8859-1] (original) +++ branches/reactx/reactos/dll/directx/ddraw/startup.c [iso-8859-1] Thu Nov 13 13:52:20 2008 @@ -33,8 +33,8 @@ This = (LPDDRAWI_DIRECTDRAW_INT)*pIface; - /* fixme linking too second link when we shall not doing it */ - if (IsBadReadPtr(This,sizeof(LPDIRECTDRAW))) + if ( (IsBadWritePtr(This,sizeof(LPDDRAWI_DIRECTDRAW_INT)) != 0) || + (IsBadWritePtr(This->lpLcl,sizeof(LPDDRAWI_DIRECTDRAW_LCL)) != 0) ) { /* We do not have a DirectDraw interface, we need alloc it*/ LPDDRAWI_DIRECTDRAW_INT memThis;

5 5

[WIDL] Problems with latest sync
by Olaf Siejka 16 Nov '08

16 Nov '08

Since revisions 37313-37314 i observe repetitive problems with WIDL. Every time WIDL is called by our BE, it throws an exception: Faulting application widl.exe, version 0.0.0.0, time stamp 0x491c610d, faulting module widl.exe, version 0.0.0.0, time stamp 0x491c610d, exception code 0xc0000005, fault offset 0x00005f0a, process id 0x17f8, application start time 0x01c945b3aefa8530. > [WIDL] obj-i386\include\reactos\idl\svcctl_s.c > [WIDL] obj-i386\include\reactos\idl\svcctl_s.h > mingw32-make: *** Waiting for unfinished jobs.... > mingw32-make: *** [obj-i386\include\reactos\idl\svcctl_s.h] Error -1073741819 (0xC0000005) > mingw32-make: *** [obj-i386\include\reactos\idl\svcctl_s.c] Error -1073741819 (0xC0000005) Reverting revisions 37313 and 37314 fixes this problem. Apart from me, this issue been noted by dreimer, encoded and Christoph_vW. Dunno about Christoph, but me, dreimer and encoded are using Vista/2008. I couldnt replicate this issue on XP/2003 though.

3 2

1st stage GUI setup and file system managment
by Matthias Kupfer 13 Nov '08

13 Nov '08

Hi folks, during the development of the 1st-stage-GUI-setup I experienced some problems with physical drive detection with reactos api (because it's fairly incomplete - it works under windows). To continue the development and to bring more benefits I want to make following suggestion. Sooner or later we need a drive/volume/partition management tool, so i will continue with this basing on the usetup code and replaced later by working reactos api calls. So we can use this tool to determine the current harddisk(s) layout(s), create/delete partitions, format with different file systems and show/install/configure the current boot loader. Later I can use this functions to handle the drives during installation process in a similiar way. What do you think about this plan? Matt -- Matthias Kupfer Telefon +49 (0) 371 236 46 52 Wilhelm-Firl-Straße 21 Mobil +49 (0) 160 859 43 54 09122 Chemnitz

2 1

Add a linkerflag to make sure we get an .eh_frame section
by Dmitry Gorbachev 12 Nov '08

12 Nov '08

Hi, > Todo: Get it at the end of the executable, so we can safely remove it. I think it can be safely removed from inside of the executable — just wasting some address space.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev November 2008