Hello,
this message is inspired by a lot of thinking, and yesterdays talk in
#reactos, when Magnus Olsen's proposition to add support for more
than one graphic adapter was a last drop into my cup of tolerancy.
Thus I want to say, one very important idea. But what I want even
more, for our developers to understand it. The key idea is that our
work on the project now MUST be aimed at bugfixing, not at adding
even more nice features. There are already quite enough of them
(features)!
As I said 1000 times, our general "users" don't care about ability to
insert 3 graphic cards into their PC, and get ReactOS using them!
They care about ReactOS crashing after closing regedit. Or during
Office 2003 installation. And if it continues to crash this way, I'm
sorry, but noone could feel the pleasure of multiple graphic cards
support, or any other feature which is useless for 99% of potential
users.
Moreover, I don't understand why noone ever bothered to work through
the winetests for reactos-specific parts of the system, like GDI,
user32/win32k testing, kernel32 testing. There are lots of failures,
and wine test results show APIs which are used for REAL, and by REAL
applications, not some historic APIs implemented by Magnus (no
offence, I'm just using him as an example, please excuse me if I
sound harsh anywhere) which are unused by any real application nowadays.
I clearly want to stress, that there is a strong misconcept in
ReactOS way of development of its Win32 subsystem. There were a lot
of positive events happening (win32k native tests library, great work
by Timo at fixing various small issues, handles, memory leaks, etc).
But it must be continued!
Ged Murphy said very right about the problem: small problems prevent
big apps from working. Wine already supports Office 2003 for years,
and noone except me was trying to make support it better. The same
applies to everywhere, there is no need to have some special skills
to improve ReactOS. You know, there are not that many people who
*really* worked on win32k in Microsoft, and they obviously can't code
for us anyway, so everyone had to learn how to develop one or another
part of the system. Look at Stefan Ginsberg - a guy who didn't know
anything about C development 3 months ago, but learnt just by reading
ros-diffs (well, and constant private messaging me in IRC asking
questions, but that doesn't count), and yesterday spotted a couple of
important real problems.
Especially that counts for Win32-subsystem (the kernel must stay as
strict NT-alike as legally possible, so it takes time to read all
available literature), but for Win32-subsystem, just maintaining its
code would result in a hundred less crashes now! I don't even say
about rewriting bad written parts. Or just simply, very-very simply,
syncing Wine's changes back into ReactOS!
But nobody cares to do that.
I especially delay the 0.3.5 release, because I want people to
concentrate more on bugfixes. We could easily release in the
beginning of may, there are enough of good changes for a usual
reactos release. But I want this particular release to be *unusual*.
If ReactOS wants to hit beta this year, developers must concentrate
on a boring work first, believe me, there will be lots more fun when
amount of people trying out reactos increases at least 100x.
And if no beta this year, I'm sorry to say, but it may be too late.
Thanks for thorough reading. Comments are welcome.
With the best regards,
Aleksey Bragin.
Actually this change may not be enough to fix the underlying issue. I
believe there are some cases when straight calling of IoVerifyVolume
could lead to deadlock. Maybe someone can lend a helping hand here and
verify if the code is actually correct? If not I will probably get to
it myself, but it may take a few days or even weeks.
Thanks,
Filip
On Sun, May 11, 2008 at 10:04 PM, <navaraf(a)svn.reactos.org> wrote:
> Author: navaraf
> Date: Sun May 11 15:04:47 2008
> New Revision: 33449
>
> URL: http://svn.reactos.org/svn/reactos?rev=33449&view=rev
> Log:
> Fix incorrect parameters to IoSetDeviceToVerify/IoVerifyVolume. Spotted by R.T.Sivakumar <rtshiva(a)gmail.com>.
>
> Modified:
> trunk/reactos/drivers/filesystems/fastfat/create.c
>
> Modified: trunk/reactos/drivers/filesystems/fastfat/create.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa…
> ==============================================================================
> --- trunk/reactos/drivers/filesystems/fastfat/create.c [iso-8859-1] (original)
> +++ trunk/reactos/drivers/filesystems/fastfat/create.c [iso-8859-1] Sun May 11 15:04:47 2008
> @@ -382,11 +382,10 @@
> DPRINT ("Media change detected!\n");
> DPRINT ("Device %p\n", DeviceExt->StorageDevice);
>
> + /* Find the device to verify and reset the thread field to empty value again. */
> DeviceToVerify = IoGetDeviceToVerify (PsGetCurrentThread ());
> -
> - IoSetDeviceToVerify (PsGetCurrentThread (),
> - NULL);
> - Status = IoVerifyVolume (DeviceExt->StorageDevice,
> + IoSetDeviceToVerify (PsGetCurrentThread (), NULL);
> + Status = IoVerifyVolume (DeviceToVerify,
> FALSE);
> }
> if (!NT_SUCCESS(Status))
>
>
This was created for all win32k/gdi32 work which is done without any
particular goal, or for directx-related work (dxeng is allowed to go
into trunk directly).
WBR,
Aleksey Bragin.
On May 11, 2008, at 3:03 PM, fireball(a)svn.reactos.org wrote:
> Author: fireball
> Date: Sun May 11 06:03:57 2008
> New Revision: 33435
>
> URL: http://svn.reactos.org/svn/reactos?rev=33435&view=rev
> Log:
> Creating a branch for Magnus Olsen's work in win32k, GDI and
> DirectX area. Finished parts will be merged back to trunk.
>
> Added:
> branches/win32k-gdi-dx/
> - copied from r33434, /
>
"DC_BITMAP or the value are not documented in MSDN or ms header" ...
and that's precisely why the definition belongs to another (internal)
header file and not here.
F.
On Sat, May 10, 2008 at 7:37 PM, <greatlrd(a)svn.reactos.org> wrote:
> Author: greatlrd
> Date: Sat May 10 12:37:43 2008
> New Revision: 33411
>
> URL: http://svn.reactos.org/svn/reactos?rev=33411&view=rev
> Log:
> adding a new define DC_BITMAP for GetStockObject
>
> Modified:
> trunk/reactos/include/psdk/wingdi.h
>
> Modified: trunk/reactos/include/psdk/wingdi.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/wingdi.h?rev=…
> ==============================================================================
> --- trunk/reactos/include/psdk/wingdi.h [iso-8859-1] (original)
> +++ trunk/reactos/include/psdk/wingdi.h [iso-8859-1] Sat May 10 12:37:43 2008
> @@ -813,6 +813,12 @@
> #define SYSTEM_FONT 13
> #define SYSTEM_FIXED_FONT 16
> #define DEFAULT_PALETTE 15
> +
> +/* NOTE DC_BITMAP or the value are not documented in MSDN or ms header
> + * it return a 1x1 1Bpp Bitmap in all case from GetStockObject
> + */
> +#define DC_BITMAP 21
> +
> #if (_WIN32_WINNT >= 0x0500)
> #define DC_BRUSH 18
> #define DC_PEN 19
>
>
Hi devs,
I don't think this patch should be refused, what about "Shell32 improvements" in: http://www.reactos.org/en/newsletter_34.html?
And all the commits made recently by johannes (also in shlview.c)? After almost a year we close the bug saying it's not our code?
WBR
Gabriel ilardi.
> Date: Fri, 9 May 2008 18:13:49 +0200> From: ReactOS.Bugzilla(a)www.reactos.org> To: ros-bugs(a)reactos.org> Subject: [ros-bugs] [Bug 644] directional keys problem with Explorer> > http://www.reactos.org/bugzilla/show_bug.cgi?id=644> > > amine48rz <amine48rz(a)gmail.com> changed:> > What |Removed |Added> ----------------------------------------------------------------------------> Status|NEW |ASSIGNED> Status|ASSIGNED |NEW> CC| |amine48rz(a)gmail.com> AssignedTo|info(a)w3seek.de |johannes.anderwald(a)student.t> | |ugraz.at> > w3seek <w3seek(a)reactos.com> changed:> > What |Removed |Added> ----------------------------------------------------------------------------> CC| |w3seek(a)reactos.com> Status|NEW |RESOLVED> Resolution| |WONTFIX> > > > > --- Comment #3 from w3seek <w3seek(a)reactos.com> 2008-05-09 18:13:48 CET ---> (In reply to comment #2)> > Created an attachment (id=1341)> --> (http://www.reactos.org/bugzilla/attachment.cgi?id=1341) [details]> > LISTVIEW_GetNextItem Patch> > Here's a new patch for which i rewrote the LISTVIEW_GetNextItem routine, so> > that the ListView itself is aware of whether LVS_ALIGNTOP or LVS_ALIGNLEFT is> > set and returns the correct next item.> > But I still like the other patch just because I dislike scrolling horizontal in> > a list :).> > This patch should not be accepted for ReactOS. This is code shared with WINE> and needs to be submitted to winehq.> > > -- > Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email> ------- You are receiving this mail because: -------> You are the QA contact for the bug.> _______________________________________________> Ros-bugs mailing list> Ros-bugs(a)reactos.org> http://www.reactos.org/mailman/listinfo/ros-bugs
_________________________________________________________________
Crea il tuo blog su Spaces, condividi le tue esperienze con il mondo!
http://home.services.spaces.live.com/
Hi everybody,
I tracked down the Explorer startup crash we experience since r33366 and
came to some weird results.
First of all, this crash also occurs when testing under Windows. Also
Explorer runs well when it's compiled with MSVC using the supplied
"explorer.sln" file.
Then I put MessageBoxes to some code pathes to track down, where the crash
occurs.
The weird thing is: It fails in the IconCache code (which doesn't even
handle strings, so shouldn't be affected by Unicode at all).
Just put a MessageBox at explorer.cpp:389 and then after _icons[ICID_NONE]
was assigned. You will see that the second message box won't appear.
You can also put a MessageBox in the Icon constructor, it won't be shown
either.
So what's going wrong here?
Bug in our mingw startup routine, memory corruption, bug in gcc, ...? I'm
out of ideas.
Best regards,
Colin
Hi folks,
I'd like to try Reactos in Xen. Is there any image available ?
thx
--
---------------------------------------------------------------------
Enrico Weigelt == metux IT service - http://www.metux.de/
---------------------------------------------------------------------
Please visit the OpenSource QM Taskforce:
http://wiki.metux.de/public/OpenSource_QM_Taskforce
Patches / Fixes for a lot dozens of packages in dozens of versions:
http://patches.metux.de/
---------------------------------------------------------------------
On Tue, May 6, 2008 at 12:15 PM, <gbrunmar(a)svn.reactos.org> wrote:
> + if (IsBadWritePtr(pMode, sizeof(D3DDISPLAYMODE*)))
Is this really a good idea?
--
Steven Edwards
"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo