Ros-dev May 2008

ros-dev@reactos.org

22 participants
29 discussions

Time has come, a call to developers
by Aleksey Bragin 12 May '08

12 May '08

Hello, this message is inspired by a lot of thinking, and yesterdays talk in #reactos, when Magnus Olsen's proposition to add support for more than one graphic adapter was a last drop into my cup of tolerancy. Thus I want to say, one very important idea. But what I want even more, for our developers to understand it. The key idea is that our work on the project now MUST be aimed at bugfixing, not at adding even more nice features. There are already quite enough of them (features)! As I said 1000 times, our general "users" don't care about ability to insert 3 graphic cards into their PC, and get ReactOS using them! They care about ReactOS crashing after closing regedit. Or during Office 2003 installation. And if it continues to crash this way, I'm sorry, but noone could feel the pleasure of multiple graphic cards support, or any other feature which is useless for 99% of potential users. Moreover, I don't understand why noone ever bothered to work through the winetests for reactos-specific parts of the system, like GDI, user32/win32k testing, kernel32 testing. There are lots of failures, and wine test results show APIs which are used for REAL, and by REAL applications, not some historic APIs implemented by Magnus (no offence, I'm just using him as an example, please excuse me if I sound harsh anywhere) which are unused by any real application nowadays. I clearly want to stress, that there is a strong misconcept in ReactOS way of development of its Win32 subsystem. There were a lot of positive events happening (win32k native tests library, great work by Timo at fixing various small issues, handles, memory leaks, etc). But it must be continued! Ged Murphy said very right about the problem: small problems prevent big apps from working. Wine already supports Office 2003 for years, and noone except me was trying to make support it better. The same applies to everywhere, there is no need to have some special skills to improve ReactOS. You know, there are not that many people who *really* worked on win32k in Microsoft, and they obviously can't code for us anyway, so everyone had to learn how to develop one or another part of the system. Look at Stefan Ginsberg - a guy who didn't know anything about C development 3 months ago, but learnt just by reading ros-diffs (well, and constant private messaging me in IRC asking questions, but that doesn't count), and yesterday spotted a couple of important real problems. Especially that counts for Win32-subsystem (the kernel must stay as strict NT-alike as legally possible, so it takes time to read all available literature), but for Win32-subsystem, just maintaining its code would result in a hundred less crashes now! I don't even say about rewriting bad written parts. Or just simply, very-very simply, syncing Wine's changes back into ReactOS! But nobody cares to do that. I especially delay the 0.3.5 release, because I want people to concentrate more on bugfixes. We could easily release in the beginning of may, there are enough of good changes for a usual reactos release. But I want this particular release to be *unusual*. If ReactOS wants to hit beta this year, developers must concentrate on a boring work first, believe me, there will be lots more fun when amount of people trying out reactos increases at least 100x. And if no beta this year, I'm sorry to say, but it may be too late. Thanks for thorough reading. Comments are welcome. With the best regards, Aleksey Bragin.

8 14

Re: [ros-dev] [ros-diffs] [navaraf] 33449: Fix incorrect parameters to IoSetDeviceToVerify/IoVerifyVolume. Spotted by R.T.Sivakumar <rtshiva@gmail.com>.
by Filip Navara 11 May '08

11 May '08

Actually this change may not be enough to fix the underlying issue. I believe there are some cases when straight calling of IoVerifyVolume could lead to deadlock. Maybe someone can lend a helping hand here and verify if the code is actually correct? If not I will probably get to it myself, but it may take a few days or even weeks. Thanks, Filip On Sun, May 11, 2008 at 10:04 PM, <navaraf(a)svn.reactos.org> wrote: > Author: navaraf > Date: Sun May 11 15:04:47 2008 > New Revision: 33449 > > URL: http://svn.reactos.org/svn/reactos?rev=33449&view=rev > Log: > Fix incorrect parameters to IoSetDeviceToVerify/IoVerifyVolume. Spotted by R.T.Sivakumar <rtshiva(a)gmail.com>. > > Modified: > trunk/reactos/drivers/filesystems/fastfat/create.c > > Modified: trunk/reactos/drivers/filesystems/fastfat/create.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fastfat/create.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fastfat/create.c [iso-8859-1] Sun May 11 15:04:47 2008 > @@ -382,11 +382,10 @@ > DPRINT ("Media change detected!\n"); > DPRINT ("Device %p\n", DeviceExt->StorageDevice); > > + /* Find the device to verify and reset the thread field to empty value again. */ > DeviceToVerify = IoGetDeviceToVerify (PsGetCurrentThread ()); > - > - IoSetDeviceToVerify (PsGetCurrentThread (), > - NULL); > - Status = IoVerifyVolume (DeviceExt->StorageDevice, > + IoSetDeviceToVerify (PsGetCurrentThread (), NULL); > + Status = IoVerifyVolume (DeviceToVerify, > FALSE); > } > if (!NT_SUCCESS(Status)) > >

1 0

Re: [ros-dev] [ros-diffs] [fireball] 33435: Creating a branch for Magnus Olsen's work in win32k, GDI and DirectX area. Finished parts will be merged back to trunk.
by Aleksey Bragin 11 May '08

11 May '08

This was created for all win32k/gdi32 work which is done without any particular goal, or for directx-related work (dxeng is allowed to go into trunk directly). WBR, Aleksey Bragin. On May 11, 2008, at 3:03 PM, fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Sun May 11 06:03:57 2008 > New Revision: 33435 > > URL: http://svn.reactos.org/svn/reactos?rev=33435&view=rev > Log: > Creating a branch for Magnus Olsen's work in win32k, GDI and > DirectX area. Finished parts will be merged back to trunk. > > Added: > branches/win32k-gdi-dx/ > - copied from r33434, / >

1 0

Re: [ros-dev] [ros-diffs] [greatlrd] 33411: adding a new define DC_BITMAP for GetStockObject
by Filip Navara 10 May '08

10 May '08

"DC_BITMAP or the value are not documented in MSDN or ms header" ... and that's precisely why the definition belongs to another (internal) header file and not here. F. On Sat, May 10, 2008 at 7:37 PM, <greatlrd(a)svn.reactos.org> wrote: > Author: greatlrd > Date: Sat May 10 12:37:43 2008 > New Revision: 33411 > > URL: http://svn.reactos.org/svn/reactos?rev=33411&view=rev > Log: > adding a new define DC_BITMAP for GetStockObject > > Modified: > trunk/reactos/include/psdk/wingdi.h > > Modified: trunk/reactos/include/psdk/wingdi.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/wingdi.h?rev=… > ============================================================================== > --- trunk/reactos/include/psdk/wingdi.h [iso-8859-1] (original) > +++ trunk/reactos/include/psdk/wingdi.h [iso-8859-1] Sat May 10 12:37:43 2008 > @@ -813,6 +813,12 @@ > #define SYSTEM_FONT 13 > #define SYSTEM_FIXED_FONT 16 > #define DEFAULT_PALETTE 15 > + > +/* NOTE DC_BITMAP or the value are not documented in MSDN or ms header > + * it return a 1x1 1Bpp Bitmap in all case from GetStockObject > + */ > +#define DC_BITMAP 21 > + > #if (_WIN32_WINNT >= 0x0500) > #define DC_BRUSH 18 > #define DC_PEN 19 > >

2 1

FW: [ros-bugs] [Bug 644] directional keys problem with Explorer
by Gabriel ilardi 09 May '08

09 May '08

Hi devs, I don't think this patch should be refused, what about "Shell32 improvements" in: http://www.reactos.org/en/newsletter_34.html? And all the commits made recently by johannes (also in shlview.c)? After almost a year we close the bug saying it's not our code? WBR Gabriel ilardi. > Date: Fri, 9 May 2008 18:13:49 +0200> From: ReactOS.Bugzilla(a)www.reactos.org> To: ros-bugs(a)reactos.org> Subject: [ros-bugs] [Bug 644] directional keys problem with Explorer> > http://www.reactos.org/bugzilla/show_bug.cgi?id=644> > > amine48rz <amine48rz(a)gmail.com> changed:> > What |Removed |Added> ----------------------------------------------------------------------------> Status|NEW |ASSIGNED> Status|ASSIGNED |NEW> CC| |amine48rz(a)gmail.com> AssignedTo|info(a)w3seek.de |johannes.anderwald(a)student.t> | |ugraz.at> > w3seek <w3seek(a)reactos.com> changed:> > What |Removed |Added> ----------------------------------------------------------------------------> CC| |w3seek(a)reactos.com> Status|NEW |RESOLVED> Resolution| |WONTFIX> > > > > --- Comment #3 from w3seek <w3seek(a)reactos.com> 2008-05-09 18:13:48 CET ---> (In reply to comment #2)> > Created an attachment (id=1341)> --> (http://www.reactos.org/bugzilla/attachment.cgi?id=1341) [details]> > LISTVIEW_GetNextItem Patch> > Here's a new patch for which i rewrote the LISTVIEW_GetNextItem routine, so> > that the ListView itself is aware of whether LVS_ALIGNTOP or LVS_ALIGNLEFT is> > set and returns the correct next item.> > But I still like the other patch just because I dislike scrolling horizontal in> > a list :).> > This patch should not be accepted for ReactOS. This is code shared with WINE> and needs to be submitted to winehq.> > > -- > Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email> ------- You are receiving this mail because: -------> You are the QA contact for the bug.> _______________________________________________> Ros-bugs mailing list> Ros-bugs(a)reactos.org> http://www.reactos.org/mailman/listinfo/ros-bugs _________________________________________________________________ Crea il tuo blog su Spaces, condividi le tue esperienze con il mondo! http://home.services.spaces.live.com/

2 1

Explorer startup crash since r33366
by Colin Finck 08 May '08

08 May '08

Hi everybody, I tracked down the Explorer startup crash we experience since r33366 and came to some weird results. First of all, this crash also occurs when testing under Windows. Also Explorer runs well when it's compiled with MSVC using the supplied "explorer.sln" file. Then I put MessageBoxes to some code pathes to track down, where the crash occurs. The weird thing is: It fails in the IconCache code (which doesn't even handle strings, so shouldn't be affected by Unicode at all). Just put a MessageBox at explorer.cpp:389 and then after _icons[ICID_NONE] was assigned. You will see that the second message box won't appear. You can also put a MessageBox in the Icon constructor, it won't be shown either. So what's going wrong here? Bug in our mingw startup routine, memory corruption, bug in gcc, ...? I'm out of ideas. Best regards, Colin

2 1

Re: [ros-dev] [ros-diffs] [mpiulachs] 33344: - code refactoring - made more and more easily extensible: * commands automatically loaded from plugins dlls * declarative and automatic command parameter parsing * common code moved to base classes - other fixes
by Filip Navara 08 May '08

08 May '08

This commit actually broke TechBot badly. Not only the commands don't work anymore because the parameter parsing fails somewhere in ParametersParser.HandleSwitches (for eg. !rosbug 333 or !ntstatus 2307), but also some of the commands (!ntstatus, !wm and probably !winerror) aren't guarded for the case when no parameters are passed and crash horribly with NullReferenceException. I am not going to fix it since I don't like digging into regular expressions, but I would be glad if someone could look at it. I'll bring MyTechBot back online once the bugs are fixed. Best regards, Filip Navara On Wed, May 7, 2008 at 4:59 PM, <mpiulachs(a)svn.reactos.org> wrote: > Author: mpiulachs > Date: Wed May 7 09:59:28 2008 > New Revision: 33344 > > URL: http://svn.reactos.org/svn/reactos?rev=33344&view=rev > Log: > - code refactoring > - made more and more easily extensible: > * commands automatically loaded from plugins dlls > * declarative and automatic command parameter parsing > * common code moved to base classes > - other fixes > > Added: > trunk/irc/TechBot/TechBot.Console/ConsoleTechBotService.cs (with props) > trunk/irc/TechBot/TechBot.Library/Attributes/ > trunk/irc/TechBot/TechBot.Library/Attributes/CommandAttribute.cs (with props) > trunk/irc/TechBot/TechBot.Library/Attributes/CommandParameterAliasAttribute.cs (with props) > trunk/irc/TechBot/TechBot.Library/Attributes/CommandParameterAttribute.cs (with props) > trunk/irc/TechBot/TechBot.Library/Collections/ > trunk/irc/TechBot/TechBot.Library/Collections/CommandBuilderCollection.cs (with props) > trunk/irc/TechBot/TechBot.Library/Commands/ApiCommand.cs (contents, props changed) > - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/ApiCommand.cs > trunk/irc/TechBot/TechBot.Library/Commands/Base/Command.cs > - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/Command.cs > trunk/irc/TechBot/TechBot.Library/Commands/Base/XmlLookupCommand.cs (with props) > trunk/irc/TechBot/TechBot.Library/Commands/BugCommand.cs (contents, props changed) > - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/BugCommand.cs > trunk/irc/TechBot/TechBot.Library/Commands/ErrorCommand.cs (contents, props changed) > - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/ErrorCommand.cs > trunk/irc/TechBot/TechBot.Library/Commands/HelpCommand.cs (contents, props changed) > - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/HelpCommand.cs > trunk/irc/TechBot/TechBot.Library/Commands/HresultCommand.cs (contents, props changed) > - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/HresultCommand.cs > trunk/irc/TechBot/TechBot.Library/Commands/NtStatusCommand.cs (contents, props changed) > - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/NtStatusCommand.cs > trunk/irc/TechBot/TechBot.Library/Commands/ReactOSBugUrl.cs > - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/ReactOSBugUrl.cs > trunk/irc/TechBot/TechBot.Library/Commands/SambaBugUrl.cs > - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/SambaBugUrl.cs > trunk/irc/TechBot/TechBot.Library/Commands/SvnCommand.cs (contents, props changed) > - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/SvnCommand.cs > trunk/irc/TechBot/TechBot.Library/Commands/WineBugUrl.cs > - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/WineBugUrl.cs > trunk/irc/TechBot/TechBot.Library/Commands/WinerrorCommand.cs (contents, props changed) > - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/WinerrorCommand.cs > trunk/irc/TechBot/TechBot.Library/Commands/WmCommand.cs (contents, props changed) > - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/WmCommand.cs > trunk/irc/TechBot/TechBot.Library/Factory/ > trunk/irc/TechBot/TechBot.Library/Factory/CommandBuilder.cs (with props) > trunk/irc/TechBot/TechBot.Library/Factory/CommandFactory.cs (with props) > trunk/irc/TechBot/TechBot.Library/ParametersParser.cs (with props) > trunk/irc/TechBot/TechBot.Library/TechBotIrcService.cs (contents, props changed) > - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/IrcService.cs > trunk/irc/TechBot/TechBot/ProjectInstaller.cs (with props) > Removed: > trunk/irc/TechBot/Default.build > trunk/irc/TechBot/TechBot.Library/ApiCommand.cs > trunk/irc/TechBot/TechBot.Library/BugCommand.cs > trunk/irc/TechBot/TechBot.Library/Command.cs > trunk/irc/TechBot/TechBot.Library/ErrorCommand.cs > trunk/irc/TechBot/TechBot.Library/HelpCommand.cs > trunk/irc/TechBot/TechBot.Library/HresultCommand.cs > trunk/irc/TechBot/TechBot.Library/IrcService.cs > trunk/irc/TechBot/TechBot.Library/NtStatusCommand.cs > trunk/irc/TechBot/TechBot.Library/ReactOSBugUrl.cs > trunk/irc/TechBot/TechBot.Library/SambaBugUrl.cs > trunk/irc/TechBot/TechBot.Library/SvnCommand.cs > trunk/irc/TechBot/TechBot.Library/WineBugUrl.cs > trunk/irc/TechBot/TechBot.Library/WinerrorCommand.cs > trunk/irc/TechBot/TechBot.Library/WmCommand.cs > trunk/irc/TechBot/TechBot.cmbx > Modified: > trunk/irc/TechBot/TechBot.Console/Main.cs > trunk/irc/TechBot/TechBot.Console/TechBot.Console.csproj > trunk/irc/TechBot/TechBot.Library/Commands/Base/XmlCommand.cs > trunk/irc/TechBot/TechBot.Library/MessageContext.cs > trunk/irc/TechBot/TechBot.Library/ServiceOutput.cs > trunk/irc/TechBot/TechBot.Library/TechBot.Library.csproj > trunk/irc/TechBot/TechBot.Library/TechBotService.cs > trunk/irc/TechBot/TechBot/ServiceThread.cs > trunk/irc/TechBot/TechBot/TechBot.csproj > trunk/irc/TechBot/TechBot/TechBotService.cs > > [This mail would be too long, it was shortened to contain the URLs only.] > > Removed: trunk/irc/TechBot/Default.build > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/Default.build?rev=3334… > > Added: trunk/irc/TechBot/TechBot.Console/ConsoleTechBotService.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Console/Consol… > > Modified: trunk/irc/TechBot/TechBot.Console/Main.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Console/Main.c… > > Modified: trunk/irc/TechBot/TechBot.Console/TechBot.Console.csproj > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Console/TechBo… > > Removed: trunk/irc/TechBot/TechBot.Library/ApiCommand.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/ApiCom… > > Added: trunk/irc/TechBot/TechBot.Library/Attributes/CommandAttribute.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Attrib… > > Added: trunk/irc/TechBot/TechBot.Library/Attributes/CommandParameterAliasAttribute.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Attrib… > > Added: trunk/irc/TechBot/TechBot.Library/Attributes/CommandParameterAttribute.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Attrib… > > Removed: trunk/irc/TechBot/TechBot.Library/BugCommand.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/BugCom… > > Added: trunk/irc/TechBot/TechBot.Library/Collections/CommandBuilderCollection.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Collec… > > Removed: trunk/irc/TechBot/TechBot.Library/Command.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Comman… > > Copied: trunk/irc/TechBot/TechBot.Library/Commands/ApiCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/ApiCommand.cs) > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Comman… > > Copied: trunk/irc/TechBot/TechBot.Library/Commands/Base/Command.cs (from r31130, trunk/irc/TechBot/TechBot.Library/Command.cs) > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Comman… > > Modified: trunk/irc/TechBot/TechBot.Library/Commands/Base/XmlCommand.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Comman… > > Added: trunk/irc/TechBot/TechBot.Library/Commands/Base/XmlLookupCommand.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Comman… > > Copied: trunk/irc/TechBot/TechBot.Library/Commands/BugCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/BugCommand.cs) > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Comman… > > Copied: trunk/irc/TechBot/TechBot.Library/Commands/ErrorCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/ErrorCommand.cs) > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Comman… > > Copied: trunk/irc/TechBot/TechBot.Library/Commands/HelpCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/HelpCommand.cs) > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Comman… > > Copied: trunk/irc/TechBot/TechBot.Library/Commands/HresultCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/HresultCommand.cs) > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Comman… > > Copied: trunk/irc/TechBot/TechBot.Library/Commands/NtStatusCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/NtStatusCommand.cs) > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Comman… > > Copied: trunk/irc/TechBot/TechBot.Library/Commands/ReactOSBugUrl.cs (from r31130, trunk/irc/TechBot/TechBot.Library/ReactOSBugUrl.cs) > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Comman… > > Copied: trunk/irc/TechBot/TechBot.Library/Commands/SambaBugUrl.cs (from r31130, trunk/irc/TechBot/TechBot.Library/SambaBugUrl.cs) > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Comman… > > Copied: trunk/irc/TechBot/TechBot.Library/Commands/SvnCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/SvnCommand.cs) > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Comman… > > Copied: trunk/irc/TechBot/TechBot.Library/Commands/WineBugUrl.cs (from r31130, trunk/irc/TechBot/TechBot.Library/WineBugUrl.cs) > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Comman… > > Copied: trunk/irc/TechBot/TechBot.Library/Commands/WinerrorCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/WinerrorCommand.cs) > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Comman… > > Copied: trunk/irc/TechBot/TechBot.Library/Commands/WmCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/WmCommand.cs) > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Comman… > > Removed: trunk/irc/TechBot/TechBot.Library/ErrorCommand.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/ErrorC… > > Added: trunk/irc/TechBot/TechBot.Library/Factory/CommandBuilder.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Factor… > > Added: trunk/irc/TechBot/TechBot.Library/Factory/CommandFactory.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Factor… > > Removed: trunk/irc/TechBot/TechBot.Library/HelpCommand.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/HelpCo… > > Removed: trunk/irc/TechBot/TechBot.Library/HresultCommand.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Hresul… > > Removed: trunk/irc/TechBot/TechBot.Library/IrcService.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/IrcSer… > > Modified: trunk/irc/TechBot/TechBot.Library/MessageContext.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Messag… > > Removed: trunk/irc/TechBot/TechBot.Library/NtStatusCommand.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/NtStat… > > Added: trunk/irc/TechBot/TechBot.Library/ParametersParser.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Parame… > > Removed: trunk/irc/TechBot/TechBot.Library/ReactOSBugUrl.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/ReactO… > > Removed: trunk/irc/TechBot/TechBot.Library/SambaBugUrl.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/SambaB… > > Modified: trunk/irc/TechBot/TechBot.Library/ServiceOutput.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Servic… > > Removed: trunk/irc/TechBot/TechBot.Library/SvnCommand.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/SvnCom… > > Modified: trunk/irc/TechBot/TechBot.Library/TechBot.Library.csproj > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/TechBo… > > Copied: trunk/irc/TechBot/TechBot.Library/TechBotIrcService.cs (from r31130, trunk/irc/TechBot/TechBot.Library/IrcService.cs) > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/TechBo… > > Modified: trunk/irc/TechBot/TechBot.Library/TechBotService.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/TechBo… > > Removed: trunk/irc/TechBot/TechBot.Library/WineBugUrl.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/WineBu… > > Removed: trunk/irc/TechBot/TechBot.Library/WinerrorCommand.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Winerr… > > Removed: trunk/irc/TechBot/TechBot.Library/WmCommand.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/WmComm… > > Removed: trunk/irc/TechBot/TechBot.cmbx > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.cmbx?rev=33343… > > Added: trunk/irc/TechBot/TechBot/ProjectInstaller.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot/ProjectInstall… > > Modified: trunk/irc/TechBot/TechBot/ServiceThread.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot/ServiceThread.… > > Modified: trunk/irc/TechBot/TechBot/TechBot.csproj > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot/TechBot.csproj… > > Modified: trunk/irc/TechBot/TechBot/TechBotService.cs > URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot/TechBotService… > >

2 1

XEN
by Enrico Weigelt 07 May '08

07 May '08

Hi folks, I'd like to try Reactos in Xen. Is there any image available ? thx -- --------------------------------------------------------------------- Enrico Weigelt == metux IT service - http://www.metux.de/ --------------------------------------------------------------------- Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ ---------------------------------------------------------------------

1 0

Re: [ros-dev] [ros-diffs] [gbrunmar] 33326: Implemented IDirect3DDevice9::GetDisplayMode()
by Steven Edwards 07 May '08

07 May '08

On Tue, May 6, 2008 at 12:15 PM, <gbrunmar(a)svn.reactos.org> wrote: > + if (IsBadWritePtr(pMode, sizeof(D3DDISPLAYMODE*))) Is this really a good idea? -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev May 2008