Ros-dev June 2008

ros-dev@reactos.org

28 participants
34 discussions

Re: [ros-dev] [ros-diffs] [cfinck] 33824: - Add a test suite forws2_32.dll It currently tests the features I needed toadjust/implement when fixing the wininet problem. ReactOScurrently passes all tests, but fails one if you launch the test app for th
by Steven Edwards 04 Jun '08

04 Jun '08

On Tue, Jun 3, 2008 at 5:08 PM, Colin Finck <mail(a)colinfinck.de> wrote: > The Wine test framework is currently only used by tests imported from Wine, > so an own test suite for ws2_32.dll might get lost there. You could have written the tests for the wine test suite and submitted them. > Also Timo's testing framework offers some interesting features like HTML > output not offered by the Wine one. Sure, but given the size of the wine test suite verses Timo's I think the effort is better spent adding this to winetest > Additionally, we have a free hand here and can play with it as we want, > while we can only import and maybe make little changes to the Wine test > framework if we want to avoid a big merging mess. Your always free to fork. As I said given the large number of unit tests in the Wine framework it seems to make more sense to me to extend that rather than develop a new one. Besides you can add the features you need to the Winetest gui and have it be independent of the framework as a whole. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [ros-dev] [ros-diffs] [greatlrd] 33807: add Test for EngDeleteSemaphore, it only test if it been create or not
by Alex Ionescu 02 Jun '08

02 Jun '08

I'm getting *quite* annoyed with seeing these kinds of tests: ret = SomeFunc(); ASSERT(ret == success); How exactly is this a test anyway? It proves in NO way that the function *worked*, only that it returned success. Furthermore, there are *plenty* of cases where a function could legitimately fail -- it is simply stupid to assume that a failure means a regression. What if the system is out of memory? On Sun, Jun 1, 2008 at 10:38 PM, <greatlrd(a)svn.reactos.org> wrote: > Author: greatlrd > Date: Sun Jun 1 09:38:02 2008 > New Revision: 33807 > > URL: http://svn.reactos.org/svn/reactos?rev=33807&view=rev > Log: > add Test for EngDeleteSemaphore, it only test if it been create or not > > Added: > trunk/rostests/apitests/gdi32api/tests/EngCreateSemaphore.c (with props) > Modified: > trunk/rostests/apitests/gdi32api/testlist.c > > Modified: trunk/rostests/apitests/gdi32api/testlist.c > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/gdi32api/testlis… > ============================================================================== > --- trunk/rostests/apitests/gdi32api/testlist.c [iso-8859-1] (original) > +++ trunk/rostests/apitests/gdi32api/testlist.c [iso-8859-1] Sun Jun 1 09:38:02 2008 > @@ -11,6 +11,7 @@ > #include "tests/CreateFont.c" > #include "tests/CreatePen.c" > #include "tests/CreateRectRgn.c" > +#include "tests/EngCreateSemaphore.c" > #include "tests/ExtCreatePen.c" > #include "tests/GdiConvertBitmap.c" > #include "tests/GdiConvertBrush.c" > @@ -51,6 +52,7 @@ > { L"CreateCompatibleDC", Test_CreateCompatibleDC }, > { L"CreateFont", Test_CreateFont }, > { L"CreatePen", Test_CreatePen }, > + { L"EngCreateSemaphore", Test_EngCreateSemaphore }, > { L"CreateRectRgn", Test_CreateRectRgn }, > { L"ExtCreatePen", Test_ExtCreatePen }, > { L"GdiConvertBitmap", Test_GdiConvertBitmap }, > > Added: trunk/rostests/apitests/gdi32api/tests/EngCreateSemaphore.c > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/gdi32api/tests/E… > ============================================================================== > --- trunk/rostests/apitests/gdi32api/tests/EngCreateSemaphore.c (added) > +++ trunk/rostests/apitests/gdi32api/tests/EngCreateSemaphore.c [iso-8859-1] Sun Jun 1 09:38:02 2008 > @@ -1,0 +1,15 @@ > +/* Simple test of EngAcquireSemaphore only check if we got a lock or not */ > +INT > +Test_EngCreateSemaphore(PTESTINFO pti) > +{ > + > + HSEMAPHORE hsem; > + hsem = EngCreateSemaphore(); > + > + RTEST ( hsem != NULL ); > + > + EngDeleteSemaphore(hsem); > + > + return APISTATUS_NORMAL; > +} > + > > Propchange: trunk/rostests/apitests/gdi32api/tests/EngCreateSemaphore.c > ------------------------------------------------------------------------------ > svn:eol-style = native > > -- Best regards, Alex Ionescu

2 1

[ros-diffs] [greatlrd] 33783: revert my last change
by James Tabor 01 Jun '08

01 Jun '08

Hi! I checked this and it is all wrong,,,,, I reverted part of revision 19267: Replacing the code with the original wine code that behaves like "Windows code" but should be called inside EngCreateBitmap if (pvBits) Width = DIB_GetDIBWidthBytes( lWidth, iFormat); . As it should be: INT FASTCALL DIB_GetDIBWidthBytes (INT width, INT depth) { // return ((width * depth + 31) & ~31) >> 3; int words; switch(depth) { case 1: words = (width + 31) / 32; break; case 4: words = (width + 7) / 8; break; case 8: words = (width + 3) / 4; break; case 15: case 16: words = (width + 1) / 2; break; case 24: words = (width * 3 + 3)/4; break; default: DPRINT1("(%d): Unsupported depth\n", depth ); /* fall through */ case 32: words = width; } return 4 * words; }

2 2

Re: [ros-dev] [ros-diffs] [tkreuzer] 33792: preserve code for NtGdiCreateEnhMetaFile from win32k (where it's going to be removed later) in gdi32 (where it's going to be implemented later)
by Steven Edwards 01 Jun '08

01 Jun '08

On Sat, May 31, 2008 at 7:15 PM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Sat May 31 18:15:34 2008 > New Revision: 33792 > > URL: http://svn.reactos.org/svn/reactos?rev=33792&view=rev > Log: > preserve code for NtGdiCreateEnhMetaFile from win32k (where it's going to be removed later) in gdi32 (where it's going to be implemented later) if your going to implement it all in usermode are you going to try to just rip the Wine metafile and enhanced metefile drivers? Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 1

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev June 2008