Ros-dev August 2008

ros-dev@reactos.org

20 participants
35 discussions

Re: [ros-dev] [ros-diffs] [cfinck] 34290: Remove the strsafe library, it was imported from a dubious source, which is incompatible with the LGPL

by Gregor Gullwi

I know this is an old changelist, but do we have any plans on re-implementing this lib by hand? -Gregor cfinck(a)svn.reactos.org wrote: > Author: cfinck > Date: Fri Jul 4 03:24:37 2008 > New Revision: 34290 > > URL: http://svn.reactos.org/svn/reactos?rev=34290&view=rev > Log: > Remove the strsafe library, it was imported from a dubious source, which is incompatible with the LGPL > > Removed: > trunk/reactos/include/psdk/strsafe.h > trunk/reactos/lib/sdk/strsafe/ > Modified: > trunk/reactos/lib/sdk/sdk.rbuild > > Removed: trunk/reactos/include/psdk/strsafe.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/strsafe.h?rev… > ============================================================================== > --- trunk/reactos/include/psdk/strsafe.h [iso-8859-1] (original) > +++ trunk/reactos/include/psdk/strsafe.h (removed) > @@ -1,454 +1,0 @@ > -/* > - * STRSAFE > - * > - * Copyright 2007 Dmitry Chapyshev <dmitry(a)reactos.org> > - * > - * This library is free software; you can redistribute it and/or > - * modify it under the terms of the GNU Lesser General Public > - * License as published by the Free Software Foundation; either > - * version 2.1 of the License, or (at your option) any later version. > - * > - * This library is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - * Lesser General Public License for more details. > - * > - * You should have received a copy of the GNU Lesser General Public > - * License along with this library; if not, write to the Free Software > - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > - */ > -#ifndef _STRSAFE_H_INCLUDED_ > -#define _STRSAFE_H_INCLUDED_ > - > -#ifdef __cplusplus > -#define _STRSAFE_EXTERN_C extern "C" > -extern "C" { > -#else > -#define _STRSAFE_EXTERN_C extern > -#endif > - > -#include <string.h> > -#include <stdarg.h> > -#include <stdio.h> > -#include <windows.h> > - > -#define STRSAFE_INLINE_API __inline HRESULT __stdcall > -#define STRSAFEAPI _STRSAFE_EXTERN_C HRESULT __stdcall > - > -#ifndef _NTSTRSAFE_H_INCLUDED_ > - > -#define STRSAFE_MAX_CCH 2147483647 > - > -#define STRSAFE_FILL_BEHIND_NULL 0x00000200 > -#define STRSAFE_IGNORE_NULLS 0x00000100 > -#define STRSAFE_FILL_ON_FAILURE 0x00000400 > -#define STRSAFE_NULL_ON_FAILURE 0x00000800 > -#define STRSAFE_NO_TRUNCATION 0x00001000 > -#define STRSAFE_IGNORE_NULL_UNICODE_STRINGS 0x00010000 > -#define STRSAFE_UNICODE_STRING_DEST_NULL_TERMINATED 0x00020000 > - > -#define STRSAFE_VALID_FLAGS (0x000000FF | STRSAFE_IGNORE_NULLS | STRSAFE_FILL_BEHIND_NULL | STRSAFE_FILL_ON_FAILURE | STRSAFE_NULL_ON_FAILURE | STRSAFE_NO_TRUNCATION) > -#define STRSAFE_UNICODE_STRING_VALID_FLAGS (STRSAFE_VALID_FLAGS | STRSAFE_IGNORE_NULL_UNICODE_STRINGS | STRSAFE_UNICODE_STRING_DEST_NULL_TERMINATED) > -#define STRSAFE_FILL_BYTE(x) ((unsigned long)((x & 0x000000FF) | STRSAFE_FILL_BEHIND_NULL)) > -#define STRSAFE_FAILURE_BYTE(x) ((unsigned long)((x & 0x000000FF) | STRSAFE_FILL_ON_FAILURE)) > -#define STRSAFE_GET_FILL_PATTERN(dwFlags) ((int)(dwFlags & 0x000000FF)) > - > -#endif /* _NTSTRSAFE_H_INCLUDED_ */ > - > -#define STRSAFE_E_INSUFFICIENT_BUFFER ((HRESULT)0x8007007AL) > -#define STRSAFE_E_INVALID_PARAMETER ((HRESULT)0x80070057L) > -#define STRSAFE_E_END_OF_FILE ((HRESULT)0x80070026L) > - > -#ifndef STRSAFE_NO_CCH_FUNCTIONS > -STRSAFEAPI > -StringCchCatA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszSrc); > - > -STRSAFEAPI > -StringCchCatW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszSrc); > - > -STRSAFEAPI > -StringCchCatExA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszSrc, > - LPTSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCchCatExW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszSrc, > - LPWSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCchCatNA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszSrc, > - size_t cchMaxAppend); > - > -STRSAFEAPI > -StringCchCatNW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszSrc, > - size_t cchMaxAppend); > - > -STRSAFEAPI > -StringCchCatNExA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszSrc, > - size_t cchMaxAppend, > - LPTSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCchCatNExW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszSrc, > - size_t cchMaxAppend, > - LPWSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCchCopyA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszSrc); > - > -STRSAFEAPI > -StringCchCopyW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszSrc); > - > -STRSAFEAPI > -StringCchCopyExA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszSrc, > - LPTSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCchCopyExW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszSrc, > - LPWSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCchCopyNA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszSrc, > - size_t cchSrc); > - > -STRSAFEAPI > -StringCchCopyNW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszSrc, > - size_t cchSrc); > - > -STRSAFEAPI > -StringCchCopyNExA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszSrc, > - size_t cchSrc, > - LPTSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCchCopyNExW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszSrc, > - size_t cchSrc, > - LPWSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFE_INLINE_API > -StringCchGetsA(LPTSTR pszDest, > - size_t cchDest); > - > -STRSAFE_INLINE_API > -StringCchGetsW(LPWSTR pszDest, > - size_t cchDest); > - > -STRSAFE_INLINE_API > -StringCchGetsExA(LPTSTR pszDest, > - size_t cchDest, > - LPTSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFE_INLINE_API > -StringCchGetsExW(LPWSTR pszDest, > - size_t cchDest, > - LPWSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCchVPrintfA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszFormat, > - va_list argList); > - > -STRSAFEAPI > -StringCchVPrintfW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszFormat, > - va_list argList); > - > -STRSAFEAPI > -StringCchVPrintfExA(LPTSTR pszDest, > - size_t cchDest, > - LPTSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags, > - LPCTSTR pszFormat, > - va_list argList); > - > -STRSAFEAPI > -StringCchVPrintfExW(LPWSTR pszDest, > - size_t cchDest, > - LPWSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags, > - LPCWSTR pszFormat, > - va_list argList); > - > -STRSAFEAPI > -StringCchLengthA(LPCTSTR psz, > - size_t cchMax, > - size_t* pcch); > - > -STRSAFEAPI > -StringCchLengthW(LPCWSTR psz, > - size_t cchMax, > - size_t* pcch); > -#endif /* STRSAFE_NO_CCH_FUNCTIONS */ > - > -/* CB */ > -#ifndef STRSAFE_NO_CB_FUNCTIONS > -STRSAFEAPI > -StringCbCatA(LPTSTR pszDest, > - size_t cbDest, > - LPCTSTR pszSrc); > - > -STRSAFEAPI > -StringCbCatW(LPWSTR pszDest, > - size_t cbDest, > - LPCWSTR pszSrc); > - > -STRSAFEAPI > -StringCbCatExA(LPTSTR pszDest, > - size_t cbDest, > - LPCTSTR pszSrc, > - LPTSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCbCatExW(LPWSTR pszDest, > - size_t cbDest, > - LPCWSTR pszSrc, > - LPWSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCbCopyA(LPTSTR pszDest, > - size_t cbDest, > - LPCTSTR pszSrc); > - > -STRSAFEAPI > -StringCbCopyW(LPWSTR pszDest, > - size_t cbDest, > - LPCWSTR pszSrc); > - > -STRSAFEAPI > -StringCbCopyExA(LPTSTR pszDest, > - size_t cbDest, > - LPCTSTR pszSrc, > - LPTSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCbCopyExW(LPWSTR pszDest, > - size_t cbDest, > - LPCWSTR pszSrc, > - LPWSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCbCopyNA(LPTSTR pszDest, > - size_t cbDest, > - LPCTSTR pszSrc, > - size_t cbSrc); > - > -STRSAFEAPI > -StringCbCopyNW(LPWSTR pszDest, > - size_t cbDest, > - LPCWSTR pszSrc, > - size_t cbSrc); > - > -STRSAFEAPI > -StringCbCopyNExA(LPTSTR pszDest, > - size_t cbDest, > - LPCTSTR pszSrc, > - size_t cbSrc, > - LPTSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCbCopyNExW(LPWSTR pszDest, > - size_t cbDest, > - LPCWSTR pszSrc, > - size_t cbSrc, > - LPWSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags); > - > -STRSAFE_INLINE_API > -StringCbGetsA(LPTSTR pszDest, > - size_t cbDest); > - > -STRSAFE_INLINE_API > -StringCbGetsW(LPWSTR pszDest, > - size_t cbDest); > - > -STRSAFE_INLINE_API > -StringCbGetsExA(LPTSTR pszDest, > - size_t cbDest, > - LPTSTR *ppszDestEnd, > - size_t* pbRemaining, > - unsigned long dwFlags); > - > -STRSAFE_INLINE_API > -StringCbGetsExW(LPWSTR pszDest, > - size_t cbDest, > - LPWSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCbPrintfA(LPTSTR pszDest, > - size_t cbDest, > - LPCTSTR pszFormat, > - ...); > - > -STRSAFEAPI > -StringCbPrintfW(LPWSTR pszDest, > - size_t cbDest, > - LPCWSTR pszFormat, > - ...); > - > -STRSAFEAPI > -StringCbPrintfExA(LPTSTR pszDest, > - size_t cbDest, > - LPTSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags, > - LPCTSTR pszFormat, > - ...); > - > -STRSAFEAPI > -StringCbPrintfExW(LPWSTR pszDest, > - size_t cbDest, > - LPWSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags, > - LPCWSTR pszFormat, > - ...); > -#endif /* STRSAFE_NO_CB_FUNCTIONS */ > - > -#ifdef UNICODE > -#ifndef STRSAFE_NO_CCH_FUNCTIONS > -#define StringCchCat StringCchCatW > -#define StringCchCatEx StringCchCatExW > -#define StringCchCatN StringCchCatNW > -#define StringCchCatNEx StringCchCatNExW > -#define StringCchCopy StringCchCopyW > -#define StringCchCopyEx StringCchCopyExW > -#define StringCchCopyN StringCchCopyNW > -#define StringCchCopyNEx StringCchCopyNExW > -#define StringCchGets StringCchGetsW > -#define StringCchGetsEx StringCchGetsExW > -#define StringCchPrintf StringCchPrintfW > -#define StringCchPrintfEx StringCchPrintfExW > -#define StringCchVPrintf StringCchVPrintfW > -#define StringCchVPrintfEx StringCchVPrintfExW > -#define StringCchLength StringCchLengthW > -#endif /* STRSAFE_NO_CCH_FUNCTIONS */ > - > -#ifndef STRSAFE_NO_CB_FUNCTIONS > -#define StringCbCat StringCbCatW > -#define StringCbCatEx StringCbCatExW > -#define StringCbCatN StringCbCatNW > -#define StringCbCatNEx StringCbCatNExW > -#define StringCbCopy StringCbCopyW > -#define StringCbCopyEx StringCbCopyExW > -#define StringCbCopyN StringCbCopyNW > -#define StringCbCopyNEx StringCbCopyNExW > -#define StringCbGets StringCbGetsW > -#define StringCbGetsEx StringCbGetsExW > -#define StringCbPrintf StringCbPrintfW > -#define StringCbPrintfEx StringCbPrintfExW > -#define StringCbVPrintf StringCbVPrintfW > -#define StringCbVPrintfEx StringCbVPrintfExW > -#define StringCbLenght StringCbLenghtW > -#endif /* STRSAFE_NO_CB_FUNCTIONS */ > - > -#else > -#ifndef STRSAFE_NO_CCH_FUNCTIONS > -#define StringCchCat StringCchCatA > -#define StringCchCatEx StringCchCatExA > -#define StringCchCatN StringCchCatNA > -#define StringCchCatNEx StringCchCatNExA > -#define StringCchCopy StringCchCopyA > -#define StringCchCopyEx StringCchCopyExA > -#define StringCchCopyN StringCchCopyNA > -#define StringCchCopyNEx StringCchCopyNExA > -#define StringCchGets StringCchGetsA > -#define StringCchGetsEx StringCchGetsExA > -#define StringCchPrintf StringCchPrintfA > -#define StringCchPrintfEx StringCchPrintfExA > -#define StringCchVPrintf StringCchVPrintfA > -#define StringCchVPrintfEx StringCchVPrintfExA > -#define StringCchLength StringCchLengthA > -#endif /* STRSAFE_NO_CCH_FUNCTIONS */ > - > -#ifndef STRSAFE_NO_CB_FUNCTIONS > -#define StringCbCat StringCbCatA > -#define StringCbCatEx StringCbCatExA > -#define StringCbCatN StringCbCatNA > -#define StringCbCatNEx StringCbCatNExA > -#define StringCbCopy StringCbCopyA > -#define StringCbCopyEx StringCbCopyExA > -#define StringCbCopyN StringCbCopyNA > -#define StringCbCopyNEx StringCbCopyNExA > -#define StringCbGets StringCbGetsA > -#define StringCbGetsEx StringCbGetsExA > -#define StringCbPrintf StringCbPrintfA > -#define StringCbPrintfEx StringCbPrintfExA > -#define StringCbVPrintf StringCbVPrintfA > -#define StringCbVPrintfEx StringCbVPrintfExA > -#define StringCbLenght StringCbLenghtA > -#endif /* STRSAFE_NO_CB_FUNCTIONS */ > -#endif /* UNICODE */ > - > -#ifdef __cplusplus > -} > -#endif /* cplusplus */ > - > -#endif /* _STRSAFE_H_INCLUDED_ */ > > Modified: trunk/reactos/lib/sdk/sdk.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/sdk.rbuild?rev=342… > ============================================================================== > --- trunk/reactos/lib/sdk/sdk.rbuild [iso-8859-1] (original) > +++ trunk/reactos/lib/sdk/sdk.rbuild [iso-8859-1] Fri Jul 4 03:24:37 2008 > @@ -23,7 +23,4 @@ > <directory name="scrnsave"> > <xi:include href="scrnsave/scrnsave.rbuild" /> > </directory> > - <directory name="strsafe"> > - <xi:include href="strsafe/strsafe.rbuild" /> > - </directory> > </group> > >

16 years, 4 months

Re: [ros-dev] [ros-diffs] [tkreuzer] 35346: PE symbol dumper. It's not finished, functions don't work and the type output doesn't always look 100% correct. But it does it's job. You need dbghelp.dll and symsrv.dll from windbg.

by Steven Edwards

On Thu, Aug 14, 2008 at 5:35 PM, <tkreuzer(a)svn.reactos.org> wrote: > URL: http://svn.reactos.org/svn/reactos?rev=35346&view=rev > Log: > PE symbol dumper. It's not finished, functions don't work and the type output doesn't always look 100% correct. But it does it's job. You need dbghelp.dll and symsrv.dll from windbg. You could also import winedump. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

16 years, 4 months

Re: [ros-dev] [ros-diffs] [tkreuzer] 35359: The TEB member is called ClientID not Cid on all Windows versions I could check (XP, 2k3, vista).

by Aleksey Bragin

Please merge this change to trunk too, if NDK author does not object. WBR, Aleksey Bragin. On Aug 16, 2008, at 3:40 AM, tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Fri Aug 15 18:40:42 2008 > New Revision: 35359 > > URL: http://svn.reactos.org/svn/reactos?rev=35359&view=rev > Log: > The TEB member is called ClientID not Cid on all Windows versions I > could check (XP, 2k3, vista).

16 years, 4 months

Re: [ros-dev] [ros-web] Developer blog

by Zachary Gorden

I'd rather pester you to finish work on your SEH paper and translation of parts of your thesis. On Fri, Aug 15, 2008 at 12:31 AM, KJK::Hyperion <hackbunny(a)reactos.org>wrote: > Zachary Gorden ha scritto: > > However, there may be developers who do not wish to maintain > > their own blog or want to keep their ROS bloggings separate and want to > > make use of the system integrated in the CMS. Any thoughts? > > Do both (aggregator AND blog platform). Then pester me to blog > _______________________________________________ > Ros-web mailing list > Ros-web(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-web >

16 years, 4 months

Developer blog

by Zachary Gorden

Sending this to both mailing lists as I don't know how many developers are actually subscribed to the web list. For some time now, the blog on the ReactOS site hasn't been used. When I asked if Aleksey was against putting up a "preview" of sorts on the front page in an attempt to revive it, some of the developers such as Ged pointed out no one really used it anymore and a few already had their own blogs and didn't want to maintain two. Ged has already moved to remove the link in the quick menu, though no formal decision has been made yet (the link is still there until a refresh occurs, though we might end up restoring it anyways). I personally believe the blog could be quite useful, even if its current form changes. An alternative would be an aggregation of the RSS feeds from the blogs maintained by each ROS developer, assuming they have a blog. However, there may be developers who do not wish to maintain their own blog or want to keep their ROS bloggings separate and want to make use of the system integrated in the CMS. Any thoughts?

16 years, 4 months

Re: [ros-dev] [ros-diffs] [sginsberg] 35299: - Reapply the PsTerminateSystemThread typo fix. We do boot fine with this fix. - Note to self: Don't commit after midnight and always test your patches yourself

by Alex Ionescu

Some credit would've been nice ;-) On 13-Aug-08, at 12:56 AM, sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Wed Aug 13 02:55:59 2008 > New Revision: 35299 > > URL: http://svn.reactos.org/svn/reactos?rev=35299&view=rev > Log: > - Reapply the PsTerminateSystemThread typo fix. We do boot fine with > this fix. > - Note to self: Don't commit after midnight and always test your > patches yourself > > Modified: > trunk/reactos/ntoskrnl/ps/kill.c > > Modified: trunk/reactos/ntoskrnl/ps/kill.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/kill.c?rev=352… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] Wed Aug 13 > 02:55:59 2008 > @@ -1086,7 +1086,7 @@ > PETHREAD Thread = PsGetCurrentThread(); > > /* Make sure this is a system thread */ > - if (Thread->SystemThread) return STATUS_INVALID_PARAMETER; > + if (!Thread->SystemThread) return STATUS_INVALID_PARAMETER; > > /* Terminate it for real */ > return PspTerminateThreadByPointer(Thread, ExitStatus, TRUE); > Best regards, Alex Ionescu

16 years, 4 months

Re: [ros-dev] [ros-diffs] [sginsberg] 35294: - Temporarily revert my last change. We don't set the SystemThread flag appropriately and it is always zero

by Alex Ionescu

else { /* System Thread */ Thread->StartAddress = StartRoutine; PspSetCrossThreadFlag(Thread, CT_SYSTEM_THREAD_BIT); Looks good to me. And CT_SYSTEM_THREAD_BIT is defined to 0x10 which is correct: union { struct { ULONG Terminated:1; #if (NTDDI_VERSION >= NTDDI_LONGHORN) ULONG ThreadInserted:1; #else ULONG DeadThread:1; #endif ULONG HideFromDebugger:1; ULONG ActiveImpersonationInfo:1; ULONG SystemThread:1; so your patch was correct and should be re-applied. On 12-Aug-08, at 3:22 PM, sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Tue Aug 12 17:22:51 2008 > New Revision: 35294 > > URL: http://svn.reactos.org/svn/reactos?rev=35294&view=rev > Log: > - Temporarily revert my last change. We don't set the SystemThread > flag appropriately and it is always zero > > Modified: > trunk/reactos/ntoskrnl/ps/kill.c > > Modified: trunk/reactos/ntoskrnl/ps/kill.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/kill.c?rev=352… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] Tue Aug 12 > 17:22:51 2008 > @@ -1086,7 +1086,7 @@ > PETHREAD Thread = PsGetCurrentThread(); > > /* Make sure this is a system thread */ > - if (!Thread->SystemThread) return STATUS_INVALID_PARAMETER; > + if (Thread->SystemThread) return STATUS_INVALID_PARAMETER; > > /* Terminate it for real */ > return PspTerminateThreadByPointer(Thread, ExitStatus, TRUE); > Best regards, Alex Ionescu

16 years, 4 months

Re: [ros-dev] [ros-priv] ROS information policy...

by Thomas Bluemel

Timo Kreuzer wrote: > And when I have already started moaning about this kind of stuff... what > about the arm guys? They are so secret they can't even make their > changelog themselfs? Why that? And why are they so secret that noone > knows? I mean we keep demanding real name and email from everyone > creating a patch, yet a bunch of people have direct commit access and > they keep hiding their names? What reasons are there I thought it was common knowledge already that Alex is the (only) arm "guys". Isn't it more than obvious? Very same coding style, knowledge, comments, rants, ... How stupid does one have to be not to realize the connection? Prove me otherwise... And since you're complaining about not being open, why do you only post this to the private list? Thomas

16 years, 4 months

[ros-diffs] [fireball] 35140: - Add more intrinsic defines. - SVN maintenance.

by Timo Kreuzer

MS defines most of those in the wdk, if NO_INTERLOCKED_INTRINSICS is not defined > +#define InterlockedDecrement _InterlockedDecrement > +#define InterlockedDecrement16 _InterlockedDecrement16 > +#define InterlockedIncrement _InterlockedIncrement > +#define InterlockedIncrement16 _InterlockedIncrement16 > +#define InterlockedCompareExchange _InterlockedCompareExchange > +#define InterlockedCompareExchange16 _InterlockedCompareExchange16 > +#define InterlockedCompareExchange64 _InterlockedCompareExchange64 > +#define InterlockedExchange _InterlockedExchange > +#define InterlockedExchangeAdd _InterlockedExchangeAdd >

16 years, 4 months

Re: [ros-dev] [ros-diffs] [dchapyshev] 35127: - Add cred.c from Wine

by Steven Edwards

On Tue, Aug 5, 2008 at 10:45 AM, <dchapyshev(a)svn.reactos.org> wrote: > +#include "../crypt/crypt.h" Minor nitpicking, Do you mind fixing this? Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

16 years, 4 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev August 2008