Ros-dev January 2009

ros-dev@reactos.org

27 participants
39 discussions

Re : [Qemu-devel] Virtio ballon device always loaded ?

by Sylvain Petreolle

Forwarded to ReactOS mailing list. (using correct address this time :) ----- Message d'origine ---- > De : Anthony Liguori <anthony(a)codemonkey.ws> > À : qemu-devel(a)nongnu.org > Envoyé le : Jeudi, 29 Janvier 2009, 22h55mn 12s > Objet : Re: [Qemu-devel] Virtio ballon device always loaded ? > > Sylvain Petreolle wrote: > > Testing ReactOS in qemu made it always asking drivers for a RAM Controller. > > > > Looking at "info pci" output and hw/pc.c, I see that the Virtio balloon device > is always loaded in an x86/64 target. > > Is that a wanted feature ? > > > > Sure, as I see no harm in not enabling it by default. ReactOS doesn't > just ignore unknown PCI devices? That's strange because Windows seems to. > > Regards, > > Anthony Liguori > > > I also notice that hw/virtio-balloon.c header refers to the Virtio Block > Device. > > > > Kind regards, > > Sylvain Petreolle > > > > > > > >

15 years, 8 months

[ros-diffs] [gschneider] 39217: Unify identical StretchBlt implementations in preparation of partial ROP suppport.

by James Tabor

Hi! Don't forget the Bug report number this is related to... Bolt aka BSTSoft is working hard on fixing this. Thanks, James Ref: http://www.reactos.org/bugzilla/show_bug.cgi?id=4075

15 years, 8 months

Re: [ros-dev] [ros-diffs] [cfinck] 39186: - Set "lake.bmp" as the default wallpaper - Add a shortcut to "Download !" to the Desktop

by Ged

Btw, there are some really nice wallpapers in the forums, much nicer than the lake.bmp we keep using. Just a thought. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of cfinck(a)svn.reactos.org Sent: 28 January 2009 20:18 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [cfinck] 39186: - Set "lake.bmp" as the default wallpaper - Add a shortcut to "Download !" to the Desktop Author: cfinck Date: Wed Jan 28 14:17:33 2009 New Revision: 39186 URL: http://svn.reactos.org/svn/reactos?rev=39186&view=rev Log: - Set "lake.bmp" as the default wallpaper - Add a shortcut to "Download !" to the Desktop Modified: branches/ros-branch-0_3_8/reactos/boot/bootdata/hivedef_i386.inf branches/ros-branch-0_3_8/reactos/dll/win32/syssetup/install.c Modified: branches/ros-branch-0_3_8/reactos/boot/bootdata/hivedef_i386.inf URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_8/reactos/boot/b… ============================================================================== --- branches/ros-branch-0_3_8/reactos/boot/bootdata/hivedef_i386.inf [iso-8859-1] (original) +++ branches/ros-branch-0_3_8/reactos/boot/bootdata/hivedef_i386.inf [iso-8859-1] Wed Jan 28 14:17:33 2009 @@ -20,7 +20,7 @@ HKCU,"Control Panel\Desktop","HungAppTimeout",0x00000002,"5000" HKCU,"Control Panel\Desktop","SCRNSAVE.EXE",0x00000000,"" HKCU,"Control Panel\Desktop","WaitToKillAppTimeout",0x00000002,"20000" -HKCU,"Control Panel\Desktop","Wallpaper",0x00000000,"" +HKCU,"Control Panel\Desktop","Wallpaper",0x00000000,"%SystemRoot%\lake.bmp" HKCU,"Control Panel\International",,0x00000012 HKCU,"Control Panel\International","Locale",0x00000000,"0409" HKCU,"Control Panel\International\Geo","Nation",0x00000000,"1" Modified: branches/ros-branch-0_3_8/reactos/dll/win32/syssetup/install.c URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_8/reactos/dll/wi… ============================================================================== --- branches/ros-branch-0_3_8/reactos/dll/win32/syssetup/install.c [iso-8859-1] (original) +++ branches/ros-branch-0_3_8/reactos/dll/win32/syssetup/install.c [iso-8859-1] Wed Jan 28 14:17:33 2009 @@ -756,6 +756,7 @@ /* Create desktop shortcuts */ CreateShortcut(CSIDL_DESKTOP, NULL, IDS_SHORT_CMD, _T("%SystemRoot%\\system32\\cmd.exe"), IDS_CMT_CMD, TRUE); + CreateShortcut(CSIDL_DESKTOP, NULL, IDS_SHORT_DOWNLOADER, _T("%SystemRoot%\\system32\\downloader.exe"), IDS_CMT_DOWNLOADER, TRUE); /* Create program startmenu shortcuts */ CreateShortcut(CSIDL_PROGRAMS, NULL, IDS_SHORT_EXPLORER, _T("%SystemRoot%\\explorer.exe"), IDS_CMT_EXPLORER, TRUE);

15 years, 8 months

Re: [ros-dev] [ros-diffs] [cfinck] 39186: - Set "lake.bmp" as the default wallpaper - Add a shortcut to "Download !" to the Desktop

by Marc Piulachs

Why bother when there are tons of free high quality wallpapers to choose from? We could use a simple but elegant abstract wallpaper rather than trying to imitate Vista or the iPhone like for example: http://www.gnome-look.org/content/show.php/Focus+GNU+Linux?content=94090 http://www.gnome-look.org/content/show.php/Flow?content=71058 http://www.gnome-look.org/content/show.php/Why+not?content=93589 My personal favourite: http://www.gnome-look.org/content/show.php/Colored+Particles+Wallpaper?cont… Regards, Marc -------------------------------------------------- From: "KJK::Hyperion" <hackbunny(a)reactos.com> Sent: Thursday, January 29, 2009 12:52 PM To: "ReactOS Development List" <ros-dev(a)reactos.org> Subject: Re: [ros-dev] [ros-diffs] [cfinck] 39186: - Set "lake.bmp" as the default wallpaper - Add a shortcut to "Download !" to the Desktop > Ged wrote: >> We'd need an alpha fish instead of a betta (Siamese fighter) >> ;) > > What about a betta youngling? This is actually pretty clever. I know a > semi-pro photographer. I could ask him > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

15 years, 8 months

Re: [ros-dev] Ros-dev Digest, Vol 53, Issue 30

by Olaf Siejka

"Please test them, especially with the applications in Downloader, and write your results to http://www.reactos.org/wiki/index.php/Tests_for_0.3.8" I have a suggestion - we should limit the amount of people that are allowed to actually write the results to some designated people and let everyone pass the results to them.

15 years, 8 months

0.3.8 Test Season has started :-)

by Colin Finck

Hello everybody (and especially the testers), After nobody complained about branching 0.3.8 from trunk now, I took the initiative today and prepared the branch with our usual customizations and hacks. It's now again the time for application testing. Therefore I uploaded Boot CD and Live CD of the current branch to http://reactos.colinfinck.de/ Please test them, especially with the applications in Downloader, and write your results to http://www.reactos.org/wiki/index.php/Tests_for_0.3.8 I especially write this now, because we want the release to be ready some days before FOSDEM. Andrew wants to start burning the CDs for FOSDEM soon, so it would be great if we could get the entire release done till *next Monday*. Best regards, Colin

15 years, 8 months

[ros-diffs] [cfinck] 39188: Hack: Copy the toolbar image on our own instead of using CopyImage to hackfix the messed up toolbar graphics as it was done for previous releases.

by James Tabor

Hi! This is what I've been fighting (BITMAP) with! I should have read this in previous releases. Take note! Thanks, James --- branches/ros-branch-0_3_8/reactos/dll/win32/comctl32/toolbar.c [iso-8859-1] (original) +++ branches/ros-branch-0_3_8/reactos/dll/win32/comctl32/toolbar.c [iso-8859-1] Wed Jan 28 15:11:36 2009 @@ -2659,7 +2659,33 @@ TRACE("adding hInst=%p nID=%d nButtons=%d\n", bitmap->hInst, bitmap->nID, bitmap->nButtons); /* Add bitmaps to the default image list */ if (bitmap->hInst == NULL) /* a handle was passed */ - hbmLoad = CopyImage(ULongToHandle(bitmap->nID), IMAGE_BITMAP, 0, 0, 0); + { + BITMAP bmp; + HBITMAP hOldBitmapBitmap, hOldBitmapLoad; + HDC hdcImage, hdcBitmap; + + /* copy the bitmap before adding it so that the user's bitmap + * doesn't get modified. + */ + GetObjectW ((HBITMAP)bitmap->nID, sizeof(BITMAP), (LPVOID)&bmp); + + hdcImage = CreateCompatibleDC(0); + hdcBitmap = CreateCompatibleDC(0); + + /* create new bitmap */ + hbmLoad = CreateBitmap (bmp.bmWidth, bmp.bmHeight, bmp.bmPlanes, bmp.bmBitsPixel, NULL); + hOldBitmapBitmap = SelectObject(hdcBitmap, (HBITMAP)bitmap->nID); + hOldBitmapLoad = SelectObject(hdcImage, hbmLoad); + + /* Copy the user's image */ + BitBlt (hdcImage, 0, 0, bmp.bmWidth, bmp.bmHeight, + hdcBitmap, 0, 0, SRCCOPY); + + SelectObject (hdcImage, hOldBitmapLoad); + SelectObject (hdcBitmap, hOldBitmapBitmap); + DeleteDC (hdcImage); + DeleteDC (hdcBitmap); + } else hbmLoad = CreateMappedBitmap(bitmap->hInst, bitmap->nID, 0, NULL, 0);

15 years, 8 months

winetest note

by Ged

I've been using the Winetests in Windows quite a lot recently, both XP and Vista, and I've noticed that a lot of the tests fail in Windows. For anyone using the Winetests in reactos to fix our code, it's worth testing if these functions pass or fail in Windows first as we might be breaking reactos to pass the winetests. Also, one of the problems I've noticed is that some tests fail on XP but pass in Vista, and vice versa. Does anyone know Wine's target OS? It seems that more tests are passing in Vista than XP these days, so maybe they've moved to a more recent target? I think the best way to move forward with this is to find out what version Wine target, fix any broken tests we come across and submit them to Wine. I don't envisage any problem with Wine accepting fixed test cases, even from the most hated of reactos devs. Anyway, I just wanted to make people aware, _don't blindly trust Winetests when fixing reactos_ Ged.

15 years, 8 months

Re: [ros-dev] [ros-diffs] [hyperion] 39111: Begin moving rules out of modulehandler.cpp and into makefile include rules.mak, where they will be more readable and manageable.

by Timo Kreuzer

If you are going to do more work on rbuild, I'd suggest doing it in a branch to avoid clean rebuilds every few revisions. Timo hyperion(a)svn.reactos.org schrieb: > Author: hyperion > Date: Mon Jan 26 08:26:15 2009 > New Revision: 39111 > > URL: http://svn.reactos.org/svn/reactos?rev=39111&view=rev > Log: > Begin moving rules out of modulehandler.cpp and into makefile include rules.mak, where they will be more readable and manageable. Currently implemented: target C compiler and target C++ compiler rules. Please do a clean build if possible. Testing with unusual output paths appreciated > >

15 years, 8 months

TEB

by James Tabor

Hi, The TEB in psdk/winternl.h does not match with the correct one in ndk/pstypes.h. Does anyone else see that as a problem or is it just me? If it is for wine, then it is wrong, need to implement it as it is in the SDK. Use it for the Tls fields only...... Thanks, James

15 years, 8 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev January 2009