Ros-dev October 2009

ros-dev@reactos.org

26 participants
36 discussions

Re: [ros-dev] [ros-diffs] [sginsberg] 43265: - Replace some x86 assembly in drivers with portable breakpoint support.

by Timo Kreuzer

It was intentionally that I used an inlined break point in bmfd & ftfd. Portability is not yet needed. Please revert. sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Sat Oct 3 16:15:46 2009 > New Revision: 43265 > > URL: http://svn.reactos.org/svn/reactos?rev=43265&view=rev > Log: > - Replace some x86 assembly in drivers with portable breakpoint support. > > Modified: > trunk/reactos/drivers/network/ndis/ndis/miniport.c > trunk/reactos/drivers/video/font/bmfd/bmfd.h > trunk/reactos/drivers/video/font/bmfd/font.c > trunk/reactos/drivers/video/font/bmfd/glyph.c > trunk/reactos/drivers/video/font/ftfd/enable.c > trunk/reactos/drivers/video/font/ftfd/font.c > trunk/reactos/drivers/video/font/ftfd/ftfd.h > > Modified: trunk/reactos/drivers/network/ndis/ndis/miniport.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… > ============================================================================== > --- trunk/reactos/drivers/network/ndis/ndis/miniport.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/network/ndis/ndis/miniport.c [iso-8859-1] Sat Oct 3 16:15:46 2009 > @@ -1472,7 +1472,7 @@ > *NdisWrapperHandle = NULL; > > #if BREAK_ON_MINIPORT_INIT > - __asm__ ("int $3\n"); > + DbgBreakPoint(); > #endif > > Miniport = ExAllocatePool(NonPagedPool, sizeof(NDIS_M_DRIVER_BLOCK)); > > Modified: trunk/reactos/drivers/video/font/bmfd/bmfd.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/font/bmfd/bm… > ============================================================================== > --- trunk/reactos/drivers/video/font/bmfd/bmfd.h [iso-8859-1] (original) > +++ trunk/reactos/drivers/video/font/bmfd/bmfd.h [iso-8859-1] Sat Oct 3 16:15:46 2009 > @@ -263,17 +263,6 @@ > ULONG > DbgPrint(IN PCHAR Format, IN ...); > > -FORCEINLINE > -VOID > -DbgBreakPoint(VOID) > -{ > -#ifdef __GNUC__ > - asm volatile ("int $3"); > -#else > - __asm int 3; > -#endif > -} > - > DHPDEV > APIENTRY > BmfdEnablePDEV( > > Modified: trunk/reactos/drivers/video/font/bmfd/font.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/font/bmfd/fo… > ============================================================================== > --- trunk/reactos/drivers/video/font/bmfd/font.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/video/font/bmfd/font.c [iso-8859-1] Sat Oct 3 16:15:46 2009 > @@ -247,7 +247,7 @@ > ULONG cjView; > > DbgPrint("BmfdLoadFontFile()\n"); > - DbgBreakPoint(); > + EngDebugBreak(); > > /* Check parameters */ > if (cFiles != 1) > @@ -323,7 +323,7 @@ > PBMFD_FILE pfile = (PBMFD_FILE)iFile; > > DbgPrint("BmfdQueryFontFile()\n"); > -// DbgBreakPoint(); > +// EngDebugBreak(); > > switch (ulMode) > { > @@ -397,7 +397,7 @@ > HGLYPH * phglyphs; > > DbgPrint("DrvQueryFontTree(iMode=%ld)\n", iMode); > -// DbgBreakPoint(); > +// EngDebugBreak(); > > /* Check parameters, we only support QFT_GLYPHSET */ > if (!iFace || iFace > pfile->cNumFaces || iMode != QFT_GLYPHSET) > @@ -522,7 +522,7 @@ > PANOSE panose = {0}; > > DbgPrint("BmfdQueryFont()\n"); > -// DbgBreakPoint(); > +// EngDebugBreak(); > > /* Validate parameters */ > if (iFace > pfile->cNumFaces || !pid) > > Modified: trunk/reactos/drivers/video/font/bmfd/glyph.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/font/bmfd/gl… > ============================================================================== > --- trunk/reactos/drivers/video/font/bmfd/glyph.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/video/font/bmfd/glyph.c [iso-8859-1] Sat Oct 3 16:15:46 2009 > @@ -331,7 +331,7 @@ > > DbgPrint("BmfdQueryFontData(pfo=%p, iMode=%ld, hg=%p, pgd=%p, pv=%p, cjSize=%ld)\n", > pfo, iMode, hg, pgd, pv, cjSize); > -// DbgBreakPoint(); > +// EngDebugBreak(); > > switch (iMode) > { > > Modified: trunk/reactos/drivers/video/font/ftfd/enable.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/font/ftfd/en… > ============================================================================== > --- trunk/reactos/drivers/video/font/ftfd/enable.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/video/font/ftfd/enable.c [iso-8859-1] Sat Oct 3 16:15:46 2009 > @@ -77,7 +77,7 @@ > IN HANDLE hDriver) > { > DbgPrint("FtfdEnablePDEV(hdev=%p)\n", hdev); > - DbgBreakPoint(); > + EngDebugBreak(); > > > /* Return a dummy DHPDEV */ > > Modified: trunk/reactos/drivers/video/font/ftfd/font.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/font/ftfd/fo… > ============================================================================== > --- trunk/reactos/drivers/video/font/ftfd/font.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/video/font/ftfd/font.c [iso-8859-1] Sat Oct 3 16:15:46 2009 > @@ -145,7 +145,7 @@ > PFTFD_FILE pfile = (PFTFD_FILE)iFile; > > DbgPrint("FtfdQueryFontFile(ulMode=%ld)\n", ulMode); > -// DbgBreakPoint(); > +// EngDebugBreak(); > > switch (ulMode) > { > @@ -322,7 +322,7 @@ > FT_Done_Face(ftface); > > DbgPrint("Finished with the ifi: %p\n", pifiX); > - DbgBreakPoint(); > + EngDebugBreak(); > > return pifi; > } > @@ -469,7 +469,7 @@ > *pid = (ULONG_PTR)pGlyphSet; > > DbgPrint("pGlyphSet=%p\n", pGlyphSet); > -DbgBreakPoint(); > +EngDebugBreak(); > > return pGlyphSet; > } > > Modified: trunk/reactos/drivers/video/font/ftfd/ftfd.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/font/ftfd/ft… > ============================================================================== > --- trunk/reactos/drivers/video/font/ftfd/ftfd.h [iso-8859-1] (original) > +++ trunk/reactos/drivers/video/font/ftfd/ftfd.h [iso-8859-1] Sat Oct 3 16:15:46 2009 > @@ -51,17 +51,6 @@ > > ULONG > DbgPrint(IN PCHAR Format, IN ...); > - > -FORCEINLINE > -VOID > -DbgBreakPoint(VOID) > -{ > -#ifdef __GNUC__ > - asm volatile ("int $3"); > -#else > - __asm int 3; > -#endif > -} > > DHPDEV > APIENTRY > > > >

15 years, 2 months

ExpSystemErrorHandler

by Love Nystrom

stefan__100__(a)hotmail.com wrote: >> And the reason you couldn't pass Parameters? > Because KeBugCheck expects the array to contain 4 entries, and Parameters isn't guranteed to be that big. > What do you think of the following? > > NTSTATUS NTAPI ExpSystemErrorHandler ( > // ... abbreviated ... > { > ULONG_PTR BugCheckParameters[MAXIMUM_HARDERROR_PARAMETERS] = {0, 0, 0, 0}; > // ... abbreviated ... > for (i = 0; i < NumberOfParameters; i++) > { > /* Copy them over */ > BugCheckParameters[i] = Parameters[i]; > } If you are going to use that, you'd better include something like this first: if (NumberOfParameters > MAXIMUM_HARDERROR_PARAMETERS) NumberOfParameters = MAXIMUM_HARDERROR_PARAMETERS; or make it for (i = 0; i < min( NumberOfParameters, MAXIMUM_HARDERROR_PARAMETERS ); i++) or you might create more problems than you solve, unless you're 100% guarateed you can never receive more than MAXIMUM_HARDERROR_PARAMETERS. (This said without studying the actual problem at hand). Best Regards // Love _________________________________________________________________ Keep your friends updated—even when you’re not signed in. http://www.microsoft.com/middleeast/windows/windowslive/see-it-in-action/so…

15 years, 2 months

Re: [ros-dev] [ros-diffs] [cgutman] 43251: - Get the length from each packet header instead of assuming that all packets will be the length of the first one

by Matthieu Suiche

Lol, this bug is really nice. -- Matthieu Suiche On Thu, Oct 1, 2009 at 11:00 PM, <cgutman(a)svn.reactos.org> wrote: > Author: cgutman > Date: Thu Oct 1 23:00:41 2009 > New Revision: 43251 > > URL: http://svn.reactos.org/svn/reactos?rev=43251&view=rev > Log: > - Get the length from each packet header instead of assuming that all packets will be the length of the first one > > Modified: > trunk/reactos/lib/drivers/oskittcp/oskittcp/ip_output.c > > Modified: trunk/reactos/lib/drivers/oskittcp/oskittcp/ip_output.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/drivers/oskittcp/oskit… > ============================================================================== > --- trunk/reactos/lib/drivers/oskittcp/oskittcp/ip_output.c [iso-8859-1] (original) > +++ trunk/reactos/lib/drivers/oskittcp/oskittcp/ip_output.c [iso-8859-1] Thu Oct 1 23:00:41 2009 > @@ -517,8 +517,8 @@ > error = ENOBUFS; > goto done; > } > - m_copydata( m, 0, htons(ip->ip_len), new_m->m_data ); > - new_m->m_len = htons(ip->ip_len); > + m_copydata( m, 0, m->m_pkthdr.len, new_m->m_data ); > + new_m->m_len = m->m_pkthdr.len; > error = OtcpEvent.PacketSend( OtcpEvent.ClientData, > (OSK_PCHAR)new_m->m_data, new_m->m_len ); > m_free( new_m ); > > >

15 years, 2 months

Re: [ros-dev] [ros-diffs] [sginsberg] 43241: - KeBugCheckEx expects BugCheckParameter2 to point to an array when the bug code is FATAL_UNHANDLED_HARD_ERROR -- properly stub out ExpSystemErrorHandler so we don't crash in KeBugCheckEx.

by Alex Ionescu

And the reason you couldn't pass Parameters? Best regards, Alex Ionescu On Wed, Sep 30, 2009 at 2:31 PM, <sginsberg(a)svn.reactos.org> wrote: > Author: sginsberg > Date: Wed Sep 30 20:31:26 2009 > New Revision: 43241 > > URL: http://svn.reactos.org/svn/reactos?rev=43241&view=rev > Log: > - KeBugCheckEx expects BugCheckParameter2 to point to an array when the bug code is FATAL_UNHANDLED_HARD_ERROR -- properly stub out ExpSystemErrorHandler so we don't crash in KeBugCheckEx. > > Modified: > trunk/reactos/ntoskrnl/ex/harderr.c > > Modified: trunk/reactos/ntoskrnl/ex/harderr.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/harderr.c?rev=… > ============================================================================== > --- trunk/reactos/ntoskrnl/ex/harderr.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ex/harderr.c [iso-8859-1] Wed Sep 30 20:31:26 2009 > @@ -58,10 +58,12 @@ > IN PULONG_PTR Parameters, > IN BOOLEAN Shutdown) > { > + ULONG_PTR Dummy[4] = {0, 0, 0, 0}; > + > /* FIXME: STUB */ > KeBugCheckEx(FATAL_UNHANDLED_HARD_ERROR, > ErrorStatus, > - 0, > + (ULONG_PTR)Dummy, > 0, > 0); > return STATUS_SUCCESS; > > >

15 years, 2 months

Re: [ros-dev] [ros-diffs] [sginsberg] 43236: - Goodbye __USE_W32API

by WaxDragon

AND THE CROWD GOES WILD! On Oct 1, 2009 9:56 AM, "Steven Edwards" <winehacker(a)gmail.com> wrote: On Wed, Sep 30, 2009 at 9:32 AM, <sginsberg(a)svn.reactos.org> wrote: > URL: http://svn.reactos.org/svn/reactos?rev=43236&view=rev > Log: > - Goodbye __USE_W32API This is a historic day in ReactOS that unfortunately no one will really remember. Let us celebrate while we can and have much rejoicing! Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

15 years, 2 months

Re: [ros-dev] [ros-diffs] [sginsberg] 43236: - Goodbye __USE_W32API

by Steven Edwards

On Wed, Sep 30, 2009 at 9:32 AM, <sginsberg(a)svn.reactos.org> wrote: > URL: http://svn.reactos.org/svn/reactos?rev=43236&view=rev > Log: > - Goodbye __USE_W32API This is a historic day in ReactOS that unfortunately no one will really remember. Let us celebrate while we can and have much rejoicing! Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

15 years, 2 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev October 2009