On Sat, Dec 12, 2009 at 8:40 PM, <hyperion(a)svn.reactos.org> wrote:
> Author: hyperion
> Date: Sun Dec 13 02:40:56 2009
> New Revision: 44558
>
> URL: http://svn.reactos.org/svn/reactos?rev=44558&view=rev
> Log:
> added Wine on ReactOS - Inkscape.svg
> added Wine on ReactOS.svg
> My "Wine on ReactOS" diagram, in SVG format, two variants (Inkscape-friendly and optimized for the web)
>
> added COPYING
> Licensing information on the images
>
> Added:
> trunk/press-media/art/COPYING
> trunk/press-media/art/Wine on ReactOS - Inkscape.svg
> trunk/press-media/art/Wine on ReactOS.svg
Maybe there should be translucent wine bottles over
user32/gdi32/kernel32/etc where we use snippets and whole source
files. I do like this image though! I will use it the next time I give
a presentation. Thanks!
--
Steven Edwards
"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo
I'm pretty much sticking to the way it is done in most other places.
Ref:
http://git.reactos.org/?p=reactos.git&a=search&h=HEAD&st=grep&s=ZeroInit
2009/12/12 KJK::Hyperion <hackbunny(a)reactos.org>
> gschneider(a)svn.reactos.org wrote:
> > - The field ZeroInit should be initialized to zero - do that by assigning
> the message type directly
>
> please do this by zero-initializing ZeroInit instead. Don't play with
> unions
>
> _______________________________________________
> Ros-dev mailing list
> Ros-dev(a)reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
>
cfinck(a)svn.reactos.org wrote:
> + ULONG i = 30 * 1000;
Can we give a meaningful name to this value and put it in a header file?
and document what it is for?
gschneider(a)svn.reactos.org wrote:
> - The field ZeroInit should be initialized to zero - do that by assigning the message type directly
please do this by zero-initializing ZeroInit instead. Don't play with unions
Building with _WINKD_ = 1 is broken
[COPY] output-i386\bootcd\reactos\ntfs.sys
[AS] ntoskrnl\ke\i386\boot.S
[CC] ntoskrnl\ke\i386\abios.c
In file included from ntoskrnl/include/internal/ntoskrnl.h:83,
from ntoskrnl/include/precomp.h:64,
from ntoskrnl/include/ntoskrnl.h:1,
from ntoskrnl\ke\i386\abios.c:11:
ntoskrnl/include/../kdbg/kdb.h:228: error: expected '=', ',', ';', 'asm' or
'__attribute__' before 'KdbEnterDebuggerException'
mingw32-make: *** [obj-i386\ntoskrnl\ke\i386\abios_ntkrnlmp.o] Error 1
I've gone down the path of virtually rewriting the msvc backend for rbuild.
Our current implementation had completely outgrown its original design and
was becoming very difficult to manage, as highlighted when I was adding
support for VS 2010.
Anyway, whilst I'm doing this I think it's a good time assess what we want
to support. We currently support Visual Studio 6, Visual Studio .NET 2002
and Visual Studio.NET 2003. This is a waste of time IMO and only adds to the
complexity of the module
I'm proposing to remove support for these 3 products unless anyone has any
reasons against.
Ged.
