Ros-dev November 2011

ros-dev@reactos.org

33 participants
21 discussions

Re: [ros-dev] [ros-diffs] [cgutman] 54418: [HALX86] - Do not allow software interrupts to preempt code running with interrupts disabled during KfLowerIrql

by Aleksey Bragin

I would like to ask our kernel gurus if this one is correct. WBR, Aleksey Bragin. On 18.11.2011 22:53, cgutman(a)svn.reactos.org wrote: > Author: cgutman > Date: Fri Nov 18 18:53:41 2011 > New Revision: 54418 > > URL: http://svn.reactos.org/svn/reactos?rev=54418&view=rev > Log: > [HALX86] > - Do not allow software interrupts to preempt code running with interrupts disabled during KfLowerIrql > > Modified: > trunk/reactos/hal/halx86/up/pic.c > > Modified: trunk/reactos/hal/halx86/up/pic.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/up/pic.c?rev=54… > ============================================================================== > --- trunk/reactos/hal/halx86/up/pic.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/up/pic.c [iso-8859-1] Fri Nov 18 18:53:41 2011 > @@ -665,26 +665,30 @@ > > /* Set old IRQL */ > Pcr->Irql = OldIrql; > - > - /* Check for pending software interrupts and compare with current IRQL */ > - PendingIrqlMask = Pcr->IRR& FindHigherIrqlMask[OldIrql]; > - if (PendingIrqlMask) > - { > - /* Check if pending IRQL affects hardware state */ > - BitScanReverse(&PendingIrql, PendingIrqlMask); > - if (PendingIrql> DISPATCH_LEVEL) > + > + /* Make sure interrupts were enabled */ > + if (EFlags& EFLAGS_INTERRUPT_MASK) > + { > + /* Check for pending software interrupts and compare with current IRQL */ > + PendingIrqlMask = Pcr->IRR& FindHigherIrqlMask[OldIrql]; > + if (PendingIrqlMask) > { > - /* Set new PIC mask */ > - Mask.Both = Pcr->IDR; > - __outbyte(PIC1_DATA_PORT, Mask.Master); > - __outbyte(PIC2_DATA_PORT, Mask.Slave); > - > - /* Clear IRR bit */ > - Pcr->IRR ^= (1<< PendingIrql); > + /* Check if pending IRQL affects hardware state */ > + BitScanReverse(&PendingIrql, PendingIrqlMask); > + if (PendingIrql> DISPATCH_LEVEL) > + { > + /* Set new PIC mask */ > + Mask.Both = Pcr->IDR; > + __outbyte(PIC1_DATA_PORT, Mask.Master); > + __outbyte(PIC2_DATA_PORT, Mask.Slave); > + > + /* Clear IRR bit */ > + Pcr->IRR ^= (1<< PendingIrql); > + } > + > + /* Now handle pending interrupt */ > + SWInterruptHandlerTable[PendingIrql](); > } > - > - /* Now handle pending interrupt */ > - SWInterruptHandlerTable[PendingIrql](); > } > > /* Restore interrupt state */ > >

13 years, 1 month

Re: [ros-dev] [ros-diffs] [cgutman] 54415: [I8042PRT] - Implement support for hot plugging PS/2 mice if one was present at boot (same requirement as Windows) - Fixes bug 1395

by Johannnes Anderwald

Am 18.11.2011 00:41, schrieb cgutman(a)svn.reactos.org: > Author: cgutman > Date: Thu Nov 17 23:41:18 2011 > New Revision: 54415 > > URL: http://svn.reactos.org/svn/reactos?rev=54415&view=rev > Log: > [I8042PRT] > - Implement support for hot plugging PS/2 mice if one was present at boot (same requirement as Windows) > - Fixes bug 1395 > > Exellent! -- Johannes Anderwald

13 years, 1 month

Looking for new maintainers

by Colin Finck

Hi all, As some of you know, I have started university about a month ago. Due to the amount of time I have to spend on university tasks these days, I can no longer fulfil all my project obligations. Therefore, I'm looking for new maintainers in the following areas: * RosBE-Unix * My Web tools (especially Testman and the rest of the regression testing system, but also GetBuilds/People Map/Subsystem integration) * Release Engineering (unless Ziliang can fully takeover my position) Provided that I find time, I'll introduce the new maintainers into these tasks as good as possible. I try to stay available for infrastructure and foundation tasks, but my time for these will definitely be limited as well. Best regards, Colin

13 years, 1 month

Testing sound

by Igor Paliychuk

Debug log from testing cmake soundchip in KSStudio. http://www.reactos.org/paste/index.php/9568/ Btw i'm getting crash in cmuda.sys on two different PCs (though i didn't notiv=ce if chips are the same) To get your attention, Johannes ;)

13 years, 1 month

Qemu Recoverable Assertion when Loading Gecko

by James Tabor

Head up on this one. It's recoverable by just typing "cont" and it goes on. (dll/ntdll/ldr/ldrutils.c:1177) Overlapping DLL: C:\ReactOS\system32\oleaut32.dll WARNING: MmFlushVirtualMemory at ntoskrnl/mm/ARM3/virtual.c:1044 is UNIMPLEMENTED! fixme:(dll/win32/wintrust/register.c:1161) stub (dll/ntdll/ldr/ldrutils.c:1138) LDR: LdrpMapDll Relocating Image Name C:\ReactOS\system32\mshtml.dll (76650000 -> 014C0000) (dll/ntdll/ldr/ldrutils.c:1177) Overlapping DLL: C:\ReactOS\System32\setupapi.dll (ntoskrnl/se/semgr.c:299) SidInToken Calls: 40000 Assertion 'RtlCheckBit(&MiUserPfnBitMap, (ULONG)Page)' failed at ntoskrnl/mm/freelist.c line 127 Entered debugger on embedded INT3 at 0x0008:0x80904efe. kdb:> bt Eip: <NTOSKRNL.EXE:104eff (lib/rtl/i386/debug_asm.S:35 (_DbgBreakPoint@0))> Frames: <NTOSKRNL.EXE:c283d (ntoskrnl/mm/freelist.c:127 (MmRemoveLRUUserPage@4))> <NTOSKRNL.EXE:c18de (ntoskrnl/mm/balance.c:134 (MmReleasePageMemoryConsumer@8))> <NTOSKRNL.EXE:cbf6a (ntoskrnl/mm/section.c:2365 (MmPageOutSectionView@16))> <NTOSKRNL.EXE:c822c (ntoskrnl/mm/rmap.c:143 (MmPageOutPhysicalAddress@4))> <NTOSKRNL.EXE:c17a9 (ntoskrnl/mm/balance.c:177 (MmTrimUserMemory))> <NTOSKRNL.EXE:c141c (ntoskrnl/mm/balance.c:366 (MiBalancerThread@4))> <NTOSKRNL.EXE:f2972 (ntoskrnl/ps/thread.c:156 (PspSystemThreadStartup@8))> <NTOSKRNL.EXE:5a6a (ntoskrnl/ke/i386/thrdini.c:78 (KiThreadStartup@0))> <NTOSKRNL.EXE:f290e (ntoskrnl/ps/thread.c:625 (PsCreateSystemThread@28))> <fcdebd80> <NTOSKRNL.EXE:152e5 (ntoskrnl/ke/wait.c:527 (KeWaitForSingleObject@20))> <NTOSKRNL.EXE:c524e (ntoskrnl/mm/mminit.c:292 (MmMpwThreadMain@4))> <NTOSKRNL.EXE:f2972 (ntoskrnl/ps/thread.c:156 (PspSystemThreadStartup@8))> <NTOSKRNL.EXE:5a6a (ntoskrnl/ke/i386/thrdini.c:78 (KiThreadStartup@0))> <NTOSKRNL.EXE:f290e (ntoskrnl/ps/thread.c:625 (PsCreateSystemThread@28))> <fce4fab0> <00000001> kdb:> cont Assertion 'RtlCheckBit(&MiUserPfnBitMap, (ULONG)Page)' failed at ntoskrnl/mm/freelist.c line 127 Entered debugger on embedded INT3 at 0x0008:0x80904efe. kdb:> cont (subsystems/win32/win32k/ntuser/keyboard.c:1066) err: No Window for Translate. (dll/ntdll/ldr/ldrutils.c:1138) LDR: LdrpMapDll Relocating Image Name xul.dll (10000000 -> 01DB0000) (dll/ntdll/ldr/ldrutils.c:1177) Overlapping DLL: C:\ReactOS\system32\ \1.0.0\wine_gecko\xpcom.dll

13 years, 1 month

Re: [ros-dev] [ros-diffs] [tfaber] 54401: [ATL] - Fix buffer overflow in CComDynamicUnkArray::Add. Found by Coverity (CID 2474) [NDK] - Remove meaningless const attribute from pointer rvalues to make Coverity's life easier

by Timo Kreuzer

Am 16.11.2011 22:17, schrieb tfaber(a)svn.reactos.org: > Author: tfaber > Date: Wed Nov 16 21:17:38 2011 > New Revision: 54401 > > URL: http://svn.reactos.org/svn/reactos?rev=54401&view=rev > Log: > [ATL] - Fix buffer overflow in CComDynamicUnkArray::Add. Found by Coverity (CID 2474) > [NDK] - Remove meaningless const attribute from pointer rvalues to make Coverity's life easier > -#define SharedUserData ((KUSER_SHARED_DATA *CONST)USER_SHARED_DATA) > +#define SharedUserData ((KUSER_SHARED_DATA *)USER_SHARED_DATA) It is like this (with the const) in wdm.h #define SharedUserData ((KUSER_SHARED_DATA * const) KI_USER_SHARED_DATA) maybe its supposed to express that "SharedUserData" is a constant and not a variable... although that doesn't make much sense

13 years, 1 month

SendMessageW doubt/bug with ANSI LPARAM.

by victor martinez

>The Total Commander comboboxes for the left and right drive list >are Unicode. However, Total Commander calls >SendMessage(handle,CB_ADDSTRING,0,(LPARAM)ansitext); >to add items as ANSI text. This seems to work, but it's adding some >extra text at the end. If I understand correctly, Total Commander is calling SendMessage, which in this case is translated to SendMessageW (as the comboboxes are Unicode). So TC is calling SendMessageW to append an ANSI string to a Combobox. Let's give a look to SendMessageW implementation thanks to Doxygen: http://doxygen.reactos.org/da/d64/winuser_8h_a18e5b961d742150a18d3039b5dd88… 02161 Result = NtUserMessageCall( Wnd, 02162 KMMsg.message, 02163 KMMsg.wParam, 02164 KMMsg.lParam, 02165 (ULONG_PTR)&Result, 02166 FNID_SENDMESSAGE, 02167 FALSE); Line 2167 FALSE is the BOOL ANSI param of NtUserMessageCall. But in this case the BOOL ANSI should be TRUE as the string is really ANSI. So since this moment we are treating TC call ( SendMessageW(handle,CB_ADDSTRING,0,(LPARAM)ansitext); ) in the same way as we would be treating SendMessageW(handle,CB_ADDSTRING,0,(LPARAM)unicodetext); This seems a bug for me. Feel free to correct me, but seems that SendMessageW is able to set both kind of strings ANSI and UNICODE in Windows, while we are forcing to our SendMessageW implementation to treat them as UNICODE always. Am I wrong? This could be a big potential issue as this could affect to all the SendmessageW calls. This is all just a guess, so please feed me with your knowledge. Thanks a lot!

13 years, 1 month

1000 EUR for ReactOS - We have made it!

by Colin Finck

Hi all, Looking at https://verein.ing-diba.de/sonstiges/33378/reactos-deutschland-ev, we have scored the 810th place in the tough competition and just won 1000 EUR for the foundation! :-) Even if we lost our position in the top of the list, comparable German Open-Source foundations like KDE e.V. or Free Software Foundation Europe are both out of the game. I'd like to use this opportunity to thank every voter for the great support towards the project! Over 8000 votes in four weeks really shows that we still have a huge fan base. Best regards, Colin

13 years, 1 month

Re: [ros-dev] [ion] 54323: [KERNEL32]: Move the "curdir.c" APIs into path.c as well, as they are Path APIs. No code changes (just formatting and moving to DPRINTs).

by Aleksey Bragin

I'm getting questions, if it's "just formatting and no code changes", why author names are removed for good and not readded in the new file? WBR, Aleksey Bragin. On 07.11.2011 3:01, ion(a)svn.reactos.org wrote: > Author: ion > Date: Sun Nov 6 23:01:04 2011 > New Revision: 54323 > > URL: http://svn.reactos.org/svn/reactos?rev=54323&view=rev > Log: > [KERNEL32]: Move the "curdir.c" APIs into path.c as well, as they are Path APIs. No code changes (just formatting and moving to DPRINTs). > Removed: trunk/reactos/dll/win32/kernel32/client/file/curdir.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… > ============================================================================== > --- trunk/reactos/dll/win32/kernel32/client/file/curdir.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/kernel32/client/file/curdir.c (removed) > @@ -1,388 +1,0 @@ > -/* $Id$ > - * > - * COPYRIGHT: See COPYING in the top level directory > - * PROJECT: ReactOS system libraries > - * FILE: lib/kernel32/file/curdir.c > - * PURPOSE: Current directory functions > - * PROGRAMMER: Eric Kohl > - * Filip Navara > - * Steven Edwards > - * Thomas Weidenmueller > - * Gunnar Andre' Dalsnes > - * UPDATE HISTORY: > - * Created 30/09/98 > - */ >

13 years, 1 month

Send Messages

by James Tabor

Hi! What I have run across in regards of ReactOS send message subsystem, ros is not packing before co_MsqSendMessage and unpacking after co_IntCallWindowProc! Instead packing before co_IntCallWindowProc with send message. Does that not raise any questions? co_IntSendMessageWithCallBack seems to do it almost right, but IntCallWndProc/Ret should be called when calling the client via co_IntCallWindowProc and should pack before the call to MsqWakeQueue and then unpack after the call to co_IntCallWindowProc. Confused? Basing this on IntCallLowLevelEvent and co_IntCallLowLevelHook when the lParam is used to save information that could get lost in a stack switch or release. Setting up the pattern; Pack before co_MsqSendMessage or related friends and Unpack after calling co_IntCallWindowProc to client. Have co_MsqDispatchOneSentMessage call something other than co_IntSendMessage so the Packed data can be handled correctly when calling to the client via co_IntCallWindowProc. I'm sure Michael Martin has brought this up to me on many occasions. Let's see where this goes! Thanks, James

13 years, 1 month

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev November 2011