Ros-dev March 2011

ros-dev@reactos.org

34 participants
47 discussions

Re: [ros-dev] [ros-diffs] [jimtabor] 50933: [Win32k|User32] - Clarify the meaning and the

by Johannes Anderwald

> Author: jimtabor > Date: Mon Feb 28 06:31:44 2011 > New Revision: 50933 > > URL: http://svn.reactos.org/svn/reactos?rev=50933&view=rev > Log: > [Win32k|User32] > - Clarify the meaning and the use of 0, 1 and 2 for user window regions, wine never did. Noticing patches not corresponding in correctness and understanding, leaving potential crashes in the DCE code, which depend on these types. > - Patch based on Rafal Harabien patch, fixes wine msg SetWindowRgn test, see also bug 5959. This change breaks Winamp 5.601: (ntoskrnl/ps/thread.c:119) PS: Unhandled Kernel Mode Exception Pointers = 0xF86A8568 (ntoskrnl/ps/thread.c:126) Code c0000005 Addr F87D4C3E Info0 00000000 Info1 00000020 Info2 00000000 Info3 00000020 *** Fatal System Error: 0x0000007e (0xC0000005,0xF87D4C3E,0xF86A8A50,0xF86A8690) [7hEntered debugger on embedded INT3 at 0x0008:0x808fd45c.bt Eip: <ntoskrnl.exe:fd45d (lib/rtl/i386/debug_asm.S:39 (RtlpBreakWithStatusInstruction))> Frames: <ntoskrnl.exe:a902 (ntoskrnl/ke/bug.c:1110 (KeBugCheckWithTf@24))> <ntoskrnl.exe:aa4d (ntoskrnl/ke/bug.c:1438 (KeBugCheckEx@20))> <ntoskrnl.exe:ead94 (ntoskrnl/ps/thread.c:129 (PspUnhandledExceptionInSystemThread))> <ntoskrnl.exe:eadaf (ntoskrnl/ps/thread.c:159 (_SEHExcept.39966))> <ntoskrnl.exe:fa9fa (lib/pseh/i386/framebased-gcchack.c:132 (_SEH2FrameHandler))> <ntoskrnl.exe:fcecb (lib/rtl/i386/except_asm.s:183 (RtlpExecuteHandler2))> <ntoskrnl.exe:fce9f (lib/rtl/i386/except_asm.s:150 (RtlpExecuteHandlerForUnwind))> <ntoskrnl.exe:3222 (ntoskrnl/ke/i386/exp.c:938 (KiDispatchException@20))> <ntoskrnl.exe:36bd (ntoskrnl/ke/i386/exp.c:1137 (KiDispatchExceptionFromTrapFrame@28))> <ntoskrnl.exe:6941 (ntoskrnl/include/internal/arch/../i386/ke.h:597 (@KiTrap0EHandler@4))> <ntoskrnl.exe:f7408 (ntoskrnl/ke/i386/trap.s:99 (VfIsVerificationEnabled@8))> <win32k.sys:bac39 (subsystems/win32/win32k/objects/region.c:2104 (@RGNOBJAPI_Lock@8))> <win32k.sys:bb0b3 (subsystems/win32/win32k/objects/region.c:3753 (NtGdiPtInRegion@12))> <win32k.sys:71bbb (subsystems/win32/win32k/ntuser/msgqueue.c:248 (@co_MsqInsertMouseMessage@4))> <win32k.sys:5ded4 (subsystems/win32/win32k/ntuser/cursoricon.c:205 (UserSetCursorPos))> <win32k.sys:66630 (subsystems/win32/win32k/ntuser/input.c:1134 (@IntMouseInput@4))> <win32k.sys:66cca (subsystems/win32/win32k/ntuser/input.c:194 (@ProcessMouseInputData@8))> <win32k.sys:66fbf (subsystems/win32/win32k/ntuser/input.c:308 (MouseThreadMain@4))> <ntoskrnl.exe:eac86 (ntoskrnl/ps/thread.c:156 (PspSystemThreadStartup@8))> <ntoskrnl.exe:5936 (ntoskrnl/ke/i386/thrdini.c:78 (KiThreadStartup@0))> <ntoskrnl.exe:eac22 (ntoskrnl/ps/thread.c:625 (PsCreateSystemThread@28))> WBR, Johannes

14 years

Re: [ros-dev] [ros-diffs] [jgardou] 50991: [NTOSKRNL] - Print supported CPU features. - Simplify detection of non working but claimed SYSENTER support for intel processors - Workaround a virtualbox "feature" : claim that SY...

by Aleksey Bragin

On Mar 7, 2011, at 4:33 PM, jgardou(a)svn.reactos.org wrote: > Author: jgardou > /* Check if the CPU is too old to support SYSENTER */ > - if ((Prcb->CpuType < 6) || > - ((Prcb->CpuType == 6) && (Prcb->CpuStep < 0x0303))) > + if ((Reg[0] & 0x0FFF3FFF) < 0x00000633) > { It was intentionally done over CpuType and CpuStep. Now you criptified it back to a raw Reg[0] value and weird hardcoded constant. Could you please 1) elaborate this change and 2) if you still think it's correct, and if you still tihnk(!) Windows does it same way, then rework it to use Prcb->Cpu* instead of these magic values? Not to say adding a hack for VirtualBox is far from being a beautiful, and would need to be *at least* marked so that it's not forgotten. Thanks, Aleksey Bragin.

14 years

by Timo Kreuzer

Am 07.03.2011 14:33, schrieb jgardou(a)svn.reactos.org: > Author: jgardou > Date: Mon Mar 7 13:33:10 2011 > New Revision: 50991 > ... > + Reg[3] |= 0x800; > ... > + if ((Reg[0]& 0x0FFF3FFF)< 0x00000633) I'd prefer symbolic constants over these magic numbers. > + > + DPRINT1("Supported CPU features :\n"); > +#define print_supported(kf_value) \ > + if(FeatureBits& kf_value) DPRINT1("\t" #kf_value "\n") > + print_supported(KF_V86_VIS); > + print_supported(KF_RDTSC); > + print_supported(KF_CR4); > + print_supported(KF_CMOV); > + print_supported(KF_GLOBAL_PAGE); > + print_supported(KF_LARGE_PAGE); > + print_supported(KF_MTRR); > + print_supported(KF_CMPXCHG8B); > + print_supported(KF_MMX); > + print_supported(KF_WORKING_PTE); > + print_supported(KF_PAT); > + print_supported(KF_FXSR); > + print_supported(KF_FAST_SYSCALL); > + print_supported(KF_XMMI); > + print_supported(KF_3DNOW); > + print_supported(KF_AMDK6MTRR); > + print_supported(KF_XMMI64); > + print_supported(KF_DTS); > + print_supported(KF_NX_BIT); > + print_supported(KF_NX_DISABLED); > + print_supported(KF_NX_ENABLED); > +#undef print_supported Can we make this more compact please? Like "Supported CPU features: V86_VIS, RDTSC ..." Thanks, Timo

14 years

[ros-diffs] [jimtabor] 50987: [GDI32] - Remove the old SetDIBBits, it severed us well....

by James Tabor

[GDI32] - Remove the old SetDIBBits, it severed us well.... Hold on to the win32k call. - Tested, Area.exe, wine gdi32 bitmaps test, AbiWord 2.8.6, OOo 2.4.3, SM 2.0.11 and ReactOS applications. - Aimp 2.61.583 (FULL, painted okay), CoolPlayer 219, winamp 0.98d and winamp 2.95 (not FUll). The rest have drawing issue with DIB. See bug 5886. The sound applications have the same issue with revision 50933+ (region unassociated with the DC owner), except CoolPlayer and winamp 0.98d. There is also an issue with vbrun60spX too. I'm not sure how to move on and start compressed bitmaps. Thanks, James

14 years

Re: [ros-dev] [ros-diffs] [fireball] 50967: - Revert 47615. Please fix actual sysreg instead of adding inconsistency between 1st, 2nd and 3rd stages debugging connections. This should fix sysreg3's inability to do backtrace...

by Timo Kreuzer

Hmm... I remember I added it to enable the possibility for backtraces in 1st stage for sysreg. Why does it now cause the opposite? And why is there an inconsistency? In 2nd stage there is an option for debug mode, in 1st stage there is none, so using kdserial (which imo is appropriate way to do it, I always select it) as default is as consistent as using "normal" debug, getting the input from the keyboard driver. Just my 0,002 ct/kb Timo Am 04.03.2011 17:57, schrieb fireball(a)svn.reactos.org: > Author: fireball > Date: Fri Mar 4 16:57:56 2011 > New Revision: 50967 > > URL: http://svn.reactos.org/svn/reactos?rev=50967&view=rev > Log: > - Revert 47615. Please fix actual sysreg instead of adding inconsistency between 1st, 2nd and 3rd stages debugging connections. This should fix sysreg3's inability to do backtraces. > See issue #5811 for more details. > > Modified: > trunk/reactos/boot/bootdata/txtsetup.sif > > Modified: trunk/reactos/boot/bootdata/txtsetup.sif > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/txtsetup.sif… > ============================================================================== > --- trunk/reactos/boot/bootdata/txtsetup.sif [iso-8859-1] (original) > +++ trunk/reactos/boot/bootdata/txtsetup.sif [iso-8859-1] Fri Mar 4 16:57:56 2011 > @@ -59,7 +59,7 @@ > [SetupData] > DefaultPath = \ReactOS > OsLoadOptions = "/NOGUIBOOT /NODEBUG" > -DbgOsLoadOptions = "/NOGUIBOOT /DEBUGPORT=COM1 /FIRSTCHANCE /KDSERIAL" > +DbgOsLoadOptions = "/NOGUIBOOT /DEBUGPORT=COM1 /FIRSTCHANCE" > ;OsLoadOptions = "/NOGUIBOOT /DEBUGPORT=SCREEN" > ;OsLoadOptions = "/NOGUIBOOT /DEBUGPORT=BOCHS" > > > >

14 years

DHCP not working?

by Javier Agustìn Fernàndez Arroyo

Hi all, im testing ROS right now in real hardware... As i cannot log into IRC (via webchat.freenode.net, i cant even reach the page, i dont know why), let me post this in ML The think is, i have installed RealTek´s official driver for the NIC, and hardware is recognized... but, dhcp dont get any IP... any idea? log is attached btw, in the log there are many errors ("xxxx failed") about ndis.......

14 years

Re: [ros-dev] [ros-diffs] [tkreuzer] 50942: [WIN32K] Do raster operation on 4 bytes instead of only 3. Fixes ... maybe noone has noticed yet ; -)

by Colin Finck

tkreuzer(a)svn.reactos.org wrote: > Do raster operation on 4 bytes instead of only 3. Quoting jgardou's commit before: > - When applying raster operation, do so only on 24 bits, we don't > support alpha channel in win32k I have no idea about DIB code, but just from the commit message I presume that this change to 24 bits has happened deliberately. - Colin

14 years, 1 month

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev March 2011