On Mar 7, 2011, at 4:33 PM, jgardou(a)svn.reactos.org wrote:
> Author: jgardou
> /* Check if the CPU is too old to support SYSENTER */
> - if ((Prcb->CpuType < 6) ||
> - ((Prcb->CpuType == 6) && (Prcb->CpuStep < 0x0303)))
> + if ((Reg[0] & 0x0FFF3FFF) < 0x00000633)
> {
It was intentionally done over CpuType and CpuStep. Now you
criptified it back to a raw Reg[0] value and weird hardcoded
constant. Could you please 1) elaborate this change and 2) if you
still think it's correct, and if you still tihnk(!) Windows does it
same way, then rework it to use Prcb->Cpu* instead of these magic
values?
Not to say adding a hack for VirtualBox is far from being a
beautiful, and would need to be *at least* marked so that it's not
forgotten.
Thanks,
Aleksey Bragin.
[GDI32]
- Remove the old SetDIBBits, it severed us well.... Hold on to the win32k call.
- Tested, Area.exe, wine gdi32 bitmaps test, AbiWord 2.8.6, OOo 2.4.3,
SM 2.0.11 and ReactOS applications.
- Aimp 2.61.583 (FULL, painted okay), CoolPlayer 219, winamp 0.98d and
winamp 2.95 (not FUll). The rest have drawing issue with DIB. See bug
5886.
The sound applications have the same issue with revision 50933+
(region unassociated with the DC owner), except CoolPlayer and winamp
0.98d. There is also an issue with vbrun60spX too. I'm not sure how to
move on and start compressed bitmaps.
Thanks,
James
Hmm...
I remember I added it to enable the possibility for backtraces in 1st
stage for sysreg. Why does it now cause the opposite? And why is there
an inconsistency? In 2nd stage there is an option for debug mode, in 1st
stage there is none, so using kdserial (which imo is appropriate way to
do it, I always select it) as default is as consistent as using "normal"
debug, getting the input from the keyboard driver.
Just my 0,002 ct/kb
Timo
Am 04.03.2011 17:57, schrieb fireball(a)svn.reactos.org:
> Author: fireball
> Date: Fri Mar 4 16:57:56 2011
> New Revision: 50967
>
> URL: http://svn.reactos.org/svn/reactos?rev=50967&view=rev
> Log:
> - Revert 47615. Please fix actual sysreg instead of adding inconsistency between 1st, 2nd and 3rd stages debugging connections. This should fix sysreg3's inability to do backtraces.
> See issue #5811 for more details.
>
> Modified:
> trunk/reactos/boot/bootdata/txtsetup.sif
>
> Modified: trunk/reactos/boot/bootdata/txtsetup.sif
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/txtsetup.sif…
> ==============================================================================
> --- trunk/reactos/boot/bootdata/txtsetup.sif [iso-8859-1] (original)
> +++ trunk/reactos/boot/bootdata/txtsetup.sif [iso-8859-1] Fri Mar 4 16:57:56 2011
> @@ -59,7 +59,7 @@
> [SetupData]
> DefaultPath = \ReactOS
> OsLoadOptions = "/NOGUIBOOT /NODEBUG"
> -DbgOsLoadOptions = "/NOGUIBOOT /DEBUGPORT=COM1 /FIRSTCHANCE /KDSERIAL"
> +DbgOsLoadOptions = "/NOGUIBOOT /DEBUGPORT=COM1 /FIRSTCHANCE"
> ;OsLoadOptions = "/NOGUIBOOT /DEBUGPORT=SCREEN"
> ;OsLoadOptions = "/NOGUIBOOT /DEBUGPORT=BOCHS"
>
>
>
>
Hi all,
im testing ROS right now in real hardware... As i cannot log into IRC (via
webchat.freenode.net, i cant even reach the page, i dont know why), let me
post this in ML
The think is, i have installed RealTek´s official driver for the NIC, and
hardware is recognized... but, dhcp dont get any IP...
any idea?
log is attached
btw, in the log there are many errors ("xxxx failed") about ndis.......
tkreuzer(a)svn.reactos.org wrote:
> Do raster operation on 4 bytes instead of only 3.
Quoting jgardou's commit before:
> - When applying raster operation, do so only on 24 bits, we don't
> support alpha channel in win32k
I have no idea about DIB code, but just from the commit message I
presume that this change to 24 bits has happened deliberately.
- Colin