Ros-dev May 2011

ros-dev@reactos.org

27 participants
31 discussions

Re: [ros-dev] [EVENTVWR/EVENTLOG] Fix a double off-by-one bug

by Love Nystrom

Hi Eric, Sounds like you got it licked, the right way. Good job ! Best Regards L. 2011/5/6 <ros-dev-request(a)reactos.org> > From: Eric Kohl <eric.kohl(a)t-online.de> > To: ReactOS Development List <ros-dev(a)reactos.org> > Date: Thu, 05 May 2011 22:41:24 +0200 > Subject: Re: [ros-dev] [EVENTVWR/EVENTLOG] Fix a double off-by-one bug > Hi Love, > > I just committed a fix for the calculation of the available number of event > records. It addresses the issues you mentioned. > > And this is how it works: > When a new log file is created, the first (or oldest) record gets the > record number 1. With each new event record the record number is incremented > by 1. To get the number of records in the log file we need to subtract the > OldestRecordNumber from the CurrentRecordNumber. If the log file is empty > the OldestRecordNumber will be 0. In this case we will return 0 for the > number of event records. > > Now we call clear a filled log file and fill it with new records. The > oldest record will not be record number 1 but we can still return the true > number of records in the log file. > > > Regards > Eric >

13 years, 8 months

Re: [ros-dev] [freeldr] Add PXE "filesystem" (Aleksey Bragin)

by Love Nystrom

Hi Aleksey, I'm sorry if my opinion came across as critique of the work as such. It was definitely not intended that way. I have great respect for all your efforts. Just a point about unfortunate choice of AT&T syntax. I would gladly volunteer to translate all old AT&T code to Intel. After all, I do have 25 years of expertise in assembly coding. It's just that I'm completely bogged down by R.L and have no time. But if it can wait, just leave it be, and I'll do it later. I'm sure Timo has enough to do with other issues already. I abbreviated the pro's and con's to just two points, of which the 2nd applies just to gcc's inline asm syntax. Translating non-inline AT&T to Intel is fairly straight forward. InvalidateHarshMode(TRUE); No offence taken. Best Regards L. On 2011-05-05 14.58, "Aleksey Bragin" <aleksey(a)reactos.org> wrote: > SetHarshMode(TRUE); > > Your opinion would be interesting if it was motivated by your knowledge and experience in writing assembly > in both AT&T and Intel syntax, so that you could provide us pros and cons of each approach by your judgement. > > Or, if you would be author of that code part in ReactOS. > > Otherwise, I’m afraid, it’s just criticizing a very good work, didn’t even noticing the great PXE milestone, > but nitpicking to a syntax. Don’t join complaints if you can’t fix it. (Timo’s point is valid because that’s him who actually > converts this stuff!) > > SetHarshMode(FALSE); > > WBR, > Aleksey.

13 years, 8 months

ReactOS YouTube Channel

by Adam

I noticed this YouTube channel here - http://www.youtube.com/reactosorg - and apparently it seems to have 3 videos about ReactOS on it. Nothing seems to be uploaded to it for a little over 1 year and I was wondering perhaps it wouldn't be a bad idea to upload some videos about various events to it. I suspect a major issue with the lack of developers is lack of publicity and I think this seems like a good opportunity. (note I am not sure if it is the official ReactOS channel or not - if not time to make one - apparently it seems the person who made the channel is displaying the Age as 16 years old)

13 years, 8 months

Apologies

by Olaf Siejka

I am sorry to Vicmarcal for outbursting on ros-dev. The reason for that was yet another pointless bugreport, after my requestes, passed several times, regarding bug reports quality. Sorry, Vicmarcal, as well as those who had to witness it. Regards

13 years, 8 months

Vicmarcal - are you mad?

by Olaf Siejka

Bugzilla is crowded with untouched bugs for so long, and you HAVE to add more crud to it? Bugs like no.6214, very usefull as we can see below: "1)Download ClickToDesktop 2)Run in ReactOS 3)Click on the desktop to hide. It doesn't work. Apps just lost the focus. Nothing appears in the DebugLog." Now that is informative... Why dont you get back doing something useful for a change?

13 years, 8 months

Re: [ros-dev] [EVENTVWR/EVENTLOG] Fix a double off-by-one bug

by Love Nystrom

Hi Gabriel, Eric, Isn't the real issue why LogFile->Header.CurrentRecordNumber is off by one ? If that is found and fixed, this patch will make the error re-emerge as an off by -1. And if CurrentRecordNumber is actually used as the next *pending* record number, the identifier is somewhat mis-leading .. ? Just my penny to the pot Best Regards L. ---------- Forwarded message ---------- > From: Gabriel ilardi <gabrielilardi(a)hotmail.it> > To: ros-dev <ros-dev(a)reactos.org> > Date: Mon, 2 May 2011 21:50:03 +0200 > Subject: Re: [ros-dev] [ros-diffs] [ekohl] 51558: [EVENTVWR/EVENTLOG] Fix a > double off-by-one bug: - The eventlog service was reporting one event more > than was available (+1). - The event viewer did not display the latest event > from... > Great work on event service and event viewer... keep it up Eric :) > > > > Date: Mon, 2 May 2011 19:38:24 +0000 > > To: ros-diffs(a)reactos.org > > From: ekohl(a)svn.reactos.org > > Subject: [ros-diffs] [ekohl] 51558: [EVENTVWR/EVENTLOG] Fix a double > off-by-one bug: - The eventlog service was reporting one event more than was > available (+1). - The event viewer did not display the latest event from... > > > > Author: ekohl > > Date: Mon May 2 19:38:23 2011 > > New Revision: 51558 > > > > URL: http://svn.reactos.org/svn/reactos?rev=51558&view=rev > > Log: > > [EVENTVWR/EVENTLOG] > > Fix a double off-by-one bug: > > - The eventlog service was reporting one event more than was available > (+1). > > - The event viewer did not display the latest event from the eventlog > service (-1). > > > > See issue #6182 for more details. > > > > Modified: > > trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c > > trunk/reactos/base/services/eventlog/rpc.c > > > > Modified: trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c > > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… > > > ============================================================================== > > --- trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c > [iso-8859-1] (original) > > +++ trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c > [iso-8859-1] Mon May 2 19:38:23 2011 > > @@ -503,7 +503,7 @@ > > HWND hwndDlg; > > HANDLE hEventLog; > > EVENTLOGRECORD *pevlr; > > - DWORD dwRead, dwNeeded, dwThisRecord, dwTotalRecords = 0, > dwCurrentRecord = 1, dwRecordsToRead = 0, dwFlags, dwMaxLength; > > + DWORD dwRead, dwNeeded, dwThisRecord, dwTotalRecords = 0, > dwCurrentRecord = 0, dwRecordsToRead = 0, dwFlags, dwMaxLength; > > LPWSTR lpSourceName; > > LPWSTR lpComputerName; > > LPSTR lpData; > > > > Modified: trunk/reactos/base/services/eventlog/rpc.c > > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/eventlog/rpc… > > > ============================================================================== > > --- trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] (original) > > +++ trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] Mon May 2 > 19:38:23 2011 > > @@ -199,6 +199,7 @@ > > DWORD *NumberOfRecords) > > { > > PLOGHANDLE lpLogHandle; > > + DWORD dwRecords; > > > > lpLogHandle = ElfGetLogHandleEntryByHandle(LogHandle); > > if (!lpLogHandle) > > @@ -206,7 +207,9 @@ > > return STATUS_INVALID_HANDLE; > > } > > > > - *NumberOfRecords = lpLogHandle->LogFile->Header.CurrentRecordNumber; > > + dwRecords = lpLogHandle->LogFile->Header.CurrentRecordNumber; > > + > > + *NumberOfRecords = (dwRecords > 0) ? (dwRecords - 1) : 0; > > > > return STATUS_SUCCESS; > > } > > > > >

13 years, 9 months

Re: [ros-dev] [freeldr] Add PXE "filesystem" (Ged Murphy)

by Love Nystrom

Hi Ged, Yes of course I read Hervé's mail. I did not suggest that he should go about porting existing code, I just expressed my opinion that we shouldn't use AT&T for new code. As for porting the existing freeldr AT&T code, I guess I could, eventually, when I get time, if I can just get a firm enough grip on the AT&T directive voodoo, which is obscure. But in the short run, no, sorry, I'm really bogged down by RL :( (It's even hard to try and keep up with the mailing list) You wouldn't happen to have a good pointer for that obscure AT&T string voodoo? Best Regards L. On Tue, May 3, 2011 at 11:12 PM, <ros-dev-request(a)reactos.org> wrote: > Send Ros-dev mailing list submissions to > ros-dev(a)reactos.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://www.reactos.org/mailman/listinfo/ros-dev > or, via email, send a message with subject or body 'help' to > ros-dev-request(a)reactos.org > > You can reach the person managing the list at > ros-dev-owner(a)reactos.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Ros-dev digest..." > > Today's Topics: > > 1. Re: [EVENTVWR/EVENTLOG] Fix a double off-by-one bug (Love Nystrom) > 2. Re: [freeldr] Add PXE "filesystem" (Love Nystrom) > 3. Re: [freeldr] Add PXE "filesystem" (Ged Murphy) > > > ---------- Forwarded message ---------- > From: Love Nystrom <love.nystrom(a)gmail.com> > To: ros-dev(a)reactos.org > Date: Tue, 3 May 2011 21:52:40 +0700 > Subject: Re: [ros-dev] [EVENTVWR/EVENTLOG] Fix a double off-by-one bug > > Hi Gabriel, Eric, > > Isn't the real issue why LogFile->Header.CurrentRecordNumber is off by one > ? > If that is found and fixed, this patch will make the error re-emerge as an > off by -1. > And if CurrentRecordNumber is actually used as the next *pending* record > number, > the identifier is somewhat mis-leading .. ? > > Just my penny to the pot > Best Regards > L. > > ---------- Forwarded message ---------- >> From: Gabriel ilardi <gabrielilardi(a)hotmail.it> >> To: ros-dev <ros-dev(a)reactos.org> >> Date: Mon, 2 May 2011 21:50:03 +0200 >> Subject: Re: [ros-dev] [ros-diffs] [ekohl] 51558: [EVENTVWR/EVENTLOG] Fix >> a double off-by-one bug: - The eventlog service was reporting one event more >> than was available (+1). - The event viewer did not display the latest event >> from... >> Great work on event service and event viewer... keep it up Eric :) >> >> >> > Date: Mon, 2 May 2011 19:38:24 +0000 >> > To: ros-diffs(a)reactos.org >> > From: ekohl(a)svn.reactos.org >> > Subject: [ros-diffs] [ekohl] 51558: [EVENTVWR/EVENTLOG] Fix a double >> off-by-one bug: - The eventlog service was reporting one event more than was >> available (+1). - The event viewer did not display the latest event from... >> > >> > Author: ekohl >> > Date: Mon May 2 19:38:23 2011 >> > New Revision: 51558 >> > >> > URL: http://svn.reactos.org/svn/reactos?rev=51558&view=rev >> > Log: >> > [EVENTVWR/EVENTLOG] >> > Fix a double off-by-one bug: >> > - The eventlog service was reporting one event more than was available >> (+1). >> > - The event viewer did not display the latest event from the eventlog >> service (-1). >> > >> > See issue #6182 for more details. >> > >> > Modified: >> > trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c >> > trunk/reactos/base/services/eventlog/rpc.c >> > >> > Modified: trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c >> > URL: >> http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… >> > >> ============================================================================== >> > --- trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c >> [iso-8859-1] (original) >> > +++ trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c >> [iso-8859-1] Mon May 2 19:38:23 2011 >> > @@ -503,7 +503,7 @@ >> > HWND hwndDlg; >> > HANDLE hEventLog; >> > EVENTLOGRECORD *pevlr; >> > - DWORD dwRead, dwNeeded, dwThisRecord, dwTotalRecords = 0, >> dwCurrentRecord = 1, dwRecordsToRead = 0, dwFlags, dwMaxLength; >> > + DWORD dwRead, dwNeeded, dwThisRecord, dwTotalRecords = 0, >> dwCurrentRecord = 0, dwRecordsToRead = 0, dwFlags, dwMaxLength; >> > LPWSTR lpSourceName; >> > LPWSTR lpComputerName; >> > LPSTR lpData; >> > >> > Modified: trunk/reactos/base/services/eventlog/rpc.c >> > URL: >> http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/eventlog/rpc… >> > >> ============================================================================== >> > --- trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] (original) >> > +++ trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] Mon May 2 >> 19:38:23 2011 >> > @@ -199,6 +199,7 @@ >> > DWORD *NumberOfRecords) >> > { >> > PLOGHANDLE lpLogHandle; >> > + DWORD dwRecords; >> > >> > lpLogHandle = ElfGetLogHandleEntryByHandle(LogHandle); >> > if (!lpLogHandle) >> > @@ -206,7 +207,9 @@ >> > return STATUS_INVALID_HANDLE; >> > } >> > >> > - *NumberOfRecords = lpLogHandle->LogFile->Header.CurrentRecordNumber; >> > + dwRecords = lpLogHandle->LogFile->Header.CurrentRecordNumber; >> > + >> > + *NumberOfRecords = (dwRecords > 0) ? (dwRecords - 1) : 0; >> > >> > return STATUS_SUCCESS; >> > } >> > >> > >> > > > > ---------- Forwarded message ---------- > From: Love Nystrom <love.nystrom(a)gmail.com> > To: ros-dev(a)reactos.org > Date: Tue, 3 May 2011 22:35:30 +0700 > Subject: Re: [ros-dev] [freeldr] Add PXE "filesystem" > > Hi Hervé, > > No disrespect for your work, but I'm inclined to concur with Timo regrading > AT&T vs. Intel. > > Even though I usually preach "don't fix it if it isn't broken', I really > think that AT&T syntax > is broken by design, and we should use only Intel assembly, which is *much* > clearer. > After all, we're programming Intel CPU's, not AT&T telephone switchboards > ;) > > 1) AT&T does not conform with Intel instruction reference. > Intel syntax conforms with the instruction reference. > > 2) AT&T has a lot of quaint obscure directive voodoo. > What little directives exist in Intel is clear and concise. > > Eventually, I hope we'll get rid of all backwards & muddy AT&T assembly, > but until then I think we should at least not use it for new code. > > Best Regards > L. > > > ---------- Forwarded message ---------- >> From: "Hervé Poussineau" <hpoussin(a)reactos.org> >> To: ReactOS Development List <ros-dev(a)reactos.org> >> Date: Mon, 02 May 2011 19:33:19 +0200 >> Subject: Re: [ros-dev] [ros-diffs] [hpoussin] 51517: [freeldr] Add PXE >> "filesystem" >> Hi, >> >> The file is in AT&T syntax, as all asm files in >> reactos/boot/freeldr/freeldr/arch/i386/ , except fathelp.asm >> Sorry, I won't "fix" it, so you'll have to find someone to do it. >> >> Regards, >> >> Hervé >> >> Timo Kreuzer a écrit : >> >>> >>> Why did you write the asm code in AT&T syntax? Its both ugly and breaks >>> compilation with MSVC. >>> I've spent quite some time converting all asm code to MSVC friendly intel >>> syntax. >>> Could you please fix that? >>> >>> Regards, >>> Timo >>> >>> Am 01.05.2011 10:11, schrieb hpoussin(a)svn.reactos.org: >>> >>>> Author: hpoussin >>>> Date: Sun May 1 08:11:43 2011 >>>> New Revision: 51517 >>>> >>>> URL: http://svn.reactos.org/svn/reactos?rev=51517&view=rev >>>> Log: >>>> [freeldr] Add PXE "filesystem" >>>> >>>> Added: >>>> trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S (with >>>> props) >>>> trunk/reactos/boot/freeldr/freeldr/fs/pxe.c (with props) >>>> trunk/reactos/boot/freeldr/freeldr/include/arch/i386/pxe.h (with >>>> props) >>>> trunk/reactos/boot/freeldr/freeldr/include/fs/pxe.h (with props) >>>> Modified: >>>> trunk/reactos/boot/freeldr/freeldr/arch/i386/machpc.c >>>> trunk/reactos/boot/freeldr/freeldr/arch/i386/pcdisk.c >>>> trunk/reactos/boot/freeldr/freeldr/freeldr_base.rbuild >>>> trunk/reactos/boot/freeldr/freeldr/freeldr_base64k.rbuild >>>> trunk/reactos/boot/freeldr/freeldr/fs/fs.c >>>> trunk/reactos/boot/freeldr/freeldr/include/arch/i386/hardware.h >>>> trunk/reactos/boot/freeldr/freeldr/include/arch/i386/machpc.h >>>> trunk/reactos/boot/freeldr/freeldr/include/freeldr.h >>>> >>>> Added: trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S >>>> URL: >>>> http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… >>>> ============================================================================== >>>> >>>> --- trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S (added) >>>> +++ trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S [iso-8859-1] >>>> Sun May 1 08:11:43 2011 >>>> @@ -1,0 +1,97 @@ >>>> +/* >>>> + * FreeLoader >>>> + * Copyright (C) 2011 Hervé Poussineau >>>> + * >>>> + * This program is free software; you can redistribute it and/or >>>> modify >>>> + * it under the terms of the GNU General Public License as published >>>> by >>>> + * the Free Software Foundation; either version 2 of the License, or >>>> + * (at your option) any later version. >>>> + * >>>> + * This program is distributed in the hope that it will be useful, >>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>> + * GNU General Public License for more details. >>>> + * >>>> + * You should have received a copy of the GNU General Public License >>>> along >>>> + * with this program; if not, write to the Free Software Foundation, >>>> Inc., >>>> + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >>>> + */ >>>> + >>>> + .text >>>> + .code16 >>>> + >>>> +#define ASM >>>> + >>>> +#include<arch.h> >>>> + >>>> +/* >>>> + * U16 PxeCallApi(U16 Segment, U16 Offset, U16 Service, VOID >>>> *Parameter); >>>> + * >>>> + * RETURNS: >>>> + */ >>>> +_pxe_function: >>>> + .word 0 >>>> +_pxe_entry_point: >>>> + .long 0 >>>> +_pxe_buffer_segment: >>>> + .word0 >>>> +_pxe_buffer_offset: >>>> + .word0 >>>> +_pxe_result: >>>> + .word 0 >>>> + >>>> +EXTERN(_PxeCallApi) >>>> + .code32 >>>> + pushl %ebp >>>> + movl %esp,%ebp >>>> + >>>> + >>>> >>> > > > ---------- Forwarded message ---------- > From: "Ged Murphy" <gedmurphy(a)gmail.com> > To: "'ReactOS Development List'" <ros-dev(a)reactos.org> > Date: Tue, 3 May 2011 17:12:03 +0100 > Subject: Re: [ros-dev] [freeldr] Add PXE "filesystem" > > Did you read Herve’s email?? > > Are you volunteering to convert all the files he mentioned into intel > syntax? > > > > > > *From:* ros-dev-bounces(a)reactos.org [mailto:ros-dev-bounces@reactos.org] *On > Behalf Of *Love Nystrom > *Sent:* 03 May 2011 16:36 > *To:* ros-dev(a)reactos.org > *Subject:* Re: [ros-dev] [freeldr] Add PXE "filesystem" > > > > > > Hi Hervé, > > > > No disrespect for your work, but I'm inclined to concur with Timo regrading > AT&T vs. Intel. > > > > Even though I usually preach "don't fix it if it isn't broken', I really > think that AT&T syntax > > is broken by design, and we should use only Intel assembly, which is *much* > clearer. > > After all, we're programming Intel CPU's, not AT&T telephone switchboards > ;) > > > > 1) AT&T does not conform with Intel instruction reference. > > Intel syntax conforms with the instruction reference. > > > > 2) AT&T has a lot of quaint obscure directive voodoo. > > What little directives exist in Intel is clear and concise. > > > > Eventually, I hope we'll get rid of all backwards & muddy AT&T assembly, > > but until then I think we should at least not use it for new code. > > > > Best Regards > > L. > > > > > > ---------- Forwarded message ---------- > From: "Hervé Poussineau" <hpoussin(a)reactos.org> > To: ReactOS Development List <ros-dev(a)reactos.org> > Date: Mon, 02 May 2011 19:33:19 +0200 > Subject: Re: [ros-dev] [ros-diffs] [hpoussin] 51517: [freeldr] Add PXE > "filesystem" > Hi, > > The file is in AT&T syntax, as all asm files in > reactos/boot/freeldr/freeldr/arch/i386/ , except fathelp.asm > Sorry, I won't "fix" it, so you'll have to find someone to do it. > > Regards, > > Hervé > > Timo Kreuzer a écrit : > > > Why did you write the asm code in AT&T syntax? Its both ugly and breaks > compilation with MSVC. > I've spent quite some time converting all asm code to MSVC friendly intel > syntax. > Could you please fix that? > > Regards, > Timo > > Am 01.05.2011 10:11, schrieb hpoussin(a)svn.reactos.org: > > Author: hpoussin > Date: Sun May 1 08:11:43 2011 > New Revision: 51517 > > URL: http://svn.reactos.org/svn/reactos?rev=51517&view=rev > Log: > [freeldr] Add PXE "filesystem" > > Added: > trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S (with props) > trunk/reactos/boot/freeldr/freeldr/fs/pxe.c (with props) > trunk/reactos/boot/freeldr/freeldr/include/arch/i386/pxe.h (with > props) > trunk/reactos/boot/freeldr/freeldr/include/fs/pxe.h (with props) > Modified: > trunk/reactos/boot/freeldr/freeldr/arch/i386/machpc.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/pcdisk.c > trunk/reactos/boot/freeldr/freeldr/freeldr_base.rbuild > trunk/reactos/boot/freeldr/freeldr/freeldr_base64k.rbuild > trunk/reactos/boot/freeldr/freeldr/fs/fs.c > trunk/reactos/boot/freeldr/freeldr/include/arch/i386/hardware.h > trunk/reactos/boot/freeldr/freeldr/include/arch/i386/machpc.h > trunk/reactos/boot/freeldr/freeldr/include/freeldr.h > > Added: trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > ============================================================================== > > --- trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S (added) > +++ trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S [iso-8859-1] Sun > May 1 08:11:43 2011 > @@ -1,0 +1,97 @@ > +/* > + * FreeLoader > + * Copyright (C) 2011 Hervé Poussineau > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > along > + * with this program; if not, write to the Free Software Foundation, > Inc., > + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > + */ > + > + .text > + .code16 > + > +#define ASM > + > +#include<arch.h> > + > +/* > + * U16 PxeCallApi(U16 Segment, U16 Offset, U16 Service, VOID *Parameter); > + * > + * RETURNS: > + */ > +_pxe_function: > + .word 0 > +_pxe_entry_point: > + .long 0 > +_pxe_buffer_segment: > + .word0 > +_pxe_buffer_offset: > + .word0 > +_pxe_result: > + .word 0 > + > +EXTERN(_PxeCallApi) > + .code32 > + pushl %ebp > + movl %esp,%ebp > + > + > > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

13 years, 9 months

Re: [ros-dev] [freeldr] Add PXE "filesystem"

by Love Nystrom

Hi Hervé, No disrespect for your work, but I'm inclined to concur with Timo regrading AT&T vs. Intel. Even though I usually preach "don't fix it if it isn't broken', I really think that AT&T syntax is broken by design, and we should use only Intel assembly, which is *much* clearer. After all, we're programming Intel CPU's, not AT&T telephone switchboards ;) 1) AT&T does not conform with Intel instruction reference. Intel syntax conforms with the instruction reference. 2) AT&T has a lot of quaint obscure directive voodoo. What little directives exist in Intel is clear and concise. Eventually, I hope we'll get rid of all backwards & muddy AT&T assembly, but until then I think we should at least not use it for new code. Best Regards L. ---------- Forwarded message ---------- > From: "Hervé Poussineau" <hpoussin(a)reactos.org> > To: ReactOS Development List <ros-dev(a)reactos.org> > Date: Mon, 02 May 2011 19:33:19 +0200 > Subject: Re: [ros-dev] [ros-diffs] [hpoussin] 51517: [freeldr] Add PXE > "filesystem" > Hi, > > The file is in AT&T syntax, as all asm files in > reactos/boot/freeldr/freeldr/arch/i386/ , except fathelp.asm > Sorry, I won't "fix" it, so you'll have to find someone to do it. > > Regards, > > Hervé > > Timo Kreuzer a écrit : > >> >> Why did you write the asm code in AT&T syntax? Its both ugly and breaks >> compilation with MSVC. >> I've spent quite some time converting all asm code to MSVC friendly intel >> syntax. >> Could you please fix that? >> >> Regards, >> Timo >> >> Am 01.05.2011 10:11, schrieb hpoussin(a)svn.reactos.org: >> >>> Author: hpoussin >>> Date: Sun May 1 08:11:43 2011 >>> New Revision: 51517 >>> >>> URL: http://svn.reactos.org/svn/reactos?rev=51517&view=rev >>> Log: >>> [freeldr] Add PXE "filesystem" >>> >>> Added: >>> trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S (with props) >>> trunk/reactos/boot/freeldr/freeldr/fs/pxe.c (with props) >>> trunk/reactos/boot/freeldr/freeldr/include/arch/i386/pxe.h (with >>> props) >>> trunk/reactos/boot/freeldr/freeldr/include/fs/pxe.h (with props) >>> Modified: >>> trunk/reactos/boot/freeldr/freeldr/arch/i386/machpc.c >>> trunk/reactos/boot/freeldr/freeldr/arch/i386/pcdisk.c >>> trunk/reactos/boot/freeldr/freeldr/freeldr_base.rbuild >>> trunk/reactos/boot/freeldr/freeldr/freeldr_base64k.rbuild >>> trunk/reactos/boot/freeldr/freeldr/fs/fs.c >>> trunk/reactos/boot/freeldr/freeldr/include/arch/i386/hardware.h >>> trunk/reactos/boot/freeldr/freeldr/include/arch/i386/machpc.h >>> trunk/reactos/boot/freeldr/freeldr/include/freeldr.h >>> >>> Added: trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S >>> URL: >>> http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… >>> ============================================================================== >>> >>> --- trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S (added) >>> +++ trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S [iso-8859-1] >>> Sun May 1 08:11:43 2011 >>> @@ -1,0 +1,97 @@ >>> +/* >>> + * FreeLoader >>> + * Copyright (C) 2011 Hervé Poussineau >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU General Public License as published by >>> + * the Free Software Foundation; either version 2 of the License, or >>> + * (at your option) any later version. >>> + * >>> + * This program is distributed in the hope that it will be useful, >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> + * GNU General Public License for more details. >>> + * >>> + * You should have received a copy of the GNU General Public License >>> along >>> + * with this program; if not, write to the Free Software Foundation, >>> Inc., >>> + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >>> + */ >>> + >>> + .text >>> + .code16 >>> + >>> +#define ASM >>> + >>> +#include<arch.h> >>> + >>> +/* >>> + * U16 PxeCallApi(U16 Segment, U16 Offset, U16 Service, VOID >>> *Parameter); >>> + * >>> + * RETURNS: >>> + */ >>> +_pxe_function: >>> + .word 0 >>> +_pxe_entry_point: >>> + .long 0 >>> +_pxe_buffer_segment: >>> + .word0 >>> +_pxe_buffer_offset: >>> + .word0 >>> +_pxe_result: >>> + .word 0 >>> + >>> +EXTERN(_PxeCallApi) >>> + .code32 >>> + pushl %ebp >>> + movl %esp,%ebp >>> + >>> + >>> >>

13 years, 9 months

Re: [ros-dev] [ros-diffs] [ekohl] 51558: [EVENTVWR/EVENTLOG] Fix a double off-by-one bug: - The eventlog service was reporting one event more than was available (+1). - The event viewer did not display the latest event from...

by Gabriel ilardi

Great work on event service and event viewer... keep it up Eric :) > Date: Mon, 2 May 2011 19:38:24 +0000 > To: ros-diffs(a)reactos.org > From: ekohl(a)svn.reactos.org > Subject: [ros-diffs] [ekohl] 51558: [EVENTVWR/EVENTLOG] Fix a double off-by-one bug: - The eventlog service was reporting one event more than was available (+1). - The event viewer did not display the latest event from... > > Author: ekohl > Date: Mon May 2 19:38:23 2011 > New Revision: 51558 > > URL: http://svn.reactos.org/svn/reactos?rev=51558&view=rev > Log: > [EVENTVWR/EVENTLOG] > Fix a double off-by-one bug: > - The eventlog service was reporting one event more than was available (+1). > - The event viewer did not display the latest event from the eventlog service (-1). > > See issue #6182 for more details. > > Modified: > trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c > trunk/reactos/base/services/eventlog/rpc.c > > Modified: trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… > ============================================================================== > --- trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c [iso-8859-1] Mon May 2 19:38:23 2011 > @@ -503,7 +503,7 @@ > HWND hwndDlg; > HANDLE hEventLog; > EVENTLOGRECORD *pevlr; > - DWORD dwRead, dwNeeded, dwThisRecord, dwTotalRecords = 0, dwCurrentRecord = 1, dwRecordsToRead = 0, dwFlags, dwMaxLength; > + DWORD dwRead, dwNeeded, dwThisRecord, dwTotalRecords = 0, dwCurrentRecord = 0, dwRecordsToRead = 0, dwFlags, dwMaxLength; > LPWSTR lpSourceName; > LPWSTR lpComputerName; > LPSTR lpData; > > Modified: trunk/reactos/base/services/eventlog/rpc.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/eventlog/rpc… > ============================================================================== > --- trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] (original) > +++ trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] Mon May 2 19:38:23 2011 > @@ -199,6 +199,7 @@ > DWORD *NumberOfRecords) > { > PLOGHANDLE lpLogHandle; > + DWORD dwRecords; > > lpLogHandle = ElfGetLogHandleEntryByHandle(LogHandle); > if (!lpLogHandle) > @@ -206,7 +207,9 @@ > return STATUS_INVALID_HANDLE; > } > > - *NumberOfRecords = lpLogHandle->LogFile->Header.CurrentRecordNumber; > + dwRecords = lpLogHandle->LogFile->Header.CurrentRecordNumber; > + > + *NumberOfRecords = (dwRecords > 0) ? (dwRecords - 1) : 0; > > return STATUS_SUCCESS; > } > >

13 years, 9 months

Re: [ros-dev] [ros-diffs] [hpoussin] 51517: [freeldr] Add PXE "filesystem"

by Timo Kreuzer

Why did you write the asm code in AT&T syntax? Its both ugly and breaks compilation with MSVC. I've spent quite some time converting all asm code to MSVC friendly intel syntax. Could you please fix that? Regards, Timo Am 01.05.2011 10:11, schrieb hpoussin(a)svn.reactos.org: > Author: hpoussin > Date: Sun May 1 08:11:43 2011 > New Revision: 51517 > > URL: http://svn.reactos.org/svn/reactos?rev=51517&view=rev > Log: > [freeldr] Add PXE "filesystem" > > Added: > trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S (with props) > trunk/reactos/boot/freeldr/freeldr/fs/pxe.c (with props) > trunk/reactos/boot/freeldr/freeldr/include/arch/i386/pxe.h (with props) > trunk/reactos/boot/freeldr/freeldr/include/fs/pxe.h (with props) > Modified: > trunk/reactos/boot/freeldr/freeldr/arch/i386/machpc.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/pcdisk.c > trunk/reactos/boot/freeldr/freeldr/freeldr_base.rbuild > trunk/reactos/boot/freeldr/freeldr/freeldr_base64k.rbuild > trunk/reactos/boot/freeldr/freeldr/fs/fs.c > trunk/reactos/boot/freeldr/freeldr/include/arch/i386/hardware.h > trunk/reactos/boot/freeldr/freeldr/include/arch/i386/machpc.h > trunk/reactos/boot/freeldr/freeldr/include/freeldr.h > > Added: trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S (added) > +++ trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S [iso-8859-1] Sun May 1 08:11:43 2011 > @@ -1,0 +1,97 @@ > +/* > + * FreeLoader > + * Copyright (C) 2011 Hervé Poussineau > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, write to the Free Software Foundation, Inc., > + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > + */ > + > + .text > + .code16 > + > +#define ASM > + > +#include<arch.h> > + > +/* > + * U16 PxeCallApi(U16 Segment, U16 Offset, U16 Service, VOID *Parameter); > + * > + * RETURNS: > + */ > +_pxe_function: > + .word 0 > +_pxe_entry_point: > + .long 0 > +_pxe_buffer_segment: > + .word0 > +_pxe_buffer_offset: > + .word0 > +_pxe_result: > + .word 0 > + > +EXTERN(_PxeCallApi) > + .code32 > + pushl %ebp > + movl %esp,%ebp > + > +

13 years, 9 months

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev May 2011