You need to cast to volatile.
(Same for Increment).
There's also no need to return the old value.
--
Best regards,
Alex Ionescu
On 2011-06-02, at 1:43 PM, pschweitzer(a)svn.reactos.org wrote:
> + OldValue = (*Ulong)--;
With all my respect to the hard work put into this, I want to express
my concerns:
Why is there a need to develop a half-done fdc, if there is a full,
working, tested by millions driver available even in old DDKs, which
we can use without violating its license?
Why waste time writing that driver from scratch now when we could
just import DDK's one and spend time fixing our PnP manager instead,
and other involved components so that DDK's driver actually works?
Again, with all my respect to Cameron, he does a great job, but when
he disappears next time for a year or two, who is going to finish
FDC? Or any other of his half-finished branches? (each being really a
pearl if it's done).
I would really suggest using all available resources first and only
then spend time developing our own stuff instead of already existing.
Thanks for understanding,
Aleksey.
On Jun 2, 2011, at 10:24 AM, cgutman(a)svn.reactos.org wrote:
> Author: cgutman
> Date: Thu Jun 2 06:24:25 2011
> New Revision: 52055
>
> URL: http://svn.reactos.org/svn/reactos?rev=52055&view=rev
> Log:
> [FDC]
> - Implement fdc.sys (still needs work but fairly complete)
> [TXTSETUP.SIF]
> - Load fdc.sys for floppy controllers
> [FDC.INF]
> - Install fdc.sys for floppy controllers
>
> Added:
> trunk/reactos/drivers/storage/fdc/CMakeLists.txt (with props)
> trunk/reactos/drivers/storage/fdc/directory.rbuild (with props)
> trunk/reactos/drivers/storage/fdc/fdc/CMakeLists.txt (with
> props)
> trunk/reactos/drivers/storage/fdc/fdc/SOURCES (with props)
> trunk/reactos/drivers/storage/fdc/fdc/fdc.c (with props)
> trunk/reactos/drivers/storage/fdc/fdc/fdc.h (with props)
> trunk/reactos/drivers/storage/fdc/fdc/fdc.rbuild (with props)
> trunk/reactos/drivers/storage/fdc/fdc/fdc.rc (with props)
> trunk/reactos/drivers/storage/fdc/fdc/fdo.c (with props)
> trunk/reactos/drivers/storage/fdc/fdc/pdo.c (with props)
> Modified:
> trunk/reactos/boot/bootdata/txtsetup.sif
> trunk/reactos/drivers/storage/CMakeLists.txt
> trunk/reactos/drivers/storage/directory.rbuild
> trunk/reactos/media/inf/fdc.inf
>
