Ros-dev July 2011

ros-dev@reactos.org

22 participants
21 discussions

Start a nNew thread

[ros-diffs] [gadamopoulos] 52716: [win32k] - Fix TrackMouseEvent. Now hot tracking really works

by James Tabor

If it passes all the wine tests w/o the intermittent hits and misses! SYNC it to HEAD!

13 years, 11 months

July Meeting Minutes

by Colin Finck

Hello all, Today's planned meeting has been postponed to the 25th August (the time of the next regular meeting) based on a voting of the participants present at 19:39 UTC. These were: * Giannis Adamopoulos * Javier Agustìn Fernàndez Arroyo * Maciej Bialas * Thomas Faber * Colin Finck * Ziliang Guo * Cameron Gutman * Rafal Harabien * Timo Kreuzer * Matthias Kupfer * Igor Paliychuk * Sylvain Petreolle * Daniel Reimer * Pierre Schweitzer * Samuel Serapion * Olaf Siejka ○ Result: [19:44] <VoteBot> Question: Please vote for a date for postponing this meeting. [19:44] <VoteBot> Answers: [19:44] <VoteBot> Abstention - 7 votes [19:44] <VoteBot> 11th August (in 2 weeks) - 3 votes [19:44] <VoteBot> 25th August (in 4 weeks, regular next meeting) - 6 votes [19:44] <VoteBot> Total number of votes: 16 ○ Main reasons were that the following people were still not present at the time of voting: * Aleksey Bragin (supposed meeting leader and key person in the Arwinss and Release preparation agenda points) * Amine Khaldi (supposed backup meeting leader and key person in the CMake agenda point) * Ged Murphy (key person in the GSoC and Driver Signing agenda points) ○ Unfortunately, nobody has been prepared for this kind of situation, so a lot of time has been wasted and confusing decisions might have been made. ○ Postponing the points also gives Aleksey time to prepare a new Arwinss build and the Build Environment guys (Daniel, me, anybody wants to join?) time to prepare a final CMake version of RosBE, which might be a factor when deciding about doing the migration to CMake. ○ The IRC Server has been closed at 20:03 UTC. To allow the participants to get an unbiased idea about today's meeting, I will post the original IRC log by the server to ros-priv. Would actually like to make it public on ros-dev as well, but will abstain from doing so until Ged's confusion about the openness of our meetings is cleared. If people have already prepared texts for this meeting (status updates, whatever else you wanted to say), please send them to my E-Mail address within the next 3 days and I'll compose a summary out of them, which I will send to ros-dev. If you think that these texts don't just deserve a simple summary, keep them for the next meeting or do whatever you want about them. And finally a personal note: Please keep in mind that it was not an easy decision for me to just close the IRC Server after I believed that main discussions were over. If I had left it running, it would have invalidated the voting (again) and participants would have treated the meeting even more as a joke. By closing it, I obviously received complaints from people who had prepared stuff for this meeting and wanted to revive it. In good hopes, Colin

14 years

Monthly status meeting reminder

by Aleksey Bragin

Hello, Let me invite you to the monthly status meeting taking place last thursday of this month, 28th of July, 19:00 UTC. The meeting will be at irc://fezile.reactos.org (Port 6667, no SSL) in the channel #meeting. Note that the IRC service will only be started shortly before the meeting. Everyone is invited to listen, and active community members have their passwords so that they can participate in the discussion. If someone doesn't have a password - please don't hesitate to email Colin to get one. Colin - would you publish the most up-to-date list of participants? Proposed agenda for the meeting: 1. Arwinss adoption voting. 2. CMake status report?. (Do we need to decide anything? If not, then let's move discussion to the mailing list) 3. Release preparation status report. (Decide when to do winesyncs and branch off the release) More suggestions are welcome. With the best regards, Aleksey Bragin.

14 years

Re: [ros-dev] [ros-diffs] [dgorbachev] 52916: [CDFS] Workaround for GCC 4.6 optimizer bug (ICE when compiling with -O3).

by Timo Kreuzer

Can you explain this one in detail? Am 27.07.2011 04:37, schrieb dgorbachev(a)svn.reactos.org: > Author: dgorbachev > Date: Wed Jul 27 02:37:40 2011 > New Revision: 52916 > > URL: http://svn.reactos.org/svn/reactos?rev=52916&view=rev > Log: > [CDFS] > Workaround for GCC 4.6 optimizer bug (ICE when compiling with -O3). > > Modified: > trunk/reactos/drivers/filesystems/cdfs/fsctl.c > > Modified: trunk/reactos/drivers/filesystems/cdfs/fsctl.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs/f… > ============================================================================== > --- trunk/reactos/drivers/filesystems/cdfs/fsctl.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/cdfs/fsctl.c [iso-8859-1] Wed Jul 27 02:37:40 2011 > @@ -63,10 +63,10 @@ > for (i = 0; i< 2048; i += 4) > { > /* DON'T optimize this to ULONG!!! (breaks overflow) */ > + Serial.Part[3] += Buffer[i+0]; > + Serial.Part[2] += Buffer[i+1]; > + Serial.Part[1] += Buffer[i+2]; > Serial.Part[0] += Buffer[i+3]; > - Serial.Part[1] += Buffer[i+2]; > - Serial.Part[2] += Buffer[i+1]; > - Serial.Part[3] += Buffer[i+0]; > } > CdInfo->SerialNumber = Serial.Value; > > > >

14 years

Re: [ros-dev] [ros-diffs] [rharabien] 52892: [DESK] - Fix #6262: each new applied color scheme increase the window title height by one - Don't read REG_QWORD directly to DWORD variable

by Jérôme Gardou

Le 26/07/2011 12:51, rharabien(a)svn.reactos.org a écrit : > - theme->Size[i] = GetSystemMetrics(g_SizeMetric[i]); > + theme->Size[i] = GetSystemMetrics(g_SizeMetric[i]); if(i == SIZE_CAPTION_Y) OutputDebugStringA("GetSystemMetrics!\n"); > This looks strange ;-)

14 years

cmake rant

by Timo Kreuzer

Hi, Several times now cmake build has been broken. Time for some action! Last meeting I asked everyone to test/use cmake. It was also mentioned that if questions arise, we (Amine and me) would be happy to help out. I can't remember anyone has asked how it works, so I assume noone had any problems. There's also a pretty good wiki entry describing the whole procedure for n00bs. Now people tell me it's complicated, people are complaining that its ridiculous to have 2 build systems, etc. And probably noone has ever tried it. We really need to move on. I don't like having 2 build systems as well. Current blocker is the debugging which has some issues, Arty is working on that. Another problem is a boot problem on real hardware, but no I don't know on which configuration it doesn't work, so we need more people testing it on their real hardware setup and report any issues. Here's a list with current issues: http://www.reactos.org/wiki/CMake_Todo So please: If you are missing something, let us know. If you like to make it better, make suggestions. But stop ignoring cmake! If noone cares and everyone just thinks he can give a s^Z damn until we officially switch, then we can as well delete all cmake stuff and keep rbuild. It has a lot of awesome advantages, like you only have to type one command to build everything and you don't need to install cmake and you can export whatever you want from kernel32 even if the functions don't exist. Also you can enjoy the rbuild-loop again and again. Or we can do it the hard way and delete rbuild, so people are forced to use cmake. I'm sure this approach would be *really* appreaciated. Thanks, Timo

14 years, 1 month

Re: [ros-dev] [ros-diffs] [jgardou] 52840: [CRT] - get back atexit handling as it was before. (reverts 52838, 52829, 52828) Thanks to Kai and Timo for the explanation

by Jérôme Gardou

Reverts 52836, 52829 and 52828, sorry. Le 24/07/2011 18:45, jgardou(a)svn.reactos.org a écrit : > Author: jgardou > Date: Sun Jul 24 16:45:41 2011 > New Revision: 52840 > > URL: http://svn.reactos.org/svn/reactos?rev=52840&view=rev > Log: > [CRT] > - get back atexit handling as it was before. > (reverts 52838, 52829, 52828) > Thanks to Kai and Timo for the explanation > > Modified: > trunk/reactos/dll/win32/msvcrt/msvcrt.spec > trunk/reactos/dll/win32/msvcrt20/msvcrt20.spec > trunk/reactos/dll/win32/msvcrt40/msvcrt40.spec > trunk/reactos/lib/3rdparty/mingw/crtexe.c > trunk/reactos/lib/3rdparty/mingw/mingw.rbuild > trunk/reactos/lib/sdk/crt/msvcrtex.cmake > trunk/reactos/lib/sdk/crt/startup/crtdll.c > trunk/reactos/lib/sdk/crt/startup/crtexe.c > > Modified: trunk/reactos/dll/win32/msvcrt/msvcrt.spec > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt/msvcrt.sp… > ============================================================================== > --- trunk/reactos/dll/win32/msvcrt/msvcrt.spec [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/msvcrt/msvcrt.spec [iso-8859-1] Sun Jul 24 16:45:41 2011 > @@ -1156,7 +1156,7 @@ > @ cdecl asin(double) > @ cdecl atan(double) > @ cdecl atan2(double double) > -@ cdecl atexit(ptr) > +@ extern atexit #<-- keep this as an extern, thank you > @ cdecl atof(str) > @ cdecl atoi(str) > @ cdecl atol(str) > > Modified: trunk/reactos/dll/win32/msvcrt20/msvcrt20.spec > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt20/msvcrt2… > ============================================================================== > --- trunk/reactos/dll/win32/msvcrt20/msvcrt20.spec [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/msvcrt20/msvcrt20.spec [iso-8859-1] Sun Jul 24 16:45:41 2011 > @@ -937,7 +937,7 @@ > @ cdecl asin(double) > @ cdecl atan(double) > @ cdecl atan2(double double) > -@ cdecl atexit(ptr) > +@ extern atexit #<-- do not touch this! > @ cdecl atof(str) > @ cdecl atoi(str) > @ cdecl atol(str) > > Modified: trunk/reactos/dll/win32/msvcrt40/msvcrt40.spec > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt40/msvcrt4… > ============================================================================== > --- trunk/reactos/dll/win32/msvcrt40/msvcrt40.spec [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/msvcrt40/msvcrt40.spec [iso-8859-1] Sun Jul 24 16:45:41 2011 > @@ -975,7 +975,7 @@ > @ cdecl asin(double) > @ cdecl atan(double) > @ cdecl atan2(double double) > -@ cdecl atexit(ptr) > +@ extern atexit #<-- changing this will kill your cat, understand? > @ cdecl atof(str) > @ cdecl atoi(str) > @ cdecl atol(str) > > Modified: trunk/reactos/lib/3rdparty/mingw/crtexe.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/mingw/crtexe.… > ============================================================================== > --- trunk/reactos/lib/3rdparty/mingw/crtexe.c [iso-8859-1] (original) > +++ trunk/reactos/lib/3rdparty/mingw/crtexe.c [iso-8859-1] Sun Jul 24 16:45:41 2011 > @@ -71,8 +71,8 @@ > /* TLS initialization hook. */ > extern const PIMAGE_TLS_CALLBACK __dyn_tls_init_callback; > > -//extern _PVFV *__onexitbegin; > -//extern _PVFV *__onexitend; > +extern _PVFV *__onexitbegin; > +extern _PVFV *__onexitend; > > extern int mingw_app_type; > > @@ -119,7 +119,7 @@ > __set_app_type(_GUI_APP); > else > __set_app_type (_CONSOLE_APP); > -// __onexitbegin = __onexitend = (_PVFV *) _encode_pointer ((_PVFV *)(-1)); > + __onexitbegin = __onexitend = (_PVFV *) _encode_pointer ((_PVFV *)(-1)); > > * __MINGW_IMP_SYMBOL(_fmode) = _fmode; > * __MINGW_IMP_SYMBOL(_commode) = _commode; > > Modified: trunk/reactos/lib/3rdparty/mingw/mingw.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/mingw/mingw.r… > ============================================================================== > --- trunk/reactos/lib/3rdparty/mingw/mingw.rbuild [iso-8859-1] (original) > +++ trunk/reactos/lib/3rdparty/mingw/mingw.rbuild [iso-8859-1] Sun Jul 24 16:45:41 2011 > @@ -12,7 +12,7 @@ > <include base="ReactOS">include/reactos/mingw-w64</include> > <library>kernel32</library> > <file>_newmode.c</file> > -  > + <file>atonexit.c</file> > <file>binmode.c</file> > <file>charmax.c</file> > <file>cinitexe.c</file> > > Modified: trunk/reactos/lib/sdk/crt/msvcrtex.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/msvcrtex.cmake… > ============================================================================== > --- trunk/reactos/lib/sdk/crt/msvcrtex.cmake [iso-8859-1] (original) > +++ trunk/reactos/lib/sdk/crt/msvcrtex.cmake [iso-8859-1] Sun Jul 24 16:45:41 2011 > @@ -17,7 +17,7 @@ > startup/natstart.c > startup/charmax.c > startup/merr.c > -# startup/atonexit.c > + startup/atonexit.c > startup/txtmode.c > startup/pesect.c > startup/tlsmcrt.c > > Modified: trunk/reactos/lib/sdk/crt/startup/crtdll.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/startup/crtdll… > ============================================================================== > --- trunk/reactos/lib/sdk/crt/startup/crtdll.c [iso-8859-1] (original) > +++ trunk/reactos/lib/sdk/crt/startup/crtdll.c [iso-8859-1] Sun Jul 24 16:45:41 2011 > @@ -49,8 +49,8 @@ > > static int __proc_attached = 0; > > -//extern _PVFV *__onexitbegin; > -//extern _PVFV *__onexitend; > +extern _PVFV *__onexitbegin; > +extern _PVFV *__onexitend; > > extern int mingw_app_type; > > @@ -65,7 +65,7 @@ > static int > pre_c_init (void) > { > -/* _PVFV *onexitbegin; > + _PVFV *onexitbegin; > > onexitbegin = (_PVFV *) malloc (32 * sizeof (_PVFV)); > __onexitend = __onexitbegin = (_PVFV *) _encode_pointer (onexitbegin); > @@ -73,8 +73,7 @@ > if (onexitbegin == NULL) > return 1; > *onexitbegin = (_PVFV) NULL; > - return 0;*/ > - return 1; > + return 0; > } > > WINBOOL WINAPI _CRT_INIT (HANDLE hDllHandle, DWORD dwReason, LPVOID lpreserved) > @@ -136,7 +135,7 @@ > _amsg_exit (31); > } > else > - {/* > + { > _PVFV * onexitbegin = (_PVFV *) _decode_pointer (__onexitbegin); > if (onexitbegin) > { > @@ -146,7 +145,7 @@ > (**onexitend) (); > free (onexitbegin); > __onexitbegin = __onexitend = (_PVFV *) NULL; > - }*/ > + } > __native_startup_state = __uninitialized; > (void) InterlockedExchangePointer ((volatile PVOID *)&__native_startup_lock, 0); > } > > Modified: trunk/reactos/lib/sdk/crt/startup/crtexe.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/startup/crtexe… > ============================================================================== > --- trunk/reactos/lib/sdk/crt/startup/crtexe.c [iso-8859-1] (original) > +++ trunk/reactos/lib/sdk/crt/startup/crtexe.c [iso-8859-1] Sun Jul 24 16:45:41 2011 > @@ -75,8 +75,8 @@ > /* TLS initialization hook. */ > extern const PIMAGE_TLS_CALLBACK __dyn_tls_init_callback; > > -//extern _PVFV *__onexitbegin; > -//extern _PVFV *__onexitend; > +extern _PVFV *__onexitbegin; > +extern _PVFV *__onexitend; > > extern int mingw_app_type; > > @@ -128,7 +128,7 @@ > __set_app_type(_GUI_APP); > else > __set_app_type (_CONSOLE_APP); > -// __onexitbegin = __onexitend = (_PVFV *) _encode_pointer ((_PVFV *)(-1)); > + __onexitbegin = __onexitend = (_PVFV *) _encode_pointer ((_PVFV *)(-1)); > > * __MINGW_IMP_SYMBOL(_fmode) = _fmode; > * __MINGW_IMP_SYMBOL(_commode) = _commode; > >

14 years, 1 month

Re: [ros-dev] [ros-diffs] [jgardou] 52831: [LIBWINE] - new tentative to fix build : get rid of libwine's stricmp, we have it in our crt

by Gabriel ilardi

Wouldn't it be advisable besides the commit message also to add a comment to the code as why stuff is commented out ? > Date: Sun, 24 Jul 2011 10:29:53 +0000 > To: ros-diffs(a)reactos.org > From: jgardou(a)svn.reactos.org > Subject: [ros-diffs] [jgardou] 52831: [LIBWINE] - new tentative to fix build : get rid of libwine's stricmp, we have it in our crt > > Author: jgardou > Date: Sun Jul 24 10:29:52 2011 > New Revision: 52831 > > URL: http://svn.reactos.org/svn/reactos?rev=52831&view=rev > Log: > [LIBWINE] > - new tentative to fix build : get rid of libwine's stricmp, we have it in our crt > > Modified: > trunk/reactos/lib/3rdparty/libwine/CMakeLists.txt > trunk/reactos/lib/3rdparty/libwine/libwine.rbuild > > Modified: trunk/reactos/lib/3rdparty/libwine/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/libwine/CMake… > ============================================================================== > --- trunk/reactos/lib/3rdparty/libwine/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/lib/3rdparty/libwine/CMakeLists.txt [iso-8859-1] Sun Jul 24 10:29:52 2011 > @@ -6,7 +6,7 @@ > config.c > debug_ros.c > loader.c > - string.c) > +# string.c) > > add_library(wine ${SOURCE}) > > > Modified: trunk/reactos/lib/3rdparty/libwine/libwine.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/libwine/libwi… > ============================================================================== > --- trunk/reactos/lib/3rdparty/libwine/libwine.rbuild [iso-8859-1] (original) > +++ trunk/reactos/lib/3rdparty/libwine/libwine.rbuild [iso-8859-1] Sun Jul 24 10:29:52 2011 > @@ -7,7 +7,7 @@ > <file>config.c</file> > <file>debug_ros.c</file> > <file>loader.c</file> > - <file>string.c</file> > +  > </module> > <module name="wineldr" type="staticlibrary"> > <include base="ReactOS">include/reactos/wine</include> > >

14 years, 1 month

Re: [ros-dev] [ros-diffs] [ion] 52807: [KERNEL32]: Optimize SwitchToFiber to simply use "ret" to jump between fibers, instead of saving EIP and doing a JMP. Bug #50: SwitchToFiber needs to check if FXSR is *NOT* present in ...

by Timo Kreuzer

This won't work, since new Fibers, created with CreateFiber(Ex) don't push a "return address" on the stack, but set the Eip member to BaseFiberStartup. Am 23.07.2011 14:08, schrieb ion(a)svn.reactos.org: > Author: ion > Date: Sat Jul 23 12:08:36 2011 > New Revision: 52807 > > URL: http://svn.reactos.org/svn/reactos?rev=52807&view=rev > Log: > [KERNEL32]: Optimize SwitchToFiber to simply use "ret" to jump between fibers, instead of saving EIP and doing a JMP. > Bug #50: SwitchToFiber needs to check if FXSR is *NOT* present in order to skip using ldmxcsr/stmxcsr. Previously, it would check if it's unsupported, and jump past the instruction if it was (resulting in invalid opcode instructions on older systems) > 50 bugs. Penance has been paid. > > Modified: > trunk/reactos/dll/win32/kernel32/client/i386/fiber.S > > Modified: trunk/reactos/dll/win32/kernel32/client/i386/fiber.S > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… > ============================================================================== > --- trunk/reactos/dll/win32/kernel32/client/i386/fiber.S [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/kernel32/client/i386/fiber.S [iso-8859-1] Sat Jul 23 12:08:36 2011 > @@ -26,20 +26,16 @@ > mov [eax+FIBER_CONTEXT_EDI], edi > mov [eax+FIBER_CONTEXT_EBP], ebp > > - /* Save the return address */ > - mov ebx, [esp] > - mov [eax+FIBER_CONTEXT_EIP], ebx > - > /* Check if we're to save FPU State */ > cmp dword ptr [eax+FIBER_CONTEXT_FLAGS], CONTEXT_FULL OR CONTEXT_FLOATING_POINT > jnz NoFpuStateSave > > /* Save the FPU State (Status and Control)*/ > fstsw [eax+FIBER_CONTEXT_FLOAT_SAVE_STATUS_WORD] > - fstcw [eax+FIBER_CONTEXT_FLOAT_SAVE_CONTROL_WORD] > + fnstcw [eax+FIBER_CONTEXT_FLOAT_SAVE_CONTROL_WORD] > > /* Check if the CPU supports SIMD MXCSR State Save */ > - cmp byte ptr ds:[PROCESSOR_FEATURE_FXSR], 0 > + cmp byte ptr ds:[PROCESSOR_FEATURE_FXSR], 1 > jnz NoFpuStateSave > stmxcsr [eax+FIBER_CONTEXT_DR6] > > @@ -103,7 +99,7 @@ > ControlWordEqual: > > /* Load the new one */ > - cmp byte ptr ds:[PROCESSOR_FEATURE_FXSR], 0 > + cmp byte ptr ds:[PROCESSOR_FEATURE_FXSR], 1 > jnz NoFpuStateRestore > ldmxcsr [ecx+FIBER_CONTEXT_DR6] > > @@ -121,7 +117,8 @@ > mov [edx+TEB_FLS_DATA], eax > > /* Jump to new fiber */ > - jmp dword ptr [ecx+FIBER_CONTEXT_EIP] > + mov esp, [ecx+FIBER_CONTEXT_ESP] > + ret 4 > +END > > -END > /* EOF */ > > >

14 years, 1 month

Re: [ros-dev] [ros-diffs] [ion] 52806: [KERNEL32]: Implement BaseFiberStartup in ASM, just like the thread/process thunks, so we get a "naked" thunk without any compiler-generated crap.

by Timo Kreuzer

Am 23.07.2011 14:05, schrieb ion(a)svn.reactos.org: > Author: ion > Date: Sat Jul 23 12:05:38 2011 > New Revision: 52806 > > URL: http://svn.reactos.org/svn/reactos?rev=52806&view=rev > Log: > [KERNEL32]: Implement BaseFiberStartup in ASM, just like the thread/process thunks, so we get a "naked" thunk without any compiler-generated crap. I don't see the point in this change. That "crap" is setting up a stack frame, which is pretty useful for debugging. It consists of 3 instructions: push ebp mov ebp, esp sub esp, 8 Your change also broke compilation with MSVC (the END directive is only at the end of the file!) and deleted the function for amd64. The function is not performance critical and the asm code doesn't really add any performace gain anyway. So why are we going back? I'm asking, because I've been working on converting more asm code to C code and IMO thats the way to go. Regards, Timo

14 years, 1 month

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev July 2011