Ros-dev August 2011

ros-dev@reactos.org

29 participants
39 discussions

[ros-diffs] [gadamopoulos] 52716: [win32k] - Fix TrackMouseEvent. Now hot tracking really works
by James Tabor 20 Sep '11

20 Sep '11

If it passes all the wine tests w/o the intermittent hits and misses! SYNC it to HEAD!

1 1

Re: [ros-dev] [ros-diffs] [jgardou] 53503: [WINETESTS/RPCRT4] Until now, rpcrt4 winetests where badly broken : client calls remotely forwarded to serverside functions which called... client side functions. One has to wonder...
by Aleksey Bragin 31 Aug '11

31 Aug '11

This breaks RBUILD-based build. More precisely these lines: +  + <define name="s_IServer_v0_0_s_ifspec">IServer_v0_0_s_ifspec</redefine> it seems to be already defined by something. WBR, Aleksey Bragin. -----Original Message----- From: jgardou(a)svn.reactos.org Sent: Wednesday, August 31, 2011 12:49 AM To: ros-diffs(a)reactos.org Subject: [ros-diffs] [jgardou] 53503: [WINETESTS/RPCRT4] Until now, rpcrt4 winetests where badly broken : client calls remotely forwarded to serverside functions which called... client side functions. One has to wonder... Author: jgardou Date: Tue Aug 30 20:49:31 2011 New Revision: 53503 URL: http://svn.reactos.org/svn/reactos?rev=53503&view=rev Log: [WINETESTS/RPCRT4] Until now, rpcrt4 winetests where badly broken : client calls remotely forwarded to serverside functions which called... client side functions. One has to wonder how testbot survived the operation - Cmake : fix that - rbuild : add a hack keeping the old behaviour, because I don't know how to make this right Modified: trunk/rostests/winetests/rpcrt4/CMakeLists.txt trunk/rostests/winetests/rpcrt4/rpcrt4.rbuild trunk/rostests/winetests/rpcrt4/server.c Modified: trunk/rostests/winetests/rpcrt4/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/rpcrt4/CMakeLis… ============================================================================== --- trunk/rostests/winetests/rpcrt4/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/winetests/rpcrt4/CMakeLists.txt [iso-8859-1] Tue Aug 30 20:49:31 2011 @@ -5,9 +5,16 @@ add_definitions( -D__ROS_LONG64__ -D_DLL -D__USE_CRTIMP) + +if(MSVC) + set(IDL_FLAGS ${IDL_FLAGS} /prefix server s_) +else() + set(IDL_FLAGS ${IDL_FLAGS} --prefix-server=s_) +endif() add_rpc_files(client server.idl) add_rpc_files(server server.idl) +unset(IDL_FLAGS) list(APPEND SOURCE cstub.c Modified: trunk/rostests/winetests/rpcrt4/rpcrt4.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/rpcrt4/rpcrt4.r… ============================================================================== --- trunk/rostests/winetests/rpcrt4/rpcrt4.rbuild [iso-8859-1] (original) +++ trunk/rostests/winetests/rpcrt4/rpcrt4.rbuild [iso-8859-1] Tue Aug 30 20:49:31 2011 @@ -12,6 +12,8 @@ <include root="intermediate" base="rpcrt4_winetest">.</include> <define name="__ROS_LONG64__" /> <redefine name="_WIN32_WINNT">0x0500</redefine> +  + <define name="s_IServer_v0_0_s_ifspec">IServer_v0_0_s_ifspec</redefine> <library>wine</library> <library>pseh</library> <library>ole32</library> Modified: trunk/rostests/winetests/rpcrt4/server.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/rpcrt4/server.c… ============================================================================== --- trunk/rostests/winetests/rpcrt4/server.c [iso-8859-1] (original) +++ trunk/rostests/winetests/rpcrt4/server.c [iso-8859-1] Tue Aug 30 20:49:31 2011 @@ -1542,12 +1542,12 @@ if (pRpcServerRegisterIfEx) { trace("Using RpcServerRegisterIfEx\n"); - status = pRpcServerRegisterIfEx(IServer_v0_0_s_ifspec, NULL, NULL, + status = pRpcServerRegisterIfEx(s_IServer_v0_0_s_ifspec, NULL, NULL, RPC_IF_ALLOW_CALLBACKS_WITH_NO_AUTH, RPC_C_LISTEN_MAX_CALLS_DEFAULT, NULL); } else - status = RpcServerRegisterIf(IServer_v0_0_s_ifspec, NULL, NULL); + status = RpcServerRegisterIf(s_IServer_v0_0_s_ifspec, NULL, NULL); ok(status == RPC_S_OK, "RpcServerRegisterIf failed with status %d\n", status); status = RpcServerListen(1, 20, TRUE); ok(status == RPC_S_OK, "RpcServerListen failed with status %d\n", status);

1 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 53496: [HAL] We cannot make any assumptions about the latency whith which the timer interrupt fires after a rollover, since VBox (other VMs probably as well) doesn't always meet this. Ad...
by Alex Ionescu 31 Aug '11

31 Aug '11

Funny how Windows works without these hacks. Let's hide more bugs :D Best regards, Alex Ionescu On Tue, Aug 30, 2011 at 12:01 PM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Tue Aug 30 12:01:01 2011 > New Revision: 53496 > > URL: http://svn.reactos.org/svn/reactos?rev=53496&view=rev > Log: > [HAL] > We cannot make any assumptions about the latency whith which the timer > interrupt fires after a rollover, since VBox (other VMs probably as well) > doesn't always meet this. Add another check to KeQueryPerformanceCounter > that gracefully handles missing interrupts. Also raise to DISPATCH_LEVEL, > since the function is not reentrant. > > Modified: > trunk/reactos/hal/halx86/generic/timer.c > > Modified: trunk/reactos/hal/halx86/generic/timer.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/timer.c… > > ============================================================================== > --- trunk/reactos/hal/halx86/generic/timer.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/generic/timer.c [iso-8859-1] Tue Aug 30 > 12:01:01 2011 > @@ -253,6 +253,7 @@ > { > LARGE_INTEGER CurrentPerfCounter; > ULONG CounterValue, ClockDelta; > + KIRQL OldIrql; > > /* If caller wants performance frequency, return hardcoded value */ > if (PerformanceFrequency) PerformanceFrequency->QuadPart = > PIT_FREQUENCY; > @@ -262,6 +263,10 @@ > > /* Check if interrupts are disabled */ > if(!(__readeflags() & EFLAGS_INTERRUPT_MASK)) return HalpPerfCounter; > + > + /* Raise irql to DISPATCH_LEVEL */ > + OldIrql = KeGetCurrentIrql(); > + if (OldIrql < DISPATCH_LEVEL) KfRaiseIrql(DISPATCH_LEVEL); > > do > { > @@ -287,13 +292,21 @@ > /* Add the clock delta */ > CurrentPerfCounter.QuadPart += ClockDelta; > > - /* This must be true unless HalpPerfCounter has changed sign, > - which takes approximately 245,118 years */ > - ASSERT(CurrentPerfCounter.QuadPart >= HalpLastPerfCounter.QuadPart); > + /* Check if the value is smaller then before, this means, we somehow > + missed an interrupt. This is a sign that the timer interrupt > + is very inaccurate. Probably a virtual machine. */ > + if (CurrentPerfCounter.QuadPart < HalpLastPerfCounter.QuadPart) > + { > + /* We missed an interrupt. Assume we will receive it later */ > + CurrentPerfCounter.QuadPart += HalpCurrentRollOver; > + } > > /* Update the last counter value */ > HalpLastPerfCounter = CurrentPerfCounter; > > + /* Restore previous irql */ > + if (OldIrql < DISPATCH_LEVEL) KfLowerIrql(OldIrql); > + > /* Return the result */ > return CurrentPerfCounter; > } > > >

2 1

ReactOS unattended.inf
by Mario Gzuk 30 Aug '11

30 Aug '11

Hi, I am the maintainer of uranos (http://uranos.sf.net) and want to implement the unattended setup of ReactOS into uranos. I read that you have implemented a answer file into ReactOS. Because of uranos does all the parts which is done by the txtinstaller from ReactOS (partition disk, write mbr, copy files and so on) from a linux boot environment - I want to know if it is possible to place the unattended.inf into the filesystem so the ReactOS is read the file in the first GUI boot. Thank you! Cheers mario

3 5

Re: [ros-dev] [ros-diffs] [tkreuzer] 53494: [INTRIN] - add __nop()
by Alex Ionescu 30 Aug '11

30 Aug '11

Can you also add __noop please? Best regards, Alex Ionescu On Mon, Aug 29, 2011 at 11:10 PM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Mon Aug 29 23:10:04 2011 > New Revision: 53494 > > URL: http://svn.reactos.org/svn/reactos?rev=53494&view=rev > Log: > [INTRIN] > - add __nop() > > Modified: > trunk/reactos/include/crt/mingw32/intrin_x86.h > > Modified: trunk/reactos/include/crt/mingw32/intrin_x86.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/mingw32/intrin… > > ============================================================================== > --- trunk/reactos/include/crt/mingw32/intrin_x86.h [iso-8859-1] (original) > +++ trunk/reactos/include/crt/mingw32/intrin_x86.h [iso-8859-1] Mon Aug 29 > 23:10:04 2011 > @@ -1505,11 +1505,18 @@ > __asm__ __volatile__("sidt %0" : : "m"(*(short*)Destination) : > "memory"); > } > > +/*** Misc operations ***/ > + > __INTRIN_INLINE void _mm_pause(void) > { > __asm__ __volatile__("pause" : : : "memory"); > } > > +__INTRIN_INLINE void __nop(void) > +{ > + __asm__ __volatile__("nop"); > +} > + > #ifdef __cplusplus > } > #endif > > >

2 1

Re: [ros-dev] [ros-diffs] [jgardou] 53481: [WIDL] - reenable -Oif flag, it's too good to be disabled With this commit, advapi32:service winetest suffers only 2 failures.
by Jérôme Gardou 28 Aug '11

28 Aug '11

Feel free to disable it again if probems occur. "Probable bugs" are hard to test alone, so I'm waiting for test bot to confirm this fixes things without breaking others. Regards. Jérôme. Le 28/08/2011 17:37, jgardou(a)svn.reactos.org a écrit : > Author: jgardou > Date: Sun Aug 28 15:37:01 2011 > New Revision: 53481 > > URL: http://svn.reactos.org/svn/reactos?rev=53481&view=rev > Log: > [WIDL] > - reenable -Oif flag, it's too good to be disabled > With this commit, advapi32:service winetest suffers only 2 failures. > > Modified: > trunk/reactos/cmake/idl-support.cmake > trunk/reactos/tools/rbuild/backend/mingw/rules.mak > > Modified: trunk/reactos/cmake/idl-support.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/idl-support.cmake?re… > ============================================================================== > --- trunk/reactos/cmake/idl-support.cmake [iso-8859-1] (original) > +++ trunk/reactos/cmake/idl-support.cmake [iso-8859-1] Sun Aug 28 15:37:01 2011 > @@ -22,8 +22,8 @@ > set(IDL_HEADER_ARG -h -o) #.h > set(IDL_HEADER_ARG2 -h -H) #.h > set(IDL_TYPELIB_ARG -t -o) #.tlb > - set(IDL_SERVER_ARG -s -o) #.c for server library > - set(IDL_CLIENT_ARG -c -o) #.c for stub client library > + set(IDL_SERVER_ARG -Oif -s -o) #.c for server library > + set(IDL_CLIENT_ARG -Oif -c -o) #.c for stub client library > set(IDL_PROXY_ARG -p -o) > set(IDL_INTERFACE_ARG -u -o) > if(ARCH MATCHES i386) > @@ -169,6 +169,6 @@ > list(APPEND IID_SOURCES ${NAME}_i.c) > endforeach() > add_library(${TARGET} ${IID_SOURCES}) > - add_dependencies(${TARGET} psdk) > + add_dependencies(${TARGET} psdk) > set_target_properties(${TARGET} PROPERTIES EXCLUDE_FROM_ALL TRUE) > endfunction() > > Modified: trunk/reactos/tools/rbuild/backend/mingw/rules.mak > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/backend/mingw… > ============================================================================== > --- trunk/reactos/tools/rbuild/backend/mingw/rules.mak [iso-8859-1] (original) > +++ trunk/reactos/tools/rbuild/backend/mingw/rules.mak [iso-8859-1] Sun Aug 28 15:37:01 2011 > @@ -264,7 +264,7 @@ > > ${call RBUILD_intermediate_path_noext,$(2)}_c: $(2) $(3) $$(widl_TARGET) | ${call RBUILD_intermediate_dir,$(2)} > $$(ECHO_WIDL) > - $$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call RBUILD_dir,$(2)}} -h -H ${call RBUILD_intermediate_path_noext,$(2)}_c.h -c -C ${call RBUILD_intermediate_path_noext,$(2)}_c.c $(2) > + $$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call RBUILD_dir,$(2)}} -Oif -h -H ${call RBUILD_intermediate_path_noext,$(2)}_c.h -c -C ${call RBUILD_intermediate_path_noext,$(2)}_c.c $(2) > $${checkpoint} $$@>$(NUL) > > ${call RBUILD_CC,$(1),${call RBUILD_intermediate_path_noext,$(2)}_c.c,,,${call RBUILD_intermediate_path_noext,$(2)}_c.o} > @@ -280,7 +280,7 @@ > > ${call RBUILD_intermediate_path_noext,$(2)}_s: $(2) $(3) $$(widl_TARGET) | ${call RBUILD_intermediate_dir,$(2)} > $$(ECHO_WIDL) > - $$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call RBUILD_dir,$(2)}} -h -H ${call RBUILD_intermediate_path_noext,$(2)}_s.h -s -S ${call RBUILD_intermediate_path_noext,$(2)}_s.c $(2) > + $$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call RBUILD_dir,$(2)}} -Oif -h -H ${call RBUILD_intermediate_path_noext,$(2)}_s.h -s -S ${call RBUILD_intermediate_path_noext,$(2)}_s.c $(2) > $${checkpoint} $$@>$(NUL) > > ${call RBUILD_CC,$(1),${call RBUILD_intermediate_path_noext,$(2)}_s.c,,,${call RBUILD_intermediate_path_noext,$(2)}_s.o} > >

3 2

(no subject)
by Dimas FranK 28 Aug '11

28 Aug '11

I want to do some testing on physical machines until now was doing the vbox will charge the machine a good desepenho memory and I'll need to spend sitema ospedeiro vbox and the problem and that the machines do not have a serial port was taking a look at these wiki but did not see exact references on how to get the debug log on the cable network vbox but works well for the network that will be with you http://www.reactos.org/wiki/Debugging http://www.reactos.org/wiki/ReactOS_Remote_Debugger#TCP.2FIP_.28QEMU_only.29

3 2

Re: [ros-dev] [ros-diffs] [ekohl] 53469: [WIDL] Revert parts of r53171: Remove the -Oif flag for WIDL because the NT4 stub code generated by the current WIDL is heavily broken with respect to the range attribute and others....
by Jérôme Gardou 28 Aug '11

28 Aug '11

HI Eric! I'm not sure about what you mean for range attribute, but I notice that typedef [context_handle] PVOID my_handle; makes widl thinks that any value of the my_handle type is passed by pointer, whereas midl considers it is passed by value. Could you be more precise about "range attributes and others?" please. Regards. Jérôme. Le 27/08/2011 18:24, ekohl(a)svn.reactos.org a écrit : > Author: ekohl > Date: Sat Aug 27 16:24:40 2011 > New Revision: 53469 > > URL: http://svn.reactos.org/svn/reactos?rev=53469&view=rev > Log: > [WIDL] > Revert parts of r53171: > Remove the -Oif flag for WIDL because the NT4 stub code generated by the current WIDL is heavily broken with respect to the range attribute and others. Please enable the -Oif feature only after these bugs are fixed in WIDL! > > Modified: > trunk/reactos/cmake/idl-support.cmake > trunk/reactos/tools/rbuild/backend/mingw/rules.mak > > Modified: trunk/reactos/cmake/idl-support.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/idl-support.cmake?re… > ============================================================================== > --- trunk/reactos/cmake/idl-support.cmake [iso-8859-1] (original) > +++ trunk/reactos/cmake/idl-support.cmake [iso-8859-1] Sat Aug 27 16:24:40 2011 > @@ -22,8 +22,8 @@ > set(IDL_HEADER_ARG -h -o) #.h > set(IDL_HEADER_ARG2 -h -H) #.h > set(IDL_TYPELIB_ARG -t -o) #.tlb > - set(IDL_SERVER_ARG -Oif -s -o) #.c for server library > - set(IDL_CLIENT_ARG -Oif -c -o) #.c for stub client library > + set(IDL_SERVER_ARG -s -o) #.c for server library > + set(IDL_CLIENT_ARG -c -o) #.c for stub client library > set(IDL_PROXY_ARG -p -o) > set(IDL_INTERFACE_ARG -u -o) > if(ARCH MATCHES i386) > @@ -169,6 +169,6 @@ > list(APPEND IID_SOURCES ${NAME}_i.c) > endforeach() > add_library(${TARGET} ${IID_SOURCES}) > - add_dependencies(${TARGET} psdk) > + add_dependencies(${TARGET} psdk) > set_target_properties(${TARGET} PROPERTIES EXCLUDE_FROM_ALL TRUE) > endfunction() > > Modified: trunk/reactos/tools/rbuild/backend/mingw/rules.mak > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/backend/mingw… > ============================================================================== > --- trunk/reactos/tools/rbuild/backend/mingw/rules.mak [iso-8859-1] (original) > +++ trunk/reactos/tools/rbuild/backend/mingw/rules.mak [iso-8859-1] Sat Aug 27 16:24:40 2011 > @@ -264,7 +264,7 @@ > > ${call RBUILD_intermediate_path_noext,$(2)}_c: $(2) $(3) $$(widl_TARGET) | ${call RBUILD_intermediate_dir,$(2)} > $$(ECHO_WIDL) > - $$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call RBUILD_dir,$(2)}} -Oif -h -H ${call RBUILD_intermediate_path_noext,$(2)}_c.h -c -C ${call RBUILD_intermediate_path_noext,$(2)}_c.c $(2) > + $$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call RBUILD_dir,$(2)}} -h -H ${call RBUILD_intermediate_path_noext,$(2)}_c.h -c -C ${call RBUILD_intermediate_path_noext,$(2)}_c.c $(2) > $${checkpoint} $$@>$(NUL) > > ${call RBUILD_CC,$(1),${call RBUILD_intermediate_path_noext,$(2)}_c.c,,,${call RBUILD_intermediate_path_noext,$(2)}_c.o} > @@ -280,7 +280,7 @@ > > ${call RBUILD_intermediate_path_noext,$(2)}_s: $(2) $(3) $$(widl_TARGET) | ${call RBUILD_intermediate_dir,$(2)} > $$(ECHO_WIDL) > - $$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call RBUILD_dir,$(2)}} -Oif -h -H ${call RBUILD_intermediate_path_noext,$(2)}_s.h -s -S ${call RBUILD_intermediate_path_noext,$(2)}_s.c $(2) > + $$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call RBUILD_dir,$(2)}} -h -H ${call RBUILD_intermediate_path_noext,$(2)}_s.h -s -S ${call RBUILD_intermediate_path_noext,$(2)}_s.c $(2) > $${checkpoint} $$@>$(NUL) > > ${call RBUILD_CC,$(1),${call RBUILD_intermediate_path_noext,$(2)}_s.c,,,${call RBUILD_intermediate_path_noext,$(2)}_s.o} > >

3 5

Sugetao
by Dimas FranK 27 Aug '11

27 Aug '11

I obeservado that companies have made the opening of perfius on social sites like orkte, face buk to have a closer contacts with its customers Suggestions Taves Foce the time to develop a page-pink similar to orkut only for pelomenos emvolvidos list of ros-dev communicate mellhor we take for example the option orkut This allows you to replaying a message to the entire group or just for some or open a profile but it would be the maintainer of the profile to select some options has some social networks that desacoselho to be very open but partially open orkut and where he has partial control of where and where does the information would be very nice to have something in ros.org or maybe opening a profile on some these social networks a method would be to discuss and APREDE programs in a more dynamic

2 1

Uma Questao
by Dimas FranK 27 Aug '11

27 Aug '11

A Matter discursoes saw some about the future of Roses A sugentao as a powerful gaming machine MaxiVista server and at the same time continue the development of financial markets and earn some cash to the developers and everyone involved in the project we will take as examples the maximum this game is notable that the projects do not get for the day for the night

2 1

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev August 2011