Ros-dev August 2011

ros-dev@reactos.org

29 participants
39 discussions

Re: [ros-dev] Ros-dev Digest, Vol 84, Issue 22
by Dimas FranK 27 Aug '11

27 Aug '11

When complete the installation of the driver placa GF8200A shipeset 8200 Through the message that the dll not found Wow32.dll MainFrameBase::OpenShellFolders():parent_pidl=C:\Documents and Settgs\Administrator\Desktop MainFrameBase::OpenShellFolders(): pidl_abs=(null) (drivers\filesystems\cdfs\create.c:148) Status c0000013 (drivers\filesystems\cdfs\create.c:148) Status c0000013 (drivers\flesystems\cdfs\common.c:196) STATUS_VERIFY_REQUIRED (drivers\filesystems\cdfs\fsctl.c:590) CDFS: IRP_MN_VERIFY_VOLUME (drivers\filesystems\cdfs\fsctl.c:467) CdfsVerifyVolume() called (drivers\filesystems\cdfs\fsctl.c:494) Deviceobject B1285A48 Device to verify B1285A48 (drivers\filesystems\cdfs\devctrl.c:34) FIXME: CdfsDevieControl called without FileObjec! (drivers\filesystems\cdfs\fsct.c:511) Different volume! (drives\filesystems\cdfs\fsctl.c:518) OenFile \ RefCount 1 (drivers\fiesystems\cdfs\fsctl.c:518) OpenFie \loader RefCount 0 (drivers\flesystems\cdfs\fsctl.c:518) OpenFile \reactos RefCount 0 (drivers\filesystems\cdfs\fsctl.c:518) OenFile \reactos\system32 RefCoun 0 (drivers\filesystems\cdfs\common.c203) IoVerifyVolume() returned (Status c0000012) (drivers\filesysems\cdfs\create.c:148) Status 8000016 MainFrameBase::OpenShellFolders():parent_pidl=(null) MainFrameBase:OpenShellFolders(): pidl_abs=D:\ MDIMainFrame PM_OPEN_WINDOW: pat=D:\ MainFrameBase::OpenShellFolders():rent_pidl=D:\ (lib\rtl\path.c:256) don't keep the directory handl open on removable media (dll\ntdll\ldr\utils.c:2301) Faile to create or open dll section of'WOW32.DLL' (Status c0000135) (d\ntdll\ldr\utils.c:1512) failed tload WOW32.DLL (subsystems\win32csrss\csrsrv\api\wapi.c:115) CSR:received hard error c0000135 WARNING: MmLockPageableDataSectio at ntoskrnl\mm\ARM3\drvmgmt.c:62s UNIMPLEMENTED! WARNING: MmUnlockPageableImageSecon at ntoskrnl\mm\ARM3\drvmgmt.c: is UNIMPLEMENTED! (ntoskrnl\se\semgr.c:299) SidInTok Calls: 30000 2011/8/26, ros-dev-request(a)reactos.org <ros-dev-request(a)reactos.org>: > Send Ros-dev mailing list submissions to > ros-dev(a)reactos.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://www.reactos.org/mailman/listinfo/ros-dev > or, via email, send a message with subject or body 'help' to > ros-dev-request(a)reactos.org > > You can reach the person managing the list at > ros-dev-owner(a)reactos.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Ros-dev digest..." > > > Today's Topics: > > 1. Re: Debug Buildslave Maintenance (caemyr(a)myopera.com) > 2. Re: Debug Buildslave Maintenance (Eric Kohl) > 3. Re: [ros-diffs] [fireball] 53446: [NTDLL/LDR] - Fix wrong > loop condition which would often lead to heap underread. - Fix > wrong subkey string length calculation, which would result in an > incorrect string being used... (Ged Murphy) > 4. Re: [ros-diffs] [fireball] 53446: [NTDLL/LDR] - Fix wrong > loop condition which would often lead to heap underread. - Fix > wrong subkey string length calculation, which would result in an > incorrect string being used... (Aleksey Bragin) > 5. Re: Debug Buildslave Maintenance (Aleksey Bragin) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Thu, 25 Aug 2011 23:29:55 +0200 > From: caemyr(a)myopera.com > Subject: Re: [ros-dev] Debug Buildslave Maintenance > To: "ReactOS Development List" <ros-dev(a)reactos.org> > Message-ID: > <1314307795.18690.140258133790149(a)webmail.messagingengine.com> > Content-Type: text/plain; charset="us-ascii" > > @Eric > > http://reactos.org/testman/compare.php?ids=7429,7579 > http://reactos.org/testman/detail.php?id=2639952 > > Please find that the crash is not CMake related, and CMake build is not > inherently broken. > > On Thu, 25 Aug 2011 23:03 +0200, "Pierre Schweitzer" > <pierre.schweitzer(a)reactos.org> wrote: >> Hi, >> >> finally. >> Colin and I are pleased to announce you that ReactOS Linux KVM tests are >> back online and working. You can find the first tests results (on r53383) >> sent tonight by the testbot on testman: http://www.reactos.org/testman/. >> >> Regards, >> Pierre. >> >> ReactOS Development List <ros-dev(a)reactos.org> wrote on Sat, August 20th, >> 2011, 4:24 PM: >> > Timo Kreuzer <timo.kreuzer(a)web.de> wrote: >> > > What about fixing release buildbot first? >> > >> > It's still a private machine owned and administered solely by Christoph. >> > >> > As long as I can't even reach him by phone, we can only wait. >> > >> > >> > > And is there a chance, maybe in the future, to switch buildbots more >> > > easily, to have a backup solution running? >> > >> > First of all, we hope that we can get the same reliability as our other >> > servers after reinstalling the server OS, giving more ReactOS admins >> > access to the machine and adding monitoring. >> > The current OS was meant to be reinstalled for quite a long time, but up >> > >> > to now, nobody with physical access to the machine had any time to do >> > it. >> > >> > If such problems continue to exist afterwards, we can try to set up a >> > fallback system, but this would require an equally configured and >> > powerful Linux machine first. >> > >> > >> > > One week without debug builds is a serious thing. >> > >> > I hope you're aware that builds are still properly uploaded, it's only >> > the testing step which fails. >> > >> > >> > - Colin >> > >> > _______________________________________________ >> > Ros-dev mailing list >> > Ros-dev(a)reactos.org >> > http://www.reactos.org/mailman/listinfo/ros-dev >> >> _______________________________________________ >> Ros-dev mailing list >> Ros-dev(a)reactos.org >> http://www.reactos.org/mailman/listinfo/ros-dev >> > With best regards > Caemyr > > > > ------------------------------ > > Message: 2 > Date: Fri, 26 Aug 2011 01:01:40 +0200 > From: Eric Kohl <eric.kohl(a)t-online.de> > Subject: Re: [ros-dev] Debug Buildslave Maintenance > To: ReactOS Development List <ros-dev(a)reactos.org> > Message-ID: <4E56D454.6060606(a)t-online.de> > Content-Type: text/plain; charset=ISO-8859-1; format=flowed > > Hi Olaf, > > I am already investigating the services test issues. One of my first > findings is that the current widl seems to mess up value ranges in some > cases. This is the cause of the following errors: > err:(dll/win32/rpcrt4/ndr_marshall.c:6496) value exceeded bounds: 918, > low: 0, high: 514 > > <rant> > It is pretty annoying that jgardou updated rpcrt4, widl and other > components without proper testing. At least he should have posted a bug > list BEFORE he comitted the new stuff. > </rant> > > Regards > Eric > >> @Eric >> >> http://reactos.org/testman/compare.php?ids=7429,7579 >> http://reactos.org/testman/detail.php?id=2639952 >> >> Please find that the crash is not CMake related, and CMake build is not >> inherently broken. >> > > > > ------------------------------ > > Message: 3 > Date: Fri, 26 Aug 2011 09:05:21 +0100 > From: "Ged Murphy" <gedmurphy.maillists(a)gmail.com> > Subject: Re: [ros-dev] [ros-diffs] [fireball] 53446: [NTDLL/LDR] - Fix > wrong loop condition which would often lead to heap underread. - Fix > wrong subkey string length calculation, which would result in an > incorrect string being used... > To: <ros-dev(a)reactos.org> > Message-ID: <004201cc63c6$e7a44a40$b6ecdec0$(a)gmail.com> > Content-Type: text/plain; charset="utf-8" > > fireball(a)svn.reactos.org wrote: > >> - Use Zw* functions instead of Nt* where necessary in >> LdrQueryImageFileKeyOption(). > > 'where necessary'm I don't understand this change. > People prefer (and Microsoft recommend) that Nt* is used in usermode. > Nt and Zw APIs point to the same address in usermode, so why is it > necessary? > > Ged. > > > > > > ------------------------------ > > Message: 4 > Date: Fri, 26 Aug 2011 12:13:26 +0400 > From: Aleksey Bragin <aleksey(a)reactos.org> > Subject: Re: [ros-dev] [ros-diffs] [fireball] 53446: [NTDLL/LDR] - Fix > wrong loop condition which would often lead to heap underread. - Fix > wrong subkey string length calculation, which would result in an > incorrect string being used... > To: ReactOS Development List <ros-dev(a)reactos.org> > Message-ID: <7766A32C-3CB0-446A-96F4-4EDC73BC3A29(a)reactos.org> > Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed > > > On Aug 26, 2011, at 12:05 PM, Ged Murphy wrote: > >> fireball(a)svn.reactos.org wrote: >> >>> - Use Zw* functions instead of Nt* where necessary in >>> LdrQueryImageFileKeyOption(). >> >> 'where necessary'm I don't understand this change. >> People prefer (and Microsoft recommend) that Nt* is used in usermode. >> Nt and Zw APIs point to the same address in usermode, so why is it >> necessary? > > This was a test for attention, and so far I got a few notices in IRC > and one in ros-dev. Good! > > Seriously, the change slipped through because I was editing source > code of both RTL (which works both at umode and kmode) and NTDLL/LDR > (which is only umode) a while ago. Of course, Nt is "preferable" in > usermode because there is just no reason to use Zw there. > > > WBR, > Aleksey Bragin. > > > > > ------------------------------ > > Message: 5 > Date: Fri, 26 Aug 2011 12:15:24 +0400 > From: Aleksey Bragin <aleksey(a)reactos.org> > Subject: Re: [ros-dev] Debug Buildslave Maintenance > To: ReactOS Development List <ros-dev(a)reactos.org> > Message-ID: <1F3FEE77-59BC-4D24-83A9-5D280FB45966(a)reactos.org> > Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed > > > On Aug 26, 2011, at 3:01 AM, Eric Kohl wrote: > >> <rant> >> It is pretty annoying that jgardou updated rpcrt4, widl and other >> components without proper testing. At least he should have posted a >> bug list BEFORE he comitted the new stuff. >> </rant> > I also ranted about that. In fact that's why I stopped syncing rpcrt4 > some time ago - because new version always gave problems. So I wanted > to solve problems first and only then commit. > > But, OK, as Olaf said - if something needs to be done, let's simply > do that and fix everything which broke ;). > > WBR, > Aleksey. > > > > > ------------------------------ > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > End of Ros-dev Digest, Vol 84, Issue 22 > *************************************** >

1 1

Re: [ros-dev] Ros-dev Digest, Vol 84, Issue 22
by Dimas FranK 26 Aug '11

26 Aug '11

When complete the installation of the driver placa GF8200A shipeset 8200 Through the message that the dll not found Wow32.dll 2011/8/26, ros-dev-request(a)reactos.org <ros-dev-request(a)reactos.org>: > Send Ros-dev mailing list submissions to > ros-dev(a)reactos.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://www.reactos.org/mailman/listinfo/ros-dev > or, via email, send a message with subject or body 'help' to > ros-dev-request(a)reactos.org > > You can reach the person managing the list at > ros-dev-owner(a)reactos.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Ros-dev digest..." > > > Today's Topics: > > 1. Re: Debug Buildslave Maintenance (caemyr(a)myopera.com) > 2. Re: Debug Buildslave Maintenance (Eric Kohl) > 3. Re: [ros-diffs] [fireball] 53446: [NTDLL/LDR] - Fix wrong > loop condition which would often lead to heap underread. - Fix > wrong subkey string length calculation, which would result in an > incorrect string being used... (Ged Murphy) > 4. Re: [ros-diffs] [fireball] 53446: [NTDLL/LDR] - Fix wrong > loop condition which would often lead to heap underread. - Fix > wrong subkey string length calculation, which would result in an > incorrect string being used... (Aleksey Bragin) > 5. Re: Debug Buildslave Maintenance (Aleksey Bragin) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Thu, 25 Aug 2011 23:29:55 +0200 > From: caemyr(a)myopera.com > Subject: Re: [ros-dev] Debug Buildslave Maintenance > To: "ReactOS Development List" <ros-dev(a)reactos.org> > Message-ID: > <1314307795.18690.140258133790149(a)webmail.messagingengine.com> > Content-Type: text/plain; charset="us-ascii" > > @Eric > > http://reactos.org/testman/compare.php?ids=7429,7579 > http://reactos.org/testman/detail.php?id=2639952 > > Please find that the crash is not CMake related, and CMake build is not > inherently broken. > > On Thu, 25 Aug 2011 23:03 +0200, "Pierre Schweitzer" > <pierre.schweitzer(a)reactos.org> wrote: >> Hi, >> >> finally. >> Colin and I are pleased to announce you that ReactOS Linux KVM tests are >> back online and working. You can find the first tests results (on r53383) >> sent tonight by the testbot on testman: http://www.reactos.org/testman/. >> >> Regards, >> Pierre. >> >> ReactOS Development List <ros-dev(a)reactos.org> wrote on Sat, August 20th, >> 2011, 4:24 PM: >> > Timo Kreuzer <timo.kreuzer(a)web.de> wrote: >> > > What about fixing release buildbot first? >> > >> > It's still a private machine owned and administered solely by Christoph. >> > >> > As long as I can't even reach him by phone, we can only wait. >> > >> > >> > > And is there a chance, maybe in the future, to switch buildbots more >> > > easily, to have a backup solution running? >> > >> > First of all, we hope that we can get the same reliability as our other >> > servers after reinstalling the server OS, giving more ReactOS admins >> > access to the machine and adding monitoring. >> > The current OS was meant to be reinstalled for quite a long time, but up >> > >> > to now, nobody with physical access to the machine had any time to do >> > it. >> > >> > If such problems continue to exist afterwards, we can try to set up a >> > fallback system, but this would require an equally configured and >> > powerful Linux machine first. >> > >> > >> > > One week without debug builds is a serious thing. >> > >> > I hope you're aware that builds are still properly uploaded, it's only >> > the testing step which fails. >> > >> > >> > - Colin >> > >> > _______________________________________________ >> > Ros-dev mailing list >> > Ros-dev(a)reactos.org >> > http://www.reactos.org/mailman/listinfo/ros-dev >> >> _______________________________________________ >> Ros-dev mailing list >> Ros-dev(a)reactos.org >> http://www.reactos.org/mailman/listinfo/ros-dev >> > With best regards > Caemyr > > > > ------------------------------ > > Message: 2 > Date: Fri, 26 Aug 2011 01:01:40 +0200 > From: Eric Kohl <eric.kohl(a)t-online.de> > Subject: Re: [ros-dev] Debug Buildslave Maintenance > To: ReactOS Development List <ros-dev(a)reactos.org> > Message-ID: <4E56D454.6060606(a)t-online.de> > Content-Type: text/plain; charset=ISO-8859-1; format=flowed > > Hi Olaf, > > I am already investigating the services test issues. One of my first > findings is that the current widl seems to mess up value ranges in some > cases. This is the cause of the following errors: > err:(dll/win32/rpcrt4/ndr_marshall.c:6496) value exceeded bounds: 918, > low: 0, high: 514 > > <rant> > It is pretty annoying that jgardou updated rpcrt4, widl and other > components without proper testing. At least he should have posted a bug > list BEFORE he comitted the new stuff. > </rant> > > Regards > Eric > >> @Eric >> >> http://reactos.org/testman/compare.php?ids=7429,7579 >> http://reactos.org/testman/detail.php?id=2639952 >> >> Please find that the crash is not CMake related, and CMake build is not >> inherently broken. >> > > > > ------------------------------ > > Message: 3 > Date: Fri, 26 Aug 2011 09:05:21 +0100 > From: "Ged Murphy" <gedmurphy.maillists(a)gmail.com> > Subject: Re: [ros-dev] [ros-diffs] [fireball] 53446: [NTDLL/LDR] - Fix > wrong loop condition which would often lead to heap underread. - Fix > wrong subkey string length calculation, which would result in an > incorrect string being used... > To: <ros-dev(a)reactos.org> > Message-ID: <004201cc63c6$e7a44a40$b6ecdec0$(a)gmail.com> > Content-Type: text/plain; charset="utf-8" > > fireball(a)svn.reactos.org wrote: > >> - Use Zw* functions instead of Nt* where necessary in >> LdrQueryImageFileKeyOption(). > > 'where necessary'm I don't understand this change. > People prefer (and Microsoft recommend) that Nt* is used in usermode. > Nt and Zw APIs point to the same address in usermode, so why is it > necessary? > > Ged. > > > > > > ------------------------------ > > Message: 4 > Date: Fri, 26 Aug 2011 12:13:26 +0400 > From: Aleksey Bragin <aleksey(a)reactos.org> > Subject: Re: [ros-dev] [ros-diffs] [fireball] 53446: [NTDLL/LDR] - Fix > wrong loop condition which would often lead to heap underread. - Fix > wrong subkey string length calculation, which would result in an > incorrect string being used... > To: ReactOS Development List <ros-dev(a)reactos.org> > Message-ID: <7766A32C-3CB0-446A-96F4-4EDC73BC3A29(a)reactos.org> > Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed > > > On Aug 26, 2011, at 12:05 PM, Ged Murphy wrote: > >> fireball(a)svn.reactos.org wrote: >> >>> - Use Zw* functions instead of Nt* where necessary in >>> LdrQueryImageFileKeyOption(). >> >> 'where necessary'm I don't understand this change. >> People prefer (and Microsoft recommend) that Nt* is used in usermode. >> Nt and Zw APIs point to the same address in usermode, so why is it >> necessary? > > This was a test for attention, and so far I got a few notices in IRC > and one in ros-dev. Good! > > Seriously, the change slipped through because I was editing source > code of both RTL (which works both at umode and kmode) and NTDLL/LDR > (which is only umode) a while ago. Of course, Nt is "preferable" in > usermode because there is just no reason to use Zw there. > > > WBR, > Aleksey Bragin. > > > > > ------------------------------ > > Message: 5 > Date: Fri, 26 Aug 2011 12:15:24 +0400 > From: Aleksey Bragin <aleksey(a)reactos.org> > Subject: Re: [ros-dev] Debug Buildslave Maintenance > To: ReactOS Development List <ros-dev(a)reactos.org> > Message-ID: <1F3FEE77-59BC-4D24-83A9-5D280FB45966(a)reactos.org> > Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed > > > On Aug 26, 2011, at 3:01 AM, Eric Kohl wrote: > >> <rant> >> It is pretty annoying that jgardou updated rpcrt4, widl and other >> components without proper testing. At least he should have posted a >> bug list BEFORE he comitted the new stuff. >> </rant> > I also ranted about that. In fact that's why I stopped syncing rpcrt4 > some time ago - because new version always gave problems. So I wanted > to solve problems first and only then commit. > > But, OK, as Olaf said - if something needs to be done, let's simply > do that and fix everything which broke ;). > > WBR, > Aleksey. > > > > > ------------------------------ > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > End of Ros-dev Digest, Vol 84, Issue 22 > *************************************** >

1 0

Debug Buildslave Maintenance
by Colin Finck 26 Aug '11

26 Aug '11

Hello all, The Debug Buildslave will be down for maintenance throughout the next week. We hope to have it fully working again by next weekend. In the process of this maintenance, the OS will be reinstalled to match the one we already use on our other servers. Besides, more of our administrators will get access to the machine, so that further problems can be debugged more easily. - Colin

6 9

Re: [ros-dev] [ros-diffs] [fireball] 53446: [NTDLL/LDR] - Fix wrong loop condition which would often lead to heap underread. - Fix wrong subkey string length calculation, which would result in an incorrect string being used...
by Ged Murphy 26 Aug '11

26 Aug '11

fireball(a)svn.reactos.org wrote: > - Use Zw* functions instead of Nt* where necessary in LdrQueryImageFileKeyOption(). 'where necessary'm I don't understand this change. People prefer (and Microsoft recommend) that Nt* is used in usermode. Nt and Zw APIs point to the same address in usermode, so why is it necessary? Ged.

2 1

August meeting
by Aleksey Bragin 25 Aug '11

25 Aug '11

Hi, this is a reminder about the Status meeting, which is to happen tomorrow, 25th of August at 19:00 UTC. Please don't miss it. Proposed agenda for the meeting: 1. Arwinss adoption voting. 2. CMake adoption voting. 3. Release preparation status report, deciding on the next release date. 4. Driver signing. Discussing possible threats and deciding on an official position wrt driver signing in future. 4. Party related to GSoC results. I propose to move individual devs status reports to ros-dev mailing list, because there is no reason to just sit in the irc channel and listen to them for hours. List of participants: - Giannis Adamopoulos (smiley1_) - Johannes Anderwald (janderwald) - Javier Agustìn Fernàndez Arroyo (elhoir) - Maciej Bialas (niski) - Jan Blomqvist-Kinander (JaixBly) - Aleksey Bragin (abragin) - Thomas Faber (ThFabba) - Colin Finck (Colin_Finck) - Jérôme Gardou (zefklop) - Danny Götte (dangerground) - Cameron Gutman (aicom) - Ziliang Guo (ZWabbit) - Rafal Harabien (rafalh) - Andrew Hill (ash77) - Kamil Hornicek (Pigglesworth) - Gabriel Ilardi (gabriel_it) - Alex Ionescu (Alex_Ionescu) - Amine Khaldi (AmineKhaldi) - Igor Koshpaev (tower) - Timo Kreuzer (tkreuzer) - Matthias Kupfer (Collibri) - Michael Martin (mjmartin) - Victor Martinez (vicmarcal) - Roel Messiant (Mephisto) - Claudiu Mihail (KlausM) - Andrew Munger (WaxDragon) - Ged Murphy (GedMurphy) - Igor Paliychuk (igorko) - Sylvain Petreolle (Usurp) - Hervé Poussineau (hpoussin) - Daniel Reimer (dreimer) - Pierre Schweitzer (HeisSpiter) - Samuel Serapion (encoded) - Olaf Siejka (Caemyr) - James Tabor (jimtabor) - Christoph von Wittich (Christoph_vW) - Art Yerkes (arty) WBR, Aleksey Bragin.

7 9

[53425] ekohl: [HAL] Add PCI_HAL device for non-ACPI machines. Code taken from the ACPI-HAL. This is just a quick hack and needs some more improvements.
by caemyr＠myopera.com 24 Aug '11

24 Aug '11

r53425 broke CMake build. To make the things worse, this is our only working test\iso provider at the moment. I would reckon fixing it a priority. CMakeFiles/hal.dir/generic/halinit.c.obj: In function `HalInitSystem@8': P:/Trunk_slave/x86_CMake/build/hal/halx86/generic/halinit.c:116: undefined reference to `HaliInitPnpDriver@0' collect2: ld returned 1 exit status -- With best regards Caemyr

1 0

Another regression
by caemyr＠myopera.com 24 Aug '11

24 Aug '11

Revision 53257 breaks Vbox test runtime at 2nd stage booting. http://svn.reactos.org/svn/reactos?view=rev&revision=53257 -- With best regards Caemyr

8 12

Re: [ros-dev] [ros-diffs] [akhaldi] 53405: [EVENTLOG] * Fix a bad sizeof().‏
by Pierre Schweitzer 24 Aug '11

24 Aug '11

Hi, same thing that for r53402, but with structure: RPC_SID. Cf: http://doxygen.reactos.org/d5/df6/structRPC__SID.html Regards, Pierre

1 0

Re: [ros-dev] [ros-diffs] [akhaldi] 53402: [HAL] * Fix a couple bad sizeof().‏
by Pierre Schweitzer 24 Aug '11

24 Aug '11

Hi, this is wrong and does actually change nothing regarding previous code. You need to copy data (structure) length, not pointer length. Structure is: CM_PARTIAL_RESOURCE_DESCRIPTOR. Cf: http://doxygen.reactos.org/db/d22/structCM__PARTIAL__RESOURCE__DESCRIPTOR.h… Regards, Pierre

1 0

Re: [ros-dev] [ros-diffs] [akhaldi] 53404: [VIDEOPRT] * Fix a bad sizeof() that's been with us since r12860 (more than 6 years ago).
by Dmitry Gorbachev 24 Aug '11

24 Aug '11

Hi Amine! > - RtlCopyMemory(AgpServices, &Interface.AgpReservePhysical, sizeof(AgpServices)); > + RtlCopyMemory(AgpServices, &Interface.AgpReservePhysical, sizeof(PVIDEO_PORT_AGP_SERVICES)); You mean sizeof(VIDEO_PORT_AGP_SERVICES), right?

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev August 2011