Ros-dev November 2012

ros-dev@reactos.org

10 participants
7 discussions

Re: [ros-dev] [ros-diffs] [hbelusca] 57780: [CPORTLIB/FREELDR] GetByte --> Wait for data (with timeout) and get it if available. PollByte --> Check for data, get it if available, and return immediately.
by Timo Kreuzer 30 Nov '12

30 Nov '12

You are aware that this changes the behavior? Polling previously only checked, if data is available, but didn't read it from the port. But afaics it's only relvenat for WinLdrPortPollOnly, which seems to be unused anyway. Am 29.11.2012 00:16, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Wed Nov 28 23:16:01 2012 > New Revision: 57780 > > URL: http://svn.reactos.org/svn/reactos?rev=57780&view=rev > Log: > [CPORTLIB/FREELDR] > GetByte --> Wait for data (with timeout) and get it if available. > PollByte --> Check for data, get it if available, and return immediately. > > Modified: > trunk/reactos/boot/freeldr/freeldr/comm/rs232.c > trunk/reactos/boot/freeldr/freeldr/windows/headless.c > trunk/reactos/include/reactos/libs/cportlib/cportlib.h > trunk/reactos/lib/cportlib/cport.c > > Modified: trunk/reactos/boot/freeldr/freeldr/comm/rs232.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/comm/… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/comm/rs232.c [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/comm/rs232.c [iso-8859-1] Wed Nov 28 23:16:01 2012 > @@ -100,7 +100,7 @@ > if (PortInitialized == FALSE) > return FALSE; > > - return (CpGetByte(&Rs232ComPort, ByteReceived, FALSE, FALSE) == CP_GET_SUCCESS); > + return (CpGetByte(&Rs232ComPort, ByteReceived, TRUE) == CP_GET_SUCCESS); > } > > /* > @@ -109,12 +109,7 @@ > if (PortInitialized == FALSE) > return FALSE; > > - while ((READ_PORT_UCHAR (SER_LSR(Rs232PortBase)) & SR_LSR_DR) == 0) > - ; > - > - *ByteReceived = READ_PORT_UCHAR (SER_RBR(Rs232PortBase)); > - > - return TRUE; > + return (CpGetByte(&Rs232ComPort, ByteReceived, FALSE) == CP_GET_SUCCESS); > } > */ > > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/headless.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/windows/headless.c [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/windows/headless.c [iso-8859-1] Wed Nov 28 23:16:01 2012 > @@ -143,7 +143,7 @@ > WinLdrPortGetByte(IN ULONG PortId, > OUT PUCHAR Data) > { > - return CpGetByte(&Port[PortId], Data, TRUE, FALSE) == CP_GET_SUCCESS; > + return CpGetByte(&Port[PortId], Data, TRUE) == CP_GET_SUCCESS; > } > > BOOLEAN > @@ -151,7 +151,7 @@ > { > UCHAR Dummy; > > - return CpGetByte(&Port[PortId], &Dummy, FALSE, TRUE) == CP_GET_SUCCESS; > + return CpGetByte(&Port[PortId], &Dummy, FALSE) == CP_GET_SUCCESS; > } > > VOID > > Modified: trunk/reactos/include/reactos/libs/cportlib/cportlib.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/cport… > ============================================================================== > --- trunk/reactos/include/reactos/libs/cportlib/cportlib.h [iso-8859-1] (original) > +++ trunk/reactos/include/reactos/libs/cportlib/cportlib.h [iso-8859-1] Wed Nov 28 23:16:01 2012 > @@ -69,8 +69,7 @@ > CpGetByte( > IN PCPPORT Port, > OUT PUCHAR Byte, > - IN BOOLEAN Wait, > - IN BOOLEAN Poll > + IN BOOLEAN Wait > ); > > VOID > > Modified: trunk/reactos/lib/cportlib/cport.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cportlib/cport.c?rev=5… > ============================================================================== > --- trunk/reactos/lib/cportlib/cport.c [iso-8859-1] (original) > +++ trunk/reactos/lib/cportlib/cport.c [iso-8859-1] Wed Nov 28 23:16:01 2012 > @@ -255,8 +255,7 @@ > NTAPI > CpGetByte(IN PCPPORT Port, > OUT PUCHAR Byte, > - IN BOOLEAN Wait, > - IN BOOLEAN Poll) > + IN BOOLEAN Wait) > { > UCHAR Lsr; > ULONG LimitCount = Wait ? TIMEOUT_COUNT : 1; > @@ -278,9 +277,6 @@ > return CP_GET_ERROR; > } > > - /* If only polling was requested by caller, return now */ > - if (Poll) return CP_GET_SUCCESS; > - > /* Otherwise read the byte and return it */ > *Byte = READ_PORT_UCHAR(Port->Address + RECEIVE_BUFFER_REGISTER); > > > >

2 1

November Status Meeting Tomorrow
by Aleksey Bragin 29 Nov '12

29 Nov '12

Hello, Let me invite you to the monthly status meeting taking place last Thursday of this month, 29th of November, 19:00 UTC. The meeting will be at irc://dev.reactos.org (Port 6667, no SSL) in the channel #meeting, or as Pierre/Colin say. Note that the IRC service will only be started shortly before the meeting. Your participation passwords will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. If someone still is not getting passwords sent before a meeting - please email Colin or Pierre before the meeting started to get one. The agenda will be posted shortly before the meeting, suggestions are welcome (send them to my email as usual). Hot topics would include progress made during this month, contracts updates, release plans (if any), web site progress (if any). With the best regards, Aleksey Bragin

4 4

Re: [ros-dev] [ros-general] Services downtime
by Colin Finck 16 Nov '12

16 Nov '12

Hi all, Pierre Schweitzer <pierre(a)reactos.org> wrote: > due to a hardware migration ongoing on one of our hypervisors, the > following services are currently down: The server upgrade went successfully and everything is back to normal now. Cheers, Colin

1 0

Server upgrade next Friday
by Colin Finck 15 Nov '12

15 Nov '12

Hi all, Several ReactOS services will be moved to a new server next Friday. As this migration highly depends on our hosting provider, the downtime may be up to 24 hours. Affected services include: - ns1.reactos.org - playground.reactos.org - jira.reactos.org The upgrade will improve reliability and adds resources for additional services in the future. Of course, you will be informed once the migration is over. Cheers, Colin

2 3

Re: [ros-dev] [ros-diffs] [hbelusca] 57701: [CSRSRV] - Use a variable ServerDll instead of using each time CsrLoadedServerDll[i], as it is done in some other places. - Clean the code (remove extra-parentheses). - Zero-out t...
by Alex Ionescu 15 Nov '12

15 Nov '12

Would you mind not "cleaning up formatting" by going against our coding style and doing the very thing I even taught you not to do during your initial patches/code reviews? Thanks. Best regards, Alex Ionescu On Tue, Nov 13, 2012 at 1:08 PM, <hbelusca(a)svn.reactos.org> wrote: > - if ((ServerDll) && (ServerDll->HardErrorCallback)) > + if (ServerDll && ServerDll->HardErrorCallback) >

4 5

Re: [ros-dev] [ros-diffs] [pschweitzer] 57674: [DOXYGEN] ReactOS is not C only. Enable support builtin STL.
by Timo Kreuzer 07 Nov '12

07 Nov '12

We have 90 % C. So disabling OPTIMIZE_OUTPUT_FOR_C will probably result in worse readable output for 90% of the code. Am 05.11.2012 12:14, schrieb pschweitzer(a)svn.reactos.org: > Author: pschweitzer > Date: Mon Nov 5 11:13:59 2012 > New Revision: 57674 > > URL: http://svn.reactos.org/svn/reactos?rev=57674&view=rev > Log: > [DOXYGEN] > ReactOS is not C only. > Enable support builtin STL. > > Modified: > trunk/reactos/Doxyfile > > Modified: trunk/reactos/Doxyfile > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/Doxyfile?rev=57674&r1=5767… > ============================================================================== > --- trunk/reactos/Doxyfile [iso-8859-1] (original) > +++ trunk/reactos/Doxyfile [iso-8859-1] Mon Nov 5 11:13:59 2012 > @@ -196,7 +196,7 @@ > # For instance, some of the names that are used will be different. The list > # of all members will be omitted, etc. > > -OPTIMIZE_OUTPUT_FOR_C = YES > +OPTIMIZE_OUTPUT_FOR_C = NO > > # Set the OPTIMIZE_OUTPUT_JAVA tag to YES if your project consists of Java > # sources only. Doxygen will then generate output that is more tailored for > @@ -236,7 +236,7 @@ > # func(std::string) {}). This also make the inheritance and collaboration > # diagrams that involve STL classes more complete and accurate. > > -BUILTIN_STL_SUPPORT = NO > +BUILTIN_STL_SUPPORT = YES > > # If you use Microsoft's C++/CLI language, you should set this option to YES to > # enable parsing support. > > >

3 3

[ros-diffs] [jgardou] 57679: [USER32] - Avoid more rounding issues and hopefully fix MSC build
by James Tabor 06 Nov '12

06 Nov '12

Hi, BE AWARE this is port synced from wine and please notate changes so it will not get lost on the next sync! James

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev November 2012