Ros-dev June 2013

ros-dev@reactos.org

11 participants
10 discussions

Re: [ros-dev] [ros-diffs] [spetreolle] 59349: [KMTESTS:FSRTL] Enable FsRtlMcb tests.
by Aleksey Bragin 28 Jun '13

28 Jun '13

They assert really, on my build, that's why I have not enabled them yet. Anyway, would be nice to see how testman behaves. Regards, Aleksey Bragin On 28.06.2013 23:25, spetreolle(a)svn.reactos.org wrote: > Author: spetreolle > Date: Fri Jun 28 19:25:37 2013 > New Revision: 59349 > > URL: http://svn.reactos.org/svn/reactos?rev=59349&view=rev > Log: > [KMTESTS:FSRTL] > Enable FsRtlMcb tests. > > > Modified: > trunk/rostests/kmtests/kmtest_drv/testlist.c > > Modified: trunk/rostests/kmtests/kmtest_drv/testlist.c > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/kmtests/kmtest_drv/testli… > ============================================================================== > --- trunk/rostests/kmtests/kmtest_drv/testlist.c [iso-8859-1] (original) > +++ trunk/rostests/kmtests/kmtest_drv/testlist.c [iso-8859-1] Fri Jun 28 19:25:37 2013 > @@ -68,8 +68,7 @@ > { "-ExTimer", Test_ExTimer }, > { "Example", Test_Example }, > { "FsRtlExpression", Test_FsRtlExpression }, > - /* Skipped on testman. See ROSTESTS-106. */ > - { "-FsRtlMcb", Test_FsRtlMcb }, > + { "FsRtlMcb", Test_FsRtlMcb }, > { "-FsRtlTunnel", Test_FsRtlTunnel }, > { "IoDeviceInterface", Test_IoDeviceInterface }, > { "IoEvent", Test_IoEvent }, > >

1 0

Status Meeting (June 2013)
by Aleksey Bragin 27 Jun '13

27 Jun '13

Hello, Let me invite you to the monthly status meeting taking place last Thursday of this month, 27th of June, 19:00 UTC. And that's tomorrow! Put that into your calendars so you don't forget. The meeting will be at irc://dev.reactos.org (Port 6667, no SSL) in the channel #meeting, or as Pierre says. Note that the IRC service will only be started shortly before the meeting. Your participation passwords will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. If someone still is not getting passwords sent before a meeting - please email Colin or Pierre before the meeting started to get one. The agenda will be posted shortly before the meeting, suggestions are welcome (send them to me shortly before the meeting starts). Regards, Aleksey Bragin

5 6

Help Me Clean Up My SVN vs_jc branch
by J. C. Jones 24 Jun '13

24 Jun '13

Hi All, A few months ago, an SVN branch, vs_jc, was created so that I could experiment with manual creation of Visual Studio solution. I am ready to start putting files into it, but before I do, I would like to get it synced with the trunk. Unfortunately, I am not very experienced with SVN (more like hopelessly ignorant), and Id like to avoid making a mess if possible. I was hoping that someone could sit with me for the 10-15 minutes that would be needed to get it right so that I dont make a mess. Hermès was helping me yesterday do a merge, but he seems to be out-of-pocket at the moment, and Id rather not wait, as I am blocking the work of others. The merge generated a lot of conflicts, and I see no option on Tortoise SVN menu to resolve them, and I have tried 6 or 7 times myself to do a merge, each time not being clear on what I am doing. I would have no problem whatsoever blowing away vs_jc and simply branching HEAD-of-trunk and starting over, as there is currently nothing that I put in vs_jc that is of value. Cheers! -JC

3 6

Re: [ros-dev] [ros-diffs] [hbelusca] 59314: [KERNEL32] Never EVER process instructions INSIDE a debug macro (e.g. ASSERT) because when compiling in Release Mode, the code isn't executed at all. Fix that. See revision r59310...
by Alex Ionescu 23 Jun '13

23 Jun '13

You should should learnt about NT_VERIFY :) Best regards, Alex Ionescu On Sun, Jun 23, 2013 at 8:55 AM, <hbelusca(a)svn.reactos.org> wrote: > Author: hbelusca > Date: Sun Jun 23 12:55:17 2013 > New Revision: 59314 > > URL: http://svn.reactos.org/svn/reactos?rev=59314&view=rev > Log: > [KERNEL32] > Never EVER process instructions INSIDE a debug macro (e.g. ASSERT) because > when compiling in Release Mode, the code isn't executed at all. > Fix that. See revision r59310 for more details. > > Modified: > branches/ntvdm/dll/win32/kernel32/client/proc.c > > Modified: branches/ntvdm/dll/win32/kernel32/client/proc.c > URL: > http://svn.reactos.org/svn/reactos/branches/ntvdm/dll/win32/kernel32/client… > > ============================================================================== > --- branches/ntvdm/dll/win32/kernel32/client/proc.c [iso-8859-1] > (original) > +++ branches/ntvdm/dll/win32/kernel32/client/proc.c [iso-8859-1] Sun > Jun 23 12:55:17 2013 > @@ -2541,6 +2541,7 @@ > WCHAR SaveChar = 0; > ULONG RetVal; > UINT Error = 0; > + UINT Length; > BOOLEAN SearchDone = FALSE; > BOOLEAN Escape = FALSE; > CLIENT_ID ClientId; > @@ -2630,7 +2631,13 @@ > } > > /* Get the path to the VDM host */ > - ASSERT(GetSystemDirectoryW(VdmPath, MAX_PATH - wcslen(NTVDM_STRING)) > != 0); > + Length = GetSystemDirectoryW(VdmPath, MAX_PATH - > wcslen(NTVDM_STRING)); > + if ((Length == 0) || (Length >= MAX_PATH - wcslen(NTVDM_STRING))) > + { > + /* System path not found for some reason, fail */ > + SetLastError(ERROR_INVALID_NAME); > + return FALSE; > + } > wcscat(VdmPath, NTVDM_STRING); > > /* > > >

2 1

Re: [ros-dev] [ros-diffs] [dreimer] 59242: Right-to-Left mirroring fixes for various applications by Baruch Rutman CORE-7015 #resolve #comment Committed in revision r59241, thanks for help.
by Timo Kreuzer 17 Jun '13

17 Jun '13

Since there are more RTL languages, shouldn't we use some flag rather than hardcoding hebrew? Am 17.06.2013 00:04, schrieb dreimer(a)svn.reactos.org: > Author: dreimer > Date: Sun Jun 16 22:04:48 2013 > New Revision: 59242 > > URL: http://svn.reactos.org/svn/reactos?rev=59242&view=rev > Log: > Right-to-Left mirroring fixes for various applications by Baruch Rutman > CORE-7015 #resolve #comment Committed in revision r59241, thanks for help. > > Modified: > trunk/reactos/base/applications/fontview/fontview.c > trunk/reactos/base/applications/fontview/fontview.h > trunk/reactos/base/applications/kbswitch/kbswitch.c > trunk/reactos/base/applications/magnify/magnifier.c > trunk/reactos/base/applications/magnify/magnifier.h > trunk/reactos/base/applications/mscutils/devmgmt/devmgmt.c > trunk/reactos/base/applications/mscutils/devmgmt/precomp.h > trunk/reactos/base/applications/mscutils/servman/precomp.h > trunk/reactos/base/applications/mscutils/servman/servman.c > trunk/reactos/base/applications/notepad/main.c > trunk/reactos/base/applications/rapps/winmain.c > trunk/reactos/base/applications/regedit/main.c > > Modified: trunk/reactos/base/applications/fontview/fontview.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/fontview… > ============================================================================== > --- trunk/reactos/base/applications/fontview/fontview.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/fontview/fontview.c [iso-8859-1] Sun Jun 16 22:04:48 2013 > @@ -94,7 +94,17 @@ > HINSTANCE hDLL; > PGFRI GetFontResourceInfoW; > LPCWSTR fileName; > - > + > + switch (GetUserDefaultUILanguage()) > + { > + case MAKELANGID(LANG_HEBREW, SUBLANG_DEFAULT): > + SetProcessDefaultLayout(LAYOUT_RTL); > + break; > + > + default: > + break; > + } > + > g_hInstance = hThisInstance; > > /* Get unicode command line */ > > Modified: trunk/reactos/base/applications/fontview/fontview.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/fontview… > ============================================================================== > --- trunk/reactos/base/applications/fontview/fontview.h [iso-8859-1] (original) > +++ trunk/reactos/base/applications/fontview/fontview.h [iso-8859-1] Sun Jun 16 22:04:48 2013 > @@ -1,6 +1,7 @@ > #include <stdarg.h> > #include <windef.h> > #include <winbase.h> > +#include <winnls.h> > #include <shellapi.h> > > #include "resource.h" > > Modified: trunk/reactos/base/applications/kbswitch/kbswitch.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/kbswitch… > ============================================================================== > --- trunk/reactos/base/applications/kbswitch/kbswitch.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/kbswitch/kbswitch.c [iso-8859-1] Sun Jun 16 22:04:48 2013 > @@ -516,6 +516,17 @@ > { > WNDCLASS WndClass = {0}; > MSG msg; > + > + switch (GetUserDefaultUILanguage()) > + { > + case MAKELANGID(LANG_HEBREW, SUBLANG_DEFAULT): > + SetProcessDefaultLayout(LAYOUT_RTL); > + break; > + > + default: > + break; > + } > + > HANDLE hMutex; > > hMutex = CreateMutex(NULL, FALSE, szKbSwitcherName); > > Modified: trunk/reactos/base/applications/magnify/magnifier.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/magnify/… > ============================================================================== > --- trunk/reactos/base/applications/magnify/magnifier.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/magnify/magnifier.c [iso-8859-1] Sun Jun 16 22:04:48 2013 > @@ -45,7 +45,17 @@ > // TODO: Place code here. > MSG msg; > HACCEL hAccelTable; > - > + > + switch (GetUserDefaultUILanguage()) > + { > + case MAKELANGID(LANG_HEBREW, SUBLANG_DEFAULT): > + SetProcessDefaultLayout(LAYOUT_RTL); > + break; > + > + default: > + break; > + } > + > UNREFERENCED_PARAMETER(hPrevInstance); > UNREFERENCED_PARAMETER(lpCmdLine); > > @@ -170,7 +180,7 @@ > HDC HdcStrech; > HANDLE hOld; > HBITMAP HbmpStrech; > - > + > RECT R; > RECT appRect; > DWORD rop = SRCCOPY; > @@ -202,7 +212,7 @@ > > /* Select our bitmap in memory DC and save the old one.*/ > hOld = SelectObject (HdcStrech , HbmpStrech); > - > + > /* Paint the screen bitmap to our in memory DC */ > BitBlt( > HdcStrech, > @@ -214,7 +224,7 @@ > 0, > 0, > SRCCOPY); > - > + > /* Draw the mouse pointer in the right position */ > DrawIcon( > HdcStrech , > @@ -271,8 +281,9 @@ > blitAreaY, > blitAreaWidth, > blitAreaHeight, > - rop); > - > + rop | NOMIRRORBITMAP); > + > + > /* Cleanup.*/ > if (iinfo.hbmMask) > DeleteObject(iinfo.hbmMask); > > Modified: trunk/reactos/base/applications/magnify/magnifier.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/magnify/… > ============================================================================== > --- trunk/reactos/base/applications/magnify/magnifier.h [iso-8859-1] (original) > +++ trunk/reactos/base/applications/magnify/magnifier.h [iso-8859-1] Sun Jun 16 22:04:48 2013 > @@ -25,6 +25,7 @@ > #include <winreg.h> > #include <wingdi.h> > #include <tchar.h> > +#include <winnls.h> //test > > #include "resource.h" > > > Modified: trunk/reactos/base/applications/mscutils/devmgmt/devmgmt.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… > ============================================================================== > --- trunk/reactos/base/applications/mscutils/devmgmt/devmgmt.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/mscutils/devmgmt/devmgmt.c [iso-8859-1] Sun Jun 16 22:04:48 2013 > @@ -34,7 +34,17 @@ > } > return 0; > } > + > + switch (GetUserDefaultUILanguage()) > + { > + case MAKELANGID(LANG_HEBREW, SUBLANG_DEFAULT): > + SetProcessDefaultLayout(LAYOUT_RTL); > + break; > > + default: > + break; > + } > + > hInstance = hThisInstance; > ProcessHeap = GetProcessHeap(); > > > Modified: trunk/reactos/base/applications/mscutils/devmgmt/precomp.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… > ============================================================================== > --- trunk/reactos/base/applications/mscutils/devmgmt/precomp.h [iso-8859-1] (original) > +++ trunk/reactos/base/applications/mscutils/devmgmt/precomp.h [iso-8859-1] Sun Jun 16 22:04:48 2013 > @@ -7,6 +7,7 @@ > #include <winuser.h> > #include <winreg.h> > #include <wingdi.h> > +#include <winnls.h> > #include <windowsx.h> > #include <tchar.h> > #include <setupapi.h> > > Modified: trunk/reactos/base/applications/mscutils/servman/precomp.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… > ============================================================================== > --- trunk/reactos/base/applications/mscutils/servman/precomp.h [iso-8859-1] (original) > +++ trunk/reactos/base/applications/mscutils/servman/precomp.h [iso-8859-1] Sun Jun 16 22:04:48 2013 > @@ -8,6 +8,7 @@ > #include <windef.h> > #include <winbase.h> > #include <wingdi.h> > +#include <winnls.h> > #include <winsvc.h> > #include <winuser.h> > #include <windowsx.h> /* GET_X/Y_LPARAM */ > > Modified: trunk/reactos/base/applications/mscutils/servman/servman.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… > ============================================================================== > --- trunk/reactos/base/applications/mscutils/servman/servman.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/mscutils/servman/servman.c [iso-8859-1] Sun Jun 16 22:04:48 2013 > @@ -8,7 +8,6 @@ > */ > > #include "precomp.h" > - > HINSTANCE hInstance; > HANDLE ProcessHeap; > > @@ -23,7 +22,17 @@ > MSG Msg; > int Ret = 1; > INITCOMMONCONTROLSEX icex; > + > + switch (GetUserDefaultUILanguage()) > + { > + case MAKELANGID(LANG_HEBREW, SUBLANG_DEFAULT): > + SetProcessDefaultLayout(LAYOUT_RTL); > + break; > > + default: > + break; > + } > + > hInstance = hThisInstance; > ProcessHeap = GetProcessHeap(); > > > Modified: trunk/reactos/base/applications/notepad/main.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/notepad/… > ============================================================================== > --- trunk/reactos/base/applications/notepad/main.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/notepad/main.c [iso-8859-1] Sun Jun 16 22:04:48 2013 > @@ -554,7 +554,17 @@ > HMONITOR monitor; > MONITORINFO info; > INT x, y; > - > + > + switch (GetUserDefaultUILanguage()) > + { > + case MAKELANGID(LANG_HEBREW, SUBLANG_DEFAULT): > + SetProcessDefaultLayout(LAYOUT_RTL); > + break; > + > + default: > + break; > + } > + > static const TCHAR className[] = _T("NPClass"); > static const TCHAR winName[] = _T("Notepad"); > > > Modified: trunk/reactos/base/applications/rapps/winmain.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/wi… > ============================================================================== > --- trunk/reactos/base/applications/rapps/winmain.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/rapps/winmain.c [iso-8859-1] Sun Jun 16 22:04:48 2013 > @@ -763,7 +763,17 @@ > WCHAR szErrorText[MAX_STR_LEN]; > HANDLE hMutex = NULL; > MSG Msg; > - > + > + switch (GetUserDefaultUILanguage()) > + { > + case MAKELANGID(LANG_HEBREW, SUBLANG_DEFAULT): > + SetProcessDefaultLayout(LAYOUT_RTL); > + break; > + > + default: > + break; > + } > + > hInst = hInstance; > > if (!IsUserAnAdmin()) > > Modified: trunk/reactos/base/applications/regedit/main.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… > ============================================================================== > --- trunk/reactos/base/applications/regedit/main.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/regedit/main.c [iso-8859-1] Sun Jun 16 22:04:48 2013 > @@ -207,6 +207,16 @@ > LoadStringW(hInstance, IDC_REGEDIT_FRAME, szFrameClass, MAX_LOADSTRING); > LoadStringW(hInstance, IDC_REGEDIT, szChildClass, MAX_LOADSTRING); > > + > + switch (GetUserDefaultUILanguage()) > + { > + case MAKELANGID(LANG_HEBREW, SUBLANG_DEFAULT): > + SetProcessDefaultLayout(LAYOUT_RTL); > + break; > + > + default: > + break; > + } > /* Store instance handle in our global variable */ > hInst = hInstance; > > > >

1 0

Re: [ros-dev] [ros-diffs] [dreimer] 59238: logical 'and' applied to non-boolean constant Reviewed by Thomas Faber and asked for commit, so blame him! CORE-7207 #resolve #comment Fixed!
by Timo Kreuzer 17 Jun '13

17 Jun '13

That is still not correct. MM_DECOMMIT (which should be aliased as MM_GUARDPAGE) is 0x10. BUT, this is only a guardpage, if 0x8, aka MM_NOCACHE is not set. it's like this: Protection & 0x18 == 0x00: normal 0x08: uncached 0x10: guard page 0x18: write combined see http://www.reactos.org/wiki/Techwiki:Memory_Protection_constants Am 16.06.2013 22:37, schrieb dreimer(a)svn.reactos.org: > Author: dreimer > Date: Sun Jun 16 20:37:04 2013 > New Revision: 59238 > > URL: http://svn.reactos.org/svn/reactos?rev=59238&view=rev > Log: > logical 'and' applied to non-boolean constant > Reviewed by Thomas Faber and asked for commit, so blame him! > CORE-7207 #resolve #comment Fixed! > > Modified: > trunk/reactos/ntoskrnl/mm/ARM3/vadnode.c > > Modified: trunk/reactos/ntoskrnl/mm/ARM3/vadnode.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/vadnode.c… > ============================================================================== > --- trunk/reactos/ntoskrnl/mm/ARM3/vadnode.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/ARM3/vadnode.c [iso-8859-1] Sun Jun 16 20:37:04 2013 > @@ -647,7 +647,7 @@ > (EndAddress >= ((PMMVAD_LONG)Vad)->u3.Secured.StartVpn)) > { > /* Guard page? */ > - if (ProtectionMask && MM_DECOMMIT) > + if (ProtectionMask & MM_DECOMMIT) > { > DPRINT1("Not allowed to change protection on guard page!\n"); > return STATUS_INVALID_PAGE_PROTECTION; > > >

1 0

[ros-diffs] [jgardou] 59174: [WIN32K] - Don't crash if the focus message queue is NULL
by James Tabor 09 Jun '13

09 Jun '13

What application failed? Thanks, James

2 2

Re: [ros-dev] [ros-diffs] [hbelusca] 59165: [RTL] Use RtlPrefixUnicodeString.
by Hermès BÉLUSCA - MAÏTO 03 Jun '13

03 Jun '13

( end of the message) , and its more elegant than many (str[i] != prefix[i] || ) instructions. Maybe youre criticizing this change because of performances reasons ? Cheers Hermès De : Hermès BÉLUSCA - MAÏTO [mailto:hermes.belusca@sfr.fr] Envoyé : lundi 3 juin 2013 11:10 À : 'ReactOS Development List' Objet : RE: [ros-dev] [ros-diffs] [hbelusca] 59165: [RTL] Use RtlPrefixUnicodeString. It was suggested by Thomas Faber, during some fixes of path.c De : ros-dev-bounces(a)reactos.org [mailto:ros-dev-bounces@reactos.org] De la part de Alex Ionescu Envoyé : lundi 3 juin 2013 04:33 À : ReactOS Development List Cc : Linda Wang Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 59165: [RTL] Use RtlPrefixUnicodeString. You should realize there's sometimes a reason why code doesn't use an existing helper function. Among some very good bug fixes and patches, you really seem to love changing code just for the sake of changing code. Best regards, Alex Ionescu On Sun, Jun 2, 2013 at 3:51 PM, <hbelusca(a)svn.reactos.org> wrote: Author: hbelusca Date: Sun Jun 2 22:51:24 2013 New Revision: 59165 URL: http://svn.reactos.org/svn/reactos?rev=59165 <http://svn.reactos.org/svn/reactos?rev=59165&view=rev> &view=rev Log: [RTL] Use RtlPrefixUnicodeString. Modified: trunk/reactos/lib/rtl/path.c Modified: trunk/reactos/lib/rtl/path.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/path.c?rev=59165 <http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/path.c?rev=59165&r 1=59164&r2=59165&view=diff> &r1=59164&r2=59165&view=diff ============================================================================ == --- trunk/reactos/lib/rtl/path.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/path.c [iso-8859-1] Sun Jun 2 22:51:24 2013 @@ -479,13 +479,19 @@ /* Capture input string */ CapturedDosName = *DosName; - /* Check for \\?\ form */ - if ((CapturedDosName.Length <= RtlpWin32NtRootSlash.Length) || - (CapturedDosName.Buffer[0] != RtlpWin32NtRootSlash.Buffer[0]) || - (CapturedDosName.Buffer[1] != RtlpWin32NtRootSlash.Buffer[1]) || - (CapturedDosName.Buffer[2] != RtlpWin32NtRootSlash.Buffer[2]) || - (CapturedDosName.Buffer[3] != RtlpWin32NtRootSlash.Buffer[3])) - { + /* Check for the presence of the NT prefix "\\?\" form */ + if (RtlPrefixUnicodeString(&RtlpWin32NtRootSlash, &CapturedDosName, FALSE)) + { + /* NT prefix is contained in the path */ + + /* Use the optimized path after acquiring the lock */ + QuickPath = TRUE; + NewBuffer = NULL; + } + else + { + /* NT prefix is not contained in the path */ + /* Quick path won't be used */ QuickPath = FALSE; @@ -497,12 +503,6 @@ NewBuffer = RtlAllocateHeap(RtlGetProcessHeap(), 0, MaxLength); DPRINT("MaxLength: %lx\n", MaxLength); if (!NewBuffer) return STATUS_NO_MEMORY; - } - else - { - /* Use the optimized path after acquiring the lock */ - QuickPath = TRUE; - NewBuffer = NULL; } /* Lock the PEB and check if the quick path can be used */

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 59165: [RTL] Use RtlPrefixUnicodeString.
by Alex Ionescu 03 Jun '13

03 Jun '13

You should realize there's sometimes a reason why code doesn't use an existing helper function. Among some very good bug fixes and patches, you really seem to love changing code just for the sake of changing code. Best regards, Alex Ionescu On Sun, Jun 2, 2013 at 3:51 PM, <hbelusca(a)svn.reactos.org> wrote: > Author: hbelusca > Date: Sun Jun 2 22:51:24 2013 > New Revision: 59165 > > URL: http://svn.reactos.org/svn/reactos?rev=59165&view=rev > Log: > [RTL] > Use RtlPrefixUnicodeString. > > Modified: > trunk/reactos/lib/rtl/path.c > > Modified: trunk/reactos/lib/rtl/path.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/path.c?rev=59165&r… > > ============================================================================== > --- trunk/reactos/lib/rtl/path.c [iso-8859-1] (original) > +++ trunk/reactos/lib/rtl/path.c [iso-8859-1] Sun Jun 2 22:51:24 > 2013 > @@ -479,13 +479,19 @@ > /* Capture input string */ > CapturedDosName = *DosName; > > - /* Check for \\?\ form */ > - if ((CapturedDosName.Length <= RtlpWin32NtRootSlash.Length) || > - (CapturedDosName.Buffer[0] != RtlpWin32NtRootSlash.Buffer[0]) || > - (CapturedDosName.Buffer[1] != RtlpWin32NtRootSlash.Buffer[1]) || > - (CapturedDosName.Buffer[2] != RtlpWin32NtRootSlash.Buffer[2]) || > - (CapturedDosName.Buffer[3] != RtlpWin32NtRootSlash.Buffer[3])) > - { > + /* Check for the presence of the NT prefix "\\?\" form */ > + if (RtlPrefixUnicodeString(&RtlpWin32NtRootSlash, &CapturedDosName, > FALSE)) > + { > + /* NT prefix is contained in the path */ > + > + /* Use the optimized path after acquiring the lock */ > + QuickPath = TRUE; > + NewBuffer = NULL; > + } > + else > + { > + /* NT prefix is not contained in the path */ > + > /* Quick path won't be used */ > QuickPath = FALSE; > > @@ -497,12 +503,6 @@ > NewBuffer = RtlAllocateHeap(RtlGetProcessHeap(), 0, MaxLength); > DPRINT("MaxLength: %lx\n", MaxLength); > if (!NewBuffer) return STATUS_NO_MEMORY; > - } > - else > - { > - /* Use the optimized path after acquiring the lock */ > - QuickPath = TRUE; > - NewBuffer = NULL; > } > > /* Lock the PEB and check if the quick path can be used */ > > >

2 1

Re: [ros-dev] [ros-builds] Linux_AMD64_2 VMWPlayer-Test: build failed
by Pierre Schweitzer 02 Jun '13

02 Jun '13

Revisions >= 59161 are fine (before starting with 59152 they are broken - known). This is only due to a VMware testbot internal failure. This is now fixed. Sorry for the flood. On 03/06/2013 00:28, buildbot(a)reactos.org wrote: > The Buildbot has detected a failed build on builder Linux_AMD64_2 VMWPlayer-Test while building ReactOS. > Full details are available at: > http://build.reactos.org/builders/Linux_AMD64_2%20VMWPlayer-Test/builds/985 > > Buildbot URL: http://build.reactos.org/ > > Buildslave for this Build: Linux_AMD64_2 > > Build Reason: Triggerable(Linux_AMD64_1 KVM-Test Trigger) > Build Source Stamp: 59161 > Blamelist: > > BUILD FAILED: failed test > > sincerely, > -The Buildbot > > > > -- Pierre Schweitzer<pierre at reactos.org> System Administrator ReactOS Foundation

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev June 2013