Ros-dev July 2013

ros-dev@reactos.org

14 participants
11 discussions

Re: [ros-dev] [ros-diffs] [akhaldi] 59598: [CMAKE/GCC] * Compile debug builds using -O1 instead of -Os. This results in faster compilation time with no measurable difference in runtime performance according to tests. CORE-7...

by Alex Ionescu

I don't really like this. Maybe only do this on the build server, or at least don't do it to kernel code. "Measurable" difference in performance doesn't really mean much on an OS that does not have any performance infrastructure, but trust me, there's a difference between O1 and O2. Best regards, Alex Ionescu On Wed, Jul 31, 2013 at 6:04 AM, <akhaldi(a)svn.reactos.org> wrote: > Author: akhaldi > Date: Wed Jul 31 13:04:38 2013 > New Revision: 59598 > > URL: http://svn.reactos.org/svn/reactos?rev=59598&view=rev > Log: > [CMAKE/GCC] > * Compile debug builds using -O1 instead of -Os. This results in faster > compilation time with no measurable difference in runtime performance > according to tests. > CORE-7374 #resolve #comment Committed in r59598. > > Modified: > trunk/reactos/cmake/config.cmake > > Modified: trunk/reactos/cmake/config.cmake > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/config.cmake?rev=595… > > ============================================================================== > --- trunk/reactos/cmake/config.cmake [iso-8859-1] (original) > +++ trunk/reactos/cmake/config.cmake [iso-8859-1] Wed Jul 31 13:04:38 > 2013 > @@ -10,7 +10,7 @@ > set(TUNE "i686" CACHE STRING > "Which CPU ReactOS should be optimized for.") > > -set(OPTIMIZE "1" CACHE STRING > +set(OPTIMIZE "4" CACHE STRING > "What level of optimization to use. > 0 = off > 1 = Default option, optimize for size (-Os) with some additional options > > >

11 years, 4 months

(no subject)

by elhoir

Hi all My Gmail account has been compromised. The mail i have sent to you is spam. I have just changed my password. Sorry for the inconveniences.

11 years, 4 months

Status Meeting (July 2013)

by Aleksey Bragin

Hello, Let me invite you to the monthly status meeting taking place last Thursday of this month, 25th of Julu, 19:00 UTC. Put that into your calendars so you don't forget. I will handle the technical side of the meeting and you will get your login credentials shortly before the meeting. If someone still is not getting passwords sent before a meeting - please email Colin or Pierre before the meeting started to get one. The agenda will be posted shortly before the meeting, suggestions are welcome (preferably send them to me before the meeting starts). Regards, Aleksey Bragin

11 years, 5 months

new TSVN version

by Timo Kreuzer

Hi, For all TSVN users: the new version 1.8.0 is broken. Merging doesn't work and aborts once you get a conflict. I had to install a nightly to make that work. Also: it uses a new working copy format, which is incompatible with older svn versions, like the one we use in RosBE. Which you would also need to update. Therefore I suggest to not update it yet, unless you really know what you are doing. I don't want to hear complaints later ;-) Timo

11 years, 5 months

Re: [ros-dev] [ros-diffs] [akhaldi] 59507: [DBGHELPHOST] * Fix some warnings. Brought to you by Thomas Faber.

by Timo Kreuzer

Seeing the __x86_64__ change, I wonder: Does the code work with 64 bit GCC builds? I mean 64 bit target not 64 bit host. Am 19.07.2013 02:11, schrieb akhaldi(a)svn.reactos.org: > Author: akhaldi > Date: Fri Jul 19 00:11:08 2013 > New Revision: 59507 > > URL: http://svn.reactos.org/svn/reactos?rev=59507&view=rev > Log: > [DBGHELPHOST] > * Fix some warnings. Brought to you by Thomas Faber. > > Modified: > trunk/reactos/dll/win32/dbghelp/compat.h > trunk/reactos/dll/win32/dbghelp/symbol.c > > Modified: trunk/reactos/dll/win32/dbghelp/compat.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/compat.h… > ============================================================================== > --- trunk/reactos/dll/win32/dbghelp/compat.h [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/dbghelp/compat.h [iso-8859-1] Fri Jul 19 00:11:08 2013 > @@ -15,7 +15,11 @@ > #define min(x, y) (((x) < (y)) ? (x) : (y)) > #define max(x, y) (((x) > (y)) ? (x) : (y)) > > +#ifdef __i386__ > #define CDECL __cdecl > +#else > +#define CDECL > +#endif > typedef PVOID IUnknown, IDispatch, IRecordInfo; > > // windef.h > @@ -719,7 +723,6 @@ > > BOOL WINAPI SymEnumerateModulesW64(HANDLE hProcess, PSYM_ENUMMODULES_CALLBACKW64 EnumModulesCallback, PVOID UserContext); > > -#ifndef _LP64 > typedef struct _tagADDRESS > { > DWORD Offset; > @@ -763,23 +766,6 @@ > typedef BOOL (CALLBACK *PSYM_ENUMSYMBOLS_CALLBACK)(PCSTR, ULONG, ULONG, PVOID); > typedef BOOL (CALLBACK *PSYM_ENUMSYMBOLS_CALLBACKW)(PCWSTR, ULONG, ULONG, PVOID); > > -#else > -#define ADDRESS ADDRESS64 > -#define LPADDRESS LPADDRESS64 > -#define IMAGEHLP_MODULE IMAGEHLP_MODULE64 > -#define PIMAGEHLP_MODULE PIMAGEHLP_MODULE64 > -#define IMAGEHLP_MODULEW IMAGEHLP_MODULEW64 > -#define PIMAGEHLP_MODULEW PIMAGEHLP_MODULEW64 > -#define PENUMLOADED_MODULES_CALLBACK PENUMLOADED_MODULES_CALLBACK64 > -#define PFUNCTION_TABLE_ACCESS_ROUTINE PFUNCTION_TABLE_ACCESS_ROUTINE64 > -#define PTRANSLATE_ADDRESS_ROUTINE PTRANSLATE_ADDRESS_ROUTINE64 > -#define PSYMBOL_REGISTERED_CALLBACK PSYMBOL_REGISTERED_CALLBACK64 > -#define PREAD_PROCESS_MEMORY_ROUTINE PREAD_PROCESS_MEMORY_ROUTINE64 > -#define PGET_MODULE_BASE_ROUTINE PGET_MODULE_BASE_ROUTINE64 > -#define PSYM_ENUMMODULES_CALLBACK PSYM_ENUMMODULES_CALLBACK64 > -#define PSYM_ENUMSYMBOLS_CALLBACK PSYM_ENUMSYMBOLS_CALLBACK64 > -#define PSYM_ENUMSYMBOLS_CALLBACKW PSYM_ENUMSYMBOLS_CALLBACKW64 > -#endif > typedef struct _IMAGEHLP_MODULE64 > { > DWORD SizeOfStruct; > > Modified: trunk/reactos/dll/win32/dbghelp/symbol.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/symbol.c… > ============================================================================== > --- trunk/reactos/dll/win32/dbghelp/symbol.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/dbghelp/symbol.c [iso-8859-1] Fri Jul 19 00:11:08 2013 > @@ -70,7 +70,7 @@ > > DWORD symt_ptr2index(struct module* module, const struct symt* sym) > { > -#ifdef _WIN64 > +#ifdef __x86_64__ > const struct symt** c; > int len = vector_length(&module->vsymt), i; > > @@ -91,7 +91,7 @@ > > struct symt* symt_index2ptr(struct module* module, DWORD id) > { > -#ifdef _WIN64 > +#ifdef __x86_64__ > if (!id-- || id >= vector_length(&module->vsymt)) return NULL; > return *(struct symt**)vector_at(&module->vsymt, id); > #else > > >

11 years, 5 months

Re: [ros-dev] [ros-diffs] [ion] 59516: [WIN32K]: Get rid of unused variables, fix all warnings on GCC 4.7

by Timo Kreuzer

This one is used for debugging. We have this in other places, too, so we should add a define __unused __attribute__((unused)) for GCC or something Or we simply silence the warning. Am 19.07.2013 19:06, schrieb ion(a)svn.reactos.org: > ============================================================================== > --- trunk/reactos/win32ss/gdi/ntgdi/gdiobj.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/gdi/ntgdi/gdiobj.c [iso-8859-1] Fri Jul 19 17:06:14 2013 > @@ -570,20 +570,18 @@ > NTAPI > GDIOBJ_vReferenceObjectByPointer(POBJ pobj) > { > - ULONG cRefs; > - > /* Check if the object has a handle */ > if (GDI_HANDLE_GET_INDEX(pobj->hHmgr)) > { > /* Increase the handle's reference count */ > ULONG ulIndex = GDI_HANDLE_GET_INDEX(pobj->hHmgr); > ASSERT((gpaulRefCount[ulIndex] & REF_MASK_COUNT) > 0); > - cRefs = InterlockedIncrement((LONG*)&gpaulRefCount[ulIndex]); > + InterlockedIncrement((LONG*)&gpaulRefCount[ulIndex]); > } > else > { > /* Increase the object's reference count */ > - cRefs = InterlockedIncrement((LONG*)&pobj->ulShareCount); > + InterlockedIncrement((LONG*)&pobj->ulShareCount); > } > > DBG_LOGEVENT(&pobj->slhLog, EVENT_REFERENCE, cRefs); >

11 years, 5 months

Invitation to use Google Talk

by Google Talk

----------------------------------------------------------------------- You've been invited by Arko Provo Mukherjee to use Google Talk. If you already have a Google account, login to Gmail and accept this chat invitation: http://mail.google.com/mail/invite/ANGjdJ-gMIk8L4uuoyU5YtzDlK2ibGGKMwAfqeBl… To sign up for a Google account and get started with Google Talk, you can visit: http://mail.google.com/mail/invite/ANGjdJ_JcFNadwaeZRu5N3VGScKYh8ScvjePyGZO… Learn more at: http://www.google.com/intl/en/landing/accounts/ Thanks, The Google Team

11 years, 5 months

r60000 is comming closer and closer!

by Александр

11 years, 5 months

get builds ajax error

by Александр

get builds ajax error

11 years, 5 months

[ros-diffs] [aandrejevic] 5XXXX: [NTVDM]

by James Tabor

Wow! I'm having FreeDOS flash backs! Good work! James

11 years, 5 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev July 2013