Ros-dev November 2014

ros-dev@reactos.org

24 participants
27 discussions

Status Meeting
by Aleksey Bragin 19 Dec '14

19 Dec '14

Hey, since we skipped the meeting this week, I propose we do make a joint November-December meeting somewhere in the middle of December. (as we did in the previous year too). How about 18th of December? Regards, Aleksey Bragin

5 8

Claim your commits
by Alexander Rechitskiy 30 Nov '14

30 Nov '14

2 5

Re: [ros-dev] [ros-diffs] [hbelusca] 65519: [WIN32K][ROSTESTS] So... ... first of all NtUserQueryInformationThread takes only 4 parameters in Win2k3 so do it as well... ... and since we claim at being compatible with Win2k3...
by Aleksey Bragin 29 Nov '14

29 Nov '14

The one who does it - please make sure to stick to the appropriate Service Pack version too. Regards, Aleksey Bragin On 29.11.2014 2:19, hbelusca(a)svn.reactos.org wrote: > Author: hbelusca > Date: Fri Nov 28 23:19:25 2014 > New Revision: 65519 > > URL: http://svn.reactos.org/svn/reactos?rev=65519&view=rev > Log: > [WIN32K][ROSTESTS] > So... > ... first of all NtUserQueryInformationThread takes only 4 parameters in Win2k3 so do it as well... > ... and since we claim at being compatible with Win2k3 (and not XP), one **MUST** review **ALL** our win32k exports, in win32ss/w32ksvc.db database first, and then in our w32kdll apitests !!!!! > But I won't do it ! >

1 0

Mention of ReactOS in some security book...
by Hermès BÉLUSCA - MAÏTO 27 Nov '14

27 Nov '14

Hi ! While searching for something I stumbled upon this : http://books.google.fr/books?id=YjwKAwAAQBAJ <http://books.google.fr/books?id=YjwKAwAAQBAJ&pg=RA1-PA331&lpg=RA1-PA331&dq= reactos+shell+new&source=bl&ots=D1hNcK_QQx&sig=n95n-VyBUgC326b3vbqg6p1QgXU&h l=fr&sa=X&ei=7VZ3VN-5O8viaqbSgSg&ved=0CEgQ6AEwCQ#v=onepage&q=reactos%20shell %20new&f=false> &pg=RA1-PA331&lpg=RA1-PA331&dq=reactos+shell+new&source=bl&ots=D1hNcK_QQx&si g=n95n-VyBUgC326b3vbqg6p1QgXU&hl=fr&sa=X&ei=7VZ3VN-5O8viaqbSgSg&ved=0CEgQ6AE wCQ#v=onepage&q=reactos%20shell%20new&f=false Read section: Creating a Custom Shell. They use ReactOS (and RosBE 1.5, a piece of history ^^) for their purpose :D Hermès.

1 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 65501: [FASTFAT] Set clean shutdown bit on dismount
by Jérôme Gardou 27 Nov '14

27 Nov '14

Hey Pierre! This flag > + if (DeviceExt->VolumeFcb->Flags & VCB_CLEAR_DIRTY) > + { > + /* Set clean shutdown bit */ > + Status = GetNextCluster(DeviceExt, 1, &eocMark); > + if (NT_SUCCESS(Status)) > + { > + eocMark |= DeviceExt->CleanShutBitMask; > + if (NT_SUCCESS(WriteCluster(DeviceExt, 1, eocMark))) and that one > + DeviceExt->VolumeFcb->Flags &= ~VCB_IS_DIRTY; > + } > + } > + > /* Flush volume & files */ > VfatFlushVolume(DeviceExt, (PVFATFCB)FileObject->FsContext); > > > don't really seem to match. Or is the former a part of a OR combination defining the latter ? Cheers. Jérôme.

2 1

Selling ReactOS CDs
by Hermès BÉLUSCA - MAÏTO 25 Nov '14

25 Nov '14

Hi all ! In the forums some spokesperson of an Indian company offering services related to FOSS wants to add us to their online shop, see http://www.reactos.org/forum/viewtopic.php?f=13 <http://www.reactos.org/forum/viewtopic.php?f=13&t=13780> &t=13780 for more information. What do you think about this? How should we react? Should we make clearer our line of conduct about such kind of things? Cheers, Hermès.

5 5

Re: [ros-dev] [ros-diffs] [pschweitzer] 65462: [NTFS] - In NtfsQueryDirectory(), don't upcase name in dir search pattern, it can conflict with POSIX names. - In CompareFileName(), handle the fact that for Win32 & DOS we do ...
by Thomas Faber 24 Nov '14

24 Nov '14

On 2014-11-23 10:49, pschweitzer(a)svn.reactos.org wrote: > + ASSERT(NT_SUCCESS(RtlUpcaseUnicodeString(&IntFileName, FileName, TRUE))); You need NT_VERIFY here or this will break debug builds.

2 1

Re: [ros-dev] [ros-diffs] [akhaldi] 65249: [SHELL32] * bool => BOOL.
by Timo Kreuzer 24 Nov '14

24 Nov '14

There is a difference between a C++ bool and a win32 BOOL. bool is 8 bit and aware of things like (bool Foo = FlagsValue & 0x80000000); BOOLEAN BooleanFlag = Foo;" with BOOL this would fail. I don't really know whether a BOOL is really the right thing to use here. Am 04.11.2014 21:00, schrieb akhaldi(a)svn.reactos.org: > Author: akhaldi > Date: Tue Nov 4 20:00:09 2014 > New Revision: 65249 > > URL: http://svn.reactos.org/svn/reactos?rev=65249&view=rev > Log: > [SHELL32] > * bool => BOOL. > > Modified: > branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.cpp > branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.h > branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.cpp > branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.h > branches/shell-experiments/dll/win32/shell32/shellfolder.h > > Modified: branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.cpp > URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/she… > ============================================================================== > --- branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.cpp [iso-8859-1] (original) > +++ branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.cpp [iso-8859-1] Tue Nov 4 20:00:09 2014 > @@ -1189,7 +1189,7 @@ > return ret; > } > > -HRESULT WINAPI CDesktopFolder::CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, bool bCopy) > +HRESULT WINAPI CDesktopFolder::CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, BOOL bCopy) > { > CComPtr<IPersistFolder2> ppf2; > WCHAR szSrcPath[MAX_PATH]; > > Modified: branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.h > URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/she… > ============================================================================== > --- branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.h [iso-8859-1] (original) > +++ branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.h [iso-8859-1] Tue Nov 4 20:00:09 2014 > @@ -88,7 +88,7 @@ > virtual HRESULT WINAPI GetUniqueName(LPWSTR pwszName, UINT uLen); > virtual HRESULT WINAPI AddFolder(HWND hwnd, LPCWSTR pwszName, LPITEMIDLIST *ppidlOut); > virtual HRESULT WINAPI DeleteItems(UINT cidl, LPCITEMIDLIST *apidl); > - virtual HRESULT WINAPI CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, bool bCopy); > + virtual HRESULT WINAPI CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, BOOL bCopy); > > DECLARE_REGISTRY_RESOURCEID(IDR_SHELLDESKTOP) > DECLARE_NOT_AGGREGATABLE(CDesktopFolder) > > Modified: branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.cpp > URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/she… > ============================================================================== > --- branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.cpp [iso-8859-1] (original) > +++ branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.cpp [iso-8859-1] Tue Nov 4 20:00:09 2014 > @@ -1030,7 +1030,7 @@ > * copies items to this folder > */ > HRESULT WINAPI CFSFolder::CopyItems(IShellFolder * pSFFrom, UINT cidl, > - LPCITEMIDLIST * apidl, bool bCopy) > + LPCITEMIDLIST * apidl, BOOL bCopy) > { > CComPtr<IPersistFolder2> ppf2 = NULL; > WCHAR szSrcPath[MAX_PATH]; > > Modified: branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.h > URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/she… > ============================================================================== > --- branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.h [iso-8859-1] (original) > +++ branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.h [iso-8859-1] Tue Nov 4 20:00:09 2014 > @@ -102,7 +102,7 @@ > virtual HRESULT WINAPI GetUniqueName(LPWSTR pwszName, UINT uLen); > virtual HRESULT WINAPI AddFolder(HWND hwnd, LPCWSTR pwszName, LPITEMIDLIST *ppidlOut); > virtual HRESULT WINAPI DeleteItems(UINT cidl, LPCITEMIDLIST *apidl); > - virtual HRESULT WINAPI CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, bool bCopy); > + virtual HRESULT WINAPI CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, BOOL bCopy); > > DECLARE_REGISTRY_RESOURCEID(IDR_SHELLFSFOLDER) > DECLARE_NOT_AGGREGATABLE(CFSFolder) > > Modified: branches/shell-experiments/dll/win32/shell32/shellfolder.h > URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/she… > ============================================================================== > --- branches/shell-experiments/dll/win32/shell32/shellfolder.h [iso-8859-1] (original) > +++ branches/shell-experiments/dll/win32/shell32/shellfolder.h [iso-8859-1] Tue Nov 4 20:00:09 2014 > @@ -42,7 +42,7 @@ > STDMETHOD(GetUniqueName)(THIS_ LPWSTR lpName, UINT uLen) PURE; > STDMETHOD(AddFolder)(THIS_ HWND hwnd, LPCWSTR lpName, LPITEMIDLIST * ppidlOut) PURE; > STDMETHOD(DeleteItems)(THIS_ UINT cidl, LPCITEMIDLIST * apidl) PURE; > - STDMETHOD(CopyItems)(THIS_ IShellFolder * pSFFrom, UINT cidl, LPCITEMIDLIST * apidl, bool bCopy) PURE; > + STDMETHOD(CopyItems)(THIS_ IShellFolder * pSFFrom, UINT cidl, LPCITEMIDLIST * apidl, BOOL bCopy) PURE; > }; > #undef INTERFACE > > > >

9 32

Re: [ros-dev] Replacing unsafe TRUE comparisons (Following Re: bool => BOOL)
by Daniel Reimer 23 Nov '14

23 Nov '14

Heheh, who could it be... ^^ It was always a event to watch you two arguing. ^^ Am 23.11.2014 21:57 schrieb Alex Ionescu <ionucu(a)videotron.ca>: > > I'm just going to chime in here and confirm that Timo does indeed own a master's diploma on surviving pissing contests, taught by the greatest master there ever was. > > Best regards, > Alex Ionescu > > On Sat, Nov 22, 2014 at 11:47 AM, Timo Kreuzer <timo.kreuzer(a)web.de> wrote: >> >> Am 22.11.2014 11:39, schrieb Love Nystrom: >>> >>> >>> On 2014-11-21 04.00, Timo Kreuzer wrote: >>>> >>>> Am 20.11.2014 14:18, schrieb Love Nystrom: >>>>> >>>>> >>>>> Well... Actually not exactly the same.. ;) >>>>> "if (f != FALSE)" requires an explicit comparison with a second operand, >>>> >>>> No, it does not. It requries the compiler to generate code that executes the following statement, when f is not 0. >>> >>> >>> I suspect we look at it from two different viewpoints here.. >>> Yours is "C centric" and mine is "object code centric". >>> You talk about what the compiler is required to do, >>> and I talk about what comes out at the end of compilation. >> >> And what comes out at the end of the compilation is what the compiler creates. And the compiler is following the rules of the C standard and the rules of logic. >> You claimed '"if (f != FALSE)" requires an explicit comparison with a second operand,' and that is factually wrong. No matter whether you are looking at it from the compiler perspective or from the perspective of an expressionist painter living in a yellow tree house on the bottom of Lake Tanganyika. >> >>> >>> And.. dear friend.. don't turn this into a pissing contest. >> >> Don't even get me started. I battled the grand master and I survived. >> >> >>> Let's check the egos in with the coat check girl at the entrance. >>> May I ask how old you are? >> >> Are we talking about age or maturity? >> >> We better end this discussion, it's not leading anywhere. And you don't want me to turn into the Grinch and steal your Christmas. >> >> Thanks, >> Timo >> >> >> _______________________________________________ >> Ros-dev mailing list >> Ros-dev(a)reactos.org >> http://www.reactos.org/mailman/listinfo/ros-dev >> >

1 0

Re: [ros-dev] [ros-diffs] [aandrejevic] 65441: [FAST486] Attempt to write the value to the stack before subtracting from the actual ESP register in Fast486StackPush.
by Timo Kreuzer 22 Nov '14

22 Nov '14

Are you sure this is the correct order of execution? The instruction is documented as first lowering the stack pointer, then writing to the new location. If a stack exception occurs, you might have esp off by 4. Am 21.11.2014 10:46, schrieb aandrejevic(a)svn.reactos.org: > Author: aandrejevic > Date: Fri Nov 21 09:46:57 2014 > New Revision: 65441 > > URL: http://svn.reactos.org/svn/reactos?rev=65441&view=rev > Log: > [FAST486] > Attempt to write the value to the stack before subtracting from the actual ESP register > in Fast486StackPush. > > > Modified: > trunk/reactos/lib/fast486/common.inl > > Modified: trunk/reactos/lib/fast486/common.inl > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/common.inl?rev… > ============================================================================== > --- trunk/reactos/lib/fast486/common.inl [iso-8859-1] (original) > +++ trunk/reactos/lib/fast486/common.inl [iso-8859-1] Fri Nov 21 09:46:57 2014 > @@ -317,15 +317,19 @@ > return FALSE; > } > > + /* Store the value in SS:[ESP - 4] */ > + if (!Fast486WriteMemory(State, > + FAST486_REG_SS, > + State->GeneralRegs[FAST486_REG_ESP].Long - sizeof(ULONG), > + &Value, > + sizeof(ULONG))) > + { > + /* Exception occurred */ > + return FALSE; > + } > + > /* Subtract ESP by 4 */ > State->GeneralRegs[FAST486_REG_ESP].Long -= sizeof(ULONG); > - > - /* Store the value in SS:ESP */ > - return Fast486WriteMemory(State, > - FAST486_REG_SS, > - State->GeneralRegs[FAST486_REG_ESP].Long, > - &Value, > - sizeof(ULONG)); > } > else > { > @@ -339,16 +343,22 @@ > return FALSE; > } > > + /* Store the value in SS:[SP - 2] */ > + if (!Fast486WriteMemory(State, > + FAST486_REG_SS, > + LOWORD(State->GeneralRegs[FAST486_REG_ESP].LowWord - sizeof(USHORT)), > + &ShortValue, > + sizeof(USHORT))) > + { > + /* Exception occurred */ > + return FALSE; > + } > + > /* Subtract SP by 2 */ > State->GeneralRegs[FAST486_REG_ESP].LowWord -= sizeof(USHORT); > - > - /* Store the value in SS:SP */ > - return Fast486WriteMemory(State, > - FAST486_REG_SS, > - State->GeneralRegs[FAST486_REG_ESP].LowWord, > - &ShortValue, > - sizeof(USHORT)); > - } > + } > + > + return TRUE; > } > > FORCEINLINE > > >

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev November 2014