Ros-dev November 2014

ros-dev@reactos.org

24 participants
27 discussions

by Giannis Adamopoulos

I don't know how many times I need to send the same link here but let's say that this is the last time: this is a post about wpf but in the middle there is a paragraph about how win32k in windows processes mouse messages: http://blogs.msdn.com/b/dwayneneed/archive/2008/09/08/transparent-windows-i… And here is the important part: Which HWND is the mouse over? The operating system must respond very quickly to mouse movement. Windows uses a dedicated Raw Input Thread (RIT), running in the kernel, to handle the signals from the mouse hardware. The RIT quickly scans over the HWND hierarchy to see which window the mouse is over. Because the system must be responsive, no application code is invoked. For normal windows, the RIT checks the mouse position against the window's rectangle (or region, if one is set). But for layered windows, the RIT looks in the bitmap that specifies the content for the window and checks the effective transparency at that location (which can be affected by the constant opacity setting, the color key setting, or the per-pixel alpha channel). If the pixel is 100% transparent, the RIT skips the window and keeps looking. Once a window has been located, the mouse move flag is set on the thread that owns the window. This will cause the thread to receive a WM_MOUSEMOVE message the next time it calls GetMessage() and there are no other higher-priority messages. Now let me explain why a flag is needed. The window manager needs to coalesce mouse move messages. If the mouse moves over a window and the system registers 10 positions over it, if the window doesn't process messages fast enough the unprocessed positions are dropped and only the last is kept. Even if another message gets between these mouse move messages get lost. That's why the last mouse position is not stored in a message queue but in a field in the thread info. That's how the window manager worked the last 20 years in windows. I'm sick and tired to see readable and correct code to be rewritten by shitty code, that is not readable and has obvious bugs without any reason why the previous implementation was wrong. I just give up. Do whatever you like with this shitty project of yours. I don't care anymore.

10 years, 1 month

Re: [ros-dev] [ros-diffs] [dquintana] 65415: [SHELL32] * Commit the folder location fixes. They are mostly untested due to being unable to boot to desktop, but looking at the contents of the HDD after syssetup runs seems th...

by Thomas Faber

On 2014-11-15 13:34, dquintana(a)svn.reactos.org wrote: > [SHELL32] > * Commit the folder location fixes. They are mostly untested due to being unable to boot to desktop, but looking at the contents of the HDD after syssetup runs seems that the shortcuts are all created in their rightful place. If anyone is able to boot, feel free to test. > > Modified: > branches/shell-experiments/dll/win32/shell32/wine/shellpath.c So which is it; to Wine or not to Wine? If we need to fork this then let's put it in another file? Or at least #ifdef __REACTOS__?

10 years, 1 month

Re: [ros-dev] EPIC: ReactOS@Samsung Galaxy S III mini

by Love Nystrom

On 2014-09-29 19.00, ros-dev-request(a)reactos.org wrote: > w0000t > natively? via an emulator??? > what the.... > \o/ @ Javier I just stumbled by and saw it.. Выглядит безумно, но я установил и запустил ReactOS через обертку Qemu - Limbo ARM 7 на своем Samsung Galaxy S III mini. It looks crazy, but I installed and started the ReactOS through wrapper Qemu - Limbo ARM 7 on your Samsung Galaxy S III mini. // It might be interesting to try wedging an ARM build into the S3 though. I was mulling over the possibility to squeeze it into an Maple Native.. Love

10 years, 1 month

Re: [ros-dev] [ros-diffs] [tkreuzer] 65390: [WIN32SS] if (BooleanValue == TRUE) -> if (!BooleanValue) Patch by Love Nystrom CORE-8799

by Timo Kreuzer

obviously it was meant to be "if (BooleanValue == TRUE) -> if (BooleanValue)" Am 13.11.2014 11:31, schrieb tkreuzer(a)svn.reactos.org: > Author: tkreuzer > Date: Thu Nov 13 10:31:45 2014 > New Revision: 65390 > > URL: http://svn.reactos.org/svn/reactos?rev=65390&view=rev > Log: > [WIN32SS] > if (BooleanValue == TRUE) -> if (!BooleanValue) > Patch by Love Nystrom > CORE-8799 > > Modified: > trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c > trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c > trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c > trunk/reactos/win32ss/drivers/displays/vga/main/enable.c > trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c > trunk/reactos/win32ss/gdi/dib/floodfill.c > trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c > trunk/reactos/win32ss/user/ntuser/hotkey.c > trunk/reactos/win32ss/user/ntuser/message.c > trunk/reactos/win32ss/user/ntuser/msgqueue.c > trunk/reactos/win32ss/user/user32/controls/appswitch.c > trunk/reactos/win32ss/user/user32/misc/desktop.c > trunk/reactos/win32ss/user/user32/misc/winsta.c > trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c > trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c > trunk/reactos/win32ss/user/winsrv/usersrv/register.c > > Modified: trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/f… > ============================================================================== > --- trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -38,7 +38,7 @@ > { > PPDEV ppdev = (PPDEV)dhpdev; > > - if (ppdev->bDDInitialized == TRUE) > + if (ppdev->bDDInitialized) > { > return TRUE; > } > @@ -237,7 +237,7 @@ > { > ppdev->pvmList = pvmList; > > - if ( bDDrawHeap == TRUE) > + if (bDDrawHeap) > { > pvmList->dwFlags = VIDMEM_ISLINEAR ; > pvmList->fpStart = ppdev->ScreenHeight * ppdev->ScreenDelta; > > Modified: trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/f… > ============================================================================== > --- trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -110,7 +110,7 @@ > VOID FASTCALL > IntShowMousePointer(PPDEV ppdev, SURFOBJ *DestSurface) > { > - if (ppdev->PointerAttributes.Enable == TRUE) > + if (ppdev->PointerAttributes.Enable) > { > return; > } > > Modified: trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/f… > ============================================================================== > --- trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -38,7 +38,7 @@ > { > PPDEV ppdev = (PPDEV)dhpdev; > > - if (ppdev->bDDInitialized == TRUE) > + if (ppdev->bDDInitialized) > { > return TRUE; > } > @@ -237,7 +237,7 @@ > { > ppdev->pvmList = pvmList; > > - if ( bDDrawHeap == TRUE) > + if (bDDrawHeap) > { > pvmList->dwFlags = VIDMEM_ISLINEAR ; > pvmList->fpStart = ppdev->ScreenHeight * ppdev->ScreenDelta; > > Modified: trunk/reactos/win32ss/drivers/displays/vga/main/enable.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/v… > ============================================================================== > --- trunk/reactos/win32ss/drivers/displays/vga/main/enable.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/drivers/displays/vga/main/enable.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -302,7 +302,7 @@ > PPDEV ppdev = (PPDEV)DPev; > ULONG returnedDataLength; > > - if(Enable==TRUE) > + if (Enable) > { > /* Reenable our graphics mode */ > if (!InitPointer(ppdev)) > > Modified: trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/v… > ============================================================================== > --- trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -560,7 +560,7 @@ > pb++; > } > > - if (edgePixel == TRUE) > + if (edgePixel) > { > b1 = *pb; > if(b1 != trans) vgaPutPixel(x2, j, b1); > > Modified: trunk/reactos/win32ss/gdi/dib/floodfill.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/dib/floodfill.… > ============================================================================== > --- trunk/reactos/win32ss/gdi/dib/floodfill.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/gdi/dib/floodfill.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -61,7 +61,7 @@ > { > if (RECTL_bPointInRect(DstRect,x,y)) > { > - if (isSurf == TRUE && > + if (isSurf && > DibFunctionsForBitmapFormat[DstSurf->iBitmapFormat].DIB_GetPixel(DstSurf, x, y) != Color) > { > return; > > Modified: trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/misc/gdi… > ============================================================================== > --- trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -1837,7 +1837,7 @@ > { > /* Free it */ > Return = NtGdiDdDeleteDirectDrawObject((HANDLE)pDirectDrawGlobal->hDD); > - if (Return == TRUE) > + if (Return) > { > pDirectDrawGlobal->hDD = 0; > } > @@ -1852,7 +1852,7 @@ > { > /* Delete the object */ > Return = NtGdiDdDeleteDirectDrawObject(ghDirectDraw); > - if (Return == TRUE) > + if (Return) > { > ghDirectDraw = 0; > } > > Modified: trunk/reactos/win32ss/user/ntuser/hotkey.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/hotkey… > ============================================================================== > --- trunk/reactos/win32ss/user/ntuser/hotkey.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/ntuser/hotkey.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -212,7 +212,7 @@ > if (!bIsDown) > { > /* WIN and F12 keys are not hardcoded here. See comments on top of this file. */ > - if (pHotKey->id == IDHK_WINKEY && bWinHotkeyActive == TRUE) > + if (pHotKey->id == IDHK_WINKEY && bWinHotkeyActive) > { > pWnd = ValidateHwndNoErr(InputWindowStation->ShellWindow); > if (pWnd) > > Modified: trunk/reactos/win32ss/user/ntuser/message.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/messag… > ============================================================================== > --- trunk/reactos/win32ss/user/ntuser/message.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/ntuser/message.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -2087,7 +2087,7 @@ > > UserLeave(); > > - if (Ret == TRUE) > + if (Ret) > { > _SEH2_TRY > { > > Modified: trunk/reactos/win32ss/user/ntuser/msgqueue.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/msgque… > ============================================================================== > --- trunk/reactos/win32ss/user/ntuser/msgqueue.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/ntuser/msgqueue.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -805,7 +805,7 @@ > *Message->Result = Result; > } > > - if (Message->HasPackedLParam == TRUE) > + if (Message->HasPackedLParam) > { > if (Message->Msg.lParam) > ExFreePool((PVOID)Message->Msg.lParam); > @@ -887,7 +887,7 @@ > KeSetEvent(SentMessage->CompletionEvent, IO_NO_INCREMENT, FALSE); > } > > - if (SentMessage->HasPackedLParam == TRUE) > + if (SentMessage->HasPackedLParam) > { > if (SentMessage->Msg.lParam) > ExFreePool((PVOID)SentMessage->Msg.lParam); > @@ -1966,7 +1966,7 @@ > KeSetEvent(CurrentSentMessage->CompletionEvent, IO_NO_INCREMENT, FALSE); > } > > - if (CurrentSentMessage->HasPackedLParam == TRUE) > + if (CurrentSentMessage->HasPackedLParam) > { > if (CurrentSentMessage->Msg.lParam) > ExFreePool((PVOID)CurrentSentMessage->Msg.lParam); > @@ -1998,7 +1998,7 @@ > KeSetEvent(CurrentSentMessage->CompletionEvent, IO_NO_INCREMENT, FALSE); > } > > - if (CurrentSentMessage->HasPackedLParam == TRUE) > + if (CurrentSentMessage->HasPackedLParam) > { > if (CurrentSentMessage->Msg.lParam) > ExFreePool((PVOID)CurrentSentMessage->Msg.lParam); > > Modified: trunk/reactos/win32ss/user/user32/controls/appswitch.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/contro… > ============================================================================== > --- trunk/reactos/win32ss/user/user32/controls/appswitch.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/user32/controls/appswitch.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -522,7 +522,7 @@ > return TRUE; > > case WM_SHOWWINDOW: > - if (wParam == TRUE) > + if (wParam) > { > PrepareWindow(); > ati = (PALTTABINFO)GetWindowLongPtrW(hWnd, 0); > > Modified: trunk/reactos/win32ss/user/user32/misc/desktop.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/misc/d… > ============================================================================== > --- trunk/reactos/win32ss/user/user32/misc/desktop.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/user32/misc/desktop.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -610,7 +610,7 @@ > GetProcessWindowStation(), > 0); > > - if( fInherit == TRUE ) > + if( fInherit ) > { > ObjectAttributes.Attributes |= OBJ_INHERIT; > } > > Modified: trunk/reactos/win32ss/user/user32/misc/winsta.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/misc/w… > ============================================================================== > --- trunk/reactos/win32ss/user/user32/misc/winsta.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/user32/misc/winsta.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -372,7 +372,7 @@ > hWindowStationsDir, > 0); > > - if( fInherit == TRUE ) > + if( fInherit ) > { > ObjectAttributes.Attributes |= OBJ_INHERIT; > } > > Modified: trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/consrv… > ============================================================================== > --- trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -1784,7 +1784,7 @@ > static VOID > Copy(PGUI_CONSOLE_DATA GuiData) > { > - if (OpenClipboard(GuiData->hWindow) == TRUE) > + if (OpenClipboard(GuiData->hWindow)) > { > PCONSOLE_SCREEN_BUFFER Buffer = GuiData->ActiveBuffer; > > @@ -1814,7 +1814,7 @@ > static VOID > Paste(PGUI_CONSOLE_DATA GuiData) > { > - if (OpenClipboard(GuiData->hWindow) == TRUE) > + if (OpenClipboard(GuiData->hWindow)) > { > PCONSOLE_SCREEN_BUFFER Buffer = GuiData->ActiveBuffer; > > > Modified: trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/consrv… > ============================================================================== > --- trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -1336,7 +1336,7 @@ > static VOID > GuiConsoleCopy(PGUI_CONSOLE_DATA GuiData) > { > - if (OpenClipboard(GuiData->hWindow) == TRUE) > + if (OpenClipboard(GuiData->hWindow)) > { > PCONSOLE Console = GuiData->Console; > PCONSOLE_SCREEN_BUFFER Buffer = ConDrvGetActiveScreenBuffer(Console); > @@ -1364,7 +1364,7 @@ > static VOID > GuiConsolePaste(PGUI_CONSOLE_DATA GuiData) > { > - if (OpenClipboard(GuiData->hWindow) == TRUE) > + if (OpenClipboard(GuiData->hWindow)) > { > PCONSOLE Console = GuiData->Console; > PCONSOLE_SCREEN_BUFFER Buffer = ConDrvGetActiveScreenBuffer(Console); > > Modified: trunk/reactos/win32ss/user/winsrv/usersrv/register.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/usersr… > ============================================================================== > --- trunk/reactos/win32ss/user/winsrv/usersrv/register.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/winsrv/usersrv/register.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -53,7 +53,7 @@ > { > PUSER_REGISTER_SERVICES_PROCESS RegisterServicesProcessRequest = &((PUSER_API_MESSAGE)ApiMessage)->Data.RegisterServicesProcessRequest; > > - if (ServicesProcessIdValid == TRUE) > + if (ServicesProcessIdValid) > { > /* Only accept a single call */ > return STATUS_INVALID_PARAMETER; > > >

10 years, 1 month

NTFS in ReactOS: heise online article

by Thomas Mueller

I saw an article on heise online (German-language website) http://www.heise.de/newsticker/ on ReactOS liest NTFS http://www.heise.de/newsticker/meldung/ReactOS-liest-NTFS-2442615.html Date is 05.11.2014, meaning just yesterday. I subsequently looked on reactos.org and couldn't find any reference to this article. So far, this is only for reading NTFS on ReactOS; writing ability stil has to be worked on. This is the first article I've seen on this subject: looks like progress. Some ReactOS developers must be familiar with this? Tom

10 years, 1 month

Re: [ros-dev] [ros-diffs] [jgardou] 65388: [TCPIP] - Comment out an optimisation which doesn't work. Reviews of why would be most appreciated.

by Timo Kreuzer

tcpip.c:264 /* Keep this list sorted */ InsertHeadList(ListEntry, &OutInstance->ListEntry); This should probably be InsertTailList(), since you want to insert before the current ListEntry Am 12.11.2014 12:39, schrieb jgardou(a)svn.reactos.org: > Author: jgardou > Date: Wed Nov 12 11:39:13 2014 > New Revision: 65388 > > URL: http://svn.reactos.org/svn/reactos?rev=65388&view=rev > Log: > [TCPIP] > - Comment out an optimisation which doesn't work. > Reviews of why would be most appreciated. > > Modified: > branches/tcpip_revolution/drivers/network/tcpip/entities.c > > Modified: branches/tcpip_revolution/drivers/network/tcpip/entities.c > URL: http://svn.reactos.org/svn/reactos/branches/tcpip_revolution/drivers/networ… > ============================================================================== > --- branches/tcpip_revolution/drivers/network/tcpip/entities.c [iso-8859-1] (original) > +++ branches/tcpip_revolution/drivers/network/tcpip/entities.c [iso-8859-1] Wed Nov 12 11:39:13 2014 > @@ -309,9 +309,11 @@ > return STATUS_SUCCESS; > } > > +#if 0 > /* The list is sorted, so we can cut the loop a bit */ > if (ID.tei_instance < Instance->InstanceId.tei_instance) > break; > +#endif > > ListEntry = ListEntry->Flink; > } > > >

10 years, 1 month

Re: [ros-dev] [ros-diffs] [spetreolle] 65378: [ADVAPI_WINETEST] Make peace^W tests, not war.☮ Wave a hello to sysreg so that it doesn't kill us. ROSTESTS-56

by Thomas Faber

Hmm, my thought behind disabling this was more that this one test doesn't justify increasing our whole test run time by 10%. On 2014-11-11 11:12, spetreolle(a)svn.reactos.org wrote: > Author: spetreolle > Date: Tue Nov 11 16:12:14 2014 > New Revision: 65378 > > URL: http://svn.reactos.org/svn/reactos?rev=65378&view=rev > Log: > [ADVAPI_WINETEST] > Make peace^W tests, not war.☮ > Wave a hello to sysreg so that it doesn't kill us. > ROSTESTS-56 > > Modified: > trunk/rostests/winetests/advapi32/service.c > > Modified: trunk/rostests/winetests/advapi32/service.c > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/advapi32/servic… > ============================================================================== > --- trunk/rostests/winetests/advapi32/service.c [iso-8859-1] (original) > +++ trunk/rostests/winetests/advapi32/service.c [iso-8859-1] Tue Nov 11 16:12:14 2014 > @@ -2166,6 +2166,9 @@ > DWORD le1, le2; > SERVICE_STATUS status; > > +#ifdef __REACTOS__ > + fprintf(stdout, "ROSTESTS-56: Hello sysreg, I am awake\n"); > +#endif > ret = StartServiceA(svc_handle, 0, NULL); > le1 = GetLastError(); > ok(!ret, "%s: StartServiceA() should have failed\n", name); > @@ -2260,12 +2263,6 @@ > * insanely long timeout: 120s. So skip the rest of the tests. > */ > win_skip("Skip some service start/stop tests on NT4\n"); > - goto cleanup; > - } > - > - if (!winetest_interactive) > - { > - skip("ROSTESTS-56: Skipping service start timeout tests!\n"); > goto cleanup; > } >

10 years, 1 month

Re: [ros-dev] [ros-diffs] [pschweitzer] 65352: [NTOSKRNL] So... Because actual ReactOS mood is to worship hacks instead of looking for proper fixes to have decent behavior: reenable the IopParseDevice hack. But, so far, onl...

by Alex Ionescu

Let me make a simple arrogant comment: Don't try to fix hacks that I spent years trying to fix (and failed). They just can't be fixed :P Best regards, Alex Ionescu On Mon, Nov 10, 2014 at 1:45 AM, <pschweitzer(a)svn.reactos.org> wrote: > Author: pschweitzer > Date: Mon Nov 10 09:45:43 2014 > New Revision: 65352 > > URL: http://svn.reactos.org/svn/reactos?rev=65352&view=rev > Log: > [NTOSKRNL] > So... Because actual ReactOS mood is to worship hacks instead of looking > for proper fixes to have decent behavior: reenable the IopParseDevice hack. > > But, so far, only reenable it for the 1st stage: the most intensive > storage stack stage (unless you start playing with partitions & formating > in 3rd stage). > > CORE-8732 #resolve #comment Bug is now properly hidden with r65352 > > Modified: > trunk/reactos/ntoskrnl/io/iomgr/file.c > > Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r… > > ============================================================================== > --- trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] Mon Nov 10 > 09:45:43 2014 > @@ -404,6 +404,27 @@ > /* Check if we can simply use a dummy file */ > UseDummyFile = ((OpenPacket->QueryOnly) || (OpenPacket->DeleteOnly)); > > + /* FIXME: Small hack still exists, have to check why... > + * This is triggered multiple times by usetup and then once per boot. > + */ > + if (ExpInTextModeSetup && > + !(DirectOpen) && > + !(RemainingName->Length) && > + !(OpenPacket->RelatedFileObject) && > + ((wcsstr(CompleteName->Buffer, L"Harddisk")) || > + (wcsstr(CompleteName->Buffer, L"Floppy"))) && > + !(UseDummyFile)) > + { > + DPRINT1("Using IopParseDevice() hack. Requested invalid > attributes: %lx\n", > + DesiredAccess & ~(SYNCHRONIZE | > + FILE_READ_ATTRIBUTES | > + READ_CONTROL | > + ACCESS_SYSTEM_SECURITY | > + WRITE_OWNER | > + WRITE_DAC)); > + DirectOpen = TRUE; > + } > + > /* Check if this is a direct open */ > if (!(RemainingName->Length) && > !(OpenPacket->RelatedFileObject) && > > >

10 years, 1 month

Re: [ros-dev] [ros-diffs] [pschweitzer] 65367: [PARTTEST] Add a dummy application that will open first disk and check first sector for MBR and then will open first partition to check for something known (& not MBR)

by Michael Fritscher

Hi, > + if (Sector->BytesPerSector * Sector->SectorsPerCluster > 32 * 1024) > + { > + return FALSE; > + } FAT supports cluster sizes until 64KB ;-) At least the WinNT series can work with them. Best regards, Michael Fritscher

10 years, 1 month

by Aleksey Bragin

Thank you for working on this hack (partial) removal! After all, having it only in the 1st stage is a win over having it enabled all the time. Regards, Aleksey On 10.11.2014 12:45, pschweitzer(a)svn.reactos.org wrote: > Author: pschweitzer > Date: Mon Nov 10 09:45:43 2014 > New Revision: 65352 > > URL: http://svn.reactos.org/svn/reactos?rev=65352&view=rev > Log: > [NTOSKRNL] > So... Because actual ReactOS mood is to worship hacks instead of looking for proper fixes to have decent behavior: reenable the IopParseDevice hack. > > But, so far, only reenable it for the 1st stage: the most intensive storage stack stage (unless you start playing with partitions & formating in 3rd stage). > > CORE-8732 #resolve #comment Bug is now properly hidden with r65352 > > Modified: > trunk/reactos/ntoskrnl/io/iomgr/file.c > > Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r… > ============================================================================== > --- trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] Mon Nov 10 09:45:43 2014 > @@ -404,6 +404,27 @@ > /* Check if we can simply use a dummy file */ > UseDummyFile = ((OpenPacket->QueryOnly) || (OpenPacket->DeleteOnly)); > > + /* FIXME: Small hack still exists, have to check why... > + * This is triggered multiple times by usetup and then once per boot. > + */ > + if (ExpInTextModeSetup && > + !(DirectOpen) && > + !(RemainingName->Length) && > + !(OpenPacket->RelatedFileObject) && > + ((wcsstr(CompleteName->Buffer, L"Harddisk")) || > + (wcsstr(CompleteName->Buffer, L"Floppy"))) && > + !(UseDummyFile)) > + { > + DPRINT1("Using IopParseDevice() hack. Requested invalid attributes: %lx\n", > + DesiredAccess & ~(SYNCHRONIZE | > + FILE_READ_ATTRIBUTES | > + READ_CONTROL | > + ACCESS_SYSTEM_SECURITY | > + WRITE_OWNER | > + WRITE_DAC)); > + DirectOpen = TRUE; > + } > + > /* Check if this is a direct open */ > if (!(RemainingName->Length) && > !(OpenPacket->RelatedFileObject) && > >

10 years, 1 month

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev November 2014