Ros-dev December 2014

ros-dev@reactos.org

16 participants
16 discussions

by Colin Finck

Hi all, Today, the motherboard in our Fezile server has finally failed after many hick-ups over the year. This causes an outage for the following services: * doxygen.reactos.org * cppcheck.reactos.org * VMware Player Test slave * VMware Player Patchbot As this is not the first time we struggle with such problems, iso.reactos.org is routed to a different server right now and not affected. We have already ordered replacement hardware for this system and hope to be able to get it back to a working state soon. Even if this machine is from 2007, we have decided to revive it with replacement parts instead of going for a brand-new one as this is much cheaper and quicker to realize. Also there is a huge pile of replacement hardware available. Sorry for the inconveniences! Cheers, Colin

9 years, 8 months

Installing ReactOS to a folder

by João Jerónimo

Hello, Is there a build command to install ReactOS to a folder. Something equivalent to "make install" of good old RBuild days? I used to install ReactOS on real hardware this way, because it allowed me to have more control over the install process (aka control it completely). Thanks, João Jerónimo

10 years

Re: [ros-dev] [ros-diffs] [pschweitzer] 65856: [NTOSKRNL] - Implement IopGetDeviceAttachmentBase() which allows getting the base device of the device stack given any device object in it - Implement IopGetDevicePDO() which r...

by Thomas Faber

On 2014-12-28 11:05, pschweitzer(a)svn.reactos.org wrote: > +extern ERESOURCE IopSecurityResource; This resource is only ever acquired shared, meaning it doesn't provide any mutual exclusion at all. Is that intentional?

10 years, 1 month

Re: [ros-dev] [ros-diffs] [hbelusca] 65449: [KERNEL32][CONSRV] - Remove the USE_CONSOLE_INIT_HANDLES define since now we "support" the console initialization events. - The events in the CONSOLE_START_INFO structure are cons...

by Thomas Faber

On 2014-11-22 23:13, hbelusca(a)svn.reactos.org wrote: > + Status = NtCreateEvent(&Console->InputBuffer.ActiveEvent, EVENT_ALL_ACCESS, > + &ObjectAttributes, NotificationEvent, FALSE); > + if (!NT_SUCCESS(Status)) > + { > + return STATUS_UNSUCCESSFUL; > + // return Status; > + } This was a while ago, but I'm curious: what's the point of this? Avoiding STATUS_UNSUCCESSFUL is usually a good thing.

10 years, 1 month

Re: [ros-dev] [ros-diffs] [jimtabor] 65815: [NtUser] - Crash while in recursion through hook calls. Move fast calls to api. Placed safe guards for removing message queue structures. Lock threads while calling hooks. Just ad...

by Thomas Faber

On 2014-12-23 20:05, jimtabor(a)svn.reactos.org wrote: > @@ -732,6 +732,7 @@ > return NULL; > } > > + RtlZeroMemory(Message, sizeof(Message)); > RtlMoveMemory(&Message->Msg, Msg, sizeof(MSG)); > > return Message; You mean sizeof(*Message)

10 years, 1 month

Re: [ros-dev] [ros-diffs] [gadamopoulos] 65766: [COMCTL32] * Do not add two additional pixels at the top margin of the toolbar. This is the behaviour of comctl32 v6 and our explorer depends on that to appear properly. We do...

by Alex Ionescu

Isn't the correct solution to use SxS with an activation context? Best regards, Alex Ionescu On Sun, Dec 21, 2014 at 1:49 AM, <gadamopoulos(a)svn.reactos.org> wrote: > Author: gadamopoulos > Date: Sat Dec 20 16:49:31 2014 > New Revision: 65766 > > URL: http://svn.reactos.org/svn/reactos?rev=65766&view=rev > Log: > [COMCTL32] > * Do not add two additional pixels at the top margin of the toolbar. This > is the behaviour of comctl32 v6 and our explorer depends on that to appear > properly. We don't have a proper solution for these differences in behavior > and since we already opt to use the v6 behavior I think it is fine. > > CORE-5483 #resolve #comment Committed a slightly different version of the > patch, thanks. > > Modified: > trunk/reactos/dll/win32/comctl32/toolbar.c > > Modified: trunk/reactos/dll/win32/comctl32/toolbar.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/toolbar… > > ============================================================================== > --- trunk/reactos/dll/win32/comctl32/toolbar.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/comctl32/toolbar.c [iso-8859-1] Sat Dec 20 > 16:49:31 2014 > @@ -244,7 +244,12 @@ > > static inline int default_top_margin(const TOOLBAR_INFO *infoPtr) > { > +#if 0 > return (infoPtr->dwStyle & TBSTYLE_FLAT ? 0 : TOP_BORDER); > +#else > + /* This is the behaviour in comctl32 v6 */ > + return 0; > +#endif > } > > static inline BOOL TOOLBAR_HasDropDownArrows(DWORD exStyle) > > >

10 years, 1 month

by David Quintana

Ideally, we'd fork comctl32 into two libraries like windows does, but that would probably mean we'd have to fork from wine, moving the maintenance effort to our side. That's why we did not do it yet. Sent from my Windows Phone ------------------------------ From: Alex Ionescu Sent: 21/12/2014 09:05 To: ReactOS Development List Cc: Linda Wang; Filip Subject: Re: [ros-dev] [ros-diffs] [gadamopoulos] 65766: [COMCTL32] * Do not add two additional pixels at the top margin of the toolbar. This is the behaviour of comctl32 v6 and our explorer depends on that to appear properly. We do... Isn't the correct solution to use SxS with an activation context? Best regards, Alex Ionescu On Sun, Dec 21, 2014 at 1:49 AM, <gadamopoulos(a)svn.reactos.org> wrote: > Author: gadamopoulos > Date: Sat Dec 20 16:49:31 2014 > New Revision: 65766 > > URL: http://svn.reactos.org/svn/reactos?rev=65766&view=rev > Log: > [COMCTL32] > * Do not add two additional pixels at the top margin of the toolbar. This > is the behaviour of comctl32 v6 and our explorer depends on that to appear > properly. We don't have a proper solution for these differences in behavior > and since we already opt to use the v6 behavior I think it is fine. > > CORE-5483 #resolve #comment Committed a slightly different version of the > patch, thanks. > > Modified: > trunk/reactos/dll/win32/comctl32/toolbar.c > > Modified: trunk/reactos/dll/win32/comctl32/toolbar.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/toolbar… > > ============================================================================== > --- trunk/reactos/dll/win32/comctl32/toolbar.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/comctl32/toolbar.c [iso-8859-1] Sat Dec 20 > 16:49:31 2014 > @@ -244,7 +244,12 @@ > > static inline int default_top_margin(const TOOLBAR_INFO *infoPtr) > { > +#if 0 > return (infoPtr->dwStyle & TBSTYLE_FLAT ? 0 : TOP_BORDER); > +#else > + /* This is the behaviour in comctl32 v6 */ > + return 0; > +#endif > } > > static inline BOOL TOOLBAR_HasDropDownArrows(DWORD exStyle) > > >

10 years, 1 month

Status Meeting

by Aleksey Bragin

Hey, since we skipped the meeting this week, I propose we do make a joint November-December meeting somewhere in the middle of December. (as we did in the previous year too). How about 18th of December? Regards, Aleksey Bragin

10 years, 1 month

Re: [ros-dev] [ros-diffs] [akhaldi] 65617: [USER32] We're not using any debugging routines here.

by Timo Kreuzer

Honestly, I don't see any point in these modifications. The next time someone wants to use these debug routines, he will need to add it back. Or he will start using DPRINT stuff again. I'd prefer to have this in all files! Am 12.12.2014 14:23, schrieb akhaldi(a)svn.reactos.org: > Author: akhaldi > Date: Fri Dec 12 13:23:45 2014 > New Revision: 65617 > > URL: http://svn.reactos.org/svn/reactos?rev=65617&view=rev > Log: > [USER32] We're not using any debugging routines here. > > Modified: > trunk/reactos/win32ss/user/user32/misc/rtlstr.c > > Modified: trunk/reactos/win32ss/user/user32/misc/rtlstr.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/misc/r… > ============================================================================== > --- trunk/reactos/win32ss/user/user32/misc/rtlstr.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/user32/misc/rtlstr.c [iso-8859-1] Fri Dec 12 13:23:45 2014 > @@ -10,10 +10,6 @@ > /* INCLUDES ******************************************************************/ > > #include <user32.h> > - > -#include <wine/debug.h> > - > -WINE_DEFAULT_DEBUG_CHANNEL(user32); > > /* FUNCTIONS *****************************************************************/ > VOID > > >

10 years, 1 month

Server downtime tomorrow (Monday)

by Colin Finck

Hi all, Due to an OS upgrade on one of our VMs, the following services will temporarily be down tomorrow (Monday): * SVN * BuildBot Buildmaster * Git Mirror * Secondary nameserver * File server at svn.reactos.org I'll try to get this done as fast as possible, so that the downtime will be reduced to a minimum. Sorry for the inconveniences! Cheers, Colin

10 years, 1 month

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev December 2014