Ros-dev March 2014

ros-dev@reactos.org

18 participants
21 discussions

Thoughts on Kickstarter
by Ólafur Arason 17 Mar '14

17 Mar '14

Hi, I've been following the project for years and I've even used explorer implementation on Windows. I also went to the Montreal event. I'm a linux user so I won't be a full time user any time soon. What I think would make a really good Kickstarter, having watched the Thorium Core progress: Developers Delight: What ReactOS or Thorium D has going for it is fully debugable and fundamental understanding of how Windows works. Microsoft has Visual Studio Online but it's pretty bad, at least at the moment it's a mess to set up. Having a way to run your MinGW-w64 projects, possible compile them. Having support for Clang msvc implementation. And last and not the least is the Visual Studio, which of course is the hardest. Even without that it's going to be really solid. An extra plus is being able to make Windows Embedded development stack running, because Trimble are really tied to that. Also Delphi and what ever other development you can think of. Having git support with CI type workflow is going to be great and with kernel level debug reports what could be better. The MingGW-w64 is going to great for all the open source software developers that need something to develop windows software without touching windows. You should talk with OpenShot they were having problems with that kind of development. This is going to be a double benefit for you guys, not only will it provide you with information about what people are using and what bugs are in your system but also provide a lot of foss software on your platform. Embedded dreams: Now that XP is through people need an embedded version, Windows Embedded isn't it, because it has a really weird api. Vista isn't really there or 7 so, where is your chance. Banks are paying Microsoft to extend XP for their ATMs but not every one can afford it. Enter Thorium E, for all those kiosks and POS. You have greater control so you can build a kit for Embedded user where they decide what's going to be included and what comes up, like not having a screen saver, virus software, IE, only allowing one or two exe files to run and only certain dlls. This would also be perfect to make single use virtual images with only one program running. If you need any help with making the video or with the campaign I would love to help. Regards, Olaf

1 0

[CORE-7969] A week later
by Minas Abrahamyan 15 Mar '14

15 Mar '14

Hi developers, Passed a week after I provided a ready for review and apply patch, a simplest solution for simplest bug. Could anyone review, test, and apply it? https://jira.reactos.org/browse/CORE-7969 Thanks

2 1

ReactOS needs to be self-hostable!
by Hermès BÉLUSCA - MAÏTO 15 Mar '14

15 Mar '14

Hi all ! ReactOS severely needs to be self-hostable for many reasons, one of it because it could allow people who only have Linux to be able to program / debug ReactOS with Windows tools (e.g. we have some people here and there complaining that they cannot use powerful debugging programs for debugging ReactOS (e.g. WinDbg and so on with MSVC builds of ReactOS) and therefore restrain themselves in using the Goode Olde GCC + DPRINT method, because they are running only on Linux). Something more personal is that I really want to program ReactOS on itself (in a VM) when it becomes self-hostable. But there are *only* few steps remaining before ReactOS can really be in such situation !! Ive already tested RosBE on it and I was able to download and configure a build. But there *are still* problems. Here is my setup on a VM: main HDD of letter drive C: with ReactOS, second HDD of letter drive D: with ROS source code in D:\rossrc, third HDD of letter drive E: with build output files in E:\rosbuild . After having successfully configured a build in the usual way (E:\rosbuild> D:\rossrc\configure.cmd), I first tried to compile the host-tools (cd host-tools && ninja). The first thing that Ive noticed is that doing so retriggered a configure, then the compilation as wanted. I retried again, and again it reconfigured the build before actually rebuilding the host-tools. The same phenomenon appears then when trying to build ReactOS proper. After analyzing produced files by the configuration step and comparing with a clean build on windows 2k3, it became clear that few files were missing, because obviously not generated: E:\rosbuild\host-tools\CMakeFiles\2.8.10.2-ReactOS\CMakeCCompiler.cmake and CMakeCXXCompiler.cmake . The other .cmake files that should also be present here (CMakeRCCompiler.cmake and CMakeSystem.cmake) as well as two .bin files and two subdirectories where present (and contain the same things). I was suggesting it might be a problem with the command-line interpreter, so I changed our cmd.exe with the one of windows 2000 (not win2k3, because the latter makes extra calls to some security APIs of advapi32 not implemented on ReactOS before running .bat / .cmd files, and it fails), but nothing changed, the files were not still present. After having enabled extra debug output of cmake (that is called when configuring a build) by adding the flags --debug-output --trace (without quotes) in the cmake calls in configure.cmd (and after redirecting console stdout + stderr to a file when retrigerring a clean configuration), doing that on ReactOS *and* on win2k3 for comparison purposes, I saw that, at some point, some cmake flags concerning compiler recognition (à la: CMAKE_GCC_EXISTS for example) werent set to TRUE or FALSE, but were kept empty. So Im wondering whether it is actually some issue, either concerning our C runtime library (e.g. some called sprintf-like function fails or whatever) is buggy and something fails, OR, something file-system related. Concerning file-system, you know that we have LOTS of kernel32:file winetests failing, about problems for deleting files, recreating (or just creating) them, and so on Maybe for some reason cmake fails to create those CMake(C/CXX)Compiler.cmake files for the same reason one of the kernel32:file tests fail ? I dont know, this previous point being speculative since I didnt test anything regarding that. Therefore it would be very nice *to see you all* trying to uncover where this bug comes from so that you can *finally* declare ReactOS self-hostable before, maybe, the next release !! Cheers, Hermès

2 2

Re: [ros-dev] [ros-diffs] [fireball] 62477: [NTOS] - Remove unneeded macro by David Welch in 2002 and me in 2003.
by Timo Kreuzer 11 Mar '14

11 Mar '14

Good sart, but I'm going to outperform this cleanup approach a bit... ;-) Am 11.03.2014 19:46, schrieb fireball(a)svn.reactos.org: > Author: fireball > Date: Tue Mar 11 18:46:32 2014 > New Revision: 62477 > > URL: http://svn.reactos.org/svn/reactos?rev=62477&view=rev > Log: > [NTOS] > - Remove unneeded macro by David Welch in 2002 and me in 2003. > > Modified: > trunk/reactos/ntoskrnl/mm/i386/page.c > > Modified: trunk/reactos/ntoskrnl/mm/i386/page.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/i386/page.c?re… > ============================================================================== > --- trunk/reactos/ntoskrnl/mm/i386/page.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/i386/page.c [iso-8859-1] Tue Mar 11 18:46:32 2014 > @@ -40,22 +40,10 @@ > #define PA_ACCESSED (1 << PA_BIT_ACCESSED) > #define PA_GLOBAL (1 << PA_BIT_GLOBAL) > > -#define HYPERSPACE (0xc0400000) > -#define IS_HYPERSPACE(v) (((ULONG)(v) >= HYPERSPACE && (ULONG)(v) < HYPERSPACE + 0x400000)) > +#define IS_HYPERSPACE(v) (((ULONG)(v) >= HYPER_SPACE && (ULONG)(v) <= HYPER_SPACE_END)) > > #define PTE_TO_PFN(X) ((X) >> PAGE_SHIFT) > #define PFN_TO_PTE(X) ((X) << PAGE_SHIFT) > - > -#if defined(__GNUC__) > -#define PTE_TO_PAGE(X) ((LARGE_INTEGER)(LONGLONG)(PAGE_MASK(X))) > -#else > -__inline LARGE_INTEGER PTE_TO_PAGE(ULONG npage) > -{ > - LARGE_INTEGER dummy; > - dummy.QuadPart = (LONGLONG)(PAGE_MASK(npage)); > - return dummy; > -} > -#endif > > const > ULONG > > >

1 0

Valve has publushed Direct3D -> OpenGL translation layer
by Alexander Rechitskiy 11 Mar '14

11 Mar '14

Valve has publushed Direct3D -> OpenGL translation layer with BSD like license https://github.com/ValveSoftware/ToGL Taken directly from the DOTA2 source tree; supports: Limited subset of Direct3D 9.0c Bytecode-level HLSL -> GLSL translator Some SM3 support: Multiple Render Targets, no Vertex Texture Fetch This most likely won't build by itself and is provided as-is and completely unsupported. Feel free to use it for your reference, incorporate it into your projects or send us modifications. Be wary that some parts are hardcoded to match Source Engine behavior; see CentroidMaskFromName() and ShadowDepthSamplerMaskFromName() in dxabstract.cpp. Please refer to the LICENSE file for more information. -- Best regards Alexander Rechitskiy

1 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 62442: [NTOSKRNL] - Implement FsRtlNotifyFilterReportChange - Implement FsRtlNotifyUpdateBuffer - Implement FsRtlCancelNotify - Implement FsRtlNotifyGetLastPartOffset - Fix implementa...
by Timo Kreuzer 08 Mar '14

08 Mar '14

See inline... Am 07.03.2014 20:33, schrieb pschweitzer(a)svn.reactos.org: > [...] > + /* Update user buffer with the change that occured > + * First copy parent name if any > + * Then copy target name, there's always one > + * And finally, copy stream name if any > + * If these names aren't unicode, then convert first > + */ > + _SEH2_TRY > + { > + OutputBuffer->NextEntryOffset = 0; > + OutputBuffer->Action = Action; > + OutputBuffer->FileNameLength = DataLength - sizeof(FILE_NOTIFY_INFORMATION); > + if (IsUnicode) > + { > + if (ParentName->Length) > + { > + RtlCopyMemory(OutputBuffer->FileName, ParentName->Buffer, ParentName->Length); > + OutputBuffer->FileName[ParentName->Length / sizeof(WCHAR)] = L'\\'; > + AlreadyWritten = ParentName->Length + sizeof(WCHAR); > + } > + RtlCopyMemory(OutputBuffer->FileName + AlreadyWritten, TargetName->Buffer, TargetName->Length); OutputBuffer->FileName is a WCHAR array, AlreadyWritten is a count of bytes, the pointer arithmetic is wrong here. > + if (StreamName) > + { > + AlreadyWritten += TargetName->Length; > + OutputBuffer->FileName[AlreadyWritten / sizeof(WCHAR)] = L':'; > + RtlCopyMemory(OutputBuffer->FileName + AlreadyWritten + sizeof(WCHAR), > + StreamName->Buffer, StreamName->Length); see above > + } > + } > + else > + { > + if (!ParentName->Length) > + { > + ASSERT(StreamName); > + RtlCopyMemory(OutputBuffer->FileName, StreamName->Buffer, StreamName->Length); > + } > + else > + { > + RtlOemToUnicodeN(OutputBuffer->FileName, OutputBuffer->FileNameLength, > + &ResultSize, ParentName->Buffer, > + ParentName->Length); > + OutputBuffer->FileName[ResultSize / sizeof(WCHAR)] = L'\\'; > + AlreadyWritten = ResultSize + sizeof(WCHAR); > + > + RtlOemToUnicodeN(OutputBuffer->FileName + AlreadyWritten, > + OutputBuffer->FileNameLength, &ResultSize, > + TargetName->Buffer, TargetName->Length); see above > + > + if (StreamName) > + { > + AlreadyWritten += ResultSize; > + OutputBuffer->FileName[AlreadyWritten / sizeof(WCHAR)] = L':'; > + RtlOemToUnicodeN(OutputBuffer->FileName + AlreadyWritten + sizeof(WCHAR), > + OutputBuffer->FileNameLength, &ResultSize, > + StreamName->Buffer, StreamName->Length); see above > [...] > + > + /* Look for target name & construct it, if required */ > + if (TargetName.Buffer) > + { > + TargetNameLength = TargetName.Length; The TargetNameLength vatiable is completely redundant > [...] > + > + /* Get the position where we can put our data (aligned!) */ > + AlignedDataLength = ROUND_UP(NotifyChange->DataLength, sizeof(ULONG)); > + /* If it's higher than buffer length, then, bail out without outputing */ > + if (DataLength > NumberOfBytes || AlignedDataLength + DataLength > NumberOfBytes) > + { > + NotifyChange->Flags |= NOTIFY_IMMEDIATELY; > + } > + else > + { > + OutputBuffer = 0; > + FileNotifyInfo = 0; Use NULL

1 0

07 Mar '14

Awesomeness, in its purest art. Le 07.03.2014 20:33, pschweitzer(a)svn.reactos.org a écrit : > Author: pschweitzer > Date: Fri Mar 7 19:33:38 2014 > New Revision: 62442 > > URL: http://svn.reactos.org/svn/reactos?rev=62442&view=rev > Log: > [NTOSKRNL] > - Implement FsRtlNotifyFilterReportChange > - Implement FsRtlNotifyUpdateBuffer > - Implement FsRtlCancelNotify > - Implement FsRtlNotifyGetLastPartOffset > - Fix implementation of FsRtlNotifyFilterChangeDirectory > > This finishes the implementation of file system notifications inside the kernel. > Data are properly returned to the caller on changes. > > CORE-2582 > > Modified: > trunk/reactos/ntoskrnl/fsrtl/notify.c > trunk/reactos/ntoskrnl/include/internal/fsrtl.h > > Modified: trunk/reactos/ntoskrnl/fsrtl/notify.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fsrtl/notify.c?re… > ============================================================================== > --- trunk/reactos/ntoskrnl/fsrtl/notify.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/fsrtl/notify.c [iso-8859-1] Fri Mar 7 19:33:38 2014 > @@ -12,6 +12,55 @@ > #define NDEBUG > #include <debug.h> > > +/* INLINED FUNCTIONS *********************************************************/ > + > +/* > + * @implemented > + */ > +FORCEINLINE > +VOID > +FsRtlNotifyAcquireFastMutex(IN PREAL_NOTIFY_SYNC RealNotifySync) > +{ > + ULONG_PTR CurrentThread = (ULONG_PTR)KeGetCurrentThread(); > + > + /* Only acquire fast mutex if it's not already acquired by the current thread */ > + if (RealNotifySync->OwningThread != CurrentThread) > + { > + ExAcquireFastMutexUnsafe(&(RealNotifySync->FastMutex)); > + RealNotifySync->OwningThread = CurrentThread; > + } > + /* Whatever the case, keep trace of the attempt to acquire fast mutex */ > + RealNotifySync->OwnerCount++; > +} > + > +/* > + * @implemented > + */ > +FORCEINLINE > +VOID > +FsRtlNotifyReleaseFastMutex(IN PREAL_NOTIFY_SYNC RealNotifySync) > +{ > + RealNotifySync->OwnerCount--; > + /* Release the fast mutex only if no other instance needs it */ > + if (!RealNotifySync->OwnerCount) > + { > + ExReleaseFastMutexUnsafe(&(RealNotifySync->FastMutex)); > + RealNotifySync->OwningThread = (ULONG_PTR)0; > + } > +} > + > +#define FsRtlNotifyGetLastPartOffset(FullLen, TargLen, Type, Chr) \ > + for (FullPosition = 0; FullPosition < FullLen; ++FullPosition) \ > + if (((Type)NotifyChange->FullDirectoryName->Buffer)[FullPosition] == Chr) \ > + ++FullNumberOfParts; \ > + for (LastPartOffset = 0; LastPartOffset < TargLen; ++LastPartOffset) { \ > + if ( ((Type)TargetDirectory.Buffer)[LastPartOffset] == Chr) { \ > + ++TargetNumberOfParts; \ > + if (TargetNumberOfParts == FullNumberOfParts) \ > + break; \ > + } \ > + } > + > /* PRIVATE FUNCTIONS *********************************************************/ > > VOID > @@ -22,13 +71,161 @@ > FsRtlNotifySetCancelRoutine(IN PIRP Irp, > IN PNOTIFY_CHANGE NotifyChange OPTIONAL); > > +/* > + * @implemented > + */ > VOID > NTAPI > FsRtlCancelNotify(IN PDEVICE_OBJECT DeviceObject, > IN PIRP Irp) > { > + PVOID Buffer; > + PIRP NotifyIrp; > + ULONG BufferLength; > + PIO_STACK_LOCATION Stack; > + PNOTIFY_CHANGE NotifyChange; > + PREAL_NOTIFY_SYNC RealNotifySync; > + PSECURITY_SUBJECT_CONTEXT SubjectContext = NULL; > + > + /* Get the NOTIFY_CHANGE struct and reset it */ > + NotifyChange = (PNOTIFY_CHANGE)Irp->IoStatus.Information; > + Irp->IoStatus.Information = 0; > + /* Reset the cancel routine */ > + IoSetCancelRoutine(Irp, NULL); > + /* And release lock */ > IoReleaseCancelSpinLock(Irp->CancelIrql); > - UNIMPLEMENTED; > + /* Get REAL_NOTIFY_SYNC struct */ > + RealNotifySync = NotifyChange->NotifySync; > + > + FsRtlNotifyAcquireFastMutex(RealNotifySync); > + > + _SEH2_TRY > + { > + /* Remove the IRP from the notifications list and mark it pending */ > + RemoveEntryList(&(Irp->Tail.Overlay.ListEntry)); > + IoMarkIrpPending(Irp); > + > + /* Now, the tricky part - let's find a buffer big enough to hold the return data */ > + if (NotifyChange->Buffer && NotifyChange->AllocatedBuffer == NULL && > + ((Irp->MdlAddress && MmGetSystemAddressForMdl(Irp->MdlAddress) == NotifyChange->Buffer) || > + NotifyChange->Buffer == Irp->AssociatedIrp.SystemBuffer)) > + { > + /* Assume we didn't find any */ > + Buffer = NULL; > + BufferLength = 0; > + > + /* If we don't have IRPs, check if current buffer is big enough */ > + if (IsListEmpty(&NotifyChange->NotifyIrps)) > + { > + if (NotifyChange->BufferLength >= NotifyChange->DataLength) > + { > + BufferLength = NotifyChange->BufferLength; > + } > + } > + else > + { > + /* Otherwise, try to look at next IRP available */ > + NotifyIrp = CONTAINING_RECORD(NotifyChange->NotifyIrps.Flink, IRP, Tail.Overlay.ListEntry); > + Stack = IoGetCurrentIrpStackLocation(NotifyIrp); > + > + /* If its buffer is big enough, get it */ > + if (Stack->Parameters.NotifyDirectory.Length >= NotifyChange->BufferLength) > + { > + /* Is it MDL? */ > + if (NotifyIrp->AssociatedIrp.SystemBuffer == NULL) > + { > + if (NotifyIrp->MdlAddress != NULL) > + { > + Buffer = MmGetSystemAddressForMdl(NotifyIrp->MdlAddress); > + } > + } > + else > + { > + Buffer = NotifyIrp->AssociatedIrp.MasterIrp; > + } > + > + /* Backup our accepted buffer length */ > + BufferLength = Stack->Parameters.NotifyDirectory.Length; > + if (BufferLength > NotifyChange->BufferLength) > + { > + BufferLength = NotifyChange->BufferLength; > + } > + } > + } > + > + /* At that point, we *may* have a buffer */ > + > + /* If it has null length, then note that we won't use it */ > + if (BufferLength == 0) > + { > + NotifyChange->Flags |= NOTIFY_IMMEDIATELY; > + } > + else > + { > + /* If we have a buffer length, but no buffer then allocate one */ > + if (Buffer == NULL) > + { > + PsChargePoolQuota(NotifyChange->OwningProcess, PagedPool, BufferLength); > + Buffer = ExAllocatePoolWithTag(PagedPool | POOL_RAISE_IF_ALLOCATION_FAILURE, BufferLength, 'NrSF'); > + NotifyChange->AllocatedBuffer = Buffer; > + } > + > + /* Copy data in that buffer */ > + RtlCopyMemory(Buffer, NotifyChange->Buffer, NotifyChange->DataLength); > + NotifyChange->ThisBufferLength = BufferLength; > + NotifyChange->Buffer = Buffer; > + } > + > + /* If we don't have valide buffer, ensure everything is 0-ed out */ > + if (NotifyChange->Flags & NOTIFY_IMMEDIATELY) > + { > + NotifyChange->Buffer = 0; > + NotifyChange->AllocatedBuffer = 0; > + NotifyChange->LastEntry = 0; > + NotifyChange->DataLength = 0; > + NotifyChange->ThisBufferLength = 0; > + } > + } > + > + /* It's now time to complete - data are ready */ > + > + /* Set appropriate status and complete */ > + Irp->IoStatus.Status = STATUS_CANCELLED; > + IofCompleteRequest(Irp, EVENT_INCREMENT); > + > + /* If that notification isn't referenced any longer, drop it */ > + if (!InterlockedDecrement((PLONG)&(NotifyChange->ReferenceCount))) > + { > + /* If it had an allocated buffer, delete */ > + if (NotifyChange->AllocatedBuffer) > + { > + PsReturnProcessPagedPoolQuota(NotifyChange->OwningProcess, NotifyChange->ThisBufferLength); > + ExFreePoolWithTag(NotifyChange->AllocatedBuffer, 'NrSF'); > + } > + > + /* In case of full name, remember subject context for later deletion */ > + if (NotifyChange->FullDirectoryName) > + { > + SubjectContext = NotifyChange->SubjectContext; > + } > + > + /* We mustn't have ANY change left anymore */ > + ASSERT(NotifyChange->NotifyList.Flink == NULL); > + ExFreePoolWithTag(NotifyChange, 0); > + } > + } > + _SEH2_FINALLY > + { > + FsRtlNotifyReleaseFastMutex(RealNotifySync); > + > + /* If the subject security context was captured, release and free it */ > + if (SubjectContext) > + { > + SeReleaseSubjectContext(SubjectContext); > + ExFreePool(SubjectContext); > + } > + } > + _SEH2_END; > } > > /* > @@ -58,6 +255,9 @@ > } > } > > +/* > + *@implemented > + */ > PNOTIFY_CHANGE > FsRtlIsNotifyOnList(IN PLIST_ENTRY NotifyList, > IN PVOID FsContext) > @@ -81,22 +281,6 @@ > } > } > return NULL; > -} > - > -FORCEINLINE > -VOID > -FsRtlNotifyAcquireFastMutex(IN PREAL_NOTIFY_SYNC RealNotifySync) > -{ > - ULONG_PTR CurrentThread = (ULONG_PTR)KeGetCurrentThread(); > - > - /* Only acquire fast mutex if it's not already acquired by the current thread */ > - if (RealNotifySync->OwningThread != CurrentThread) > - { > - ExAcquireFastMutexUnsafe(&(RealNotifySync->FastMutex)); > - RealNotifySync->OwningThread = CurrentThread; > - } > - /* Whatever the case, keep trace of the attempt to acquire fast mutex */ > - RealNotifySync->OwnerCount++; > } > > /* > @@ -216,7 +400,7 @@ > > DataLength = NotifyChange->DataLength; > > - NotifyChange->Flags &= (INVALIDATE_BUFFERS | WATCH_TREE); > + NotifyChange->Flags &= (NOTIFY_IMMEDIATELY | WATCH_TREE); > NotifyChange->DataLength = 0; > NotifyChange->LastEntry = 0; > > @@ -233,19 +417,6 @@ > } > } > > -FORCEINLINE > -VOID > -FsRtlNotifyReleaseFastMutex(IN PREAL_NOTIFY_SYNC RealNotifySync) > -{ > - RealNotifySync->OwnerCount--; > - /* Release the fast mutex only if no other instance needs it */ > - if (!RealNotifySync->OwnerCount) > - { > - ExReleaseFastMutexUnsafe(&(RealNotifySync->FastMutex)); > - RealNotifySync->OwningThread = (ULONG_PTR)0; > - } > -} > - > /* > * @implemented > */ > @@ -293,6 +464,91 @@ > > /* Return that we didn't removed cancel routine */ > return FALSE; > +} > + > +/* > + * @implemented > + */ > +BOOLEAN > +FsRtlNotifyUpdateBuffer(OUT PFILE_NOTIFY_INFORMATION OutputBuffer, > + IN ULONG Action, > + IN PSTRING ParentName, > + IN PSTRING TargetName, > + IN PSTRING StreamName, > + IN BOOLEAN IsUnicode, > + IN ULONG DataLength) > +{ > + /* Unless there's an issue with buffers, there's no reason to fail */ > + BOOLEAN Succeed = TRUE; > + ULONG AlreadyWritten = 0, ResultSize; > + > + PAGED_CODE(); > + > + /* Update user buffer with the change that occured > + * First copy parent name if any > + * Then copy target name, there's always one > + * And finally, copy stream name if any > + * If these names aren't unicode, then convert first > + */ > + _SEH2_TRY > + { > + OutputBuffer->NextEntryOffset = 0; > + OutputBuffer->Action = Action; > + OutputBuffer->FileNameLength = DataLength - sizeof(FILE_NOTIFY_INFORMATION); > + if (IsUnicode) > + { > + if (ParentName->Length) > + { > + RtlCopyMemory(OutputBuffer->FileName, ParentName->Buffer, ParentName->Length); > + OutputBuffer->FileName[ParentName->Length / sizeof(WCHAR)] = L'\\'; > + AlreadyWritten = ParentName->Length + sizeof(WCHAR); > + } > + RtlCopyMemory(OutputBuffer->FileName + AlreadyWritten, TargetName->Buffer, TargetName->Length); > + if (StreamName) > + { > + AlreadyWritten += TargetName->Length; > + OutputBuffer->FileName[AlreadyWritten / sizeof(WCHAR)] = L':'; > + RtlCopyMemory(OutputBuffer->FileName + AlreadyWritten + sizeof(WCHAR), > + StreamName->Buffer, StreamName->Length); > + } > + } > + else > + { > + if (!ParentName->Length) > + { > + ASSERT(StreamName); > + RtlCopyMemory(OutputBuffer->FileName, StreamName->Buffer, StreamName->Length); > + } > + else > + { > + RtlOemToUnicodeN(OutputBuffer->FileName, OutputBuffer->FileNameLength, > + &ResultSize, ParentName->Buffer, > + ParentName->Length); > + OutputBuffer->FileName[ResultSize / sizeof(WCHAR)] = L'\\'; > + AlreadyWritten = ResultSize + sizeof(WCHAR); > + > + RtlOemToUnicodeN(OutputBuffer->FileName + AlreadyWritten, > + OutputBuffer->FileNameLength, &ResultSize, > + TargetName->Buffer, TargetName->Length); > + > + if (StreamName) > + { > + AlreadyWritten += ResultSize; > + OutputBuffer->FileName[AlreadyWritten / sizeof(WCHAR)] = L':'; > + RtlOemToUnicodeN(OutputBuffer->FileName + AlreadyWritten + sizeof(WCHAR), > + OutputBuffer->FileNameLength, &ResultSize, > + StreamName->Buffer, StreamName->Length); > + } > + } > + } > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + Succeed = FALSE; > + } > + _SEH2_END; > + > + return Succeed; > } > > /* PUBLIC FUNCTIONS **********************************************************/ > @@ -445,7 +701,7 @@ > > /*++ > * @name FsRtlNotifyFilterChangeDirectory > - * @unimplemented > + * @implemented > * > * FILLME > * > @@ -559,16 +815,16 @@ > NotifyIrp->IoStatus.Status = STATUS_DELETE_PENDING; > IoCompleteRequest(NotifyIrp, EVENT_INCREMENT); > } > - /* Complete if there is directory enumeration and no buffer available any more */ > - if ((NotifyChange->Flags & INVALIDATE_BUFFERS) && (NotifyChange->Flags & ENUMERATE_DIR)) > - { > - NotifyChange->Flags &= ~INVALIDATE_BUFFERS; > + /* Complete now if asked to (and not asked to notify later on) */ > + if ((NotifyChange->Flags & NOTIFY_IMMEDIATELY) && !(NotifyChange->Flags & NOTIFY_LATER)) > + { > + NotifyChange->Flags &= ~NOTIFY_IMMEDIATELY; > IoMarkIrpPending(NotifyIrp); > NotifyIrp->IoStatus.Status = STATUS_NOTIFY_ENUM_DIR; > IoCompleteRequest(NotifyIrp, EVENT_INCREMENT); > } > - /* If no data yet, or directory enumeration, handle */ > - else if (NotifyChange->DataLength == 0 || (NotifyChange->Flags & ENUMERATE_DIR)) > + /* If no data yet, or asked to notify later on, handle */ > + else if (NotifyChange->DataLength == 0 || (NotifyChange->Flags & NOTIFY_LATER)) > { > goto HandleIRP; > } > @@ -612,20 +868,13 @@ > else > { > /* If it can't contain WCHAR, it's ANSI */ > - if (FullDirectoryName->Length < sizeof(WCHAR)) > + if (FullDirectoryName->Length < sizeof(WCHAR) || ((CHAR*)FullDirectoryName->Buffer)[1] != 0) > { > NotifyChange->CharacterSize = sizeof(CHAR); > } > - /* First char is \, so in unicode, right part is 0 > - * whereas in ANSI it contains next char > - */ > - else if (((CHAR*)FullDirectoryName->Buffer)[1] == 0) > + else > { > NotifyChange->CharacterSize = sizeof(WCHAR); > - } > - else > - { > - NotifyChange->CharacterSize = sizeof(CHAR); > } > > /* Now, check is user is willing to watch root */ > @@ -668,7 +917,7 @@ > FsRtlNotifyReleaseFastMutex(RealNotifySync); > > /* If the subject security context was captured and there's no notify */ > - if (SubjectContext && (!NotifyChange || FullDirectoryName)) > + if (SubjectContext && (!NotifyChange || NotifyChange->FullDirectoryName)) > { > SeReleaseSubjectContext(SubjectContext); > ExFreePool(SubjectContext); > @@ -679,7 +928,7 @@ > > /*++ > * @name FsRtlNotifyFilterReportChange > - * @unimplemented > + * @implemented > * > * FILLME > * > @@ -731,7 +980,437 @@ > IN PVOID TargetContext, > IN PVOID FilterContext) > { > - KeBugCheck(FILE_SYSTEM); > + PIRP Irp; > + PVOID OutputBuffer; > + USHORT FullPosition; > + PLIST_ENTRY NextEntry; > + PIO_STACK_LOCATION Stack; > + PNOTIFY_CHANGE NotifyChange; > + PREAL_NOTIFY_SYNC RealNotifySync; > + PFILE_NOTIFY_INFORMATION FileNotifyInfo; > + BOOLEAN IsStream, IsParent, PoolQuotaCharged; > + STRING TargetDirectory, TargetName, ParentName, IntNormalizedParentName; > + ULONG NumberOfBytes, TargetNumberOfParts, FullNumberOfParts, LastPartOffset, ParentNameOffset, ParentNameLength; > + ULONG DataLength, TargetNameLength, AlignedDataLength; > + > + TargetDirectory.Length = 0; > + TargetDirectory.MaximumLength = 0; > + TargetDirectory.Buffer = NULL; > + TargetName.Length = 0; > + TargetName.MaximumLength = 0; > + TargetName.Buffer = NULL; > + ParentName.Length = 0; > + ParentName.MaximumLength = 0; > + ParentName.Buffer = NULL; > + IsStream = FALSE; > + > + PAGED_CODE(); > + > + DPRINT("FsRtlNotifyFilterReportChange(%p, %p, %p, %u, %p, %p, %p, %x, %x, %p, %p)\n", > + NotifySync, NotifyList, FullTargetName, TargetNameOffset, StreamName, NormalizedParentName, > + FilterMatch, Action, TargetContext, FilterContext); > + > + /* We need offset in name */ > + if (!TargetNameOffset && FullTargetName) > + { > + return; > + } > + > + /* Get real structure hidden behind the opaque pointer */ > + RealNotifySync = (PREAL_NOTIFY_SYNC)NotifySync; > + /* Acquire lock - will be released in finally block */ > + FsRtlNotifyAcquireFastMutex(RealNotifySync); > + _SEH2_TRY > + { > + /* Browse all the registered notifications we have */ > + for (NextEntry = NotifyList->Flink; NextEntry != NotifyList; > + NextEntry = NextEntry->Flink) > + { > + /* Try to find an entry matching our change */ > + NotifyChange = CONTAINING_RECORD(NextEntry, NOTIFY_CHANGE, NotifyList); > + if (FullTargetName != NULL) > + { > + ASSERT(NotifyChange->FullDirectoryName != NULL); > + if (!NotifyChange->FullDirectoryName->Length) > + { > + continue; > + } > + > + if (!(FilterMatch & NotifyChange->CompletionFilter)) > + { > + continue; > + } > + > + /* If no normalized name provided, construct it from full target name */ > + if (NormalizedParentName == NULL) > + { > + IntNormalizedParentName.Buffer = FullTargetName->Buffer; > + if (TargetNameOffset != NotifyChange->CharacterSize) > + { > + IntNormalizedParentName.MaximumLength = > + IntNormalizedParentName.Length = TargetNameOffset - NotifyChange->CharacterSize; > + } > + else > + { > + IntNormalizedParentName.MaximumLength = > + IntNormalizedParentName.Length = TargetNameOffset; > + } > + NormalizedParentName = &IntNormalizedParentName; > + } > + > + /* heh? Watched directory bigger than changed file? */ > + if (NormalizedParentName->Length < NotifyChange->FullDirectoryName->Length) > + { > + continue; > + } > + > + /* Same len => parent */ > + if (NormalizedParentName->Length == NotifyChange->FullDirectoryName->Length) > + { > + IsParent = TRUE; > + } > + /* If not, then, we have to be watching the tree, otherwise we don't have to report such changes */ > + else if (!(NotifyChange->Flags & WATCH_TREE)) > + { > + continue; > + } > + /* And finally, we've to check we're properly \-terminated */ > + else > + { > + if (!(NotifyChange->Flags & WATCH_ROOT)) > + { > + if (NotifyChange->CharacterSize == sizeof(CHAR)) > + { > + if (((PSTR)NormalizedParentName->Buffer)[NotifyChange->FullDirectoryName->Length] != '\\') > + { > + continue; > + } > + } > + else > + { > + if (((PWSTR)NormalizedParentName->Buffer)[NotifyChange->FullDirectoryName->Length / sizeof (WCHAR)] != L'\\') > + { > + continue; > + } > + } > + } > + > + IsParent = FALSE; > + } > + > + /* If len matches, then check that both name are equal */ > + if (!RtlEqualMemory(NormalizedParentName->Buffer, NotifyChange->FullDirectoryName->Buffer, > + NotifyChange->FullDirectoryName->Length)) > + { > + continue; > + } > + > + /* Call traverse callback (only if we have to traverse ;-)) */ > + if (!IsParent > + && NotifyChange->TraverseCallback != NULL > + && !NotifyChange->TraverseCallback(NotifyChange->FsContext, > + TargetContext, > + NotifyChange->SubjectContext)) > + { > + continue; > + } > + > + /* And then, filter callback if provided */ > + if (NotifyChange->FilterCallback != NULL > + && FilterContext != NULL > + && !NotifyChange->FilterCallback(NotifyChange->FsContext, FilterContext)) > + { > + continue; > + } > + } > + /* We have a stream! */ > + else > + { > + ASSERT(NotifyChange->FullDirectoryName == NULL); > + if (TargetContext != NotifyChange->SubjectContext) > + { > + continue; > + } > + > + ParentName.Buffer = NULL; > + ParentName.Length = 0; > + IsStream = TRUE; > + IsParent = FALSE; > + } > + > + /* If we don't have to notify immediately, prepare for output */ > + if (!(NotifyChange->Flags & NOTIFY_IMMEDIATELY)) > + { > + /* If we have something to output... */ > + if (NotifyChange->BufferLength) > + { > + /* Get size of the output */ > + NumberOfBytes = 0; > + Irp = NULL; > + if (!NotifyChange->ThisBufferLength) > + { > + if (IsListEmpty(&NotifyChange->NotifyIrps)) > + { > + NumberOfBytes = NotifyChange->BufferLength; > + } > + else > + { > + Irp = CONTAINING_RECORD(NotifyChange->NotifyIrps.Flink, IRP, Tail.Overlay.ListEntry); > + Stack = IoGetCurrentIrpStackLocation(Irp); > + NumberOfBytes = Stack->Parameters.NotifyDirectory.Length; > + } > + } > + else > + { > + NumberOfBytes = NotifyChange->ThisBufferLength; > + } > + > + /* If we're matching parent, we don't care about parent (redundant) */ > + if (IsParent) > + { > + ParentName.Length = 0; > + } > + else > + { > + /* If we don't deal with streams, some more work is required */ > + if (!IsStream) > + { > + if (NotifyChange->Flags & WATCH_ROOT || > + (NormalizedParentName->Buffer != FullTargetName->Buffer)) > + { > + /* Construct TargetDirectory if we don't have it yet */ > + if (TargetDirectory.Buffer == NULL) > + { > + TargetDirectory.Buffer = FullTargetName->Buffer; > + TargetDirectory.Length = TargetNameOffset; > + if (TargetNameOffset != NotifyChange->CharacterSize) > + { > + TargetDirectory.Length = TargetNameOffset - NotifyChange->CharacterSize; > + } > + TargetDirectory.MaximumLength = TargetDirectory.Length; > + } > + /* Now, we start looking for matching parts (unless we watch root) */ > + TargetNumberOfParts = 0; > + if (!(NotifyChange->Flags & WATCH_ROOT)) > + { > + FullNumberOfParts = 1; > + if (NotifyChange->CharacterSize == sizeof(CHAR)) > + { > + FsRtlNotifyGetLastPartOffset(NotifyChange->FullDirectoryName->Length, > + TargetDirectory.Length, PSTR, '\\'); > + } > + else > + { > + FsRtlNotifyGetLastPartOffset(NotifyChange->FullDirectoryName->Length / sizeof(WCHAR), > + TargetDirectory.Length / sizeof(WCHAR), PWSTR, L'\\'); > + LastPartOffset *= NotifyChange->CharacterSize; > + } > + } > + > + /* Then, we can construct proper parent name */ > + ParentNameOffset = NotifyChange->CharacterSize + LastPartOffset; > + ParentName.Buffer = &TargetDirectory.Buffer[ParentNameOffset]; > + ParentNameLength = TargetDirectory.Length; > + } > + else > + { > + /* Construct parent name even for streams */ > + ParentName.Buffer = &NormalizedParentName->Buffer[NotifyChange->FullDirectoryName->Length] + NotifyChange->CharacterSize; > + ParentNameLength = NormalizedParentName->Length - NotifyChange->FullDirectoryName->Length; > + ParentNameOffset = NotifyChange->CharacterSize; > + } > + ParentNameLength -= ParentNameOffset; > + ParentName.Length = ParentNameLength; > + ParentName.MaximumLength = ParentNameLength; > + } > + } > + > + /* Start to count amount of data to write, we've first the structure itself */ > + DataLength = FIELD_OFFSET(FILE_NOTIFY_INFORMATION, FileName); > + > + /* If stream, we'll just append stream name */ > + if (IsStream) > + { > + ASSERT(StreamName != NULL); > + DataLength += StreamName->Length; > + } > + else > + { > + /* If not parent, we've to append parent name */ > + if (!IsParent) > + { > + if (NotifyChange->CharacterSize == sizeof(CHAR)) > + { > + DataLength += RtlOemStringToCountedUnicodeSize(&ParentName); > + } > + else > + { > + DataLength += ParentName.Length; > + } > + DataLength += sizeof(WCHAR); > + } > + > + /* Look for target name & construct it, if required */ > + if (TargetName.Buffer) > + { > + TargetNameLength = TargetName.Length; > + } > + else > + { > + TargetName.Buffer = &FullTargetName->Buffer[TargetNameOffset]; > + TargetNameLength = FullTargetName->Length - TargetNameOffset; > + TargetName.Length = TargetNameLength; > + TargetName.MaximumLength = TargetNameLength; > + } > + > + /* Then, we will append it as well */ > + if (NotifyChange->CharacterSize == sizeof(CHAR)) > + { > + DataLength += RtlOemStringToCountedUnicodeSize(&TargetName); > + } > + else > + { > + DataLength += TargetName.Length; > + } > + > + /* If we also had a stream name, then we can append it as well */ > + if (StreamName != NULL) > + { > + if (NotifyChange->CharacterSize == sizeof(WCHAR)) > + { > + DataLength += StreamName->Length + sizeof(WCHAR); > + } > + else > + { > + DataLength = DataLength + RtlOemStringToCountedUnicodeSize(&TargetName) + sizeof(CHAR); > + } > + } > + } > + > + /* Get the position where we can put our data (aligned!) */ > + AlignedDataLength = ROUND_UP(NotifyChange->DataLength, sizeof(ULONG)); > + /* If it's higher than buffer length, then, bail out without outputing */ > + if (DataLength > NumberOfBytes || AlignedDataLength + DataLength > NumberOfBytes) > + { > + NotifyChange->Flags |= NOTIFY_IMMEDIATELY; > + } > + else > + { > + OutputBuffer = 0; > + FileNotifyInfo = 0; > + /* If we already had a buffer, update last entry position */ > + if (NotifyChange->Buffer != NULL) > + { > + FileNotifyInfo = (PVOID)((ULONG_PTR)NotifyChange->Buffer + NotifyChange->LastEntry); > + FileNotifyInfo->NextEntryOffset = AlignedDataLength - NotifyChange->LastEntry; > + NotifyChange->LastEntry = AlignedDataLength; > + /* And get our output buffer */ > + OutputBuffer = (PVOID)((ULONG_PTR)NotifyChange->Buffer + AlignedDataLength); > + } > + /* If we hadn't buffer, try to find one */ > + else if (Irp != NULL) > + { > + if (Irp->AssociatedIrp.SystemBuffer != NULL) > + { > + OutputBuffer = Irp->AssociatedIrp.SystemBuffer; > + } > + else if (Irp->MdlAddress != NULL) > + { > + OutputBuffer = MmGetSystemAddressForMdl(Irp->MdlAddress); > + } > + > + NotifyChange->Buffer = OutputBuffer; > + NotifyChange->ThisBufferLength = NumberOfBytes; > + } > + > + /* If we couldn't find one, then allocate one */ > + if (NotifyChange->Buffer == NULL) > + { > + PoolQuotaCharged = FALSE; > + _SEH2_TRY > + { > + PsChargePoolQuota(NotifyChange->OwningProcess, PagedPool, NumberOfBytes); > + PoolQuotaCharged = TRUE; > + OutputBuffer = ExAllocatePoolWithTag(PagedPool | POOL_RAISE_IF_ALLOCATION_FAILURE, > + NumberOfBytes, 'NrSF'); > + NotifyChange->Buffer = OutputBuffer; > + NotifyChange->AllocatedBuffer = OutputBuffer; > + } > + /* If something went wrong during allocation, notify immediately instead of outputing */ > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + if (PoolQuotaCharged) > + { > + PsReturnProcessPagedPoolQuota(NotifyChange->OwningProcess, NumberOfBytes); > + } > + NotifyChange->Flags |= NOTIFY_IMMEDIATELY; > + } > + _SEH2_END; > + } > + > + /* Finally, if we have a buffer, fill it in! */ > + if (OutputBuffer != NULL) > + { > + if (FsRtlNotifyUpdateBuffer((FILE_NOTIFY_INFORMATION *)OutputBuffer, > + Action, &ParentName, &TargetName, > + StreamName, NotifyChange->CharacterSize == sizeof(WCHAR), > + DataLength)) > + { > + NotifyChange->DataLength = DataLength + AlignedDataLength; > + } > + /* If it failed, notify immediately */ > + else > + { > + NotifyChange->Flags |= NOTIFY_IMMEDIATELY; > + } > + } > + } > + > + /* If we have to notify right now (something went wrong?) */ > + if (NotifyChange->Flags & NOTIFY_IMMEDIATELY) > + { > + /* Ensure that all our buffers are NULL */ > + if (NotifyChange->Buffer != NULL) > + { > + if (NotifyChange->AllocatedBuffer != NULL) > + { > + PsReturnProcessPagedPoolQuota(NotifyChange->OwningProcess, NotifyChange->ThisBufferLength); > + ExFreePoolWithTag(NotifyChange->AllocatedBuffer, 'NrSF'); > + } > + > + NotifyChange->Buffer = NULL; > + NotifyChange->AllocatedBuffer = NULL; > + NotifyChange->LastEntry = 0; > + NotifyChange->DataLength = 0; > + NotifyChange->ThisBufferLength = 0; > + } > + } > + } > + } > + > + /* If asking for old name in case of a rename, notify later on, > + * so that we can wait for new name. > + * http://msdn.microsoft.com/en-us/library/dn392331.aspx > + */ > + if (Action == FILE_ACTION_RENAMED_OLD_NAME) > + { > + NotifyChange->Flags |= NOTIFY_LATER; > + } > + else > + { > + NotifyChange->Flags &= ~NOTIFY_LATER; > + if (!IsListEmpty(&NotifyChange->NotifyIrps)) > + { > + FsRtlNotifyCompleteIrpList(NotifyChange, STATUS_SUCCESS); > + } > + } > + } > + } > + _SEH2_FINALLY > + { > + FsRtlNotifyReleaseFastMutex(RealNotifySync); > + } > + _SEH2_END; > } > > /*++ > > Modified: trunk/reactos/ntoskrnl/include/internal/fsrtl.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… > ============================================================================== > --- trunk/reactos/ntoskrnl/include/internal/fsrtl.h [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/include/internal/fsrtl.h [iso-8859-1] Fri Mar 7 19:33:38 2014 > @@ -53,9 +53,9 @@ > // Notifications flags > // > #define WATCH_TREE 0x01 > -#define INVALIDATE_BUFFERS 0x02 > +#define NOTIFY_IMMEDIATELY 0x02 > #define CLEANUP_IN_PROCESS 0x04 > -#define ENUMERATE_DIR 0x08 > +#define NOTIFY_LATER 0x08 > #define WATCH_ROOT 0x10 > #define DELETE_IN_PROCESS 0x20 > > >

2 1

NDIS NdisIMRegisterLayeredMiniport
by Maxime Daniel 07 Mar '14

07 Mar '14

Hello, I need to use NDIS NdisIMRegisterLayeredMiniport functions to provide a virtual ethernet card. I read the documentation on MSDN and it seems that this functions is required to build an adapter without physical link (eg, with no hardware IRQ). The problem is that this function is not implemented yet on reactos (svn rev. 62083). Is someone can tell me if it's implementable or if there is an alternative to build a virtual ethernet adapter with current implementation of NDIS. Thanks. -- Daniel Maxime Linux version 3.6.9-maxux64 (emy) (gcc version 4.7.3 (Gentoo 4.7.3-r1 p1.4, pie-0.5.5) ) #3 SMP PREEMPT Wed Feb 19 16:40:22 CET 2014 14:02:53 up 1 day, 21:38, 1 user, load average: 0.17, 0.26, 0.23

2 2

Re: [ros-dev] [ros-diffs] [hbelusca] 62419: [APITESTS:kernel32] Be more specific about which last error we expect.
by Timo Kreuzer 05 Mar '14

05 Mar '14

IIRC, we have something like ok_lasterror() Am 05.03.2014 02:53, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Wed Mar 5 01:53:46 2014 > New Revision: 62419 > > URL: http://svn.reactos.org/svn/reactos?rev=62419&view=rev > Log: > [APITESTS:kernel32] > Be more specific about which last error we expect. > > Modified: > trunk/rostests/apitests/kernel32/dosdev.c > > Modified: trunk/rostests/apitests/kernel32/dosdev.c > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/kernel32/dosdev.… > ============================================================================== > --- trunk/rostests/apitests/kernel32/dosdev.c [iso-8859-1] (original) > +++ trunk/rostests/apitests/kernel32/dosdev.c [iso-8859-1] Wed Mar 5 01:53:46 2014 > @@ -137,7 +137,7 @@ > ok(Result, "Failed to subst drive\n"); > DriveType1 = GetDriveTypeA(SUBST_DRIVE_WITH_TRAILING_PATH_SEPERATOR); > ok(DriveType1 != SystemDriveType, "subst drive types match when it shouldn't\n"); > - ok(GetLastError() == ERROR_FILE_NOT_FOUND, "GetLastError() reports unexpected error code\n"); > + ok(GetLastError() == ERROR_FILE_NOT_FOUND, "Wrong last error. Expected %lu, got %lu\n", (DWORD)(ERROR_FILE_NOT_FOUND), GetLastError()); > dwMaskCur = GetLogicalDrives(); > ok(dwMaskCur != dwMaskPrev, "Drive masks match when it shouldn't\n"); > ok((dwMaskCur & (1 << (SUBST_DRIVE_LETTER - 'A'))), "Drive bit is not set\n"); > @@ -168,7 +168,7 @@ > ok(Result, "Failed to subst drive\n"); > DriveType1 = GetDriveTypeA(SUBST_DRIVE_WITH_TRAILING_PATH_SEPERATOR); > ok(DriveType1 != SystemDriveType, "subst drive types match when it shouldn't\n"); > - ok(GetLastError() == ERROR_FILE_NOT_FOUND, "GetLastError() reports unexpected error code\n"); > + ok(GetLastError() == ERROR_FILE_NOT_FOUND, "Wrong last error. Expected %lu, got %lu\n", (DWORD)(ERROR_FILE_NOT_FOUND), GetLastError()); > dwMaskCur = GetLogicalDrives(); > ok(dwMaskCur != dwMaskPrev, "Drive masks match when it shouldn't\n"); > ok((dwMaskCur & (1 << (SUBST_DRIVE_LETTER - 'A'))), "Drive bit is not set\n"); > @@ -203,7 +203,7 @@ > ok(Result, "Failed to subst drive\n"); > DriveType1 = GetDriveTypeA(SUBST_DRIVE_WITH_TRAILING_PATH_SEPERATOR); > ok(DriveType1 != SystemDriveType, "subst drive types match when it shouldn't\n"); > - ok(GetLastError() == ERROR_FILE_NOT_FOUND, "GetLastError() reports unexpected error code\n"); > + ok(GetLastError() == ERROR_FILE_NOT_FOUND, "Wrong last error. Expected %lu, got %lu\n", (DWORD)(ERROR_FILE_NOT_FOUND), GetLastError()); > dwMaskCur = GetLogicalDrives(); > ok(dwMaskCur != dwMaskPrev, "Drive masks match when it shouldn't\n"); > ok((dwMaskCur & (1 << (SUBST_DRIVE_LETTER - 'A'))), "Drive bit is not set\n"); > @@ -266,7 +266,7 @@ > ok((dwMaskCur & (1 << (SUBST_DRIVE_LETTER - 'A'))), "Drive bit is not set\n"); > hnd = FindFirstFileA(SUBST_DRIVE_SEARCH, &Data); > ok(hnd == INVALID_HANDLE_VALUE, "Opened subst drive when it should fail\n"); > - ok(GetLastError() == ERROR_INVALID_NAME, "GetLastError() reports unexpected error code\n"); > + ok(GetLastError() == ERROR_INVALID_NAME, "Wrong last error. Expected %lu, got %lu\n", (DWORD)(ERROR_INVALID_NAME), GetLastError()); > if (hnd) FindClose(hnd); > Result = DefineDosDeviceA(DDD_REMOVE_DEFINITION, SUBST_DRIVE, NULL); > ok(Result, "Failed to remove subst drive using NULL Target name\n"); > @@ -313,7 +313,7 @@ > ok(Result, "Failed to subst drive\n"); > DriveType1 = GetDriveTypeA(SUBST_DRIVE_WITH_TRAILING_PATH_SEPERATOR); > ok(DriveType1 != SystemDriveType, "subst drive types match when it shouldn't\n"); > - ok(GetLastError() == ERROR_FILE_NOT_FOUND, "GetLastError() reports unexpected error code\n"); > + ok(GetLastError() == ERROR_FILE_NOT_FOUND, "Wrong last error. Expected %lu, got %lu\n", (DWORD)(ERROR_FILE_NOT_FOUND), GetLastError()); > dwMaskCur = GetLogicalDrives(); > ok(dwMaskCur != dwMaskPrev, "Drive masks match when it shouldn't\n"); > ok((dwMaskCur & (1 << (SUBST_DRIVE_LETTER - 'A'))), "Drive bit is not set\n"); > @@ -333,7 +333,7 @@ > ok(Result, "Failed to subst drive\n"); > DriveType1 = GetDriveTypeA(SUBST_DRIVE_WITH_TRAILING_PATH_SEPERATOR); > ok(DriveType1 != SystemDriveType, "subst drive types match when it shouldn't\n"); > - ok(GetLastError() == ERROR_FILE_NOT_FOUND, "GetLastError() reports unexpected error code\n"); > + ok(GetLastError() == ERROR_FILE_NOT_FOUND, "Wrong last error. Expected %lu, got %lu\n", (DWORD)(ERROR_FILE_NOT_FOUND), GetLastError()); > dwMaskCur = GetLogicalDrives(); > ok(dwMaskCur != dwMaskPrev, "Drive masks match when it shouldn't\n"); > ok((dwMaskCur & (1 << (SUBST_DRIVE_LETTER - 'A'))), "Drive bit is not set\n"); > @@ -362,7 +362,7 @@ > ok(Result, "Failed to subst drive\n"); > Result = QueryDosDeviceA(SUBST_DRIVE, Buffer, 0); > ok(!Result, "Should fail as the buffer passed is supposed to be small\n"); > - ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "GetLastError() reports unexpected error code\n"); > + ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "Wrong last error. Expected %lu, got %lu\n", (DWORD)(ERROR_INSUFFICIENT_BUFFER), GetLastError()); > Result = QueryDosDeviceA(SUBST_DRIVE, Buffer, MAX_PATH); > ok(Result, "failed to get target path\n"); > ok(_strnicmp(Buffer, "\\??\\", 4) == 0, "The target returned does have correct prefix set\n"); > @@ -374,7 +374,7 @@ > /* This will try to retrieve all existing MS-DOS device names */ > Result = QueryDosDeviceA(NULL, Buffer, 0); > ok(!Result, "Should fail as the buffer passed is supposed to be small\n"); > - ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "GetLastError() reports unexpected error code\n"); > + ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "Wrong last error. Expected %lu, got %lu\n", (DWORD)(ERROR_INSUFFICIENT_BUFFER), GetLastError()); > } > > START_TEST(dosdev) > > >

2 1

About hotpatchable dlls on ReactOS
by Hermès BÉLUSCA - MAÏTO 02 Mar '14

02 Mar '14

Hi guys ! It seems to appear that some games need standard APIs hotpatchable, in the sense of MS: few extra bytes present in the prologue of the functions that allow somebody to detour the API. I knew that this feature was useful for windows updates, but what I didnt know is that there are other programs that use it: see this answer from James on the Epic Win! forum thread: http://www.reactos.org/forum/viewtopic.php?f=2 <http://www.reactos.org/forum/viewtopic.php?f=2&t=10972&p=106823#p106814> &t=10972&p=106823#p106814 , and the following post is something that Ive found about this subject, and the fact that Wine already have done something about that. So my question: should we support/create hotpatchable images (of the standard dlls and maybe ?? exes) in ReactOS ? Is it already done ? If not, what needs to be added ? It seems that MSVC and GCC handle that a bit differently. Cheers, Hermès BÉLUSCA - MAÏTO

4 6

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev March 2014