Ros-dev April 2014

ros-dev@reactos.org

14 participants
18 discussions

Re: [ros-dev] [ros-diffs] [dquintana] 63044: [RSHELL] [SHELL32] * Move the IID_NULL_PPV_ARG macro to the shobj_undoc header, next to the (also ros-specific) IID_PPV_ARG macro, so that it can be used elsewhere. [SHELL32] * M...

by Thomas Faber

On 2014-04-29 13:14, dquintana(a)svn.reactos.org wrote: > [SHELL32] > * Make use of IID_NULL_PPV_ARG in all the calls to GetUIObjectOf, and fix one instance of mismatched riid/pointer. I don't see that mismatch. What am I missing? ;)

10 years, 4 months

Re: [ros-dev] [ros-diffs] [tfaber] 63030: [FIND] - Avoid printf on a non-format string. Spotted by Víctor - Remove broken pseudo-TCHAR usage CORE-8112 #resolve

by Timo Kreuzer

Am 28.04.2014 10:06, schrieb tfaber(a)svn.reactos.org: > @@ -235,9 +235,9 @@ > } > else > { > - LoadString(GetModuleHandle(NULL), IDS_CANNOT_OPEN, (LPTSTR)lpMessage, 4096); > - CharToOem(lpMessage, lpMessage); > - fprintf (stderr, lpMessage, > + LoadString (GetModuleHandle (NULL), IDS_CANNOT_OPEN, szMessage, sizeof(szMessage) / sizeof(szMessage[0])); > + CharToOemA (szMessage, szMessage); > + fprintf (stderr, szMessage, > finddata.name); > } LoadString -> LoadStringA? Also, shouldn't we go unicode?

10 years, 4 months

Re: [ros-dev] [ros-diffs] [tfaber] 63032: [NETCFGX] - Use correct parent key instead of an uninitialized handle in INetCfgComponentControl_fnApplyRegistryChanges CORE-8115 #resolve

by Thomas Faber

Uh, this is missing the "Patch by Víctor Martínez" part, sorry. On 2014-04-28 10:27, tfaber(a)svn.reactos.org wrote: > Author: tfaber > Date: Mon Apr 28 08:27:57 2014 > New Revision: 63032 > > URL: http://svn.reactos.org/svn/reactos?rev=63032&view=rev > Log: > [NETCFGX] > - Use correct parent key instead of an uninitialized handle in INetCfgComponentControl_fnApplyRegistryChanges > CORE-8115 #resolve > > Modified: > trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c > > Modified: trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netcfgx/tcpipcon… > ============================================================================== > --- trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c [iso-8859-1] Mon Apr 28 08:27:57 2014 > @@ -3141,7 +3141,7 @@ > //MessageBoxW(NULL, L"INetCfgComponentControl_fnApplyRegistryChanges", NULL, MB_OK); > > > - if (RegCreateKeyExW(hKey, L"SYSTEM\\CurrentControlSet\\Services\\Tcpip\\Parameters", 0, NULL, 0, KEY_WRITE, NULL, &hKey, NULL) == ERROR_SUCCESS) > + if (RegCreateKeyExW(HKEY_LOCAL_MACHINE, L"SYSTEM\\CurrentControlSet\\Services\\Tcpip\\Parameters", 0, NULL, 0, KEY_WRITE, NULL, &hKey, NULL) == ERROR_SUCCESS) > { > if (pCurrentConfig->pDNS) > { > >

10 years, 4 months

Re: [ros-dev] [ros-diffs] [jimtabor] 63027: [Win32k] - Moved to new menu structures, synced in wine code and started first phase to server side. Resulting that more tests are running and failing less. Unplugged ntuser bad f...

by Thomas Faber

Jim, this introduced a new warning: win32ss/user/user32/windows/menu.c:1952:14: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Thanks. On 2014-04-28 08:40, jimtabor(a)svn.reactos.org wrote: > Author: jimtabor > Date: Mon Apr 28 03:55:23 2014 > New Revision: 63027 > > URL: http://svn.reactos.org/svn/reactos?rev=63027&view=rev > Log: > [Win32k] > - Moved to new menu structures, synced in wine code and started first phase to server side. Resulting that more tests are running and failing less. Unplugged ntuser bad functions. > - See CORE-5605, CORE-7447, CORE-7967, CORE-8098 and CORE-8107 > > Modified: > trunk/reactos/win32ss/include/ntuser.h > trunk/reactos/win32ss/user/ntuser/accelerator.c > trunk/reactos/win32ss/user/ntuser/menu.c > trunk/reactos/win32ss/user/ntuser/menu.h > trunk/reactos/win32ss/user/ntuser/object.c > trunk/reactos/win32ss/user/ntuser/simplecall.c > trunk/reactos/win32ss/user/ntuser/userfuncs.h > trunk/reactos/win32ss/user/ntuser/window.c > trunk/reactos/win32ss/user/user32/windows/menu.c > > [This mail would be too long, it was shortened to contain the URLs only.] > > Modified: trunk/reactos/win32ss/include/ntuser.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/include/ntuser.h?r… > > Modified: trunk/reactos/win32ss/user/ntuser/accelerator.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/accele… > > Modified: trunk/reactos/win32ss/user/ntuser/menu.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/menu.c… > > Modified: trunk/reactos/win32ss/user/ntuser/menu.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/menu.h… > > Modified: trunk/reactos/win32ss/user/ntuser/object.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/object… > > Modified: trunk/reactos/win32ss/user/ntuser/simplecall.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/simple… > > Modified: trunk/reactos/win32ss/user/ntuser/userfuncs.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/userfu… > > Modified: trunk/reactos/win32ss/user/ntuser/window.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/window… > > Modified: trunk/reactos/win32ss/user/user32/windows/menu.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/window… > >

10 years, 4 months

WebOS and ReactOS

by Alexander Rechitskiy

Let's bring up the webOS topic again. There is an interesting idea to port Nyx portability layer to Win32 and thus make Open webOS running in ReactOS/Windows. Nice user interface would be a benefit! http://www.openwebosproject.org/docs/architecture#.U1l8Uvl_vTo -- Best regards, Alexander Reachitskiy

10 years, 4 months

Status Meeting (April 2014)

by Aleksey Bragin

Hello, Let me invite you to the monthly status meeting taking place last Thursday of this month, 24th of April, 19:00 UTC. And this date is very close to now! IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. If someone still is not getting passwords sent before a meeting - please email Pierre before the meeting started to get one. Please send agenda proposals to me before the meeting, so that we can start with a proposed agenda. Regards, Aleksey Bragin

10 years, 4 months

Re: [ros-dev] [ros-diffs] [akhaldi] 62898: [PSDK] * Add missing MAXLONGLONG definition.

by Timo Kreuzer

Am 22.04.2014 23:43, schrieb akhaldi(a)svn.reactos.org: > Author: akhaldi > Date: Tue Apr 22 21:43:39 2014 > New Revision: 62898 > > URL: http://svn.reactos.org/svn/reactos?rev=62898&view=rev > Log: > [PSDK] > * Add missing MAXLONGLONG definition. > > Modified: > trunk/reactos/include/psdk/winnt.h > > Modified: trunk/reactos/include/psdk/winnt.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/winnt.h?rev=6… > ============================================================================== > --- trunk/reactos/include/psdk/winnt.h [iso-8859-1] (original) > +++ trunk/reactos/include/psdk/winnt.h [iso-8859-1] Tue Apr 22 21:43:39 2014 > @@ -1480,6 +1480,7 @@ > #define MAXBYTE 0xff > #define MAXWORD 0xffff > #define MAXDWORD 0xffffffff > +#define MAXLONGLONG (((LONGLONG)0x7fffffff << 32) | 0xffffffff) > #define PROCESSOR_INTEL_386 386 > #define PROCESSOR_INTEL_486 486 > #define PROCESSOR_INTEL_PENTIUM 586 > > > Why not use 0x7FFFFFFFFFFFFFFFLL ?

10 years, 4 months

Re: [ros-dev] [ros-diffs] [aandrejevic] 62892: [NTVDM] Quit when ntvdm becomes the last process attached to the console.

by Thomas Faber

On 2014-04-22 22:46, aandrejevic(a)svn.reactos.org wrote: > --- branches/ntvdm/subsystems/ntvdm/ntvdm.c [iso-8859-1] (original) > +++ branches/ntvdm/subsystems/ntvdm/ntvdm.c [iso-8859-1] Tue Apr 22 20:46:50 2014 > @@ -196,6 +197,11 @@ > EmulatorInterrupt(0x23); > break; > } > + case CTRL_LAST_CLOSE_EVENT: > + { > + if (CommandThread) TerminateThread(CommandThread, 0); > + break; > + } > default: > { > /* Stop the VDM if the user logs out or closes the console */ Wasn't there an event to tell that thread to exit? Using TerminateThread like this feels icky.

10 years, 4 months

Re: [ros-dev] [ros-diffs] [pschweitzer] 62779: [CDFS] Convert FCB pathname from simple buffer to unicode string. Please carefully review if I missed something

by Pierre Schweitzer

Hey! That's indeed a typo! Can someone commit a fix? I can't before Monday evening. Thanks! Pierre -------- Message original -------- Objet : Re: [ros-dev] [ros-diffs] [pschweitzer] 62779: [CDFS] Convert FCB pathname from simple buffer to unicode string. Please carefully review if I missed something De : Alexander Andrejevic <theflash(a)sdf.lonestar.org> À : ReactOS Development List <ros-dev(a)reactos.org> Cc : Hi, Correct me if I'm wrong, but the original version didn't modify the string length. Are you sure that should be "=" and not "=="? Regards, Alex On Sat, Apr 19, 2014 at 09:31:44AM +0200, Thomas Faber wrote: > On 2014-04-18 23:40, pschweitzer(a)svn.reactos.org wrote: > > --- trunk/reactos/drivers/filesystems/cdfs/fcb.c [iso-8859-1] (original) > > +++ trunk/reactos/drivers/filesystems/cdfs/fcb.c [iso-8859-1] Fri Apr 18 21:40:02 2014 > > @@ -129,7 +131,7 @@ > > BOOLEAN > > CdfsFCBIsRoot(PFCB Fcb) > > { > > - return(wcscmp(Fcb->PathName, L"\\") == 0); > > + return (Fcb->PathName.Length = sizeof(WCHAR) && Fcb->PathName.Buffer[0] == L'\\'); > > } > > == > > > > Generally I'm seeing a lot of manual work where > RtlInitEmptyUnicodeString and RtlCopyUnicodeString could be used. > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev -- Alexander Andrejevic <theflash(a)sdf.lonestar.org> SDF Public Access UNIX System - http://sdf.lonestar.org _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

10 years, 4 months

Re: [ros-dev] [ros-diffs] [pschweitzer] 62779: [CDFS] Convert FCB pathname from simple buffer to unicode string. Please carefully review if I missed something

by Thomas Faber

On 2014-04-18 23:40, pschweitzer(a)svn.reactos.org wrote: > --- trunk/reactos/drivers/filesystems/cdfs/fcb.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/cdfs/fcb.c [iso-8859-1] Fri Apr 18 21:40:02 2014 > @@ -129,7 +131,7 @@ > BOOLEAN > CdfsFCBIsRoot(PFCB Fcb) > { > - return(wcscmp(Fcb->PathName, L"\\") == 0); > + return (Fcb->PathName.Length = sizeof(WCHAR) && Fcb->PathName.Buffer[0] == L'\\'); > } == Generally I'm seeing a lot of manual work where RtlInitEmptyUnicodeString and RtlCopyUnicodeString could be used.

10 years, 4 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev April 2014