Ros-dev May 2014

ros-dev@reactos.org

18 participants
20 discussions

Instanciate TAP device for Virtualisation

by Maxime Daniel

Hi, I'm working on network virtualization support in ReactOS. At this time, PoC works but I reach a point where I need a solution that would allow to add and remove TAP (TAP-Win32 from OpenVPN for exemple) Network Devices from kernel space, without user intervention. The problem right now is that there seems to be impossible in ReactOS to have a proper way or tips and tricks to add/remove TAP devices without rebooting the system. What should be fixed/edit to instanciate of TAP device on the fly on the current implementation (r63193) ? Thanks -- Daniel Maxime Linux version 3.6.9-maxux64 (emy) (gcc version 4.7.3 (Gentoo 4.7.3-r1 p1.4, pie-0.5.5) ) #3 SMP PREEMPT Wed Feb 19 16:40:22 CET 2014 17:15:01 up 1 day, 1:44, 1 user, load average: 0.29, 0.28, 0.35

10 years, 6 months

Re: [ros-dev] [ros-diffs] [hbelusca] 63506: [NTOS:CM] Replace a hardcoded value with something more readable.

by Timo Kreuzer

Am 30.05.2014 23:47, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Fri May 30 21:47:22 2014 > New Revision: 63506 > > URL: http://svn.reactos.org/svn/reactos?rev=63506&view=rev > Log: > [NTOS:CM] > Replace a hardcoded value with something more readable. > - RootKey->Type = '20yk'; > + RootKey->Type = CM_KEY_BODY_TYPE; > RootKey->NotifyBlock = NULL; > +// > +#define CM_KEY_BODY_TYPE 0x6B793032 Why not '20yk' ? This hex constant looks fishy.

10 years, 6 months

Re: [ros-dev] [ros-diffs] [tkreuzer] 63388: [NTOSKRNL] Fix ending address calculation for the commit path in NtAllocateVirtualMemory like done for the reserve path in r63356. Add a comment about a Windows kernel bug, which ...

by Thomas Faber

On 2014-05-20 23:11, tkreuzer(a)svn.reactos.org wrote: > --- trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] Tue May 20 21:11:43 2014 > @@ -4593,8 +4593,8 @@ > // on the user input, and then compute the actual region size once all the > // alignments have been done. > // > + EndingAddress = (((ULONG_PTR)PBaseAddress + PRegionSize - 1) | (PAGE_SIZE - 1)); > StartingAddress = (ULONG_PTR)PAGE_ALIGN(PBaseAddress); > - EndingAddress = (((ULONG_PTR)PBaseAddress + PRegionSize - 1) | (PAGE_SIZE - 1)); > PRegionSize = EndingAddress - StartingAddress + 1; > > // Can you explain this a bit? I don't see any logic change.

10 years, 6 months

SVN r63496

by Eric Kohl

>[LSASRV] > >- Just run again the loop if LsarOpenAccount call failed (that also >avoids a call to LsarClose on a NULL handle, that is trapped by the >kdbg if one enabled "set condition * first always"). > >- Free the memory and the opened handles before returning in case of >failure of LsapAddPrivilegeToTokenPrivileges. Maybe this cleaning step >can be done more elegantly. > >Eric, can you please review that? It should be good I think. The change is OK!

10 years, 6 months

Re: [ros-dev] [ros-diffs] [akhaldi] 63480: [CMAKE] * Convert the hives from UTF-8 to UTF16 as part of the build process. CORE-7703 CORE-8221

by Thomas Faber

The savior, as always. Thank you! On 2014-05-27 21:42, akhaldi(a)svn.reactos.org wrote: > Author: akhaldi > Date: Tue May 27 19:42:15 2014 > New Revision: 63480 > > URL: http://svn.reactos.org/svn/reactos?rev=63480&view=rev > Log: > [CMAKE] > * Convert the hives from UTF-8 to UTF16 as part of the build process. > CORE-7703 > CORE-8221 > > Modified: > trunk/reactos/boot/bootdata/CMakeLists.txt > trunk/reactos/boot/bootdata/hivecls.inf (contents, props changed) > trunk/reactos/boot/bootdata/hivedef.inf (contents, props changed) > trunk/reactos/boot/bootdata/hivesft.inf (contents, props changed) > trunk/reactos/boot/bootdata/hivesys.inf > trunk/reactos/cmake/CMakeMacros.cmake > > [This mail would be too long, it was shortened to contain the URLs only.] > > Modified: trunk/reactos/boot/bootdata/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/CMakeLists.t… > > Modified: trunk/reactos/boot/bootdata/hivecls.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivecls.inf?… > > Modified: trunk/reactos/boot/bootdata/hivedef.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivedef.inf?… > > Modified: trunk/reactos/boot/bootdata/hivesft.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesft.inf?… > > Modified: trunk/reactos/boot/bootdata/hivesys.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys.inf?… > > Modified: trunk/reactos/cmake/CMakeMacros.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/CMakeMacros.cmake?re… > >

10 years, 6 months

Re: [ros-dev] [ros-diffs] [cwittich] 63452: [bootdata] convert hivecls.inf and hivedef.inf to UTF16LE fixes CORE-7614

by Thomas Faber

This is not the right solution. SVN has terrible UTF-16 handling so we should not convert these back to UTF-16. https://jira.reactos.org/browse/CORE-7703 https://jira.reactos.org/browse/CORE-8221 On 2014-05-25 22:17, cwittich(a)svn.reactos.org wrote: > Author: cwittich > Date: Sun May 25 20:17:25 2014 > New Revision: 63452 > > URL: http://svn.reactos.org/svn/reactos?rev=63452&view=rev > Log: > [bootdata] > convert hivecls.inf and hivedef.inf to UTF16LE > fixes CORE-7614 > > Modified: > trunk/reactos/boot/bootdata/hivecls.inf (contents, props changed) > trunk/reactos/boot/bootdata/hivedef.inf (contents, props changed) >

10 years, 7 months

Regarding recent FAT32 partition handling work by Eric

by Caemyr

I would like to applaud Eric for his outstanding work with ROS partition handling, which we are able to experience since recently. Eric himself had tested this code including GParted, but i`ve that is not all. 7z is able to read FAT partition image files, but this didn't work at all. Right now i was able to open up ROS vmdk image, created by ReactOS itself and view/extract anything of its contents. I cannot express enough how handy this is going to be, allowing to access ROS vm hard disk contents without the pesky hdd mounting (which never really work reliably for me), transferring anything out of the vm by LAN/Internet or booting other VM with those HDDs co-mounted. Simply I cannot thank you enough for your work. Pic included as proof. -- With best regards Caemyr

10 years, 7 months

Re: [ros-dev] [ros-diffs] [cwittich] 63423: [shell32] revert one line of r63414

by Thomas Faber

> --- trunk/reactos/dll/win32/shell32/shlexec.cpp [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/shell32/shlexec.cpp [iso-8859-1] Fri May 23 17:14:39 2014 > @@ -459,7 +459,7 @@ > startup.dwFlags = STARTF_USESHOWWINDOW; > startup.wShowWindow = psei->nShow; > dwCreationFlags = CREATE_UNICODE_ENVIRONMENT; > - if (!(psei->fMask & SEE_MASK_NO_CONSOLE)) > + if (psei->fMask & SEE_MASK_NO_CONSOLE) > dwCreationFlags |= CREATE_NEW_CONSOLE; > startup.lpTitle = (LPWSTR)(psei->fMask & (SEE_MASK_HASLINKNAME | SEE_MASK_HASTITLE) ? psei->lpClass : NULL); This is the opposite of what the documentation says?

10 years, 7 months

Re: [ros-dev] [ros-diffs] [akhaldi] 63353: [CMAKE/MSVC] * Define _ALLOW_KEYWORD_MACROS to get the news MSVC toolchain to allow us to redefine inline (it became a keyword). Reported by David Quintana.

by Thomas Faber

Hrm, why not just limit the define to C instead? On 2014-05-18 16:39, akhaldi(a)svn.reactos.org wrote: > Author: akhaldi > Date: Sun May 18 14:39:03 2014 > New Revision: 63353 > > URL: http://svn.reactos.org/svn/reactos?rev=63353&view=rev > Log: > [CMAKE/MSVC] > * Define _ALLOW_KEYWORD_MACROS to get the news MSVC toolchain to allow us to redefine inline (it became a keyword). Reported by David Quintana. > > Modified: > trunk/reactos/CMakeLists.txt > > Modified: trunk/reactos/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/CMakeLists.txt?rev=63353&r… > ============================================================================== > --- trunk/reactos/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/CMakeLists.txt [iso-8859-1] Sun May 18 14:39:03 2014 > @@ -62,6 +62,9 @@ > if(MSVC) > if(ARCH STREQUAL "i386") > add_definitions(/D_X86_ /DWIN32 /D_WINDOWS) > + endif() > + if(MSVC_VERSION GREATER 1799) > + add_definitions(/D_ALLOW_KEYWORD_MACROS) > endif() > add_definitions(/Dinline=__inline) > else() > >

10 years, 7 months

Re: [ros-dev] [ros-diffs] [hbelusca] 63398: [USETUP] - Fix a bit the translation of yesterday; - Use TEXT_PADDING_BIG instead of hardcoding 3 spaces in the status messages.

by Pierre Schweitzer

On 05/21/2014 02:23 PM, hbelusca(a)svn.reactos.org wrote: > Author: hbelusca > Date: Wed May 21 12:23:04 2014 > New Revision: 63398 > > URL: http://svn.reactos.org/svn/reactos?rev=63398&view=rev > Log: > [USETUP] > - Fix a bit the translation of yesterday; > - Use TEXT_PADDING_BIG instead of hardcoding 3 spaces in the status messages. > > Modified: > trunk/reactos/base/setup/usetup/lang/fr-FR.h > > Modified: trunk/reactos/base/setup/usetup/lang/fr-FR.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/lang/fr-… > ============================================================================== > --- trunk/reactos/base/setup/usetup/lang/fr-FR.h [iso-8859-1] (original) > +++ trunk/reactos/base/setup/usetup/lang/fr-FR.h [iso-8859-1] Wed May 21 12:23:04 2014 > @@ -642,8 +642,8 @@ > { > 0, > 0, > - " Veuillez attendre ...", > - TEXT_TYPE_STATUS, > + "Veuillez attendre ...", > + TEXT_TYPE_STATUS | TEXT_PADDING_BIG > }, > { > 0, It would be better to have "Veuillez patienter..." "Attendre" sounds so weird in that context. > @@ -850,8 +850,8 @@ > { > 0, > 0, > - " Patienter...", > - TEXT_TYPE_STATUS > + "Patienter...", > + TEXT_TYPE_STATUS | TEXT_PADDING_BIG > }, > { > 0, Here, it's likely to be "Patientez..." (to be checked though). -- Pierre Schweitzer <pierre(a)reactos.org> System Administrator ReactOS Foundation

10 years, 7 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev May 2014