Ros-dev May 2014

ros-dev@reactos.org

18 participants
20 discussions

Start a nNew thread

New Patchbot is ready
by Colin Finck 21 May '14

21 May '14

The new Linux-based Patchbot is finally live. Do whatever you want with it.

1 0

Re: [ros-dev] [ros-diffs] [ekohl] 63330: [NTOSKRNL] Partial revert of r63326! The correct partition numbers cause boot failures.
by Alex Ionescu 20 May '14

20 May '14

Lol so maybe you should think twice next time you see "FIXFIX REACTOS HACK" like I originally wrote it ;-) Best regards, Alex Ionescu On Sat, May 17, 2014 at 4:42 PM, <ekohl(a)svn.reactos.org> wrote: > Author: ekohl > Date: Sat May 17 14:42:28 2014 > New Revision: 63330 > > URL: http://svn.reactos.org/svn/reactos?rev=63330&view=rev > Log: > [NTOSKRNL] > Partial revert of r63326! The correct partition numbers cause boot failures. > > Modified: > trunk/reactos/ntoskrnl/fstub/disksup.c > > Modified: trunk/reactos/ntoskrnl/fstub/disksup.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fstub/disksup.c?r… > ============================================================================== > --- trunk/reactos/ntoskrnl/fstub/disksup.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/fstub/disksup.c [iso-8859-1] Sat May 17 14:42:28 2014 > @@ -1655,7 +1655,9 @@ > UInt32x32To64(GET_PARTITION_LENGTH(PartitionDescriptor), > SectorSize); > > - PartitionInfo->PartitionNumber = (!IsContainerPartition(PartitionType)) ? i : 0; > + // BUGBUGBUG: The correct partition numbers seem to cause boot failures!!! > +// PartitionInfo->PartitionNumber = (!IsContainerPartition(PartitionType)) ? i : 0; > + PartitionInfo->PartitionNumber = i + 1; > } > else > { > >

2 1

libusb-win32 - can we use it?
by Alexander Rechitskiy 20 May '14

20 May '14

http://sourceforge.net/apps/trac/libusb-win32/wiki -- Best regards, Alexander Rechitskiy

3 3

Re: [ros-dev] [ros-diffs] [ekohl] 63326: [NTOSKRNL] xHalIoReadPartitionTable: Only used non-container partition entries have a non-zero partition number.
by Pierre Schweitzer 17 May '14

17 May '14

Hey Eric, This fix unfortunately broke trunk. Our four testbots are red. Have a look here, for instance: http://build.reactos.org/builders/Linux_AMD64_1%20KVM-Test/builds/6442/step… Cheers, Pierre On 17/05/2014 14:55, ekohl(a)svn.reactos.org wrote: > Author: ekohl > Date: Sat May 17 12:55:06 2014 > New Revision: 63326 > > URL: http://svn.reactos.org/svn/reactos?rev=63326&view=rev > Log: > [NTOSKRNL] > xHalIoReadPartitionTable: Only used non-container partition entries have a non-zero partition number. > > Modified: > trunk/reactos/ntoskrnl/fstub/disksup.c > > Modified: trunk/reactos/ntoskrnl/fstub/disksup.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fstub/disksup.c?r… > ============================================================================== > --- trunk/reactos/ntoskrnl/fstub/disksup.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/fstub/disksup.c [iso-8859-1] Sat May 17 12:55:06 2014 > @@ -1655,8 +1655,7 @@ > UInt32x32To64(GET_PARTITION_LENGTH(PartitionDescriptor), > SectorSize); > > - /* FIXME: REACTOS HACK */ > - PartitionInfo->PartitionNumber = i + 1; > + PartitionInfo->PartitionNumber = (!IsContainerPartition(PartitionType)) ? i : 0; > } > else > { > @@ -1667,7 +1666,6 @@ > PartitionInfo->PartitionLength.QuadPart = 0; > PartitionInfo->HiddenSectors = 0; > > - /* FIXME: REACTOS HACK */ > PartitionInfo->PartitionNumber = 0; > } > } > > -- Pierre Schweitzer<pierre at reactos.org> System Administrator ReactOS Foundation

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 63135: Arch, please do not mix up ANSI vs. UNICODE string functions, do you?
by Aleksey Bragin 17 May '14

17 May '14

Speaking of that (1000s time), the proper way would be to convert everything to UNICODE. It would help. Regards, Aleksey Bragin On 03.05.2014 21:24, hbelusca(a)svn.reactos.org wrote: > Author: hbelusca > Date: Sat May 3 17:24:22 2014 > New Revision: 63135 > > URL: http://svn.reactos.org/svn/reactos?rev=63135&view=rev > Log: > Arch, please do not mix up ANSI vs. UNICODE string functions, do you? > > Modified: > trunk/reactos/base/applications/network/ftp/cmds.c > > Modified: trunk/reactos/base/applications/network/ftp/cmds.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/… > ============================================================================== > --- trunk/reactos/base/applications/network/ftp/cmds.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/network/ftp/cmds.c [iso-8859-1] Sat May 3 17:24:22 2014 > @@ -1303,13 +1303,13 @@ > > if (argc > 1) > { > - strncat(CmdLine, " /C", MAX_PATH - wcslen(Cmdline) - 1); > + strncat(CmdLine, " /C", MAX_PATH - strlen(Cmdline) - 1); > } > > for (i=1; i<argc; i++) > { > - strncat(CmdLine, " ", MAX_PATH - wsclen(Cmdline) - 1); > - strncat(CmdLine, argv[i], MAX_PATH - wsclen(Cmdline) -1); > + strncat(CmdLine, " ", MAX_PATH - strlen(Cmdline) - 1); > + strncat(CmdLine, argv[i], MAX_PATH - strlen(Cmdline) -1); > } > > StartupInfo.cb = sizeof( StartupInfo ); > >

3 2

ReactOS' defragger "Fraginator" history
by Hermès BÉLUSCA - MAÏTO 13 May '14

13 May '14

Hi everybody! During some little maintenance of rosapps I was doing during some work pause, I wanted to know from where we found our still unused (until someone programs the defragmentation API :P) defragger called Fraginator. Since it doesnt contain any information about his initial author I tried to check into the SVN log, and I found that it was added in our codebase in 2006 by Ged: see the commit log http://svn.reactos.org/svn/reactos?view=revision <http://svn.reactos.org/svn/reactos?view=revision&revision=21411> &revision=21411 ; notice that the committer mentioned that [Fraginator] is pretty hard to come by on the net now. Nevertheless nothing is said about his author. However (!!) googling at fraginator defragger, I fell on this webpage, certainly written by the actual Fraginator author: http://blog.getpaint.net/2012/03/28/college-adventures-in-open-source-fragin ator-edition/ . In this blog entry you have the story of the Fraginator defragger! (if someone can add an entry, he/shes welcome). Nice reading! Hermès.

1 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 63247: [DDK/XDK/NTOSKRNL/DRIVERS] Fix incompatible definition of a number of NTOSKRNL data imports. These imports are declared in MS DDK in a way that is usually not how you would declar...
by Thomas Faber 12 May '14

12 May '14

Woohoo, thanks! Questions/comments inline. On 2014-05-12 01:11, tkreuzer(a)svn.reactos.org wrote: > --- trunk/reactos/include/ddk/ntifs.h [iso-8859-1] (original) > +++ trunk/reactos/include/ddk/ntifs.h [iso-8859-1] Sun May 11 23:11:16 2014 > @@ -870,11 +870,11 @@ > (NTAPI *PRTL_FREE_STRING_ROUTINE)( > _In_ __drv_freesMem(Mem) _Post_invalid_ PVOID Buffer); > > -extern const PRTL_ALLOCATE_STRING_ROUTINE RtlAllocateStringRoutine; > -extern const PRTL_FREE_STRING_ROUTINE RtlFreeStringRoutine; > +extern NTKERNELAPI const PRTL_ALLOCATE_STRING_ROUTINE RtlAllocateStringRoutine; > +extern NTKERNELAPI const PRTL_FREE_STRING_ROUTINE RtlFreeStringRoutine; > > #if _WIN32_WINNT >= 0x0600 > -extern const PRTL_REALLOCATE_STRING_ROUTINE RtlReallocateStringRoutine; > +extern NTKERNELAPI const PRTL_REALLOCATE_STRING_ROUTINE RtlReallocateStringRoutine; > #endif > > _Function_class_(RTL_HEAP_COMMIT_ROUTINE) Do you have any idea what RtlAllocateStringRoutine and friends are? They don't seem to exist. (NDK defines them for user mode btw, without dllimport) > Modified: trunk/reactos/include/ddk/wdm.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/wdm.h?rev=6324… > ============================================================================== > --- trunk/reactos/include/ddk/wdm.h [iso-8859-1] (original) > +++ trunk/reactos/include/ddk/wdm.h [iso-8859-1] Sun May 11 23:11:16 2014 > @@ -82,10 +85,13 @@ > #endif > > /* For ReactOS */ > -#if !defined(_NTOSKRNL_) && !defined(_BLDR_) > +#if !defined(_NTOSKRNL_) && !defined(_BLDR_) && !defined(_NTSYSTEM_) > #define NTKERNELAPI DECLSPEC_IMPORT > #else > #define NTKERNELAPI > +#ifndef _NTSYSTEM_ > +#define _NTSYSTEM_ > +#endif > #endif > > #if defined(_X86_) && !defined(_NTHAL_) We should probably switch to using _NTSYSTEM_ instead of _NTOSKRNL_ at some point? > @@ -129,6 +135,29 @@ > #define ALLOC_DATA_PRAGMA 1 > #endif > > +#endif /* _MSC_VER */ > + > +/* These macros are used to create aliases for imported data. We need to do > + this to have declarations that are compatible with MS DDK */ > +#ifdef _M_IX86 > +#define __SYMBOL(_Name) "_"#_Name > +#define __IMPORTSYMBOL(_Name) "__imp__"#_Name > +#define __IMPORTNAME(_Name) _imp__##_Name > +#else > +#define __SYMBOL(_Name) #_Name > +#define __IMPORTSYMBOL(_Name) "__imp_"#_Name > +#define __IMPORTNAME(_Name) __imp_##_Name > +#endif > +#ifdef _MSC_VER > +#define __CREATE_NTOS_DATA_IMPORT_ALIAS(_Name) \ > + __pragma(comment(linker, "/alternatename:"__SYMBOL(_Name) "=" __IMPORTSYMBOL(_Name))) > +#else /* !_MSC_VER */ > +#ifndef __STRINGIFY > +#define __STRINGIFY(_exp) #_exp > +#endif > +#define _Pragma_redifine_extname(_Name, _Target) _Pragma(__STRINGIFY(redefine_extname _Name _Target)) > +#define __CREATE_NTOS_DATA_IMPORT_ALIAS(_Name) \ > + _Pragma_redifine_extname(_Name,__IMPORTNAME(_Name)) > #endif > > #if defined(_WIN64) s/redifine/redefine/ > --- trunk/reactos/ntoskrnl/kd64/kdapi.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/kd64/kdapi.c [iso-8859-1] Sun May 11 23:11:16 2014 > @@ -1903,9 +1903,7 @@ > > /* We are disabled now */ > KdDebuggerEnabled = FALSE; > -#undef KdDebuggerEnabled > SharedUserData->KdDebuggerEnabled = FALSE; > -#define KdDebuggerEnabled _KdDebuggerEnabled > } > } Should this not use KD_DEBUGGER_ENABLED? (same in kdinit.c)

2 1

Re: [ros-dev] [ros-diffs] [cwittich] 63225: [comctl32] Notify the parent on a return key press. fixes return key in device manager
by Hermès BÉLUSCA - MAÏTO 11 May '14

11 May '14

Hi Christoph ! Are you sure that before committing this fix in Wine code, you: 1- made a patch to wine's code, 2- sent it to them, and 3- checked that they merged too in their code base? Because otherwise your fix here might be lost in the next Wine code sync... Cheers, Hermès. -----Message d'origine----- Author: cwittich Date: Sun May 11 05:04:56 2014 New Revision: 63225 URL: http://svn.reactos.org/svn/reactos?rev=63225&view=rev Log: [comctl32] Notify the parent on a return key press. fixes return key in device manager Modified: trunk/reactos/dll/win32/comctl32/treeview.c Modified: trunk/reactos/dll/win32/comctl32/treeview.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/treeview .c?rev=63225&r1=63224&r2=63225&view=diff ============================================================================ == --- trunk/reactos/dll/win32/comctl32/treeview.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/comctl32/treeview.c [iso-8859-1] Sun May 11 05:04:56 2014 @@ -5242,6 +5242,10 @@ newSelection = TREEVIEW_GetNextListItem(infoPtr, prevItem); break; + case VK_RETURN: + TREEVIEW_SendSimpleNotify(infoPtr, NM_RETURN); + break; + case VK_HOME: newSelection = infoPtr->root->firstChild; break;

1 1

Re: [ros-dev] [ros-diffs] [hbelusca] 63202: [RPCRT4] Detect whether we are connecting to a pipe on the local machine and use the \\.\ prefix instead of the full machine name. This patch modifies ReactOS-specific code (that ...
by Timo Kreuzer 10 May '14

10 May '14

Am 09.05.2014 03:57, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Fri May 9 01:57:43 2014 > New Revision: 63202 > > URL: http://svn.reactos.org/svn/reactos?rev=63202&view=rev > Log: > [RPCRT4] > Detect whether we are connecting to a pipe on the local machine and use the \\.\ prefix instead of the full machine name. > This patch modifies ReactOS-specific code (that was introduced by Eric in revision 53630) (Wine still supports only local pipes), so I also update our rpcrt4_ros.diff file accordingly, r63201 with respect to the latest Wine 1.7.17 rpcrt4 code. > Modified: trunk/reactos/dll/win32/rpcrt4/rpcrt4_ros.diff > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/rpcrt4_ro… > ============================================================================== > [...] > > +diff -prudN .\wine\dlls\rpcrt4/msvc.S .\reactos\dll\win32\rpcrt4/msvc.S > +--- .\wine\dlls\rpcrt4/msvc.S 1970-01-01 01:00:00.000000000 +0100 > ++++ .\reactos\dll\win32\rpcrt4/msvc.S 2012-02-14 21:27:35.943001900 +0100 > +@@ -0,0 +1,146 @@ > > +diff -prudN .\wine\dlls\rpcrt4/precomp.h .\reactos\dll\win32\rpcrt4/precomp.h > +--- .\wine\dlls\rpcrt4/precomp.h 1970-01-01 01:00:00.000000000 +0100 > ++++ .\reactos\dll\win32\rpcrt4/precomp.h 2014-03-14 01:43:22.357516600 +0100 > > +diff -prudN .\wine\dlls\rpcrt4/unix_func.c .\reactos\dll\win32\rpcrt4/unix_func.c > +--- .\wine\dlls\rpcrt4/unix_func.c 1970-01-01 01:00:00.000000000 +0100 > ++++ .\reactos\dll\win32\rpcrt4/unix_func.c 2013-01-25 00:19:53.278052800 +0100 Why add these to the diff?

2 1

r58367 - Fix a bug in StartupWindowThread
by Aleksey Bragin 02 May '14

02 May '14

Hi, http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msgina/gui.c?r1=… Is there a point in that DuplicateHandle call? "When SetThreadDesktop is called the system closes the desktop handle when needed so we have to create a new handle because this handle may still be in use by winlogon" Sorry, I re-read that comment a few times and still can't understand. I take it that SetThreadDesktop closes the old handle which was set before. And it may, for some reason, be used by winlogon. Shouldn't that be a place to fix, rather than the hack in r58367? And why is the SetThreadDesktop(OldDesk) is removed by this revision? Regards, Aleksey Bragin

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev May 2014