Lol so maybe you should think twice next time you see "FIXFIX REACTOS
HACK" like I originally wrote it ;-)
Best regards,
Alex Ionescu
On Sat, May 17, 2014 at 4:42 PM, <ekohl(a)svn.reactos.org> wrote:
> Author: ekohl
> Date: Sat May 17 14:42:28 2014
> New Revision: 63330
>
> URL: http://svn.reactos.org/svn/reactos?rev=63330&view=rev
> Log:
> [NTOSKRNL]
> Partial revert of r63326! The correct partition numbers cause boot failures.
>
> Modified:
> trunk/reactos/ntoskrnl/fstub/disksup.c
>
> Modified: trunk/reactos/ntoskrnl/fstub/disksup.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fstub/disksup.c?r…
> ==============================================================================
> --- trunk/reactos/ntoskrnl/fstub/disksup.c [iso-8859-1] (original)
> +++ trunk/reactos/ntoskrnl/fstub/disksup.c [iso-8859-1] Sat May 17 14:42:28 2014
> @@ -1655,7 +1655,9 @@
> UInt32x32To64(GET_PARTITION_LENGTH(PartitionDescriptor),
> SectorSize);
>
> - PartitionInfo->PartitionNumber = (!IsContainerPartition(PartitionType)) ? i : 0;
> + // BUGBUGBUG: The correct partition numbers seem to cause boot failures!!!
> +// PartitionInfo->PartitionNumber = (!IsContainerPartition(PartitionType)) ? i : 0;
> + PartitionInfo->PartitionNumber = i + 1;
> }
> else
> {
>
>
Hi everybody!
During some little maintenance of rosapps I was doing during some work
pause, I wanted to know from where we found our still unused (until someone
programs the defragmentation API :P) defragger called Fraginator. Since it
doesnt contain any information about his initial author I tried to check
into the SVN log, and I found that it was added in our codebase in 2006 by
Ged: see the commit log http://svn.reactos.org/svn/reactos?view=revision
<http://svn.reactos.org/svn/reactos?view=revision&revision=21411>
&revision=21411 ; notice that the committer mentioned that [Fraginator] is
pretty hard to come by on the net now. Nevertheless nothing is said about
his author.
However (!!) googling at fraginator defragger, I fell on this webpage,
certainly written by the actual Fraginator author:
http://blog.getpaint.net/2012/03/28/college-adventures-in-open-source-fragin
ator-edition/ . In this blog entry you have the story of the Fraginator
defragger! (if someone can add an entry, he/shes welcome).
Nice reading!
Hermès.
Hi Christoph !
Are you sure that before committing this fix in Wine code, you: 1- made a
patch to wine's code, 2- sent it to them, and 3- checked that they merged
too in their code base? Because otherwise your fix here might be lost in the
next Wine code sync...
Cheers,
Hermès.
-----Message d'origine-----
Author: cwittich
Date: Sun May 11 05:04:56 2014
New Revision: 63225
URL: http://svn.reactos.org/svn/reactos?rev=63225&view=rev
Log:
[comctl32]
Notify the parent on a return key press.
fixes return key in device manager
Modified:
trunk/reactos/dll/win32/comctl32/treeview.c
Modified: trunk/reactos/dll/win32/comctl32/treeview.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/treeview
.c?rev=63225&r1=63224&r2=63225&view=diff
============================================================================
==
--- trunk/reactos/dll/win32/comctl32/treeview.c [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/comctl32/treeview.c [iso-8859-1] Sun May 11
05:04:56 2014
@@ -5242,6 +5242,10 @@
newSelection = TREEVIEW_GetNextListItem(infoPtr, prevItem);
break;
+ case VK_RETURN:
+ TREEVIEW_SendSimpleNotify(infoPtr, NM_RETURN);
+ break;
+
case VK_HOME:
newSelection = infoPtr->root->firstChild;
break;
Am 09.05.2014 03:57, schrieb hbelusca(a)svn.reactos.org:
> Author: hbelusca
> Date: Fri May 9 01:57:43 2014
> New Revision: 63202
>
> URL: http://svn.reactos.org/svn/reactos?rev=63202&view=rev
> Log:
> [RPCRT4]
> Detect whether we are connecting to a pipe on the local machine and use the \\.\ prefix instead of the full machine name.
> This patch modifies ReactOS-specific code (that was introduced by Eric in revision 53630) (Wine still supports only local pipes), so I also update our rpcrt4_ros.diff file accordingly, r63201 with respect to the latest Wine 1.7.17 rpcrt4 code.
> Modified: trunk/reactos/dll/win32/rpcrt4/rpcrt4_ros.diff
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/rpcrt4_ro…
> ==============================================================================
> [...]
>
> +diff -prudN .\wine\dlls\rpcrt4/msvc.S .\reactos\dll\win32\rpcrt4/msvc.S
> +--- .\wine\dlls\rpcrt4/msvc.S 1970-01-01 01:00:00.000000000 +0100
> ++++ .\reactos\dll\win32\rpcrt4/msvc.S 2012-02-14 21:27:35.943001900 +0100
> +@@ -0,0 +1,146 @@
>
> +diff -prudN .\wine\dlls\rpcrt4/precomp.h .\reactos\dll\win32\rpcrt4/precomp.h
> +--- .\wine\dlls\rpcrt4/precomp.h 1970-01-01 01:00:00.000000000 +0100
> ++++ .\reactos\dll\win32\rpcrt4/precomp.h 2014-03-14 01:43:22.357516600 +0100
>
> +diff -prudN .\wine\dlls\rpcrt4/unix_func.c .\reactos\dll\win32\rpcrt4/unix_func.c
> +--- .\wine\dlls\rpcrt4/unix_func.c 1970-01-01 01:00:00.000000000 +0100
> ++++ .\reactos\dll\win32\rpcrt4/unix_func.c 2013-01-25 00:19:53.278052800 +0100
Why add these to the diff?
Hi,
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msgina/gui.c?r1=…
Is there a point in that DuplicateHandle call?
"When SetThreadDesktop is called the system closes the desktop handle
when needed
so we have to create a new handle because this handle may still be in
use by winlogon"
Sorry, I re-read that comment a few times and still can't understand. I
take it that SetThreadDesktop closes the old handle which was set
before. And it may, for some reason, be used by winlogon. Shouldn't that
be a place to fix, rather than the hack in r58367?
And why is the SetThreadDesktop(OldDesk) is removed by this revision?
Regards,
Aleksey Bragin