Ros-dev August 2014

ros-dev@reactos.org

7 participants
10 discussions

Re: [ros-dev] [ros-diffs] [tfaber] 63953: [FASTFAT] - Do not use direct I/O since it limits read/write operations to 64 MB CORE-8410 #resolve

by cameron.gutman＠reactos.org

This seems strange. I understand that NT 5.x has a limitation of 64 MB MDLs on x86, but direct I/O was designed for exactly this case of large I/O operations. Has anyone verified that 2k3 doesn’t do MDL chaining for direct I/O when the transfer is larger than a single MDL can hold? Also aren’t there changes to the IRP dispatch routines required to cope with not having an Irp->MdlAddress pointer anymore? Cameron From: tfaber(a)svn.reactos.org Sent: ‎Tuesday‎, ‎August‎ ‎26‎, ‎2014 ‎6‎:‎41‎ ‎AM To: ros-diffs(a)reactos.org Author: tfaber Date: Tue Aug 26 13:41:57 2014 New Revision: 63953 URL: http://svn.reactos.org/svn/reactos?rev=63953&view=rev Log: [FASTFAT] - Do not use direct I/O since it limits read/write operations to 64 MB CORE-8410 #resolve Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] Tue Aug 26 13:41:57 2014 @@ -442,8 +442,7 @@ goto ByeBye; } - DeviceObject->Flags = DeviceObject->Flags | DO_DIRECT_IO; - DeviceExt = (PVOID) DeviceObject->DeviceExtension; + DeviceExt = DeviceObject->DeviceExtension; RtlZeroMemory(DeviceExt, ROUND_UP(sizeof(DEVICE_EXTENSION), sizeof(ULONG)) + sizeof(HASHENTRY*) * HashTableSize); DeviceExt->FcbHashTable = (HASHENTRY**)((ULONG_PTR)DeviceExt + ROUND_UP(sizeof(DEVICE_EXTENSION), sizeof(ULONG))); DeviceExt->HashTableSize = HashTableSize;

10 years, 2 months

mplay translation

by Javier Agustìn Fernàndez Arroyo

hello folks, i have just updated the spanish translatiuon of mplay. Its here: https://jira.reactos.org/browse/CORE-8470 Enjoy! :)

10 years, 2 months

Re: [ros-dev] [ros-diffs] [tfaber] 63928: [FASTFAT] - Properly handle errors in CcInitializeCacheMap, CcCopyRead and CcCopyWrite CORE-8410

by Jérôme Gardou

Hey Thomas I think that you want to use _SEH2_YIELD in a few places here, that is, unless we want to completely ditch pseh2 in favor of pseh3 ;-) Regards Jérôme Le 24/08/2014 05:28, tfaber(a)svn.reactos.org a écrit : > Author: tfaber > Date: Sun Aug 24 03:28:01 2014 > New Revision: 63928 > > URL: http://svn.reactos.org/svn/reactos?rev=63928&view=rev > Log: > [FASTFAT] > - Properly handle errors in CcInitializeCacheMap, CcCopyRead and CcCopyWrite > CORE-8410 > > Modified: > trunk/reactos/drivers/filesystems/fastfat/CMakeLists.txt > trunk/reactos/drivers/filesystems/fastfat/fcb.c > trunk/reactos/drivers/filesystems/fastfat/fsctl.c > trunk/reactos/drivers/filesystems/fastfat/rw.c > trunk/reactos/drivers/filesystems/fastfat/vfat.h > > Modified: trunk/reactos/drivers/filesystems/fastfat/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fastfat/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fastfat/CMakeLists.txt [iso-8859-1] Sun Aug 24 03:28:01 2014 > @@ -26,6 +26,7 @@ > add_library(fastfat SHARED ${SOURCE} vfatfs.rc) > > set_module_type(fastfat kernelmodedriver) > +target_link_libraries(fastfat ${PSEH_LIB}) > add_importlibs(fastfat ntoskrnl hal) > > add_pch(fastfat vfat.h SOURCE) > > Modified: trunk/reactos/drivers/filesystems/fastfat/fcb.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fastfat/fcb.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fastfat/fcb.c [iso-8859-1] Sun Aug 24 03:28:01 2014 > @@ -340,12 +340,14 @@ > { > PFILE_OBJECT fileObject; > PVFATCCB newCCB; > + NTSTATUS status; > > fileObject = IoCreateStreamFileObject (NULL, vcb->StorageDevice); > > newCCB = ExAllocateFromNPagedLookasideList(&VfatGlobalData->CcbLookasideList); > if (newCCB == NULL) > { > + ObDereferenceObject(fileObject); > return STATUS_INSUFFICIENT_RESOURCES; > } > RtlZeroMemory(newCCB, sizeof (VFATCCB)); > @@ -356,11 +358,24 @@ > fcb->FileObject = fileObject; > fcb->RefCount++; > > - CcInitializeCacheMap(fileObject, > - (PCC_FILE_SIZES)(&fcb->RFCB.AllocationSize), > - TRUE, > - &VfatGlobalData->CacheMgrCallbacks, > - fcb); > + _SEH2_TRY > + { > + CcInitializeCacheMap(fileObject, > + (PCC_FILE_SIZES)(&fcb->RFCB.AllocationSize), > + TRUE, > + &VfatGlobalData->CacheMgrCallbacks, > + fcb); > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + status = _SEH2_GetExceptionCode(); > + fcb->RefCount--; > + fcb->FileObject = NULL; > + ExFreeToNPagedLookasideList(&VfatGlobalData->CcbLookasideList, newCCB); > + ObDereferenceObject(fileObject); > + return status; > + } > + _SEH2_END; > > fcb->Flags |= FCB_CACHE_INITIALIZED; > return STATUS_SUCCESS; > > Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] Sun Aug 24 03:28:01 2014 > @@ -550,11 +550,20 @@ > Fcb->RFCB.ValidDataLength = Fcb->RFCB.FileSize; > Fcb->RFCB.AllocationSize = Fcb->RFCB.FileSize; > > - CcInitializeCacheMap(DeviceExt->FATFileObject, > - (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize), > - TRUE, > - &VfatGlobalData->CacheMgrCallbacks, > - Fcb); > + _SEH2_TRY > + { > + CcInitializeCacheMap(DeviceExt->FATFileObject, > + (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize), > + TRUE, > + &VfatGlobalData->CacheMgrCallbacks, > + Fcb); > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + Status = _SEH2_GetExceptionCode(); > + goto ByeBye; > + } > + _SEH2_END; > > DeviceExt->LastAvailableCluster = 2; > ExInitializeResourceLite(&DeviceExt->FatResource); > > Modified: trunk/reactos/drivers/filesystems/fastfat/rw.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fastfat/rw.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fastfat/rw.c [iso-8859-1] Sun Aug 24 03:28:01 2014 > @@ -673,22 +673,35 @@ > Status = /*STATUS_END_OF_FILE*/STATUS_SUCCESS; > } > > - if (IrpContext->FileObject->PrivateCacheMap == NULL) > - { > - CcInitializeCacheMap(IrpContext->FileObject, > - (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize), > - FALSE, > - &(VfatGlobalData->CacheMgrCallbacks), > - Fcb); > - } > - > - if (!CcCopyRead(IrpContext->FileObject, &ByteOffset, Length, > - (BOOLEAN)(IrpContext->Flags & IRPCONTEXT_CANWAIT), Buffer, > - &IrpContext->Irp->IoStatus)) > - { > - Status = STATUS_PENDING; > - goto ByeBye; > - } > + _SEH2_TRY > + { > + if (IrpContext->FileObject->PrivateCacheMap == NULL) > + { > + CcInitializeCacheMap(IrpContext->FileObject, > + (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize), > + FALSE, > + &(VfatGlobalData->CacheMgrCallbacks), > + Fcb); > + } > + > + if (!CcCopyRead(IrpContext->FileObject, > + &ByteOffset, > + Length, > + (IrpContext->Flags & IRPCONTEXT_CANWAIT) != 0, > + Buffer, > + &IrpContext->Irp->IoStatus)) > + { > + ASSERT((IrpContext->Flags & IRPCONTEXT_CANWAIT) == 0); > + Status = STATUS_PENDING; > + goto ByeBye; > + } > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + Status = _SEH2_GetExceptionCode(); > + goto ByeBye; > + } > + _SEH2_END; > > if (!NT_SUCCESS(IrpContext->Irp->IoStatus.Status)) > { > @@ -947,30 +960,42 @@ > { > // cached write > > - if (IrpContext->FileObject->PrivateCacheMap == NULL) > - { > - CcInitializeCacheMap(IrpContext->FileObject, > - (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize), > - FALSE, > - &VfatGlobalData->CacheMgrCallbacks, > - Fcb); > - } > - > - if (ByteOffset.QuadPart > OldFileSize.QuadPart) > - { > - CcZeroData(IrpContext->FileObject, &OldFileSize, &ByteOffset, TRUE); > - } > - > - if (CcCopyWrite(IrpContext->FileObject, &ByteOffset, Length, > - 1 /*IrpContext->Flags & IRPCONTEXT_CANWAIT*/, Buffer)) > - { > - IrpContext->Irp->IoStatus.Information = Length; > - Status = STATUS_SUCCESS; > - } > - else > - { > - Status = STATUS_UNSUCCESSFUL; > - } > + _SEH2_TRY > + { > + if (IrpContext->FileObject->PrivateCacheMap == NULL) > + { > + CcInitializeCacheMap(IrpContext->FileObject, > + (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize), > + FALSE, > + &VfatGlobalData->CacheMgrCallbacks, > + Fcb); > + } > + > + if (ByteOffset.QuadPart > OldFileSize.QuadPart) > + { > + CcZeroData(IrpContext->FileObject, &OldFileSize, &ByteOffset, TRUE); > + } > + > + if (CcCopyWrite(IrpContext->FileObject, > + &ByteOffset, > + Length, > + TRUE /*(IrpContext->Flags & IRPCONTEXT_CANWAIT) != 0*/, > + Buffer)) > + { > + IrpContext->Irp->IoStatus.Information = Length; > + Status = STATUS_SUCCESS; > + } > + else > + { > + ASSERT(FALSE /*(IrpContext->Flags & IRPCONTEXT_CANWAIT) == 0*/); > + Status = STATUS_UNSUCCESSFUL; > + } > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + Status = _SEH2_GetExceptionCode(); > + } > + _SEH2_END; > } > else > { > > Modified: trunk/reactos/drivers/filesystems/fastfat/vfat.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fastfat/vfat.h [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fastfat/vfat.h [iso-8859-1] Sun Aug 24 03:28:01 2014 > @@ -4,6 +4,7 @@ > #include <ntifs.h> > #include <ntdddisk.h> > #include <dos.h> > +#include <pseh/pseh2.h> > > #define USE_ROS_CC_AND_FS > > >

10 years, 2 months

Re: [ros-dev] [ros-diffs] [jgardou] 63933: [WIN32K] - Enable commented freetype call: set font face size and coordinate transformation matrix Patch by Huw Campbell, reviewed by a gazillion of people. CORE-4657 #resolve #com...

by Thomas Faber

On 2014-08-24 15:28, jgardou(a)svn.reactos.org wrote: > -// FT_Set_Pixel_Sizes(ft_face, > -// TextObj->logfont.elfEnumLogfontEx.elfLogFont.lfWidth, > + FT_Set_Pixel_Sizes(ft_face, > + TextObj->logfont.elfEnumLogfontEx.elfLogFont.lfWidth, The abs() was added in the second version of the patch because this way it breaks tests. See https://jira.reactos.org/browse/CORE-4657?focusedCommentId=60379&page=com.a…

10 years, 2 months

Re: [ros-dev] [ros-diffs] [hbelusca] 63940: [MPLAY32] Implement a single-window mode for videos. Patch by Ricardo Hanke. TO ALL TRANSLATORS: Update the translations! CORE-7910 #resolve #comment Committed, thanks!

by Thomas Faber

On 2014-08-24 17:40, hbelusca(a)svn.reactos.org wrote: > + mciSendCommand(wDeviceId, MCI_PUT, MCI_DGV_PUT_DESTINATION | MCI_DGV_RECT | MCI_WAIT, (DWORD)&mciPut); A DWORD cannot fit a pointer. This function takes DWORD_PTR.

10 years, 2 months

Re: [ros-dev] [ros-diffs] [hbelusca] 63885: [KERNEL32] OpenConsoleW was implemented :P [CONSOLE.CPL][CONSRV] Create all the fonts needed at console startup, and then just select what's needed when fonts attributes need to b...

by Thomas Faber

On 2014-08-14 22:10, hbelusca(a)svn.reactos.org wrote: > + if (FaceName != GuiData->GuiInfo.FaceName) > + { > + SIZE_T Length = min(wcslen(FaceName) + 1, LF_FACESIZE); // wcsnlen > + wcsncpy(GuiData->GuiInfo.FaceName, FaceName, LF_FACESIZE); > + GuiData->GuiInfo.FaceName[Length] = L'\0'; // NULL-terminate > + } Buffer overflow. You mean [Length - 1]

10 years, 3 months

On the server outage

by Colin Finck

Dear all, As you've certainly noticed, one of our main servers providing the www.reactos.org website along with JIRA and FishEye was down yesterday. Problems began yesterday around 13:00 UTC and lasted till some minutes ago. This has happened due to a severe hardware failure on the hypervisor machine serving the affected VMs. Our hosting provider needed two attempts to find and replace the failed hardware. Finally, the crash has caused one database table to get corrupted. This one was repaired just now. No data has been lost though. All services should be up again now. If you still notice anything not working, please report to me. We're sorry for the caused inconveniences! Best regards, -- Colin Finck System & Network Administrator ReactOS Deutschland e.V.

10 years, 3 months

Introducing ReactOS development accounts

by Colin Finck

TL;DR ===== Your SVN account == "ReactOS development account", because it will be used for more services than just SVN. You can now change the password on your own at https://lam.reactos.org Hi all, I've been trying to centralize our user accounts for some time now and finally have something to show. Your known SVN credentials have been imported into an LDAP-based user directory now. This gives us the ability to easily plug various services for developers into the directory: SVN, BuildBot, the participant list for meetings, especially the upcoming services like Mumble, development VMs and file sharing. You can view your account details and change your password on your own now. Just visit https://lam.reactos.org to do so. The E-Mail address shown there will be used e.g. for sending meeting invitations. As we all want the migration to go flawlessy, I've set up a temporary SVN repository at svn://svn.reactos.org/sasltest This should work just like our "reactos" repository: If you have write access there, you have write access in "sasltest" as well. It already works well for me and my SVN client, but I want confirmations from others too. Please do so by committing some junk into sasltest :) We have some members, who don't have SVN write access but participate in the monthly meetings. They will shortly receive an E-Mail with their account details. That doesn't give you SVN write access though, it's just for participating in the meetings for now :P I'll keep you informed when we finally plug our main repositories into the LDAP database. Note that this doesn't change anything with the ReactOS Website accounts and IServ mail accounts. Former ones will always be in a separate database as everybody can sign up there. Cheers, Colin

10 years, 3 months

Re: [ros-dev] [ros-diffs] [dgorbachev] 63823: [NTOSKRNL][PSEH3] - Add inline asm dependencies to fix undefined reference errors when building with link-time optimization. - Improve formatting. - No functional changes.

by Timo Kreuzer

Am 07.08.2014 01:10, schrieb dgorbachev(a)svn.reactos.org: > - : "m" (*(_TrylevelFrame)), "m" (*(_DataTable)), "c"(__builtin_alloca(0)) \ > + : "m" (*(_TrylevelFrame)), "m" (*(_DataTable)), "c" (__builtin_alloca(0)), "p" (_SEH3$_RegisterFrameWithNonVolatiles) \ What's this? Was that intentional? Timo

10 years, 3 months

Re: [ros-dev] [ros-diffs] [hbelusca] 63803: [KERNEL32] Add a bunch of missing _SEH_YIELD in 'return' clues in _SEH_TRY clauses. [KERNEL32][CONSRV] Make kernel32 / winsrv console CSR structures Win2k3-compliant for Read/Writ...

by Thomas Faber

On 2014-08-04 18:25, hbelusca(a)svn.reactos.org wrote: > [KERNEL32] > Add a bunch of missing _SEH_YIELD in 'return' clues in _SEH_TRY clauses. That should be pointless with PSEH3. I believe Timo has in fact been removing them.

10 years, 3 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev August 2014