Ros-dev November 2015

ros-dev@reactos.org

13 participants
7 discussions

Status Meeting (November 2015)

by Aleksey Bragin

Hello, Let me invite you to the monthly status meeting taking place last Thursday of a month, 26th of November, 19:00 UTC, as usual. IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. Please send agenda proposals to me before the meeting. Regards, Aleksey Bragin

9 years

Patch situation

by Robert Naumann

Hey all. I have some thoughts about our current patch situation. After the last big strike regarding patches, which was around the Hackfest, The count of them increased amazingly. We got some new contributers, this year, which do a great work. Some of our old contributers are still hacking like fire and mostly this are small fixes with big impact. Easy to review. I summed up some of them, to show which could get some attention. There are also bigger patches, which would need a coordinated review, but add very nice features (Swyters vbox fix for example). I am sure that about 10 of them could make it. Patches that are currently under review or active development ============================================================= The following patches are the ones, which actually got some attention. They all are slightly bigger ones. CORE-10533 PATCH: Fix local network resolving CORE-10440 PATCH: Fix issues of ws2_32_new CORE-10367 Implement apphelp sdb layer (More or less) simple patches, that would be nice2have for 0.4 ============================================================== These are all the patches from our actual most active contributers. Most of them are very small and easy to understand. Let's not forget them because contributers can become developers, which we need so badly. It would be nice to have them in trunk before release, if they are correct. CORE-10550 clipbrd: Load the clipboard contents from a file CORE-10476 Add a placeholder machine owner at second stage installer to improve UX CORE-10438 [shell32] 'Empty Recycle Bin' should be disabled when no items are present CORE-10437 [console] Add missing DS_MODALFRAME CORE-10436 [shell32] OK button in run dialog should be disabled by default CORE-10410 [fdebug] Manifest and application title CORE-10393 [RAPPS] Small Database Update CORE-10310 Automatically format file size & assorted fixes for apps CORE-9721 [notepad] Let the user know when an opened file is modified CORE-9959 shell32: patch for SHFileOperation (delete-operation) CORE-6742 Can't dynamically change the resolution by resizing in VirtualBox Hacks(?) that would improve the look and feel in 0.4 ==================================================== These patches contain hacks but it would be nice to have them in release. I don't mean to apply them to trunk, but to the 0.4 branch. Important is that, if this happens, enough regression testing is done. CORE-9654 PATCH +Bugfix: UXTHEME draw text with shadows, fix GetThemeSysColor CORE-9533 Title icons are 32pixel downsized to 16pixel CORE-5644 mspaint: selection border isn't visible CORE-9689 Drive's properties theming problem CORE-8925 Start menu has classic border when themes are enabled Drive Type related patches ========================== The author of these patches did some effort to fix the bug, which shows the correct icon for specific drives. I feel like I saw more than this 2 patches but I am not sure and don't find more. We should collaborate with him and take care of this annoying bug, CORE-10221 Fix icons in My Computer CORE-9622 Improvement to GetDriveType() Function Victor's Patches ================ These patches are from Victor M. Calvo. He did a big effort to fix bugs, which affect specifig apps and caused registry curruption. He also proved his patches with apitests but almost nothing happened with the patches. CORE-9673 PATCH: BS_DIBPATTERN8x8 not supported CORE-9672 PATCH: Rewrite RegQueryInfoKeyW CORE-9666 PATCH: RegQueryValueExW fails to set properly the REG_NONE type CORE-9665 PATCH: RegQueryValueExW and RegQueryValueExA calls accept bytes not chars. CORE-9398 PATCH: Several fixes for SetupInstallServicesFromInfSectionExW CORE-8164 Fix a interexchanging values in Vga driver CORE-8157 Fix a memcpy in Dhcpclient using the length in bytes. CORE-8156 Fix a sanity check of a returned ConstructBitBlob CORE-8077 GetDiskFreeSpaceW fixes CORE-8076 SetVolumeLabelW and GetVolumeInformationW fixes Cheers Robert

9 years, 1 month

Re: [ros-dev] [ros-diffs] [hbelusca] 69936: [USER32] Implement now-documented MB_GetString. See: https://msdn.microsoft.com/en-us/library/windows/desktop/dn910915(v=vs.85).aspx and: http://undoc.airesoft.co.uk/user32.dll/MB...

by Michael Fritscher

Hi, > + > + /* The allowable IDs are between IDOK (0) and IDCONTINUE (11) > inclusive */ > + if (wBtn >= IDCONTINUE) > + return NULL; > + > + LoadStringW(User32Instance, wBtn, (LPWSTR)&btnStr, 0); > + return btnStr; If IDCONTINUE is inclusive then the check in the next line should be >, shouldn't it? Best regards, Michael

9 years, 1 month

Re: [ros-dev] [ros-diffs] [hbelusca] 69935: [USER32] MessageBoxIndirect fixes by Carlo Bramini: - Implemented loading of text and caption if they are detected as resource IDs. - Use direct resource string pointers with Load...

by Thomas Faber

Mixing formatting changes, changes that should and changes that shouldn't affect behavior, and making indentation inconsistent in the progress is my favorite. :\ On 2015-11-19 00:46, hbelusca(a)svn.reactos.org wrote: > Author: hbelusca > Date: Wed Nov 18 23:46:38 2015 > New Revision: 69935 > > URL: http://svn.reactos.org/svn/reactos?rev=69935&view=rev > Log: > [USER32] > MessageBoxIndirect fixes by Carlo Bramini: > - Implemented loading of text and caption if they are detected as resource IDs. > - Use direct resource string pointers with LoadStringW and use the returned string length. > - Dramatically improve the implementation of ID and resource string assignments, by using a little look up table. This removes some ugly, difficult to maintain copy-paste code. > - Fix the scaling of logical coordinates by making it aware of rounding, i.e. the size of the controls is now calculated correctly. > CORE-10352 #resolve #comment Thank you for the patch! :D

9 years, 1 month

Infrastructure problems today

by Colin Finck

Hi all, We suffered from several Infrastructure problems in one of our datacenters today, with the cause that multiple servers were temporarily unreachable. All problems should be finally fixed now though. If you still encounter related problems, please reply to my mail. Cheers, Colin

9 years, 1 month

Re: [ros-dev] [ros-diffs] [gedmurphy] 69650: The c++ bool is 1 byte, not 4. Thanks Thomas

by Timo Kreuzer

In fact in this case it wouldn't make a difference, since the bool would be converted to a LONG. But using TRUE/FALSE seems to be appropriate here. Am 22.10.2015 um 19:37 schrieb gedmurphy(a)svn.reactos.org: > Author: gedmurphy > Date: Thu Oct 22 17:37:51 2015 > New Revision: 69650 > > URL: http://svn.reactos.org/svn/reactos?rev=69650&view=rev > Log: > The c++ bool is 1 byte, not 4. Thanks Thomas > > Modified: > trunk/reactos/dll/win32/devmgr/devmgmt/MainWindow.cpp > trunk/reactos/dll/win32/devmgr/devmgmt/MainWindow.h > > Modified: trunk/reactos/dll/win32/devmgr/devmgmt/MainWindow.cpp > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/devmgr/devmgmt/M… > ============================================================================== > --- trunk/reactos/dll/win32/devmgr/devmgmt/MainWindow.cpp [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/devmgr/devmgmt/MainWindow.cpp [iso-8859-1] Thu Oct 22 17:37:51 2015 > @@ -786,7 +786,7 @@ > // we set a timer to run in 500ms, which should leave enough time for all > // the messages to come through. Wrap so we don't set multiple timers > // > - if (InterlockedCompareExchange((LONG *)&This->m_RefreshPending, true, false) == false) > + if (InterlockedCompareExchange((LONG *)&This->m_RefreshPending, TRUE, FALSE) == FALSE) > { > SetTimer(hwnd, REFRESH_TIMER, 500, NULL); > } > @@ -807,7 +807,7 @@ > KillTimer(hwnd, REFRESH_TIMER); > > // Allow more change notifications > - InterlockedExchange((LONG *)&This->m_RefreshPending, false); > + InterlockedExchange((LONG *)&This->m_RefreshPending, FALSE); > } > break; > } > > Modified: trunk/reactos/dll/win32/devmgr/devmgmt/MainWindow.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/devmgr/devmgmt/M… > ============================================================================== > --- trunk/reactos/dll/win32/devmgr/devmgmt/MainWindow.h [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/devmgr/devmgmt/MainWindow.h [iso-8859-1] Thu Oct 22 17:37:51 2015 > @@ -17,7 +17,7 @@ > HMENU m_hMenu; > HMENU m_hActionMenu; > int m_CmdShow; > - bool m_RefreshPending; > + BOOL m_RefreshPending; > > public: > CDeviceManager(void); > > >

9 years, 1 month

Files in press-media repository

by Colin Finck

Hi all, After Victor's commit of so many files to our press-media repository, I think we should establish some binding rules for it: * There is no need to have a single file in X different formats in the repository. Let's only keep it there in the best format. In particular, that means: Vector formats > Dynamic raster formats > Static raster formats E.g.: AI/SVG > PSD/TIFF > PNG The only exception to the rule can be made if one of the better formats is highly proprietary (like AI). In that case, an additional SVG file or (as a last resort) high-resolution PNG file may accompany it. I don't consider PSD proprietary anymore, because almost every Open-Source and Closed-Source graphics tool can work with them. Totally uncompressed formats (like BMP) have no reason to stay in the repository at all when better compressed formats (like PNG) are available. I would make the only exception to e.g. the BIOS logo for the MiniPC, because this one needs to be a BMP with special settings for technical reasons. * Only directly ReactOS-related media whose copyright is clarified should go there. Third-party graphics can pose a serious legal trouble. Additionally, Stock graphics can be found on many platforms. There is no need to let press-media become a repository for this. As long as there are no objections or additions, I would like Victor to remove some redundant files according to these rules. Cheers, Colin

9 years, 1 month

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev November 2015