Hi,
The names for our builders / testers don't seem to be optimal to me. And
since they seem to be sorted in the waterfall display alphabetically
now, I suggest renaming them in the following way:
Build_GCCLin_Debug
Build_GCCLin_Release
Build_GCCWin
Build_MSVC_x64
Build_MSVC_x86
Test_KVM
Test_VBox
Test_VMW
Test_VMW_Hybrid
Test_WHS
This way it is much more consistent, limited to actually useful
information and would sort them nicely with builders left and testers right.
Regards,
Timo
Hey guys,
as some of you might have seen already we now have two copies of the more and more increasing RAPPS DB in trunk. This is:
a) Absolutely unnecessary and does only result in one thing, two differing DBs
b) Shows even more that it’s not useful to have it in trunk at all.
Because of this I start a vote now to get your opinion in completely removing the RAPPS DB from trunk into a subtree like done for many other things, too.
What do you think?
Greetings
Daniel Reimer
Gesendet von Windows Mail
Interesting that the wine code doesn't check for NULL at HeapAlloc at all
- could these be submitted to wine?
Additionally, at least one HeapAlloc isn't checked also in our build:
piDx = HeapAlloc(GetProcessHeap(),0,sizeof(INT) * (*count));
Perhaps a
#ifdef __REACTOS__
if (piDx == NULL)
{
return FALSE; //Not sure about this, just looked at the diff ;)
}
#endif
would be usefull there.
Best regards,
Michael Fritscher
> Author: akhaldi
> Date: Sat May 30 17:14:16 2015
> New Revision: 67974
>
> URL: http://svn.reactos.org/svn/reactos?rev=67974&view=rev
> Log:
> [USER32] Sync edit.c with Wine Staging 1.7.37. CORE-9246
>
> Modified:
> trunk/reactos/media/doc/README.WINE
> trunk/reactos/win32ss/user/user32/controls/edit.c
>
That's a bit** of a hack. Either the code holds a reference and needs to release it or not. cLockObj is a private field and code outside of UserReference* should not be allowed to access it.
Thanks!
-Thomas
** actually it's a pretty big hack
On May 28, 2015 12:13:03 AM CEST, jimtabor(a)svn.reactos.org wrote:
>Author: jimtabor
>Date: Wed May 27 22:13:03 2015
>New Revision: 67937
>
>URL: http://svn.reactos.org/svn/reactos?rev=67937&view=rev
>Log:
>[NtUser]
>- De-reference global cursor. See CORE-8305.
>
>Modified:
> trunk/reactos/win32ss/user/ntuser/cursoricon.c
>
>Modified: trunk/reactos/win32ss/user/ntuser/cursoricon.c
>URL:
>http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/cursor…
>==============================================================================
>--- trunk/reactos/win32ss/user/ntuser/cursoricon.c [iso-8859-1]
>(original)
>+++ trunk/reactos/win32ss/user/ntuser/cursoricon.c [iso-8859-1] Wed May
>27 22:13:03 2015
>@@ -1077,6 +1077,12 @@
> if (pcurOld->CURSORF_flags & CURSORF_GLOBAL)
> {
> TRACE("Returning Global Cursor hcur %p\n",hOldCursor);
>+
>+ if (pcurOld->head.cLockObj > 2) // Throttle down to 2.
>+ {
>+ UserDereferenceObject(pcurOld);
>+ }
>+
> goto leave;
> }
>
--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
Hello,
Let me invite you to the monthly status meeting taking place 28th of
May, 19:00 UTC, as always.
IRC service will only be started shortly before the meeting. Your
participation passwords and server address will be emailed to you
shortly before the meeting starts, and they are going to be different
once again as they are not stored in any database. Hopefully it's not
much of inconvenience.
Please send agenda proposals to me before the meeting, so that we can
start with a proposed agenda.
Regards,
Aleksey Bragin
Hi guys!
After a week dealing with several scripts and options, we're finally integrating the most important info from Reactos.org and Community.reactos.org directly to our Social channels to keep a constant flow of updates to our followers.
Since now our ReactOS Facebook and ReactOS Twitter will be automatically updated when...
... A Jira bugreport is resolved with a 'Fixed' and 'Cannot reproduce' status.
... A blog post is published in "ReactOS.org"
... A blog post is published in "Community.ReactOS.org"
Some of the features:
- Updates are queued and published with a time gap between them, so in case, eg, a Tester/Dev runs a Spring Cleanup, we won't be publishing 10 Jira reports in the same minute.
- Facebook and Twitter updates include pictures in case the blog post or the Jira report has one. So please add a picture in case you're blogging even if it is just a screenshot of you running "whatever" in ReactOS.
- Includes #hashtags related to the current Jira/Blog report.
- Uses bit.ly shortener when needed.
- And several hidden Easter Eggs in Twitter...(I was bored in the train)
If you've any suggestions about other potential updates to be sent to our Social Channels, just tell me and I'd try to integrate them in an automated way.
I'm planning a way to ease and have community contributions filtered and joining the automated flow, but it'll have to wait until I master Drupal. Also I'm working in some "crossposting" among our Social Channels, so a direct post in Facebook not coming from our PR Update System is replicated in Twitter and the other way around.
We can be really proud of the current PR Update system implemented, since probably it even beats several bigger opensource projects and/or companies out there.
If you didn't join our Twitter or Facebook yet, please feel free to join:
- Facebook: https://www.facebook.com/pages/ReactOS/19143619259
- Twitter: http://www.twitter.com/reactos
Brought to you by the ReactOS PR Team.