Ros-dev May 2015

ros-dev@reactos.org

19 participants
21 discussions

#ReactOS in OpenExpo'15 (Madrid) and other PR stuff
by victor martinez 14 Aug '15

14 Aug '15

Hi guys!I'm proud to confirm that ReactOS project will be shown in OpenExpo'15 in Madrid, 16th June.OpenExpo is one of the greatest open source events in Spain: http://www.openexpo.esWe'll have the opportunity to give a Talk plus some Hacking lab (wish me good luck!). If anyone wants to come, I've one additional free pass. On the other hand, the open source 2/OS project is pushing forward through some Latam guys:https://plus.google.com/112666045931562995118/posts/6k1Xw2yXB7MSeems they're using ReactOS code in their project according with their tweets:https://twitter.com/2osproject/status/578135968219267072(Translation: We're using code of reactos.org and winehq.org, we have had to interact with networking stack with ROS using JAVA)Using Java??? And they seemed to have some issues with ReactOS code:http://twitter.com/2osproject/status/592291632004882433 Keep rockin'!

6 8

Name of builders/testers in buildbot
by Timo Kreuzer 14 Jun '15

14 Jun '15

Hi, The names for our builders / testers don't seem to be optimal to me. And since they seem to be sorted in the waterfall display alphabetically now, I suggest renaming them in the following way: Build_GCCLin_Debug Build_GCCLin_Release Build_GCCWin Build_MSVC_x64 Build_MSVC_x86 Test_KVM Test_VBox Test_VMW Test_VMW_Hybrid Test_WHS This way it is much more consistent, limited to actually useful information and would sort them nicely with builders left and testers right. Regards, Timo

4 4

Vote for removing rapps DB from trunk
by daniel.reimer＠reactos.org 01 Jun '15

01 Jun '15

Hey guys, as some of you might have seen already we now have two copies of the more and more increasing RAPPS DB in trunk. This is: a) Absolutely unnecessary and does only result in one thing, two differing DBs b) Shows even more that it’s not useful to have it in trunk at all. Because of this I start a vote now to get your opinion in completely removing the RAPPS DB from trunk into a subtree like done for many other things, too. What do you think? Greetings Daniel Reimer Gesendet von Windows Mail

4 3

Re: [ros-dev] [ros-diffs] [dquintana] 67976: [DEVMGMT_NEW] At the request of Christoph von Wittich, bring devmgmt_new into the build. * Created CMakeLists.txt and added to parent folder. * Removed some references to CAtlStr...
by Ged Murphy 01 Jun '15

01 Jun '15

Eeek, I was working on this via VS and have quite a few changes in my WC, including CAtlString support for our ATL lib... -----Original Message----- From: Ros-diffs [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dquintana(a)svn.reactos.org Sent: 30 May 2015 20:54 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dquintana] 67976: [DEVMGMT_NEW] At the request of Christoph von Wittich, bring devmgmt_new into the build. * Created CMakeLists.txt and added to parent folder. * Removed some references to CAtlStr... Author: dquintana Date: Sat May 30 19:53:44 2015 New Revision: 67976 URL: http://svn.reactos.org/svn/reactos?rev=67976&view=rev Log: [DEVMGMT_NEW] At the request of Christoph von Wittich, bring devmgmt_new into the build. * Created CMakeLists.txt and added to parent folder. * Removed some references to CAtlString that were not needed and are not implemented in our headers. * Fixed build with gcc. * Spread all the changes done to the english resources to the other languages. Many languages now contain untranslated strings that will need to be fixed. Note that I made no effort to fix any bugs or improve any features. The app comes as-is, except it now builds with rosbe. Added: trunk/reactos/base/applications/mscutils/devmgmt_new/CMakeLists.txt (with props) trunk/reactos/base/applications/mscutils/devmgmt_new/precomp.h - copied, changed from r67940, trunk/reactos/base/applications/mscutils/devmgmt_new/stdafx.h trunk/reactos/base/applications/mscutils/devmgmt_new/resource.h - copied unchanged from r67940, trunk/reactos/base/applications/mscutils/devmgmt_new/Resource.h Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/Resource.h trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt.exe.manifest trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt.h trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt_new.sln trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt_new.vcxproj trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt_new.vcxproj.filters trunk/reactos/base/applications/mscutils/devmgmt_new/rsrc.rc trunk/reactos/base/applications/mscutils/devmgmt_new/stdafx.cpp trunk/reactos/base/applications/mscutils/devmgmt_new/stdafx.h trunk/reactos/base/applications/mscutils/devmgmt_new/targetver.h Modified: trunk/reactos/base/applications/mscutils/CMakeLists.txt trunk/reactos/base/applications/mscutils/devmgmt_new/DeviceView.cpp trunk/reactos/base/applications/mscutils/devmgmt_new/DeviceView.h trunk/reactos/base/applications/mscutils/devmgmt_new/Devices.cpp trunk/reactos/base/applications/mscutils/devmgmt_new/MainWindow.cpp trunk/reactos/base/applications/mscutils/devmgmt_new/MainWindow.h trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt.cpp trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/bg-BG.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/de-DE.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/el-GR.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/en-US.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/es-ES.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/fr-FR.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/he-IL.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/id-ID.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/it-IT.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ja-JP.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ko-KR.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/no-NO.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/pl-PL.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/pt-BR.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ro-RO.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ru-RU.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/sk-SK.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/sq-AL.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/sv-SE.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/th-TH.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/tr-TR.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/uk-UA.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/zh-CN.rc [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/base/applications/mscutils/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Added: trunk/reactos/base/applications/mscutils/devmgmt_new/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/DeviceView.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/DeviceView.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/Devices.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/MainWindow.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/MainWindow.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/Resource.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt.exe.manifest URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt_new.sln URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt_new.vcxproj URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt_new.vcxproj.filters URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/bg-BG.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/el-GR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/en-US.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/es-ES.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/he-IL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/id-ID.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ja-JP.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ko-KR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/no-NO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/pl-PL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/pt-BR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/sk-SK.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/sq-AL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/sv-SE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/th-TH.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/zh-CN.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Copied: trunk/reactos/base/applications/mscutils/devmgmt_new/precomp.h (from r67940, trunk/reactos/base/applications/mscutils/devmgmt_new/stdafx.h) URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/rsrc.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/stdafx.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/stdafx.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/targetver.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils…

3 3

Re: [ros-dev] [ros-diffs] [cwittich] 67981: [DEVMGMT_NEW] enable/disable context menu items on selection change
by Ged Murphy 31 May '15

31 May '15

I also have all the code for this, but for choosing which icons to show in the toolbar. The context menu would have been able to use this code.... -----Original Message----- From: Ros-diffs [mailto:ros-diffs-bounces@reactos.org] On Behalf Of cwittich(a)svn.reactos.org Sent: 31 May 2015 10:15 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [cwittich] 67981: [DEVMGMT_NEW] enable/disable context menu items on selection change Author: cwittich Date: Sun May 31 09:14:29 2015 New Revision: 67981 URL: http://svn.reactos.org/svn/reactos?rev=67981&view=rev Log: [DEVMGMT_NEW] enable/disable context menu items on selection change Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/DeviceView.cpp trunk/reactos/base/applications/mscutils/devmgmt_new/DeviceView.h trunk/reactos/base/applications/mscutils/devmgmt_new/MainWindow.cpp Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/DeviceView.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/devmgmt_new/DeviceView.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/devmgmt_new/DeviceView.cpp [iso-8859-1] Sun May 31 09:14:29 2015 @@ -110,6 +110,30 @@ (VOID)m_Devices->Uninitialize(); return TRUE; +} + +BOOL CDeviceView::HasChildItem( + _In_ HTREEITEM Item) +{ + return (TreeView_GetChild(m_hTreeView, Item) != NULL); } + +BOOL CDeviceView::IsRootItem( + _In_ HTREEITEM Item) +{ + return (TreeView_GetRoot(m_hTreeView) == Item); } + +BOOL CDeviceView::IsRootItemSelected() +{ + return (TreeView_GetRoot(m_hTreeView) == +TreeView_GetSelection(m_hTreeView)); +} + +VOID CDeviceView::EnableContextMenuItem( + _In_ UINT Id, + _In_ UINT Enabled) +{ + EnableMenuItem(m_hShortcutMenu, Id, Enabled); } VOID Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/DeviceView.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/devmgmt_new/DeviceView.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/devmgmt_new/DeviceView.h [iso-8859-1] Sun May 31 09:14:29 2015 @@ -34,6 +34,11 @@ BOOL Initialize(); BOOL Uninitialize(); + VOID EnableContextMenuItem( + _In_ UINT Id, + _In_ UINT Enabled + ); + VOID ShowContextMenu( _In_ INT xPos, _In_ INT yPos @@ -49,12 +54,27 @@ VOID Refresh(); VOID DisplayPropertySheet(); VOID SetFocus(); - + + BOOL IsRootItemSelected(); + + BOOL IsRootItem( + _In_ HTREEITEM Item + ); + + BOOL HasChildItem( + _In_ HTREEITEM Item + ); + VOID SetDeviceListType(ListDevices List) { m_ListDevices = List; } + ListDevices GetDeviceListType() + { + return m_ListDevices; + } + VOID ShowHiddenDevices(_In_ BOOL ShowHidden) { m_ShowHidden = ShowHidden; Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/MainWindow.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/devmgmt_new/MainWindow.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/devmgmt_new/MainWindow.cpp [iso-8859-1] Sun May 31 09:14:29 2015 @@ -429,7 +429,61 @@ break; } - + + case TVN_SELCHANGED: + { + LPNM_TREEVIEW pnmtv = (LPNM_TREEVIEW)lParam; + ListDevices ListType = m_DeviceView->GetDeviceListType(); + + if (ListType == DevicesByType) + { + if (!m_DeviceView->HasChildItem(pnmtv->itemNew.hItem)) + { + SendMessage(m_hToolBar, + TB_SETSTATE, + IDC_PROP, + (LPARAM)MAKELONG(TBSTATE_ENABLED, 0)); + + EnableMenuItem(GetMenu(m_hMainWnd), IDC_PROP, MF_ENABLED); + m_DeviceView->EnableContextMenuItem(IDC_PROP, MF_ENABLED); + } + else + { + SendMessage(m_hToolBar, + TB_SETSTATE, + IDC_PROP, + (LPARAM)MAKELONG(TBSTATE_INDETERMINATE, + 0)); + + EnableMenuItem(GetMenu(m_hMainWnd), IDC_PROP, MF_GRAYED); + m_DeviceView->EnableContextMenuItem(IDC_PROP, MF_GRAYED); + } + } + else if (ListType == DevicesByConnection) + { + if (m_DeviceView->IsRootItem(pnmtv->itemNew.hItem)) + { + SendMessage(m_hToolBar, + TB_SETSTATE, + IDC_PROP, + (LPARAM)MAKELONG(TBSTATE_INDETERMINATE, + 0)); + + EnableMenuItem(GetMenu(m_hMainWnd), IDC_PROP, MF_GRAYED); + m_DeviceView->EnableContextMenuItem(IDC_PROP, MF_GRAYED); + } + else + { + SendMessage(m_hToolBar, + TB_SETSTATE, + IDC_PROP, + (LPARAM)MAKELONG(TBSTATE_ENABLED, 0)); + + EnableMenuItem(GetMenu(m_hMainWnd), IDC_PROP, MF_ENABLED); + m_DeviceView->EnableContextMenuItem(IDC_PROP, MF_ENABLED); + } + } + } + break; + case NM_DBLCLK: { m_DeviceView->DisplayPropertySheet(); @@ -438,7 +492,18 @@ case NM_RETURN: { - m_DeviceView->DisplayPropertySheet(); + ListDevices ListType = m_DeviceView->GetDeviceListType(); + if (ListType == DevicesByType) + { + m_DeviceView->DisplayPropertySheet(); + } + else if (ListType == DevicesByConnection) + { + if (!m_DeviceView->IsRootItemSelected()) + { + m_DeviceView->DisplayPropertySheet(); + } + } break; } }

1 0

Re: [ros-dev] [ros-diffs] [akhaldi] 67974: [USER32] Sync edit.c with Wine Staging 1.7.37. CORE-9246
by Michael Fritscher 30 May '15

30 May '15

Interesting that the wine code doesn't check for NULL at HeapAlloc at all - could these be submitted to wine? Additionally, at least one HeapAlloc isn't checked also in our build: piDx = HeapAlloc(GetProcessHeap(),0,sizeof(INT) * (*count)); Perhaps a #ifdef __REACTOS__ if (piDx == NULL) { return FALSE; //Not sure about this, just looked at the diff ;) } #endif would be usefull there. Best regards, Michael Fritscher > Author: akhaldi > Date: Sat May 30 17:14:16 2015 > New Revision: 67974 > > URL: http://svn.reactos.org/svn/reactos?rev=67974&view=rev > Log: > [USER32] Sync edit.c with Wine Staging 1.7.37. CORE-9246 > > Modified: > trunk/reactos/media/doc/README.WINE > trunk/reactos/win32ss/user/user32/controls/edit.c >

1 0

Re: [ros-dev] [ros-diffs] [jimtabor] 67937: [NtUser] - De-reference global cursor. See CORE-8305.
by Thomas Faber 29 May '15

29 May '15

That's a bit** of a hack. Either the code holds a reference and needs to release it or not. cLockObj is a private field and code outside of UserReference* should not be allowed to access it. Thanks! -Thomas ** actually it's a pretty big hack On May 28, 2015 12:13:03 AM CEST, jimtabor(a)svn.reactos.org wrote: >Author: jimtabor >Date: Wed May 27 22:13:03 2015 >New Revision: 67937 > >URL: http://svn.reactos.org/svn/reactos?rev=67937&view=rev >Log: >[NtUser] >- De-reference global cursor. See CORE-8305. > >Modified: > trunk/reactos/win32ss/user/ntuser/cursoricon.c > >Modified: trunk/reactos/win32ss/user/ntuser/cursoricon.c >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/cursor… >============================================================================== >--- trunk/reactos/win32ss/user/ntuser/cursoricon.c [iso-8859-1] >(original) >+++ trunk/reactos/win32ss/user/ntuser/cursoricon.c [iso-8859-1] Wed May >27 22:13:03 2015 >@@ -1077,6 +1077,12 @@ > if (pcurOld->CURSORF_flags & CURSORF_GLOBAL) > { > TRACE("Returning Global Cursor hcur %p\n",hOldCursor); >+ >+ if (pcurOld->head.cLockObj > 2) // Throttle down to 2. >+ { >+ UserDereferenceObject(pcurOld); >+ } >+ > goto leave; > } > -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.

2 1

Status Meeting (May 2015)
by Aleksey Bragin 28 May '15

28 May '15

Hello, Let me invite you to the monthly status meeting taking place 28th of May, 19:00 UTC, as always. IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. Please send agenda proposals to me before the meeting, so that we can start with a proposed agenda. Regards, Aleksey Bragin

5 7

Re: [ros-dev] [ros-diffs] [akhaldi] 67940: [TCPIP] Identify TCP/IP driver as version 4. By Lee Schroeder. CORE-9744
by Thomas Faber 28 May '15

28 May '15

> --- trunk/reactos/drivers/network/tcpip/tcpip.rc [iso-8859-1] (original) > +++ trunk/reactos/drivers/network/tcpip/tcpip.rc [iso-8859-1] Thu May 28 10:31:38 2015 > @@ -1,5 +1,5 @@ > #define REACTOS_VERSION_DLL > -#define REACTOS_STR_FILE_DESCRIPTION "TCP/IP protocol driver" > +#define REACTOS_STR_FILE_DESCRIPTION "TCP/IPv4 protocol driver" > #define REACTOS_STR_INTERNAL_NAME "tcpip" > #define REACTOS_STR_ORIGINAL_FILENAME "tcpip.sys" > #include <reactos/version.rc> This part makes no sense. tcpip.sys does both v4 and v6

1 0

ReactOS Updates flowing to our Social Channels.
by victor martinez 18 May '15

18 May '15

Hi guys! After a week dealing with several scripts and options, we're finally integrating the most important info from Reactos.org and Community.reactos.org directly to our Social channels to keep a constant flow of updates to our followers. Since now our ReactOS Facebook and ReactOS Twitter will be automatically updated when... ... A Jira bugreport is resolved with a 'Fixed' and 'Cannot reproduce' status. ... A blog post is published in "ReactOS.org" ... A blog post is published in "Community.ReactOS.org" Some of the features: - Updates are queued and published with a time gap between them, so in case, eg, a Tester/Dev runs a Spring Cleanup, we won't be publishing 10 Jira reports in the same minute. - Facebook and Twitter updates include pictures in case the blog post or the Jira report has one. So please add a picture in case you're blogging even if it is just a screenshot of you running "whatever" in ReactOS. - Includes #hashtags related to the current Jira/Blog report. - Uses bit.ly shortener when needed. - And several hidden Easter Eggs in Twitter...(I was bored in the train) If you've any suggestions about other potential updates to be sent to our Social Channels, just tell me and I'd try to integrate them in an automated way. I'm planning a way to ease and have community contributions filtered and joining the automated flow, but it'll have to wait until I master Drupal. Also I'm working in some "crossposting" among our Social Channels, so a direct post in Facebook not coming from our PR Update System is replicated in Twitter and the other way around. We can be really proud of the current PR Update system implemented, since probably it even beats several bigger opensource projects and/or companies out there. If you didn't join our Twitter or Facebook yet, please feel free to join: - Facebook: https://www.facebook.com/pages/ReactOS/19143619259 - Twitter: http://www.twitter.com/reactos Brought to you by the ReactOS PR Team.

3 7

Re: [ros-dev] [ros-diffs] [tkreuzer] 67718: [CRT] Add simple C implementations for acosf, ceilf, floorf, fmodf and fix sqrtf
by Thomas Faber 16 May '15

16 May '15

On 2015-05-14 15:44, tkreuzer(a)svn.reactos.org wrote: > +_Check_return_ > +float > +__cdecl > +ceilf( > +_In_ float x) > +{ > + return (float)ceilf((double)x); > +} > +_Check_return_ > +float > +__cdecl > +floorf( > +_In_ float x) > +{ > + return (float)floorf((double)x); > +} Did you mean to call ceil/floor here?

2 1

Re: [ros-dev] [ros-diffs] [tkreuzer] 67709: [D3DX9_36/WINED3D] - Remove useless copysignf invocation and the wrong defines for it - BrokenHacksOnTopOfBrokenCode--; - Should be sent upstream
by Thomas Faber 14 May '15

14 May '15

On 2015-05-14 06:00, tkreuzer(a)svn.reactos.org wrote: > - int sign = (copysignf(1, in) < 0); > + int sign = (in < 0); > - if (copysignf(1.0f, value) < 0.0f) > + if (value < 0.0f) > ++idx; I believe the behavior would be different here for negative zero: copysignf(1.0f, -0.0f) should be < 0.0f -0.0f should be == 0.0f Maybe that's the reason for having these calls?

3 3

Re: [ros-dev] [ros-diffs] [akhaldi] 67689: [CMAKE] The /SUBSYSTEM flag takes uppercase parameters.
by Timo Kreuzer 13 May '15

13 May '15

Can you please also add an approproate value for ARM (I guess win8)? :) Am 12.05.2015 um 14:18 schrieb akhaldi(a)svn.reactos.org: > Author: akhaldi > Date: Tue May 12 12:18:02 2015 > New Revision: 67689 > > URL: http://svn.reactos.org/svn/reactos?rev=67689&view=rev > Log: > [CMAKE] The /SUBSYSTEM flag takes uppercase parameters. > > Modified: > trunk/reactos/cmake/msvc.cmake > > Modified: trunk/reactos/cmake/msvc.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/msvc.cmake?rev=67689… > ============================================================================== > --- trunk/reactos/cmake/msvc.cmake [iso-8859-1] (original) > +++ trunk/reactos/cmake/msvc.cmake [iso-8859-1] Tue May 12 12:18:02 2015 > @@ -210,10 +210,11 @@ > endfunction() > > function(set_subsystem MODULE SUBSYSTEM) > + string(TOUPPER ${SUBSYSTEM} _subsystem) > if(ARCH STREQUAL "amd64") > - add_target_link_flags(${MODULE} "/SUBSYSTEM:${SUBSYSTEM},5.02") > - else() > - add_target_link_flags(${MODULE} "/SUBSYSTEM:${SUBSYSTEM},5.01") > + add_target_link_flags(${MODULE} "/SUBSYSTEM:${_subsystem},5.02") > + else() > + add_target_link_flags(${MODULE} "/SUBSYSTEM:${_subsystem},5.01") > endif() > endfunction() > > > >

1 0

Re: [ros-dev] [ros-diffs] [akhaldi] 67683: [SHELL32] Don't provide the format option when the volume is read only. By Barrett Karish. CORE-9530
by Thomas Faber 12 May '15

12 May '15

On 2015-05-12 06:57, akhaldi(a)svn.reactos.org wrote: > +/* FIXME: ntifs.h */ > +#define FILE_READ_ONLY_VOLUME 0x00080000 This should go in ndk/iotypes.h inside an NTOS_MODE_USER ifdef.

1 0

Fezile motherboard has finally failed
by Colin Finck 11 May '15

11 May '15

Hi all, Today, the motherboard in our Fezile server has finally failed after many hick-ups over the year. This causes an outage for the following services: * doxygen.reactos.org * cppcheck.reactos.org * VMware Player Test slave * VMware Player Patchbot As this is not the first time we struggle with such problems, iso.reactos.org is routed to a different server right now and not affected. We have already ordered replacement hardware for this system and hope to be able to get it back to a working state soon. Even if this machine is from 2007, we have decided to revive it with replacement parts instead of going for a brand-new one as this is much cheaper and quicker to realize. Also there is a huge pile of replacement hardware available. Sorry for the inconveniences! Cheers, Colin

3 5

Re: [ros-dev] [ros-builds] Trunk_x86_GCCLin Release: build failed
by Pierre Schweitzer 10 May '15

10 May '15

Manually uploaded. On 10/05/2015 19:28, buildbot(a)reactos.org wrote: > The Buildbot has detected a failed build on builder Trunk_x86_GCCLin Release while building ReactOS. > Full details are available at: > https://build.reactos.org/builders/Trunk_x86_GCCLin%20Release/builds/1177 > > Buildbot URL: https://build.reactos.org/ > > Buildslave for this Build: Debug > > Build Reason: The Periodic scheduler named 'Release' triggered this build > Build Source Stamp: HEAD > Blamelist: > > BUILD FAILED: failed shell > > sincerely, > -The Buildbot > > > > > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

[ros-diffs] [hbelusca] 67595: [NTVDM] - Move some interrupt initialization where it belongs and activate few other ones. - Initialize interruct vector for INT 2Ah (Network check) because some apps directly cal...
by James Tabor 08 May '15

08 May '15

Hi, Yes Int 2A is needed for the novel client server to work correctly. I added it to FreeDOS, here are some examples, http://sourceforge.net/p/freedos/svn/HEAD/tree/kernel/trunk/kernel/entry.as… http://sourceforge.net/p/freedos/svn/HEAD/tree/kernel/trunk/kernel/kernel.a… LOL yeah just bragging now, http://sourceforge.net/p/freedos/svn/HEAD/tree/kernel/trunk/kernel/dosidle.…

1 0

Debug output
by stack exchange 06 May '15

06 May '15

Whats the difference between DPRINT and DbgPrint? I wrote a little program that I can use to observe pipes, which I use for debugging. The text from DPRINT is there, but where does DbgPrint go and why are there multiple different debugging aids?

3 2

Re: [ros-dev] [ros-diffs] [gedmurphy] 67563: [DDK] Fix the FS filter callback definitions
by Ged Murphy 06 May '15

06 May '15

Well this is a weird one, the DDK says these callbacks are cdecl (missing NTAPI) and anyone building against the DDK will obviously declare their callbacks to match this convention. However internally, windows uses stdcall for these callbacks. I can't find much by way of problems people have encountered with this, so why aren't people seeing problems with the way the stack is cleaned up? Anyone have any ideas before I blindly revert this change? Ged. -----Original Message----- From: Ros-diffs [mailto:ros-diffs-bounces@reactos.org] On Behalf Of gedmurphy(a)svn.reactos.org Sent: 05 May 2015 19:54 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [gedmurphy] 67563: [DDK] Fix the FS filter callback definitions Author: gedmurphy Date: Tue May 5 18:54:28 2015 New Revision: 67563 URL: http://svn.reactos.org/svn/reactos?rev=67563&view=rev Log: [DDK] Fix the FS filter callback definitions Modified: trunk/reactos/include/ddk/ntifs.h Modified: trunk/reactos/include/ddk/ntifs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntifs.h?rev=67… ============================================================================== --- trunk/reactos/include/ddk/ntifs.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/ntifs.h [iso-8859-1] Tue May 5 18:54:28 2015 @@ -4890,12 +4890,12 @@ } FS_FILTER_CALLBACK_DATA, *PFS_FILTER_CALLBACK_DATA; typedef NTSTATUS -(NTAPI *PFS_FILTER_CALLBACK) ( +(*PFS_FILTER_CALLBACK) ( _In_ PFS_FILTER_CALLBACK_DATA Data, _Out_ PVOID *CompletionContext); typedef VOID -(NTAPI *PFS_FILTER_COMPLETION_CALLBACK) ( +(*PFS_FILTER_COMPLETION_CALLBACK) ( _In_ PFS_FILTER_CALLBACK_DATA Data, _In_ NTSTATUS OperationStatus, _In_ PVOID CompletionContext);

3 8

Setup on an extended partition
by stack exchange 05 May '15

05 May '15

Hi I'm new to ReactOS development and started to look into some issues I noticed with the setup. When I tried to install it I experimented a bit and noticed that you can create extended partitions during the setup. The setup also accepts such a partition for installation, but the actual installations fails with an error. Now I wondered, what would be the correct way to fix it. I checked with Windows 7 installation, and it apparently doesn't allow you to install on an extended partition either, at least it only allows you to create primary partitions. So if this shouldn't be possible, then I would add an error message to the setup, when the user chooses an extended partition. If this should be possible though, I would look into it, why it fails and try to fix it. Not sure if XP or others allow installations on extended partitions, I have to check this (been a long time since I last installed an XP :) ). regards, Gerhard Gruber

7 16

Re: [ros-dev] [ros-diffs] [akhaldi] 67508: [PARPORT] Introduce a skeleton that will serve as base for implementing the parallel port function driver. Brought to you by The ReactOS Printing Group. CORE-9644
by Pierre Schweitzer 02 May '15

02 May '15

On 02/05/2015 12:15, akhaldi(a)svn.reactos.org wrote: > Author: akhaldi > Date: Sat May 2 10:15:37 2015 > New Revision: 67508 > > URL: http://svn.reactos.org/svn/reactos?rev=67508&view=rev > Log: > [PARPORT] Introduce a skeleton that will serve as base for implementing the parallel port function driver. Brought to you by The ReactOS Printing Group. CORE-9644 Is there a need for that much secrecy? I shall remind that we ask people to contribute with their real names. Such secret looks useless and damaging for the project. And no, ARM group isn't a good example, nor a reason to keep doing so. -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

3 3

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev May 2015