Ros-dev May 2015

ros-dev@reactos.org

19 participants
21 discussions

Re: [ros-dev] [ros-diffs] [tkreuzer] 67718: [CRT] Add simple C implementations for acosf, ceilf, floorf, fmodf and fix sqrtf
by Thomas Faber 16 May '15

16 May '15

On 2015-05-14 15:44, tkreuzer(a)svn.reactos.org wrote: > +_Check_return_ > +float > +__cdecl > +ceilf( > +_In_ float x) > +{ > + return (float)ceilf((double)x); > +} > +_Check_return_ > +float > +__cdecl > +floorf( > +_In_ float x) > +{ > + return (float)floorf((double)x); > +} Did you mean to call ceil/floor here?

2 1

Re: [ros-dev] [ros-diffs] [tkreuzer] 67709: [D3DX9_36/WINED3D] - Remove useless copysignf invocation and the wrong defines for it - BrokenHacksOnTopOfBrokenCode--; - Should be sent upstream
by Thomas Faber 14 May '15

14 May '15

On 2015-05-14 06:00, tkreuzer(a)svn.reactos.org wrote: > - int sign = (copysignf(1, in) < 0); > + int sign = (in < 0); > - if (copysignf(1.0f, value) < 0.0f) > + if (value < 0.0f) > ++idx; I believe the behavior would be different here for negative zero: copysignf(1.0f, -0.0f) should be < 0.0f -0.0f should be == 0.0f Maybe that's the reason for having these calls?

3 3

Re: [ros-dev] [ros-diffs] [akhaldi] 67689: [CMAKE] The /SUBSYSTEM flag takes uppercase parameters.
by Timo Kreuzer 13 May '15

13 May '15

Can you please also add an approproate value for ARM (I guess win8)? :) Am 12.05.2015 um 14:18 schrieb akhaldi(a)svn.reactos.org: > Author: akhaldi > Date: Tue May 12 12:18:02 2015 > New Revision: 67689 > > URL: http://svn.reactos.org/svn/reactos?rev=67689&view=rev > Log: > [CMAKE] The /SUBSYSTEM flag takes uppercase parameters. > > Modified: > trunk/reactos/cmake/msvc.cmake > > Modified: trunk/reactos/cmake/msvc.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/msvc.cmake?rev=67689… > ============================================================================== > --- trunk/reactos/cmake/msvc.cmake [iso-8859-1] (original) > +++ trunk/reactos/cmake/msvc.cmake [iso-8859-1] Tue May 12 12:18:02 2015 > @@ -210,10 +210,11 @@ > endfunction() > > function(set_subsystem MODULE SUBSYSTEM) > + string(TOUPPER ${SUBSYSTEM} _subsystem) > if(ARCH STREQUAL "amd64") > - add_target_link_flags(${MODULE} "/SUBSYSTEM:${SUBSYSTEM},5.02") > - else() > - add_target_link_flags(${MODULE} "/SUBSYSTEM:${SUBSYSTEM},5.01") > + add_target_link_flags(${MODULE} "/SUBSYSTEM:${_subsystem},5.02") > + else() > + add_target_link_flags(${MODULE} "/SUBSYSTEM:${_subsystem},5.01") > endif() > endfunction() > > > >

1 0

Re: [ros-dev] [ros-diffs] [akhaldi] 67683: [SHELL32] Don't provide the format option when the volume is read only. By Barrett Karish. CORE-9530
by Thomas Faber 12 May '15

12 May '15

On 2015-05-12 06:57, akhaldi(a)svn.reactos.org wrote: > +/* FIXME: ntifs.h */ > +#define FILE_READ_ONLY_VOLUME 0x00080000 This should go in ndk/iotypes.h inside an NTOS_MODE_USER ifdef.

1 0

Fezile motherboard has finally failed
by Colin Finck 11 May '15

11 May '15

Hi all, Today, the motherboard in our Fezile server has finally failed after many hick-ups over the year. This causes an outage for the following services: * doxygen.reactos.org * cppcheck.reactos.org * VMware Player Test slave * VMware Player Patchbot As this is not the first time we struggle with such problems, iso.reactos.org is routed to a different server right now and not affected. We have already ordered replacement hardware for this system and hope to be able to get it back to a working state soon. Even if this machine is from 2007, we have decided to revive it with replacement parts instead of going for a brand-new one as this is much cheaper and quicker to realize. Also there is a huge pile of replacement hardware available. Sorry for the inconveniences! Cheers, Colin

3 5

Re: [ros-dev] [ros-builds] Trunk_x86_GCCLin Release: build failed
by Pierre Schweitzer 10 May '15

10 May '15

Manually uploaded. On 10/05/2015 19:28, buildbot(a)reactos.org wrote: > The Buildbot has detected a failed build on builder Trunk_x86_GCCLin Release while building ReactOS. > Full details are available at: > https://build.reactos.org/builders/Trunk_x86_GCCLin%20Release/builds/1177 > > Buildbot URL: https://build.reactos.org/ > > Buildslave for this Build: Debug > > Build Reason: The Periodic scheduler named 'Release' triggered this build > Build Source Stamp: HEAD > Blamelist: > > BUILD FAILED: failed shell > > sincerely, > -The Buildbot > > > > > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

[ros-diffs] [hbelusca] 67595: [NTVDM] - Move some interrupt initialization where it belongs and activate few other ones. - Initialize interruct vector for INT 2Ah (Network check) because some apps directly cal...
by James Tabor 08 May '15

08 May '15

Hi, Yes Int 2A is needed for the novel client server to work correctly. I added it to FreeDOS, here are some examples, http://sourceforge.net/p/freedos/svn/HEAD/tree/kernel/trunk/kernel/entry.as… http://sourceforge.net/p/freedos/svn/HEAD/tree/kernel/trunk/kernel/kernel.a… LOL yeah just bragging now, http://sourceforge.net/p/freedos/svn/HEAD/tree/kernel/trunk/kernel/dosidle.…

1 0

Debug output
by stack exchange 06 May '15

06 May '15

Whats the difference between DPRINT and DbgPrint? I wrote a little program that I can use to observe pipes, which I use for debugging. The text from DPRINT is there, but where does DbgPrint go and why are there multiple different debugging aids?

3 2

Re: [ros-dev] [ros-diffs] [gedmurphy] 67563: [DDK] Fix the FS filter callback definitions
by Ged Murphy 06 May '15

06 May '15

Well this is a weird one, the DDK says these callbacks are cdecl (missing NTAPI) and anyone building against the DDK will obviously declare their callbacks to match this convention. However internally, windows uses stdcall for these callbacks. I can't find much by way of problems people have encountered with this, so why aren't people seeing problems with the way the stack is cleaned up? Anyone have any ideas before I blindly revert this change? Ged. -----Original Message----- From: Ros-diffs [mailto:ros-diffs-bounces@reactos.org] On Behalf Of gedmurphy(a)svn.reactos.org Sent: 05 May 2015 19:54 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [gedmurphy] 67563: [DDK] Fix the FS filter callback definitions Author: gedmurphy Date: Tue May 5 18:54:28 2015 New Revision: 67563 URL: http://svn.reactos.org/svn/reactos?rev=67563&view=rev Log: [DDK] Fix the FS filter callback definitions Modified: trunk/reactos/include/ddk/ntifs.h Modified: trunk/reactos/include/ddk/ntifs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntifs.h?rev=67… ============================================================================== --- trunk/reactos/include/ddk/ntifs.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/ntifs.h [iso-8859-1] Tue May 5 18:54:28 2015 @@ -4890,12 +4890,12 @@ } FS_FILTER_CALLBACK_DATA, *PFS_FILTER_CALLBACK_DATA; typedef NTSTATUS -(NTAPI *PFS_FILTER_CALLBACK) ( +(*PFS_FILTER_CALLBACK) ( _In_ PFS_FILTER_CALLBACK_DATA Data, _Out_ PVOID *CompletionContext); typedef VOID -(NTAPI *PFS_FILTER_COMPLETION_CALLBACK) ( +(*PFS_FILTER_COMPLETION_CALLBACK) ( _In_ PFS_FILTER_CALLBACK_DATA Data, _In_ NTSTATUS OperationStatus, _In_ PVOID CompletionContext);

3 8

Setup on an extended partition
by stack exchange 05 May '15

05 May '15

Hi I'm new to ReactOS development and started to look into some issues I noticed with the setup. When I tried to install it I experimented a bit and noticed that you can create extended partitions during the setup. The setup also accepts such a partition for installation, but the actual installations fails with an error. Now I wondered, what would be the correct way to fix it. I checked with Windows 7 installation, and it apparently doesn't allow you to install on an extended partition either, at least it only allows you to create primary partitions. So if this shouldn't be possible, then I would add an error message to the setup, when the user chooses an extended partition. If this should be possible though, I would look into it, why it fails and try to fix it. Not sure if XP or others allow installations on extended partitions, I have to check this (been a long time since I last installed an XP :) ). regards, Gerhard Gruber

7 16

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev May 2015