Ros-dev June 2015

ros-dev@reactos.org

12 participants
20 discussions

#ReactOS in OpenExpo'15 (Madrid) and other PR stuff
by victor martinez 14 Aug '15

14 Aug '15

Hi guys!I'm proud to confirm that ReactOS project will be shown in OpenExpo'15 in Madrid, 16th June.OpenExpo is one of the greatest open source events in Spain: http://www.openexpo.esWe'll have the opportunity to give a Talk plus some Hacking lab (wish me good luck!). If anyone wants to come, I've one additional free pass. On the other hand, the open source 2/OS project is pushing forward through some Latam guys:https://plus.google.com/112666045931562995118/posts/6k1Xw2yXB7MSeems they're using ReactOS code in their project according with their tweets:https://twitter.com/2osproject/status/578135968219267072(Translation: We're using code of reactos.org and winehq.org, we have had to interact with networking stack with ROS using JAVA)Using Java??? And they seemed to have some issues with ReactOS code:http://twitter.com/2osproject/status/592291632004882433 Keep rockin'!

6 8

Re: [ros-dev] [ros-diffs] [cfinck] 68253: [SPOOLSS] Halfplement and document the undocumented but exported MarshallDownStructure API. Information about this API was exclusively gained by writing a custom XML file for rohita...
by Alex Ionescu 01 Jul '15

01 Jul '15

On Wed, Jun 24, 2015 at 9:26 AM, <cfinck(a)svn.reactos.org> wrote: > cbSize Well, you may at least want to validate that your dwOffsets are within cbSize? Best regards, Alex Ionescu

3 3

Re: [ros-dev] [ros-diffs] [cwittich] 68305: [BROWSEUI] don't expose some interfaces expose IID_IContextMenu3 from CBandSiteMenu
by Pierre Schweitzer 29 Jun '15

29 Jun '15

This commit regressed (badly) explorer: https://www3.heisspiter.net/explorer.png On 28/06/2015 20:22, cwittich(a)svn.reactos.org wrote: > Author: cwittich > Date: Sun Jun 28 18:22:02 2015 > New Revision: 68305 > > URL: http://svn.reactos.org/svn/reactos?rev=68305&view=rev > Log: > [BROWSEUI] > don't expose some interfaces > expose IID_IContextMenu3 from CBandSiteMenu > > Modified: > trunk/reactos/dll/win32/browseui/addressband.h > trunk/reactos/dll/win32/browseui/addresseditbox.h > trunk/reactos/dll/win32/browseui/bandsitemenu.h > trunk/reactos/dll/win32/browseui/internettoolbar.h > > Modified: trunk/reactos/dll/win32/browseui/addressband.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/address… > ============================================================================== > --- trunk/reactos/dll/win32/browseui/addressband.h [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/browseui/addressband.h [iso-8859-1] Sun Jun 28 18:22:02 2015 > @@ -136,6 +136,5 @@ > COM_INTERFACE_ENTRY_IID(IID_IInputObjectSite, IInputObjectSite) > COM_INTERFACE_ENTRY_IID(IID_IPersist, IPersist) > COM_INTERFACE_ENTRY_IID(IID_IPersistStream, IPersistStream) > - COM_INTERFACE_ENTRY_IID(IID_IDispatch, IDispatch) > END_COM_MAP() > }; > > Modified: trunk/reactos/dll/win32/browseui/addresseditbox.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/address… > ============================================================================== > --- trunk/reactos/dll/win32/browseui/addresseditbox.h [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/browseui/addresseditbox.h [iso-8859-1] Sun Jun 28 18:22:02 2015 > @@ -97,7 +97,6 @@ > COM_INTERFACE_ENTRY_IID(IID_IWinEventHandler, IWinEventHandler) > COM_INTERFACE_ENTRY_IID(IID_IOleCommandTarget, IOleCommandTarget) > COM_INTERFACE_ENTRY_IID(IID_IDispatch, IDispatch) > - COM_INTERFACE_ENTRY_IID(IID_IPersist, IPersist) > COM_INTERFACE_ENTRY_IID(IID_IPersistStream, IPersistStream) > END_COM_MAP() > }; > > Modified: trunk/reactos/dll/win32/browseui/bandsitemenu.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/bandsit… > ============================================================================== > --- trunk/reactos/dll/win32/browseui/bandsitemenu.h [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/browseui/bandsitemenu.h [iso-8859-1] Sun Jun 28 18:22:02 2015 > @@ -55,6 +55,7 @@ > BEGIN_COM_MAP(CBandSiteMenu) > COM_INTERFACE_ENTRY_IID(IID_IShellService, IShellService) > COM_INTERFACE_ENTRY_IID(IID_IContextMenu2, IContextMenu2) > + COM_INTERFACE_ENTRY_IID(IID_IContextMenu3, IContextMenu3) > COM_INTERFACE_ENTRY_IID(IID_IContextMenu, IContextMenu) > END_COM_MAP() > }; > > Modified: trunk/reactos/dll/win32/browseui/internettoolbar.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/interne… > ============================================================================== > --- trunk/reactos/dll/win32/browseui/internettoolbar.h [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/browseui/internettoolbar.h [iso-8859-1] Sun Jun 28 18:22:02 2015 > @@ -228,7 +228,6 @@ > COM_INTERFACE_ENTRY_IID(IID_IInputObject, IInputObject) > COM_INTERFACE_ENTRY_IID(IID_IOleWindow, IOleWindow) > COM_INTERFACE_ENTRY_IID(IID_IDockingWindow, IDockingWindow) > - COM_INTERFACE_ENTRY_IID(IID_IPersist, IPersist) > // COM_INTERFACE_ENTRY_IID(IID_IPersistStream, IPersistStream) > COM_INTERFACE_ENTRY_IID(IID_IPersistStreamInit, IPersistStreamInit) > COM_INTERFACE_ENTRY_IID(IID_IOleCommandTarget, IOleCommandTarget) > @@ -237,7 +236,5 @@ > COM_INTERFACE_ENTRY_IID(IID_IShellChangeNotify, IShellChangeNotify) > COM_INTERFACE_ENTRY_IID(IID_IObjectWithSite, IObjectWithSite) > COM_INTERFACE_ENTRY_IID(IID_IServiceProvider, IServiceProvider) > - COM_INTERFACE_ENTRY_IID(IID_IWinEventHandler, IWinEventHandler) > - COM_INTERFACE_ENTRY_IID(IID_IBandSite, IBandSite) > END_COM_MAP() > }; > > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

2 1

Re: [ros-dev] [ros-diffs] [ekohl] 68313: [NTOSKRNL] Add CmpDestroySecurityCache() and CmpDestroyHiveViewList() stubs and call them in CmpDestroyHive and CmUnloadKey(). CORE-6492 #resolve #comment Thank you Hermes! This is e...
by Thomas Faber 29 Jun '15

29 Jun '15

On 2015-06-29 20:26, ekohl(a)svn.reactos.org wrote: > Modified: trunk/reactos/ntoskrnl/config/cmmapvw.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmmapvw.c?… > ============================================================================== > --- trunk/reactos/ntoskrnl/config/cmmapvw.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/config/cmmapvw.c [iso-8859-1] Mon Jun 29 18:26:56 2015 > @@ -29,3 +29,54 @@ > Hive->PinnedViews = 0; > Hive->UseCount = 0; > } > + > +VOID > +NTAPI > +CmpDestroyHiveViewList(IN PCMHIVE Hive) > +{ > + PCM_VIEW_OF_FILE CmView; > + PLIST_ENTRY EntryList; > + > + /* Do NOT destroy the views of read-only hives */ > + ASSERT(Hive->Hive.ReadOnly == FALSE); > + > + /* Free all the views inside the Pinned View List */ > + EntryList = RemoveHeadList(&Hive->PinViewListHead); > + while (EntryList != &Hive->PinViewListHead) In case you haven't found it yourself yet maybe I can speed things up in identifying the test failures here: I made RemoveHeadList on an empty list cause a security check failure a while back because when done unintentionally it can indicate a bug in the code, while OTOH it's super easy to avoid. So I'm guessing this is probably the cause, and should use a while (!IsListEmpty()) RemoveHeadList(); or similar pattern. If you have strong feelings against this check (which MS's headers don't do), let me know. > + { > + CmView = CONTAINING_RECORD(EntryList, CM_VIEW_OF_FILE, PinViewList); > + > + /* FIXME: Unmap the view if it is mapped */ > + > + ExFreePool(CmView); > + > + Hive->PinnedViews--; > + > + EntryList = RemoveHeadList(&Hive->PinViewListHead); > + } > + > + /* The Pinned View List should be empty */ > + ASSERT(IsListEmpty(&Hive->PinViewListHead) == TRUE); > + ASSERT(Hive->PinnedViews == 0); > + > + /* Now, free all the views inside the LRU View List */ > + EntryList = RemoveHeadList(&Hive->LRUViewListHead); > + while (EntryList != &Hive->LRUViewListHead) > + { > + CmView = CONTAINING_RECORD(EntryList, CM_VIEW_OF_FILE, LRUViewList); > + > + /* FIXME: Unmap the view if it is mapped */ > + > + ExFreePool(CmView); > + > + Hive->MappedViews--; > + > + EntryList = RemoveHeadList(&Hive->LRUViewListHead); > + }

2 1

Status Meeting (June 2015)
by Aleksey Bragin 23 Jun '15

23 Jun '15

Hello, Let me invite you to the monthly status meeting taking place 25th of June, 19:00 UTC, as always. IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. Please send agenda proposals to me before the meeting. One point for agenda would be discussion of our upcoming Hackfest in Aachen, which is going to be awesome (the Hackfest, and hopefully the discussion too ;)) Regards, Aleksey Bragin

2 1

Re: [ros-dev] [ros-diffs] [hbelusca] 68139: [TOOLS] Improve bin2c by saving in a #define the size of the generated array, and specify this size in the declaration of the array so that doing sizeof(...) becomes possible. Use...
by Steven Edwards 22 Jun '15

22 Jun '15

This causes failures in cross-compiling on OS X [15/6897] Building C object hal/halx86/CMakeFiles/lib_hal_legacy.dir/pci_classes.c.obj FAILED: /usr/local/RosBE/i386/bin/i686-w64-mingw32-gcc -DDBG=1 -DKDBG=1 -DUSE_COMPILER_EXCEPTIONS -DWINVER=0x502 -D_M_IX86 -D_NTHALDLL_ -D_NTHAL_ -D_SEH_ENABLE_TRACE -D_SETUPAPI_VER=0x502 -D_USE_32BIT_TIME_T -D_USE_PSEH3=1 -D_WIN32_IE=0x600 -D_WIN32_WINDOWS=0x502 -D_WIN32_WINNT=0x502 -D_X86_ -D__REACTOS__ -D__i386__ -D_inline=__inline -Di386 -Wa,--compress-debug-sections -pipe -fms-extensions -fno-strict-aliasing -nostdinc -mstackrealign -Wold-style-declaration -Wdeclaration-after-statement -fdebug-prefix-map="/Users/steven.edwards/source/reactos/reactos"=ReactOS -gdwarf-2 -gstrict-dwarf -femit-struct-debug-detailed=none -feliminate-unused-debug-symbols -march=pentium -mtune=i686 -Werror -Wall -Wpointer-arith -Wno-char-subscripts -Wno-multichar -Wno-unused-value -Wno-maybe-uninitialized -O1 -fno-optimize-sibling-calls -fno-omit-frame-pointer -mpreferred-stack-boundary=3 -fno-set-stack-executable -g -Ihal/halx86 -I../../hal/halx86 -I../../include -I../../include/psdk -I../../include/dxsdk -Iinclude -Iinclude/psdk -Iinclude/dxsdk -Iinclude/reactos -I../../include/crt -I../../include/ddk -I../../include/ndk -I../../include/reactos -I../../include/reactos/libs -I../../hal/halx86/include -I../../ntoskrnl/include -MMD -MT hal/halx86/CMakeFiles/lib_hal_legacy.dir/pci_classes.c.obj -MF hal/halx86/CMakeFiles/lib_hal_legacy.dir/pci_classes.c.obj.d -o hal/halx86/CMakeFiles/lib_hal_legacy.dir/pci_classes.c.obj -c hal/halx86/pci_classes.c In file included from hal/halx86/pci_classes.c:4:0: /Users/steven.edwards/source/reactos/reactos/output-MinGW-i386/reactos/hal/halx86/pci_classes.h:4:33: error: 'Iu' undeclared here (not in a function) [15/6897] Building C object hal/halx86/CMakeFiles/lib_hal_legacy.dir/legacy/bussupp.c.obj FAILED: /usr/local/RosBE/i386/bin/i686-w64-mingw32-gcc -DDBG=1 -DKDBG=1 -DUSE_COMPILER_EXCEPTIONS -DWINVER=0x502 -D_M_IX86 -D_NTHALDLL_ -D_NTHAL_ -D_SEH_ENABLE_TRACE -D_SETUPAPI_VER=0x502 -D_USE_32BIT_TIME_T -D_USE_PSEH3=1 -D_WIN32_IE=0x600 -D_WIN32_WINDOWS=0x502 -D_WIN32_WINNT=0x502 -D_X86_ -D__REACTOS__ -D__i386__ -D_inline=__inline -Di386 -Wa,--compress-debug-sections -pipe -fms-extensions -fno-strict-aliasing -nostdinc -mstackrealign -Wold-style-declaration -Wdeclaration-after-statement -fdebug-prefix-map="/Users/steven.edwards/source/reactos/reactos"=ReactOS -gdwarf-2 -gstrict-dwarf -femit-struct-debug-detailed=none -feliminate-unused-debug-symbols -march=pentium -mtune=i686 -Werror -Wall -Wpointer-arith -Wno-char-subscripts -Wno-multichar -Wno-unused-value -Wno-maybe-uninitialized -O1 -fno-optimize-sibling-calls -fno-omit-frame-pointer -mpreferred-stack-boundary=3 -fno-set-stack-executable -g -Ihal/halx86 -I../../hal/halx86 -I../../include -I../../include/psdk -I../../include/dxsdk -Iinclude -Iinclude/psdk -Iinclude/dxsdk -Iinclude/reactos -I../../include/crt -I../../include/ddk -I../../include/ndk -I../../include/reactos -I../../include/reactos/libs -I../../hal/halx86/include -I../../ntoskrnl/include -MMD -MT hal/halx86/CMakeFiles/lib_hal_legacy.dir/legacy/bussupp.c.obj -MF hal/halx86/CMakeFiles/lib_hal_legacy.dir/legacy/bussupp.c.obj.d -o hal/halx86/CMakeFiles/lib_hal_legacy.dir/legacy/bussupp.c.obj -c ../../hal/halx86/legacy/bussupp.c In file included from ../../hal/halx86/legacy/bussupp.c:697:0: hal/halx86/pci_classes.h:4:33: error: 'Iu' undeclared here (not in a function) ../../hal/halx86/legacy/bussupp.c: In function 'HalpDebugPciDumpBus': ../../hal/halx86/legacy/bussupp.c:739:32: error: 'VendorTable' undeclared (first use in this function) ../../hal/halx86/legacy/bussupp.c:739:32: note: each undeclared identifier is reported only once for each function it appears in [15/6897] Building C object lib/3rdparty/adns/CMakeFiles/adns.dir/src/event.c.obj ninja: build stopped: subcommand failed. On Sun, Jun 14, 2015 at 11:13 AM, <hbelusca(a)svn.reactos.org> wrote: > Author: hbelusca > Date: Sun Jun 14 18:13:50 2015 > New Revision: 68139 > > URL: http://svn.reactos.org/svn/reactos?rev=68139&view=rev > Log: > [TOOLS] > Improve bin2c by saving in a #define the size of the generated array, and > specify this size in the declaration of the array so that doing sizeof(...) > becomes possible. Use "unsigned char" as the (portable) type of the > contents of the array. > > [HAL] > Add PCHAR casts where needed to take into account the previous > modifications. > > Modified: > trunk/reactos/hal/halx86/legacy/bussupp.c > trunk/reactos/tools/bin2c.c > > Modified: trunk/reactos/hal/halx86/legacy/bussupp.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/legacy/bussupp.… > > ============================================================================== > --- trunk/reactos/hal/halx86/legacy/bussupp.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/legacy/bussupp.c [iso-8859-1] Sun Jun 14 > 18:13:50 2015 > @@ -715,7 +715,7 @@ > > /* Isolate the class name */ > sprintf(LookupString, "C %02x ", PciData->BaseClass); > - ClassName = strstr(ClassTable, LookupString); > + ClassName = strstr((PCHAR)ClassTable, LookupString); > if (ClassName) > { > /* Isolate the subclass name */ > @@ -736,7 +736,7 @@ > > /* Isolate the vendor name */ > sprintf(LookupString, "\r\n%04x ", PciData->VendorID); > - VendorName = strstr(VendorTable, LookupString); > + VendorName = strstr((PCHAR)VendorTable, LookupString); > if (VendorName) > { > /* Copy the vendor name into our buffer */ > > Modified: trunk/reactos/tools/bin2c.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/tools/bin2c.c?rev=68139&r1… > > ============================================================================== > --- trunk/reactos/tools/bin2c.c [iso-8859-1] (original) > +++ trunk/reactos/tools/bin2c.c [iso-8859-1] Sun Jun 14 18:13:50 2015 > @@ -13,8 +13,8 @@ > FILE* inFile; > FILE* outCFile; > FILE* outHFile; > + size_t bufLen; > unsigned char ch; > - unsigned char cnt; > > /* Validate the arguments */ > if (argc < 5) > @@ -46,14 +46,6 @@ > return -1; > } > > - /* Generate the header file and close it */ > - fprintf(outHFile, "/* This file is autogenerated, do not edit. > */\n\n"); > - fprintf(outHFile, "#ifndef CHAR\n" > - "#define CHAR char\n" > - "#endif\n\n"); > - fprintf(outHFile, "extern CHAR %s[];\n", argv[4]); > - fclose(outHFile); > - > /* Generate the source file and close it */ > fprintf(outCFile, "/* This file is autogenerated, do not edit. > */\n\n"); > if (argc >= 7) > @@ -69,25 +61,29 @@ > /* Add the array attribute */ > fprintf(outCFile, "%s ", argv[5]); > } > - fprintf(outCFile, "CHAR %s[] =\n{", argv[4]); > + fprintf(outCFile, "unsigned char %s[] =\n{", argv[4]); > > - cnt = 0; > - ch = fgetc(inFile); > + bufLen = 0; > + ch = fgetc(inFile); > while (!feof(inFile)) > { > - if ((cnt % 16) == 0) > - { > + if ((bufLen % 16) == 0) > fprintf(outCFile, "\n "); > - cnt = 0; > - } > + > fprintf(outCFile, " 0x%02x,", (unsigned int)ch); > - ++cnt; > + ++bufLen; > ch = fgetc(inFile); > } > /* Put a final NULL terminator */ > - fprintf(outCFile, "\n 0x00"); > + fprintf(outCFile, "\n 0x00"); ++bufLen; > fprintf(outCFile, "\n};\n"); > fclose(outCFile); > + > + /* Generate the header file and close it */ > + fprintf(outHFile, "/* This file is autogenerated, do not edit. > */\n\n"); > + fprintf(outHFile, "#define %s_SIZE %Iu\n" , argv[4], bufLen); > + fprintf(outHFile, "extern unsigned char %s[%Iu];\n", argv[4], bufLen); > + fclose(outHFile); > > /* Close the input file */ > fclose(inFile); > > > -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 1

The first ever ReactOS Hackfest
by Colin Finck 20 Jun '15

20 Jun '15

Join us for the very first ReactOS Hackfest from Friday, 7th August to Wednesday, 13th August 2015, in the German city of Aachen. Discover Germany's most-Western city in the direct neighborhood of Belgium and the Netherlands. Within the historical city center, Aachen offers a scientific environment and a high density of pubs. Let's catch this atmosphere to code the week away and achieve great results as a team! ===> It is now time to plan your trip! <=== Flights and Accommodation won't get cheaper. You find all details on this Wiki page: https://reactos.org/wiki/ReactOS_Hackfest_2015 Don't forget to add your ideas and travelling details to this page: https://reactos.org/wiki/ReactOS_Hackfest_2015/Lists If you have any further questions, just drop me a line by E-Mail or call me on the mobile phone number I sent to ros-priv. Looking forward to meet you! With best regards, Colin Finck

1 0

Re: [ros-dev] [ros-diffs] [akhaldi] 68155: [THEMEUI] Revert r67304 (Leverage add_registry_inf() as suggested by Timo). Figuring out why that doesn't work is left as an exercise for the reader. See CORE-5984 for details.
by Timo Kreuzer 16 Jun '15

16 Jun '15

If you look at the autogenerated file, you'll find this: [AddReg.NTarm] ; RAM Disk class driver HKLM,"SYSTEM\CurrentControlSet\Services\Disk","ErrorControl",0x00010001,0x00000000 HKLM,"SYSTEM\CurrentControlSet\Services\Disk","ImagePath",0x00020000,"system32\drivers\ramdisk.sys" HKLM,"SYSTEM\CurrentControlSet\Services\Disk","Start",0x00010001,0x00000000 HKLM,"SYSTEM\CurrentControlSet\Services\Disk","Type",0x00010001,0x00000001 HKLM,"SYSTEM\CurrentControlSet\Services\fastfat","Start",0x00010001,0x00000003 ; EOF ; MS Styles (Themes) HKCR,".msstyles","",0x00000000,"msstylesfile" HKCR,"msstylesfile","",0x00000000,"Visual Style File" HKCR,"msstylesfile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1" HKCR,"msstylesfile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance /Action:OpenMSTheme file:""%1""" ; Theme File HKCR,".theme","",0x00000000,"themefile" HKCR,"themefile","",0x00000000,"Theme File" HKCR,"themefile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1" HKCR,"themefile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance /Action:OpenTheme /file:""%1""" And now figure out, why it didn't work. Am 15.06.2015 um 22:42 schrieb akhaldi(a)svn.reactos.org: > Author: akhaldi > Date: Mon Jun 15 20:42:08 2015 > New Revision: 68155 > > URL: http://svn.reactos.org/svn/reactos?rev=68155&view=rev > Log: > [THEMEUI] Revert r67304 (Leverage add_registry_inf() as suggested by Timo). Figuring out why that doesn't work is left as an exercise for the reader. See CORE-5984 for details. > > Removed: > trunk/reactos/dll/win32/themeui/themeui_reg.inf > Modified: > trunk/reactos/boot/bootdata/hivecls.inf > trunk/reactos/dll/win32/themeui/CMakeLists.txt > > Modified: trunk/reactos/boot/bootdata/hivecls.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivecls.inf?… > ============================================================================== > --- trunk/reactos/boot/bootdata/hivecls.inf [iso-8859-1] (original) > +++ trunk/reactos/boot/bootdata/hivecls.inf [iso-8859-1] Mon Jun 15 20:42:08 2015 > @@ -284,6 +284,18 @@ > HKCR,"sysfile","NoOpen",0x00000000,"" > HKCR,"sysfile","FriendlyTypeName",0x00020000,"@%SystemRoot%\system32\shell32.dll,-171" > HKCR,"sysfile\DefaultIcon","",0x00020000,"%SystemRoot%\system32\shell32.dll,-154" > + > +; MS Styles (Themes) > +HKCR,".msstyles","",0x00000000,"msstylesfile" > +HKCR,"msstylesfile","",0x00000000,"Visual Style File" > +HKCR,"msstylesfile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1" > +HKCR,"msstylesfile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance /Action:OpenMSTheme file:""%1""" > + > +; Theme File > +HKCR,".theme","",0x00000000,"themefile" > +HKCR,"themefile","",0x00000000,"Theme File" > +HKCR,"themefile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1" > +HKCR,"themefile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance /Action:OpenTheme /file:""%1""" > > ; URL shortcuts (e.g. used in favorites folder of IExplorer) > HKCR,".url","",0x00000000,"InternetShortcut" > > Modified: trunk/reactos/dll/win32/themeui/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/themeui/CMakeLis… > ============================================================================== > --- trunk/reactos/dll/win32/themeui/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/themeui/CMakeLists.txt [iso-8859-1] Mon Jun 15 20:42:08 2015 > @@ -1,5 +1,4 @@ > > add_library(themeui SHARED themeui.rc) > set_module_type(themeui win32dll ENTRYPOINT 0) > -add_registry_inf(themeui_reg.inf) > add_cd_file(TARGET themeui DESTINATION reactos/system32 FOR all) > > Removed: trunk/reactos/dll/win32/themeui/themeui_reg.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/themeui/themeui_… > ============================================================================== > --- trunk/reactos/dll/win32/themeui/themeui_reg.inf [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/themeui/themeui_reg.inf (removed) > @@ -1,11 +0,0 @@ > -; MS Styles (Themes) > -HKCR,".msstyles","",0x00000000,"msstylesfile" > -HKCR,"msstylesfile","",0x00000000,"Visual Style File" > -HKCR,"msstylesfile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1" > -HKCR,"msstylesfile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance /Action:OpenMSTheme file:""%1""" > - > -; Theme File > -HKCR,".theme","",0x00000000,"themefile" > -HKCR,"themefile","",0x00000000,"Theme File" > -HKCR,"themefile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1" > -HKCR,"themefile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance /Action:OpenTheme /file:""%1""" > > >

2 1

VMware Testbots fixed
by Colin Finck 16 Jun '15

16 Jun '15

Hi all, After some attempts yesterday and today, the VMware Testbots are finally fixed. Due to a misconfiguration, they were unfortunately testing the same revision 65663 all the time. I'm going to delete the duplicate testings for r65663 once I have some time. Unless somebody is interested in the most detailed information about randomly failing Wine tests ;) Cheers, Colin

1 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 68137: [KERNEL32] Addendum to r68136: use appropriate define. Spotted by Thomas
by Timo Kreuzer 15 Jun '15

15 Jun '15

Am 14.06.2015 um 18:00 schrieb pschweitzer(a)svn.reactos.org: > Author: pschweitzer > Date: Sun Jun 14 16:00:27 2015 > New Revision: 68137 > > > - Proc = (1ULL << Processor) >> 0x20; > + Proc = (1ULL << Processor) >> MAXIMUM_PROCESSORS; This is effectively the same as "Proc = (Processor == MAXIMUM_PROCESSORS);" which is always 0. Timo

1 1

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev June 2015