Ros-dev October 2016

ros-dev@reactos.org

15 participants
18 discussions

Re: [ros-dev] Retrieving the computer name of a named pipe client

by Alex Ionescu

You literally wrote " but this is neither supported under Windows Server 2003", so yes, there's your answer :) Best regards, Alex Ionescu On Tue, Oct 11, 2016 at 1:18 PM, Colin Finck <colin(a)reactos.org> wrote: > Am 10.10.2016 um 23:22 schrieb Timo Kreuzer: >> #define FSCTL_PIPE_GET_CONNECTION_ATTRIBUTE >> CTL_CODE(FILE_DEVICE_NAMED_PIPE, 12, METHOD_BUFFERED, FILE_ANY_ACCESS) >> >> static const char AttributeName[] = "ClientComputerName"; >> >> Status = NtFsControlFile(NamedPipeHandle, > > Are you sure this is the right way of doing it under Windows 2003? > While 2003's rpcrt4.dll imports NtFsControlFile, running GNU strings on > it doesn't output any "ClientComputerName" string. > > Furthermore, our NPFS driver only implements the FSCTL_PIPE_* control > codes up to FSCTL_PIPE_QUERY_CLIENT_PROCESS (#9). #10 to #16 (with > FSCTL_PIPE_GET_CONNECTION_ATTRIBUTE being #12) are not processed. Same > goes for the free ntifs.h from https://www.acc.umu.se/~bosse/ntifs.h, it > lacks all FSCTL_PIPE_* codes after #9. I'm getting the impression, #10 > to #16 were only introduced with NT 6.0. > If I had the ntifs.h from Windows 2003, I could confirm my theory, but > this file was never public and only part of the commercial IFS Kit. > > So, talking to the NPFS driver probably goes into the right direction, > but I assume we have to find an alternative to > FSCTL_PIPE_GET_CONNECTION_ATTRIBUTE. > > > - Colin > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev

8 years, 2 months

Re: [ros-dev] [ros-diffs] [phater] 72948: [MSAFD] Fix some return codes and better parameter checks based on wine tests CORE-12104

by Thomas Faber

Hurray! Congrats on your first commit! On 2016-10-10 08:38, phater(a)svn.reactos.org wrote: > Author: phater > Date: Mon Oct 10 06:38:52 2016 > New Revision: 72948 > > URL: http://svn.reactos.org/svn/reactos?rev=72948&view=rev > Log: > [MSAFD] Fix some return codes and better parameter checks based on wine tests CORE-12104 > > Modified: > trunk/reactos/dll/win32/msafd/misc/dllmain.c >

8 years, 2 months

Re: [ros-dev] [ros-diffs] [hbelusca] 72943: [PING] - Use a dynamic-allocated buffer with FormatMessageW, fixes messages disappearance (eg. ping help in russian). CORE-12108 #comment Fixed in r72943. - Remove the unneeded 1-...

by Colin Finck

hbelusca(a)svn.reactos.org wrote: > +#define RC_STRING_MAX_SIZE 4096 > + > + WCHAR Format[RC_STRING_MAX_SIZE]; > + LPWSTR lpMsgBuf = NULL; > + DWORD Len; > va_list args; > > if (!LoadStringW(GetModuleHandleW(NULL), id, Format, > _countof(Format))) Now instead of #define RC_STRING_MAX_SIZE 4096 WCHAR Format[RC_STRING_MAX_SIZE]; LoadStringW(GetModuleHandleW(NULL), id, Format, _countof(Format)); just do a LPWSTR lpFormatBuf; LoadStringW(GetModuleHandleW(NULL), id, (LPWSTR)&lpFormatBuf, 0); and you have a perfect universal solution for any resource string length without caring about buffer sizes at all. It doesn't even need any extra memory :) This should actually be changed in a lot of places! - Colin

8 years, 2 months

[ros-diffs] [spetreolle] 72905: [NtUser] Turn an ERR into a TRACE.

by James Tabor

Now we will never know what happen to the lost application!

8 years, 2 months

Re: [ros-dev] [ros-diffs] [hbelusca] 72939: Fix commit synchronization issue (that's what happens when you work on a patch that somebody else worked on in parallel!!)

by Amine Khaldi

Hi, Please think twice before committing to the ReactOS repo. The most recent example is the format/lang/uk-UA.rc changes that have absolutely nothing to do with the "Russian translation update by Sergey Stopkin." commit log. When you do that, you'll always be committing while being calm and in control of what you're sending. The svn history is a responsibility shared between the ReactOS developers. Regards, Amine.

8 years, 2 months

jira is down for me

by Alexander Rechitskiy

8 years, 2 months

Re: [ros-dev] [ros-diffs] [hbelusca] 72922: [KD] - When enabling or disabling the kernel debugger and setting the KdDebuggerEnabled flag, also update the corresponding user-mode flag in SharedUserData->KdDebuggerEnabled. - ...

by Pierre Schweitzer

Le 06/10/2016 à 21:01, hbelusca(a)svn.reactos.org a écrit : > Author: hbelusca > Date: Thu Oct 6 19:01:33 2016 > New Revision: 72922 > > URL: http://svn.reactos.org/svn/reactos?rev=72922&view=rev > Log: > [KD] > - When enabling or disabling the kernel debugger and setting the KdDebuggerEnabled flag, also update the corresponding user-mode flag in SharedUserData->KdDebuggerEnabled. > - Turn KdpGetMemorySizeInMBs into a INIT_FUNCTION. > - Print kernel command line & ARC paths even in debug log file mode. > > [KD64] > WinKD: Also print our nice ReactOS debug header (version, # of processors & memory MB, kernel command line and ARC paths). > > Modified: > trunk/reactos/ntoskrnl/kd/kdinit.c > trunk/reactos/ntoskrnl/kd/kdio.c > trunk/reactos/ntoskrnl/kd/kdmain.c > trunk/reactos/ntoskrnl/kd64/kdapi.c > trunk/reactos/ntoskrnl/kd64/kdinit.c > > Modified: trunk/reactos/ntoskrnl/kd/kdio.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd/kdio.c?rev=729… > ============================================================================== > --- trunk/reactos/ntoskrnl/kd/kdio.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/kd/kdio.c [iso-8859-1] Thu Oct 6 19:01:33 2016 > @@ -240,10 +243,15 @@ > KeInitializeSpinLock(&KdpDebugLogSpinLock); > > /* Display separator + ReactOS version at start of the debug log */ > - DPRINT1("---------------------------------------------------------------\n"); > + DPRINT1("-----------------------------------------------------\n"); This specific change has likely broken any testbot running sysreg2 and vmware or vbox. Why was this change even needed? -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

8 years, 2 months

Re: [ros-dev] [ros-diffs] [akhaldi] 72908: [WS2_32_APITEST] Add tests for getnameinfo. By Peter Hater. CORE-8549

by Thomas Faber

On 2016-10-05 11:33, akhaldi(a)svn.reactos.org wrote: > --- trunk/rostests/apitests/ws2_32/getnameinfo.c (added) > +++ trunk/rostests/apitests/ws2_32/getnameinfo.c [iso-8859-1] Wed Oct 5 09:33:03 2016 > @@ -0,0 +1,99 @@ > +/* > + * PROJECT: ReactOS api tests > + * LICENSE: GPLv2+ - See COPYING in the top level directory > + * PURPOSE: Test for getaddrinfo > + * PROGRAMMER: Thomas Faber <thomas.faber(a)reactos.org> > + */ Thanks for the credit, but I don't think I deserve it ;)

8 years, 2 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev October 2016