Ros-dev December 2016

ros-dev@reactos.org

7 participants
7 discussions

by mvardan.dev

Hello Aleksey, About readiness to get merged I think decision should be done by Thomas or Amine. Related to collaboration with ROS, as I have informed on one of the monthly meetings, I have willing to contribute ReactOS. But for now I have probelm with time which is depend on many factors. We can schedule meeting in IRC or wherever you want, to discuss how I can help to our project. Thanks,Vardan. Sent from my Samsung Galaxy smartphone. -------- Original message --------From: Aleksey Bragin <aleksey(a)reactos.org> Date: 12/20/16 03:00 (GMT+04:00) To: ReactOS Development List <ros-dev(a)reactos.org> Subject: [ros-dev] USB from GSoC Hello! What happened to the USB branch made by Vardan during GSoC 2016? Is it ready to be merged, or if not, what's holding it? Any input is appreciated, especially from Vardan himself. Regards, Aleksey Bragin _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

7 years, 11 months

Re: [ros-dev] [ros-diffs] [jimtabor] 73475: [Win32SS|RTL] - Fix clipping for Draw Text. Inspired by Katayama Hirofumi MZ patch and ComCtl32/RichEd20/UxThmems. See CORE-2201.

by Thomas Faber

On 2016-12-22 11:39, jimtabor(a)svn.reactos.org wrote: > +#ifndef _WIN32K_ ///// Fix CORE-2201. > + if (!(flags & DT_NOCLIP) ) > + { > + int hasClip; > + hrgn = CreateRectRgn(0,0,0,0); > + if (hrgn) > + { > + hasClip = GetClipRgn(hdc, hrgn); > + // If the region to be retrieved is NULL, the return value is 0. > + if (hasClip != 1) > + { > + DeleteObject(hrgn); > + hrgn = NULL; > + } > + IntersectClipRect(hdc, rect->left, rect->top, rect->right, rect->bottom); > + } > + } > +#else > + if (!(flags & DT_NOCLIP) ) > + { > + int hasClip; > + hrgn = NtGdiCreateRectRgn(0,0,0,0); > + if (hrgn) > + { > + hasClip = NtGdiGetRandomRgn(hdc, hrgn, CLIPRGN); > + if (hasClip != 1) > + { > + GreDeleteObject(hrgn); > + hrgn = NULL; > + } > + NtGdiIntersectClipRect(hdc, rect->left, rect->top, rect->right, rect->bottom); > + } > + } > +#endif ///// Any particular reason not to simply do the NtGdi call in both user and kernel? Looks like they should be doing the exact same thing.

7 years, 12 months

The Terminator^W AHK bot needs a vacation

by Sylvain Petreolle

During Christmas, I have to leave the AHK bot room free of machine noise at my place. The bot is officially on vacation until Dec 27-28th :-) Happy Christmas, Sylvain Petreolle

8 years

USB from GSoC

by Aleksey Bragin

Hello! What happened to the USB branch made by Vardan during GSoC 2016? Is it ready to be merged, or if not, what's holding it? Any input is appreciated, especially from Vardan himself. Regards, Aleksey Bragin

8 years

Re: [ros-dev] [ros-diffs] [gadamopoulos] 73436: [SHELL32] - Initialize the shell icon cache only when needed or when FileIconInit is called (and not in the DllMain of shell32)

by Thomas Faber

On 2016-12-07 01:10, gadamopoulos(a)svn.reactos.org wrote: > [SHELL32] - Initialize the shell icon cache only when needed or when FileIconInit is called (and not in the DllMain of shell32) > --- trunk/reactos/dll/win32/shell32/iconcache.cpp [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/shell32/iconcache.cpp [iso-8859-1] Wed Dec 7 00:10:43 2016 > @@ -453,6 +453,9 @@ > sice.dwSourceIndex = dwSourceIndex; > sice.dwFlags = dwFlags; > > + if (!sic_hdpa) > + SIC_Initialize(); > + > EnterCriticalSection(&SHELL32_SicCS); > > if (NULL != DPA_GetPtr (sic_hdpa, 0)) > @@ -687,6 +690,9 @@ > RegCloseKey(hKeyShellIcons); > } > > + if (!sic_hdpa) > + SIC_Initialize(); > + > return SIC_LoadIcon(iconPath, iconIdx, 0); > } > This is great. Unfortunately now you have a race condition if multiple of these functions get called concurrently.

8 years

Re: [ros-dev] [ros-diffs] [ekohl] 73433: [SERVICES] Create a new environment block when a service process is started. Patch by Hermès BÉLUSCA - MAÏTO. CORE-12414

by Ged Murphy

This leaks if ImpersonateLoggedOnUser fails and the environment block is non-null -----Original Message----- From: Ros-diffs [mailto:ros-diffs-bounces@reactos.org] On Behalf Of ekohl(a)svn.reactos.org Sent: 06 December 2016 17:30 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [ekohl] 73433: [SERVICES] Create a new environment block when a service process is started. Patch by Hermès BÉLUSCA - MAÏTO. CORE-12414 + if (Service->lpImage->hToken) + { + /* User token: Run the service under the user account */ + + if (!CreateEnvironmentBlock(&lpEnvironment, Service->lpImage->hToken, FALSE)) + { + /* We failed, run the service with the current environment */ + DPRINT1("CreateEnvironmentBlock() failed with error %d, service '%S' will run with the current environment.\n", + Service->lpServiceName, GetLastError()); + lpEnvironment = NULL; + } + + /* Impersonate the new user */ + if (!ImpersonateLoggedOnUser(Service->lpImage->hToken)) + { + dwError = GetLastError(); + DPRINT1("ImpersonateLoggedOnUser() failed with error %d\n", GetLastError()); + return dwError; + }

8 years

From this moment PVS-Studio is free of charge for opensource projects

by Alexander Rechitskiy

8 years

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev December 2016