Ros-dev February 2016

ros-dev@reactos.org

20 participants
13 discussions

Re: [ros-dev] [ros-diffs] [hbelusca] 70707: [CMLIB]: Implement CmpFreeSecurityDescriptor. See r70609. CORE-10793 CORE-10796
by Alex Ionescu 11 Feb '16

11 Feb '16

On Wed, Feb 10, 2016 at 5:28 PM, <hbelusca(a)svn.reactos.org> wrote: > else // if (SecurityData->ReferenceCount <= 1) Is the intent to free the data while SecurityData->RefCount will remain at 1?! Best regards, Alex Ionescu

2 1

[ros-diffs] [jimtabor] 70685: [User32] - Patch by Manuel : Explorer not draw (16 bits) icons. See CORE-10789.
by James Tabor 03 Feb '16

03 Feb '16

Hello, Apologies to Carlo Bramini, I listed the wrong author of the patch. James <https://jira.reactos.org/secure/ViewProfile.jspa?name=carlo+bramix>

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 70674: [CMLIB]: Demote the DPRINT1 saying that we leak the security block descriptor to a DPRINT. People (Alex & me) working on cmlib already know this. "Fixes" timeout problems of the t...
by Alex Ionescu 02 Feb '16

02 Feb '16

I think you guys took more time to debug and mess with the DPRINT then it would've taken to implement the function. Come on guys. Best regards, Alex Ionescu On Mon, Feb 1, 2016 at 3:10 PM, <hbelusca(a)svn.reactos.org> wrote: > Author: hbelusca > Date: Mon Feb 1 23:10:38 2016 > New Revision: 70674 > > URL: http://svn.reactos.org/svn/reactos?rev=70674&view=rev > Log: > [CMLIB]: Demote the DPRINT1 saying that we leak the security block descriptor to a DPRINT. People (Alex & me) working on cmlib already know this. "Fixes" timeout problems of the testbots due to spamming this dprint. > > Modified: > trunk/reactos/lib/cmlib/cmkeydel.c > > Modified: trunk/reactos/lib/cmlib/cmkeydel.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/cmkeydel.c?rev=7… > ============================================================================== > --- trunk/reactos/lib/cmlib/cmkeydel.c [iso-8859-1] (original) > +++ trunk/reactos/lib/cmlib/cmkeydel.c [iso-8859-1] Mon Feb 1 23:10:38 2016 > @@ -215,7 +215,7 @@ > } > > /* FIXME: This leaks the security desriptor! */ > - DPRINT1("Potentially leaking key security descriptor. Please call CmpFreeSecurityDescriptor\n"); > + DPRINT("Potentially leaking key security descriptor. Please call CmpFreeSecurityDescriptor\n"); > > /* Free the key body itself, and then return our status */ > if (!CmpFreeKeyBody(Hive, Cell)) return STATUS_INSUFFICIENT_RESOURCES; > >

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev February 2016