Ros-dev May 2016

ros-dev@reactos.org

30 participants
39 discussions

Re: [ros-dev] [ros-diffs] [tfaber] 71307: [HAL] - Create a wrapper version of HalpEndSoftwareInterrupt that frees its stack before calling the noreturn version of the next software interrupt handler. Fixes excessive stack u...
by Timo Kreuzer 16 May '16

16 May '16

Wait, are you suggesting that "doing everything the same as MS does" and "I don't need to care for C standards, I have a huge epeen!" and "OnlyOnePersonCanWriteHalCode AndItsNotYou".... doesn't work? :O Best regards, Timo Kreuzer Am 10.05.2016 um 17:03 schrieb tfaber(a)svn.reactos.org: > Author: tfaber > Date: Tue May 10 15:03:56 2016 > New Revision: 71307 > > URL: http://svn.reactos.org/svn/reactos?rev=71307&view=rev > Log: > [HAL] > - Create a wrapper version of HalpEndSoftwareInterrupt that frees its stack before calling the noreturn version of the next software interrupt handler. Fixes excessive stack usage when DPCs are queued in quick succession. > CORE-11123 #resolve > > Added: > trunk/reactos/hal/halx86/up/pic.S (with props) > Modified: > trunk/reactos/hal/halx86/pic.cmake > trunk/reactos/hal/halx86/up/pic.c > > Modified: trunk/reactos/hal/halx86/pic.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/pic.cmake?rev=7… > ============================================================================== > --- trunk/reactos/hal/halx86/pic.cmake [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/pic.cmake [iso-8859-1] Tue May 10 15:03:56 2016 > @@ -1,7 +1,8 @@ > > list(APPEND HAL_PIC_ASM_SOURCE > generic/systimer.S > - generic/trap.S) > + generic/trap.S > + up/pic.S) > > list(APPEND HAL_PIC_SOURCE > generic/profil.c > > Added: trunk/reactos/hal/halx86/up/pic.S > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/up/pic.S?rev=71… > ============================================================================== > --- trunk/reactos/hal/halx86/up/pic.S (added) > +++ trunk/reactos/hal/halx86/up/pic.S [iso-8859-1] Tue May 10 15:03:56 2016 > @@ -0,0 +1,48 @@ > +/* > + * FILE: hal/halx86/up/pic.S > + * COPYRIGHT: See COPYING in the top level directory > + * PURPOSE: HAL PIC Management and Control Code > + * PROGRAMMER: Thomas Faber (thomas.faber(a)reactos.org) > + */ > + > +/* INCLUDES ******************************************************************/ > + > +#include <asm.inc> > + > +#include <ks386.inc> > + > +EXTERN _HalpEndSoftwareInterrupt2@8:PROC > + > +/* GLOBALS *******************************************************************/ > + > +.data > +ASSUME CS:NOTHING, DS:NOTHING, ES:NOTHING, FS:NOTHING, GS:NOTHING > + > +/* FUNCTIONS *****************************************************************/ > + > +.code > +PUBLIC _HalpEndSoftwareInterrupt@8 > +.PROC _HalpEndSoftwareInterrupt@8 > + FPO 0, 2, 0, 0, 0, FRAME_FPO > + > + /* Call the C function with the same arguments we got */ > + push [esp+8] > + push [esp+8] > + call _HalpEndSoftwareInterrupt2@8 > + > + /* Check if we got a pointer back */ > + test eax, eax > + jnz CallIntHandler > + > + /* No? Just return */ > + ret 8 > + > +CallIntHandler: > + /* We got a pointer to call. Since it won't return, free up our stack > + space, or we could end up with some nasty deep recursion */ > + mov ecx, [esp+8] > + add esp, 12 > + jmp eax > +.ENDP > + > +END > > Propchange: trunk/reactos/hal/halx86/up/pic.S > ------------------------------------------------------------------------------ > svn:eol-style = native > > Modified: trunk/reactos/hal/halx86/up/pic.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/up/pic.c?rev=71… > ============================================================================== > --- trunk/reactos/hal/halx86/up/pic.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/up/pic.c [iso-8859-1] Tue May 10 15:03:56 2016 > @@ -11,6 +11,11 @@ > #include <hal.h> > #define NDEBUG > #include <debug.h> > + > +VOID > +NTAPI > +HalpEndSoftwareInterrupt(IN KIRQL OldIrql, > + IN PKTRAP_FRAME TrapFrame); > > /* GLOBALS ********************************************************************/ > > @@ -263,7 +268,7 @@ > * so it will always preempt until we reach PROFILE_LEVEL. > */ > 0b00000000000000000001011111110000, /* IRQL 20 */ > - 0b00000000000000000001001111110000, /* IRQL 20 */ > + 0b00000000000000000001001111110000, /* IRQL 21 */ > 0b00000000000000000001000111110000, /* IRQL 22 */ > 0b00000000000000000001000011110000, /* IRQL 23 */ > 0b00000000000000000001000001110000, /* IRQL 24 */ > @@ -732,15 +737,17 @@ > KeGetPcr()->IRR &= ~(1 << Irql); > } > > -VOID > -NTAPI > -HalpEndSoftwareInterrupt(IN KIRQL OldIrql, > - IN PKTRAP_FRAME TrapFrame) > +PHAL_SW_INTERRUPT_HANDLER_2ND_ENTRY > +NTAPI > +HalpEndSoftwareInterrupt2(IN KIRQL OldIrql, > + IN PKTRAP_FRAME TrapFrame) > { > ULONG PendingIrql, PendingIrqlMask, PendingIrqMask; > PKPCR Pcr = KeGetPcr(); > PIC_MASK Mask; > > + UNREFERENCED_PARAMETER(TrapFrame); > + > /* Set old IRQL */ > Pcr->Irql = OldIrql; > > @@ -749,10 +756,10 @@ > { > /* Check for pending software interrupts and compare with current IRQL */ > PendingIrqlMask = Pcr->IRR & FindHigherIrqlMask[OldIrql]; > - if (!PendingIrqlMask) return; > + if (!PendingIrqlMask) return NULL; > > /* Check for in-service delayed interrupt */ > - if (Pcr->IrrActive & 0xFFFFFFF0) return; > + if (Pcr->IrrActive & 0xFFFFFFF0) return NULL; > > /* Check if pending IRQL affects hardware state */ > BitScanReverse(&PendingIrql, PendingIrqlMask); > @@ -777,10 +784,11 @@ > else > { > /* No need to loop checking for hardware interrupts */ > - SWInterruptHandlerTable2[PendingIrql](TrapFrame); > - UNREACHABLE; > + return SWInterruptHandlerTable2[PendingIrql]; > } > } > + > + return NULL; > } > > /* EDGE INTERRUPT DISMISSAL FUNCTIONS *****************************************/ > > >

1 0

Abuse filter bans legit users and ignores spamers
by Alexander Rechitskiy 16 May '16

16 May '16

1 0

https://code.reactos.org/ is down
by Alexander Rechitskiy 13 May '16

13 May '16

2 1

CAPCHA does not work
by Alexander Rechitskiy 13 May '16

13 May '16

2 1

Build Crash ProgMan
by James Tabor 12 May '16

12 May '16

Linux build, on all my systems, Slackware, Fedora,,,,, Building C object base/shell/progman/progman_pch.h.gch FAILED: /usr/local/RosBE/i386/bin/i686-w64-mingw32-gcc -DDBG=1 -DKDBG=1 -DUNICODE -DUSE_COMPILER_EXCEPTIONS -DWINVER=0x502 -D_DLL -D_M_IX86 -D_SEH_ENABLE_TRACE -D_SETUPAPI_VER=0x502 -D_UNICODE -D_USE_32BIT_TIME_T -D_USE_PSEH3=1 -D_WIN32_IE=0x600 -D_WIN32_WINDOWS=0x502 -D_WIN32_WINNT=0x502 -D_X86_ -D__REACTOS__ -D__USE_CRTIMP -D__i386__ -D_inline=__inline -Di386 -Wa,--compress-debug-sections -pipe -fms-extensions -fno-strict-aliasing -nostdinc -mstackrealign -Wold-style-declaration -Wdeclaration-after-statement -fdebug-prefix-map="/home/ros/reactos"=ReactOS -gdwarf-2 -gstrict-dwarf -femit-struct-debug-detailed=none -feliminate-unused-debug-symbols -march=pentium -mtune=i686 -Werror -Wall -Wpointer-arith -Wno-char-subscripts -Wno-multichar -Wno-unused-value -Wno-maybe-uninitialized -O1 -fno-optimize-sibling-calls -fno-omit-frame-pointer -mpreferred-stack-boundary=3 -fno-set-stack-executable -Winvalid-pch -Werror=invalid-pch -Ibase/shell/progman -I../../base/shell/progman -I../../sdk/include -I../../sdk/include/psdk -I../../sdk/include/dxsdk -Isdk/include -Isdk/include/psdk -Isdk/include/dxsdk -Isdk/include/ddk -Isdk/include/reactos -I../../sdk/include/crt -I../../sdk/include/ddk -I../../sdk/include/ndk -I../../sdk/include/reactos -I../../sdk/include/reactos/libs -MMD -MT base/shell/progman/progman_pch.h.gch -MF base/shell/progman/progman_pch.h.gch.d -o base/shell/progman/progman_pch.h.gch -c ../../base/shell/progman/progman.h ../../base/shell/progman/progman.h:35:9: error: #pragma once in main file [-Werror] cc1: all warnings being treated as errors [206/1104] Linking C executable base/shell/cmd/cmd.exe ninja: build stopped: subcommand failed.

1 0

Spam attack, continuing... (episode 12345/infinity)
by Hermès BÉLUSCA - MAÏTO 04 May '16

04 May '16

So, guys, ... We are yet again subject to a spam attack on the forums AND in the wiki (since yesterday for the latter), but nothing was done yet !! https://reactos.org/forum/ https://reactos.org/wiki/Special:RecentChanges For the wiki, the abuse filter hasn't blocked everything !! Regards, Hermès

1 0

Google Summer of Code
by Zuodian Hu 03 May '16

03 May '16

Dear ReactOS I am zhu48 from the GSoC, on the network driver project. I'm sorry I am sending this email out so late after the start of the official bonding period. I am going into finals week and I had some trouble getting the mailing list to work. Hello everybody! Zuodian Hu

2 1

Greetings from GSoC student!
by Aman Priyadarshi 03 May '16

03 May '16

Hello ROS community! My name is Aman Priyadarshi, undergraduate from India. It's a bit late but I would like to thank you all the members of this community who helped me to figure out things, helped me in setting up my build environment and finishing up my GSoC Proposal. It is really great opportunity for me to get selected and prove myself. You people can be sure that I'll put my best. *Project Proposed:* My project is to write "AHCI controller interface and hence ATA/ATAPI driver for windows 2003 targeting NT 5.0" which I later port to ROS. I have started investigation of NT programming concepts and storage class structure. I hope I would able to meet expectation of community. *My Background: *I am a enthusiastic programmer, core languages are C#, C/C++, x86 Assembly. my field of interest includes hardware programming, algorithms (+ optimizations) and Machine Learning. In free time I love to work on my own project Atom OS, It's an multitasking monolithic kernel based operating system that I have written from scratch in C# targeting x86 arch. I also love competitive coding (codechef.com <https://www.codechef.com/users/amaneureka>) and tiny machine Learning project (mainly classification based). I would really like to continue being a developer at ROS community after GSoC project. Greetings *Aman Priyadarshi* *www.atomixos.com <http://www.atomixos.com>* ᐧ

3 2

WinDbg protocol for debugging, PDB implementation
by Антон Кочков 02 May '16

02 May '16

Hello Everyone! After I saw an article mentioning you're using WinDbg for debugging, I thought that information below could be interesting for you: We (radare2 project) have developed our own implementation of both GDB and WinDbg protocol parsers as a separate libraries in pure C and without hard dependencies of external libraries. Here you can find our WinDbg protocol implementation https://github.com/radare/radare2/tree/master/shlr/wind And here you can find our PDB parser https://github.com/radare/radare2/tree/master/libr/bin/pdb This is how to use radare2 for connecting to WinDbg server https://github.com/radare/radare2/blob/master/doc/windbg And here is how to use radare2 for parsing PDB files https://github.com/radare/radare2/blob/master/doc/pdb/pdb_usage Our goal is to write complete implementations of WinDbg and PDB, both platform independent and working everywhere. If you're interested on joining forces for that - feel free to answer this email or join us in Telegram or IRC - "#radare" on both. I hope this would be useful for someone. Kind regards, Anton Kochkov.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev May 2016