Ros-dev September 2016

ros-dev@reactos.org

17 participants
24 discussions

Re: [ros-dev] [ros-diffs] [gedmurphy] 72594: [FLTMGR] - Implement FltLoadFilter and stub FltUnloadFilter - Register contexts if the caller requests (coming later) - Stubpliment FltStartFiltering

by Thomas Faber

On 2016-09-06 18:47, gedmurphy(a)svn.reactos.org wrote: > @@ -116,12 +150,21 @@ > InitializeListHead(&Filter->PortList.mList); > Filter->PortList.mCount = 0; > > + /* We got this far, assume success from here */ > + Status = STATUS_SUCCESS; > + > /* Check if the caller requested any context data */ > if (Registration->ContextRegistration) > { > - // register the context information > - } > - > + /* Register the contexts for this filter */ > + Status = FltpRegisterContexts(Filter, Registration->ContextRegistration); > + if (NT_SUCCESS(Status)) I think you mean !NT_SUCCESS? > + { > + goto Quit; > + } > + } > + > + /* Check if the caller is registering any callbacks */ > if (Registration->OperationRegistration) > { > /* The callback data comes after the fixed struct */ > @@ -162,7 +205,7 @@ > // - More stuff?? > // > > -//Quit: > +Quit: > if (!NT_SUCCESS(Status)) > { > // Add cleanup for context resources

8 years

Re: [ros-dev] [ros-diffs] [gedmurphy] 72595: [FLTMGR] - Add stubs for context registration - Add dispatch and device control handlers - Implement the load IOCTL. We can now load minifilters with 'fltmc load <myfilter>'

by Thomas Faber

On 2016-09-06 18:59, gedmurphy(a)svn.reactos.org wrote: > +NTSTATUS > +HandleLoadUnloadIoctl(_In_ PDEVICE_OBJECT DeviceObject, > + _Inout_ PIRP Irp) > +{ > + PIO_STACK_LOCATION StackPtr; > + UNICODE_STRING Name; > + PFILTER_NAME FilterName; > + ULONG BufferLength; > + ULONG ControlCode; > + > + /* Get the IOCTL data from the stack pointer */ > + StackPtr = IoGetCurrentIrpStackLocation(Irp); > + BufferLength = StackPtr->Parameters.DeviceIoControl.InputBufferLength; > + ControlCode = StackPtr->Parameters.DeviceIoControl.IoControlCode; > + > + FLT_ASSERT(ControlCode == IOCTL_LOAD_FILTER || ControlCode == IOCTL_UNLOAD_FILTER); > + > + /* Make sure the buffer is valid */ > + if (BufferLength < sizeof(FILTER_NAME)) > + return STATUS_INVALID_PARAMETER; > + > + /* Convert the file name buffer into a string */ > + FilterName = (PFILTER_NAME)Irp->AssociatedIrp.SystemBuffer; > + Name.Length = FilterName->Length; > + Name.MaximumLength = FilterName->Length; > + Name.Buffer = (PWCH)((PCHAR)FilterName + FIELD_OFFSET(FILTER_NAME, FilterName[0])); You're missing a check for BufferLength < FIELD_OFFSET(FILTER_NAME, FilterName[FilterName->Length / sizeof(WCHAR)]) > + > + /* Forward the request to our Flt routines */ > + if (ControlCode == IOCTL_LOAD_FILTER) > + { > + return FltLoadFilter(&Name); > + } > + else > + { > + return FltUnloadFilter(&Name); > + } > +}

8 years

Re: [ros-dev] where is the final report for AHCI GSoC?

by Alex Ionescu

Hi Alexander, All the check-ins were mirrored in our SVN repository branch, and the official GSOC page has a link to the Wiki. Best regards, Alex Ionescu On Sun, Sep 4, 2016 at 2:57 AM, Alexander Rechitskiy <art1st-tm(a)yandex.ru> wrote: > Thank you for prompt answer. > Me and some other ppl have worried about getting not so much news about > progress of this project as we expected. I did not know that you have > decided to use github for final report. > > 04.09.2016, 12:47, "Aman Priyadarshi" <aman.eureka(a)gmail.com>: > > Hi, > > Please read the wiki page > https://github.com/amaneureka/reactos/wiki/Storahci > > Link is also available of GSoC website. > ᐧ > > > Regards > *Aman Priyadarshi* > *www.atomixos.com <http://www.atomixos.com/>* > > On Sun, Sep 4, 2016 at 3:07 PM, Alexander Rechitskiy <art1st-tm(a)yandex.ru> > wrote: > > > > 04.09.2016, 12:09, "Alexander Rechitskiy" art1st-tm(a)yandex.ru: > > > > Have we failed this project? > > > > > As I know, project was NOT failed! I just wanted to read the final report. > > -- > Best regards, > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > , > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > > > -- > Best regards, > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > >

8 years

where is the final report for AHCI GSoC?

by Alexander Rechitskiy

8 years

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev September 2016